Do we need different window hints for the docks and the toolbox?

[Martin Nordholts-2]

Hi,

In Edit->Preferences->Window Management you can set the window hint on
the toolbox and the docks separately. Do we really need this kind of
granularity? Isn't it enough to only have one window hint setting and
use that for both the toolbox and the docks? I can't come up with a
use case where two different hints are necessary. If we can use a
single hint option than both the preference UI and the code can be
simplified.

The commit [1] that introduced the hint concept doesn't explain why
two separate options were added. Do you remember your reasons for
doing this Sven?

Regards,
Martin

[1] commit 5a43e55c507ba505c3f0e3602bf82bbc06834ae3
    Author: Sven Neumann <sven@...>
    Date:   Thu Nov 20 20:36:55 2003 +0000

--

My GIMP Blog:
http://www.chromecode.com/



_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Martin Nordholts-2]

On 09/09/2009 07:10 PM, Martin Nordholts wrote:
> The commit [1] that introduced the hint concept doesn't explain why
> two separate options were added. Do you remember your reasons for
> doing this Sven?

Drc reminded me of that once upon a time the toolbox was the main
window. Since that is not the case any longer, let's get rid of
the toolbox specific hint and use the dock hint also for the toolbox.

 / Martin

--

My GIMP Blog:
http://www.chromecode.com/

_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Martin Nordholts-2]

On 09/09/2009 10:56 PM, Martin Nordholts wrote:
> Drc reminded me of that once upon a time the toolbox was the main
> window. Since that is not the case any longer, let's get rid of
> the toolbox specific hint and use the dock hint also for the toolbox.

I've done this now:

commit e1faf82e7d9a9dd31c5e7e88abc45c92b3cc603b
Author: Martin Nordholts <martinn@...>
Date:   Wed Sep 9 23:34:18 2009 +0200

    Get rid of toolbox-window-hint, use dock-window-hint instead

    Since the toolbox no longer is the main window with a menu, use the
    same hint for the toolbox (which actually is a dock) as for the other
    docks.

 / Martin

--

My GIMP Blog:
http://www.chromecode.com/

_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer