Duplicate forms
|
View:
New views
13 Messages
—
Rating Filter:
Alert me
|
 |
Duplicate forms
by Rouslan Placella
::
Rate this Message:
Hi all,
Quick question: why do we have two forms for renaming a table on tbl_operations.php? Can one be dropped? Please see attached screenshot for the location of forms. Bye, Rouslan ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Michal Čihař
::
Rate this Message:
Hi
Dne Fri, 03 Aug 2012 11:28:31 +0200 Rouslan Placella <rouslan@...> napsal(a): > Quick question: why do we have two forms for renaming a table on > tbl_operations.php? Can one be dropped? Please see attached screenshot > for the location of forms. The difference is probably in implementation - in same database, you can use just RENAME, for moving data to other database, this might fail, so basically it's CREATE TABLE and INSERT .. SELECT. Still it would be better to merge these and use RENAME when possible and fallback to complex method if needed. -- Michal Čihař | http://cihar.com | http://blog.cihar.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Marc Delisle-2
::
Rate this Message:
Michal Čihař a écrit :
> Hi > > Dne Fri, 03 Aug 2012 11:28:31 +0200 > Rouslan Placella <rouslan@...> napsal(a): > >> Quick question: why do we have two forms for renaming a table on >> tbl_operations.php? Can one be dropped? Please see attached screenshot >> for the location of forms. > > The difference is probably in implementation - in same database, you > can use just RENAME, for moving data to other database, this might > fail, so basically it's CREATE TABLE and INSERT .. SELECT. > > Still it would be better to merge these and use RENAME when possible > and fallback to complex method if needed. I'm not sure these should be merged. In the mind of some users, renaming and moving are different actions. -- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Rouslan Placella
::
Rate this Message:
On 03/08/2012 14:19, Marc Delisle wrote:
> Michal Čihař a écrit : >> Hi >> >> Dne Fri, 03 Aug 2012 11:28:31 +0200 >> Rouslan Placella <rouslan@...> napsal(a): >> >>> Quick question: why do we have two forms for renaming a table on >>> tbl_operations.php? Can one be dropped? Please see attached screenshot >>> for the location of forms. Well, I have a dilemma about this form in my branch. With the "rename" functionality in the table options form, a dedicated ajax handler is necessary for it to work. Without, the form can be handled by a generic page loading mechanism, which means less code and a more maintainable solution. >> The difference is probably in implementation - in same database, you >> can use just RENAME, for moving data to other database, this might >> fail, so basically it's CREATE TABLE and INSERT .. SELECT. I see, it sounds a bit more complicated than I was hoping for. >> Still it would be better to merge these and use RENAME when possible >> and fallback to complex method if needed. > > I'm not sure these should be merged. In the mind of some users, renaming > and moving are different actions. Then we could call it "rename/move"... ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Marc Delisle-2
::
Rate this Message:
Rouslan Placella a écrit :
> On 03/08/2012 14:19, Marc Delisle wrote: >> Michal Čihař a écrit : >>> Hi >>> >>> Dne Fri, 03 Aug 2012 11:28:31 +0200 >>> Rouslan Placella <rouslan@...> napsal(a): >>> >>>> Quick question: why do we have two forms for renaming a table on >>>> tbl_operations.php? Can one be dropped? Please see attached screenshot >>>> for the location of forms. > > Well, I have a dilemma about this form in my branch. With the "rename" > functionality in the table options form, a dedicated ajax handler is > necessary for it to work. Without, the form can be handled by a generic > page loading mechanism, which means less code and a more maintainable > solution. > >>> The difference is probably in implementation - in same database, you >>> can use just RENAME, for moving data to other database, this might >>> fail, so basically it's CREATE TABLE and INSERT .. SELECT. > > I see, it sounds a bit more complicated than I was hoping for. > >>> Still it would be better to merge these and use RENAME when possible >>> and fallback to complex method if needed. >> I'm not sure these should be merged. In the mind of some users, renaming >> and moving are different actions. > > Then we could call it "rename/move"... I would be happy with that. It would have the added benefit of removing the rename table dialog from the table options fieldset, where it does not really belong. -- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Marc Delisle-2
::
Rate this Message:
Marc Delisle a écrit :
> Rouslan Placella a écrit : >> On 03/08/2012 14:19, Marc Delisle wrote: >>> Michal Čihař a écrit : >>>> Hi >>>> >>>> Dne Fri, 03 Aug 2012 11:28:31 +0200 >>>> Rouslan Placella <rouslan@...> napsal(a): >>>> >>>>> Quick question: why do we have two forms for renaming a table on >>>>> tbl_operations.php? Can one be dropped? Please see attached screenshot >>>>> for the location of forms. >> Well, I have a dilemma about this form in my branch. With the "rename" >> functionality in the table options form, a dedicated ajax handler is >> necessary for it to work. Without, the form can be handled by a generic >> page loading mechanism, which means less code and a more maintainable >> solution. >> >>>> The difference is probably in implementation - in same database, you >>>> can use just RENAME, for moving data to other database, this might >>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT. >> I see, it sounds a bit more complicated than I was hoping for. >> >>>> Still it would be better to merge these and use RENAME when possible >>>> and fallback to complex method if needed. >>> I'm not sure these should be merged. In the mind of some users, renaming >>> and moving are different actions. >> Then we could call it "rename/move"... > > I would be happy with that. It would have the added benefit of removing > the rename table dialog from the table options fieldset, where it does > not really belong. > -- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Rouslan Placella
::
Rate this Message:
On 03/08/2012 17:43, Marc Delisle wrote:
> Marc Delisle a écrit : >> Rouslan Placella a écrit : >>> On 03/08/2012 14:19, Marc Delisle wrote: >>>> Michal Čihař a écrit : >>>>> Hi >>>>> >>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200 >>>>> Rouslan Placella <rouslan@...> napsal(a): >>>>> >>>>>> Quick question: why do we have two forms for renaming a table on >>>>>> tbl_operations.php? Can one be dropped? Please see attached screenshot >>>>>> for the location of forms. >>> Well, I have a dilemma about this form in my branch. With the "rename" >>> functionality in the table options form, a dedicated ajax handler is >>> necessary for it to work. Without, the form can be handled by a generic >>> page loading mechanism, which means less code and a more maintainable >>> solution. >>> >>>>> The difference is probably in implementation - in same database, you >>>>> can use just RENAME, for moving data to other database, this might >>>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT. >>> I see, it sounds a bit more complicated than I was hoping for. >>> >>>>> Still it would be better to merge these and use RENAME when possible >>>>> and fallback to complex method if needed. >>>> I'm not sure these should be merged. In the mind of some users, renaming >>>> and moving are different actions. >>> Then we could call it "rename/move"... >> >> I would be happy with that. It would have the added benefit of removing >> the rename table dialog from the table options fieldset, where it does >> not really belong. >> > By the way, Thilina is refactoring db and tbl operations these days... Sounds like one of us will have a few conflicts to resolve. I already have some committed changes in those areas. When does he expect to finish up with that? ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Rouslan Placella
::
Rate this Message:
On 03/08/2012 17:45, Rouslan Placella wrote:
> On 03/08/2012 17:43, Marc Delisle wrote: >> Marc Delisle a écrit : >>> Rouslan Placella a écrit : >>>> On 03/08/2012 14:19, Marc Delisle wrote: >>>>> Michal Čihař a écrit : >>>>>> Hi >>>>>> >>>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200 >>>>>> Rouslan Placella <rouslan@...> napsal(a): >>>>>> >>>>>>> Quick question: why do we have two forms for renaming a table on >>>>>>> tbl_operations.php? Can one be dropped? Please see attached screenshot >>>>>>> for the location of forms. >>>> Well, I have a dilemma about this form in my branch. With the "rename" >>>> functionality in the table options form, a dedicated ajax handler is >>>> necessary for it to work. Without, the form can be handled by a generic >>>> page loading mechanism, which means less code and a more maintainable >>>> solution. >>>> >>>>>> The difference is probably in implementation - in same database, you >>>>>> can use just RENAME, for moving data to other database, this might >>>>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT. >>>> I see, it sounds a bit more complicated than I was hoping for. >>>> >>>>>> Still it would be better to merge these and use RENAME when possible >>>>>> and fallback to complex method if needed. >>>>> I'm not sure these should be merged. In the mind of some users, renaming >>>>> and moving are different actions. >>>> Then we could call it "rename/move"... >>> >>> I would be happy with that. It would have the added benefit of removing >>> the rename table dialog from the table options fieldset, where it does >>> not really belong. >>> >> By the way, Thilina is refactoring db and tbl operations these days... > > Sounds like one of us will have a few conflicts to resolve. I already > have some committed changes in those areas. When does he expect to > finish up with that? Or did you mean asking Thilina to look into this? ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: ***SPAM*** Re: Duplicate forms
by Marc Delisle-2
::
Rate this Message:
Rouslan Placella a écrit :
> On 03/08/2012 17:45, Rouslan Placella wrote: >> On 03/08/2012 17:43, Marc Delisle wrote: >>> Marc Delisle a écrit : >>>> Rouslan Placella a écrit : >>>>> On 03/08/2012 14:19, Marc Delisle wrote: >>>>>> Michal Čihař a écrit : >>>>>>> Hi >>>>>>> >>>>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200 >>>>>>> Rouslan Placella <rouslan@...> napsal(a): >>>>>>> >>>>>>>> Quick question: why do we have two forms for renaming a table on >>>>>>>> tbl_operations.php? Can one be dropped? Please see attached screenshot >>>>>>>> for the location of forms. >>>>> Well, I have a dilemma about this form in my branch. With the "rename" >>>>> functionality in the table options form, a dedicated ajax handler is >>>>> necessary for it to work. Without, the form can be handled by a generic >>>>> page loading mechanism, which means less code and a more maintainable >>>>> solution. >>>>> >>>>>>> The difference is probably in implementation - in same database, you >>>>>>> can use just RENAME, for moving data to other database, this might >>>>>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT. >>>>> I see, it sounds a bit more complicated than I was hoping for. >>>>> >>>>>>> Still it would be better to merge these and use RENAME when possible >>>>>>> and fallback to complex method if needed. >>>>>> I'm not sure these should be merged. In the mind of some users, renaming >>>>>> and moving are different actions. >>>>> Then we could call it "rename/move"... >>>> I would be happy with that. It would have the added benefit of removing >>>> the rename table dialog from the table options fieldset, where it does >>>> not really belong. >>>> >>> By the way, Thilina is refactoring db and tbl operations these days... >> Sounds like one of us will have a few conflicts to resolve. I already >> have some committed changes in those areas. When does he expect to >> finish up with that? > > Or did you mean asking Thilina to look into this? I only meant that you two guys should talk to each other, especially if you already have changes in your tree about the operations stuff. It's up to him if he wants to merge these two dialogs; it was not planned in his schedule. -- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Thilina Buddika Abeyrathna
::
Rate this Message:
On Fri, Aug 3, 2012 at 10:24 PM, Rouslan Placella <rouslan@...> wrote: --
Hi, For the moment, I have done some refactoring for both rename table and move table operations in my tree, Regards. Thilina Abeyrathna Gtalk : thilinaabeyrathna skype: thilinabuddika88
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: ***SPAM*** Re: Duplicate forms
by Rouslan Placella
::
Rate this Message:
On 03/08/2012 19:48, Marc Delisle wrote:
> Rouslan Placella a écrit : > >> On 03/08/2012 17:45, Rouslan Placella wrote: >>> On 03/08/2012 17:43, Marc Delisle wrote: >>>> Marc Delisle a écrit : >>>>> Rouslan Placella a écrit : >>>>>> On 03/08/2012 14:19, Marc Delisle wrote: >>>>>>> Michal Čihař a écrit : >>>>>>>> Hi >>>>>>>> >>>>>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200 >>>>>>>> Rouslan Placella <rouslan@...> napsal(a): >>>>>>>> >>>>>>>>> Quick question: why do we have two forms for renaming a table on >>>>>>>>> tbl_operations.php? Can one be dropped? Please see attached screenshot >>>>>>>>> for the location of forms. >>>>>> Well, I have a dilemma about this form in my branch. With the "rename" >>>>>> functionality in the table options form, a dedicated ajax handler is >>>>>> necessary for it to work. Without, the form can be handled by a generic >>>>>> page loading mechanism, which means less code and a more maintainable >>>>>> solution. >>>>>> >>>>>>>> The difference is probably in implementation - in same database, you >>>>>>>> can use just RENAME, for moving data to other database, this might >>>>>>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT. >>>>>> I see, it sounds a bit more complicated than I was hoping for. >>>>>> >>>>>>>> Still it would be better to merge these and use RENAME when possible >>>>>>>> and fallback to complex method if needed. >>>>>>> I'm not sure these should be merged. In the mind of some users, renaming >>>>>>> and moving are different actions. >>>>>> Then we could call it "rename/move"... >>>>> I would be happy with that. It would have the added benefit of removing >>>>> the rename table dialog from the table options fieldset, where it does >>>>> not really belong. >>>>> >>>> By the way, Thilina is refactoring db and tbl operations these days... >>> Sounds like one of us will have a few conflicts to resolve. I already >>> have some committed changes in those areas. When does he expect to >>> finish up with that? >> >> Or did you mean asking Thilina to look into this? > > I only meant that you two guys should talk to each other, especially if > you already have changes in your tree about the operations stuff. > > It's up to him if he wants to merge these two dialogs; it was not > planned in his schedule. Fair enough, as he said that he already did refactoring work on these forms, I think that I'll just write a dedicated ajax handler for them as to avoid further merge conflicts. I'll look into this issue once again after all the merges, when the table operations code will ve stable. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Rouslan Placella
::
Rate this Message:
On 04/08/2012 01:39, Thilina Buddika Abeyrathna wrote:
> > > On Fri, Aug 3, 2012 at 10:24 PM, Rouslan Placella <rouslan@... > <mailto:rouslan@...>> wrote: > > On 03/08/2012 17:45, Rouslan Placella wrote: > > On 03/08/2012 17:43, Marc Delisle wrote: > >> Marc Delisle a écrit : > >>> Rouslan Placella a écrit : > >>>> On 03/08/2012 14:19, Marc Delisle wrote: > >>>>> Michal Čihař a écrit : > >>>>>> Hi > >>>>>> > >>>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200 > >>>>>> Rouslan Placella <rouslan@... > <mailto:rouslan@...>> napsal(a): > >>>>>> > >>>>>>> Quick question: why do we have two forms for renaming a > table on > >>>>>>> tbl_operations.php? Can one be dropped? Please see attached > screenshot > >>>>>>> for the location of forms. > >>>> Well, I have a dilemma about this form in my branch. With the > "rename" > >>>> functionality in the table options form, a dedicated ajax > handler is > >>>> necessary for it to work. Without, the form can be handled by > a generic > >>>> page loading mechanism, which means less code and a more > maintainable > >>>> solution. > >>>> > >>>>>> The difference is probably in implementation - in same > database, you > >>>>>> can use just RENAME, for moving data to other database, this > might > >>>>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT. > >>>> I see, it sounds a bit more complicated than I was hoping for. > >>>> > >>>>>> Still it would be better to merge these and use RENAME when > possible > >>>>>> and fallback to complex method if needed. > >>>>> I'm not sure these should be merged. In the mind of some > users, renaming > >>>>> and moving are different actions. > >>>> Then we could call it "rename/move"... > >>> > >>> I would be happy with that. It would have the added benefit of > removing > >>> the rename table dialog from the table options fieldset, where > it does > >>> not really belong. > >>> > >> By the way, Thilina is refactoring db and tbl operations these > days... > > > > Sounds like one of us will have a few conflicts to resolve. I already > > have some committed changes in those areas. When does he expect to > > finish up with that? > > Or did you mean asking Thilina to look into this? > > Hi, > For the moment, I have done some refactoring for both rename table and > move table operations in my tree, Which repo/branch/commits? I don't see anything like that in https://github.com/thilinaa/phpmyadmin/commits/master Bye, Rouslan ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
|
|
Re: Duplicate forms
by Thilina Buddika Abeyrathna
::
Rate this Message:
On Sat, Aug 4, 2012 at 3:00 PM, Rouslan Placella <rouslan@...> wrote:
Some commits,
But some functions has changed for further refactoring. Regards. Thilina Abeyrathna Gtalk : thilinaabeyrathna skype: thilinabuddika88 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel |
rename-tbl.png (35K) | Free embeddable forum powered by Nabble | Forum Help |
