EditView

[Emanuel Rumpf-3]

Hi

I just wanted to fix the menu of MatrixView and
got that EditView is not being used anymore,
instead EditViewBase is inherited directly.

I wonder, what to do with the actions (createAction(..)) set up in EditView.
Move them to EditViewBase - or to MatrixView ?

Or keep EditView and just remove the few remaining gui-stuff
so it stays a class layer with some additional actions, that
MatrixView would inherit again?


Emanuel

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[cannam]

On Tue, Jul 7, 2009 at 7:26 PM, Emanuel Rumpf<xbran23@...> wrote:
> I just wanted to fix the menu of MatrixView and
> got that EditView is not being used anymore,
> instead EditViewBase is inherited directly.
>
> I wonder, what to do with the actions (createAction(..)) set up in EditView.
> Move them to EditViewBase - or to MatrixView ?

I think we need to avoid having such a heavyweight base class as the
former EditView.  It was complicated enough in the way it interacted
with each subclass to make it only harder to understand the
subclasses, not easier.  I think in hindsight that "cut-and-paste
code" is actually preferable to this.

Many of the actions remaining in EditView are extremely trivial
two-liners: check getSelection is non-null, issue a command using it.
These I think should simply be duplicated in both NotationView and
MatrixView.  (One thing I forgot to mention when discussing some of
the action functions for NotationView earlier is that I think there's
absolutely no value in setting the status bar message while we carry
out such a trivial operation -- all those TmpStatusMsg objects should
go.)

The insert tempo/timesig actions are a bit less clear-cut -- possibly
the functions themselves are simply too complicated; where else should
that work be done?


Chris

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[Emanuel Rumpf-3]

2009/7/7 Chris Cannam <cannam@...>:
> These I think should simply be duplicated in both NotationView and
> MatrixView.
Ok, I will do that.
I prefer a simple class hierarchy too, unless there's obvious reason to deviate.
>
> The insert tempo/timesig actions are a bit less clear-cut -- possibly
> the functions themselves are simply too complicated; where else should
> that work be done?
>
I'll have to see..

Thanks
Emanuel

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[D. Michael McIntyre-3]

On Tuesday 07 July 2009, Emanuel Rumpf wrote:

> I just wanted to fix the menu of MatrixView and

If you can figure out why my new toolbar and menu actions aren't showing up,
I've spent even more time on it and gotten nowhere.  I'm missing something
critical, obviously, but I don't know what.

It really was all intended to be more of a quick experiment than anything I
expected to eat two days of crawling through the code scratching my head.  I
might not even like this new toolbar idea, which is why I wanted to do it on
the cheap first.
--
D. Michael McIntyre

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel