Error in handling URLs when writing lmx files

View: New views
2 Messages — Rating Filter:   Alert me  

Error in handling URLs when writing lmx files

by Christian Bühler :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello,

I think I found a bug in lmx.c. The URLs are not properly escaped.
I have attached a little patch.

Please be kind to me if I did something wrong, this is the first time
ever I am submitting a patch to an open source project.

Regards,
Christian Bühler

[lmx_url.patch]

Index: lmx.c
===================================================================
RCS file: /cvsroot/gpsbabel/gpsbabel/lmx.c,v
retrieving revision 1.4
diff -r1.4 lmx.c
97c97
< gbfprintf(ofd, "          <lm:url>%s</lm:url>\n", wpt->url);
---
> lmx_write_xml(5, "lm:url", wpt->url);


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code@...
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

Re: Error in handling URLs when writing lmx files

by Robert Lipe-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Seems right to me.  Applied.  Thanx.

2009/9/27 Christian Bühler <christian@...>
Hello,

I think I found a bug in lmx.c. The URLs are not properly escaped.
I have attached a little patch.

Please be kind to me if I did something wrong, this is the first time
ever I am submitting a patch to an open source project.

Regards,
Christian Bühler

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code@...
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code



------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code@...
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code