Escaping more characters in portlet urls

[djencks]

In geronimo we've had some problems with ';' not getting escaped in  
some portlet urls, see PLUTO-579.  The escaping algorithm currently  
used looks really inefficient.  One of the Geronimo developers (Ivan)  
came up with a patch that looks good to me and I've applied to  
branches-1.1.x.  I think it would be appropriate for trunk as well,  
the code looks about the same.

Could one of the pluto devs more familiar with this area take a look  
and make sure I'm not missing the point before I go ahead any apply it  
to trunk?

many thanks
david jencks

[Ate Douma]

Hi David,

I looked briefly at both the PLUTO-579 patch and the current Pluto trunk PortalURLParserImpl and don't think this issue applies to trunk
anymore.
I added a more detailed comment on the issue itself: https://issues.apache.org/jira/browse/PLUTO-579

Regards,

Ate

David Jencks wrote:

> In geronimo we've had some problems with ';' not getting escaped in some
> portlet urls, see PLUTO-579.  The escaping algorithm currently used
> looks really inefficient.  One of the Geronimo developers (Ivan) came up
> with a patch that looks good to me and I've applied to branches-1.1.x.  
> I think it would be appropriate for trunk as well, the code looks about
> the same.
>
> Could one of the pluto devs more familiar with this area take a look and
> make sure I'm not missing the point before I go ahead any apply it to
> trunk?
>
> many thanks
> david jencks
>

[djencks]

Hi Ate,

I think there are still issues.... I added another comment to the issue.

thanks
david jencks

On Sep 24, 2009, at 12:56 AM, Ate Douma wrote:

> Hi David,
>
> I looked briefly at both the PLUTO-579 patch and the current Pluto  
> trunk PortalURLParserImpl and don't think this issue applies to  
> trunk anymore.
> I added a more detailed comment on the issue itself: https://issues.apache.org/jira/browse/PLUTO-579
>
> Regards,
>
> Ate
>
> David Jencks wrote:
>> In geronimo we've had some problems with ';' not getting escaped in  
>> some portlet urls, see PLUTO-579.  The escaping algorithm currently  
>> used looks really inefficient.  One of the Geronimo developers  
>> (Ivan) came up with a patch that looks good to me and I've applied  
>> to branches-1.1.x.  I think it would be appropriate for trunk as  
>> well, the code looks about the same.
>> Could one of the pluto devs more familiar with this area take a  
>> look and make sure I'm not missing the point before I go ahead any  
>> apply it to trunk?
>> many thanks
>> david jencks
>