Nabble - Exim

[Bug 909] connect() uses "wrong" addrlen in dcc.c

2009-11-12T00:34:25Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=909

Nigel Metheringham <nigel@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #1 from Nigel Metheringham <nigel@...> 2009-11-12 08:34:24 ---
CVS commit by nm4:

Correct connect() call in dcc code. Fixes: bug#909

--- CVS commit summary ---
1.589 1.590 +2 -0 - exim/exim-doc/doc-txt/ChangeLog
1.4 1.5 +2 -3 - exim/exim-src/src/dcc.c

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 909] New: connect() uses "wrong" addrlen in dcc.c

2009-11-11T14:55:58Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=909
Summary: connect() uses "wrong" addrlen in dcc.c
Product: Exim
Version: 4.69
Platform: Other
OS/Version: Linux
Status: NEW
Severity: bug
Priority: medium
Component: ACLs
AssignedTo: nigel@...
ReportedBy: wbreyha@...
CC: exim-dev@...

Created an attachment (id=343)
--> (http://bugs.exim.org/attachment.cgi?id=343)
use sizeof(serv_addr) for connect()

A user reported troubles with my dcc patch on 64bit FreeBSD.

I used
servlen = Ustrlen(serv_addr.sun_path) + sizeof(serv_addr.sun_family);
connect(sockfd, (struct sockaddr *) &serv_addr, servlen);

That doesn't work on all plattforms. I looked at some other parts of exim and
changed that to
connect(sockfd, (struct sockaddr *) &serv_addr, sizeof(serv_addr));
accordingly.

Greetings, Wolfgang

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 908] New: NetBSD3 can be g/c

2009-11-11T09:01:03Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=908
Summary: NetBSD3 can be g/c
Product: Exim
Version: N/A
Platform: Other
OS/Version: NetBSD
Status: NEW
Severity: bug
Priority: low
Component: Packaging
AssignedTo: nigel@...
ReportedBy: prlw1@...
CC: exim-dev@...

exim-src/OS/os.h-NetBSD3 and exim-src/OS/Makefile-NetBSD3 may be removed, and
associated vestiges in exim-src/scripts/os-type (cf patch) tidied away.

os.h-NetBSD3 defines HAVE_SETCLASSCONTEXT which is no longer used by exim, and
setclasscontext() lives in libutil, which is why Makefile-NetBSD3 has the extra
-lutil linker flag.

I see that since I looked into this last year, SIOCGIFCONF_GIVES_ADDR has come
into being, which means that os.h-NetBSD3 is out-of-date too.

(I think the last debate around SIOCGIFCONF was roughly in NetBSD 1.4, i.e.,
way before NetBSD 3 - this is a different issue to if_storage appearing in
ifreq)

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-11T09:00:14Z

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-11T08:52:23Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #9 from Serge Demonchaux <serge-exim@...> 2009-11-11 16:52:22 ---
---- Comment #8 From Nigel Metheringham 2009-11-11 15:49:14 -------
> I'm not willing to take the buildconfig.c changes unless we can ensure that
> this will not break older (or non linux/bsd) systems.
>
> Are there any 64 bit systems which have older C libraries?
> I guess this is the case since I was using Alpha based systems more
> than 15 years back...

I'm in complete agreement with you on this. We are only sure for the x86_64.

We are too close to the release to consider this change. The next time after
tests in CVS...

Now it is possible to inform in documentation of this option of compilation.

See: ISO C99: 7.8 Format conversion of integer types <inttypes.h>
/usr/include/inttypes.h

Regards,
--Serge

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-11T07:49:15Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #8 from Nigel Metheringham <nigel@...> 2009-11-11 15:49:14 ---
I'm not willing to take the buildconfig.c changes unless we can ensure that
this will not break older (or non linux/bsd) systems.

Are there any 64 bit systems which have older C libraries?
I guess this is the case since I was using Alpha based systems more
than 15 years back...

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-11T07:14:14Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #7 from Serge Demonchaux <serge-exim@...> 2009-11-11 15:14:14 ---
> More signed/unsigned fixes. Need confirmation that this completely deals
> with bug. Related: bug#905

src/dns.c ===> OK
src/dcc.c ===> OK
src/malware.c ===> OK
src/mime.c ===> OK
src/receive.c ===> OK
src/spf.c ===> OK
src/lookups/spf.c ===> OK

------- Comment #6 From Nigel Metheringham 2009-11-11 14:45:03
> We need to change those config.h changes to a Makefile or buildconfig.c
> patch.

...or to leave the choie to the packager? I would not be to answer.
Call the list about this ?

See more about 'off_t' with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
<http://lists.freebsd.org/pipermail/freebsd-arch/2005-December/004685.html>

In Linux x86 with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == i686
sizeof(test_off_t) == 8

In Linux x86 withOUT "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == i686
sizeof(test_off_t) == 4

In Linux x86_64 with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == x86_64
sizeof(test_off_t) == 8

=============start=====================
--- exim-4.70/src/buildconfig.c.ORI 2009-11-11 15:05:15 +0100
+++ exim-4.70/src/buildconfig.c 2009-11-11 15:05:33 +0100
@@ -147,8 +147,8 @@
fprintf(new, "#ifndef OFF_T_FMT\n");
if (sizeof(test_off_t) > 4)
{
- fprintf(new, "#define OFF_T_FMT \"%%lld\"\n");
- fprintf(new, "#define LONGLONG_T long long int\n");
+ fprintf(new, "#define OFF_T_FMT \"%%\" PRIi64\n");
+ fprintf(new, "#define LONGLONG_T int64_t\n");
}
else
{
@@ -165,9 +165,9 @@
fprintf(new, "#ifndef TIME_T_FMT\n");
if (sizeof(test_time_t) > 4)
{
- fprintf(new, "#define TIME_T_FMT \"%%lld\"\n");
+ fprintf(new, "#define TIME_T_FMT \"%%\" PRIi64\n");
fprintf(new, "#undef LONGLONG_T\n");
- fprintf(new, "#define LONGLONG_T long long int\n");
+ fprintf(new, "#define LONGLONG_T int64_t\n");
}
else
{
=============end=====================

Best regards,
--Serge

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-11T06:45:03Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #6 from Nigel Metheringham <nigel@...> 2009-11-11 14:45:03 ---
We need to change those config.h changes to a Makefile or buildconfig.c
patch.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-11T06:43:29Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #5 from Nigel Metheringham <nigel@...> 2009-11-11 14:43:29 ---
CVS commit by nm4:

More signed/unsigned fixes. Need confirmation that this completely deals with
bug. Related: bug#905

--- CVS commit summary ---
1.2 1.3 +2 -2 - exim/exim-src/src/lookups/spf.c

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-11T05:29:49Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

Serge Demonchaux <serge-exim@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |serge-exim@...

--- Comment #4 from Serge Demonchaux <serge-exim@...> 2009-11-11 13:29:48 ---
Very good.

src/dns.c ===> OK
src/dcc.c ===> OK
src/malware.c ===> OK
src/mime.c ===> OK
src/receive.c ===> OK
src/spf.c ===> OK

I'm missed this 'src/lookups/spf.c'
========================
--- /caos.dev/usr/src/rpm/BUILD/exim-4.70CVS/src/lookups/spf.c.ORI 2009-11-11
12:00:26 +0100
+++ /caos.dev/usr/src/rpm/BUILD/exim-4.70CVS/src/lookups/spf.c 2009-11-11
12:00:17 +0100
@@ -59,11 +59,11 @@
return FAIL;
}

- if (SPF_request_set_ipv4_str(spf_request, filename)) {
+ if (SPF_request_set_ipv4_str(spf_request, CS filename)) {
*errmsg = string_sprintf("invalid IP address '%s'", filename);
return FAIL;
}
- if (SPF_request_set_env_from(spf_request, keystring)) {
+ if (SPF_request_set_env_from(spf_request, CS keystring)) {
*errmsg = string_sprintf("invalid envelope from address '%s'",
keystring);
return FAIL;
}
========================

With Linux i386 + GCC (-Wall), Exim is compiled well. On the x86_64
AMD , there are problems with 'off_t': (build-Linux-x86_64/config.h)

#ifndef OFF_T_FMT
#define OFF_T_FMT "%lld"
#define LONGLONG_T long long int
#endif

[...]
appendfile.c:2641: warning: format '%lld' expects type 'long long int', but
argument 3 has type 'off_t'
[...]

by changing the definitions, i have no warnings

build-Linux-x86_64/config.h:

--- exim-4.70/build-Linux-x86_64/config.h.ORI 2009-11-11 14:24:47 +0100
+++ exim-4.70/build-Linux-x86_64/config.h 2009-11-11 14:25:54 +0100
@@ -7,12 +7,12 @@
Do not edit it. Instead, edit Local/Makefile and rerun make. */

#ifndef OFF_T_FMT
-#define OFF_T_FMT "%lld"
+#define OFF_T_FMT "%" PRIi64
#define LONGLONG_T int64_t
#endif

#ifndef TIME_T_FMT
-#define TIME_T_FMT "%lld"
+#define TIME_T_FMT "%" PRIi64
#undef LONGLONG_T
#define LONGLONG_T int64_t
#endif

Regards,
--Serge

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-11T02:08:04Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #3 from Nigel Metheringham <nigel@...> 2009-11-11 10:08:03 ---
CVS commit by nm4:

Applied signed/unsigned fixes. Need confirmation that this completely deals
with bug. Related: bug#905

--- CVS commit summary ---
1.3 1.4 +12 -32 - exim/exim-src/src/dcc.c
1.19 1.20 +1 -1 - exim/exim-src/src/dns.c
1.17 1.18 +1 -1 - exim/exim-src/src/malware.c
1.18 1.19 +2 -2 - exim/exim-src/src/mime.c
1.50 1.51 +3 -2 - exim/exim-src/src/receive.c
1.8 1.9 +5 -5 - exim/exim-src/src/spf.c

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 907] New: Build errors on Mac OS X 10.6.2

2009-11-10T09:15:31Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=907
Summary: Build errors on Mac OS X 10.6.2
Product: Exim
Version: 4.69
Platform: Other
OS/Version: All
Status: NEW
Severity: bug
Priority: medium
Component: Unfiled
AssignedTo: nigel@...
ReportedBy: nigel@...
CC: exim-dev@...

The following warnings are generated when compiling on Mac OS X 10.6.2

exim.c: In function ‘exim_wait_tick’:
exim.c:336: warning: format ‘%06lu’ expects type ‘long unsigned int’,
but argument 3 has type ‘__darwin_suseconds_t’
exim.c:336: warning: format ‘%06lu’ expects type ‘long unsigned int’,
but argument 5 has type ‘__darwin_suseconds_t’
exim.c:338: warning: format ‘%06lu’ expects type ‘long unsigned int’,
but argument 3 has type ‘__darwin_suseconds_t’
exim.c: In function ‘show_whats_supported’:
exim.c:1057: warning: format ‘%d’ expects type ‘int’, but argument 3
has type ‘long unsigned int’

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email
--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 636] retry timeout exceeded 450 bug?

2009-11-10T08:33:49Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=636

Thorsten Meinl <Thorsten@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |Thorsten@...-
| |bamberg.de

--- Comment #13 from Thorsten Meinl <Thorsten@...> 2009-11-10 16:33:48 ---
We have the same problem over here and to mee it occurs if this has to do with
several MX hosts for a mail domain. We had some cases recently where the first
tried MX hosts returned back a 450 due to greylisting and the last two refused
the connection completely. After that the mail instantly went into "retry
timeout exceeded" and was bounced back. Could it be, that the "Connection
refused" errors for the host are adding up so that at some time it leads to
immediate bounces even if some other MX hosts only defer the mail?

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Exim 4.70: Release Candidate 4

2009-11-10T08:30:45Z

This RC is mainly to test that my release scripts and documentation building stuff are working correctly, so the comments in the RC3 announcement at
http://lists.exim.org/lurker/message/20091108.135427.c4301a28.en.html

still apply.

The differences from RC3 are:-
- the tar balls were built with the release scripts, so should be right!
- all documentation has been generated.
- Bugs 902, 904 (compiler and documentation issues - no functional changes)

The source can be obtained from either CVS or git, however it would be more useful to pick up the tarball from ftp://ftp.exim.org/pub/exim/exim4/ instead as I need to ensure there are no problems with the source and documentation generation. The RCs will go out to mirror sites as they update.

There is one bug already (!) reported against RC4 - 905 - which fixes some compiler warnings.

Nigel.

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 906] exim 4.70rc4 dkim_cur_signer empty if no sig

2009-11-10T08:10:26Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=906

Wolfgang Breyha <wbreyha@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |WORKSFORME

--- Comment #1 from Wolfgang Breyha <wbreyha@...> 2009-11-10 16:10:25 ---
Sorry, my fault.

I used ${domain:$dkim_cur_signer} ... which is empty since no "@" is found.

Wolfgang

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 906] New: exim 4.70rc4 dkim_cur_signer empty if no sig

2009-11-10T07:56:54Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=906
Summary: exim 4.70rc4 dkim_cur_signer empty if no sig
Product: Exim
Version: N/A
Platform: Other
OS/Version: Linux
Status: NEW
Severity: bug
Priority: medium
Component: ACLs
AssignedTo: nigel@...
ReportedBy: wbreyha@...
CC: exim-dev@...

Hi!

I set
dkim_verify_signers = $sender_address_domain:$dkim_signers
in my config as described in the documentation.

If $sender_address_domain contains a domain for which no signature is available
acl_smtp_dkim is called, but $dkim_cur_signer is empty.

This makes it impossible to check for eg. adsp records.

$dkim_verify_status is correctly set to "none".

Regards, Wolfgang

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Re: [Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-10T05:46:47Z

Le Tuesday 10 November 2009 14:09:34 Wolfgang Breyha, vous avez écrit :

> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
>
> http://bugs.exim.org/show_bug.cgi?id=905
>
>
>
>
> --- Comment #2 from Wolfgang Breyha <wbreyha@...> 2009-11-10 13:09:34
> --- Created an attachment (id=342)
> --> (http://bugs.exim.org/attachment.cgi?id=342)
> dcc.c fixes (unused variables, pointer fix)
>
>
> --
> Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

Hi,

with your last patch, it still remains:

312c312
< debug_printf("\n****************************\n", sendbuf);
---
> debug_printf("\n****************************\n%s", sendbuf);
363c363
< while(resp = read(sockfd, recvbuf, sizeof(recvbuf)-1) > 0) {
---
> while((resp = read(sockfd, recvbuf, sizeof(recvbuf)-1)) > 0) {
388c388
< dcc_result = "A";
---
> dcc_result = US"A";
394c394
< dcc_result = "R";
---
> dcc_result = US"R";
410c410
< dcc_result = "A";
---
> dcc_result = US"A";
417c417
< dcc_result = "G";
---
> dcc_result = US"G";
426c426
< dcc_result = "T";
---
> dcc_result = US"T";
434c434
< dcc_result = "T";
---
> dcc_result = US"T";
500c500
< if (((xtra_hdrs = expand_string("$acl_m_dcc_add_header")) != NULL) &&
(xtra_hdrs[0] != '\0')) {
---
> if (((xtra_hdrs = expand_string(US"$acl_m_dcc_add_header")) != NULL) &&
(xtra_hdrs[0] != '\0')) {

---------------------------------------
Regards
--Serge

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-10T05:09:34Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #2 from Wolfgang Breyha <wbreyha@...> 2009-11-10 13:09:34 ---
Created an attachment (id=342)
--> (http://bugs.exim.org/attachment.cgi?id=342)
dcc.c fixes (unused variables, pointer fix)

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-10T05:08:19Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

Wolfgang Breyha <wbreyha@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |wbreyha@...

--- Comment #1 from Wolfgang Breyha <wbreyha@...> 2009-11-10 13:08:19 ---
I fixed the rest of "-W all" warnings for dcc.c. patch attached. patch is
against >exim-4.70-CVS.2009.11.09-differ_in_signedness.patch< !

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 905] New: Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

2009-11-10T04:31:43Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905
Summary: Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09
18:29:22 +0100)
Product: Exim
Version: N/A
Platform: All
OS/Version: Linux
Status: NEW
Severity: bug
Priority: medium
Component: Packaging
AssignedTo: nigel@...
ReportedBy: serge-exim@...
CC: exim-dev@...

Created an attachment (id=341)
--> (http://bugs.exim.org/attachment.cgi?id=341)
exim-4.70-CVS.2009.11.09-differ_in_signedness.patch

* Typo, signed/unsigned char:

src/dns.c
src/dcc.c
src/malware.c
src/mime.c
src/receive.c
src/spf.c

* Unused variables in src/dcc.c: (this patch NOT remove variables)

src/dcc.c:96: warning: unused variable 'pollfd'
src/dcc.c:94: warning: unused variable 'server'
src/dcc.c:93: warning: unused variable 'start'
src/dcc.c:92: warning: unused variable 'override'
src/dcc.c:91: warning: unused variable 'q'
src/dcc.c:91: warning: unused variable 'p'
src/dcc.c:90: warning: unused variable 'offset'
src/dcc.c:85: warning: unused variable 'dcc_rcpt'
src/dcc.c:62: warning: unused variable 'dcc_request'
src/dcc.c:61: warning: unused variable 'dcc_daemon_port'
src/dcc.c:59: warning: unused variable 'dcc_buffer'
src/dcc.c:58: warning: unused variable 'dcc_sock'
src/dcc.c:56: warning: unused variable 'mbox_size'
src/dcc.c:55: warning: unused variable 'user_name_buffer'
src/dcc.c:54: warning: unused variable 'body_begin'
src/dcc.c:53: warning: unused variable 'user_name'

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 904] Absolute path in XSL files

2009-11-09T12:11:19Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=904

Simon Arlott <bugzilla.exim.simon@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |bugzilla.exim.simon@...
| |rg

--- Comment #3 from Simon Arlott <bugzilla.exim.simon@...> 2009-11-09 20:11:19 ---
See http://lists.exim.org/lurker/message/20091022.233245.b69b1311.en.html for
how to fix it. Gentoo doesn't put those files in bizarre version-dependent
locations.

Recent changes mean you'd need to change the first command to:
sed -e
's:/usr/share/sgml/docbook/xsl-stylesheets-1.70.1/xhtml/chunk.xsl:/usr/share/sgml/docbook/xsl-stylesheets/xhtml/chunk.xsl:'
-i MyStyle-chunk-html.xsl

Watch out for docbook2texi, as there's both docbook-sgml-utils (which reports
lots of errors and then gives up) and docbook2X (which reports lots of warnings
but still works). It also won't exit with an error if w3m is missing.

I couldn't find an original source for sdop or xfpt so I just used Debian's
copies.

It takes forever (5 minutes) but I can now "make everything" in doc-docbook.
http://s85.org/keoAWnqr

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Re: [exim-cvs] cvs commit: exim/exim-src/src dkim.c mime.c

2009-11-09T08:23:20Z

Le Monday 09 November 2009 16:51:54 Jakob Hirsch, vous avez écrit :
> S e r g e, 2009-11-09 16:21:
> > - if (bytestate & 3 != 0)
> > + if (bytestate & (3 != 0))
>
> um, no. You proably meant
>
> if ((bytestate & 3) != 0)

Thank you Jakob ;-)

Another

========= exim-4.70/src/dcc.c ===========

diff -urN exim-4.70/src/dcc.c exim-4.70.OK/src/dcc.c
--- exim-4.70/src/dcc.c 2009-10-14 20:39:24 +0200
+++ exim-4.70.OK/src/dcc.c 2009-11-09 16:58:44 +0100
@@ -329,7 +329,7 @@
Ustrncat(sendbuf, "\n", sizeof(sendbuf)-Ustrlen(sendbuf)-1);
flushbuffer(sockfd, sendbuf);
DEBUG(D_acl)
- debug_printf("\n****************************\n", sendbuf);
+ debug_printf("\n****************************\n%s", sendbuf);

/* Clear the input buffer */
bzero(sendbuf, sizeof(sendbuf));
@@ -380,7 +380,7 @@

/* Let's read from the socket until there's nothing left to read */
bzero(recvbuf, sizeof(recvbuf));
- while(resp = read(sockfd, recvbuf, sizeof(recvbuf)-1) > 0) {
+ while((resp = read(sockfd, recvbuf, sizeof(recvbuf)-1)) > 0) {
/* How much did we get from the socket */
c = Ustrlen(recvbuf) + 1;
DEBUG(D_acl)
@@ -405,13 +405,13 @@
DEBUG(D_acl)
debug_printf("Overall result = A\treturning OK\n");
Ustrcpy(dcc_return_text, "Mail accepted by DCC");
- dcc_result = "A";
+ dcc_result = US"A";
retval = OK;
}
else if(recvbuf[i] == 'R') {
DEBUG(D_acl)
debug_printf("Overall result = R\treturning FAIL\n");
- dcc_result = "R";
+ dcc_result = US"R";
retval = FAIL;
if(sender_host_name) {
log_write(0, LOG_MAIN, "H=%s [%s] F=<%s>: rejected by DCC",
sender_host_name, sender_host_address, sender_address);
@@ -427,14 +427,14 @@
Ustrcpy(dcc_return_text, "Not all recipients accepted by DCC");
/* Since we're in an ACL we want a global result
* so we accept for all */
- dcc_result = "A";
+ dcc_result = US"A";
retval = OK;
}
else if(recvbuf[i] == 'G') {
DEBUG(D_acl)
debug_printf("Overall result = G\treturning FAIL\n");
Ustrcpy(dcc_return_text, "Greylisted by DCC");
- dcc_result = "G";
+ dcc_result = US"G";
retval = FAIL;
}
else if(recvbuf[i] == 'T') {
@@ -443,7 +443,7 @@
retval = DEFER;
log_write(0,LOG_MAIN,"Temporary error with DCC: %s\n",
recvbuf);
Ustrcpy(dcc_return_text, "Temporary error with DCC");
- dcc_result = "T";
+ dcc_result = US"T";
}
else {
DEBUG(D_acl)
@@ -451,7 +451,7 @@
retval = DEFER;
log_write(0,LOG_MAIN,"Unknown DCC response: %s\n", recvbuf);
Ustrcpy(dcc_return_text, "Unknown DCC response");
- dcc_result = "T";
+ dcc_result = US"T";
}
}
else {
@@ -517,7 +517,7 @@

/* check if we should add additional headers passed in acl_m_dcc_add_header
*/
if(dcc_direct_add_header) {
- if (((xtra_hdrs = expand_string("$acl_m_dcc_add_header")) != NULL) &&
(xtra_hdrs[0] != '\0')) {
+ if (((xtra_hdrs = expand_string(US"$acl_m_dcc_add_header")) != NULL) &&
(xtra_hdrs[0] != '\0')) {
Ustrncpy(dcc_xtra_hdrs, xtra_hdrs, sizeof(dcc_xtra_hdrs) - 2);
if (dcc_xtra_hdrs[Ustrlen(dcc_xtra_hdrs)-1] != '\n')
Ustrcat(dcc_xtra_hdrs, "\n");

========= exim-4.70/src/dcc.c ===========

* Now it still remains:

dcc.c:96: warning: unused variable 'pollfd'
dcc.c:94: warning: unused variable 'server'
dcc.c:93: warning: unused variable 'start'
dcc.c:92: warning: unused variable 'override'
dcc.c:91: warning: unused variable 'q'
dcc.c:91: warning: unused variable 'p'
dcc.c:90: warning: unused variable 'offset'
dcc.c:85: warning: unused variable 'dcc_rcpt'
dcc.c:62: warning: unused variable 'dcc_request'
dcc.c:61: warning: unused variable 'dcc_daemon_port'
dcc.c:59: warning: unused variable 'dcc_buffer'
dcc.c:58: warning: unused variable 'dcc_sock'
dcc.c:56: warning: unused variable 'mbox_size'
dcc.c:55: warning: unused variable 'user_name_buffer'
dcc.c:54: warning: unused variable 'body_begin'
dcc.c:53: warning: unused variable 'user_name'

dcc.c:100: warning: 'result' is used uninitialized in this function
dcc.c:156: warning: 'portnr' may be used uninitialized in this function

Regards,
-- S e r g e

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Re: [exim-cvs] cvs commit: exim/exim-src/src dkim.c mime.c

2009-11-09T07:51:54Z

S e r g e, 2009-11-09 16:21:
> - if (bytestate & 3 != 0)
> + if (bytestate & (3 != 0))

um, no. You proably meant

if ((bytestate & 3) != 0)

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 904] Absolute path in XSL files

2009-11-09T07:49:47Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=904

--- Comment #2 from Nigel Metheringham <nigel@...> 2009-11-09 15:49:46 ---
I suspect docs for 4.68 were built on Philip's machine.

Docs for 4.69 were built on mine.

I can't find the appropriate pre-built packages for Suse 10 - xmlto
is on the opensuse build system, but has requirements that are not
fulfilled from within their packages....

What a complete crock!

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 904] Absolute path in XSL files

2009-11-09T07:31:42Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=904

--- Comment #1 from Tom Kistner <tom@...> 2009-11-09 15:31:42 ---
I changed this because the original file reference does not exist on tahini. No
idea where the docs are supposed to be built.

@Nigel: Maybe you can install the required packages on tahini? (I can't ...)

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Re: [Bug 904] New: Absolute path in XSL files

2009-11-09T07:25:45Z

On 09/11/2009, Nigel Metheringham <nigel@...> wrote:

> Unfortunately this means only Tom can produce the documentation!

Sounds like a good result :-)

--
Peter Bowyer
Email: peter@...
Follow me on Twitter: twitter.com/peeebeee

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 904] New: Absolute path in XSL files

2009-11-09T07:24:23Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=904
Summary: Absolute path in XSL files
Product: Exim
Version: 4.69
Platform: Other
OS/Version: All
Status: NEW
Severity: bug
Priority: medium
Component: Documentation
AssignedTo: tom@...
ReportedBy: nigel@...
CC: exim-dev@...

Change

http://vcs.exim.org/viewvc/exim/exim-doc/doc-docbook/MyStyle-chunk-html.xsl?r1=1.3&r2=1.4

Introduced a reference to
/home/tom/share/xml/docbook/xsl/1.73.2/xhtml/chunk.xsl

Unfortunately this means only Tom can produce the documentation!

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Re: [exim-cvs] cvs commit: exim/exim-src/src dkim.c mime.c

2009-11-09T07:21:09Z

Le Monday 09 November 2009 15:31:25 Tom Kistner, vous avez écrit :

> tom 2009/11/09 14:31:24 GMT
>
> Modified files:
> exim-src/src dkim.c mime.c
> Log:
> Make SUN compiler happy. Fixes #902
>
> Revision Changes Path
> 1.8 +1 -1 exim/exim-src/src/dkim.c
> 1.18 +1 -1 exim/exim-src/src/mime.c
>

--- exim-4.70/src/mime.c 2009-11-09 15:45:56 +0100
+++ exim-4.70.OK/src/mime.c 2009-11-09 16:04:59 +0100
@@ -106,7 +106,7 @@

opos = obuf;

- while (fgets(ibuf, MIME_MAX_LINE_LENGTH, in) != NULL)
+ while (Ufgets(ibuf, MIME_MAX_LINE_LENGTH, in) != NULL)
{
if (boundary != NULL
&& Ustrncmp(ibuf, "--", 2) == 0
@@ -153,7 +153,7 @@
return -1; /* error */
size += len;
/* copy incomplete last byte to start of obuf, where we continue */
- if (bytestate & 3 != 0)
+ if (bytestate & (3 != 0))
*obuf = *opos;
opos = obuf;
}

--- exim-4.70/src/malware.c 2009-11-05 21:58:27 +0100
+++ exim-4.70.OK/src/malware.c 2009-11-09 16:07:27 +0100
@@ -231,7 +231,7 @@
if ( Ustrstr(buf, US"<detected type=\"") != NULL ) {
detected = 1;
} else if ( detected && (strhelper = Ustrstr(buf, US"<name>")) ) {
- if (strhelper2 = (Ustrstr(buf, US"</name>"))) {
+ if ((strhelper2 = Ustrstr(buf, US"</name>")) != NULL) {
*strhelper2 = '\0';
Ustrcpy(malware_name_buffer, strhelper + 6);
}

Regards,

-- Serge
--
(o_
(/)_
S e r g e

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 902] Compilation errors with 4.70 RC3 using Sun compiler

2009-11-09T06:31:47Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=902

Tom Kistner <tom@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tom@...
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #1 from Tom Kistner <tom@...> 2009-11-09 14:31:46 ---
Fixed them. Thanks!

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Re: [exim] Exim 4.70: Release Candidate 3

2009-11-09T04:45:27Z

On Sun, 8 Nov 2009 13:54:27 +0000 Nigel Metheringham wrote:

> Announcing the 3rd Release Candidate for the exim 4.70 release - we
> intend this to be the final release candidate unless any release
> blocking bugs are discovered.
>
> The release of Exim 4.70 is on the horizon. A lot of stuff has
> accumulated in CVS since January 2008. Since we want to give the current
> code some wider exposure, please accept this invitation to test a 4.70
> pre-release. You can get the current code by pulling a snapshot from
> David's GIT shadow:
>
> git clone git://git.exim.org/exim-src.git
>
> or from the CVS - see http://wiki.exim.org/EximDevelopment
>
> In either case the RC3 is tagged with exim-4.70_RC3
>
> Or wget a tarball here:
>
> ftp://ftp.exim.org/pub/exim/exim4/exim-4.70_RC3.tar.gz

This version seems incomplete :-(

make[2]: Entering directory `/usr/local/exim/src/exim-4.70_RC3/build-Linux-i386/pdkim'
make[2]: Makefile: No such file or directory
make[2]: *** No rule to make target `Makefile'. Stop.
make[2]: Leaving directory `/usr/local/exim/src/exim-4.70_RC3/build-Linux-i386/pdkim'

Solution was to copy directory "pdkim" from .../exim-4.70-RC-20091013/src
to .../exim-4.70_RC3/src

Kind regards,
Frank Elsner

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Re: [exim] Exim 4.70: Release Candidate 3

2009-11-09T02:21:38Z

On 9 Nov 2009, at 10:06, Ian Eiloart wrote:

>
>
> --On 8 November 2009 13:54:27 +0000 Nigel Metheringham
> <nigel.metheringham@...> wrote:
>
>>
>> NM/05 Bugzilla 437: Prevent Maildix aux files being created with
>> mode 000
>
> Or, is that "Maildir"?

Yup. Its also the second (of three) changes marked NM/05

--
[ Nigel Metheringham Nigel.Metheringham@... ]
[ - Comments in this message are my own and not ITO opinion/policy - ]

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 903] exim 4.70_RC3: documentation missing

2009-11-09T02:19:00Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=903

Nigel Metheringham <nigel@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #1 from Nigel Metheringham <nigel@...> 2009-11-09 10:19:00 ---
Final release will use the standard release script, but the RC didn't as it
currently does not handle RCs and I did not want to fully regenerate all the
documentation.

The release script does generate the doc directory (which is not held within
the normal CVS source tree).

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

Re: [exim] Exim 4.70: Release Candidate 3

2009-11-09T02:06:05Z

--On 8 November 2009 13:54:27 +0000 Nigel Metheringham
<nigel.metheringham@...> wrote:

>
> NM/05 Bugzilla 437: Prevent Maildix aux files being created with
> mode 000

Or, is that "Maildir"?

--
Ian Eiloart
IT Services, University of Sussex
01273-873148 x3148
For new support requests, see http://www.sussex.ac.uk/its/help/

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 903] New: exim 4.70_RC3: documentation missing

2009-11-09T01:23:21Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=903
Summary: exim 4.70_RC3: documentation missing
Product: Exim
Version: N/A
Platform: All
OS/Version: All
Status: NEW
Severity: bug
Priority: low
Component: Documentation
AssignedTo: nigel@...
ReportedBy: jue@...
CC: exim-dev@...

the whole doc subdirectory is missing in exim 4.70_RC3. Should be added again
for the final release, because most of the distributions install at least the
man page.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev

[Bug 902] New: Compilation errors with 4.70 RC3 using Sun compiler

2009-11-09T00:33:09Z

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=902
Summary: Compilation errors with 4.70 RC3 using Sun compiler
Product: Exim
Version: 4.69
Platform: Other
OS/Version: All
Status: NEW
Severity: bug
Priority: high
Component: Packaging
AssignedTo: nigel@...
ReportedBy: nigel@...
CC: exim-dev@...

Reported by Jack Bailey

I'm compiling with Sun Studio 12 and getting quite a few warnings. CentOS-5.4.

/opt/SUNWspro/bin/cc -O -I/usr/local/include -xtarget=pentium4 -fast -v pdkim.c
"pdkim.c", line 164: warning: syntax error: empty declaration
"pdkim.c", line 175: warning: syntax error: empty declaration
"pdkim.c", line 194: warning: syntax error: empty declaration
"pdkim.c", line 209: warning: syntax error: empty declaration
"pdkim.c", line 212: warning: syntax error: empty declaration
"pdkim.c", line 217: warning: syntax error: empty declaration
"pdkim.c", line 230: warning: syntax error: empty declaration
"pdkim.c", line 235: warning: syntax error: empty declaration
"pdkim.c", line 240: warning: syntax error: empty declaration
"pdkim.c", line 291: warning: syntax error: empty declaration
"pdkim.c", line 301: warning: syntax error: empty declaration
"pdkim.c", line 404: warning: syntax error: empty declaration
"pdkim.c", line 911: warning: syntax error: empty declaration
"pdkim.c", line 979: warning: syntax error: empty declaration
"pdkim.c", line 1109: warning: syntax error: empty declaration
"pdkim.c", line 1167: warning: syntax error: empty declaration
"pdkim.c", line 1692: warning: syntax error: empty declaration
"pdkim.c", line 1699: warning: syntax error: empty declaration
"pdkim.c", line 1731: warning: syntax error: empty declaration

/opt/SUNWspro/bin/cc -O -I/usr/local/include -xtarget=pentium4 -fast -v dkim.c
"dkim.c", line 528: warning: syntax error: empty declaration

Many/most/all of these are caused by semi-colons following curly braces.

Here's another which I did not investigate:

/opt/SUNWspro/bin/cc -O -I/usr/local/include -xtarget=pentium4 -fast -v mime.c
"mime.c", line 109: warning: argument #1 is incompatible with prototype:
prototype: pointer to char : "/usr/include/stdio.h", line 532
argument : pointer to unsigned char

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

From forum: Exim Dev