Extra slashes in Locations returned from DAVRepository.getLocationsImpl

View: New views
3 Messages — Rating Filter:   Alert me  

Extra slashes in Locations returned from DAVRepository.getLocationsImpl

by gnomie :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

  after upgrading from SVNKit 1.1.7 to 1.3.0 it caught my attention that SVNLocationEntry instances returned  from repo.getLocations() sometimes have extra forward slashes in their path. I.e. SVNLocationEntry.getPath() may return something like "//trunk/bla", which made some of my code fail. The workaround is obviously easy, but nevertheless that seems to be worth a correction.

  When debugging and scanning the sources it seems that something corresponding happened in DAVLocationsHandler between the different versions of SVNKit.

  Something else, for which I have no explanation (but would like to understand) is that this problem did not show up with HTTP localhost urls, but only when using SVNKit on a remote HTTPS URL.

Thanks,
  Henning

Re: Extra slashes in Locations returned from DAVRepository.getLocationsImpl

by Alexander Sinyushkin :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello Hennig,

Thanks for this report. I've added possible fix to trunk and merged it
to the 1.3.x branch.
You can try new binaries that can be downloaded from the 1.3.x
configuration on our build server (teamcity.svnkit.com)
after tests finish.

I also wonder, with what server did you find this problem?

----
Alexander Sinyushkin,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!



Henning wrote:

> Hi,
>
>   after upgrading from SVNKit 1.1.7 to 1.3.0 it caught my attention
> that SVNLocationEntry instances returned  from repo.getLocations()
> sometimes have extra forward slashes in their path. I.e.
> SVNLocationEntry.getPath() may return something like "//trunk/bla",
> which made some of my code fail. The workaround is obviously easy, but
> nevertheless that seems to be worth a correction.
>
>   When debugging and scanning the sources it seems that something
> corresponding happened in DAVLocationsHandler between the different
> versions of SVNKit.
>
>   Something else, for which I have no explanation (but would like to
> understand) is that this problem did not show up with HTTP localhost
> urls, but only when using SVNKit on a remote HTTPS URL.
>
> Thanks,
>   Henning

---------------------------------------------------------------------
To unsubscribe, e-mail: svnkit-users-unsubscribe@...
For additional commands, e-mail: svnkit-users-help@...


Re: Extra slashes in Locations returned from DAVRepository.getLocationsImpl

by gnomie :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Alexander,

  it is a remotely hosted Apache+mod_dav_svn server.

The Apache version is 2.0.55. Not sure how to find out about the mod_dav_svn version.
The svnserve version is 1.3.1.

Thanks for the fix!
Henning


Am Mittwoch, den 29.07.2009, 21:53 +0200 schrieb Alexander Sinyushkin:
Hello Hennig,

Thanks for this report. I've added possible fix to trunk and merged it 
to the 1.3.x branch.
You can try new binaries that can be downloaded from the 1.3.x 
configuration on our build server (teamcity.svnkit.com)
after tests finish.

I also wonder, with what server did you find this problem?

----
Alexander Sinyushkin,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library! 



Henning wrote:
> Hi,
>
>   after upgrading from SVNKit 1.1.7 to 1.3.0 it caught my attention 
> that SVNLocationEntry instances returned  from repo.getLocations() 
> sometimes have extra forward slashes in their path. I.e. 
> SVNLocationEntry.getPath() may return something like "//trunk/bla", 
> which made some of my code fail. The workaround is obviously easy, but 
> nevertheless that seems to be worth a correction.
>
>   When debugging and scanning the sources it seems that something 
> corresponding happened in DAVLocationsHandler between the different 
> versions of SVNKit.
>
>   Something else, for which I have no explanation (but would like to 
> understand) is that this problem did not show up with HTTP localhost 
> urls, but only when using SVNKit on a remote HTTPS URL.
>
> Thanks,
>   Henning

---------------------------------------------------------------------
To unsubscribe, e-mail: svnkit-users-unsubscribe@...
For additional commands, e-mail: svnkit-users-help@...