Nabble - FOP - Dev

DO NOT REPLY [Bug 48293] New: Unable to extract the data from pdf file for greek fonts

2009-11-26T07:22:26Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48293

Summary: Unable to extract the data from pdf file for greek
fonts
Product: Fop
Version: all
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: critical
Priority: P1
Component: fonts
AssignedTo: fop-dev@...
ReportedBy: maruthivenugopal.bandaru@...

Created an attachment (id=24624)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24624)
it contains the problem with greek font in pdf

Hi fop dev team,
We are facing an issue for extracting data from the pdf files,
which are belongs to greece, for example, when we tried to copy the content of
pdf file in word document, it is displaying that content as square boxes.
Kindly help us on this issue.

Thanks & Regards
Maruthi

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: svn commit: r828678 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/afp: goca/ modca/ modca/triplets/

2009-11-26T06:46:38Z

Adrian Cumiskey wrote:
> Hi Chris,

Hi Adrian,

thanks for your input on this. It is appreciated.

>
> 2009/11/26 Chris Bowditch <bowditch_chris@...
> <mailto:bowditch_chris@...>>
>
> Adrian Cumiskey wrote:
>
> I agree it might be better if the AttributeQualifier triplet is
> at the end of the list as it is optional, and FullyQualifiedName
> and AttributeValue are both manditory. I would be very
> surprised if this should cause a problem as I don't believe
> there are any ordering rules for triplets. I'd be interested to
> hear how bug manifests itself?
>
>
> MO:DCA Specification dictates the order of the triplets, here:
> http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3M5M00/5.82.2?SHELF=APSBK320&DT=20010307105730
> <http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3M5M00/5.82.2?SHELF=APSBK320&DT=20010307105730>
>
>
> I don't believe that it does, this is just a list of possible applicable
> triplets for the TagLogicalElement structure field, the order in which
> they are present should not be important.

You could well be right here. Since I am not an expert on AFP I asked
Jeremias for his thoughts too. We could see nothing in the MO:DCA spec
to confirm or deny either way.

>
>
> Attribute Qualifier is the last part of TLE structured field.
>
> One of our customers has a process that extracts the TLE values
> which now fails because the 10 bytes of the AttributeQualifier occur
> in front of the value.
>
>
> I do not think that it is correct for your customer to make this
> assumption about the position of the triplet in the structured field
> data. AFAIK it is still perfectly valid AFP so long as all the
> mandatory triplets are present and all the structured field data lengths
> and triplet data lengths are present and correct. But if this patch
> fixes the problem for your client I have no problem with you applying it.

Based on what you've told me today I tend to agree that anyone writing
an AFP Parser should not assume the order of triplets matches the
specification. However, I would imagine that a lot of people writing
such a parser would tend to (incorrectly?) assume that the order of the
triplets would match that shown in the structured field definition in
the specification. So if FOP does choose to deviate from the shown
order, we may find that AFP streams cannot be processed by some
printers/viewers/software. Which is not desirable.

>
> Adrian.

Thanks,

Chris

Re: svn commit: r828678 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/afp: goca/ modca/ modca/triplets/

2009-11-26T05:58:57Z

Hi Chris,

2009/11/26 Chris Bowditch <bowditch_chris@...>

Adrian Cumiskey wrote:
I agree it might be better if the AttributeQualifier triplet is at the end of the list as it is optional, and FullyQualifiedName and AttributeValue are both manditory. I would be very surprised if this should cause a problem as I don't believe there are any ordering rules for triplets. I'd be interested to hear how bug manifests itself?

MO:DCA Specification dictates the order of the triplets, here: http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3M5M00/5.82.2?SHELF=APSBK320&DT=20010307105730

I don't believe that it does, this is just a list of possible applicable triplets for the TagLogicalElement structure field, the order in which they are present should not be important.

Attribute Qualifier is the last part of TLE structured field.

One of our customers has a process that extracts the TLE values which now fails because the 10 bytes of the AttributeQualifier occur in front of the value.

I do not think that it is correct for your customer to make this assumption about the position of the triplet in the structured field data. AFAIK it is still perfectly valid AFP so long as all the mandatory triplets are present and all the structured field data lengths and triplet data lengths are present and correct. But if this patch fixes the problem for your client I have no problem with you applying it.

Adrian.

Re: svn commit: r828678 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/afp: goca/ modca/ modca/triplets/

2009-11-26T04:08:13Z

Adrian Cumiskey wrote:
> Hi Chris,

Hi Adrian,

thanks for your reply.

>
> I agree it might be better if the AttributeQualifier triplet is at the
> end of the list as it is optional, and FullyQualifiedName and
> AttributeValue are both manditory. I would be very surprised if this
> should cause a problem as I don't believe there are any ordering rules
> for triplets. I'd be interested to hear how bug manifests itself?

MO:DCA Specification dictates the order of the triplets, here:
http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3M5M00/5.82.2?SHELF=APSBK320&DT=20010307105730

Attribute Qualifier is the last part of TLE structured field.

One of our customers has a process that extracts the TLE values which
now fails because the 10 bytes of the AttributeQualifier occur in front
of the value.

Thanks,

Chris

>
> Thanks,
>
> Adrian.
>
> 2009/11/26 Chris Bowditch <bowditch_chris@...
> <mailto:bowditch_chris@...>>
>
> acumiskey@... <mailto:acumiskey@...> wrote:
>
> Author: acumiskey
> Date: Thu Oct 22 13:20:53 2009
> New Revision: 828678
>
>
> Hi Adrian,
>
> there is a bug in this commit. AttributeQualifier was moved from end
> of TLE to be between Attribute Name and Attribute Value.
>
> I will commit a fix shortly.
>
> Chris
>
>
>
> URL: http://svn.apache.org/viewvc?rev=828678&view=rev
> <http://svn.apache.org/viewvc?rev=828678&view=rev>
> Log:
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=47941
> Created Triplet interface.
> Created new AttributeValueTriplet and AttributeQualifierTriplet.
> Promoted truncate() from GraphicsCharacterString to
> AbstractAFPObject so it can be reused for AttributeValueTriplet.
>
> Added:
>
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java
>
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java
>
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java
> Modified:
>
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java
>
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java
>
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java
>
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java
>
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java
> URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java?rev=828678&r1=828677&r2=828678&view=diff
> <http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java?rev=828678&r1=828677&r2=828678&view=diff>
> ==============================================================================
> ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java
> (original)
> +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java
> Thu Oct 22 13:20:53 2009
> @@ -45,7 +45,7 @@
> */
> public GraphicsCharacterString(String str, int x, int y) {
> super(x, y);
> - this.str = truncate(str);
> + this.str = truncate(str, MAX_STR_LEN);
> }
> /**
> @@ -57,7 +57,7 @@
> */
> public GraphicsCharacterString(String str) {
> super(null);
> - this.str = truncate(str);
> + this.str = truncate(str, MAX_STR_LEN);
> }
> /** {@inheritDoc} */
> @@ -83,20 +83,6 @@
> }
> /**
> - * Truncates the string as necessary
> - *
> - * @param str a character string
> - * @return a possibly truncated string
> - */
> - private String truncate(String str) {
> - if (str.length() > MAX_STR_LEN) {
> - str = str.substring(0, MAX_STR_LEN);
> - log.warn("truncated character string, longer than "
> + MAX_STR_LEN + " chars");
> - }
> - return str;
> - }
> -
> - /**
> * Returns the text string as an encoded byte array
> *
> * @return the text string as an encoded byte array
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java
> URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java?rev=828678&r1=828677&r2=828678&view=diff
> <http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java?rev=828678&r1=828677&r2=828678&view=diff>
> ==============================================================================
> ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java
> (original)
> +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java
> Thu Oct 22 13:20:53 2009
> @@ -43,7 +43,7 @@
> /** the structured field class id */
> protected static final byte SF_CLASS = (byte)0xD3;
> - private static final byte[] SF_HEADER = new byte[] {
> + protected static final byte[] SF_HEADER = new byte[] {
> 0x5A, // Structured field identifier
> 0x00, // Length byte 1
> 0x10, // Length byte 2
> @@ -177,6 +177,21 @@
> }
> }
> + /**
> + * Truncates the string as necessary
> + *
> + * @param str a character string
> + * @param maxLength the maximum length allowed for the string
> + * @return a possibly truncated string
> + */
> + protected String truncate(String str, int maxLength) {
> + if (str.length() > maxLength) {
> + str = str.substring(0, maxLength);
> + log.warn("truncated character string '" + str + "',
> longer than " + maxLength + " chars");
> + }
> + return str;
> + }
> +
> /** structured field type codes */
> public interface Type {
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java
> URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java?rev=828678&r1=828677&r2=828678&view=diff
> <http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java?rev=828678&r1=828677&r2=828678&view=diff>
> ==============================================================================
> ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java
> (original)
> +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java
> Thu Oct 22 13:20:53 2009
> @@ -27,9 +27,12 @@
> import org.apache.fop.afp.modca.Registry.ObjectType;
> import org.apache.fop.afp.modca.triplets.AbstractTriplet;
> +import org.apache.fop.afp.modca.triplets.AttributeQualifierTriplet;
> +import org.apache.fop.afp.modca.triplets.AttributeValueTriplet;
> import org.apache.fop.afp.modca.triplets.CommentTriplet;
> import org.apache.fop.afp.modca.triplets.FullyQualifiedNameTriplet;
> import
> org.apache.fop.afp.modca.triplets.ObjectClassificationTriplet;
> +import org.apache.fop.afp.modca.triplets.Triplet;
> /**
> * A MODCA structured object base class providing support for
> Triplets
> @@ -37,7 +40,7 @@
> public class AbstractTripletStructuredObject extends
> AbstractStructuredObject {
> /** list of object triplets */
> - protected List/*<AbstractTriplet>*/ triplets = new
> java.util.ArrayList/*<AbstractTriplet>*/();
> + protected List/*<Triplet>*/ triplets = new
> java.util.ArrayList/*<Triplet>*/();
> /**
> * Returns the triplet data length
> @@ -109,7 +112,7 @@
> *
> * @param triplet the triplet to add
> */
> - protected void addTriplet(AbstractTriplet triplet) {
> + protected void addTriplet(Triplet triplet) {
> triplets.add(triplet);
> }
> @@ -130,7 +133,7 @@
> }
> /**
> - * Sets the fully qualified name of this resource
> + * Sets the fully qualified name of this structured field
> *
> * @param fqnType the fully qualified name type of this resource
> * @param fqnFormat the fully qualified name format of this
> resource
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java
> URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java?rev=828678&r1=828677&r2=828678&view=diff
> <http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java?rev=828678&r1=828677&r2=828678&view=diff>
> ==============================================================================
> ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java
> (original)
> +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java
> Thu Oct 22 13:20:53 2009
> @@ -21,9 +21,10 @@
> import java.io.IOException;
> import java.io.OutputStream;
> -import java.io.UnsupportedEncodingException;
> -import org.apache.fop.afp.AFPConstants;
> +import org.apache.fop.afp.modca.triplets.AttributeQualifierTriplet;
> +import org.apache.fop.afp.modca.triplets.AttributeValueTriplet;
> +import org.apache.fop.afp.modca.triplets.FullyQualifiedNameTriplet;
> import org.apache.fop.afp.util.BinaryUtils;
> /**
> @@ -45,7 +46,7 @@
> * effect on the appearance of a document when it is presented.
> * <p/>
> */
> -public class TagLogicalElement extends AbstractAFPObject {
> +public class TagLogicalElement extends
> AbstractTripletStructuredObject {
> /**
> * Name of the key, used within the TLE
> @@ -75,77 +76,43 @@
> this.tleID = tleID;
> }
> - /** {@inheritDoc} */
> - public void writeToStream(OutputStream os) throws IOException {
> + /**
> + * Sets the attribute value of this structured field
> + *
> + * @param value the attribute value
> + */
> + public void setAttributeValue(String value) {
> + addTriplet(new AttributeValueTriplet(value));
> + }
> - // convert name and value to ebcdic
> - byte[] tleByteName = null;
> - byte[] tleByteValue = null;
> - try {
> - tleByteName =
> name.getBytes(AFPConstants.EBCIDIC_ENCODING);
> - tleByteValue =
> value.getBytes(AFPConstants.EBCIDIC_ENCODING);
> - } catch (UnsupportedEncodingException usee) {
> - tleByteName = name.getBytes();
> - tleByteValue = value.getBytes();
> - log.warn(
> - "Constructor:: UnsupportedEncodingException
> translating the name "
> - + name);
> - }
> -
> - byte[] data = new byte[27 + tleByteName.length +
> tleByteValue.length];
> -
> - data[0] = 0x5A;
> - // Set the total record length
> - byte[] rl1
> - = BinaryUtils.convert(26 + tleByteName.length +
> tleByteValue.length, 2);
> - //Ignore first byte
> - data[1] = rl1[0];
> - data[2] = rl1[1];
> -
> - // Structured field ID for a TLE
> - data[3] = (byte) 0xD3;
> - data[4] = (byte) Type.ATTRIBUTE;
> - data[5] = (byte) Category.PROCESS_ELEMENT;
> -
> - data[6] = 0x00; // Reserved
> - data[7] = 0x00; // Reserved
> - data[8] = 0x00; // Reserved
> -
> - //Use 2 triplets, attribute name and value (the key for
> indexing)
> -
> - byte[] rl2 = BinaryUtils.convert(tleByteName.length +
> 4, 1);
> - data[9] = rl2[0]; // length of the triplet, including
> this field
> - data[10] = 0x02; //Identifies it as a FQN triplet
> - data[11] = 0x0B; // GID format
> - data[12] = 0x00;
> -
> - // write out TLE name
> - int pos = 13;
> - for (int i = 0; i < tleByteName.length; i++) {
> - data[pos++] = tleByteName[i];
> - }
> -
> - byte[] rl3 = BinaryUtils.convert(tleByteValue.length +
> 4, 1);
> - data[pos++] = rl3[0]; // length of the triplet,
> including this field
> - data[pos++] = 0x36; //Identifies the triplet, attribute
> value
> - data[pos++] = 0x00; // Reserved
> - data[pos++] = 0x00; // Reserved
> -
> - for (int i = 0; i < tleByteValue.length; i++) {
> - data[pos++] = tleByteValue[i];
> - }
> - // attribute qualifier
> - data[pos++] = 0x0A;
> - data[pos++] = (byte)0x80;
> - byte[] id = BinaryUtils.convert(tleID, 4);
> - for (int i = 0; i < id.length; i++) {
> - data[pos++] = id[i];
> - }
> - byte[] level = BinaryUtils.convert(1, 4);
> - for (int i = 0; i < level.length; i++) {
> - data[pos++] = level[i];
> - }
> + /**
> + * Sets the attribute qualifier of this structured field
> + *
> + * @param seqNumber the attribute sequence number
> + * @param levNumber the attribute level number
> + */
> + public void setAttributeQualifier(int seqNumber, int
> levNumber) {
> + addTriplet(new AttributeQualifierTriplet(seqNumber,
> levNumber));
> + }
> + /** {@inheritDoc} */
> + public void writeToStream(OutputStream os) throws IOException {
> + setFullyQualifiedName(
> + FullyQualifiedNameTriplet.TYPE_ATTRIBUTE_GID,
> + FullyQualifiedNameTriplet.FORMAT_CHARSTR,
> + name);
> + setAttributeQualifier(tleID, 1);
> + setAttributeValue(value);
> + + byte[] data = new byte[SF_HEADER.length];
> + copySF(data, Type.ATTRIBUTE, Category.PROCESS_ELEMENT);
> + + int tripletDataLength = getTripletDataLength();
> + byte[] l = BinaryUtils.convert(data.length +
> tripletDataLength - 1, 2);
> + data[1] = l[0];
> + data[2] = l[1];
> os.write(data);
> +
> + writeTriplets(os);
> }
> }
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java
> URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java?rev=828678&r1=828677&r2=828678&view=diff
> <http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java?rev=828678&r1=828677&r2=828678&view=diff>
> ==============================================================================
> ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java
> (original)
> +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java
> Thu Oct 22 13:20:53 2009
> @@ -19,70 +19,12 @@
> package org.apache.fop.afp.modca.triplets;
> -import org.apache.fop.afp.Streamable;
> -import org.apache.fop.afp.StructuredData;
> +import org.apache.fop.afp.modca.AbstractAFPObject;
> /**
> * A simple implementation of a MOD:CA triplet
> */
> -public abstract class AbstractTriplet implements Streamable,
> StructuredData {
> - public static final byte
> CODED_GRAPHIC_CHARACTER_SET_GLOBAL_IDENTIFIER = 0x01;
> -
> - /** Triplet identifiers */
> - public static final byte FULLY_QUALIFIED_NAME = 0x02;
> - public static final byte MAPPING_OPTION = 0x04;
> - public static final byte OBJECT_CLASSIFICATION = 0x10;
> - public static final byte MODCA_INTERCHANGE_SET = 0x18;
> - public static final byte FONT_DESCRIPTOR_SPECIFICATION = 0x1F;
> - public static final byte OBJECT_FUNCTION_SET_SPECIFICATION
> = 0x21;
> - public static final byte EXTENDED_RESOURCE_LOCAL_IDENTIFIER
> = 0x22;
> - public static final byte RESOURCE_LOCAL_IDENTIFIER = 0x24;
> - public static final byte RESOURCE_SECTION_NUMBER = 0x25;
> - public static final byte CHARACTER_ROTATION = 0x26;
> - public static final byte OBJECT_BYTE_OFFSET = 0x2D;
> - public static final byte ATTRIBUTE_VALUE = 0x36;
> - public static final byte DESCRIPTOR_POSITION = 0x43;
> - public static final byte MEDIA_EJECT_CONTROL = 0x45;
> - public static final byte
> PAGE_OVERLAY_CONDITIONAL_PROCESSING = 0x46;
> - public static final byte RESOURCE_USAGE_ATTRIBUTE = 0x47;
> - public static final byte MEASUREMENT_UNITS = 0x4B;
> - public static final byte OBJECT_AREA_SIZE = 0x4C;
> - public static final byte AREA_DEFINITION = 0x4D;
> - public static final byte COLOR_SPECIFICATION = 0x4E;
> - public static final byte ENCODING_SCHEME_ID = 0x50;
> - public static final byte MEDIUM_MAP_PAGE_NUMBER = 0x56;
> - public static final byte OBJECT_BYTE_EXTENT = 0x57;
> - public static final byte OBJECT_STRUCTURED_FIELD_OFFSET = 0x58;
> - public static final byte OBJECT_STRUCTURED_FIELD_EXTENT = 0x59;
> - public static final byte OBJECT_OFFSET = 0x5A;
> - public static final byte FONT_HORIZONTAL_SCALE_FACTOR = 0x5D;
> - public static final byte OBJECT_COUNT = 0x5E;
> - public static final byte OBJECT_DATE_AND_TIMESTAMP = 0x62;
> - public static final byte COMMENT = 0x65;
> - public static final byte MEDIUM_ORIENTATION = 0x68;
> - public static final byte RESOURCE_OBJECT_INCLUDE = 0x6C;
> - public static final byte PRESENTATION_SPACE_RESET_MIXING =
> 0x70;
> - public static final byte PRESENTATION_SPACE_MIXING_RULE = 0x71;
> - public static final byte UNIVERSAL_DATE_AND_TIMESTAMP = 0x72;
> - public static final byte TONER_SAVER = 0x74;
> - public static final byte COLOR_FIDELITY = 0x75;
> - public static final byte FONT_FIDELITY = 0x78;
> - public static final byte ATTRIBUTE_QUALIFIER = (byte)0x80;
> - public static final byte PAGE_POSITION_INFORMATION =
> (byte)0x81;
> - public static final byte PARAMETER_VALUE = (byte)0x82;
> - public static final byte PRESENTATION_CONTROL = (byte)0x83;
> - public static final byte
> FONT_RESOLUTION_AND_METRIC_TECHNOLOGY = (byte)0x84;
> - public static final byte FINISHING_OPERATION = (byte)0x85;
> - public static final byte TEXT_FIDELITY = (byte)0x86;
> - public static final byte MEDIA_FIDELITY = (byte)0x87;
> - public static final byte FINISHING_FIDELITY = (byte)0x88;
> - public static final byte DATA_OBJECT_FONT_DESCRIPTOR =
> (byte)0x8B;
> - public static final byte LOCALE_SELECTOR = (byte)0x8C;
> - public static final byte UP3I_FINISHING_OPERATION = (byte)0x8E;
> - public static final byte
> COLOR_MANAGEMENT_RESOURCE_DESCRIPTOR = (byte)0x91;
> - public static final byte RENDERING_INTENT = (byte)0x95;
> - public static final byte CMR_TAG_FIDELITY = (byte)0x96;
> - public static final byte DEVICE_APPEARANCE = (byte)0x97;
> +public abstract class AbstractTriplet extends AbstractAFPObject
> implements Triplet {
> /** the triplet identifier */
> protected final byte id;
>
> Added:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java
> URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java?rev=828678&view=auto
> <http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java?rev=828678&view=auto>
> ==============================================================================
> ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java
> (added)
> +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java
> Thu Oct 22 13:20:53 2009
> @@ -0,0 +1,48 @@
> +package org.apache.fop.afp.modca.triplets;
> +
> +import java.io.IOException;
> +import java.io.OutputStream;
> +
> +import org.apache.fop.afp.util.BinaryUtils;
> +
> +/**
> + * The attribute qualifier triplet is used to specify a
> qualifier for a document
> + * attribute.
> + */
> +public class AttributeQualifierTriplet extends AbstractTriplet {
> +
> + private int seqNumber;
> + private int levNumber;
> +
> + /**
> + * Main constructor
> + * + * @param seqNumber the attribute qualifier
> sequence number
> + * @param levNumber the attribute qualifier level number
> + */
> + public AttributeQualifierTriplet(int seqNumber, int
> levNumber) {
> + super(ATTRIBUTE_QUALIFIER);
> + this.seqNumber = seqNumber;
> + this.levNumber = levNumber;
> + }
> +
> + /** {@inheritDoc} */
> + public void writeToStream(OutputStream os) throws IOException {
> + byte[] data = getData();
> + byte[] id = BinaryUtils.convert(seqNumber, 4);
> + System.arraycopy(id, 0, data, 2, id.length);
> + byte[] level = BinaryUtils.convert(levNumber, 4);
> + System.arraycopy(level, 0, data, 6, level.length);
> + os.write(data);
> + }
> +
> + /** {@inheritDoc} */
> + public int getDataLength() {
> + return 10;
> + }
> + + /** {@inheritDoc} */
> + public String toString() {
> + return "seqNumber=" + seqNumber + ", levNumber=" +
> levNumber;
> + }
> +}
>
> Added:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java
> URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java?rev=828678&view=auto
> <http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java?rev=828678&view=auto>
> ==============================================================================
> ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java
> (added)
> +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java
> Thu Oct 22 13:20:53 2009
> @@ -0,0 +1,53 @@
> +package org.apache.fop.afp.modca.triplets;
> +
> +import java.io.IOException;
> +import java.io.OutputStream;
> +import java.io.UnsupportedEncodingException;
> +
> +import org.apache.fop.afp.AFPConstants;
> +
> +/**
> + * The attribute value triplet is used to specify a value for a
> document
> + * attribute.
> + */
> +public class AttributeValueTriplet extends AbstractTriplet {
> + private String attVal;
> +
> + /**
> + * Main constructor
> + * + * @param attVal an attribute value
> + */
> + public AttributeValueTriplet(String attVal) {
> + super(ATTRIBUTE_VALUE);
> + this.attVal = truncate(attVal, MAX_LENGTH - 4);
> + }
> +
> + /** {@inheritDoc} */
> + public void writeToStream(OutputStream os) throws IOException {
> + byte[] data = super.getData();
> + data[2] = 0x00; // Reserved
> + data[3] = 0x00; // Reserved
> +
> + // convert name and value to ebcdic
> + byte[] tleByteValue = null;
> + try {
> + tleByteValue =
> attVal.getBytes(AFPConstants.EBCIDIC_ENCODING);
> + } catch (UnsupportedEncodingException usee) {
> + tleByteValue = attVal.getBytes();
> + throw new IllegalArgumentException(attVal + "
> encoding failed");
> + }
> + System.arraycopy(tleByteValue, 0, data, 4,
> tleByteValue.length);
> + os.write(data);
> + }
> +
> + /** {@inheritDoc} */
> + public int getDataLength() {
> + return 4 + attVal.length();
> + }
> + + /** {@inheritDoc} */
> + public String toString() {
> + return attVal;
> + }
> +}
>
> Added:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java
> URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java?rev=828678&view=auto
> <http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java?rev=828678&view=auto>
> ==============================================================================
> ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java
> (added)
> +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java
> Thu Oct 22 13:20:53 2009
> @@ -0,0 +1,66 @@
> +package org.apache.fop.afp.modca.triplets;
> +
> +import org.apache.fop.afp.Streamable;
> +import org.apache.fop.afp.StructuredData;
> +
> +public interface Triplet extends Streamable, StructuredData {
> + int MAX_LENGTH = 254;
> + + byte CODED_GRAPHIC_CHARACTER_SET_GLOBAL_IDENTIFIER = 0x01;
> +
> + /** Triplet identifiers */
> + byte FULLY_QUALIFIED_NAME = 0x02;
> + byte MAPPING_OPTION = 0x04;
> + byte OBJECT_CLASSIFICATION = 0x10;
> + byte MODCA_INTERCHANGE_SET = 0x18;
> + byte FONT_DESCRIPTOR_SPECIFICATION = 0x1F;
> + byte OBJECT_FUNCTION_SET_SPECIFICATION = 0x21;
> + byte EXTENDED_RESOURCE_LOCAL_IDENTIFIER = 0x22;
> + byte RESOURCE_LOCAL_IDENTIFIER = 0x24;
> + byte RESOURCE_SECTION_NUMBER = 0x25;
> + byte CHARACTER_ROTATION = 0x26;
> + byte OBJECT_BYTE_OFFSET = 0x2D;
> + byte ATTRIBUTE_VALUE = 0x36;
> + byte DESCRIPTOR_POSITION = 0x43;
> + byte MEDIA_EJECT_CONTROL = 0x45;
> + byte PAGE_OVERLAY_CONDITIONAL_PROCESSING = 0x46;
> + byte RESOURCE_USAGE_ATTRIBUTE = 0x47;
> + byte MEASUREMENT_UNITS = 0x4B;
> + byte OBJECT_AREA_SIZE = 0x4C;
> + byte AREA_DEFINITION = 0x4D;
> + byte COLOR_SPECIFICATION = 0x4E;
> + byte ENCODING_SCHEME_ID = 0x50;
> + byte MEDIUM_MAP_PAGE_NUMBER = 0x56;
> + byte OBJECT_BYTE_EXTENT = 0x57;
> + byte OBJECT_STRUCTURED_FIELD_OFFSET = 0x58;
> + byte OBJECT_STRUCTURED_FIELD_EXTENT = 0x59;
> + byte OBJECT_OFFSET = 0x5A;
> + byte FONT_HORIZONTAL_SCALE_FACTOR = 0x5D;
> + byte OBJECT_COUNT = 0x5E;
> + byte OBJECT_DATE_AND_TIMESTAMP = 0x62;
> + byte COMMENT = 0x65;
> + byte MEDIUM_ORIENTATION = 0x68;
> + byte RESOURCE_OBJECT_INCLUDE = 0x6C;
> + byte PRESENTATION_SPACE_RESET_MIXING = 0x70;
> + byte PRESENTATION_SPACE_MIXING_RULE = 0x71;
> + byte UNIVERSAL_DATE_AND_TIMESTAMP = 0x72;
> + byte TONER_SAVER = 0x74;
> + byte COLOR_FIDELITY = 0x75;
> + byte FONT_FIDELITY = 0x78;
> + byte ATTRIBUTE_QUALIFIER = (byte)0x80;
> + byte PAGE_POSITION_INFORMATION = (byte)0x81;
> + byte PARAMETER_VALUE = (byte)0x82;
> + byte PRESENTATION_CONTROL = (byte)0x83;
> + byte FONT_RESOLUTION_AND_METRIC_TECHNOLOGY = (byte)0x84;
> + byte FINISHING_OPERATION = (byte)0x85;
> + byte TEXT_FIDELITY = (byte)0x86;
> + byte MEDIA_FIDELITY = (byte)0x87;
> + byte FINISHING_FIDELITY = (byte)0x88;
> + byte DATA_OBJECT_FONT_DESCRIPTOR = (byte)0x8B;
> + byte LOCALE_SELECTOR = (byte)0x8C;
> + byte UP3I_FINISHING_OPERATION = (byte)0x8E;
> + byte COLOR_MANAGEMENT_RESOURCE_DESCRIPTOR = (byte)0x91;
> + byte RENDERING_INTENT = (byte)0x95;
> + byte CMR_TAG_FIDELITY = (byte)0x96;
> + byte DEVICE_APPEARANCE = (byte)0x97;
> +}
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> fop-commits-unsubscribe@...
> <mailto:fop-commits-unsubscribe@...>
> For additional commands, e-mail:
> fop-commits-help@...
> <mailto:fop-commits-help@...>
>
>
>
>
>
>
>
> --
> Kind regards,
>
> Adrian Cumiskey.

DO NOT REPLY [Bug 48290] AFP Renderer: AttributeQualifier Triplet occurs before TLE Value

2009-11-26T04:03:42Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48290

Chris Bowditch <bowditch_chris@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: svn commit: r828678 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/afp: goca/ modca/ modca/triplets/

2009-11-26T03:35:17Z

Hi Chris,

I agree it might be better if the AttributeQualifier triplet is at the end of the list as it is optional, and FullyQualifiedName and AttributeValue are both manditory. I would be very surprised if this should cause a problem as I don't believe there are any ordering rules for triplets. I'd be interested to hear how bug manifests itself?

Thanks,

Adrian.

2009/11/26 Chris Bowditch <bowditch_chris@...>

acumiskey@... wrote:

Author: acumiskey
Date: Thu Oct 22 13:20:53 2009
New Revision: 828678

Hi Adrian,

there is a bug in this commit. AttributeQualifier was moved from end of TLE to be between Attribute Name and Attribute Value.

I will commit a fix shortly.

Chris

URL: http://svn.apache.org/viewvc?rev=828678&view=rev
Log:
Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=47941
Created Triplet interface.
Created new AttributeValueTriplet and AttributeQualifierTriplet.
Promoted truncate() from GraphicsCharacterString to AbstractAFPObject so it can be reused for AttributeValueTriplet.

Added:
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java?rev=828678&r1=828677&r2=828678&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java Thu Oct 22 13:20:53 2009
@@ -45,7 +45,7 @@
*/
public GraphicsCharacterString(String str, int x, int y) {
super(x, y);
- this.str = truncate(str);
+ this.str = truncate(str, MAX_STR_LEN);
}
/**
@@ -57,7 +57,7 @@
*/
public GraphicsCharacterString(String str) {
super(null);
- this.str = truncate(str);
+ this.str = truncate(str, MAX_STR_LEN);
}
/** {@inheritDoc} */
@@ -83,20 +83,6 @@
}
/**
- * Truncates the string as necessary
- *
- * @param str a character string
- * @return a possibly truncated string
- */
- private String truncate(String str) {
- if (str.length() > MAX_STR_LEN) {
- str = str.substring(0, MAX_STR_LEN);
- log.warn("truncated character string, longer than " + MAX_STR_LEN + " chars");
- }
- return str;
- }
-
- /**
* Returns the text string as an encoded byte array
*
* @return the text string as an encoded byte array

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java?rev=828678&r1=828677&r2=828678&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java Thu Oct 22 13:20:53 2009
@@ -43,7 +43,7 @@
/** the structured field class id */
protected static final byte SF_CLASS = (byte)0xD3;
- private static final byte[] SF_HEADER = new byte[] {
+ protected static final byte[] SF_HEADER = new byte[] {
0x5A, // Structured field identifier
0x00, // Length byte 1
0x10, // Length byte 2
@@ -177,6 +177,21 @@
}
}
+ /**
+ * Truncates the string as necessary
+ *
+ * @param str a character string
+ * @param maxLength the maximum length allowed for the string
+ * @return a possibly truncated string
+ */
+ protected String truncate(String str, int maxLength) {
+ if (str.length() > maxLength) {
+ str = str.substring(0, maxLength);
+ log.warn("truncated character string '" + str + "', longer than " + maxLength + " chars");
+ }
+ return str;
+ }
+
/** structured field type codes */
public interface Type {

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java?rev=828678&r1=828677&r2=828678&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java Thu Oct 22 13:20:53 2009
@@ -27,9 +27,12 @@
  import org.apache.fop.afp.modca.Registry.ObjectType;
import org.apache.fop.afp.modca.triplets.AbstractTriplet;
+import org.apache.fop.afp.modca.triplets.AttributeQualifierTriplet;
+import org.apache.fop.afp.modca.triplets.AttributeValueTriplet;
import org.apache.fop.afp.modca.triplets.CommentTriplet;
import org.apache.fop.afp.modca.triplets.FullyQualifiedNameTriplet;
import org.apache.fop.afp.modca.triplets.ObjectClassificationTriplet;
+import org.apache.fop.afp.modca.triplets.Triplet;
  /**
* A MODCA structured object base class providing support for Triplets
@@ -37,7 +40,7 @@
public class AbstractTripletStructuredObject extends AbstractStructuredObject {
/** list of object triplets */
- protected List/*<AbstractTriplet>*/ triplets = new java.util.ArrayList/*<AbstractTriplet>*/();
+ protected List/*<Triplet>*/ triplets = new java.util.ArrayList/*<Triplet>*/();
/**
* Returns the triplet data length
@@ -109,7 +112,7 @@
*
* @param triplet the triplet to add
*/
- protected void addTriplet(AbstractTriplet triplet) {
+ protected void addTriplet(Triplet triplet) {
triplets.add(triplet);
}
@@ -130,7 +133,7 @@
}
/**
- * Sets the fully qualified name of this resource
+ * Sets the fully qualified name of this structured field
*
* @param fqnType the fully qualified name type of this resource
* @param fqnFormat the fully qualified name format of this resource

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java?rev=828678&r1=828677&r2=828678&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java Thu Oct 22 13:20:53 2009
@@ -21,9 +21,10 @@
  import java.io.IOException;
import java.io.OutputStream;
-import java.io.UnsupportedEncodingException;
-import org.apache.fop.afp.AFPConstants;
+import org.apache.fop.afp.modca.triplets.AttributeQualifierTriplet;
+import org.apache.fop.afp.modca.triplets.AttributeValueTriplet;
+import org.apache.fop.afp.modca.triplets.FullyQualifiedNameTriplet;
import org.apache.fop.afp.util.BinaryUtils;
  /**
@@ -45,7 +46,7 @@
* effect on the appearance of a document when it is presented.
* <p/>
*/
-public class TagLogicalElement extends AbstractAFPObject {
+public class TagLogicalElement extends AbstractTripletStructuredObject {
/**
* Name of the key, used within the TLE
@@ -75,77 +76,43 @@
this.tleID = tleID;
}
- /** {@inheritDoc} */
- public void writeToStream(OutputStream os) throws IOException {
+ /**
+ * Sets the attribute value of this structured field
+ *
+ * @param value the attribute value
+ */
+ public void setAttributeValue(String value) {
+ addTriplet(new AttributeValueTriplet(value));
+ }
- // convert name and value to ebcdic
- byte[] tleByteName = null;
- byte[] tleByteValue = null;
- try {
- tleByteName = name.getBytes(AFPConstants.EBCIDIC_ENCODING);
- tleByteValue = value.getBytes(AFPConstants.EBCIDIC_ENCODING);
- } catch (UnsupportedEncodingException usee) {
- tleByteName = name.getBytes();
- tleByteValue = value.getBytes();
- log.warn(
- "Constructor:: UnsupportedEncodingException translating the name "
- + name);
- }
-
- byte[] data = new byte[27 + tleByteName.length + tleByteValue.length];
-
- data[0] = 0x5A;
- // Set the total record length
- byte[] rl1
- = BinaryUtils.convert(26 + tleByteName.length + tleByteValue.length, 2);
- //Ignore first byte
- data[1] = rl1[0];
- data[2] = rl1[1];
-
- // Structured field ID for a TLE
- data[3] = (byte) 0xD3;
- data[4] = (byte) Type.ATTRIBUTE;
- data[5] = (byte) Category.PROCESS_ELEMENT;
-
- data[6] = 0x00; // Reserved
- data[7] = 0x00; // Reserved
- data[8] = 0x00; // Reserved
-
- //Use 2 triplets, attribute name and value (the key for indexing)
-
- byte[] rl2 = BinaryUtils.convert(tleByteName.length + 4, 1);
- data[9] = rl2[0]; // length of the triplet, including this field
- data[10] = 0x02; //Identifies it as a FQN triplet
- data[11] = 0x0B; // GID format
- data[12] = 0x00;
-
- // write out TLE name
- int pos = 13;
- for (int i = 0; i < tleByteName.length; i++) {
- data[pos++] = tleByteName[i];
- }
-
- byte[] rl3 = BinaryUtils.convert(tleByteValue.length + 4, 1);
- data[pos++] = rl3[0]; // length of the triplet, including this field
- data[pos++] = 0x36; //Identifies the triplet, attribute value
- data[pos++] = 0x00; // Reserved
- data[pos++] = 0x00; // Reserved
-
- for (int i = 0; i < tleByteValue.length; i++) {
- data[pos++] = tleByteValue[i];
- }
- // attribute qualifier
- data[pos++] = 0x0A;
- data[pos++] = (byte)0x80;
- byte[] id = BinaryUtils.convert(tleID, 4);
- for (int i = 0; i < id.length; i++) {
- data[pos++] = id[i];
- }
- byte[] level = BinaryUtils.convert(1, 4);
- for (int i = 0; i < level.length; i++) {
- data[pos++] = level[i];
- }
+ /**
+ * Sets the attribute qualifier of this structured field
+ *
+ * @param seqNumber the attribute sequence number
+ * @param levNumber the attribute level number
+ */
+ public void setAttributeQualifier(int seqNumber, int levNumber) {
+ addTriplet(new AttributeQualifierTriplet(seqNumber, levNumber));
+ }
+ /** {@inheritDoc} */
+ public void writeToStream(OutputStream os) throws IOException {
+ setFullyQualifiedName(
+ FullyQualifiedNameTriplet.TYPE_ATTRIBUTE_GID,
+ FullyQualifiedNameTriplet.FORMAT_CHARSTR,
+ name);
+ setAttributeQualifier(tleID, 1);
+ setAttributeValue(value);
+ + byte[] data = new byte[SF_HEADER.length];
+ copySF(data, Type.ATTRIBUTE, Category.PROCESS_ELEMENT);
+ + int tripletDataLength = getTripletDataLength();
+ byte[] l = BinaryUtils.convert(data.length + tripletDataLength - 1, 2);
+ data[1] = l[0];
+ data[2] = l[1];
os.write(data);
+
+ writeTriplets(os);
}
}

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java?rev=828678&r1=828677&r2=828678&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java Thu Oct 22 13:20:53 2009
@@ -19,70 +19,12 @@
  package org.apache.fop.afp.modca.triplets;
-import org.apache.fop.afp.Streamable;
-import org.apache.fop.afp.StructuredData;
+import org.apache.fop.afp.modca.AbstractAFPObject;
  /**
* A simple implementation of a MOD:CA triplet
*/
-public abstract class AbstractTriplet implements Streamable, StructuredData {
- public static final byte CODED_GRAPHIC_CHARACTER_SET_GLOBAL_IDENTIFIER = 0x01;
-
- /** Triplet identifiers */
- public static final byte FULLY_QUALIFIED_NAME = 0x02;
- public static final byte MAPPING_OPTION = 0x04;
- public static final byte OBJECT_CLASSIFICATION = 0x10;
- public static final byte MODCA_INTERCHANGE_SET = 0x18;
- public static final byte FONT_DESCRIPTOR_SPECIFICATION = 0x1F;
- public static final byte OBJECT_FUNCTION_SET_SPECIFICATION = 0x21;
- public static final byte EXTENDED_RESOURCE_LOCAL_IDENTIFIER = 0x22;
- public static final byte RESOURCE_LOCAL_IDENTIFIER = 0x24;
- public static final byte RESOURCE_SECTION_NUMBER = 0x25;
- public static final byte CHARACTER_ROTATION = 0x26;
- public static final byte OBJECT_BYTE_OFFSET = 0x2D;
- public static final byte ATTRIBUTE_VALUE = 0x36;
- public static final byte DESCRIPTOR_POSITION = 0x43;
- public static final byte MEDIA_EJECT_CONTROL = 0x45;
- public static final byte PAGE_OVERLAY_CONDITIONAL_PROCESSING = 0x46;
- public static final byte RESOURCE_USAGE_ATTRIBUTE = 0x47;
- public static final byte MEASUREMENT_UNITS = 0x4B;
- public static final byte OBJECT_AREA_SIZE = 0x4C;
- public static final byte AREA_DEFINITION = 0x4D;
- public static final byte COLOR_SPECIFICATION = 0x4E;
- public static final byte ENCODING_SCHEME_ID = 0x50;
- public static final byte MEDIUM_MAP_PAGE_NUMBER = 0x56;
- public static final byte OBJECT_BYTE_EXTENT = 0x57;
- public static final byte OBJECT_STRUCTURED_FIELD_OFFSET = 0x58;
- public static final byte OBJECT_STRUCTURED_FIELD_EXTENT = 0x59;
- public static final byte OBJECT_OFFSET = 0x5A;
- public static final byte FONT_HORIZONTAL_SCALE_FACTOR = 0x5D;
- public static final byte OBJECT_COUNT = 0x5E;
- public static final byte OBJECT_DATE_AND_TIMESTAMP = 0x62;
- public static final byte COMMENT = 0x65;
- public static final byte MEDIUM_ORIENTATION = 0x68;
- public static final byte RESOURCE_OBJECT_INCLUDE = 0x6C;
- public static final byte PRESENTATION_SPACE_RESET_MIXING = 0x70;
- public static final byte PRESENTATION_SPACE_MIXING_RULE = 0x71;
- public static final byte UNIVERSAL_DATE_AND_TIMESTAMP = 0x72;
- public static final byte TONER_SAVER = 0x74;
- public static final byte COLOR_FIDELITY = 0x75;
- public static final byte FONT_FIDELITY = 0x78;
- public static final byte ATTRIBUTE_QUALIFIER = (byte)0x80;
- public static final byte PAGE_POSITION_INFORMATION = (byte)0x81;
- public static final byte PARAMETER_VALUE = (byte)0x82;
- public static final byte PRESENTATION_CONTROL = (byte)0x83;
- public static final byte FONT_RESOLUTION_AND_METRIC_TECHNOLOGY = (byte)0x84;
- public static final byte FINISHING_OPERATION = (byte)0x85;
- public static final byte TEXT_FIDELITY = (byte)0x86;
- public static final byte MEDIA_FIDELITY = (byte)0x87;
- public static final byte FINISHING_FIDELITY = (byte)0x88;
- public static final byte DATA_OBJECT_FONT_DESCRIPTOR = (byte)0x8B;
- public static final byte LOCALE_SELECTOR = (byte)0x8C;
- public static final byte UP3I_FINISHING_OPERATION = (byte)0x8E;
- public static final byte COLOR_MANAGEMENT_RESOURCE_DESCRIPTOR = (byte)0x91;
- public static final byte RENDERING_INTENT = (byte)0x95;
- public static final byte CMR_TAG_FIDELITY = (byte)0x96;
- public static final byte DEVICE_APPEARANCE = (byte)0x97;
+public abstract class AbstractTriplet extends AbstractAFPObject implements Triplet {
/** the triplet identifier */
protected final byte id;

Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java?rev=828678&view=auto
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java (added)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java Thu Oct 22 13:20:53 2009
@@ -0,0 +1,48 @@
+package org.apache.fop.afp.modca.triplets;
+
+import java.io.IOException;
+import java.io.OutputStream;
+
+import org.apache.fop.afp.util.BinaryUtils;
+
+/**
+ * The attribute qualifier triplet is used to specify a qualifier for a document
+ * attribute.
+ */
+public class AttributeQualifierTriplet extends AbstractTriplet {
+
+ private int seqNumber;
+ private int levNumber;
+
+ /**
+ * Main constructor
+ * + * @param seqNumber the attribute qualifier sequence number
+ * @param levNumber the attribute qualifier level number
+ */
+ public AttributeQualifierTriplet(int seqNumber, int levNumber) {
+ super(ATTRIBUTE_QUALIFIER);
+ this.seqNumber = seqNumber;
+ this.levNumber = levNumber;
+ }
+
+ /** {@inheritDoc} */
+ public void writeToStream(OutputStream os) throws IOException {
+ byte[] data = getData();
+ byte[] id = BinaryUtils.convert(seqNumber, 4);
+ System.arraycopy(id, 0, data, 2, id.length);
+ byte[] level = BinaryUtils.convert(levNumber, 4);
+ System.arraycopy(level, 0, data, 6, level.length);
+ os.write(data);
+ }
+
+ /** {@inheritDoc} */
+ public int getDataLength() {
+ return 10;
+ }
+ + /** {@inheritDoc} */
+ public String toString() {
+ return "seqNumber=" + seqNumber + ", levNumber=" + levNumber;
+ }
+}

Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java?rev=828678&view=auto
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java (added)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java Thu Oct 22 13:20:53 2009
@@ -0,0 +1,53 @@
+package org.apache.fop.afp.modca.triplets;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.io.UnsupportedEncodingException;
+
+import org.apache.fop.afp.AFPConstants;
+
+/**
+ * The attribute value triplet is used to specify a value for a document
+ * attribute.
+ */
+public class AttributeValueTriplet extends AbstractTriplet {
+ private String attVal;
+
+ /**
+ * Main constructor
+ * + * @param attVal an attribute value
+ */
+ public AttributeValueTriplet(String attVal) {
+ super(ATTRIBUTE_VALUE);
+ this.attVal = truncate(attVal, MAX_LENGTH - 4);
+ }
+
+ /** {@inheritDoc} */
+ public void writeToStream(OutputStream os) throws IOException {
+ byte[] data = super.getData();
+ data[2] = 0x00; // Reserved
+ data[3] = 0x00; // Reserved
+
+ // convert name and value to ebcdic
+ byte[] tleByteValue = null;
+ try {
+ tleByteValue = attVal.getBytes(AFPConstants.EBCIDIC_ENCODING);
+ } catch (UnsupportedEncodingException usee) {
+ tleByteValue = attVal.getBytes();
+ throw new IllegalArgumentException(attVal + " encoding failed");
+ }
+ System.arraycopy(tleByteValue, 0, data, 4, tleByteValue.length);
+ os.write(data);
+ }
+
+ /** {@inheritDoc} */
+ public int getDataLength() {
+ return 4 + attVal.length();
+ }
+ + /** {@inheritDoc} */
+ public String toString() {
+ return attVal;
+ }
+}

Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java?rev=828678&view=auto
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java (added)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java Thu Oct 22 13:20:53 2009
@@ -0,0 +1,66 @@
+package org.apache.fop.afp.modca.triplets;
+
+import org.apache.fop.afp.Streamable;
+import org.apache.fop.afp.StructuredData;
+
+public interface Triplet extends Streamable, StructuredData {
+ int MAX_LENGTH = 254;
+ + byte CODED_GRAPHIC_CHARACTER_SET_GLOBAL_IDENTIFIER = 0x01;
+
+ /** Triplet identifiers */
+ byte FULLY_QUALIFIED_NAME = 0x02;
+ byte MAPPING_OPTION = 0x04;
+ byte OBJECT_CLASSIFICATION = 0x10;
+ byte MODCA_INTERCHANGE_SET = 0x18;
+ byte FONT_DESCRIPTOR_SPECIFICATION = 0x1F;
+ byte OBJECT_FUNCTION_SET_SPECIFICATION = 0x21;
+ byte EXTENDED_RESOURCE_LOCAL_IDENTIFIER = 0x22;
+ byte RESOURCE_LOCAL_IDENTIFIER = 0x24;
+ byte RESOURCE_SECTION_NUMBER = 0x25;
+ byte CHARACTER_ROTATION = 0x26;
+ byte OBJECT_BYTE_OFFSET = 0x2D;
+ byte ATTRIBUTE_VALUE = 0x36;
+ byte DESCRIPTOR_POSITION = 0x43;
+ byte MEDIA_EJECT_CONTROL = 0x45;
+ byte PAGE_OVERLAY_CONDITIONAL_PROCESSING = 0x46;
+ byte RESOURCE_USAGE_ATTRIBUTE = 0x47;
+ byte MEASUREMENT_UNITS = 0x4B;
+ byte OBJECT_AREA_SIZE = 0x4C;
+ byte AREA_DEFINITION = 0x4D;
+ byte COLOR_SPECIFICATION = 0x4E;
+ byte ENCODING_SCHEME_ID = 0x50;
+ byte MEDIUM_MAP_PAGE_NUMBER = 0x56;
+ byte OBJECT_BYTE_EXTENT = 0x57;
+ byte OBJECT_STRUCTURED_FIELD_OFFSET = 0x58;
+ byte OBJECT_STRUCTURED_FIELD_EXTENT = 0x59;
+ byte OBJECT_OFFSET = 0x5A;
+ byte FONT_HORIZONTAL_SCALE_FACTOR = 0x5D;
+ byte OBJECT_COUNT = 0x5E;
+ byte OBJECT_DATE_AND_TIMESTAMP = 0x62;
+ byte COMMENT = 0x65;
+ byte MEDIUM_ORIENTATION = 0x68;
+ byte RESOURCE_OBJECT_INCLUDE = 0x6C;
+ byte PRESENTATION_SPACE_RESET_MIXING = 0x70;
+ byte PRESENTATION_SPACE_MIXING_RULE = 0x71;
+ byte UNIVERSAL_DATE_AND_TIMESTAMP = 0x72;
+ byte TONER_SAVER = 0x74;
+ byte COLOR_FIDELITY = 0x75;
+ byte FONT_FIDELITY = 0x78;
+ byte ATTRIBUTE_QUALIFIER = (byte)0x80;
+ byte PAGE_POSITION_INFORMATION = (byte)0x81;
+ byte PARAMETER_VALUE = (byte)0x82;
+ byte PRESENTATION_CONTROL = (byte)0x83;
+ byte FONT_RESOLUTION_AND_METRIC_TECHNOLOGY = (byte)0x84;
+ byte FINISHING_OPERATION = (byte)0x85;
+ byte TEXT_FIDELITY = (byte)0x86;
+ byte MEDIA_FIDELITY = (byte)0x87;
+ byte FINISHING_FIDELITY = (byte)0x88;
+ byte DATA_OBJECT_FONT_DESCRIPTOR = (byte)0x8B;
+ byte LOCALE_SELECTOR = (byte)0x8C;
+ byte UP3I_FINISHING_OPERATION = (byte)0x8E;
+ byte COLOR_MANAGEMENT_RESOURCE_DESCRIPTOR = (byte)0x91;
+ byte RENDERING_INTENT = (byte)0x95;
+ byte CMR_TAG_FIDELITY = (byte)0x96;
+ byte DEVICE_APPEARANCE = (byte)0x97;
+}

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@...
For additional commands, e-mail: fop-commits-help@...

--
Kind regards,

Adrian Cumiskey.

DO NOT REPLY [Bug 48290] AFP Renderer: AttributeQualifier Triplet occurs before TLE Value

2009-11-26T03:23:48Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48290

--- Comment #1 from Chris Bowditch <bowditch_chris@...> 2009-11-26 03:23:48 UTC ---
bug fix committed in revision 884526

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48255] [PATCH] Revisited implementation of PDFRectangle and PDFLink (derived from new PDFAnnotation dictionary)

2009-11-26T03:19:25Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48255

Gerald Buchgraber <gerald.buchgraber@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|PDFRectangle |[PATCH] Revisited
| |implementation of
| |PDFRectangle and PDFLink
| |(derived from new
| |PDFAnnotation dictionary)

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48255] PDFRectangle

2009-11-26T03:01:48Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48255

--- Comment #2 from Gerald Buchgraber <gerald.buchgraber@...> 2009-11-26 03:01:47 UTC ---
Created an attachment (id=24622)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24622)
[PATCH] Revisited implementation of PDFRectangle and PDFLink

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48290] New: AFP Renderer: AttributeQualifier Triplet occurs before TLE Value

2009-11-26T02:53:54Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48290

Summary: AFP Renderer: AttributeQualifier Triplet occurs before
TLE Value
Product: Fop
Version: 1.0dev
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: fop-dev@...
ReportedBy: bowditch_chris@...

Order of AttributeQualifier and Value Triplet were switched for TLE by
following commit:
http://mail-archives.apache.org/mod_mbox/xmlgraphics-fop-commits/200910.mbox/%3c20091022132054.A5C7B23888CE@...%3e

This means TLE structure no longer conforms to AFP specification:
http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3M5M00/5.82.2?SHELF=APSBK320&DT=20010307105730

The fix is fairly straight forward and follows shortly.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: svn commit: r828678 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/afp: goca/ modca/ modca/triplets/

2009-11-26T02:49:58Z

acumiskey@... wrote:
> Author: acumiskey
> Date: Thu Oct 22 13:20:53 2009
> New Revision: 828678

Hi Adrian,

there is a bug in this commit. AttributeQualifier was moved from end of
TLE to be between Attribute Name and Attribute Value.

I will commit a fix shortly.

Chris

>
> URL: http://svn.apache.org/viewvc?rev=828678&view=rev
> Log:
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=47941
> Created Triplet interface.
> Created new AttributeValueTriplet and AttributeQualifierTriplet.
> Promoted truncate() from GraphicsCharacterString to AbstractAFPObject so it can be reused for AttributeValueTriplet.
>
> Added:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java
> xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java?rev=828678&r1=828677&r2=828678&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsCharacterString.java Thu Oct 22 13:20:53 2009
> @@ -45,7 +45,7 @@
> */
> public GraphicsCharacterString(String str, int x, int y) {
> super(x, y);
> - this.str = truncate(str);
> + this.str = truncate(str, MAX_STR_LEN);
> }
>
> /**
> @@ -57,7 +57,7 @@
> */
> public GraphicsCharacterString(String str) {
> super(null);
> - this.str = truncate(str);
> + this.str = truncate(str, MAX_STR_LEN);
> }
>
> /** {@inheritDoc} */
> @@ -83,20 +83,6 @@
> }
>
> /**
> - * Truncates the string as necessary
> - *
> - * @param str a character string
> - * @return a possibly truncated string
> - */
> - private String truncate(String str) {
> - if (str.length() > MAX_STR_LEN) {
> - str = str.substring(0, MAX_STR_LEN);
> - log.warn("truncated character string, longer than " + MAX_STR_LEN + " chars");
> - }
> - return str;
> - }
> -
> - /**
> * Returns the text string as an encoded byte array
> *
> * @return the text string as an encoded byte array
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java?rev=828678&r1=828677&r2=828678&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractAFPObject.java Thu Oct 22 13:20:53 2009
> @@ -43,7 +43,7 @@
> /** the structured field class id */
> protected static final byte SF_CLASS = (byte)0xD3;
>
> - private static final byte[] SF_HEADER = new byte[] {
> + protected static final byte[] SF_HEADER = new byte[] {
> 0x5A, // Structured field identifier
> 0x00, // Length byte 1
> 0x10, // Length byte 2
> @@ -177,6 +177,21 @@
> }
> }
>
> + /**
> + * Truncates the string as necessary
> + *
> + * @param str a character string
> + * @param maxLength the maximum length allowed for the string
> + * @return a possibly truncated string
> + */
> + protected String truncate(String str, int maxLength) {
> + if (str.length() > maxLength) {
> + str = str.substring(0, maxLength);
> + log.warn("truncated character string '" + str + "', longer than " + maxLength + " chars");
> + }
> + return str;
> + }
> +
> /** structured field type codes */
> public interface Type {
>
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java?rev=828678&r1=828677&r2=828678&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java Thu Oct 22 13:20:53 2009
> @@ -27,9 +27,12 @@
>
> import org.apache.fop.afp.modca.Registry.ObjectType;
> import org.apache.fop.afp.modca.triplets.AbstractTriplet;
> +import org.apache.fop.afp.modca.triplets.AttributeQualifierTriplet;
> +import org.apache.fop.afp.modca.triplets.AttributeValueTriplet;
> import org.apache.fop.afp.modca.triplets.CommentTriplet;
> import org.apache.fop.afp.modca.triplets.FullyQualifiedNameTriplet;
> import org.apache.fop.afp.modca.triplets.ObjectClassificationTriplet;
> +import org.apache.fop.afp.modca.triplets.Triplet;
>
> /**
> * A MODCA structured object base class providing support for Triplets
> @@ -37,7 +40,7 @@
> public class AbstractTripletStructuredObject extends AbstractStructuredObject {
>
> /** list of object triplets */
> - protected List/*<AbstractTriplet>*/ triplets = new java.util.ArrayList/*<AbstractTriplet>*/();
> + protected List/*<Triplet>*/ triplets = new java.util.ArrayList/*<Triplet>*/();
>
> /**
> * Returns the triplet data length
> @@ -109,7 +112,7 @@
> *
> * @param triplet the triplet to add
> */
> - protected void addTriplet(AbstractTriplet triplet) {
> + protected void addTriplet(Triplet triplet) {
> triplets.add(triplet);
> }
>
> @@ -130,7 +133,7 @@
> }
>
> /**
> - * Sets the fully qualified name of this resource
> + * Sets the fully qualified name of this structured field
> *
> * @param fqnType the fully qualified name type of this resource
> * @param fqnFormat the fully qualified name format of this resource
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java?rev=828678&r1=828677&r2=828678&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/TagLogicalElement.java Thu Oct 22 13:20:53 2009
> @@ -21,9 +21,10 @@
>
> import java.io.IOException;
> import java.io.OutputStream;
> -import java.io.UnsupportedEncodingException;
>
> -import org.apache.fop.afp.AFPConstants;
> +import org.apache.fop.afp.modca.triplets.AttributeQualifierTriplet;
> +import org.apache.fop.afp.modca.triplets.AttributeValueTriplet;
> +import org.apache.fop.afp.modca.triplets.FullyQualifiedNameTriplet;
> import org.apache.fop.afp.util.BinaryUtils;
>
> /**
> @@ -45,7 +46,7 @@
> * effect on the appearance of a document when it is presented.
> * <p/>
> */
> -public class TagLogicalElement extends AbstractAFPObject {
> +public class TagLogicalElement extends AbstractTripletStructuredObject {
>
> /**
> * Name of the key, used within the TLE
> @@ -75,77 +76,43 @@
> this.tleID = tleID;
> }
>
> - /** {@inheritDoc} */
> - public void writeToStream(OutputStream os) throws IOException {
> + /**
> + * Sets the attribute value of this structured field
> + *
> + * @param value the attribute value
> + */
> + public void setAttributeValue(String value) {
> + addTriplet(new AttributeValueTriplet(value));
> + }
>
> - // convert name and value to ebcdic
> - byte[] tleByteName = null;
> - byte[] tleByteValue = null;
> - try {
> - tleByteName = name.getBytes(AFPConstants.EBCIDIC_ENCODING);
> - tleByteValue = value.getBytes(AFPConstants.EBCIDIC_ENCODING);
> - } catch (UnsupportedEncodingException usee) {
> - tleByteName = name.getBytes();
> - tleByteValue = value.getBytes();
> - log.warn(
> - "Constructor:: UnsupportedEncodingException translating the name "
> - + name);
> - }
> -
> - byte[] data = new byte[27 + tleByteName.length + tleByteValue.length];
> -
> - data[0] = 0x5A;
> - // Set the total record length
> - byte[] rl1
> - = BinaryUtils.convert(26 + tleByteName.length + tleByteValue.length, 2);
> - //Ignore first byte
> - data[1] = rl1[0];
> - data[2] = rl1[1];
> -
> - // Structured field ID for a TLE
> - data[3] = (byte) 0xD3;
> - data[4] = (byte) Type.ATTRIBUTE;
> - data[5] = (byte) Category.PROCESS_ELEMENT;
> -
> - data[6] = 0x00; // Reserved
> - data[7] = 0x00; // Reserved
> - data[8] = 0x00; // Reserved
> -
> - //Use 2 triplets, attribute name and value (the key for indexing)
> -
> - byte[] rl2 = BinaryUtils.convert(tleByteName.length + 4, 1);
> - data[9] = rl2[0]; // length of the triplet, including this field
> - data[10] = 0x02; //Identifies it as a FQN triplet
> - data[11] = 0x0B; // GID format
> - data[12] = 0x00;
> -
> - // write out TLE name
> - int pos = 13;
> - for (int i = 0; i < tleByteName.length; i++) {
> - data[pos++] = tleByteName[i];
> - }
> -
> - byte[] rl3 = BinaryUtils.convert(tleByteValue.length + 4, 1);
> - data[pos++] = rl3[0]; // length of the triplet, including this field
> - data[pos++] = 0x36; //Identifies the triplet, attribute value
> - data[pos++] = 0x00; // Reserved
> - data[pos++] = 0x00; // Reserved
> -
> - for (int i = 0; i < tleByteValue.length; i++) {
> - data[pos++] = tleByteValue[i];
> - }
> - // attribute qualifier
> - data[pos++] = 0x0A;
> - data[pos++] = (byte)0x80;
> - byte[] id = BinaryUtils.convert(tleID, 4);
> - for (int i = 0; i < id.length; i++) {
> - data[pos++] = id[i];
> - }
> - byte[] level = BinaryUtils.convert(1, 4);
> - for (int i = 0; i < level.length; i++) {
> - data[pos++] = level[i];
> - }
> + /**
> + * Sets the attribute qualifier of this structured field
> + *
> + * @param seqNumber the attribute sequence number
> + * @param levNumber the attribute level number
> + */
> + public void setAttributeQualifier(int seqNumber, int levNumber) {
> + addTriplet(new AttributeQualifierTriplet(seqNumber, levNumber));
> + }
>
> + /** {@inheritDoc} */
> + public void writeToStream(OutputStream os) throws IOException {
> + setFullyQualifiedName(
> + FullyQualifiedNameTriplet.TYPE_ATTRIBUTE_GID,
> + FullyQualifiedNameTriplet.FORMAT_CHARSTR,
> + name);
> + setAttributeQualifier(tleID, 1);
> + setAttributeValue(value);
> +
> + byte[] data = new byte[SF_HEADER.length];
> + copySF(data, Type.ATTRIBUTE, Category.PROCESS_ELEMENT);
> +
> + int tripletDataLength = getTripletDataLength();
> + byte[] l = BinaryUtils.convert(data.length + tripletDataLength - 1, 2);
> + data[1] = l[0];
> + data[2] = l[1];
> os.write(data);
> +
> + writeTriplets(os);
> }
> }
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java?rev=828678&r1=828677&r2=828678&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AbstractTriplet.java Thu Oct 22 13:20:53 2009
> @@ -19,70 +19,12 @@
>
> package org.apache.fop.afp.modca.triplets;
>
> -import org.apache.fop.afp.Streamable;
> -import org.apache.fop.afp.StructuredData;
> +import org.apache.fop.afp.modca.AbstractAFPObject;
>
> /**
> * A simple implementation of a MOD:CA triplet
> */
> -public abstract class AbstractTriplet implements Streamable, StructuredData {
> - public static final byte CODED_GRAPHIC_CHARACTER_SET_GLOBAL_IDENTIFIER = 0x01;
> -
> - /** Triplet identifiers */
> - public static final byte FULLY_QUALIFIED_NAME = 0x02;
> - public static final byte MAPPING_OPTION = 0x04;
> - public static final byte OBJECT_CLASSIFICATION = 0x10;
> - public static final byte MODCA_INTERCHANGE_SET = 0x18;
> - public static final byte FONT_DESCRIPTOR_SPECIFICATION = 0x1F;
> - public static final byte OBJECT_FUNCTION_SET_SPECIFICATION = 0x21;
> - public static final byte EXTENDED_RESOURCE_LOCAL_IDENTIFIER = 0x22;
> - public static final byte RESOURCE_LOCAL_IDENTIFIER = 0x24;
> - public static final byte RESOURCE_SECTION_NUMBER = 0x25;
> - public static final byte CHARACTER_ROTATION = 0x26;
> - public static final byte OBJECT_BYTE_OFFSET = 0x2D;
> - public static final byte ATTRIBUTE_VALUE = 0x36;
> - public static final byte DESCRIPTOR_POSITION = 0x43;
> - public static final byte MEDIA_EJECT_CONTROL = 0x45;
> - public static final byte PAGE_OVERLAY_CONDITIONAL_PROCESSING = 0x46;
> - public static final byte RESOURCE_USAGE_ATTRIBUTE = 0x47;
> - public static final byte MEASUREMENT_UNITS = 0x4B;
> - public static final byte OBJECT_AREA_SIZE = 0x4C;
> - public static final byte AREA_DEFINITION = 0x4D;
> - public static final byte COLOR_SPECIFICATION = 0x4E;
> - public static final byte ENCODING_SCHEME_ID = 0x50;
> - public static final byte MEDIUM_MAP_PAGE_NUMBER = 0x56;
> - public static final byte OBJECT_BYTE_EXTENT = 0x57;
> - public static final byte OBJECT_STRUCTURED_FIELD_OFFSET = 0x58;
> - public static final byte OBJECT_STRUCTURED_FIELD_EXTENT = 0x59;
> - public static final byte OBJECT_OFFSET = 0x5A;
> - public static final byte FONT_HORIZONTAL_SCALE_FACTOR = 0x5D;
> - public static final byte OBJECT_COUNT = 0x5E;
> - public static final byte OBJECT_DATE_AND_TIMESTAMP = 0x62;
> - public static final byte COMMENT = 0x65;
> - public static final byte MEDIUM_ORIENTATION = 0x68;
> - public static final byte RESOURCE_OBJECT_INCLUDE = 0x6C;
> - public static final byte PRESENTATION_SPACE_RESET_MIXING = 0x70;
> - public static final byte PRESENTATION_SPACE_MIXING_RULE = 0x71;
> - public static final byte UNIVERSAL_DATE_AND_TIMESTAMP = 0x72;
> - public static final byte TONER_SAVER = 0x74;
> - public static final byte COLOR_FIDELITY = 0x75;
> - public static final byte FONT_FIDELITY = 0x78;
> - public static final byte ATTRIBUTE_QUALIFIER = (byte)0x80;
> - public static final byte PAGE_POSITION_INFORMATION = (byte)0x81;
> - public static final byte PARAMETER_VALUE = (byte)0x82;
> - public static final byte PRESENTATION_CONTROL = (byte)0x83;
> - public static final byte FONT_RESOLUTION_AND_METRIC_TECHNOLOGY = (byte)0x84;
> - public static final byte FINISHING_OPERATION = (byte)0x85;
> - public static final byte TEXT_FIDELITY = (byte)0x86;
> - public static final byte MEDIA_FIDELITY = (byte)0x87;
> - public static final byte FINISHING_FIDELITY = (byte)0x88;
> - public static final byte DATA_OBJECT_FONT_DESCRIPTOR = (byte)0x8B;
> - public static final byte LOCALE_SELECTOR = (byte)0x8C;
> - public static final byte UP3I_FINISHING_OPERATION = (byte)0x8E;
> - public static final byte COLOR_MANAGEMENT_RESOURCE_DESCRIPTOR = (byte)0x91;
> - public static final byte RENDERING_INTENT = (byte)0x95;
> - public static final byte CMR_TAG_FIDELITY = (byte)0x96;
> - public static final byte DEVICE_APPEARANCE = (byte)0x97;
> +public abstract class AbstractTriplet extends AbstractAFPObject implements Triplet {
>
> /** the triplet identifier */
> protected final byte id;
>
> Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java?rev=828678&view=auto
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java (added)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeQualifierTriplet.java Thu Oct 22 13:20:53 2009
> @@ -0,0 +1,48 @@
> +package org.apache.fop.afp.modca.triplets;
> +
> +import java.io.IOException;
> +import java.io.OutputStream;
> +
> +import org.apache.fop.afp.util.BinaryUtils;
> +
> +/**
> + * The attribute qualifier triplet is used to specify a qualifier for a document
> + * attribute.
> + */
> +public class AttributeQualifierTriplet extends AbstractTriplet {
> +
> + private int seqNumber;
> + private int levNumber;
> +
> + /**
> + * Main constructor
> + *
> + * @param seqNumber the attribute qualifier sequence number
> + * @param levNumber the attribute qualifier level number
> + */
> + public AttributeQualifierTriplet(int seqNumber, int levNumber) {
> + super(ATTRIBUTE_QUALIFIER);
> + this.seqNumber = seqNumber;
> + this.levNumber = levNumber;
> + }
> +
> + /** {@inheritDoc} */
> + public void writeToStream(OutputStream os) throws IOException {
> + byte[] data = getData();
> + byte[] id = BinaryUtils.convert(seqNumber, 4);
> + System.arraycopy(id, 0, data, 2, id.length);
> + byte[] level = BinaryUtils.convert(levNumber, 4);
> + System.arraycopy(level, 0, data, 6, level.length);
> + os.write(data);
> + }
> +
> + /** {@inheritDoc} */
> + public int getDataLength() {
> + return 10;
> + }
> +
> + /** {@inheritDoc} */
> + public String toString() {
> + return "seqNumber=" + seqNumber + ", levNumber=" + levNumber;
> + }
> +}
>
> Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java?rev=828678&view=auto
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java (added)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/AttributeValueTriplet.java Thu Oct 22 13:20:53 2009
> @@ -0,0 +1,53 @@
> +package org.apache.fop.afp.modca.triplets;
> +
> +import java.io.IOException;
> +import java.io.OutputStream;
> +import java.io.UnsupportedEncodingException;
> +
> +import org.apache.fop.afp.AFPConstants;
> +
> +/**
> + * The attribute value triplet is used to specify a value for a document
> + * attribute.
> + */
> +public class AttributeValueTriplet extends AbstractTriplet {
> + private String attVal;
> +
> + /**
> + * Main constructor
> + *
> + * @param attVal an attribute value
> + */
> + public AttributeValueTriplet(String attVal) {
> + super(ATTRIBUTE_VALUE);
> + this.attVal = truncate(attVal, MAX_LENGTH - 4);
> + }
> +
> + /** {@inheritDoc} */
> + public void writeToStream(OutputStream os) throws IOException {
> + byte[] data = super.getData();
> + data[2] = 0x00; // Reserved
> + data[3] = 0x00; // Reserved
> +
> + // convert name and value to ebcdic
> + byte[] tleByteValue = null;
> + try {
> + tleByteValue = attVal.getBytes(AFPConstants.EBCIDIC_ENCODING);
> + } catch (UnsupportedEncodingException usee) {
> + tleByteValue = attVal.getBytes();
> + throw new IllegalArgumentException(attVal + " encoding failed");
> + }
> + System.arraycopy(tleByteValue, 0, data, 4, tleByteValue.length);
> + os.write(data);
> + }
> +
> + /** {@inheritDoc} */
> + public int getDataLength() {
> + return 4 + attVal.length();
> + }
> +
> + /** {@inheritDoc} */
> + public String toString() {
> + return attVal;
> + }
> +}
>
> Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java?rev=828678&view=auto
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java (added)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/triplets/Triplet.java Thu Oct 22 13:20:53 2009
> @@ -0,0 +1,66 @@
> +package org.apache.fop.afp.modca.triplets;
> +
> +import org.apache.fop.afp.Streamable;
> +import org.apache.fop.afp.StructuredData;
> +
> +public interface Triplet extends Streamable, StructuredData {
> + int MAX_LENGTH = 254;
> +
> + byte CODED_GRAPHIC_CHARACTER_SET_GLOBAL_IDENTIFIER = 0x01;
> +
> + /** Triplet identifiers */
> + byte FULLY_QUALIFIED_NAME = 0x02;
> + byte MAPPING_OPTION = 0x04;
> + byte OBJECT_CLASSIFICATION = 0x10;
> + byte MODCA_INTERCHANGE_SET = 0x18;
> + byte FONT_DESCRIPTOR_SPECIFICATION = 0x1F;
> + byte OBJECT_FUNCTION_SET_SPECIFICATION = 0x21;
> + byte EXTENDED_RESOURCE_LOCAL_IDENTIFIER = 0x22;
> + byte RESOURCE_LOCAL_IDENTIFIER = 0x24;
> + byte RESOURCE_SECTION_NUMBER = 0x25;
> + byte CHARACTER_ROTATION = 0x26;
> + byte OBJECT_BYTE_OFFSET = 0x2D;
> + byte ATTRIBUTE_VALUE = 0x36;
> + byte DESCRIPTOR_POSITION = 0x43;
> + byte MEDIA_EJECT_CONTROL = 0x45;
> + byte PAGE_OVERLAY_CONDITIONAL_PROCESSING = 0x46;
> + byte RESOURCE_USAGE_ATTRIBUTE = 0x47;
> + byte MEASUREMENT_UNITS = 0x4B;
> + byte OBJECT_AREA_SIZE = 0x4C;
> + byte AREA_DEFINITION = 0x4D;
> + byte COLOR_SPECIFICATION = 0x4E;
> + byte ENCODING_SCHEME_ID = 0x50;
> + byte MEDIUM_MAP_PAGE_NUMBER = 0x56;
> + byte OBJECT_BYTE_EXTENT = 0x57;
> + byte OBJECT_STRUCTURED_FIELD_OFFSET = 0x58;
> + byte OBJECT_STRUCTURED_FIELD_EXTENT = 0x59;
> + byte OBJECT_OFFSET = 0x5A;
> + byte FONT_HORIZONTAL_SCALE_FACTOR = 0x5D;
> + byte OBJECT_COUNT = 0x5E;
> + byte OBJECT_DATE_AND_TIMESTAMP = 0x62;
> + byte COMMENT = 0x65;
> + byte MEDIUM_ORIENTATION = 0x68;
> + byte RESOURCE_OBJECT_INCLUDE = 0x6C;
> + byte PRESENTATION_SPACE_RESET_MIXING = 0x70;
> + byte PRESENTATION_SPACE_MIXING_RULE = 0x71;
> + byte UNIVERSAL_DATE_AND_TIMESTAMP = 0x72;
> + byte TONER_SAVER = 0x74;
> + byte COLOR_FIDELITY = 0x75;
> + byte FONT_FIDELITY = 0x78;
> + byte ATTRIBUTE_QUALIFIER = (byte)0x80;
> + byte PAGE_POSITION_INFORMATION = (byte)0x81;
> + byte PARAMETER_VALUE = (byte)0x82;
> + byte PRESENTATION_CONTROL = (byte)0x83;
> + byte FONT_RESOLUTION_AND_METRIC_TECHNOLOGY = (byte)0x84;
> + byte FINISHING_OPERATION = (byte)0x85;
> + byte TEXT_FIDELITY = (byte)0x86;
> + byte MEDIA_FIDELITY = (byte)0x87;
> + byte FINISHING_FIDELITY = (byte)0x88;
> + byte DATA_OBJECT_FONT_DESCRIPTOR = (byte)0x8B;
> + byte LOCALE_SELECTOR = (byte)0x8C;
> + byte UP3I_FINISHING_OPERATION = (byte)0x8E;
> + byte COLOR_MANAGEMENT_RESOURCE_DESCRIPTOR = (byte)0x91;
> + byte RENDERING_INTENT = (byte)0x95;
> + byte CMR_TAG_FIDELITY = (byte)0x96;
> + byte DEVICE_APPEARANCE = (byte)0x97;
> +}
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-commits-unsubscribe@...
> For additional commands, e-mail: fop-commits-help@...
>
>
>

DO NOT REPLY [Bug 48237] afp renderer does not respect image color settings for svg

2009-11-26T00:24:16Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48237

--- Comment #5 from Chris Bowditch <bowditch_chris@...> 2009-11-26 00:24:13 UTC ---
Jeremias,

our local B+W AFP Printer handles this and converts the colour SVG to B+W on
the fly. However, one of our customers with B+W Printers said the AFP failed to
print due to the colour in the GOCA objects. We believe this is a bug and
should be fixed.

Thanks,

Chris

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: Thoughts on Bug 48237

2009-11-25T12:26:38Z

Hi Peter

See my question I attached to bug 48237. But of course, the ideal case
is to have the color converted properly if possible.

On 24.11.2009 15:30:30 Peter Hancock wrote:
> At present FOP does not respect an image color setting of 'b+w' when
> rendering svg to afp (see Bug 48237)
>
> According to the AFP spec (
> http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3N1M00/7.47.1?SHELF=APSBK320&DT=20001002123303)
> it does not seem possible to specify a grayscale color space, and so my
> question is how should colour be controlled?

I think there are two general approached besides just using RGB:
- CMYK with only the K component (that is a clear indication that we
want a fully black color or shades of that)
- using a Highlight color space (assuming black as a highlight/spot
color)

But I have no experience with highlight colors on AFP, so I can't tell
if it would work.

> Since AFPGraphics2D is responsible for setting the color on the MODCA
> GraphicsObject prior to calling drawing methods, would a sensible fix to
> the problem be to convert the awt.Color before calling this setter?

Probably. I have some tentative need to have a general color conversion
facility for FOP (not just AFP). For example, at some point we may want
to have color conversion from sRGB to CMYK. Another use case for a color
converter would be a detector which would convert any grayscale color (R,
G, B or C, M, Y with equal values) to a CMYK value (with only K) which
might in certain situations improve output quality because otherwise a
RIP might be inclined to mix black by mixing CMY. I can imagine that a
general interface could be defined for which there could be multiple
implementations depending on the use case and configuration. For the
present case, one implementation of that interface per color setting
could be written for AFP. Not sure, just brainstorming.

> Any thoughts would be most welcome,
>
> Pete

Jeremias Maerki

DO NOT REPLY [Bug 48237] afp renderer does not respect image color settings for svg

2009-11-25T12:10:43Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48237

--- Comment #4 from Jeremias Maerki <jeremias@...> 2009-11-25 12:10:42 UTC ---
Peter, I understand the bug report (all colors should ideally be transformed to
grayscales when AFP output is configured to 8bit grayscales), but what I'm
curious about is whether the current behaviour actually caused a problem on
your side. So far I have no reports that the colors cause any problems. The
systems seem to be able to handle them correctly, even on a monochrome system.
Only the bitmap images are currently reduced in color depth most of all because
that has a huge impact on file size.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 47311] [PATCH] Support for bleed, trim and crop box and scaling

2009-11-25T12:01:08Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=47311

--- Comment #44 from Jeremias Maerki <jeremias@...> 2009-11-25 12:01:00 UTC ---
(In reply to comment #43)

> Hi All,
>
> We have found one issue during testing this new feature.
> The issue lies in PageBoundaries.java in calculating crop/bleed boxes.
>
> The offsets order is: [top, right, bottom, left], so to calculate Y size of
> the final box we should use the 'bottom' instead of 'top' offset :
>
>
> return new Rectangle(originalRect.x - coords[3],
> - originalRect.y - coords[0],
> + originalRect.y - coords[2],
> originalRect.width + coords[3] + coords[1],
> originalRect.height + coords[0] + coords[2]);
>
>
>
> Please find in the attachments the fix patch. (Comment#41)
> Also I have attached the full patch for FOP-0.95 version (Comment#42) if
> somebody will have a need to use this feature with previous version.

I've taken a look at that. Thanks for spotting the problem, Boris, but your
solution was not the right one. But you brought me on the right track. I've
just found out what our mistake is: PDF specifies the boxes as "rectangles"
which are defined as "llx lly urx ury" (i.e. lower left to upper right). But
our/FOP's Rectangle2D objects are actually "upper left to lower right". In
PageBoundaries we're still in FOP's coordinate system which starts at the upper
left. So we have to calculate the right values for the default PDF coordinate
system. Boris' change would have broken a test case and created a bug on the
bitmap production side. So the right change is to do a transformation from
FOP's internal coordinate system to PDF's default one in PDFDocumentHandler:
http://svn.apache.org/viewvc?rev=884241&view=rev

Boris, can you please verify that this fix also work for you? Thanks!

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48264] [PATCH] PS Renderer failed to process images using CMYK color space

2009-11-25T07:55:59Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48264

Jeremias Maerki <jeremias@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #6 from Jeremias Maerki <jeremias@...> 2009-11-25 07:55:58 UTC ---
So the code was basically already there (due to the JPEG CMYK support) and only
had to be enabled. Your patch could actually be further simplified. The check
for the component count is not necessary as that is done inside
ImageEncodingHelper already.

Patch applied: http://svn.apache.org/viewvc?rev=884159&view=rev
Thanks!

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48237] afp renderer does not respect image color settings for svg

2009-11-25T07:39:34Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48237

--- Comment #3 from Venkat Reddy <vanukuri.venkat@...> 2009-11-25 07:39:33 UTC ---
I have checked this bug with FOP 0.95 version initially, but later understood
that FOPTrunk is having this problem instead of FOP 0.95.

The Bitmaps are rendering according the image mode configuration (either b+w or
color) in both FOP 0.95 and FOPTrunk.

The problem is with SVGs, the image mode is not respected in case of SVGs in
FOPTrunk.

So, It is a valid bug in FOPTrunk....

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48255] PDFRectangle

2009-11-25T07:27:58Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48255

--- Comment #1 from Jeremias Maerki <jeremias@...> 2009-11-25 07:27:58 UTC ---
Patches are welcome to improve FOP. PDFRectangle could be changed to be a
subclass of PDFArray and PDFLink should actually be a PDFDictionary subclass at
some point. Want to give it a try?

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48227] RenderContext property PDF_CONTEXT is set twice

2009-11-25T07:23:29Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48227

Jeremias Maerki <jeremias@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #1 from Jeremias Maerki <jeremias@...> 2009-11-25 07:23:29 UTC ---
Changed: http://svn.apache.org/viewvc?rev=884138&view=rev
Thanks.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48211] How to change/set 128-bit RC4 encryption level in secured PDF

2009-11-25T07:12:12Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48211

Jeremias Maerki <jeremias@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|general |pdf
Version|0.95 |1.0dev
Severity|major |enhancement

--- Comment #1 from Jeremias Maerki <jeremias@...> 2009-11-25 07:12:11 UTC ---
Support for encryption larger than 40bits has not been implemented, yet.
Patches are welcome.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48048] [PATCH] AFP renderer outputs incorrect values for GBAR ( Graphics Begin Area )

2009-11-25T07:05:27Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48048

Jeremias Maerki <jeremias@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #1 from Jeremias Maerki <jeremias@...> 2009-11-25 07:05:24 UTC ---
Thanks for spotting this and sending a patch! It is applied now:
http://svn.apache.org/viewvc?rev=884129&view=rev

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

RE: Support for Arabic in FOP

2009-11-24T10:13:15Z

Hi Prakash,

I need fop to be able to handle arabic text. I tried to generate a PDF file with the Sebastian fop code, but the arabic text is not correctly shaped. I must be doing something wrong...
Can you please send me an example?

Thanks in advance.

best regards,
Sérgio Lopes

Prakash sen wrote:

Hi,

I am not sure on the licensing part as sebastian did some changes in FOP code and he provided me the jars. And as per what i had checked those jar print arabic correctly.
Possibly he will only be able to answer and I am nots ure whether the change was made keeping FOP standards. He was planning to do bidi algorithm, no idea whether he worked on it later and whether he contribuited the below change to FOP.

Below were his comments -
If I set the writing-mode to rl-tb my text is flipped vertical. This happens
because the CTM class rotates the transformation matrix for rendering
according to the writing mode. If I want to write right-to-left this has
nothing to do with mirroring of cause and I disabled it, because I want to
print arabic text. So what is the purpose of mirroring in rl-tb
writing-mode? What errors will appear if I disable the CTM.getWMctm()
function that does the mirroring according to the writing-mode?
I achived printing (pdf) arabic text after some weeks of work ignoring any
xsl:fo recommendations. The most things I did in the TextLayoutManager. Now
I'm thinking about implementing it according to the recommendations and the
BIDI algorithm.

Hi Prakash,
you can download the version of FOP that I use to print Arabic script from
www.anneundsebp.de/fop/fop.html

I hope it works for you. Unfortunately I don't understand Arabic but I know
that there are still some problems with the type setting. Maybe you can
inform me about bugs you'll find.
I'll add some explanations and the source code in a few days.

Regards
Sebastian

Re: Thoughts on Bug 48237

2009-11-24T09:05:21Z

Hi Venkat,

The bug is with svg images (embedded and extrernal) - you are correct that it works with bitmaps as demonstrated in the files attached to the bug report. Were you able to test those?

Cheers,
Pete

On Tue, Nov 24, 2009 at 4:59 PM, Venkat Reddy <vanukuri.venkat@...> wrote:

Hi Peter,

There is no bug with this functionality. You can have a look at the FO file that I have used...

1. Update the configuration file for the image mode (b+w or color)
2. Run the following command from the command prompt...
*C:\mywork\FOP\fop-0.95> fop -c C:\fop.xconf -fo C:\mywork\JavaXSLTSamples\XSLFOSamples\hello.fo -afp C:\mywork\JavaXSLTSamples\XSLFOSamples\hellotest.afp
*
According to the mode, the image will be rendered with color or black and white...

Thanks,
Venkat.

Peter Hancock wrote:

At present FOP does not respect an image color setting of 'b+w' when rendering svg to afp (see Bug 48237)

According to the AFP spec (http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3N1M00/7.47.1?SHELF=APSBK320&DT=20001002123303 <http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3N1M00/7.47.1?SHELF=APSBK320&DT=20001002123303>) it does not seem possible to specify a grayscale color space, and so my question is how should colour be controlled?

Since AFPGraphics2D is responsible for setting the color on the MODCA GraphicsObject prior to calling drawing methods, would a sensible fix to the problem be to convert the awt.Color before calling this setter?

Any thoughts would be most welcome,

Pete

DO NOT REPLY [Bug 48237] afp renderer does not respect image color settings for svg

2009-11-24T08:59:36Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48237

--- Comment #2 from Venkat Reddy <vanukuri.venkat@...> 2009-11-24 08:59:36 UTC ---
Created an attachment (id=24606)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24606)
Input FO file

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: Thoughts on Bug 48237

2009-11-24T08:59:24Z

Hi Peter,

There is no bug with this functionality. You can have a look at the FO
file that I have used...

1. Update the configuration file for the image mode (b+w or color)
2. Run the following command from the command prompt...
*C:\mywork\FOP\fop-0.95> fop -c C:\fop.xconf -fo
C:\mywork\JavaXSLTSamples\XSLFOSamples\hello.fo -afp
C:\mywork\JavaXSLTSamples\XSLFOSamples\hellotest.afp
*
According to the mode, the image will be rendered with color or black
and white...

Thanks,
Venkat.

Peter Hancock wrote:

> At present FOP does not respect an image color setting of 'b+w' when
> rendering svg to afp (see Bug 48237)
>
> According to the AFP spec
> (http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3N1M00/7.47.1?SHELF=APSBK320&DT=20001002123303
> <http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3N1M00/7.47.1?SHELF=APSBK320&DT=20001002123303>)
> it does not seem possible to specify a grayscale color space, and so
> my question is how should colour be controlled?
>
> Since AFPGraphics2D is responsible for setting the color on the MODCA
> GraphicsObject prior to calling drawing methods, would a sensible
> fix to the problem be to convert the awt.Color before calling this setter?
>
> Any thoughts would be most welcome,
>
> Pete

<?xml version="1.0" encoding="UTF-8"?>
<fo:root xmlns:fo="http://www.w3.org/1999/XSL/Format">
<fo:layout-master-set>
<fo:simple-page-master master-name="page">
<fo:region-body
margin-right="0.5in"
margin-left="0.5in"
margin-bottom="1in"
margin-top="0.5in"
region-name="body"/>
</fo:simple-page-master>
</fo:layout-master-set>
<fo:page-sequence master-reference="page">
<fo:flow flow-name="body">
<fo:block break-before="page" top="4in">
Testing image <fo:external-graphic src="C:\mywork\JavaXSLTSamples\XSLFOSamples\blue.png"/> in between words
</fo:block>
</fo:flow>
</fo:page-sequence>
</fo:root>

DO NOT REPLY [Bug 48237] afp renderer does not respect image color settings for svg

2009-11-24T08:58:36Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48237

--- Comment #1 from Venkat Reddy <vanukuri.venkat@...> 2009-11-24 08:58:35 UTC ---
Hi Peter,

There is no bug with this functionality. You can have a look at the FO file
that I have used...

1. Update the configuration file for the image mode (b+w or color)
2. Run the following command from the command prompt...
C:\mywork\FOP\fop-0.95> fop -c C:\fop.xconf -fo
C:\mywork\JavaXSLTSamples\XSLFOSamples\hello.fo -afp
C:\mywork\JavaXSLTSamples\XSLFOSamples\hellotest.afp

According to the mode, the image will be rendered with color or black and
white...

Thanks,
Venkat.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Thoughts on Bug 48237

2009-11-24T06:30:30Z

At present FOP does not respect an image color setting of 'b+w' when rendering svg to afp (see Bug 48237)

According to the AFP spec (http://publibz.boulder.ibm.com/cgi-bin/bookmgr_OS390/BOOKS/HA3N1M00/7.47.1?SHELF=APSBK320&DT=20001002123303) it does not seem possible to specify a grayscale color space, and so my question is how should colour be controlled?

Since AFPGraphics2D is responsible for setting the color on the MODCA GraphicsObject prior to calling drawing methods, would a sensible fix to the problem be to convert the awt.Color before calling this setter?

Any thoughts would be most welcome,

Pete

DO NOT REPLY [Bug 47311] [PATCH] Support for bleed, trim and crop box and scaling

2009-11-23T23:54:26Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=47311

--- Comment #43 from Boris Y. <borisbsu@...> 2009-11-23 23:54:24 UTC ---
Hi All,

We have found one issue during testing this new feature.
The issue lies in PageBoundaries.java in calculating crop/bleed boxes.

The offsets order is: [top, right, bottom, left], so to calculate Y size of
the final box we should use the 'bottom' instead of 'top' offset :

return new Rectangle(originalRect.x - coords[3],
- originalRect.y - coords[0],
+ originalRect.y - coords[2],
originalRect.width + coords[3] + coords[1],
originalRect.height + coords[0] + coords[2]);

Please find in the attachments the fix patch. (Comment#41)
Also I have attached the full patch for FOP-0.95 version (Comment#42) if
somebody will have a need to use this feature with previous version.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 47311] [PATCH] Support for bleed, trim and crop box and scaling

2009-11-23T23:52:58Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=47311

--- Comment #42 from Boris Y. <borisbsu@...> 2009-11-23 23:52:58 UTC ---
Created an attachment (id=24600)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24600)
Full patch for FOP-0.95 version

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 47311] [PATCH] Support for bleed, trim and crop box and scaling

2009-11-23T23:52:25Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=47311

--- Comment #41 from Boris Y. <borisbsu@...> 2009-11-23 23:52:14 UTC ---
Created an attachment (id=24599)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24599)
Fix for /trunk

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48264] [PATCH] PS Renderer failed to process images using CMYK color space

2009-11-23T08:01:27Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48264

--- Comment #5 from Venkat Reddy <vanukuri.venkat@...> 2009-11-23 08:01:26 UTC ---
Created an attachment (id=24595)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24595)
Postscript output file after the changes

Please find the CMYK color space with the output file after the patch applied.

like ...

%AXGBeginBitmap: C:\mywork\JavaXSLTSamples\XSLFOSamples\cmykimage.jpg
{{
/RawData currentfile /ASCII85Decode filter def
/Data RawData << >> /DCTDecode filter def
/DeviceCMYK setcolorspace
<<
/Decode [1 0 1 0 1 0 1 0]
/Width 500
/BitsPerComponent 8
/ImageType 1
/DataSource Data
/ImageMatrix [500 0 0 300 0 0]
/Height 300
>> image
} stopped {handleerror} if
RawData flushfile
} exec

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48264] [PATCH] PS Renderer failed to process images using CMYK color space

2009-11-23T07:52:28Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48264

--- Comment #4 from Venkat Reddy <vanukuri.venkat@...> 2009-11-23 07:52:27 UTC ---
Please find that the code changes are in XMLGraphicsCommons project, the patch
should be applied to XMLGraphicsCommons and the
'xmlgraphics-commons-1.4svn.jar' should be placed in FopTrunk/lib to get the
desired output.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48264] [PATCH] PS Renderer failed to process images using CMYK color space

2009-11-23T07:45:48Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48264

--- Comment #3 from Venkat Reddy <vanukuri.venkat@...> 2009-11-23 07:45:48 UTC ---
Created an attachment (id=24594)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24594)
CMYK Tiff Image

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48264] [PATCH] PS Renderer failed to process images using CMYK color space

2009-11-23T07:45:02Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48264

--- Comment #2 from Venkat Reddy <vanukuri.venkat@...> 2009-11-23 07:45:02 UTC ---
Created an attachment (id=24592)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24592)
CMYK JPG image

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48264] [PATCH] PS Renderer failed to process images using CMYK color space

2009-11-23T07:44:10Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=48264

--- Comment #1 from Venkat Reddy <vanukuri.venkat@...> 2009-11-23 07:44:10 UTC ---
Created an attachment (id=24591)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24591)
Input FO file

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.