FTBS with shave enabled

View: New views
4 Messages — Rating Filter:   Alert me  

FTBS with shave enabled

by Bastien Nocera :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Heya,

$ V=1 make
/bin/sh ../libtool --mode=link /bin/sh /home/hadess/Projects/Cvs/libgpod/shave cc gcc -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -Werror -std=c89 -g -O2 -Wno-strict-aliasing -Wno-sign-compare -Wdeclaration-after-statement -o libgpod.la -rpath /usr/lib64 -version-info 5:0:1 -no-undefined libgpod_la-db-artwork-debug.lo libgpod_la-db-artwork-parser.lo libgpod_la-db-artwork-writer.lo libgpod_la-db-image-parser.lo libgpod_la-db-parse-context.lo libgpod_la-itdb_artwork.lo libgpod_la-itdb_chapterdata.lo libgpod_la-itdb_device.lo libgpod_la-itdb_itunesdb.lo libgpod_la-itdb_photoalbum.lo libgpod_la-itdb_playlist.lo libgpod_la-itdb_plist.lo libgpod_la-itdb_sha1.lo libgpod_la-itdb_sysinfo_extended_parser.lo libgpod_la-itdb_thumb.lo libgpod_la-itdb_track.lo libgpod_la-itdb_tzinfo.lo libgpod_la-ithumb-writer.lo libgpod_la-pixmaps.lo libgpod_la-sha1.lo -lgobject-2.0 -lglib-2.0 -lxml2 -lgdk_pixbuf-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lm --shave-mode=link
libtool: link: unable to infer tagged configuration
libtool: link: specify a tag with `--tag'
make[2]: *** [libgpod.la] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Works if I remove the shave init code from configure.

Any reasons not to use automake 1.11's silent stuff instead of shave?

Cheers


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: FTBS with shave enabled

by Todd Zullinger :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Bastien Nocera wrote:

> $ V=1 make
> /bin/sh ../libtool --mode=link /bin/sh /home/hadess/Projects/Cvs/libgpod/shave cc gcc -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -Werror -std=c89 -g -O2 -Wno-strict-aliasing -Wno-sign-compare -Wdeclaration-after-statement -o libgpod.la -rpath /usr/lib64 -version-info 5:0:1 -no-undefined libgpod_la-db-artwork-debug.lo libgpod_la-db-artwork-parser.lo libgpod_la-db-artwork-writer.lo libgpod_la-db-image-parser.lo libgpod_la-db-parse-context.lo libgpod_la-itdb_artwork.lo libgpod_la-itdb_chapterdata.lo libgpod_la-itdb_device.lo libgpod_la-itdb_itunesdb.lo libgpod_la-itdb_photoalbum.lo libgpod_la-itdb_playlist.lo libgpod_la-itdb_plist.lo libgpod_la-itdb_sha1.lo libgpod_la-itdb_sysinfo_extended_parser.lo libgpod_la-itdb_thumb.lo libgpod_la-itdb_track.lo libgpod_la-itdb_tzinfo.lo libgpod_la-ithumb-writer.lo libgpod_la-pixmaps.lo libgpod_la-sha1.lo -lgobject-2.0 -lglib-2.0 -lxml2 -lgdk_pixbuf-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.
> 0 -lm --shave-mode=link
> libtool: link: unable to infer tagged configuration
> libtool: link: specify a tag with `--tag'
> make[2]: *** [libgpod.la] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
>
> Works if I remove the shave init code from configure.
Hell, it fails even if you try to use V=0.  So the shave stuff is
quite a bit borked. :(

I tested on Fedora 10, which has libtool-1.5.  I should check Fedora
11 or rawhide, but I'm guessing one of those is what you're running,
right Bastien?

> Any reasons not to use automake 1.11's silent stuff instead of
> shave?

I think the reason was that bumping the automake requirement to 1.11
so soon after it was released would hurt people building from svn on
older releases.  Personally, I have no problem waiting for quieter
make output until automake-1.11 is seen as having sufficient
availability to make it a build requirement.

FWIW, the attached patch makes the build work for me.  I'm not sure
that adding --tag=CC even when the libtool mode is linking rather than
compiling is correct though.  I'm not anything close to smart when it
comes to libtool.

--
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sometimes the majority only means that all the fools are on the same
side.
    -- Michael W. Smith


From 431470cfc7ef20dd4824d968d786ce152846f87a Mon Sep 17 00:00:00 2001
From: Todd Zullinger <tmz@...>
Date: Wed, 19 Aug 2009 13:23:13 -0400
Subject: [PATCH] Pass --tag=CC to libtool even when $mode=link

---
 shave-libtool.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/shave-libtool.in b/shave-libtool.in
index 54ebd69..68579b9 100644
--- a/shave-libtool.in
+++ b/shave-libtool.in
@@ -94,7 +94,7 @@ output=$last_result
 # on the compiler name. As shave is using CC to hook a wrapper, libtool gets
 # confused. Let's detect these cases and add a --tag=CC option.
 tag=""
-if test $tag_seen -eq 0 -a x"$mode" = xcompile; then
+if test $tag_seen -eq 0; then
     tag="--tag=CC"
 fi
 
--
1.6.4



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

attachment0 (554 bytes) Download Attachment

Re: FTBS with shave enabled

by Bastien Nocera :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, 2009-08-19 at 14:09 -0400, Todd Zullinger wrote:

> Bastien Nocera wrote:
> > $ V=1 make
> > /bin/sh ../libtool --mode=link /bin/sh /home/hadess/Projects/Cvs/libgpod/shave cc gcc -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -Werror -std=c89 -g -O2 -Wno-strict-aliasing -Wno-sign-compare -Wdeclaration-after-statement -o libgpod.la -rpath /usr/lib64 -version-info 5:0:1 -no-undefined libgpod_la-db-artwork-debug.lo libgpod_la-db-artwork-parser.lo libgpod_la-db-artwork-writer.lo libgpod_la-db-image-parser.lo libgpod_la-db-parse-context.lo libgpod_la-itdb_artwork.lo libgpod_la-itdb_chapterdata.lo libgpod_la-itdb_device.lo libgpod_la-itdb_itunesdb.lo libgpod_la-itdb_photoalbum.lo libgpod_la-itdb_playlist.lo libgpod_la-itdb_plist.lo libgpod_la-itdb_sha1.lo libgpod_la-itdb_sysinfo_extended_parser.lo libgpod_la-itdb_thumb.lo libgpod_la-itdb_track.lo libgpod_la-itdb_tzinfo.lo libgpod_la-ithumb-writer.lo libgpod_la-pixmaps.lo libgpod_la-sha1.lo -lgobject-2.0 -lglib-2.0 -lxml2 -lgdk_pixbuf-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.
> > 0 -lm --shave-mode=link
> > libtool: link: unable to infer tagged configuration
> > libtool: link: specify a tag with `--tag'
> > make[2]: *** [libgpod.la] Error 1
> > make[1]: *** [all-recursive] Error 1
> > make: *** [all] Error 2
> >
> > Works if I remove the shave init code from configure.
>
> Hell, it fails even if you try to use V=0.  So the shave stuff is
> quite a bit borked. :(
>
> I tested on Fedora 10, which has libtool-1.5.  I should check Fedora
> 11 or rawhide, but I'm guessing one of those is what you're running,
> right Bastien?

libtool-2.2.6-13.fc12.x86_64

> > Any reasons not to use automake 1.11's silent stuff instead of
> > shave?
>
> I think the reason was that bumping the automake requirement to 1.11
> so soon after it was released would hurt people building from svn on
> older releases.

Check the patch here:
http://bugzilla.gnome.org/show_bug.cgi?id=592213#c3

It doesn't require automake-1.11, but will make use of it if available.

Cheers


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: FTBS with shave enabled

by Todd Zullinger :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Bastien Nocera wrote:
> Check the patch here:
> http://bugzilla.gnome.org/show_bug.cgi?id=592213#c3
>
> It doesn't require automake-1.11, but will make use of it if
> available.

Excellent!  Thanks for that.  Christophe applied the configure.ac
portion of that and I synced the gnome-autogen.sh script from
gnome-common for automake-1.11 detection.  Things should build fine on
rawhide now, with quiet make output by default.  Yell if you find
that's not the case.

--
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Never was a government that was not composed of liars, malefactors and
thieves.
    -- Cicero, last Free Consul of Rome



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

attachment0 (554 bytes) Download Attachment