FW: libpng1.4 and Windows CE

View: New views
3 Messages — Rating Filter:   Alert me  

FW: libpng1.4 and Windows CE

by John Bowler :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

From: Glenn Randers-Pehrson [mailto:glennrp@...]
>I used the simpler
>
>    #ifdef PNG_WRITE_tIME_SUPPORTED
>    #    ifdef _WIN32_WCE
>               code
>    #    endif
>    #endif

I was suggesting an additional macro pair (PNG_CONVERT_tIME_SUPPORTED,
PNG_NO_CONVERT_tIME) here so that _WIN32_WCE systems could enable the
convertion functions if, for some reason, support became available and so
that other systems could disable them without disabling the tIME support
itself.

#ifndef PNG_NO_CONVERT_tIME
# ifndef _WIN32_WCE
#  define PNG_CONVERT_tIME_SUPPORTED
# endif
#endif

A build that wants to force the convertion functions in simply sets (in
pngusr.h or config.h or on the command line):

#define PNG_NO_CONVERT_TIME
#define PNG_CONVERT_tIME_SUPPORTED

To disable:

#define PNG_NO_CONVERT_TIME

I just used #if as shorthand, sorry for the confusion.  

John Bowler <jbowler@...>



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: FW: libpng1.4 and Windows CE

by Glenn Randers-Pehrson :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Mon, Nov 2, 2009 at 11:58 AM, John Bowler <jbowler@...> wrote:

> I was suggesting an additional macro pair (PNG_CONVERT_tIME_SUPPORTED,
> PNG_NO_CONVERT_tIME) here so that _WIN32_WCE systems could enable the
> convertion functions if, for some reason, support became available and so
> that other systems could disable them without disabling the tIME support
> itself.
>
> #ifndef PNG_NO_CONVERT_tIME
> # ifndef _WIN32_WCE
> #  define PNG_CONVERT_tIME_SUPPORTED
> # endif
> #endif

OK.  It's in the GIT repository (both branches).

Glenn

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: FW: libpng1.4 and Windows CE

by Glenn Randers-Pehrson :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Mon, Nov 2, 2009 at 12:38 PM, Glenn Randers-Pehrson
<glennrp@...> wrote:

> On Mon, Nov 2, 2009 at 11:58 AM, John Bowler <jbowler@...> wrote:
>
>> I was suggesting an additional macro pair (PNG_CONVERT_tIME_SUPPORTED,
>> PNG_NO_CONVERT_tIME) here so that _WIN32_WCE systems could enable the
>> convertion functions if, for some reason, support became available and so
>> that other systems could disable them without disabling the tIME support
>> itself.
>>
>> #ifndef PNG_NO_CONVERT_tIME
>> # ifndef _WIN32_WCE
>> #  define PNG_CONVERT_tIME_SUPPORTED
>> # endif
>> #endif
>
> OK.  It's in the GIT repository (both branches).
>
> Glenn
>

I changed this in both git branches to read


#ifdef PNG_WRITE_tIME_SUPPORTED
#  ifndef PNG_NO_CONVERT_tIME
#    ifndef _WIN32_WCE
/*   The "tm" structure is not supported on WindowsCE */
#      ifndef PNG_CONVERT_tIME_SUPPORTED
#        define PNG_CONVERT_tIME_SUPPORTED
#      endif
#   endif
#  endif
#endif

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement