FYI: Fix for PR34580

View: New views
1 Messages — Rating Filter:   Alert me  

FYI: Fix for PR34580

by gnu_andrew :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Thanks to twisti for spotting the broken PR34580 test.
Don't know what I was on when I committed this, but it should now be
fixed...

ChangeLog:

2008-07-24  Andrew John Hughes  <gnu_andrew@...>

        * gnu/testlet/java/awt/Desktop/PR34580.java:
        Assign class to correct package.
       
2008-07-24  Andrew John Hughes  <gnu_andrew@...>

        * gnu/testlet/java/awt/Desktop/PR34580.java:
        Fix compilation errors.
        * gnu/testlet/java/util/Currency/Taiwan.java:
        Update number of fraction digits to match CLDR.

--
Andrew :)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

Index: gnu/testlet/java/awt/Desktop/PR34580.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Desktop/PR34580.java,v
retrieving revision 1.1
diff -u -u -r1.1 PR34580.java
--- gnu/testlet/java/awt/Desktop/PR34580.java 25 Dec 2007 02:15:23 -0000 1.1
+++ gnu/testlet/java/awt/Desktop/PR34580.java 24 Jul 2008 15:59:42 -0000
@@ -23,6 +23,9 @@
 
 import java.awt.Desktop;
 
+import java.lang.reflect.Method;
+import java.lang.reflect.InvocationTargetException;
+
 import gnu.testlet.TestHarness;
 import gnu.testlet.Testlet;
 
@@ -40,14 +43,25 @@
   {
     try
       {
- Desktop.isDesktopSupported();
- h.check(true, "isDesktopSupported() accessed succesfully.");
- }
-      catch (IllegalAccessException e)
- {
-  h.debug(e);
-  h.fail("isDesktopSupported() could not be accessed.");
- }
+ Method m = Desktop.class.getMethod("isDesktopSupported");
+ m.invoke(null);
+ h.check(true, "isDesktopSupported() accessed successfully.");
+      }
+    catch (IllegalAccessException e)
+      {
+ h.debug(e);
+ h.fail("isDesktopSupported() could not be accessed.");
+      }
+    catch (NoSuchMethodException e)
+      {
+ h.debug(e);
+ h.fail("isDesktopSupported() is not implemented.");
+      }
+    catch (InvocationTargetException e)
+      {
+ h.debug(e);
+ h.fail("isDesktopSupported() threw an exception: " + e);
+      }
   }
 
 }
Index: gnu/testlet/java/util/Currency/Taiwan.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/util/Currency/Taiwan.java,v
retrieving revision 1.2
diff -u -u -r1.2 Taiwan.java
--- gnu/testlet/java/util/Currency/Taiwan.java 18 Jun 2007 15:01:54 -0000 1.2
+++ gnu/testlet/java/util/Currency/Taiwan.java 24 Jul 2008 15:59:46 -0000
@@ -37,7 +37,7 @@
   private static final Locale TEST_LOCALE = Locale.TAIWAN;
   private static final String ISO4217_CODE = "TWD";
   private static final String CURRENCY_SYMBOL = "NT$";
-  private static final int FRACTION_DIGITS = 2;
+  private static final int FRACTION_DIGITS = 0;
 
   public void test(TestHarness harness)
   {

Index: gnu/testlet/java/awt/Desktop/PR34580.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Desktop/PR34580.java,v
retrieving revision 1.2
diff -u -u -r1.2 PR34580.java
--- gnu/testlet/java/awt/Desktop/PR34580.java 24 Jul 2008 16:02:13 -0000 1.2
+++ gnu/testlet/java/awt/Desktop/PR34580.java 24 Jul 2008 17:12:38 -0000
@@ -19,7 +19,7 @@
 // the Free Software Foundation, 59 Temple Place - Suite 330,
 // Boston, MA 02111-1307, USA.
 
-package gnu.testlet.javax.swing.JFrame;
+package gnu.testlet.java.awt.Desktop;
 
 import java.awt.Desktop;