Feedback: Ray-Alvy-Smith patch, SVN

[Vinnie-4]

- I was able to get the patch from the last post, I saw it both in my private message and also the message posted to the list. Thanks

- Patch worked great!

- When I looked at my customizations, there was really only one thing that i added, an enumeration value to each of the orders:

    struct order_rgb  { enum rgb_e  { R=0, G=1, B=2, rgb_tag, hasAlpha=false }; };       //----order_rgb
    struct order_bgr  { enum bgr_e  { B=0, G=1, R=2, rgb_tag, hasAlpha=false }; };       //----order_bgr
    struct order_rgba { enum rgba_e { R=0, G=1, B=2, A=3, rgba_tag, hasAlpha=true }; }; //----order_rgba
    struct order_argb { enum argb_e { A=0, R=1, G=2, B=3, rgba_tag, hasAlpha=true }; }; //----order_argb
    struct order_abgr { enum abgr_e { A=0, B=1, G=2, R=3, rgba_tag, hasAlpha=true }; }; //----order_abgr
    struct order_bgra { enum bgra_e { B=0, G=1, R=2, A=3, rgba_tag, hasAlpha=true }; }; //----order_bgra

My change was to include 'hasAlpha'. This is useful for template metaprogramming.

- I have a common header file at the beginning of every .cpp file in the agg project, #include "pch.h" for building a precompiled header under MSVC


Also:

- The directory structure of the project could be improved. The extra 'agg-2.4' is pretty annoying, as is the lack of a single include directory. It was one of the first things I changed in my private copy and I had to revert it back in order to apply the patch. I was thinking:

{agg dir}include/agg/*
{agg dir}include/agg/ctrl/*
{agg dir}include/agg/platform/*
...
{agg dir}include/agg/freetype/{freetype includes}
{agg dir}include/agg/win_truetype/{win truetype includes}
{agg dir}src/*
...

This way a build environment can use -I{agg dir}include, with client code having lines like:
#include <agg/agg_arrowhead.h>
or (more work)
#include <agg/arrowhead.h>
for example.

Of course this is a non trivial change that might require client code changes (mostly search and replace) but I wanted to mention it.

- Still no SVN access unless I am doing something wrong (?)





------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Vector-agg-general mailing list
Vector-agg-general@...
https://lists.sourceforge.net/lists/listinfo/vector-agg-general

[John Horigan]

On Oct 3, 2009, at 5:10 AM, Vinnie wrote:

> - I was able to get the patch from the last post, I saw it both in  
> my private message and also the message posted to the list. Thanks
>
> - Patch worked great!
>
> - When I looked at my customizations, there was really only one  
> thing that i added, an enumeration value to each of the orders:
>
>    struct order_rgb  { enum rgb_e  { R=0, G=1, B=2, rgb_tag,  
> hasAlpha=false }; };       //----order_rgb
>    struct order_bgr  { enum bgr_e  { B=0, G=1, R=2, rgb_tag,  
> hasAlpha=false }; };       //----order_bgr
>    struct order_rgba { enum rgba_e { R=0, G=1, B=2, A=3, rgba_tag,  
> hasAlpha=true }; }; //----order_rgba
>    struct order_argb { enum argb_e { A=0, R=1, G=2, B=3, rgba_tag,  
> hasAlpha=true }; }; //----order_argb
>    struct order_abgr { enum abgr_e { A=0, B=1, G=2, R=3, rgba_tag,  
> hasAlpha=true }; }; //----order_abgr
>    struct order_bgra { enum bgra_e { B=0, G=1, R=2, A=3, rgba_tag,  
> hasAlpha=true }; }; //----order_bgra
>
> My change was to include 'hasAlpha'. This is useful for template  
> metaprogramming.
>

OK. I will incorporate that. New patch attached.

> - I have a common header file at the beginning of every .cpp file in  
> the agg project, #include "pch.h" for building a precompiled header  
> under MSVC
>
>

Sounds great. You should create a patch for that. Wrap the #include in  
something like #ifdef AGG_USE_MSVC_PCH so that other Windows users are  
not compelled to use pre-compiled headers.

> Also:
>
> - The directory structure of the project could be improved. The  
> extra 'agg-2.4' is pretty annoying, as is the lack of a single  
> include directory. It was one of the first things I changed in my  
> private copy and I had to revert it back in order to apply the  
> patch. I was thinking:
>
> {agg dir}include/agg/*
> {agg dir}include/agg/ctrl/*
> {agg dir}include/agg/platform/*
> ...
> {agg dir}include/agg/freetype/{freetype includes}
> {agg dir}include/agg/win_truetype/{win truetype includes}
> {agg dir}src/*
> ...
>
> This way a build environment can use -I{agg dir}include, with client  
> code having lines like:
> #include <agg/agg_arrowhead.h>
> or (more work)
> #include <agg/arrowhead.h>
> for example.
>
> Of course this is a non trivial change that might require client  
> code changes (mostly search and replace) but I wanted to mention it.
>

This is a great idea. We could do this trivially use symbolic links  
but SVN doesn't even try to support symbolic links under Windows.  
Maybe you could create your preferred include tree using symlinks (if  
you are running Vista or Win7).

We should have a list of major improvements to AGG. Then at some date  
we could have a hacking sprint and produce AGG3. Reorganizing the  
header files should be on the list.

> - Still no SVN access unless I am doing something wrong (?)
>
>
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Vector-agg-general mailing list
> Vector-agg-general@...
> https://lists.sourceforge.net/lists/listinfo/vector-agg-general

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Vector-agg-general mailing list
Vector-agg-general@...
https://lists.sourceforge.net/lists/listinfo/vector-agg-general

[klaas.holwerda-3]

Hi All,

We waited for more then enough.
Have not seen objection.
Will apply the patch tomorrow in say 24 hours.

Regards,

Klaas

John Horigan wrote:
>
> OK. I will incorporate that. New patch attached.
>


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Vector-agg-general mailing list
Vector-agg-general@...
https://lists.sourceforge.net/lists/listinfo/vector-agg-general