FilterList + WeakReferenceMatcherEditor --> IllegalState

View: New views
5 Messages — Rating Filter:   Alert me  

FilterList + WeakReferenceMatcherEditor --> IllegalState

by Johannes Schneider-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

If I use a WeakReferenceMatcherEditor as matcher editor for a FilterList, I recieve the following exception:

java.lang.IllegalStateException
        at ca.odell.glazedlists.FilterList.changeMatcher(FilterList.java:283)
        at ca.odell.glazedlists.FilterList.changeMatcherWithLocks(FilterList.java:269)
        at ca.odell.glazedlists.FilterList.access$100(FilterList.java:51)
        at ca.odell.glazedlists.FilterList$PrivateMatcherEditorListener.changedMatcher(FilterList.java:443)
        at ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor$WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
        at ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor.changedMatcher(WeakReferenceMatcherEditor.java:112)
        at ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor$WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
        at ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChangedMatcher(AbstractMatcherEditor.java:115)
        at ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChanged(AbstractMatcherEditor.java:63)


I have patched the WeakReferenceMatcherEditor and changed the else path of de.avat.jview.diary.model.WeakReferenceMatcherEditor.WeakMatcherEditorListener#changedMatcher:

      } else {
        //Convert the event
        Event<E> convertedEvent = new Event<E>( editor, matcherEvent.getType(), matcherEvent.getMatcher() );
        matcherEditorListener.changedMatcher( convertedEvent );
      }


which seems to solve the problem. Is this a bug in GlazedLists? Or (probably) an error in using GlazedLists?


Regards,

Johannes





---- Msg sent via @Mail - http://atmail.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...


Re: FilterList + WeakReferenceMatcherEditor --> IllegalState

by James Lemieux :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Johannes,

   This is entirely a bug in GL. Your fix is the correct one... we should be translating that MatcherEvent before sending it on. I'll submit that fix tonight.

James

On Thu, Apr 2, 2009 at 2:24 AM, <mailings@...> wrote:
If I use a WeakReferenceMatcherEditor as matcher editor for a FilterList, I recieve the following exception:

java.lang.IllegalStateException
       at ca.odell.glazedlists.FilterList.changeMatcher(FilterList.java:283)
       at ca.odell.glazedlists.FilterList.changeMatcherWithLocks(FilterList.java:269)
       at ca.odell.glazedlists.FilterList.access$100(FilterList.java:51)
       at ca.odell.glazedlists.FilterList$PrivateMatcherEditorListener.changedMatcher(FilterList.java:443)
       at ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor$WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
       at ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor.changedMatcher(WeakReferenceMatcherEditor.java:112)
       at ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor$WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
       at ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChangedMatcher(AbstractMatcherEditor.java:115)
       at ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChanged(AbstractMatcherEditor.java:63)


I have patched the WeakReferenceMatcherEditor and changed the else path of de.avat.jview.diary.model.WeakReferenceMatcherEditor.WeakMatcherEditorListener#changedMatcher:

     } else {
       //Convert the event
       Event<E> convertedEvent = new Event<E>( editor, matcherEvent.getType(), matcherEvent.getMatcher() );
       matcherEditorListener.changedMatcher( convertedEvent );
     }


which seems to solve the problem. Is this a bug in GlazedLists? Or (probably) an error in using GlazedLists?


Regards,

Johannes





---- Msg sent via @Mail - http://atmail.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...



Re: FilterList + WeakReferenceMatcherEditor --> IllegalState

by Johannes Schneider-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Do you have any idea when the next bugfix version will be released?


Thanks,

Johannes

On Thu, 2009-04-02 at 10:46 -0700, James Lemieux wrote:

> Johannes,
>
>    This is entirely a bug in GL. Your fix is the correct one... we
> should be translating that MatcherEvent before sending it on. I'll
> submit that fix tonight.
>
> James
>
> On Thu, Apr 2, 2009 at 2:24 AM, <mailings@...> wrote:
>         If I use a WeakReferenceMatcherEditor as matcher editor for a
>         FilterList, I recieve the following exception:
>        
>         java.lang.IllegalStateException
>                at
>         ca.odell.glazedlists.FilterList.changeMatcher(FilterList.java:283)
>                at
>         ca.odell.glazedlists.FilterList.changeMatcherWithLocks(FilterList.java:269)
>                at ca.odell.glazedlists.FilterList.access
>         $100(FilterList.java:51)
>                at ca.odell.glazedlists.FilterList
>         $PrivateMatcherEditorListener.changedMatcher(FilterList.java:443)
>                at
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor
>         $WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
>                at
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor.changedMatcher(WeakReferenceMatcherEditor.java:112)
>                at
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor
>         $WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
>                at
>         ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChangedMatcher(AbstractMatcherEditor.java:115)
>                at
>         ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChanged(AbstractMatcherEditor.java:63)
>        
>        
>         I have patched the WeakReferenceMatcherEditor and changed the
>         else path of
>         de.avat.jview.diary.model.WeakReferenceMatcherEditor.WeakMatcherEditorListener#changedMatcher:
>        
>              } else {
>                //Convert the event
>                Event<E> convertedEvent = new Event<E>( editor,
>         matcherEvent.getType(), matcherEvent.getMatcher() );
>                matcherEditorListener.changedMatcher( convertedEvent );
>              }
>        
>        
>         which seems to solve the problem. Is this a bug in
>         GlazedLists? Or (probably) an error in using GlazedLists?
>        
>        
>         Regards,
>        
>         Johannes
>        
>        
>        
>        
>        
>         ---- Msg sent via @Mail - http://atmail.com/
>        
>         ---------------------------------------------------------------------
>         To unsubscribe, e-mail:
>         users-unsubscribe@...
>         For additional commands, e-mail:
>         users-help@...
>        
>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...


Re: FilterList + WeakReferenceMatcherEditor --> IllegalState

by James Lemieux :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hey Johannes,

   A JUnit testcase was added, and the code fix submitted into HEAD. We'll product a JDK 1.5 snapshot build shortly. If this becomes a problem for a few 1.8 users in the field that cannot (or are unwilling) to move up to the head, we'll package the fix into a point release.

I'll respond on this thread when the snapshot build is updated with this change.

James

On Tue, Apr 7, 2009 at 10:14 AM, Johannes Schneider <mailings@...> wrote:
Do you have any idea when the next bugfix version will be released?


Thanks,

Johannes

On Thu, 2009-04-02 at 10:46 -0700, James Lemieux wrote:
> Johannes,
>
>    This is entirely a bug in GL. Your fix is the correct one... we
> should be translating that MatcherEvent before sending it on. I'll
> submit that fix tonight.
>
> James
>
> On Thu, Apr 2, 2009 at 2:24 AM, <mailings@...> wrote:
>         If I use a WeakReferenceMatcherEditor as matcher editor for a
>         FilterList, I recieve the following exception:
>
>         java.lang.IllegalStateException
>                at
>         ca.odell.glazedlists.FilterList.changeMatcher(FilterList.java:283)
>                at
>         ca.odell.glazedlists.FilterList.changeMatcherWithLocks(FilterList.java:269)
>                at ca.odell.glazedlists.FilterList.access
>         $100(FilterList.java:51)
>                at ca.odell.glazedlists.FilterList
>         $PrivateMatcherEditorListener.changedMatcher(FilterList.java:443)
>                at
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor
>         $WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
>                at
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor.changedMatcher(WeakReferenceMatcherEditor.java:112)
>                at
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor
>         $WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
>                at
>         ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChangedMatcher(AbstractMatcherEditor.java:115)
>                at
>         ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChanged(AbstractMatcherEditor.java:63)
>
>
>         I have patched the WeakReferenceMatcherEditor and changed the
>         else path of
>         de.avat.jview.diary.model.WeakReferenceMatcherEditor.WeakMatcherEditorListener#changedMatcher:
>
>              } else {
>                //Convert the event
>                Event<E> convertedEvent = new Event<E>( editor,
>         matcherEvent.getType(), matcherEvent.getMatcher() );
>                matcherEditorListener.changedMatcher( convertedEvent );
>              }
>
>
>         which seems to solve the problem. Is this a bug in
>         GlazedLists? Or (probably) an error in using GlazedLists?
>
>
>         Regards,
>
>         Johannes
>
>
>
>
>
>         ---- Msg sent via @Mail - http://atmail.com/
>
>         ---------------------------------------------------------------------
>         To unsubscribe, e-mail:
>         users-unsubscribe@...
>         For additional commands, e-mail:
>         users-help@...
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...



Re: FilterList + WeakReferenceMatcherEditor --> IllegalState

by Johannes Schneider-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

a point release will be great...


Thanks,

Johannes

On Tue, 2009-04-07 at 16:12 -0700, James Lemieux wrote:

> Hey Johannes,
>
>    A JUnit testcase was added, and the code fix submitted into HEAD.
> We'll product a JDK 1.5 snapshot build shortly. If this becomes a
> problem for a few 1.8 users in the field that cannot (or are
> unwilling) to move up to the head, we'll package the fix into a point
> release.
>
> I'll respond on this thread when the snapshot build is updated with
> this change.
>
> James
>
> On Tue, Apr 7, 2009 at 10:14 AM, Johannes Schneider
> <mailings@...> wrote:
>         Do you have any idea when the next bugfix version will be
>         released?
>        
>        
>         Thanks,
>        
>         Johannes
>        
>        
>         On Thu, 2009-04-02 at 10:46 -0700, James Lemieux wrote:
>         > Johannes,
>         >
>         >    This is entirely a bug in GL. Your fix is the correct
>         one... we
>         > should be translating that MatcherEvent before sending it
>         on. I'll
>         > submit that fix tonight.
>         >
>         > James
>         >
>         > On Thu, Apr 2, 2009 at 2:24 AM, <mailings@...>
>         wrote:
>         >         If I use a WeakReferenceMatcherEditor as matcher
>         editor for a
>         >         FilterList, I recieve the following exception:
>         >
>         >         java.lang.IllegalStateException
>         >                at
>         >
>         ca.odell.glazedlists.FilterList.changeMatcher(FilterList.java:283)
>         >                at
>         >
>         ca.odell.glazedlists.FilterList.changeMatcherWithLocks(FilterList.java:269)
>         >                at ca.odell.glazedlists.FilterList.access
>         >         $100(FilterList.java:51)
>         >                at ca.odell.glazedlists.FilterList
>         >
>         $PrivateMatcherEditorListener.changedMatcher(FilterList.java:443)
>         >                at
>         >
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor
>         >
>         $WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
>         >                at
>         >
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor.changedMatcher(WeakReferenceMatcherEditor.java:112)
>         >                at
>         >
>         ca.odell.glazedlists.impl.matchers.WeakReferenceMatcherEditor
>         >
>         $WeakMatcherEditorListener.changedMatcher(WeakReferenceMatcherEditor.java:171)
>         >                at
>         >
>         ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChangedMatcher(AbstractMatcherEditor.java:115)
>         >                at
>         >
>         ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChanged(AbstractMatcherEditor.java:63)
>         >
>         >
>         >         I have patched the WeakReferenceMatcherEditor and
>         changed the
>         >         else path of
>         >
>         de.avat.jview.diary.model.WeakReferenceMatcherEditor.WeakMatcherEditorListener#changedMatcher:
>         >
>         >              } else {
>         >                //Convert the event
>         >                Event<E> convertedEvent = new
>         Event<E>( editor,
>         >         matcherEvent.getType(), matcherEvent.getMatcher() );
>         >
>          matcherEditorListener.changedMatcher( convertedEvent );
>         >              }
>         >
>         >
>         >         which seems to solve the problem. Is this a bug in
>         >         GlazedLists? Or (probably) an error in using
>         GlazedLists?
>         >
>         >
>         >         Regards,
>         >
>         >         Johannes
>         >
>         >
>         >
>         >
>         >
>         >         ---- Msg sent via @Mail - http://atmail.com/
>         >
>         >
>         ---------------------------------------------------------------------
>         >         To unsubscribe, e-mail:
>         >         users-unsubscribe@...
>         >         For additional commands, e-mail:
>         >         users-help@...
>         >
>         >
>        
>        
>         ---------------------------------------------------------------------
>         To unsubscribe, e-mail:
>         users-unsubscribe@...
>         For additional commands, e-mail:
>         users-help@...
>        
>        
>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...