First G3 fork: make the application a module

View: New views
2 Messages — Rating Filter:   Alert me  

First G3 fork: make the application a module

by Bharat Mediratta :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


I've just committed a series of changes to my public fork of Gallery 3,
available here:

    http://github.com/bharat/gallery3/tree/master

The focus of this round of changes is to change us from having Gallery
be the Kohana application and make it so that the Gallery application is
just another module (called "gallery").  It was actually fairly easy.

This has several advantages for us:

1) it makes us more like other Kohana applications, which will increase
interoperability with Kohana apps in general and makes our structure
more readily understandable to folks familiar with Kohana.

2) it frees us from the problem that Romain discovered (and I filed in
http://dev.kohanaphp.com/issues/1695) where APPPATH is always first in
the cascading file list because we can force the gallery module to be last.

3) it gives us greater consistency in the code in that now everything is
  a module so we don't have to special case APPPATH.


Notes:
1) I haven't gotten scaffold/package working yet so I've updated the
installer by hand

2) I renamed core->application and kohana->system (this is the standard
Kohana layout) -- I'll have to change the vendor code for this too.

3) I'm sure that this will break g2_import since it's re-using the class
"gallery" which is also in use in G2.  We'll have to come up with a
creative workaround for that problem.

I'll keep working on this in my fork of Gallery 3 and when its ready,
I'll push it back into the main branch when I've resolved the issues
above (hopefully tonight).  I'm happy to say that this model of
development on Git is actually quite nice.  If you're interested, please
clone my repo and check out how it's organized and let me know what you
think.

-Bharat

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
__[ g a l l e r y - d e v e l ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]

Re: First G3 fork: make the application a module

by Bharat Mediratta :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


FYI, I've submitted this change.  If you were familiar with the the G3
code, here's a cheat sheet:

galley3/
  core -> modules/gallery
  kohana -> system
  core/config/config.php -> application/config/config.php

enjoy,
-Bharat


Bharat Mediratta wrote:

> I've just committed a series of changes to my public fork of Gallery 3,
> available here:
>
>     http://github.com/bharat/gallery3/tree/master
>
> The focus of this round of changes is to change us from having Gallery
> be the Kohana application and make it so that the Gallery application is
> just another module (called "gallery").  It was actually fairly easy.
>
> This has several advantages for us:
>
> 1) it makes us more like other Kohana applications, which will increase
> interoperability with Kohana apps in general and makes our structure
> more readily understandable to folks familiar with Kohana.
>
> 2) it frees us from the problem that Romain discovered (and I filed in
> http://dev.kohanaphp.com/issues/1695) where APPPATH is always first in
> the cascading file list because we can force the gallery module to be last.
>
> 3) it gives us greater consistency in the code in that now everything is
>   a module so we don't have to special case APPPATH.
>
>
> Notes:
> 1) I haven't gotten scaffold/package working yet so I've updated the
> installer by hand
>
> 2) I renamed core->application and kohana->system (this is the standard
> Kohana layout) -- I'll have to change the vendor code for this too.
>
> 3) I'm sure that this will break g2_import since it's re-using the class
> "gallery" which is also in use in G2.  We'll have to come up with a
> creative workaround for that problem.
>
> I'll keep working on this in my fork of Gallery 3 and when its ready,
> I'll push it back into the main branch when I've resolved the issues
> above (hopefully tonight).  I'm happy to say that this model of
> development on Git is actually quite nice.  If you're interested, please
> clone my repo and check out how it's organized and let me know what you
> think.
>
> -Bharat
>
> ------------------------------------------------------------------------------
> Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
> is a gathering of tech-side developers & brand creativity professionals. Meet
> the minds behind Google Creative Lab, Visual Complexity, Processing, &
> iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
> Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
> __[ g a l l e r y - d e v e l ]_________________________
>
> [ list info/archive --> http://gallery.sf.net/lists.php ]
> [ gallery info/FAQ/download --> http://gallery.sf.net ]
>


------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
__[ g a l l e r y - d e v e l ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]