Fix, Base, NSXMLParser (SetValueForKey())

View: New views
2 Messages — Rating Filter:   Alert me  

Fix, Base, NSXMLParser (SetValueForKey())

by Georg Fleischmann-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

here is a suggestion of a fix for NSXMLParser SetValueForKey() to  
avoid Newline characters in Nib strings to be swallowed.

I just added a (forgotten?) break, so a string will be collected  
including the newline characters it contains.
For me it works fine - my Cocoa Nibs now display strings including  
newline characters. I'm not aware of any side effects.

Best wishes,
Georg Fleischmann


*** Source/NSXMLParser.m.old 2009-05-12 13:30:54.000000000 +0800
--- Source/NSXMLParser.m 2009-06-23 17:39:01.000000000 +0800
***************
*** 1235,1240 ****
--- 1235,1241 ----
             case '\n':
               this->line++;
               this->column = 0;
+             break;

             case EOF:
             case '<':



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

Re: Fix, Base, NSXMLParser (SetValueForKey())

by Richard Frith-Macdonald-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On 24 Jun 2009, at 03:19, Georg Fleischmann wrote:

> here is a suggestion of a fix for NSXMLParser SetValueForKey() to  
> avoid Newline characters in Nib strings to be swallowed.
>
> I just added a (forgotten?) break, so a string will be collected  
> including the newline characters it contains.
> For me it works fine - my Cocoa Nibs now display strings including  
> newline characters. I'm not aware of any side effects.
>
> Best wishes,
> Georg Fleischmann
>
>
> *** Source/NSXMLParser.m.old 2009-05-12 13:30:54.000000000 +0800
> --- Source/NSXMLParser.m 2009-06-23 17:39:01.000000000 +0800
> ***************
> *** 1235,1240 ****
> --- 1235,1241 ----
>            case '\n':
>              this->line++;
>              this->column = 0;
> +             break;
>
>            case EOF:
>            case '<':

Thanks.  I fixed that in svn.


_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep