Fix EContactPhoto member access

View: New views
3 Messages — Rating Filter:   Alert me  

Fix EContactPhoto member access

by Nicolas Trangez :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hija,

On my setup, using EDS 1.8.2, I was unable to compile eds-feed-0.5.0,
needed to apply atteched patch.

Regards,

Nicolas

[eds-feed-fix-photo-type.patch]

--- eds-feed-0.5.0/src/main.c.orig 2006-04-12 09:06:40.000000000 +0200
+++ eds-feed-0.5.0/src/main.c 2007-02-06 11:19:27.000000000 +0100
@@ -184,12 +184,12 @@
  {
  case E_CONTACT_PHOTO_TYPE_INLINED:
  photo = galago_image_new_from_data(
- (guchar *)ephoto->inlined.data, ephoto->inlined.length);
+ (guchar *)ephoto->data.inlined.data, ephoto->data.inlined.length);
  break;
 
  case E_CONTACT_PHOTO_TYPE_URI:
- if (g_str_has_prefix(ephoto->uri, "file://"))
- photo = galago_image_new_from_file(ephoto->uri + 7);
+ if (g_str_has_prefix(ephoto->data.uri, "file://"))
+ photo = galago_image_new_from_file(ephoto->data.uri + 7);
  else
  {
  /* TODO: use gnome-vfs? */


_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel

Re: Fix EContactPhoto member access

by Christian Hammond-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Thanks. Can you file it on the bug tracker please? My inbox gets swamped with mail and it's easy to lose patches.

http://trac.galago-project.org/

Christian

On 2/6/07, Nicolas Ikke Trangez <eikke@...> wrote:
Hija,

On my setup, using EDS 1.8.2, I was unable to compile eds-feed-0.5.0,
needed to apply atteched patch.

Regards,

Nicolas

_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel





--
Christian Hammond - chipx86@...
VMware, Inc.
_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel

Re: Fix EContactPhoto member access

by Nicolas Trangez :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, 2007-02-06 at 13:51 -0800, Christian Hammond wrote:
> Thanks. Can you file it on the bug tracker please? My inbox gets
> swamped with mail and it's easy to lose patches.
>
> http://trac.galago-project.org/
After sending this mail I found a similar patch in trac, so I dont think
that's necessary any longer
>
> Christian
Nicolas

>
> On 2/6/07, Nicolas Ikke Trangez <eikke@...> wrote:
>         Hija,
>        
>         On my setup, using EDS 1.8.2, I was unable to compile
>         eds-feed-0.5.0,
>         needed to apply atteched patch.
>        
>         Regards,
>        
>         Nicolas
>        
>         _______________________________________________
>         galago-devel mailing list
>         galago-devel@...
>         http://lists.freedesktop.org/mailman/listinfo/galago-devel
>        
>        
>
>
>
> --
> Christian Hammond - chipx86@...
> VMware, Inc.
_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel