Fix evaluation order in bbox deice

View: New views
1 Messages — Rating Filter:   Alert me  

Fix evaluation order in bbox deice

by Alex Cherepanov :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Fix expression evaluation order in bbox device to avoid
access to uninitialized color and Purify warning.

Regression testing shows no differences.


Index: gs/base/gdevbbox.c
===================================================================
--- gs/base/gdevbbox.c (revision 9930)
+++ gs/base/gdevbbox.c (working copy)
@@ -234,7 +234,7 @@
 }
 
 #define GX_DC_IS_TRANSPARENT(pdevc, bdev)\
-  (gx_dc_pure_color(pdevc) == (bdev)->transparent && gx_dc_is_pure(pdevc))
+  (gx_dc_is_pure(pdevc) && gx_dc_pure_color(pdevc) == (bdev)->transparent)
 
 static int
 bbox_close_device(gx_device * dev)

_______________________________________________
gs-code-review mailing list
gs-code-review@...
http://www.ghostscript.com/mailman/listinfo/gs-code-review