Fix for the OSX bundle creator

View: New views
2 Messages — Rating Filter:   Alert me  

Fix for the OSX bundle creator

by Tobias Sauerwein-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi all,

this fix enables the OSX bundle creator script to include dependencies
from places unlike the usual ones (eg. /opt or /usr).

Cheers,
Tobi


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Aqsis-development mailing list
Aqsis-development@...
https://lists.sourceforge.net/lists/listinfo/aqsis-development

osxpackage.patch (5K) Download Attachment

Re: Fix for the OSX bundle creator

by Chris Foster-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, Sep 1, 2009 at 4:41 AM, Tobias Sauerwein<cgtobi@...> wrote:
> Hi all,
>
> this fix enables the OSX bundle creator script to include dependencies
> from places unlike the usual ones (eg. /opt or /usr).

The create bundle stuff is your domain Tobi.  I trust you've done that
correctly.

> - for dep in $( otool -L $folder$file | grep ".dylib" | grep "/opt/" | grep -v $BUNDLE_NAME | sed s/\(.*\)// ) $( otool -L $folder$file | grep dylib | grep fltk | grep -v $BUNDLE_NAME | sed s/\(.*\)// ) $( otool -L $folder$file | grep dylib | grep libboost | grep -v $BUNDLE_NAME | sed s/\(.*\)// ); do
> + for dep in $( otool -L $folder$file | grep ".dylib" | grep "/opt/" | grep -v $BUNDLE_NAME | sed s/\(.*\)// ) $( otool -L $folder$file | grep ".dylib" | grep -v "/usr/" | grep -v "/Developer/" | grep -v "/System/" | grep -v "libaqsis" | grep -v $BUNDLE_NAME | sed s/\(.*\)// ) $( otool -L $folder$file | grep ".a" | grep -v "/usr/" | grep -v "/Developer/" | grep -v "/System/" | grep -v "libaqsis" | grep -v $BUNDLE_NAME | sed s/\(.*\)// ) $( otool -L $folder$file | grep dylib | grep fltk | grep -v $BUNDLE_NAME | sed s/\(.*\)// ) $( otool -L $folder$file | grep dylib | grep libboost | grep -v $BUNDLE_NAME | sed s/\(.*\)// ); do

A minor comment... that's one hell of a pipeline - with some judicious
newlines it might be a lot more readable ;-)

> diff --git a/libs/util/plugins.cpp b/libs/util/plugins.cpp
> index 9454751..e5f29d5 100644
> --- a/libs/util/plugins.cpp
> +++ b/libs/util/plugins.cpp
> @@ -168,7 +168,7 @@ CqPluginBase::DLError( void )
>
>   // Free the buffer.
>   LocalFree( lpMsgBuf );
> -#elif not defined AQSIS_SYSTEM_MACOSX
> +#else //not defined AQSIS_SYSTEM_MACOSX
>
>   char* error = dlerror();
>   if( error )

This looks completely unrelated and I guess should be in a different
commit (or at least, the commit message should mention the change)?

Enabling the use of dlerror() on OSX certainly seems like a good idea.

~Chris.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Aqsis-development mailing list
Aqsis-development@...
https://lists.sourceforge.net/lists/listinfo/aqsis-development