Fix segfault trying to load missing libmp3lame

View: New views
3 Messages — Rating Filter:   Alert me  

Fix segfault trying to load missing libmp3lame

by Rodrigo Rodrigues da Silva :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

To superjoe

--
Rodrigo Rodrigues da Silva
PoliGNU - Grupo de Estudos de Software Livre da Poli/USP
FSF Associate Member #7788

[fix_lame_segfault_090930.diff]

diff --git a/src/core/lame_library.cpp b/src/core/lame_library.cpp
index 7e80136..cdbd40b 100644
--- a/src/core/lame_library.cpp
+++ b/src/core/lame_library.cpp
@@ -42,8 +42,10 @@ LameLibrary::LameLibrary() :
  "you have Lame installed and then check your folder settings "
  "and make sure you tell LMMS where libmp3lame.so.0 is." ),
  QMessageBox::Ok | QMessageBox::Default );
- delete m_lameLib;
- m_lameLib = NULL;
+ m_lameLib->unload();
+                delete m_lameLib;
+                m_lameLib = NULL;
+                return;
  }
 
  // grab the functions and stuff we need


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
LMMS-devel mailing list
LMMS-devel@...
https://lists.sourceforge.net/lists/listinfo/lmms-devel

Re: Fix segfault trying to load missing libmp3lame

by Rodrigo Rodrigues da Silva :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I've fixed another segfault, reported in bug #2839545. The fix was
submitted as a patch on SourceForge:
http://sourceforge.net/tracker/?func=detail&aid=2870621&group_id=105168&atid=640436

Please integrate it when possible.

Rodrigo

--
Rodrigo Rodrigues da Silva
PoliGNU - Grupo de Estudos de Software Livre da Poli/USP
FSF Associate Member #7788

2009/9/30 Rodrigo Rodrigues da Silva <rodrigopitanga@...>:
> To superjoe
>
> --
> Rodrigo Rodrigues da Silva
> PoliGNU - Grupo de Estudos de Software Livre da Poli/USP
> FSF Associate Member #7788
>

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
LMMS-devel mailing list
LMMS-devel@...
https://lists.sourceforge.net/lists/listinfo/lmms-devel

Re: Fix segfault trying to load missing libmp3lame

by Andy Kelley :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

OK I integrated it and pushed it.

On Wed, Sep 30, 2009 at 6:24 AM, Rodrigo Rodrigues da Silva <rodrigopitanga@...> wrote:
I've fixed another segfault, reported in bug #2839545. The fix was
submitted as a patch on SourceForge:
http://sourceforge.net/tracker/?func=detail&aid=2870621&group_id=105168&atid=640436

Please integrate it when possible.

Rodrigo

--
Rodrigo Rodrigues da Silva
PoliGNU - Grupo de Estudos de Software Livre da Poli/USP
FSF Associate Member #7788

2009/9/30 Rodrigo Rodrigues da Silva <rodrigopitanga@...>:
> To superjoe
>
> --
> Rodrigo Rodrigues da Silva
> PoliGNU - Grupo de Estudos de Software Livre da Poli/USP
> FSF Associate Member #7788
>

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
LMMS-devel mailing list
LMMS-devel@...
https://lists.sourceforge.net/lists/listinfo/lmms-devel



--
Andy Kelley
Nuclear Development
http://nucleardev.com/

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
LMMS-devel mailing list
LMMS-devel@...
https://lists.sourceforge.net/lists/listinfo/lmms-devel