Fixes bug #498095 - mnemonics clash

[Dmitrijs Ledkovs]

Hello all!

Fixing mnemonics clashes with "_Edit", as well as make sure new
mnemonics are consistent across dialogs.

In task page _D was already used for _Due Date, I changed it to
D_ue Date in hope that consistency with New Memo is more important
since it already was using _Description.

Patch was created agains svn/trunk revision 35957. Applies cleanly
with -p1 option. Compiles and tested.

With regards,

Dmitrijs Ledkovs

diff --git a/calendar/ChangeLog b/calendar/ChangeLog
index feda557..363c5d0 100644
--- a/calendar/ChangeLog
+++ b/calendar/ChangeLog
@@ -1,3 +1,12 @@
[phone]  Dmitrijs Ledkovs  <dmitrij.ledkov@...>
+
+ ** Fixes bug #498095
+
+ * dialogs/event-page.glade: "D_escription" -> "_Description"
+ * dialogs/task-page.glade: As above and "_Due Date" -> "D_ue Date"
+
+ Change mnemonics to resolve clash with "_Edit".
+
 2008-08-08  Milan Crha  <mcrha@...>
 
  ** Fix for bug #544117
diff --git a/calendar/gui/dialogs/event-page.glade b/calendar/gui/dialogs/event-page.glade
index f593357..f0f1d2e 100644
--- a/calendar/gui/dialogs/event-page.glade
+++ b/calendar/gui/dialogs/event-page.glade
@@ -159,7 +159,7 @@
       <child>
  <widget class="GtkLabel" id="description-label">
   <property name="visible">True</property>
-  <property name="label" translatable="yes">D_escription:</property>
+  <property name="label" translatable="yes">_Description:</property>
   <property name="use_underline">True</property>
   <property name="use_markup">False</property>
   <property name="justify">GTK_JUSTIFY_CENTER</property>
diff --git a/calendar/gui/dialogs/task-page.glade b/calendar/gui/dialogs/task-page.glade
index a5eb1e2..d106381 100644
--- a/calendar/gui/dialogs/task-page.glade
+++ b/calendar/gui/dialogs/task-page.glade
@@ -169,7 +169,7 @@
       <child>
  <widget class="GtkLabel" id="due-date-label">
   <property name="visible">True</property>
-  <property name="label" translatable="yes">_Due date:</property>
+  <property name="label" translatable="yes">D_ue date:</property>
   <property name="use_underline">True</property>
   <property name="use_markup">False</property>
   <property name="justify">GTK_JUSTIFY_CENTER</property>
@@ -274,7 +274,7 @@
       <child>
  <widget class="GtkLabel" id="label18">
   <property name="visible">True</property>
-  <property name="label" translatable="yes">De_scription:</property>
+  <property name="label" translatable="yes">_Description:</property>
   <property name="use_underline">True</property>
   <property name="use_markup">False</property>
   <property name="justify">GTK_JUSTIFY_CENTER</property>
--
1.6.0.rc2.22.g71b99


_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches

[Matthew Barnes]

On Mon, 2008-08-11 at 18:39 +0300, Dmitrijs Ledkovs wrote:

> Fixing mnemonics clashes with "_Edit", as well as make sure new
> mnemonics are consistent across dialogs.
>
> In task page _D was already used for _Due Date, I changed it to
> D_ue Date in hope that consistency with New Memo is more important
> since it already was using _Description.
>
> Patch was created agains svn/trunk revision 35957. Applies cleanly
> with -p1 option. Compiles and tested.
>
> With regards,
>
> Dmitrijs Ledkovs

Thanks for the patch.  Can you please add it to the appropriate bug
report at http://bugzilla.gnome.org/.

Mailing lists are not an effective way to track patches, and this
particular mailing list is only really useful for calling attention to
and (to a lesser degree) discussing existing patches in Bugzilla.

Thanks,
Matthew Barnes

_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches

[Dmitrijs Ledkovs]

Thanks for pointing this out. I'm new and tried to follow guide for
submitting patches to
evolution which pointed me to submit them here.

Sorry to bother whole mailing list =D


With best regards



Dmitrijs Ledkovs



On Mon, Aug 11, 2008 at 18:59, Matthew Barnes <mbarnes@...> wrote:

> On Mon, 2008-08-11 at 18:39 +0300, Dmitrijs Ledkovs wrote:
>> Fixing mnemonics clashes with "_Edit", as well as make sure new
>> mnemonics are consistent across dialogs.
>>
>> In task page _D was already used for _Due Date, I changed it to
>> D_ue Date in hope that consistency with New Memo is more important
>> since it already was using _Description.
>>
>> Patch was created agains svn/trunk revision 35957. Applies cleanly
>> with -p1 option. Compiles and tested.
>>
>> With regards,
>>
>> Dmitrijs Ledkovs
>
> Thanks for the patch.  Can you please add it to the appropriate bug
> report at http://bugzilla.gnome.org/.
>
> Mailing lists are not an effective way to track patches, and this
> particular mailing list is only really useful for calling attention to
> and (to a lesser degree) discussing existing patches in Bugzilla.
>
> Thanks,
> Matthew Barnes
>
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches@...
> http://mail.gnome.org/mailman/listinfo/evolution-patches
>

_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches

[Sven Anders-2]

Matthew Barnes schrieb:
>
> Mailing lists are not an effective way to track patches, and this
> particular mailing list is only really useful for calling attention to
> and (to a lesser degree) discussing existing patches in Bugzilla.

Ahh, then I want to call attention to the bugfix of bug #266678.
I'm really interested, that this bugfix goes upstream, but it seems
nobody else is interested or understands the code?!
Please help...

Regards
 Sven

--
 Sven Anders <anders@...>                 () Ascii Ribbon Campaign
                                                 /\ Support plain text e-mail
 ANDURAS service solutions AG
 Innstraße 71 - 94036 Passau - Germany
 Web: www.anduras.de - Tel: [phone] - Fax: [phone]

Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
Mitglieder des Vorstands: Sven Anders, Marcus Junker
Vorsitzender des Aufsichtsrats: Mark Peters

[anders.vcf]

---

begin:vcard
fn:Sven Anders
n:Anders;Sven
org:ANDURAS AG;Research and Development
adr;quoted-printable:;;Innstra=C3=9Fe 71;Passau;Bavaria;94036;Germany
email;internet:anders@...
title:Dipl. Inf.
tel;work:++49 (0)851 / 490 50 -0
tel;fax:++49 (0)851 / 590 50 - 55
x-mozilla-html:FALSE
url:http://www.anduras.de
version:2.1
end:vcard

---

_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches

[Matthew Barnes]

On Mon, 2008-08-11 at 19:07 +0300, Dmitrijs Ledkovs wrote:
> Thanks for pointing this out. I'm new and tried to follow guide for
> submitting patches to evolution which pointed me to submit them here.
>
> Sorry to bother whole mailing list =D

Not a problem.  This mailing list is pretty much dead these days anyway,
so there's not many people here to bother.  :)

Which guide did you follow?  I'll try to update the instructions.

Matthew Barnes

_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches

[Moritz Mertinkat-2]

Probably this one:
http://www.gnome.org/projects/evolution/patch.shtml


What about "Features" with patches? Should I re-submit the patch to
Bugzilla?
http://mail.gnome.org/archives/evolution-patches/2008-August/msg00000.html

Regards,
Moritz Mertinkat


Matthew Barnes schrieb:

> On Mon, 2008-08-11 at 19:07 +0300, Dmitrijs Ledkovs wrote:
>> Thanks for pointing this out. I'm new and tried to follow guide for
>> submitting patches to evolution which pointed me to submit them here.
>>
>> Sorry to bother whole mailing list =D
>
> Not a problem.  This mailing list is pretty much dead these days anyway,
> so there's not many people here to bother.  :)
>
> Which guide did you follow?  I'll try to update the instructions.
>
> Matthew Barnes
>
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches@...
> http://mail.gnome.org/mailman/listinfo/evolution-patches

_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches