Follow up on creating ASF-compliant source releases

View: New views
9 Messages — Rating Filter:   Alert me  

Follow up on creating ASF-compliant source releases

by Dennis Lundberg-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi

For a *single* module project, like one of our Maven plugins, do I
really have to create an assembly descriptor?

Wouldn't it work if I just use the predefined "project" descriptor?

--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Follow up on creating ASF-compliant source releases

by brettporter :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On 10/07/2009, at 6:22 AM, Dennis Lundberg wrote:

> Hi
>
> For a *single* module project, like one of our Maven plugins, do I
> really have to create an assembly descriptor?
>
> Wouldn't it work if I just use the predefined "project" descriptor?

Yes, if you do not have any source packages called "target".

- Brett


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Follow up on creating ASF-compliant source releases

by Benjamin Bentmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Brett Porter wrote:

>> Wouldn't it work if I just use the predefined "project" descriptor?
>
> Yes, if you do not have any source packages called "target".

Really, what about the LICENSE/NOTICE files that get generated under
target? As far as I grok the "project" descriptor (and also the "src"
descriptor), these would be missing from the root of the source archive.
Also, the "project" descriptor would produce an assembly with the
classifier "project", not what we want, do we?


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Follow up on creating ASF-compliant source releases

by djencks :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Jul 9, 2009, at 1:34 PM, Benjamin Bentmann wrote:

> Brett Porter wrote:
>
>>> Wouldn't it work if I just use the predefined "project" descriptor?
>> Yes, if you do not have any source packages called "target".
>
> Really, what about the LICENSE/NOTICE files that get generated under  
> target? As far as I grok the "project" descriptor (and also the  
> "src" descriptor), these would be missing from the root of the  
> source archive.

I think Brian disagrees with me, but my understanding of the lengthy  
conversation on legal-discuss includes concluding that svn needs  
LICENSE and NOTICE files at expected checkout roots that cover what is  
actually in svn, as opposed to what gets in the binary, javadoc, or  
source jars.  So these would get added to the source release packaging.

thanks
david jencks

> Also, the "project" descriptor would produce an assembly with the  
> classifier "project", not what we want, do we?
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Follow up on creating ASF-compliant source releases

by brettporter :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Sorry I thought Dennis meant the src descriptor. And yes, I forgot  
about the LICENSE/NOTICE, since I usually have them in SVN when using  
the src descriptor. Good catch.

- Brett

On 10/07/2009, at 6:34 AM, Benjamin Bentmann wrote:

> Brett Porter wrote:
>
>>> Wouldn't it work if I just use the predefined "project" descriptor?
>> Yes, if you do not have any source packages called "target".
>
> Really, what about the LICENSE/NOTICE files that get generated under  
> target? As far as I grok the "project" descriptor (and also the  
> "src" descriptor), these would be missing from the root of the  
> source archive. Also, the "project" descriptor would produce an  
> assembly with the classifier "project", not what we want, do we?
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Follow up on creating ASF-compliant source releases

by BRIAN FOX-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

no...this is what i've been working on just slowly. It's almost done
though, and the idea is that it should just work in almost all cases.

On Thu, Jul 9, 2009 at 4:22 PM, Dennis Lundberg<dennisl@...> wrote:

> Hi
>
> For a *single* module project, like one of our Maven plugins, do I
> really have to create an assembly descriptor?
>
> Wouldn't it work if I just use the predefined "project" descriptor?
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Follow up on creating ASF-compliant source releases

by Dennis Lundberg-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

OK, thanks everyone for your feedback.

I'll use the source assembly descriptor from the assembly plugin as a
template then.

Brett Porter wrote:

> Sorry I thought Dennis meant the src descriptor. And yes, I forgot about
> the LICENSE/NOTICE, since I usually have them in SVN when using the src
> descriptor. Good catch.
>
> - Brett
>
> On 10/07/2009, at 6:34 AM, Benjamin Bentmann wrote:
>
>> Brett Porter wrote:
>>
>>>> Wouldn't it work if I just use the predefined "project" descriptor?
>>> Yes, if you do not have any source packages called "target".
>>
>> Really, what about the LICENSE/NOTICE files that get generated under
>> target? As far as I grok the "project" descriptor (and also the "src"
>> descriptor), these would be missing from the root of the source
>> archive. Also, the "project" descriptor would produce an assembly with
>> the classifier "project", not what we want, do we?
>>
>>
>> Benjamin
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>


--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Follow up on creating ASF-compliant source releases

by Dennis Lundberg-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I know you've put a lot of time and effort into this Brian. Thanks for
that. I thought that most of the work was to fix potential problems in
multi module builds.

Brian Fox wrote:

> no...this is what i've been working on just slowly. It's almost done
> though, and the idea is that it should just work in almost all cases.
>
> On Thu, Jul 9, 2009 at 4:22 PM, Dennis Lundberg<dennisl@...> wrote:
>> Hi
>>
>> For a *single* module project, like one of our Maven plugins, do I
>> really have to create an assembly descriptor?
>>
>> Wouldn't it work if I just use the predefined "project" descriptor?
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>


--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Follow up on creating ASF-compliant source releases

by John Casey-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hmm, I thought I fixed the project descriptor in 2.2-beta-4? Maybe not...

Brett Porter wrote:

>
> On 10/07/2009, at 6:22 AM, Dennis Lundberg wrote:
>
>> Hi
>>
>> For a *single* module project, like one of our Maven plugins, do I
>> really have to create an assembly descriptor?
>>
>> Wouldn't it work if I just use the predefined "project" descriptor?
>
> Yes, if you do not have any source packages called "target".
>
> - Brett
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...