FreeDiams uploaded

[Eric MAEKER]

Hi all,

I've just uploaded FreeDiams debian/* files to the svn.
Can anyone check them ?

Thanks
Eric


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Thu, Oct 01, 2009 at 05:42:08PM +0200, Eric MAEKER wrote:
> I've just uploaded FreeDiams debian/* files to the svn.

Thanks.  I commited some cosmetical changes.  The main issue which
prevents me from a real check is that I have no idea how to obtain the
source tarball.  I did not found such a thing on your homepage and there
is not get-orig-source (optional bt helpful) in your debian/rules file.

Kind regards

    ANdreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Thu, Oct 01, 2009 at 10:21:48PM +0200, Eric MAEKER wrote:
> Oh I can create a command that automatically dld tar.gz file ? Very  
> interesting. I'll take a look to doc.

Developers reference: 6.7.8.2. Repackaged upstream source

It is talking about repackaged orig.tar.gz but I think it is handy in
any way.  If you like to browse the Debian Med SVN for

    find packages -name get-orig-source

you will find examples for such scripts.  It is used as rule for the
get-orig-source target in the according rules file.  While this is
definitely not mandatory if you do not change the original tarball I
like to have a default way to get the original source and put it in
nearly all of may packages.

Moreover you might consider a debian/watch file once your original
tarball is online (see man uscan).

Kind regards

    Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Eric MAEKER]

Ok, so if I mostly understand scripts, I should wget files in '../
tarballs'. That's sounds strange for me to create a dir outside a svn  
bundle (or the script's working dir), but nevermind I'll wrote the  
script this way.
It is not very difficult...
Sources are getting closed.

Thanks,
Eric
http://www.freemedforms.com/

Le 2 oct. 09 à 07:33, Andreas Tille a écrit :

> On Thu, Oct 01, 2009 at 10:21:48PM +0200, Eric MAEKER wrote:
>> Oh I can create a command that automatically dld tar.gz file ? Very
>> interesting. I'll take a look to doc.
>
> Developers reference: 6.7.8.2. Repackaged upstream source
>
> It is talking about repackaged orig.tar.gz but I think it is handy in
> any way.  If you like to browse the Debian Med SVN for
>
>   find packages -name get-orig-source
>
> you will find examples for such scripts.  It is used as rule for the
> get-orig-source target in the according rules file.  While this is
> definitely not mandatory if you do not change the original tarball I
> like to have a default way to get the original source and put it in
> nearly all of may packages.
>
> Moreover you might consider a debian/watch file once your original
> tarball is online (see man uscan).
>
> Kind regards
>
>   Andreas.
>
> --
> http://fam-tille.de
>

--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Fri, Oct 02, 2009 at 09:38:25AM +0200, Eric MAEKER wrote:
> Ok, so if I mostly understand scripts, I should wget files in '../
> tarballs'. That's sounds strange for me to create a dir outside a svn  
> bundle (or the script's working dir), but nevermind I'll wrote the  
> script this way.

Our policy for using SVN is to store only the debian directory in
the repository.  The files in the debian directory might deal with
other locations in your directory tree.  We do not commit the source
tarball into the SVN.

If it fits your workflow better you might be interested in the new
Git repository[1] which has a different workflow and keeps the whole
upstream source as well.

Kind regards

       Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Eric MAEKER]

Le 2 oct. 09 à 11:39, Andreas Tille a écrit :
> Our policy for using SVN is to store only the debian directory in
> the repository.  The files in the debian directory might deal with
> other locations in your directory tree.  We do not commit the source
> tarball into the SVN.
Ok so if I understand. During the build/packaging process, your  
commands look like :
cd trunk/package/<app>/trunk
./debian/get-orig-source  (tarballs directory is create in <app>/
trunk, sources are stored there - outside svn)
cd tarballs
untar
cd <app>-<version>
debuild [...]
cd ..
sudo pbuilder [...]

That it ?

I'll commit the script this afternoon so you can check the  
'mecanism' ;) I can make all necessary correction if needed.

> If it fits your workflow better you might be interested in the new
> Git repository[1] which has a different workflow and keeps the whole
> upstream source as well.
Hummm, svn if painfull enough for me ;)

> Kind regards
>
>       Andreas.
Thanks for your time and advises.

Eric




--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Eric MAEKER]

Le 2 oct. 09 à 12:21, Eric MAEKER a écrit :

> I'll commit the script this afternoon so you can check the  
> 'mecanism' ;) I can make all necessary correction if needed.
Script and sources committed (script on your svn, source --> get-orig-
source).

Eric


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Fri, Oct 02, 2009 at 01:08:58PM +0200, Eric MAEKER wrote:
> Script and sources committed (script on your svn, source --> get-orig-
> source).

I commited cosmetical changes using dpkg-parsechangelog.  But your
download URL seems to be a cut-n-pasto from imagej. Could you please fix
the download URL?

Kind regards

    Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Eric MAEKER]

Hi Andreas,
Le 2 oct. 09 à 21:44, Andreas Tille a écrit :
> On Fri, Oct 02, 2009 at 01:08:58PM +0200, Eric MAEKER wrote:
>> Script and sources committed (script on your svn, source --> get-
>> orig-
>> source).
>
> I commited cosmetical changes using dpkg-parsechangelog.  But your
> download URL seems to be a cut-n-pasto from imagej. Could you please  
> fix
> the download URL?

Yes greatly thanks for your additions.
Script looks great, i've changed wget url. like this :
   wget -q $URL
That's all.

Eric

--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Fri, Oct 02, 2009 at 10:06:19PM +0200, Eric MAEKER wrote:
> Script looks great, i've changed wget url. like this :
>   wget -q $URL
> That's all.
Ahh, that's easy. ;-)
Comments to your upstream tarball in the first place:

  - Please set the permissions of images (*.png) to not executable.
    Lintian floods you with warnings about files with executable permissions
    which are not executable.
    There are also some executable *.txt files in the tarball.
  - I also found some .DS_Store files in the tarball - I would also remove
    this.
  - Please leave out the debian directory out of your upstream tarball.
    As you might see now yourself you have a difference between the
    upstream tarball and the packaging stuff in SVN.  This can easily
    prevented by just not including the debian directory in the upstream
    tarball.

For the packaging I would split the data files into a separate arch=all
package.  There is some information about the reasons to do so in the
net which I do not want to repeat here.  I'd happily volunteer to do
this change because I'm afraid that you are not as experienced than me
in this kind of stuff.  I'd also add a freediams-doc package.  I think I
might commit these changes today evening if you like this.  You might
consider to apply my suggestions to your tarball meanwhile.

Kind regards and thanks for working on freediams

     Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Eric MAEKER]

Le 3 oct. 09 à 09:33, Andreas Tille a écrit :

> On Fri, Oct 02, 2009 at 10:06:19PM +0200, Eric MAEKER wrote:
>> Script looks great, i've changed wget url. like this :
>>  wget -q $URL
>> That's all.
> Ahh, that's easy. ;-)
Yes, that's all me ;)

> Comments to your upstream tarball in the first place:
>
>  - Please set the permissions of images (*.png) to not executable.
>    Lintian floods you with warnings about files with executable  
> permissions
>    which are not executable.
>    There are also some executable *.txt files in the tarball.
Oooops yes that's a problem with svn properties... I'll correct this.

>  - I also found some .DS_Store files in the tarball - I would also  
> remove
>    this.
Aaaahhhh MacOs... I love it ;)

>  - Please leave out the debian directory out of your upstream tarball.
Oh. debuilder includes debian/* files in autogenerated tarball ?
If so, I'll create my own tarball with my own command...

>    As you might see now yourself you have a difference between the
>    upstream tarball and the packaging stuff in SVN.  This can easily
>    prevented by just not including the debian directory in the  
> upstream
>    tarball.
Yes, this error was not voluntary. And I'll correct this.

> For the packaging I would split the data files into a separate  
> arch=all
> package.
Oh yes, I'd like to do it myself but time is missing and documentation  
for this kind of work is.... big...
But this is an issue.

> There is some information about the reasons to do so in the
> net which I do not want to repeat here.  I'd happily volunteer to do
> this change because I'm afraid that you are not as experienced than me
> in this kind of stuff.
Eh eh ! You already know me well ;)
Yes thank you for all your help.
Can I add your contribution into the About page of FreeDiams/
FreeMedForms (including public mail) ?

> I'd also add a freediams-doc package.  I think I
> might commit these changes today evening if you like this.  You might
> consider to apply my suggestions to your tarball meanwhile.
Hummm, I'm on holidays this night and off-line for one week. So yes,  
I'll make changes since 12th of Octobre.


> Kind regards and thanks for working on freediams
Thanks for your help !!!

>     Andreas.
Eric


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Sat, Oct 03, 2009 at 10:58:00AM +0200, Eric MAEKER wrote:
>> For the packaging I would split the data files into a separate  
>> arch=all
>> package.
> Oh yes, I'd like to do it myself but time is missing and documentation  
> for this kind of work is.... big...
> But this is an issue.

No problem. For this purpose we like to provide help in the Debian Med
team.

> Can I add your contribution into the About page of FreeDiams/
> FreeMedForms (including public mail) ?

I don't really mind - mentioning the Debian Med team might make
sense.

> Hummm, I'm on holidays this night and off-line for one week. So yes,  
> I'll make changes since 12th of Octobre.

I can also do the doc package - no problem.

I have one question: You installed

   global_resources/databases/drugs/drugs.db

but

   global_resources/databases/drugs/dosages.db

did not ended up in the package.  Is this intentional or just a
bug in the installer?

Kind regards

     Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Sat, Oct 03, 2009 at 10:58:00AM +0200, Eric MAEKER wrote:
>> For the packaging I would split the data files into a separate  
>> arch=all
>> package.
> Oh yes, I'd like to do it myself but time is missing and documentation  
> for this kind of work is.... big...
> But this is an issue.

No problem. For this purpose we like to provide help in the Debian Med
team.

> Can I add your contribution into the About page of FreeDiams/
> FreeMedForms (including public mail) ?

I don't really mind - mentioning the Debian Med team might make
sense.

> Hummm, I'm on holidays this night and off-line for one week. So yes,  
> I'll make changes since 12th of Octobre.

I can also do the doc package - no problem.

I have one question: You installed

   global_resources/databases/drugs/drugs.db

but

   global_resources/databases/drugs/dosages.db

did not ended up in the package.  Is this intentional or just a
bug in the installer?

Kind regards

     Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Eric MAEKER]

> I have one question: You installed
>
>  global_resources/databases/drugs/drugs.db
This the general database --> /usr/share/freediams

> but
>   global_resources/databases/drugs/dosages.db
This is a personnal database created by the application on the first  
start up --> $home/.freediams/databases/drugs
This file must not be present in the actual package ? It will be  
present on next releases, and should be named differently.

Eric



--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

Hi,

I commited packaging stuff for FreeDiams which splits the single binary
into two and also adds a doc packages.  I'm not completely happy with
this because when activating the rpath patch the dynamic libraries are
not found in the end.  This might be investigated later.

I have a question with the upstream program: Is there really a need
for asking the user to agree with the license?

Kind regards

      Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Eric MAEKER]

Hi Andreas, Hi all,

So, I've made some bug corrections, files properties corrections and  
some improvements in FreeDiams. These are not yet published.

Le 4 oct. 09 à 22:33, Andreas Tille a écrit :
> I commited packaging stuff for FreeDiams which splits the single  
> binary
> into two and also adds a doc packages.
Ok I'll make some changes with upcoming v0.1.2 (debug version). Doc  
path will be all lowered (doc/html/freediams)

> I'm not completely happy with
> this because when activating the rpath patch the dynamic libraries are
> not found in the end.  This might be investigated later.
Yes I don't really understand this, you've defined the LD_LIBRARY_PATH  
in rules, so rpath is not necessary after installation ?
There are two rpath definitions :
- libs/rpath.pri --> used by libs and main app
- plugins/fmf_plugins.pri --> used by plugins
I saw in your diff that you only changed the main app / libs rpath,  
not the plugins.
Please, send me your complete error log. I'll try to manage this.

> I have a question with the upstream program: Is there really a need
> for asking the user to agree with the license?
Hummm, I'm protecting myself of any "reclamation"...
I'm not really inform of legal issues in Open Source software.
I must add a start message like this : "FreeDiams MUST NOT BE USED for  
automedication, please contact your doctor."

> Kind regards
>
>      Andreas.
Eric

--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Karsten Hilbert]

On Fri, Oct 16, 2009 at 10:36:04AM +0200, Eric MAEKER wrote:

> >I have a question with the upstream program: Is there really a need
> >for asking the user to agree with the license?
> Hummm, I'm protecting myself of any "reclamation"...
> I'm not really inform of legal issues in Open Source software.
> I must add a start message like this : "FreeDiams MUST NOT BE USED
> for automedication, please contact your doctor."

Ah, I see. This is less an issue with users as such rather
than with non-doctor users. I agree you better include such
a disclaimer. It got nothing to do with whether this is Open
Source or not.

Karsten
--
GPG key ID E4071346 @ wwwkeys.pgp.net
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Fri, Oct 16, 2009 at 10:36:04AM +0200, Eric MAEKER wrote:
> So, I've made some bug corrections, files properties corrections and  
> some improvements in FreeDiams. These are not yet published.

I'd suggest we try the same packaging stuff on your new version.
Or is there anything which prevents your from releasing this besides
the packaging issues?

> Ok I'll make some changes with upcoming v0.1.2 (debug version). Doc path
> will be all lowered (doc/html/freediams)

This can be adapted easily.

> Yes I don't really understand this, you've defined the LD_LIBRARY_PATH  
> in rules, so rpath is not necessary after installation ?
> There are two rpath definitions :
> - libs/rpath.pri --> used by libs and main app
> - plugins/fmf_plugins.pri --> used by plugins
> I saw in your diff that you only changed the main app / libs rpath, not
> the plugins.
> Please, send me your complete error log. I'll try to manage this.

Well, there is no real errorlog.  The package builds and the program
runs.  If I try to remove the rpath warnings by patching the Makefile
the programm does not run any more because it does not find the
libraries in the subdirectory.  But as I said: we should leave it as
it is for the moment and continue working on this later.

>> I have a question with the upstream program: Is there really a need
>> for asking the user to agree with the license?
> Hummm, I'm protecting myself of any "reclamation"...
> I'm not really inform of legal issues in Open Source software.

Well, the licensing issue is *really* unusual when running GPLed
software.

> I must add a start message like this : "FreeDiams MUST NOT BE USED for  
> automedication, please contact your doctor."

I have no idea whether this is needed or not.  You might discuss this
issue on the Debian Med list because there are doctors who might know.

Kind regards

       Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Eric MAEKER]

Le 16 oct. 09 à 14:13, Andreas Tille a écrit :

> I'd suggest we try the same packaging stuff on your new version.
Ok for the three file packaging. Can you help me on configuring a  
package repository ? I known 'repro' as a repository maker...

>> Yes I don't really understand this, you've defined the  
>> LD_LIBRARY_PATH
>> in rules, so rpath is not necessary after installation ?
>> There are two rpath definitions :
>> - libs/rpath.pri --> used by libs and main app
>> - plugins/fmf_plugins.pri --> used by plugins
>> I saw in your diff that you only changed the main app / libs rpath,  
>> not
>> the plugins.
>> Please, send me your complete error log. I'll try to manage this.
>
> Well, there is no real errorlog.  The package builds and the program
> runs.  If I try to remove the rpath warnings by patching the Makefile
> the programm does not run any more because it does not find the
> libraries in the subdirectory.  But as I said: we should leave it as
> it is for the moment and continue working on this later.

Oh I understand, Litian warns about a wrong rpath and you tried to  
remove the whole rpath configuration ?
If this is the problem, yes you should better ignore it for now... I  
don't really know how to remove these warnings easily for now.

> Well, the licensing issue is *really* unusual when running GPLed
> software.
That's true. I don't really know what is the best choice for this  
dialog.
You should know that it appears only once each time you update the  
version, or at the first start up.
This is not really annoying.

>> I must add a start message like this : "FreeDiams MUST NOT BE USED  
>> for
>> automedication, please contact your doctor."
>
> I have no idea whether this is needed or not.  You might discuss this
> issue on the Debian Med list because there are doctors who might know.
Ok so the question is asked ;)

> Kind regards
>
>       Andreas.
Eric

--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Andreas Tille-6]

On Fri, Oct 16, 2009 at 02:31:05PM +0200, Eric MAEKER wrote:
>> I'd suggest we try the same packaging stuff on your new version.
> Ok for the three file packaging. Can you help me on configuring a  
> package repository ? I known 'repro' as a repository maker...

I'm afraid I do not understand the question.  What exactly is
repro?
You get the three binary packages if you unpack your source tarball
checkout the debian directory of freediams from SVN copy it to
the unpackage tarball and say `debuild` there.  That's basically
all.

> Oh I understand, Litian warns about a wrong rpath and you tried to  
> remove the whole rpath configuration ?

Yes.  And I redid this change because at least my change broke the
resulting binary.

> If this is the problem, yes you should better ignore it for now... I  
> don't really know how to remove these warnings easily for now.

This is what I suggested.

> That's true. I don't really know what is the best choice for this  
> dialog.
> You should know that it appears only once each time you update the  
> version, or at the first start up.
> This is not really annoying.

It is finally your decision and I just have given a comment from my
(uneducated) perspective.  If you think it is needed - just ignore my
comment.  But after your explanation I actually wonder whether the
current way to express:

>>> I must add a start message like this : "FreeDiams MUST NOT BE USED  
>>> for
>>> automedication, please contact your doctor."

is very proably overlooked by users who are "trained" to click licensing
information away ...  So I would really not mix up the licensing
information which is actually more or less useless whith the medical
information which seems to be very important.  At least *I* did *not*
noticed this information.

>> I have no idea whether this is needed or not.  You might discuss this
>> issue on the Debian Med list because there are doctors who might know.
> Ok so the question is asked ;)

Fine for me but as I said try to focus it more onto the real intend.

Kind regards

    Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...