GMENU und wrapItemAndSub

[Philipp Metzler]

Hello,

Why is it not possible to use wrapItemAndSub with GMENU? Wouldn't it  
be easy to copy the code for that feature from TMENU? Or is there a  
good reason for not doing this? We have a project where we'd like to  
generate the menues (3 levels) with GMENU and have a nested DIV-
structure so that we can animate the layers with jquery.

Best regards,

Philipp

_______________________________________________________________

DI Philipp Metzler
Goli.at GesbR.
Dorf Rieden 7/11
A-6900 Bregenz
EU - Austria

E-Mail: phil@...
Skype (Internet Phone): googol
Tel: +43 / 676 / 72 94 176
ICQ: 13950954

o www.philippmetzler.com - Softwareentwicklung und Websites mit Typo3.
o www.goli.at - Ihr Speicherplatz im Web. Messen Sie uns an unseren  
Daten.
o www.clickshopping.at - Wir bringen Ihre Produkte auf den Punkt.
o www.greencar.at - Elektroautos und mehr ...
_______________________________________________________________

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Moreno Feltscher]

I also missed that feature one time in the past.
Would be nice to have this one..

+1 for wrapItemAndSub on GMENU

Or are there any reasons why this isn't implemented?


Cheers
Moreno
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Tapio Markula-3]

Moreno Feltscher kirjoitti:
> I also missed that feature one time in the past.
> Would be nice to have this one..
>
> +1 for wrapItemAndSub on GMENU
>
> Or are there any reasons why this isn't implemented?
>
>
maybe thought that image menus don't need text wrappers
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Kamper-3]

Hi,

+1 for having it.

I made a small patch which should do it, please test and report (havn't
time for testing now)

vg Steffen

Index: typo3/sysext/cms/tslib/class.tslib_menu.php
===================================================================
--- typo3/sysext/cms/tslib/class.tslib_menu.php (revision 4016)
+++ typo3/sysext/cms/tslib/class.tslib_menu.php (working copy)
@@ -2429,6 +2429,8 @@
  if (!$this->I['spacer']) {
  $this->WMresult.= $this->subMenu($this->I['uid'], $this->WMsubmenuObjSuffixes[$key]['sOSuffix']);
  }
+ $part = $this->WMcObj->stdWrap($this->I['val']['wrapItemAndSub'],$this->I['val']['wrapItemAndSub.']);
+ $this->WMresult.= $part ? $this->tmpl->wrap($this->I['theItem'],$part) : $this->I['theItem'];
  }
 
 

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Kamper-3]

Steffen Kamper schrieb:
> Hi,
>
> +1 for having it.
>
> I made a small patch which should do it, please test and report (havn't
> time for testing now)
>
> vg Steffen
>
seems not interesting?

vg Steffen
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Martin Kutschker-7]

Steffen Kamper schrieb:

> Steffen Kamper schrieb:
>> Hi,
>>
>> +1 for having it.
>>
>> I made a small patch which should do it, please test and report
>> (havn't time for testing now)
>>
>> vg Steffen
>>
> seems not interesting?

No, I never use GMENU. I've been told to use text menus for
accessibility reasons. Yeah, I know I could use alt/title but I cannot
recall creating an image menu for a very long time.

Masi
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Tapio Markula-3]

Steffen Kamper kirjoitti:

> Steffen Kamper schrieb:
>> Hi,
>>
>> +1 for having it.
>>
>> I made a small patch which should do it, please test and report
>> (havn't time for testing now)
>>
>> vg Steffen
>>
> seems not interesting?
>
> vg Steffen

Philip would be interested
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Kamper-3]

Martin Kutschker schrieb:
> Steffen Kamper schrieb:

>>>
>> seems not interesting?
>
> No, I never use GMENU. I've been told to use text menus for
> accessibility reasons. Yeah, I know I could use alt/title but I cannot
> recall creating an image menu for a very long time.
>

same with me. But GMENU is part of the core and some use it, not all
need the accessibility.

In some cases it's important if client wishes to use their house font.
There are some techniques to use images and having accessibility.

vg Steffen
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Tapio Markula-3]

Steffen Kamper kirjoitti:

> Martin Kutschker schrieb:
>> Steffen Kamper schrieb:
>
>>>>
>>> seems not interesting?
>>
>> No, I never use GMENU. I've been told to use text menus for
>> accessibility reasons. Yeah, I know I could use alt/title but I cannot
>> recall creating an image menu for a very long time.
>>
>
> same with me. But GMENU is part of the core and some use it, not all
> need the accessibility.
>
> In some cases it's important if client wishes to use their house font.
> There are some techniques to use images and having accessibility.
>
> vg Steffen

do you have a diff - I could put that into tm_contentaccess.
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Martin Kutschker-7]

Steffen Kamper schrieb:

> Martin Kutschker schrieb:
>> Steffen Kamper schrieb:
>
>>>>
>>> seems not interesting?
>>
>> No, I never use GMENU. I've been told to use text menus for
>> accessibility reasons. Yeah, I know I could use alt/title but I cannot
>> recall creating an image menu for a very long time.
>>
>
> same with me. But GMENU is part of the core and some use it, not all
> need the accessibility.

Sure, but there are so many small issues. I cannot care or be interested
in every single one of them.

Masi
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Kamper-3]

Tapio Markula schrieb:

> Steffen Kamper kirjoitti:
>> Martin Kutschker schrieb:
>>> Steffen Kamper schrieb:
>>
>>>>>
>>>> seems not interesting?
>>>
>>> No, I never use GMENU. I've been told to use text menus for
>>> accessibility reasons. Yeah, I know I could use alt/title but I cannot
>>> recall creating an image menu for a very long time.
>>>
>>
>> same with me. But GMENU is part of the core and some use it, not all
>> need the accessibility.
>>
>> In some cases it's important if client wishes to use their house font.
>> There are some techniques to use images and having accessibility.
>>
>> vg Steffen
> do you have a diff - I could put that into tm_contentaccess.

i attached diff to my post before

vg Steffen
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Kamper-3]

Martin Kutschker schrieb:

> Steffen Kamper schrieb:
>> Martin Kutschker schrieb:
>>> Steffen Kamper schrieb:
>>>> seems not interesting?
>>> No, I never use GMENU. I've been told to use text menus for
>>> accessibility reasons. Yeah, I know I could use alt/title but I cannot
>>> recall creating an image menu for a very long time.
>>>
>> same with me. But GMENU is part of the core and some use it, not all
>> need the accessibility.
>
> Sure, but there are so many small issues. I cannot care or be interested
> in every single one of them.
>
> Masi

:-) my question was addressed to original poster ;-)

vg Steffen
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Tapio Markula-3]

Steffen Kamper kirjoitti:

> Tapio Markula schrieb:
>> Steffen Kamper kirjoitti:
>>> Martin Kutschker schrieb:
>>>> Steffen Kamper schrieb:
>>>
>>>>>>
>>>>> seems not interesting?
>>>>
>>>> No, I never use GMENU. I've been told to use text menus for
>>>> accessibility reasons. Yeah, I know I could use alt/title but I cannot
>>>> recall creating an image menu for a very long time.
>>>>
>>>
>>> same with me. But GMENU is part of the core and some use it, not all
>>> need the accessibility.
>>>
>>> In some cases it's important if client wishes to use their house
>>> font. There are some techniques to use images and having accessibility.
>>>
>>> vg Steffen
>> do you have a diff - I could put that into tm_contentaccess.
>
> i attached diff to my post before

I found a problem with XCLASSing.

gmenu extends tslib_menu
but I have

class ux_tslib_menu extends tslib_menu

but that is not apparently used with

class tslib_gmenu extends tslib_menu {
...

Is this ok?

class ux_tslib_tmenu extends ux_tslib_menu {
}
...

class ux_tslib_gmenu extends ux_tslib_menu {
...
        function extProc_afterLinking($key) {
...

                $part =
$this->WMcObj->stdWrap($this->I['val']['wrapItemAndSub'],$this->I['val']['wrapItemAndSub.']);
                $this->WMresult.= $part ? $this->tmpl->wrap($this->I['theItem'],$part)
: $this->I['theItem'];
        }
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Philipp Metzler]

Hello Steffen,

Thanks a lot for your quick patch. We just tested it. The result is,  
that the menu items are displayed twice now.

Plese check it out here: http://neu.danklhampel.com/

Changed the code in class tslib_gmenu as you described. It looks like  
this now:

**********************

        function extProc_afterLinking($key) {
                $this->WMresult.=$this->I['theItem'];
                if (!$this->I['spacer']) {
                        $this->WMresult.= $this->subMenu($this->I['uid'], $this-
 >WMsubmenuObjSuffixes[$key]['sOSuffix']);
                }
                $part = $this->WMcObj->stdWrap($this->I['val']['wrapItemAndSub'],
$this->I['val']['wrapItemAndSub.']);
                $this->WMresult.= $part ? $this->tmpl->wrap($this->I['theItem'],
$part) : $this->I['theItem'];
        }

**********************

The Typoscript we use looks like this:

lib.mainMenu = HMENU
lib.mainMenu {

         1=GMENU
         1 {
                 expAll = 1
                 noBlur = 1
                               
                 #wrap.allStdWrap.insertData = 1
                 allStdWrap.insertData = 1
                 wrap (
                     <div id="level_1_{field:uid}" class="MainMenu">
                         |
                     </div>
                 )
             
                 NO = 1
                 NO {
                         wrapItemAndSub.insertData = 1
                         wrapItemAndSub(
                             <div onMouseOver="showMessage('animate  
level (if exists) else content with id: {field:uid}');"  
class="MainMenuItem">
                                 |
                                 <div id="Content_{field:uid}"  
class="Content"></div>
                             </div>
                         )

                         transparentBackground = 1
                         ATagTitle.field = title
                         XY=[10.w]+10,24

                         10=TEXT
                         10 {
                                 text.field=title
                                 offset=1,20
                                 fontColor=#000000
                                 fontFile=fileadmin/fonts/BodoniStd.otf
                                 fontSize=18
                         }
                 }
                 ACT <.NO
                 ACT.10.fontColor = #666666

                 RO <.NO
                 RO.10.fontColor = #666666

                 ACTRO <.RO
         }


Best regards,

Philipp

_______________________________________________________________

DI Philipp Metzler
Goli.at GesbR.
Dorf Rieden 7/11
A-6900 Bregenz
EU - Austria

E-Mail: phil@...
Skype: googol
Tel: +43 / 676 / 72 94 176
ICQ: 13950954

∙ www.philippmetzler.com - Softwareentwicklung und Websites mit Typo3.
∙ www.goli.at - Ihr Speicherplatz im Web. Messen Sie uns an unseren  
Daten.
∙ www.clickshopping.at - Wir bringen Ihre Produkte auf den Punkt.
∙ www.greencar.at - Elektroautos und mehr ...
_______________________________________________________________

Am 26.08.2008 um 12:00 schrieb typo3-dev-request@...:

> Steffen Kamper schrieb:
>> Hi,
>>
>> +1 for having it.
>>
>> I made a small patch which should do it, please test and report  
>> (havn't
>> time for testing now)
>>
>> vg Steffen
>>
> seems not interesting?
>
> vg Steffen

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Philipp Metzler]

Hallo,

I decided to use TMENU now because the patch for GMENU with  
wrapItemAndSub did not work (at least for me) and because of the  
active state for the graphical menu. As the page is not beeing  
reloaded GMENU will not work for that - although I assume you could  
manipulate the links with Javascript in the DOM.

So now I use imgNameNotRandom = 1, access the images with Javascript  
and use it for the menu. Then I load the Content with Ajax.

But thanks a lot for your quick answer! I assume one would have to  
test the patch thoroughly first.

Best regards,

Philipp

_______________________________________________________________

DI Philipp Metzler
Goli.at GesbR.
Dorf Rieden 7/11
A-6900 Bregenz
EU - Austria

E-Mail: phil@...
Skype: googol
Tel: +43 / 676 / 72 94 176
ICQ: 13950954

∙ www.philippmetzler.com - Softwareentwicklung und Websites mit Typo3.
∙ www.goli.at - Ihr Speicherplatz im Web. Messen Sie uns an unseren  
Daten.
∙ www.clickshopping.at - Wir bringen Ihre Produkte auf den Punkt.
∙ www.greencar.at - Elektroautos und mehr ...
_______________________________________________________________

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Moreno Feltscher]

Nothing new here?
A working patch would be nice.. I can't do this by myself, knowledge
problem based :-)

Cheers
Moreno
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Helmut Hummel-2]

Hi,

Steffen Kamper schrieb:

> Martin Kutschker schrieb:
>>
>> No, I never use GMENU. I've been told to use text menus for
>> accessibility reasons. Yeah, I know I could use alt/title but I cannot
>> recall creating an image menu for a very long time.
>
> same with me. But GMENU is part of the core and some use it, not all
> need the accessibility.
>
> In some cases it's important if client wishes to use their house font.
> There are some techniques to use images and having accessibility.

Well, there are solutions how to get the GMENU accessible:
http://wiki.typo3.org/index.php/GTMENU

It would be very nice to implement this into core or to rewrite GMENU to
output accessible HTML/CSS code.

Any volunteers? ;)

Kind regards
Helmut
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[jujuthing]

+1

Philipp Metzler wrote:

> Hello,
>
> Why is it not possible to use wrapItemAndSub with GMENU? Wouldn't it be
> easy to copy the code for that feature from TMENU? Or is there a good
> reason for not doing this? We have a project where we'd like to generate
> the menues (3 levels) with GMENU and have a nested DIV-structure so that
> we can animate the layers with jquery.
>
> Best regards,
>
> Philipp
>
> _______________________________________________________________
>
> DI Philipp Metzler
> Goli.at GesbR.
> Dorf Rieden 7/11
> A-6900 Bregenz
> EU - Austria
>
> E-Mail: phil@...
> Skype (Internet Phone): googol
> Tel: +43 / 676 / 72 94 176
> ICQ: 13950954
>
> o www.philippmetzler.com - Softwareentwicklung und Websites mit Typo3.
> o www.goli.at - Ihr Speicherplatz im Web. Messen Sie uns an unseren Daten.
> o www.clickshopping.at - Wir bringen Ihre Produkte auf den Punkt.
> o www.greencar.at - Elektroautos und mehr ...
> _______________________________________________________________
>

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Stano Paška-2]

I use GMENU with GTMenu userfunction (accessible menu with hidden text
and css images, with hover functionality) and wrapitemandsub is good
thing.
I patched Typo3 by myself.

Stano.

On Tue, Aug 26, 2008 at 11:26 AM, Martin Kutschker
<masi-no@...> wrote:

> Steffen Kamper schrieb:
>> Steffen Kamper schrieb:
>>> Hi,
>>>
>>> +1 for having it.
>>>
>>> I made a small patch which should do it, please test and report
>>> (havn't time for testing now)
>>>
>>> vg Steffen
>>>
>> seems not interesting?
>
> No, I never use GMENU. I've been told to use text menus for
> accessibility reasons. Yeah, I know I could use alt/title but I cannot
> recall creating an image menu for a very long time.
>
> Masi
> _______________________________________________
> TYPO3-dev mailing list
> TYPO3-dev@...
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev
>

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Christopher Torgalson]

Hi,

On Wed, Jan 21, 2009 at 9:41 AM, Stano Paška <stano.paska@...> wrote:

> I use GMENU with GTMenu userfunction (accessible menu with hidden text
> and css images, with hover functionality) and wrapitemandsub is good
> thing.
> I patched Typo3 by myself.
>
> Stano.
>
> On Tue, Aug 26, 2008 at 11:26 AM, Martin Kutschker
> <masi-no@...> wrote:
>> Steffen Kamper schrieb:
>>> Steffen Kamper schrieb:
>>>> Hi,
>>>>
>>>> +1 for having it.
>>>>
>>>> I made a small patch which should do it, please test and report
>>>> (havn't time for testing now)
>>>>
>>>> vg Steffen
>>>>
>>> seems not interesting?
>>
>> No, I never use GMENU. I've been told to use text menus for
>> accessibility reasons. Yeah, I know I could use alt/title but I cannot
>> recall creating an image menu for a very long time.

Since this thread has been resurrected, I recommend my extension
'bh_firtools' [1]. It's all Typoscript and, IMO, much superior to
GTMENU since it allows the generated CSS to be placed in the head of
the page or, if you prefer, in a dynamic stylesheet [2].


[1] http://typo3.org/extensions/repository/view/bh_firtools/current/
[2] http://typo3.org/documentation/document-library/extension-manuals/bh_firtools/2.1.2/view/1/5/#id4043640

--
Christopher Torgalson
http://www.typo3apprentice.com/
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev