Nabble - Gaim - Patches

[Gaim-patches] [ gaim-Patches-1692595 ] most prioritized buddy in expanded contact sign off weirdnes

2007-04-18T07:48:27Z

Patches item #1692595, was opened at 2007-04-01 18:07
Message generated for change (Comment added) made by rlaager
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1692595&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Later
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Nobody/Anonymous (nobody)
Summary: most prioritized buddy in expanded contact sign off weirdnes

Initial Comment:
... because the contact priority is not always invalidated when the blist is updated. I removed the ui update in notify_buddy_status_update() because it doesn't recompute the priority and because the only call path for that function already updates the blist

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-04-18 08:48

Message:
Logged In: YES
user_id=156487
Originator: NO

This has been moved to Trac, right?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1692595&group_id=235

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1413778 ] Conversation: confirm before close unread tabs

2007-04-18T07:47:14Z

Patches item #1413778, was opened at 2006-01-24 09:49
Message generated for change (Comment added) made by rlaager
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1413778&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 4
Private: No
Submitted By: Sadrul Habib Chowdhury (sadrul)
Assigned to: Nobody/Anonymous (nobody)
Summary: Conversation: confirm before close unread tabs

Initial Comment:
This patch requests confirmation before closing tabs
with unread messages (from `Close other tabs' or `close
all tabs')

It also makes the gtkconv the handle for the notify/
request dialogs, which I think makes more sense.

-- Adil

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-04-18 08:47

Message:
Logged In: YES
user_id=156487
Originator: NO

sadrul: If you can deal with my one objection here, you should totally
commit this (but maybe post-2.0.0 for string freeze reasons). Otherwise,
could you please move this to Trac?

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2006-02-07 01:05

Message:
Logged In: YES
user_id=156487

If I close a window, I don't want to see more than one
confirmation dialog.

----------------------------------------------------------------------

Comment By: Sadrul Habib Chowdhury (sadrul)
Date: 2006-02-07 00:55

Message:
Logged In: YES
user_id=1132702

The existing confirmation dialog comes up only when you
close the whole window, but doesn't popup when you do `Close
other tabs' or `close this tab', or [accidentally] click on
the [x]. And the existing dialog is modal.

I have attached a new patch which removes the existing
dialog, and uses the new dialogs. The result is, a popup
will appear for each tab with unread messages, and the tabs
with no unread messages will be closed. This behaviour is
different from the existing behaviour (currently it doesn't
close any tab).

I am unable to decide whether this would confuse users.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2006-02-06 20:33

Message:
Logged In: YES
user_id=156487

I accepted the gtkconv handle portion of this patch.
Thanks.

As for the confirmation dialog.... We already have code to
build a confirmation window when you try to close the
window and one of the tabs has unread messages. I'd like to
see this new dialog be more connsisten with that. The code
should probably be reworked a bit so there isn't
duplication. Let me know if that sounds stupid.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1413778&group_id=235

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1575202 ] Consistent docklet statuses

2007-04-18T07:46:09Z

Patches item #1575202, was opened at 2006-10-11 06:45
Message generated for change (Comment added) made by rlaager
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1575202&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: Richard Nelson (wabz)
Assigned to: Sean Egan (seanegan)
Summary: Consistent docklet statuses

Initial Comment:
This brings the docklet status list in line with the
status selector - when only accounts of one protocol
type are online, show that protocol's statuses.

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-04-18 08:46

Message:
Logged In: YES
user_id=156487
Originator: NO

wabz: You're a developer now. ;) If this makes sense, you should commit it
to the Pidgin tree.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2006-11-19 01:08

Message:
Logged In: YES
user_id=156487
Originator: NO

Sean, can you take a look at this please?

----------------------------------------------------------------------

Comment By: Richard Nelson (wabz)
Date: 2006-10-19 07:31

Message:
Logged In: YES
user_id=698726

Even after the changes to the statusbox for b4, choosing a
per-protocol primitive status from the docklet didn't make
the statusbox reflect the change. This is because
gaim_account_set_status does not update a saved status, or
create a new one.

I considered making gaim_account_set_status do Something
Smart, but decided it's really impossible to find out what
whatever is calling it really wants - is it trying to set
all accounts to a primitive status? Does it want a new one?
I think whatever is calling it should be aware that it's not
going to change the default status, and the statusbox isn't
going to update.

So, I made the docklet do what the statusbox currently does,
which is to find or create an appropriate saved status, and
set that (and woah, the statusbox now updates correctly ;).
This involved moving a bunch of code around. I've tested it
with several protocol combinations, single protocol,
changing the status from <wherever>, it _appears_ to work
okay :)

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1575202&group_id=235

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1621854 ] brings soc-2006-msnp13 up to head

2007-04-14T14:16:14Z

Patches item #1621854, was opened at 2006-12-24 22:36
Message generated for change (Comment added) made by rlaager
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Later
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Sean Egan (seanegan)
Summary: brings soc-2006-msnp13 up to head

Initial Comment:
This tarball brings soc-2006-msnp13 up to head. In addition to that it also fixes a crash with sending offline messages.

I wasn't able to generate a diff against that branch, svn seems to insist on diff'ing against HEAD after I run the merge command. After running `svn merge -r 16309:HEAD https://gaim.svn.sourceforge.net/svnroot/gaim/trunk` on the soc-2006-msnp13 you can replace the msn directory with the attached tarball. The fix for offline messaging is on msn.c:901:

if (!session->oim)
session->oim = msn_oim_new(session)

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-04-14 15:16

Message:
Logged In: YES
user_id=156487
Originator: NO

Moved to: http://developer.pidgin.im/ticket/148

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-04-09 19:09

Message:
Logged In: YES
user_id=159910
Originator: YES

I remember he said that he had planned to merge it in once 2.0.0 is out
the door. 2 students also said they were going to file SoC applications on
this, so that may or may not change his plan depending if those
applications are accepted.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-04-09 18:02

Message:
Logged In: YES
user_id=156487
Originator: NO

I'm commenting here for the record. khc: Have you talked to Sean yet about
any MSNP?? branch he may have? I'd love to see this in a Monotone branch
now that we're public with that.

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 03:37

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 03:36

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-04-01 16:03

Message:
Logged In: YES
user_id=1525231
Originator: NO

Couple patches again:
http://koti.mbnet.fi/simom/gaim-msnp13/markup_escape_psm.diff
PSM needs to be escaped, tooltip rendering fails if PSM had '&' in it.

http://koti.mbnet.fi/simom/gaim-msnp13/currentmedia.diff
Support for showing current media of buddies in buddy list. Tooltip shows
both PSM and current media if they are both set, but status line shows only
current media if it is set (official client behaviour). Note: This patch
already includes escaping of PSM, you don't need markup_escape_psm.diff if
you use this.
I know there are bigger problems at the moment than lack of current media
support, but here it is anyway :)

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-16 04:18

Message:
Logged In: YES
user_id=1525231
Originator: NO

Two little patches, first one prevents own account to be added as a buddy
to buddylist, and second fixes tooltip messing with status and PSM.

http://koti.mbnet.fi/simom/gaim-msnp13/own-account-as-buddy.diff
http://koti.mbnet.fi/simom/gaim-msnp13/psm-in-tooltip.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 01:35

Message:
Logged In: YES
user_id=159910
Originator: YES

A little late, but here is a version that should remember your friendly
name. Also has a fix for a crasher when MSN sends you back:

<faultstring>Need to do full sync. Can't sync deltas Client
has too old a copy for us to do a delta sync</faultstring>

In this case, I make gaim re-request the full contact list/address book.

I haven't look too deeply into the reverse list problem, but I think the
solution would involve caching the reverse list, which may require
extending the privacy api.
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-15 22:30

Message:
Logged In: YES
user_id=159910
Originator: YES

Updated the diff with basically no change, except with simom's icon fix.
The previous diff was broken because some of the files were not added

Had to compress it because of sourceforge file size limit
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-10 14:39

Message:
Logged In: YES
user_id=159910
Originator: YES

uploaded a diff, this diff is unchanged from the last tarball that I
previously uploaded, except that it's against HEAD. This should be a little
easier for most people.

File Added: msn-p13-merge-head.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-07 01:54

Message:
Logged In: YES
user_id=159910
Originator: YES

Another way is to make a SOAP request whenever the friendly name is set,
and set the friendly name every time you sign on, which doesn't fix the
reverse list problem, but does allow the friendly name to persist. I
already have the first part written.

I apologize if my lack of activity wasted you too much time.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-06 05:22

Message:
Logged In: YES
user_id=1525231
Originator: NO

One way too is to ask full contact list and address book every time
(*Changes=NULL in certain function calls), I tried this too, it works but
logging in takes some more time. It actually fixes reverse list -problem
too, but maybe local caching would still be a better solution as it is
planned to work that way and it reduces bandwidth-usage.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-03-06 01:09

Message:
Logged In: YES
user_id=20979
Originator: NO

Ooh, that's so rockin'

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-06 01:02

Message:
Logged In: YES
user_id=159910
Originator: YES

I found a way to make the server resend the friendly name every time you
sign on, but I haven't had the time and motivation to finish that.
Hopefully I will find the time to look at your diff this weekend.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-05 10:43

Message:
Logged In: YES
user_id=1525231
Originator: NO

I fixed the icons by adding "b->proto_data = user;" to msn_userlist_load()
in userlist.c (see end of the patch), and Friendly name -issue by caching
it to buddylist and using that if it isn't sent by server. This seems to be
necessary as server sends only changes in information since last time.
Maybe same should be done to reverse list, as now for every buddy in my
list i get 'has you: no' in the tooltip. I also prevented own account to be
added to buddy list. Patch against msn.tgz v2 (the one dated 2006-12-30
09:17) can be found in
http://koti.mbnet.fi/simom/gaim-msnp13/msnp13-friendly-name-and-icons.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 12:54

Message:
Logged In: YES
user_id=159910
Originator: YES

I am heading out, but g_return_if_fail(cmd->param_count >= 3) means if the
condition cmd->param_count >= 3 fails, the function would return right
there. So that part is working as expected. I have no idea why sometimes I
get the friendly name and sometimes I don't.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 05:11

Message:
Logged In: YES
user_id=1678429
Originator: NO

The first two connection I receive after last USR TWN command
USR <tid> OK <email> 1 0
USR <tid2> <email> <a number of three blocks
nnnnnnnnnn.nnnnnnnn.nnnnnnnn>
USR <tid2> OK <email> <displayname>

The third time the last USR OK command is:
USR <tid2> OK <email> <email>

I changed nothing in account's setting, I only connected and disconnected
for three time. VERY strange.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 05:02

Message:
Logged In: YES
user_id=1678429
Originator: NO

Uhm... I'm trying your updated version... with a new profile.... The first
connection, it's all ok... it loads for my contact the right friendly name
from server I think because the local alias is different. I disconnected,
then reconnected, it's ok also this time; again I disconnect and then
reconnect, but at this third time... it doesn't load the friendly name, and
all my msn buddies have the same msn icon
http://xs210.xs.to/xs210/06525/screenshot1.png. :|

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 04:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

And also I see now in prp_cmd method of notification.c your mod...
###############
static void
prp_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
MsnSession *session = cmdproc->session;
const char *type, *value;

g_return_if_fail(cmd->param_count >= 3);

type = cmd->params[2];

if (cmd->param_count == 4)
{
value = cmd->params[3];
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, gaim_url_decode(value));
}
else
{
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, NULL);
else if (!strcmp(type, "MFM")) {
type = cmd->params[1];
gaim_connection_set_display_name(
gaim_account_get_connection(session->account),
gaim_url_decode(cmd->params[2]));
}
}
}
###############################
as third instruction of the void there is
g_return_if_fail(cmd->param_count >= 3);, from whati I understand of this
void, it stop the void procedure if cmd->param_count >= 3.... but after I
see if (cmd->param_count == 4) .... so if it's right the interpretation of
g_return_if_fail the condition that follow never happen! And I also thought
that was incoerent... and so I changed the integer of values.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 04:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

I added the if (!strcmp(type, "MFN")) { in sync.c and notification.c
because it figured out in that files the void prp_cmd... and I thought that
was necessary add the parsing of that instruction... that set the nickname.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 01:17

Message:
Logged In: YES
user_id=159910
Originator: YES

new version, fixes some crashes because group_id is char * but in some
places it's set to an int (!). skadotnet, I don't understand why you need
`if (!strcmp(type, "MFN")) {` in so many places, so I didn't include most
of them. I also have different versions of some of your fixes because I
already fixed them.

Group manipulations may still not work, at least it's not crashing :-)

File Added: msn.tgz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 01:03

Message:
Logged In: YES
user_id=159910
Originator: YES

are you sure that setting the friendly name in msn_notification_post_adl()
is correct?

something is weird, sometimes I get back my own contact information in
contact.c:msn_parse_addressbook(), so I can set the display name there, and
sometimes I don't. It may have something to do with contact list caching.

I will upload a new version soon that fixes lots of compiler warning and
some crashes for group manipulations.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-29 20:38

Message:
Logged In: YES
user_id=159910
Originator: YES

I finally figured out why I couldn't sign on, I was missing a */ so a
large block of code was commented out!

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 09:35

Message:
Logged In: YES
user_id=1678429
Originator: NO

I link directly the patch file....
http://skadotnet.altervista.org/msn.patch

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 09:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

This is the patch file for the first 2 fix, it's not complete because it
need the implementation of the field where save the friendly name, now it
use local alias as first display name. It persists the problem of buddy
icon, I'm sorry but more than this I can't do.
Here the patch:
############################################################################################################################################
diff -uN msn.original/msn.c msn/msn.c
--- msn.original/msn.c 2006-12-25 03:29:57.000000000 +0100
+++ msn/msn.c 2006-12-29 16:11:15.000000000 +0100
@@ -137,9 +137,10 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ if (strlen(alias) > 0)
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
+ else
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s",
gaim_url_encode(gaim_account_get_username(account)));
}

static void
@@ -798,6 +799,9 @@

if (!msn_session_connect(session, host, port, http_method))
gaim_connection_error(gc, _("Failed to connect to server."));
+
+ // Transitional pointment to local alias. Should be the friendly name
saved at every change.
+ gaim_connection_set_display_name(gc, gaim_account_get_alias(account));
}

static void
diff -uN msn.original/notification.c msn/notification.c
--- msn.original/notification.c 2006-12-25 00:52:23.000000000 +0100
+++ msn/notification.c 2006-12-29 16:11:15.000000000 +0100
@@ -235,8 +235,9 @@
/* authenticate OK */
const char *friendly = gaim_url_decode(cmd->params[3]);

- gaim_connection_set_display_name(gc, friendly);
-
+ if (g_ascii_strcasecmp(friendly, "1"))
+ gaim_connection_set_display_name(gc, friendly);
+
msn_session_set_login_step(session, MSN_LOGIN_STEP_SYN);

// msn_cmdproc_send(cmdproc, "SYN", "%s", "0");
@@ -626,6 +627,29 @@
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;
+
+ GaimAccount *account;
+ account = cmdproc->session->account;
+
+ /*
+ * TODO: save somewhere the friendly name in accounts file, when a new
account is created,
+ * or it's set empty or equal to local alias. When a command PRP
MFN is sent through
+ * prp_cmd method in notification.c and sync.c the field in xml
config file is updated.
+ * This is loaded after login with
gaim_connection_set_display_name(GaimConnection *gc, const char *value)
[msn.c:803-804]
+ * so if we connect throught MSNP8 on USR OK command we overwrite
that field,
+ * if the length isn't equal to "1", else if we connect throught
MSNP11 or higher, on USR OK command
+ * we don't overwrite that field because the params is equals to
"1", and throught the command down here
+ * we set for the first time the saved friendly nickname.
+ */
+ const char *friendly;
+ friendly =
gaim_url_encode(gaim_connection_get_display_name(account->gc));
+
+ if (strlen(friendly) <= 0)
+ friendly = gaim_url_encode(gaim_account_get_username(account));
+
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", friendly);
+
+ gaim_debug_info("Ska","Set friendly name as
%s\n",gaim_url_decode(friendly));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
@@ -1025,12 +1049,16 @@

g_return_if_fail(cmd->param_count >= 3);

- type = cmd->params[2];
+ type = cmd->params[1];

- if (cmd->param_count == 4)
+ if (cmd->param_count == 3)
{
- value = cmd->params[3];
- if (!strcmp(type, "PHH"))
+ value = cmd->params[2];
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -1039,7 +1067,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
diff -uN msn.original/sync.c msn/sync.c
--- msn.original/sync.c 2006-12-25 00:17:41.000000000 +0100
+++ msn/sync.c 2006-12-29 16:11:15.000000000 +0100
@@ -64,7 +64,11 @@

if (cmd->param_count == 2)
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -73,7 +77,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
############################################################################################################################################

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 08:05

Message:
Logged In: YES
user_id=1678429
Originator: NO

I'm modifying the fix for second issue, that also set the display name's
field when you open the dialog for set alias manually

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 05:15

Message:
Logged In: YES
user_id=1678429
Originator: NO

There is also another bug.... all my msn buddies have the same msn icon:
this http://xs210.xs.to/xs210/06525/screenshot1.png

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 05:09

Message:
Logged In: YES
user_id=1678429
Originator: NO

I don't see any other way to solve this... when login server send the
command USR Ok, now there isn't the display name that should be stored on
the server....
I've found, I think, the right location to add this command. File
notification.c at line 625.

From:
#####################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
######################################

To:
######################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

GaimAccount *account;
account = cmdproc->session->account;

msn_cmdproc_send(cmdproc,"PRP","MFN %s",
gaim_url_encode(gaim_account_get_alias(account)));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
################################################

with this fix, now the friendly name is set at startup as the local alias
field's value.
For the old MSNP8 is still enabled the parsing of USR OK answer to look
for the display name... but connecting with MSNP13/14 it finds only the
value "1", because server answer with "USR <transid> OK <email-address> 1
0\r\n". The old parser get the fourth parameter... that now is "1", and set
it as friendly name... but then arrives another USR OK answer that
containst at fourth parameter again the email address, and again it set the
friendly name with the email address.
Using this fix, before the second USR OK answer it set the friendly name
so the second USR OK answer arrives as the old format "USR <transid> OK
<email-address> <friendly-name> 0\r\n".

There are other things to do, because, now it set the local alias, and
when you want manually change the friendly name through the dialog, the
value of textbox is "1", I don't know why.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 17:02

Message:
Logged In: YES
user_id=159910
Originator: YES

ya, I thought about that, but then with MSNP8 you can use your friendly
name that you set from elsewhere, with this it means you can't

anyway, I still need to fix the logon issue before I can do any meaningful
work again.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 16:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

For the second "bug", from what I could see from the code, and from
msnpiki, it's a change of commands of the protocol. Before the friendly
name ad login was recieved form USR command, but now as says
http://msnpiki.msnfanatic.com/index.php/MSNP13:Example_Session#Updating_Display_Name
after ADL command we need to send a fisrt PRP command to set the friendly
name, so we need to save somewhere the nickname.
A solution could be use the config file to save this parameter, when the
account is created this field is sat as alias field; then ad after sending
ADL command to get the contact list, send the first PRP MFN, to set first
the nickname with param the value of friendlyname field; and also add a
command to save the friendly nickname's value in the setting file, when is
modified manually throught the dialog.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 13:21

Message:
Logged In: YES
user_id=159910
Originator: YES

actually I _thought_ I fixed the 2nd issue, turns out now I can't log in
anymore :-/ reverting to old gaim code works though, will figure it out
later tonight.

feel free to take a shot

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 12:46

Message:
Logged In: YES
user_id=159910
Originator: YES

I actually have those 2 fixed already, nice job though.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 11:34

Message:
Logged In: YES
user_id=1678429
Originator: NO

I've tried the patch winth gaim svn... it works but there are some
problems with the friendly nickname... when I try to set the nickname, it
disconnect from msn. I've corrected this problem using the new msn command
to set nickname, instead of the obsolate one.

###################################################################
--- msn.c.original 2006-12-28 18:30:12.000000000 +0100
+++ msn.c 2006-12-28 18:30:34.000000000 +0100
@@ -137,9 +137,7 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
}

static void
#########################################################################

Now I'm going to solve the missed nickname's update on connect.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1668681 ] Close bug #1121620 and fix some Bi-Directional text issues

2007-04-14T12:57:01Z

Patches item #1668681, was opened at 2007-02-25 20:23
Message generated for change (Comment added) made by rlaager
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668681&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Shlomi Loubaton (shlomil)
Assigned to: Ethan Blanton (eblanton)
Summary: Close bug #1121620 and fix some Bi-Directional text issues

Initial Comment:
In this patch I implemented the following:

* Added a support for tag in the parser of the IMHtml Widget. (AFAIK this HTML tag is deprecated, but most browsers implement it and it beats coding CSS support)

* Added text direction detection to outgoing messages and send it with the correct SPAN tag.

* Added support for the "FN=1" flag in Messanger protocol implementation, both in sending and receiving messages (bug #1121620).

* Fixed some display issues: Insert RLM and RLE unicode characters to the conversation display according to the expected alignment and direction.

For more information about this patch and screenshots:
http://shlomil.blogspot.com/2007/02/patch-to-fix-some-bidi-text-issues-in.html

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-04-14 13:57

Message:
Logged In: YES
user_id=156487
Originator: NO

This was moved to Trac and has been committed.

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-04-05 17:49

Message:
Logged In: YES
user_id=953881
Originator: YES

4th version of the patch:
The problem mentioned in my previous comment with ICQ plug-in was fixed.
The function gaim_unescape_html() was used (oscar.c:4288) to strip HTML
tags before sending ch2 messages.
Doing that, of course, did not work so I changed it to use
gaim_markup_strip_html() .

File Added: shlomi-bidi4.patch

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-24 11:41

Message:
Logged In: YES
user_id=953881
Originator: YES

I investigated implementing the same fix for ICQ protocol only to realized
that it's impossible at least until the ability to send "channel 2"
messages is implemented in Gaim (AKA the 4 years old feature request
#787993). I guess that it's a heavy task since it requires implementing
basic RTF parsing abilities. After we have such ability - it's only a
matter of sending the message with this RTF prefix: '\pard\rtlpar\qr'.

Unfortunately, I also found a problem with the patch - sending a RTL
message to ICQ user will send embedded SPAN tags in the message. Seems like
ICQ's implementation rely on the fact that the message formatting buttons
are disabled when editing a message for ICQ and it doesn't strip the HTML
before sending. This is a minor fix - I'll fix it soon and upload a 4th
version for the patch.

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-06 17:59

Message:
Logged In: YES
user_id=953881
Originator: YES

* Timestamps and Aliases are now encapsulated in their own LRE/RLE Unicode
characters.
* screenshot of fixed timestamps in Gaim:
http://bp2.blogger.com/_40WxAMsyuJQ/Re36uN_jodI/AAAAAAAAAA8/UX592uVRwGk/s400/timestamps.png

Code just got a little more complicated but works great.
Maybe I should try to optimize it somehow. Suggestions/requests are
welcomed.
File Added: shlomi-bidi3.patch

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-01 21:38

Message:
Logged In: YES
user_id=953881
Originator: YES

Ok, thank you both. Note taken.
I'll see what I can do about the timestamps.

Shlomil.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-03-01 20:40

Message:
Logged In: YES
user_id=156487
Originator: NO

I agree with Sean. As you can see in your second screenshot, the
timestamps don't line up. They should be on the right, with the name after
them (on the left, since we're talking about RTL).

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-01 19:45

Message:
Logged In: YES
user_id=953881
Originator: YES

Changes in shlomi-bidi2.patch:
* The two spans were unified to a single span tag (as Etan suggested).
* Now text properties are set by inline CSS attributes (<span
style="...">) (also as Etan suggested).
* Need for inline CSS parsing in MSN plug-in made this patch a little more
complicated than the first one.
* gtk_imhtml_get_css_opt() - Function was able to recognized only the
first attribute - now fixed. (But this function is a mess and should be
rewritten IMO)

Tested again talking to MSN Messenger and Gaim and it still works as
expected.

Shlomil.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2007-03-01 19:44

Message:
Logged In: YES
user_id=199625
Originator: NO

I don't speak an rtl language, but it seems like, in the second
screenshot, you'd want the timestamp to be right-aligned, followed by the
screenname, then the message. Like we do it in LTR.

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-01 19:27

Message:
Logged In: YES
user_id=953881
Originator: YES

File Added: shlomi-bidi2.patch

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-02-28 02:39

Message:
Logged In: YES
user_id=953881
Originator: YES

After a chat with Etan on IRC, I was suggested to unify the two span tags
into one tag and add the alignment and direction attributes (deprecated
HTML) as CSS properties.
I'll do that and then resubmit my patch.

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2007-02-27 16:40

Message:
Logged In: YES
user_id=28833
Originator: NO

Ethan, do you have time to look at this?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668681&group_id=235

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1693706 ] Fix missing buddy icons and custom emoticons on MSN

2007-04-12T09:29:11Z

Patches item #1693706, was opened at 2007-04-03 11:22
Message generated for change (Comment added) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1693706&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Simo Mattila (simom)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix missing buddy icons and custom emoticons on MSN

Initial Comment:
Newer Live Messenger -versions doesn't always send SHA1C-field in msnobj's and so Gaim discards them. This patch accepts them even if SHA1C is missing, and use SHA1D as icon checksum instead of SHA1C.
Fixes bug #1675659.

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2007-04-12 11:29

Message:
Logged In: YES
user_id=20979
Originator: NO

Thank you

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-04-12 11:12

Message:
Logged In: YES
user_id=1525231
Originator: YES

Continued in http://developer.pidgin.im/ticket/113

----------------------------------------------------------------------

Comment By: Daniel Atallah (datallah)
Date: 2007-04-08 21:21

Message:
Logged In: YES
user_id=325843
Originator: NO

This will cause all the existing icon checksums to be incorrect.

I think this should be redone using SHA1D as a fallback instead of the
default.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1693706&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1693706 ] Fix missing buddy icons and custom emoticons on MSN

2007-04-12T09:12:32Z

Patches item #1693706, was opened at 2007-04-03 18:22
Message generated for change (Comment added) made by simom
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1693706&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Simo Mattila (simom)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix missing buddy icons and custom emoticons on MSN

Initial Comment:
Newer Live Messenger -versions doesn't always send SHA1C-field in msnobj's and so Gaim discards them. This patch accepts them even if SHA1C is missing, and use SHA1D as icon checksum instead of SHA1C.
Fixes bug #1675659.

----------------------------------------------------------------------

>Comment By: Simo Mattila (simom)
Date: 2007-04-12 18:12

Message:
Logged In: YES
user_id=1525231
Originator: YES

Continued in http://developer.pidgin.im/ticket/113

----------------------------------------------------------------------

Comment By: Daniel Atallah (datallah)
Date: 2007-04-09 04:21

Message:
Logged In: YES
user_id=325843
Originator: NO

This will cause all the existing icon checksums to be incorrect.

I think this should be redone using SHA1D as a fallback instead of the
default.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1693706&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1698779 ] Upgrade not available

2007-04-11T16:31:58Z

Patches item #1698779, was opened at 2007-04-11 17:01
Message generated for change (Comment added) made by ascheinberg
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: newfeature
Group: None
Status: Deleted
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Scheinberg (ascheinberg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Upgrade not available

Initial Comment:
Hello, I am using Gaim 2.0.0 beta 6, which appears to be the most current version. Gaim is telling me to upgrade to 2.0.0 final, and directing me to this site:

http://www.pidgin.im/version.php?version=2.0.0beta6&build=gaim-win32

There is nothing here. Is something going on here?

----------------------------------------------------------------------

>Comment By: Adam Scheinberg (ascheinberg)
Date: 2007-04-11 18:31

Message:
Logged In: YES
user_id=1355657
Originator: YES

No caching proxy, and no, I did not receive it today. Just yesterday.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-04-11 17:33

Message:
Logged In: YES
user_id=20979
Originator: NO

Also, do you access the internet though some kind of caching proxy server?

----------------------------------------------------------------------

Comment By: Stu Tomlinson (nosnilmot)
Date: 2007-04-11 17:19

Message:
Logged In: YES
user_id=309779
Originator: NO

When did you last get this misleading message from the release
notification plugin? I fixed the problem yesterday.

----------------------------------------------------------------------

Comment By: Adam Scheinberg (ascheinberg)
Date: 2007-04-11 17:09

Message:
Logged In: YES
user_id=1355657
Originator: YES

Laziness? Your Trac site doesn't appear to allow me to post "bugs." Your
sourceforge site no longer has a link for bugs. Your Trac site docs have
not been updated AT ALL, and still point to default Trac configuration
documents.

You may have "taken pity" on me for posting here, but it's certainly not
for lack of trying!!

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2007-04-11 17:06

Message:
Logged In: YES
user_id=28833
Originator: NO

This is not a patch.

However, this once I'll take pity on your lazyness. Our changes to the
website have broken the very fragile release notification plugin.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1698779 ] Upgrade not available

2007-04-11T15:33:18Z

Patches item #1698779, was opened at 2007-04-11 17:01
Message generated for change (Comment added) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: newfeature
Group: None
Status: Deleted
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Scheinberg (ascheinberg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Upgrade not available

Initial Comment:
Hello, I am using Gaim 2.0.0 beta 6, which appears to be the most current version. Gaim is telling me to upgrade to 2.0.0 final, and directing me to this site:

http://www.pidgin.im/version.php?version=2.0.0beta6&build=gaim-win32

There is nothing here. Is something going on here?

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2007-04-11 17:33

Message:
Logged In: YES
user_id=20979
Originator: NO

Also, do you access the internet though some kind of caching proxy server?

----------------------------------------------------------------------

Comment By: Stu Tomlinson (nosnilmot)
Date: 2007-04-11 17:19

Message:
Logged In: YES
user_id=309779
Originator: NO

When did you last get this misleading message from the release
notification plugin? I fixed the problem yesterday.

----------------------------------------------------------------------

Comment By: Adam Scheinberg (ascheinberg)
Date: 2007-04-11 17:09

Message:
Logged In: YES
user_id=1355657
Originator: YES

Laziness? Your Trac site doesn't appear to allow me to post "bugs." Your
sourceforge site no longer has a link for bugs. Your Trac site docs have
not been updated AT ALL, and still point to default Trac configuration
documents.

You may have "taken pity" on me for posting here, but it's certainly not
for lack of trying!!

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2007-04-11 17:06

Message:
Logged In: YES
user_id=28833
Originator: NO

This is not a patch.

However, this once I'll take pity on your lazyness. Our changes to the
website have broken the very fragile release notification plugin.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1698779 ] Upgrade not available

2007-04-11T15:19:37Z

Patches item #1698779, was opened at 2007-04-11 16:01
Message generated for change (Comment added) made by nosnilmot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: newfeature
Group: None
Status: Deleted
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Scheinberg (ascheinberg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Upgrade not available

Initial Comment:
Hello, I am using Gaim 2.0.0 beta 6, which appears to be the most current version. Gaim is telling me to upgrade to 2.0.0 final, and directing me to this site:

http://www.pidgin.im/version.php?version=2.0.0beta6&build=gaim-win32

There is nothing here. Is something going on here?

----------------------------------------------------------------------

>Comment By: Stu Tomlinson (nosnilmot)
Date: 2007-04-11 16:19

Message:
Logged In: YES
user_id=309779
Originator: NO

When did you last get this misleading message from the release
notification plugin? I fixed the problem yesterday.

----------------------------------------------------------------------

Comment By: Adam Scheinberg (ascheinberg)
Date: 2007-04-11 16:09

Message:
Logged In: YES
user_id=1355657
Originator: YES

Laziness? Your Trac site doesn't appear to allow me to post "bugs." Your
sourceforge site no longer has a link for bugs. Your Trac site docs have
not been updated AT ALL, and still point to default Trac configuration
documents.

You may have "taken pity" on me for posting here, but it's certainly not
for lack of trying!!

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2007-04-11 16:06

Message:
Logged In: YES
user_id=28833
Originator: NO

This is not a patch.

However, this once I'll take pity on your lazyness. Our changes to the
website have broken the very fragile release notification plugin.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1698779 ] Upgrade not available

2007-04-11T15:09:54Z

Patches item #1698779, was opened at 2007-04-11 17:01
Message generated for change (Comment added) made by ascheinberg
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: newfeature
Group: None
Status: Deleted
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Scheinberg (ascheinberg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Upgrade not available

Initial Comment:
Hello, I am using Gaim 2.0.0 beta 6, which appears to be the most current version. Gaim is telling me to upgrade to 2.0.0 final, and directing me to this site:

http://www.pidgin.im/version.php?version=2.0.0beta6&build=gaim-win32

There is nothing here. Is something going on here?

----------------------------------------------------------------------

>Comment By: Adam Scheinberg (ascheinberg)
Date: 2007-04-11 17:09

Message:
Logged In: YES
user_id=1355657
Originator: YES

Laziness? Your Trac site doesn't appear to allow me to post "bugs." Your
sourceforge site no longer has a link for bugs. Your Trac site docs have
not been updated AT ALL, and still point to default Trac configuration
documents.

You may have "taken pity" on me for posting here, but it's certainly not
for lack of trying!!

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2007-04-11 17:06

Message:
Logged In: YES
user_id=28833
Originator: NO

This is not a patch.

However, this once I'll take pity on your lazyness. Our changes to the
website have broken the very fragile release notification plugin.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1698779 ] Upgrade not available

2007-04-11T15:06:44Z

Patches item #1698779, was opened at 2007-04-11 17:01
Message generated for change (Comment added) made by lschiere
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: newfeature
Group: None
>Status: Deleted
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Scheinberg (ascheinberg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Upgrade not available

Initial Comment:
Hello, I am using Gaim 2.0.0 beta 6, which appears to be the most current version. Gaim is telling me to upgrade to 2.0.0 final, and directing me to this site:

http://www.pidgin.im/version.php?version=2.0.0beta6&build=gaim-win32

There is nothing here. Is something going on here?

----------------------------------------------------------------------

>Comment By: Luke Schierer (lschiere)
Date: 2007-04-11 17:06

Message:
Logged In: YES
user_id=28833
Originator: NO

This is not a patch.

However, this once I'll take pity on your lazyness. Our changes to the
website have broken the very fragile release notification plugin.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1698779 ] Upgrade not available

2007-04-11T15:01:10Z

Patches item #1698779, was opened at 2007-04-11 17:01
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: newfeature
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Scheinberg (ascheinberg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Upgrade not available

Initial Comment:
Hello, I am using Gaim 2.0.0 beta 6, which appears to be the most current version. Gaim is telling me to upgrade to 2.0.0 final, and directing me to this site:

http://www.pidgin.im/version.php?version=2.0.0beta6&build=gaim-win32

There is nothing here. Is something going on here?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1698779&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1621854 ] brings soc-2006-msnp13 up to head

2007-04-09T18:09:39Z

Patches item #1621854, was opened at 2006-12-25 04:36
Message generated for change (Comment added) made by bsponline
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Sean Egan (seanegan)
Summary: brings soc-2006-msnp13 up to head

Initial Comment:
This tarball brings soc-2006-msnp13 up to head. In addition to that it also fixes a crash with sending offline messages.

I wasn't able to generate a diff against that branch, svn seems to insist on diff'ing against HEAD after I run the merge command. After running `svn merge -r 16309:HEAD https://gaim.svn.sourceforge.net/svnroot/gaim/trunk` on the soc-2006-msnp13 you can replace the msn directory with the attached tarball. The fix for offline messaging is on msn.c:901:

if (!session->oim)
session->oim = msn_oim_new(session)

----------------------------------------------------------------------

>Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-04-10 01:09

Message:
Logged In: YES
user_id=159910
Originator: YES

I remember he said that he had planned to merge it in once 2.0.0 is out
the door. 2 students also said they were going to file SoC applications on
this, so that may or may not change his plan depending if those
applications are accepted.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-04-10 00:02

Message:
Logged In: YES
user_id=156487
Originator: NO

I'm commenting here for the record. khc: Have you talked to Sean yet about
any MSNP?? branch he may have? I'd love to see this in a Monotone branch
now that we're public with that.

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 09:37

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 09:36

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-04-01 22:03

Message:
Logged In: YES
user_id=1525231
Originator: NO

Couple patches again:
http://koti.mbnet.fi/simom/gaim-msnp13/markup_escape_psm.diff
PSM needs to be escaped, tooltip rendering fails if PSM had '&' in it.

http://koti.mbnet.fi/simom/gaim-msnp13/currentmedia.diff
Support for showing current media of buddies in buddy list. Tooltip shows
both PSM and current media if they are both set, but status line shows only
current media if it is set (official client behaviour). Note: This patch
already includes escaping of PSM, you don't need markup_escape_psm.diff if
you use this.
I know there are bigger problems at the moment than lack of current media
support, but here it is anyway :)

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-16 09:18

Message:
Logged In: YES
user_id=1525231
Originator: NO

Two little patches, first one prevents own account to be added as a buddy
to buddylist, and second fixes tooltip messing with status and PSM.

http://koti.mbnet.fi/simom/gaim-msnp13/own-account-as-buddy.diff
http://koti.mbnet.fi/simom/gaim-msnp13/psm-in-tooltip.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 06:35

Message:
Logged In: YES
user_id=159910
Originator: YES

A little late, but here is a version that should remember your friendly
name. Also has a fix for a crasher when MSN sends you back:

<faultstring>Need to do full sync. Can't sync deltas Client
has too old a copy for us to do a delta sync</faultstring>

In this case, I make gaim re-request the full contact list/address book.

I haven't look too deeply into the reverse list problem, but I think the
solution would involve caching the reverse list, which may require
extending the privacy api.
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 03:30

Message:
Logged In: YES
user_id=159910
Originator: YES

Updated the diff with basically no change, except with simom's icon fix.
The previous diff was broken because some of the files were not added

Had to compress it because of sourceforge file size limit
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-10 20:39

Message:
Logged In: YES
user_id=159910
Originator: YES

uploaded a diff, this diff is unchanged from the last tarball that I
previously uploaded, except that it's against HEAD. This should be a little
easier for most people.

File Added: msn-p13-merge-head.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-07 07:54

Message:
Logged In: YES
user_id=159910
Originator: YES

Another way is to make a SOAP request whenever the friendly name is set,
and set the friendly name every time you sign on, which doesn't fix the
reverse list problem, but does allow the friendly name to persist. I
already have the first part written.

I apologize if my lack of activity wasted you too much time.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-06 11:22

Message:
Logged In: YES
user_id=1525231
Originator: NO

One way too is to ask full contact list and address book every time
(*Changes=NULL in certain function calls), I tried this too, it works but
logging in takes some more time. It actually fixes reverse list -problem
too, but maybe local caching would still be a better solution as it is
planned to work that way and it reduces bandwidth-usage.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-03-06 07:09

Message:
Logged In: YES
user_id=20979
Originator: NO

Ooh, that's so rockin'

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-06 07:02

Message:
Logged In: YES
user_id=159910
Originator: YES

I found a way to make the server resend the friendly name every time you
sign on, but I haven't had the time and motivation to finish that.
Hopefully I will find the time to look at your diff this weekend.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-05 16:43

Message:
Logged In: YES
user_id=1525231
Originator: NO

I fixed the icons by adding "b->proto_data = user;" to msn_userlist_load()
in userlist.c (see end of the patch), and Friendly name -issue by caching
it to buddylist and using that if it isn't sent by server. This seems to be
necessary as server sends only changes in information since last time.
Maybe same should be done to reverse list, as now for every buddy in my
list i get 'has you: no' in the tooltip. I also prevented own account to be
added to buddy list. Patch against msn.tgz v2 (the one dated 2006-12-30
09:17) can be found in
http://koti.mbnet.fi/simom/gaim-msnp13/msnp13-friendly-name-and-icons.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 18:54

Message:
Logged In: YES
user_id=159910
Originator: YES

I am heading out, but g_return_if_fail(cmd->param_count >= 3) means if the
condition cmd->param_count >= 3 fails, the function would return right
there. So that part is working as expected. I have no idea why sometimes I
get the friendly name and sometimes I don't.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 11:11

Message:
Logged In: YES
user_id=1678429
Originator: NO

The first two connection I receive after last USR TWN command
USR <tid> OK <email> 1 0
USR <tid2> <email> <a number of three blocks
nnnnnnnnnn.nnnnnnnn.nnnnnnnn>
USR <tid2> OK <email> <displayname>

The third time the last USR OK command is:
USR <tid2> OK <email> <email>

I changed nothing in account's setting, I only connected and disconnected
for three time. VERY strange.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 11:02

Message:
Logged In: YES
user_id=1678429
Originator: NO

Uhm... I'm trying your updated version... with a new profile.... The first
connection, it's all ok... it loads for my contact the right friendly name
from server I think because the local alias is different. I disconnected,
then reconnected, it's ok also this time; again I disconnect and then
reconnect, but at this third time... it doesn't load the friendly name, and
all my msn buddies have the same msn icon
http://xs210.xs.to/xs210/06525/screenshot1.png. :|

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 10:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

And also I see now in prp_cmd method of notification.c your mod...
###############
static void
prp_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
MsnSession *session = cmdproc->session;
const char *type, *value;

g_return_if_fail(cmd->param_count >= 3);

type = cmd->params[2];

if (cmd->param_count == 4)
{
value = cmd->params[3];
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, gaim_url_decode(value));
}
else
{
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, NULL);
else if (!strcmp(type, "MFM")) {
type = cmd->params[1];
gaim_connection_set_display_name(
gaim_account_get_connection(session->account),
gaim_url_decode(cmd->params[2]));
}
}
}
###############################
as third instruction of the void there is
g_return_if_fail(cmd->param_count >= 3);, from whati I understand of this
void, it stop the void procedure if cmd->param_count >= 3.... but after I
see if (cmd->param_count == 4) .... so if it's right the interpretation of
g_return_if_fail the condition that follow never happen! And I also thought
that was incoerent... and so I changed the integer of values.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 10:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

I added the if (!strcmp(type, "MFN")) { in sync.c and notification.c
because it figured out in that files the void prp_cmd... and I thought that
was necessary add the parsing of that instruction... that set the nickname.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 07:17

Message:
Logged In: YES
user_id=159910
Originator: YES

new version, fixes some crashes because group_id is char * but in some
places it's set to an int (!). skadotnet, I don't understand why you need
`if (!strcmp(type, "MFN")) {` in so many places, so I didn't include most
of them. I also have different versions of some of your fixes because I
already fixed them.

Group manipulations may still not work, at least it's not crashing :-)

File Added: msn.tgz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 07:03

Message:
Logged In: YES
user_id=159910
Originator: YES

are you sure that setting the friendly name in msn_notification_post_adl()
is correct?

something is weird, sometimes I get back my own contact information in
contact.c:msn_parse_addressbook(), so I can set the display name there, and
sometimes I don't. It may have something to do with contact list caching.

I will upload a new version soon that fixes lots of compiler warning and
some crashes for group manipulations.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 02:38

Message:
Logged In: YES
user_id=159910
Originator: YES

I finally figured out why I couldn't sign on, I was missing a */ so a
large block of code was commented out!

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 15:35

Message:
Logged In: YES
user_id=1678429
Originator: NO

I link directly the patch file....
http://skadotnet.altervista.org/msn.patch

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 15:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

This is the patch file for the first 2 fix, it's not complete because it
need the implementation of the field where save the friendly name, now it
use local alias as first display name. It persists the problem of buddy
icon, I'm sorry but more than this I can't do.
Here the patch:
############################################################################################################################################
diff -uN msn.original/msn.c msn/msn.c
--- msn.original/msn.c 2006-12-25 03:29:57.000000000 +0100
+++ msn/msn.c 2006-12-29 16:11:15.000000000 +0100
@@ -137,9 +137,10 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ if (strlen(alias) > 0)
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
+ else
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s",
gaim_url_encode(gaim_account_get_username(account)));
}

static void
@@ -798,6 +799,9 @@

if (!msn_session_connect(session, host, port, http_method))
gaim_connection_error(gc, _("Failed to connect to server."));
+
+ // Transitional pointment to local alias. Should be the friendly name
saved at every change.
+ gaim_connection_set_display_name(gc, gaim_account_get_alias(account));
}

static void
diff -uN msn.original/notification.c msn/notification.c
--- msn.original/notification.c 2006-12-25 00:52:23.000000000 +0100
+++ msn/notification.c 2006-12-29 16:11:15.000000000 +0100
@@ -235,8 +235,9 @@
/* authenticate OK */
const char *friendly = gaim_url_decode(cmd->params[3]);

- gaim_connection_set_display_name(gc, friendly);
-
+ if (g_ascii_strcasecmp(friendly, "1"))
+ gaim_connection_set_display_name(gc, friendly);
+
msn_session_set_login_step(session, MSN_LOGIN_STEP_SYN);

// msn_cmdproc_send(cmdproc, "SYN", "%s", "0");
@@ -626,6 +627,29 @@
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;
+
+ GaimAccount *account;
+ account = cmdproc->session->account;
+
+ /*
+ * TODO: save somewhere the friendly name in accounts file, when a new
account is created,
+ * or it's set empty or equal to local alias. When a command PRP
MFN is sent through
+ * prp_cmd method in notification.c and sync.c the field in xml
config file is updated.
+ * This is loaded after login with
gaim_connection_set_display_name(GaimConnection *gc, const char *value)
[msn.c:803-804]
+ * so if we connect throught MSNP8 on USR OK command we overwrite
that field,
+ * if the length isn't equal to "1", else if we connect throught
MSNP11 or higher, on USR OK command
+ * we don't overwrite that field because the params is equals to
"1", and throught the command down here
+ * we set for the first time the saved friendly nickname.
+ */
+ const char *friendly;
+ friendly =
gaim_url_encode(gaim_connection_get_display_name(account->gc));
+
+ if (strlen(friendly) <= 0)
+ friendly = gaim_url_encode(gaim_account_get_username(account));
+
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", friendly);
+
+ gaim_debug_info("Ska","Set friendly name as
%s\n",gaim_url_decode(friendly));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
@@ -1025,12 +1049,16 @@

g_return_if_fail(cmd->param_count >= 3);

- type = cmd->params[2];
+ type = cmd->params[1];

- if (cmd->param_count == 4)
+ if (cmd->param_count == 3)
{
- value = cmd->params[3];
- if (!strcmp(type, "PHH"))
+ value = cmd->params[2];
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -1039,7 +1067,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
diff -uN msn.original/sync.c msn/sync.c
--- msn.original/sync.c 2006-12-25 00:17:41.000000000 +0100
+++ msn/sync.c 2006-12-29 16:11:15.000000000 +0100
@@ -64,7 +64,11 @@

if (cmd->param_count == 2)
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -73,7 +77,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
############################################################################################################################################

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 14:05

Message:
Logged In: YES
user_id=1678429
Originator: NO

I'm modifying the fix for second issue, that also set the display name's
field when you open the dialog for set alias manually

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 11:15

Message:
Logged In: YES
user_id=1678429
Originator: NO

There is also another bug.... all my msn buddies have the same msn icon:
this http://xs210.xs.to/xs210/06525/screenshot1.png

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 11:09

Message:
Logged In: YES
user_id=1678429
Originator: NO

I don't see any other way to solve this... when login server send the
command USR Ok, now there isn't the display name that should be stored on
the server....
I've found, I think, the right location to add this command. File
notification.c at line 625.

From:
#####################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
######################################

To:
######################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

GaimAccount *account;
account = cmdproc->session->account;

msn_cmdproc_send(cmdproc,"PRP","MFN %s",
gaim_url_encode(gaim_account_get_alias(account)));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
################################################

with this fix, now the friendly name is set at startup as the local alias
field's value.
For the old MSNP8 is still enabled the parsing of USR OK answer to look
for the display name... but connecting with MSNP13/14 it finds only the
value "1", because server answer with "USR <transid> OK <email-address> 1
0\r\n". The old parser get the fourth parameter... that now is "1", and set
it as friendly name... but then arrives another USR OK answer that
containst at fourth parameter again the email address, and again it set the
friendly name with the email address.
Using this fix, before the second USR OK answer it set the friendly name
so the second USR OK answer arrives as the old format "USR <transid> OK
<email-address> <friendly-name> 0\r\n".

There are other things to do, because, now it set the local alias, and
when you want manually change the friendly name through the dialog, the
value of textbox is "1", I don't know why.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 23:02

Message:
Logged In: YES
user_id=159910
Originator: YES

ya, I thought about that, but then with MSNP8 you can use your friendly
name that you set from elsewhere, with this it means you can't

anyway, I still need to fix the logon issue before I can do any meaningful
work again.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 22:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

For the second "bug", from what I could see from the code, and from
msnpiki, it's a change of commands of the protocol. Before the friendly
name ad login was recieved form USR command, but now as says
http://msnpiki.msnfanatic.com/index.php/MSNP13:Example_Session#Updating_Display_Name
after ADL command we need to send a fisrt PRP command to set the friendly
name, so we need to save somewhere the nickname.
A solution could be use the config file to save this parameter, when the
account is created this field is sat as alias field; then ad after sending
ADL command to get the contact list, send the first PRP MFN, to set first
the nickname with param the value of friendlyname field; and also add a
command to save the friendly nickname's value in the setting file, when is
modified manually throught the dialog.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 19:21

Message:
Logged In: YES
user_id=159910
Originator: YES

actually I _thought_ I fixed the 2nd issue, turns out now I can't log in
anymore :-/ reverting to old gaim code works though, will figure it out
later tonight.

feel free to take a shot

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 18:46

Message:
Logged In: YES
user_id=159910
Originator: YES

I actually have those 2 fixed already, nice job though.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 17:34

Message:
Logged In: YES
user_id=1678429
Originator: NO

I've tried the patch winth gaim svn... it works but there are some
problems with the friendly nickname... when I try to set the nickname, it
disconnect from msn. I've corrected this problem using the new msn command
to set nickname, instead of the obsolate one.

###################################################################
--- msn.c.original 2006-12-28 18:30:12.000000000 +0100
+++ msn.c 2006-12-28 18:30:34.000000000 +0100
@@ -137,9 +137,7 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
}

static void
#########################################################################

Now I'm going to solve the missed nickname's update on connect.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1621854 ] brings soc-2006-msnp13 up to head

2007-04-09T17:02:22Z

Patches item #1621854, was opened at 2006-12-24 22:36
Message generated for change (Comment added) made by rlaager
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Sean Egan (seanegan)
Summary: brings soc-2006-msnp13 up to head

Initial Comment:
This tarball brings soc-2006-msnp13 up to head. In addition to that it also fixes a crash with sending offline messages.

I wasn't able to generate a diff against that branch, svn seems to insist on diff'ing against HEAD after I run the merge command. After running `svn merge -r 16309:HEAD https://gaim.svn.sourceforge.net/svnroot/gaim/trunk` on the soc-2006-msnp13 you can replace the msn directory with the attached tarball. The fix for offline messaging is on msn.c:901:

if (!session->oim)
session->oim = msn_oim_new(session)

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-04-09 18:02

Message:
Logged In: YES
user_id=156487
Originator: NO

I'm commenting here for the record. khc: Have you talked to Sean yet about
any MSNP?? branch he may have? I'd love to see this in a Monotone branch
now that we're public with that.

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 03:37

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 03:36

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-04-01 16:03

Message:
Logged In: YES
user_id=1525231
Originator: NO

Couple patches again:
http://koti.mbnet.fi/simom/gaim-msnp13/markup_escape_psm.diff
PSM needs to be escaped, tooltip rendering fails if PSM had '&' in it.

http://koti.mbnet.fi/simom/gaim-msnp13/currentmedia.diff
Support for showing current media of buddies in buddy list. Tooltip shows
both PSM and current media if they are both set, but status line shows only
current media if it is set (official client behaviour). Note: This patch
already includes escaping of PSM, you don't need markup_escape_psm.diff if
you use this.
I know there are bigger problems at the moment than lack of current media
support, but here it is anyway :)

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-16 04:18

Message:
Logged In: YES
user_id=1525231
Originator: NO

Two little patches, first one prevents own account to be added as a buddy
to buddylist, and second fixes tooltip messing with status and PSM.

http://koti.mbnet.fi/simom/gaim-msnp13/own-account-as-buddy.diff
http://koti.mbnet.fi/simom/gaim-msnp13/psm-in-tooltip.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 01:35

Message:
Logged In: YES
user_id=159910
Originator: YES

A little late, but here is a version that should remember your friendly
name. Also has a fix for a crasher when MSN sends you back:

<faultstring>Need to do full sync. Can't sync deltas Client
has too old a copy for us to do a delta sync</faultstring>

In this case, I make gaim re-request the full contact list/address book.

I haven't look too deeply into the reverse list problem, but I think the
solution would involve caching the reverse list, which may require
extending the privacy api.
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-15 22:30

Message:
Logged In: YES
user_id=159910
Originator: YES

Updated the diff with basically no change, except with simom's icon fix.
The previous diff was broken because some of the files were not added

Had to compress it because of sourceforge file size limit
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-10 14:39

Message:
Logged In: YES
user_id=159910
Originator: YES

uploaded a diff, this diff is unchanged from the last tarball that I
previously uploaded, except that it's against HEAD. This should be a little
easier for most people.

File Added: msn-p13-merge-head.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-07 01:54

Message:
Logged In: YES
user_id=159910
Originator: YES

Another way is to make a SOAP request whenever the friendly name is set,
and set the friendly name every time you sign on, which doesn't fix the
reverse list problem, but does allow the friendly name to persist. I
already have the first part written.

I apologize if my lack of activity wasted you too much time.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-06 05:22

Message:
Logged In: YES
user_id=1525231
Originator: NO

One way too is to ask full contact list and address book every time
(*Changes=NULL in certain function calls), I tried this too, it works but
logging in takes some more time. It actually fixes reverse list -problem
too, but maybe local caching would still be a better solution as it is
planned to work that way and it reduces bandwidth-usage.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-03-06 01:09

Message:
Logged In: YES
user_id=20979
Originator: NO

Ooh, that's so rockin'

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-06 01:02

Message:
Logged In: YES
user_id=159910
Originator: YES

I found a way to make the server resend the friendly name every time you
sign on, but I haven't had the time and motivation to finish that.
Hopefully I will find the time to look at your diff this weekend.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-05 10:43

Message:
Logged In: YES
user_id=1525231
Originator: NO

I fixed the icons by adding "b->proto_data = user;" to msn_userlist_load()
in userlist.c (see end of the patch), and Friendly name -issue by caching
it to buddylist and using that if it isn't sent by server. This seems to be
necessary as server sends only changes in information since last time.
Maybe same should be done to reverse list, as now for every buddy in my
list i get 'has you: no' in the tooltip. I also prevented own account to be
added to buddy list. Patch against msn.tgz v2 (the one dated 2006-12-30
09:17) can be found in
http://koti.mbnet.fi/simom/gaim-msnp13/msnp13-friendly-name-and-icons.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 12:54

Message:
Logged In: YES
user_id=159910
Originator: YES

I am heading out, but g_return_if_fail(cmd->param_count >= 3) means if the
condition cmd->param_count >= 3 fails, the function would return right
there. So that part is working as expected. I have no idea why sometimes I
get the friendly name and sometimes I don't.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 05:11

Message:
Logged In: YES
user_id=1678429
Originator: NO

The first two connection I receive after last USR TWN command
USR <tid> OK <email> 1 0
USR <tid2> <email> <a number of three blocks
nnnnnnnnnn.nnnnnnnn.nnnnnnnn>
USR <tid2> OK <email> <displayname>

The third time the last USR OK command is:
USR <tid2> OK <email> <email>

I changed nothing in account's setting, I only connected and disconnected
for three time. VERY strange.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 05:02

Message:
Logged In: YES
user_id=1678429
Originator: NO

Uhm... I'm trying your updated version... with a new profile.... The first
connection, it's all ok... it loads for my contact the right friendly name
from server I think because the local alias is different. I disconnected,
then reconnected, it's ok also this time; again I disconnect and then
reconnect, but at this third time... it doesn't load the friendly name, and
all my msn buddies have the same msn icon
http://xs210.xs.to/xs210/06525/screenshot1.png. :|

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 04:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

And also I see now in prp_cmd method of notification.c your mod...
###############
static void
prp_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
MsnSession *session = cmdproc->session;
const char *type, *value;

g_return_if_fail(cmd->param_count >= 3);

type = cmd->params[2];

if (cmd->param_count == 4)
{
value = cmd->params[3];
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, gaim_url_decode(value));
}
else
{
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, NULL);
else if (!strcmp(type, "MFM")) {
type = cmd->params[1];
gaim_connection_set_display_name(
gaim_account_get_connection(session->account),
gaim_url_decode(cmd->params[2]));
}
}
}
###############################
as third instruction of the void there is
g_return_if_fail(cmd->param_count >= 3);, from whati I understand of this
void, it stop the void procedure if cmd->param_count >= 3.... but after I
see if (cmd->param_count == 4) .... so if it's right the interpretation of
g_return_if_fail the condition that follow never happen! And I also thought
that was incoerent... and so I changed the integer of values.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 04:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

I added the if (!strcmp(type, "MFN")) { in sync.c and notification.c
because it figured out in that files the void prp_cmd... and I thought that
was necessary add the parsing of that instruction... that set the nickname.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 01:17

Message:
Logged In: YES
user_id=159910
Originator: YES

new version, fixes some crashes because group_id is char * but in some
places it's set to an int (!). skadotnet, I don't understand why you need
`if (!strcmp(type, "MFN")) {` in so many places, so I didn't include most
of them. I also have different versions of some of your fixes because I
already fixed them.

Group manipulations may still not work, at least it's not crashing :-)

File Added: msn.tgz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 01:03

Message:
Logged In: YES
user_id=159910
Originator: YES

are you sure that setting the friendly name in msn_notification_post_adl()
is correct?

something is weird, sometimes I get back my own contact information in
contact.c:msn_parse_addressbook(), so I can set the display name there, and
sometimes I don't. It may have something to do with contact list caching.

I will upload a new version soon that fixes lots of compiler warning and
some crashes for group manipulations.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-29 20:38

Message:
Logged In: YES
user_id=159910
Originator: YES

I finally figured out why I couldn't sign on, I was missing a */ so a
large block of code was commented out!

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 09:35

Message:
Logged In: YES
user_id=1678429
Originator: NO

I link directly the patch file....
http://skadotnet.altervista.org/msn.patch

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 09:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

This is the patch file for the first 2 fix, it's not complete because it
need the implementation of the field where save the friendly name, now it
use local alias as first display name. It persists the problem of buddy
icon, I'm sorry but more than this I can't do.
Here the patch:
############################################################################################################################################
diff -uN msn.original/msn.c msn/msn.c
--- msn.original/msn.c 2006-12-25 03:29:57.000000000 +0100
+++ msn/msn.c 2006-12-29 16:11:15.000000000 +0100
@@ -137,9 +137,10 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ if (strlen(alias) > 0)
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
+ else
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s",
gaim_url_encode(gaim_account_get_username(account)));
}

static void
@@ -798,6 +799,9 @@

if (!msn_session_connect(session, host, port, http_method))
gaim_connection_error(gc, _("Failed to connect to server."));
+
+ // Transitional pointment to local alias. Should be the friendly name
saved at every change.
+ gaim_connection_set_display_name(gc, gaim_account_get_alias(account));
}

static void
diff -uN msn.original/notification.c msn/notification.c
--- msn.original/notification.c 2006-12-25 00:52:23.000000000 +0100
+++ msn/notification.c 2006-12-29 16:11:15.000000000 +0100
@@ -235,8 +235,9 @@
/* authenticate OK */
const char *friendly = gaim_url_decode(cmd->params[3]);

- gaim_connection_set_display_name(gc, friendly);
-
+ if (g_ascii_strcasecmp(friendly, "1"))
+ gaim_connection_set_display_name(gc, friendly);
+
msn_session_set_login_step(session, MSN_LOGIN_STEP_SYN);

// msn_cmdproc_send(cmdproc, "SYN", "%s", "0");
@@ -626,6 +627,29 @@
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;
+
+ GaimAccount *account;
+ account = cmdproc->session->account;
+
+ /*
+ * TODO: save somewhere the friendly name in accounts file, when a new
account is created,
+ * or it's set empty or equal to local alias. When a command PRP
MFN is sent through
+ * prp_cmd method in notification.c and sync.c the field in xml
config file is updated.
+ * This is loaded after login with
gaim_connection_set_display_name(GaimConnection *gc, const char *value)
[msn.c:803-804]
+ * so if we connect throught MSNP8 on USR OK command we overwrite
that field,
+ * if the length isn't equal to "1", else if we connect throught
MSNP11 or higher, on USR OK command
+ * we don't overwrite that field because the params is equals to
"1", and throught the command down here
+ * we set for the first time the saved friendly nickname.
+ */
+ const char *friendly;
+ friendly =
gaim_url_encode(gaim_connection_get_display_name(account->gc));
+
+ if (strlen(friendly) <= 0)
+ friendly = gaim_url_encode(gaim_account_get_username(account));
+
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", friendly);
+
+ gaim_debug_info("Ska","Set friendly name as
%s\n",gaim_url_decode(friendly));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
@@ -1025,12 +1049,16 @@

g_return_if_fail(cmd->param_count >= 3);

- type = cmd->params[2];
+ type = cmd->params[1];

- if (cmd->param_count == 4)
+ if (cmd->param_count == 3)
{
- value = cmd->params[3];
- if (!strcmp(type, "PHH"))
+ value = cmd->params[2];
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -1039,7 +1067,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
diff -uN msn.original/sync.c msn/sync.c
--- msn.original/sync.c 2006-12-25 00:17:41.000000000 +0100
+++ msn/sync.c 2006-12-29 16:11:15.000000000 +0100
@@ -64,7 +64,11 @@

if (cmd->param_count == 2)
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -73,7 +77,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
############################################################################################################################################

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 08:05

Message:
Logged In: YES
user_id=1678429
Originator: NO

I'm modifying the fix for second issue, that also set the display name's
field when you open the dialog for set alias manually

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 05:15

Message:
Logged In: YES
user_id=1678429
Originator: NO

There is also another bug.... all my msn buddies have the same msn icon:
this http://xs210.xs.to/xs210/06525/screenshot1.png

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 05:09

Message:
Logged In: YES
user_id=1678429
Originator: NO

I don't see any other way to solve this... when login server send the
command USR Ok, now there isn't the display name that should be stored on
the server....
I've found, I think, the right location to add this command. File
notification.c at line 625.

From:
#####################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
######################################

To:
######################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

GaimAccount *account;
account = cmdproc->session->account;

msn_cmdproc_send(cmdproc,"PRP","MFN %s",
gaim_url_encode(gaim_account_get_alias(account)));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
################################################

with this fix, now the friendly name is set at startup as the local alias
field's value.
For the old MSNP8 is still enabled the parsing of USR OK answer to look
for the display name... but connecting with MSNP13/14 it finds only the
value "1", because server answer with "USR <transid> OK <email-address> 1
0\r\n". The old parser get the fourth parameter... that now is "1", and set
it as friendly name... but then arrives another USR OK answer that
containst at fourth parameter again the email address, and again it set the
friendly name with the email address.
Using this fix, before the second USR OK answer it set the friendly name
so the second USR OK answer arrives as the old format "USR <transid> OK
<email-address> <friendly-name> 0\r\n".

There are other things to do, because, now it set the local alias, and
when you want manually change the friendly name through the dialog, the
value of textbox is "1", I don't know why.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 17:02

Message:
Logged In: YES
user_id=159910
Originator: YES

ya, I thought about that, but then with MSNP8 you can use your friendly
name that you set from elsewhere, with this it means you can't

anyway, I still need to fix the logon issue before I can do any meaningful
work again.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 16:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

For the second "bug", from what I could see from the code, and from
msnpiki, it's a change of commands of the protocol. Before the friendly
name ad login was recieved form USR command, but now as says
http://msnpiki.msnfanatic.com/index.php/MSNP13:Example_Session#Updating_Display_Name
after ADL command we need to send a fisrt PRP command to set the friendly
name, so we need to save somewhere the nickname.
A solution could be use the config file to save this parameter, when the
account is created this field is sat as alias field; then ad after sending
ADL command to get the contact list, send the first PRP MFN, to set first
the nickname with param the value of friendlyname field; and also add a
command to save the friendly nickname's value in the setting file, when is
modified manually throught the dialog.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 13:21

Message:
Logged In: YES
user_id=159910
Originator: YES

actually I _thought_ I fixed the 2nd issue, turns out now I can't log in
anymore :-/ reverting to old gaim code works though, will figure it out
later tonight.

feel free to take a shot

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 12:46

Message:
Logged In: YES
user_id=159910
Originator: YES

I actually have those 2 fixed already, nice job though.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 11:34

Message:
Logged In: YES
user_id=1678429
Originator: NO

I've tried the patch winth gaim svn... it works but there are some
problems with the friendly nickname... when I try to set the nickname, it
disconnect from msn. I've corrected this problem using the new msn command
to set nickname, instead of the obsolate one.

###################################################################
--- msn.c.original 2006-12-28 18:30:12.000000000 +0100
+++ msn.c 2006-12-28 18:30:34.000000000 +0100
@@ -137,9 +137,7 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
}

static void
#########################################################################

Now I'm going to solve the missed nickname's update on connect.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1621854 ] brings soc-2006-msnp13 up to head

2007-04-09T02:37:55Z

Patches item #1621854, was opened at 2006-12-25 04:36
Message generated for change (Comment added) made by jason_syu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Sean Egan (seanegan)
Summary: brings soc-2006-msnp13 up to head

Initial Comment:
This tarball brings soc-2006-msnp13 up to head. In addition to that it also fixes a crash with sending offline messages.

I wasn't able to generate a diff against that branch, svn seems to insist on diff'ing against HEAD after I run the merge command. After running `svn merge -r 16309:HEAD https://gaim.svn.sourceforge.net/svnroot/gaim/trunk` on the soc-2006-msnp13 you can replace the msn directory with the attached tarball. The fix for offline messaging is on msn.c:901:

if (!session->oim)
session->oim = msn_oim_new(session)

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 08:37

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 08:36

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-04-01 21:03

Message:
Logged In: YES
user_id=1525231
Originator: NO

Couple patches again:
http://koti.mbnet.fi/simom/gaim-msnp13/markup_escape_psm.diff
PSM needs to be escaped, tooltip rendering fails if PSM had '&' in it.

http://koti.mbnet.fi/simom/gaim-msnp13/currentmedia.diff
Support for showing current media of buddies in buddy list. Tooltip shows
both PSM and current media if they are both set, but status line shows only
current media if it is set (official client behaviour). Note: This patch
already includes escaping of PSM, you don't need markup_escape_psm.diff if
you use this.
I know there are bigger problems at the moment than lack of current media
support, but here it is anyway :)

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-16 09:18

Message:
Logged In: YES
user_id=1525231
Originator: NO

Two little patches, first one prevents own account to be added as a buddy
to buddylist, and second fixes tooltip messing with status and PSM.

http://koti.mbnet.fi/simom/gaim-msnp13/own-account-as-buddy.diff
http://koti.mbnet.fi/simom/gaim-msnp13/psm-in-tooltip.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 06:35

Message:
Logged In: YES
user_id=159910
Originator: YES

A little late, but here is a version that should remember your friendly
name. Also has a fix for a crasher when MSN sends you back:

<faultstring>Need to do full sync. Can't sync deltas Client
has too old a copy for us to do a delta sync</faultstring>

In this case, I make gaim re-request the full contact list/address book.

I haven't look too deeply into the reverse list problem, but I think the
solution would involve caching the reverse list, which may require
extending the privacy api.
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 03:30

Message:
Logged In: YES
user_id=159910
Originator: YES

Updated the diff with basically no change, except with simom's icon fix.
The previous diff was broken because some of the files were not added

Had to compress it because of sourceforge file size limit
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-10 20:39

Message:
Logged In: YES
user_id=159910
Originator: YES

uploaded a diff, this diff is unchanged from the last tarball that I
previously uploaded, except that it's against HEAD. This should be a little
easier for most people.

File Added: msn-p13-merge-head.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-07 07:54

Message:
Logged In: YES
user_id=159910
Originator: YES

Another way is to make a SOAP request whenever the friendly name is set,
and set the friendly name every time you sign on, which doesn't fix the
reverse list problem, but does allow the friendly name to persist. I
already have the first part written.

I apologize if my lack of activity wasted you too much time.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-06 11:22

Message:
Logged In: YES
user_id=1525231
Originator: NO

One way too is to ask full contact list and address book every time
(*Changes=NULL in certain function calls), I tried this too, it works but
logging in takes some more time. It actually fixes reverse list -problem
too, but maybe local caching would still be a better solution as it is
planned to work that way and it reduces bandwidth-usage.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-03-06 07:09

Message:
Logged In: YES
user_id=20979
Originator: NO

Ooh, that's so rockin'

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-06 07:02

Message:
Logged In: YES
user_id=159910
Originator: YES

I found a way to make the server resend the friendly name every time you
sign on, but I haven't had the time and motivation to finish that.
Hopefully I will find the time to look at your diff this weekend.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-05 16:43

Message:
Logged In: YES
user_id=1525231
Originator: NO

I fixed the icons by adding "b->proto_data = user;" to msn_userlist_load()
in userlist.c (see end of the patch), and Friendly name -issue by caching
it to buddylist and using that if it isn't sent by server. This seems to be
necessary as server sends only changes in information since last time.
Maybe same should be done to reverse list, as now for every buddy in my
list i get 'has you: no' in the tooltip. I also prevented own account to be
added to buddy list. Patch against msn.tgz v2 (the one dated 2006-12-30
09:17) can be found in
http://koti.mbnet.fi/simom/gaim-msnp13/msnp13-friendly-name-and-icons.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 18:54

Message:
Logged In: YES
user_id=159910
Originator: YES

I am heading out, but g_return_if_fail(cmd->param_count >= 3) means if the
condition cmd->param_count >= 3 fails, the function would return right
there. So that part is working as expected. I have no idea why sometimes I
get the friendly name and sometimes I don't.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 11:11

Message:
Logged In: YES
user_id=1678429
Originator: NO

The first two connection I receive after last USR TWN command
USR <tid> OK <email> 1 0
USR <tid2> <email> <a number of three blocks
nnnnnnnnnn.nnnnnnnn.nnnnnnnn>
USR <tid2> OK <email> <displayname>

The third time the last USR OK command is:
USR <tid2> OK <email> <email>

I changed nothing in account's setting, I only connected and disconnected
for three time. VERY strange.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 11:02

Message:
Logged In: YES
user_id=1678429
Originator: NO

Uhm... I'm trying your updated version... with a new profile.... The first
connection, it's all ok... it loads for my contact the right friendly name
from server I think because the local alias is different. I disconnected,
then reconnected, it's ok also this time; again I disconnect and then
reconnect, but at this third time... it doesn't load the friendly name, and
all my msn buddies have the same msn icon
http://xs210.xs.to/xs210/06525/screenshot1.png. :|

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 10:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

And also I see now in prp_cmd method of notification.c your mod...
###############
static void
prp_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
MsnSession *session = cmdproc->session;
const char *type, *value;

g_return_if_fail(cmd->param_count >= 3);

type = cmd->params[2];

if (cmd->param_count == 4)
{
value = cmd->params[3];
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, gaim_url_decode(value));
}
else
{
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, NULL);
else if (!strcmp(type, "MFM")) {
type = cmd->params[1];
gaim_connection_set_display_name(
gaim_account_get_connection(session->account),
gaim_url_decode(cmd->params[2]));
}
}
}
###############################
as third instruction of the void there is
g_return_if_fail(cmd->param_count >= 3);, from whati I understand of this
void, it stop the void procedure if cmd->param_count >= 3.... but after I
see if (cmd->param_count == 4) .... so if it's right the interpretation of
g_return_if_fail the condition that follow never happen! And I also thought
that was incoerent... and so I changed the integer of values.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 10:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

I added the if (!strcmp(type, "MFN")) { in sync.c and notification.c
because it figured out in that files the void prp_cmd... and I thought that
was necessary add the parsing of that instruction... that set the nickname.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 07:17

Message:
Logged In: YES
user_id=159910
Originator: YES

new version, fixes some crashes because group_id is char * but in some
places it's set to an int (!). skadotnet, I don't understand why you need
`if (!strcmp(type, "MFN")) {` in so many places, so I didn't include most
of them. I also have different versions of some of your fixes because I
already fixed them.

Group manipulations may still not work, at least it's not crashing :-)

File Added: msn.tgz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 07:03

Message:
Logged In: YES
user_id=159910
Originator: YES

are you sure that setting the friendly name in msn_notification_post_adl()
is correct?

something is weird, sometimes I get back my own contact information in
contact.c:msn_parse_addressbook(), so I can set the display name there, and
sometimes I don't. It may have something to do with contact list caching.

I will upload a new version soon that fixes lots of compiler warning and
some crashes for group manipulations.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 02:38

Message:
Logged In: YES
user_id=159910
Originator: YES

I finally figured out why I couldn't sign on, I was missing a */ so a
large block of code was commented out!

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 15:35

Message:
Logged In: YES
user_id=1678429
Originator: NO

I link directly the patch file....
http://skadotnet.altervista.org/msn.patch

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 15:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

This is the patch file for the first 2 fix, it's not complete because it
need the implementation of the field where save the friendly name, now it
use local alias as first display name. It persists the problem of buddy
icon, I'm sorry but more than this I can't do.
Here the patch:
############################################################################################################################################
diff -uN msn.original/msn.c msn/msn.c
--- msn.original/msn.c 2006-12-25 03:29:57.000000000 +0100
+++ msn/msn.c 2006-12-29 16:11:15.000000000 +0100
@@ -137,9 +137,10 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ if (strlen(alias) > 0)
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
+ else
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s",
gaim_url_encode(gaim_account_get_username(account)));
}

static void
@@ -798,6 +799,9 @@

if (!msn_session_connect(session, host, port, http_method))
gaim_connection_error(gc, _("Failed to connect to server."));
+
+ // Transitional pointment to local alias. Should be the friendly name
saved at every change.
+ gaim_connection_set_display_name(gc, gaim_account_get_alias(account));
}

static void
diff -uN msn.original/notification.c msn/notification.c
--- msn.original/notification.c 2006-12-25 00:52:23.000000000 +0100
+++ msn/notification.c 2006-12-29 16:11:15.000000000 +0100
@@ -235,8 +235,9 @@
/* authenticate OK */
const char *friendly = gaim_url_decode(cmd->params[3]);

- gaim_connection_set_display_name(gc, friendly);
-
+ if (g_ascii_strcasecmp(friendly, "1"))
+ gaim_connection_set_display_name(gc, friendly);
+
msn_session_set_login_step(session, MSN_LOGIN_STEP_SYN);

// msn_cmdproc_send(cmdproc, "SYN", "%s", "0");
@@ -626,6 +627,29 @@
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;
+
+ GaimAccount *account;
+ account = cmdproc->session->account;
+
+ /*
+ * TODO: save somewhere the friendly name in accounts file, when a new
account is created,
+ * or it's set empty or equal to local alias. When a command PRP
MFN is sent through
+ * prp_cmd method in notification.c and sync.c the field in xml
config file is updated.
+ * This is loaded after login with
gaim_connection_set_display_name(GaimConnection *gc, const char *value)
[msn.c:803-804]
+ * so if we connect throught MSNP8 on USR OK command we overwrite
that field,
+ * if the length isn't equal to "1", else if we connect throught
MSNP11 or higher, on USR OK command
+ * we don't overwrite that field because the params is equals to
"1", and throught the command down here
+ * we set for the first time the saved friendly nickname.
+ */
+ const char *friendly;
+ friendly =
gaim_url_encode(gaim_connection_get_display_name(account->gc));
+
+ if (strlen(friendly) <= 0)
+ friendly = gaim_url_encode(gaim_account_get_username(account));
+
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", friendly);
+
+ gaim_debug_info("Ska","Set friendly name as
%s\n",gaim_url_decode(friendly));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
@@ -1025,12 +1049,16 @@

g_return_if_fail(cmd->param_count >= 3);

- type = cmd->params[2];
+ type = cmd->params[1];

- if (cmd->param_count == 4)
+ if (cmd->param_count == 3)
{
- value = cmd->params[3];
- if (!strcmp(type, "PHH"))
+ value = cmd->params[2];
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -1039,7 +1067,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
diff -uN msn.original/sync.c msn/sync.c
--- msn.original/sync.c 2006-12-25 00:17:41.000000000 +0100
+++ msn/sync.c 2006-12-29 16:11:15.000000000 +0100
@@ -64,7 +64,11 @@

if (cmd->param_count == 2)
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -73,7 +77,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
############################################################################################################################################

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 14:05

Message:
Logged In: YES
user_id=1678429
Originator: NO

I'm modifying the fix for second issue, that also set the display name's
field when you open the dialog for set alias manually

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 11:15

Message:
Logged In: YES
user_id=1678429
Originator: NO

There is also another bug.... all my msn buddies have the same msn icon:
this http://xs210.xs.to/xs210/06525/screenshot1.png

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 11:09

Message:
Logged In: YES
user_id=1678429
Originator: NO

I don't see any other way to solve this... when login server send the
command USR Ok, now there isn't the display name that should be stored on
the server....
I've found, I think, the right location to add this command. File
notification.c at line 625.

From:
#####################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
######################################

To:
######################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

GaimAccount *account;
account = cmdproc->session->account;

msn_cmdproc_send(cmdproc,"PRP","MFN %s",
gaim_url_encode(gaim_account_get_alias(account)));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
################################################

with this fix, now the friendly name is set at startup as the local alias
field's value.
For the old MSNP8 is still enabled the parsing of USR OK answer to look
for the display name... but connecting with MSNP13/14 it finds only the
value "1", because server answer with "USR <transid> OK <email-address> 1
0\r\n". The old parser get the fourth parameter... that now is "1", and set
it as friendly name... but then arrives another USR OK answer that
containst at fourth parameter again the email address, and again it set the
friendly name with the email address.
Using this fix, before the second USR OK answer it set the friendly name
so the second USR OK answer arrives as the old format "USR <transid> OK
<email-address> <friendly-name> 0\r\n".

There are other things to do, because, now it set the local alias, and
when you want manually change the friendly name through the dialog, the
value of textbox is "1", I don't know why.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 23:02

Message:
Logged In: YES
user_id=159910
Originator: YES

ya, I thought about that, but then with MSNP8 you can use your friendly
name that you set from elsewhere, with this it means you can't

anyway, I still need to fix the logon issue before I can do any meaningful
work again.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 22:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

For the second "bug", from what I could see from the code, and from
msnpiki, it's a change of commands of the protocol. Before the friendly
name ad login was recieved form USR command, but now as says
http://msnpiki.msnfanatic.com/index.php/MSNP13:Example_Session#Updating_Display_Name
after ADL command we need to send a fisrt PRP command to set the friendly
name, so we need to save somewhere the nickname.
A solution could be use the config file to save this parameter, when the
account is created this field is sat as alias field; then ad after sending
ADL command to get the contact list, send the first PRP MFN, to set first
the nickname with param the value of friendlyname field; and also add a
command to save the friendly nickname's value in the setting file, when is
modified manually throught the dialog.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 19:21

Message:
Logged In: YES
user_id=159910
Originator: YES

actually I _thought_ I fixed the 2nd issue, turns out now I can't log in
anymore :-/ reverting to old gaim code works though, will figure it out
later tonight.

feel free to take a shot

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 18:46

Message:
Logged In: YES
user_id=159910
Originator: YES

I actually have those 2 fixed already, nice job though.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 17:34

Message:
Logged In: YES
user_id=1678429
Originator: NO

I've tried the patch winth gaim svn... it works but there are some
problems with the friendly nickname... when I try to set the nickname, it
disconnect from msn. I've corrected this problem using the new msn command
to set nickname, instead of the obsolate one.

###################################################################
--- msn.c.original 2006-12-28 18:30:12.000000000 +0100
+++ msn.c 2006-12-28 18:30:34.000000000 +0100
@@ -137,9 +137,7 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
}

static void
#########################################################################

Now I'm going to solve the missed nickname's update on connect.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1621854 ] brings soc-2006-msnp13 up to head

2007-04-09T02:36:20Z

Patches item #1621854, was opened at 2006-12-25 04:36
Message generated for change (Comment added) made by jason_syu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Sean Egan (seanegan)
Summary: brings soc-2006-msnp13 up to head

Initial Comment:
This tarball brings soc-2006-msnp13 up to head. In addition to that it also fixes a crash with sending offline messages.

I wasn't able to generate a diff against that branch, svn seems to insist on diff'ing against HEAD after I run the merge command. After running `svn merge -r 16309:HEAD https://gaim.svn.sourceforge.net/svnroot/gaim/trunk` on the soc-2006-msnp13 you can replace the msn directory with the attached tarball. The fix for offline messaging is on msn.c:901:

if (!session->oim)
session->oim = msn_oim_new(session)

----------------------------------------------------------------------

Comment By: J.S. (jason_syu)
Date: 2007-04-09 08:36

Message:
Logged In: YES
user_id=1760749
Originator: NO

In function msn_session_sync_users() in file session.c, gaim will throw
SEGFAULT caused by
removing element from the list while iterating the list.

Iterating here:
>> for(bnode = cnode->child; bnode; bnode = bnode->next) {

Removing here:
>> msn_show_sync_issue(session, b->name, group_name); // bnode may be
removed in this function

So iterating code can be changed to:
...
bnode = cnode->child;
while(bnode != NULL) {
tnode = bnode->next;
....
....
bnode = tnode;
}
...
to avoid using the data structure of removed element.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-04-01 21:03

Message:
Logged In: YES
user_id=1525231
Originator: NO

Couple patches again:
http://koti.mbnet.fi/simom/gaim-msnp13/markup_escape_psm.diff
PSM needs to be escaped, tooltip rendering fails if PSM had '&' in it.

http://koti.mbnet.fi/simom/gaim-msnp13/currentmedia.diff
Support for showing current media of buddies in buddy list. Tooltip shows
both PSM and current media if they are both set, but status line shows only
current media if it is set (official client behaviour). Note: This patch
already includes escaping of PSM, you don't need markup_escape_psm.diff if
you use this.
I know there are bigger problems at the moment than lack of current media
support, but here it is anyway :)

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-16 09:18

Message:
Logged In: YES
user_id=1525231
Originator: NO

Two little patches, first one prevents own account to be added as a buddy
to buddylist, and second fixes tooltip messing with status and PSM.

http://koti.mbnet.fi/simom/gaim-msnp13/own-account-as-buddy.diff
http://koti.mbnet.fi/simom/gaim-msnp13/psm-in-tooltip.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 06:35

Message:
Logged In: YES
user_id=159910
Originator: YES

A little late, but here is a version that should remember your friendly
name. Also has a fix for a crasher when MSN sends you back:

<faultstring>Need to do full sync. Can't sync deltas Client
has too old a copy for us to do a delta sync</faultstring>

In this case, I make gaim re-request the full contact list/address book.

I haven't look too deeply into the reverse list problem, but I think the
solution would involve caching the reverse list, which may require
extending the privacy api.
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 03:30

Message:
Logged In: YES
user_id=159910
Originator: YES

Updated the diff with basically no change, except with simom's icon fix.
The previous diff was broken because some of the files were not added

Had to compress it because of sourceforge file size limit
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-10 20:39

Message:
Logged In: YES
user_id=159910
Originator: YES

uploaded a diff, this diff is unchanged from the last tarball that I
previously uploaded, except that it's against HEAD. This should be a little
easier for most people.

File Added: msn-p13-merge-head.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-07 07:54

Message:
Logged In: YES
user_id=159910
Originator: YES

Another way is to make a SOAP request whenever the friendly name is set,
and set the friendly name every time you sign on, which doesn't fix the
reverse list problem, but does allow the friendly name to persist. I
already have the first part written.

I apologize if my lack of activity wasted you too much time.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-06 11:22

Message:
Logged In: YES
user_id=1525231
Originator: NO

One way too is to ask full contact list and address book every time
(*Changes=NULL in certain function calls), I tried this too, it works but
logging in takes some more time. It actually fixes reverse list -problem
too, but maybe local caching would still be a better solution as it is
planned to work that way and it reduces bandwidth-usage.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-03-06 07:09

Message:
Logged In: YES
user_id=20979
Originator: NO

Ooh, that's so rockin'

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-06 07:02

Message:
Logged In: YES
user_id=159910
Originator: YES

I found a way to make the server resend the friendly name every time you
sign on, but I haven't had the time and motivation to finish that.
Hopefully I will find the time to look at your diff this weekend.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-05 16:43

Message:
Logged In: YES
user_id=1525231
Originator: NO

I fixed the icons by adding "b->proto_data = user;" to msn_userlist_load()
in userlist.c (see end of the patch), and Friendly name -issue by caching
it to buddylist and using that if it isn't sent by server. This seems to be
necessary as server sends only changes in information since last time.
Maybe same should be done to reverse list, as now for every buddy in my
list i get 'has you: no' in the tooltip. I also prevented own account to be
added to buddy list. Patch against msn.tgz v2 (the one dated 2006-12-30
09:17) can be found in
http://koti.mbnet.fi/simom/gaim-msnp13/msnp13-friendly-name-and-icons.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 18:54

Message:
Logged In: YES
user_id=159910
Originator: YES

I am heading out, but g_return_if_fail(cmd->param_count >= 3) means if the
condition cmd->param_count >= 3 fails, the function would return right
there. So that part is working as expected. I have no idea why sometimes I
get the friendly name and sometimes I don't.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 11:11

Message:
Logged In: YES
user_id=1678429
Originator: NO

The first two connection I receive after last USR TWN command
USR <tid> OK <email> 1 0
USR <tid2> <email> <a number of three blocks
nnnnnnnnnn.nnnnnnnn.nnnnnnnn>
USR <tid2> OK <email> <displayname>

The third time the last USR OK command is:
USR <tid2> OK <email> <email>

I changed nothing in account's setting, I only connected and disconnected
for three time. VERY strange.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 11:02

Message:
Logged In: YES
user_id=1678429
Originator: NO

Uhm... I'm trying your updated version... with a new profile.... The first
connection, it's all ok... it loads for my contact the right friendly name
from server I think because the local alias is different. I disconnected,
then reconnected, it's ok also this time; again I disconnect and then
reconnect, but at this third time... it doesn't load the friendly name, and
all my msn buddies have the same msn icon
http://xs210.xs.to/xs210/06525/screenshot1.png. :|

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 10:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

And also I see now in prp_cmd method of notification.c your mod...
###############
static void
prp_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
MsnSession *session = cmdproc->session;
const char *type, *value;

g_return_if_fail(cmd->param_count >= 3);

type = cmd->params[2];

if (cmd->param_count == 4)
{
value = cmd->params[3];
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, gaim_url_decode(value));
}
else
{
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, NULL);
else if (!strcmp(type, "MFM")) {
type = cmd->params[1];
gaim_connection_set_display_name(
gaim_account_get_connection(session->account),
gaim_url_decode(cmd->params[2]));
}
}
}
###############################
as third instruction of the void there is
g_return_if_fail(cmd->param_count >= 3);, from whati I understand of this
void, it stop the void procedure if cmd->param_count >= 3.... but after I
see if (cmd->param_count == 4) .... so if it's right the interpretation of
g_return_if_fail the condition that follow never happen! And I also thought
that was incoerent... and so I changed the integer of values.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 10:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

I added the if (!strcmp(type, "MFN")) { in sync.c and notification.c
because it figured out in that files the void prp_cmd... and I thought that
was necessary add the parsing of that instruction... that set the nickname.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 07:17

Message:
Logged In: YES
user_id=159910
Originator: YES

new version, fixes some crashes because group_id is char * but in some
places it's set to an int (!). skadotnet, I don't understand why you need
`if (!strcmp(type, "MFN")) {` in so many places, so I didn't include most
of them. I also have different versions of some of your fixes because I
already fixed them.

Group manipulations may still not work, at least it's not crashing :-)

File Added: msn.tgz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 07:03

Message:
Logged In: YES
user_id=159910
Originator: YES

are you sure that setting the friendly name in msn_notification_post_adl()
is correct?

something is weird, sometimes I get back my own contact information in
contact.c:msn_parse_addressbook(), so I can set the display name there, and
sometimes I don't. It may have something to do with contact list caching.

I will upload a new version soon that fixes lots of compiler warning and
some crashes for group manipulations.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 02:38

Message:
Logged In: YES
user_id=159910
Originator: YES

I finally figured out why I couldn't sign on, I was missing a */ so a
large block of code was commented out!

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 15:35

Message:
Logged In: YES
user_id=1678429
Originator: NO

I link directly the patch file....
http://skadotnet.altervista.org/msn.patch

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 15:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

This is the patch file for the first 2 fix, it's not complete because it
need the implementation of the field where save the friendly name, now it
use local alias as first display name. It persists the problem of buddy
icon, I'm sorry but more than this I can't do.
Here the patch:
############################################################################################################################################
diff -uN msn.original/msn.c msn/msn.c
--- msn.original/msn.c 2006-12-25 03:29:57.000000000 +0100
+++ msn/msn.c 2006-12-29 16:11:15.000000000 +0100
@@ -137,9 +137,10 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ if (strlen(alias) > 0)
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
+ else
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s",
gaim_url_encode(gaim_account_get_username(account)));
}

static void
@@ -798,6 +799,9 @@

if (!msn_session_connect(session, host, port, http_method))
gaim_connection_error(gc, _("Failed to connect to server."));
+
+ // Transitional pointment to local alias. Should be the friendly name
saved at every change.
+ gaim_connection_set_display_name(gc, gaim_account_get_alias(account));
}

static void
diff -uN msn.original/notification.c msn/notification.c
--- msn.original/notification.c 2006-12-25 00:52:23.000000000 +0100
+++ msn/notification.c 2006-12-29 16:11:15.000000000 +0100
@@ -235,8 +235,9 @@
/* authenticate OK */
const char *friendly = gaim_url_decode(cmd->params[3]);

- gaim_connection_set_display_name(gc, friendly);
-
+ if (g_ascii_strcasecmp(friendly, "1"))
+ gaim_connection_set_display_name(gc, friendly);
+
msn_session_set_login_step(session, MSN_LOGIN_STEP_SYN);

// msn_cmdproc_send(cmdproc, "SYN", "%s", "0");
@@ -626,6 +627,29 @@
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;
+
+ GaimAccount *account;
+ account = cmdproc->session->account;
+
+ /*
+ * TODO: save somewhere the friendly name in accounts file, when a new
account is created,
+ * or it's set empty or equal to local alias. When a command PRP
MFN is sent through
+ * prp_cmd method in notification.c and sync.c the field in xml
config file is updated.
+ * This is loaded after login with
gaim_connection_set_display_name(GaimConnection *gc, const char *value)
[msn.c:803-804]
+ * so if we connect throught MSNP8 on USR OK command we overwrite
that field,
+ * if the length isn't equal to "1", else if we connect throught
MSNP11 or higher, on USR OK command
+ * we don't overwrite that field because the params is equals to
"1", and throught the command down here
+ * we set for the first time the saved friendly nickname.
+ */
+ const char *friendly;
+ friendly =
gaim_url_encode(gaim_connection_get_display_name(account->gc));
+
+ if (strlen(friendly) <= 0)
+ friendly = gaim_url_encode(gaim_account_get_username(account));
+
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", friendly);
+
+ gaim_debug_info("Ska","Set friendly name as
%s\n",gaim_url_decode(friendly));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
@@ -1025,12 +1049,16 @@

g_return_if_fail(cmd->param_count >= 3);

- type = cmd->params[2];
+ type = cmd->params[1];

- if (cmd->param_count == 4)
+ if (cmd->param_count == 3)
{
- value = cmd->params[3];
- if (!strcmp(type, "PHH"))
+ value = cmd->params[2];
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -1039,7 +1067,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
diff -uN msn.original/sync.c msn/sync.c
--- msn.original/sync.c 2006-12-25 00:17:41.000000000 +0100
+++ msn/sync.c 2006-12-29 16:11:15.000000000 +0100
@@ -64,7 +64,11 @@

if (cmd->param_count == 2)
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -73,7 +77,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
############################################################################################################################################

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 14:05

Message:
Logged In: YES
user_id=1678429
Originator: NO

I'm modifying the fix for second issue, that also set the display name's
field when you open the dialog for set alias manually

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 11:15

Message:
Logged In: YES
user_id=1678429
Originator: NO

There is also another bug.... all my msn buddies have the same msn icon:
this http://xs210.xs.to/xs210/06525/screenshot1.png

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 11:09

Message:
Logged In: YES
user_id=1678429
Originator: NO

I don't see any other way to solve this... when login server send the
command USR Ok, now there isn't the display name that should be stored on
the server....
I've found, I think, the right location to add this command. File
notification.c at line 625.

From:
#####################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
######################################

To:
######################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

GaimAccount *account;
account = cmdproc->session->account;

msn_cmdproc_send(cmdproc,"PRP","MFN %s",
gaim_url_encode(gaim_account_get_alias(account)));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
################################################

with this fix, now the friendly name is set at startup as the local alias
field's value.
For the old MSNP8 is still enabled the parsing of USR OK answer to look
for the display name... but connecting with MSNP13/14 it finds only the
value "1", because server answer with "USR <transid> OK <email-address> 1
0\r\n". The old parser get the fourth parameter... that now is "1", and set
it as friendly name... but then arrives another USR OK answer that
containst at fourth parameter again the email address, and again it set the
friendly name with the email address.
Using this fix, before the second USR OK answer it set the friendly name
so the second USR OK answer arrives as the old format "USR <transid> OK
<email-address> <friendly-name> 0\r\n".

There are other things to do, because, now it set the local alias, and
when you want manually change the friendly name through the dialog, the
value of textbox is "1", I don't know why.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 23:02

Message:
Logged In: YES
user_id=159910
Originator: YES

ya, I thought about that, but then with MSNP8 you can use your friendly
name that you set from elsewhere, with this it means you can't

anyway, I still need to fix the logon issue before I can do any meaningful
work again.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 22:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

For the second "bug", from what I could see from the code, and from
msnpiki, it's a change of commands of the protocol. Before the friendly
name ad login was recieved form USR command, but now as says
http://msnpiki.msnfanatic.com/index.php/MSNP13:Example_Session#Updating_Display_Name
after ADL command we need to send a fisrt PRP command to set the friendly
name, so we need to save somewhere the nickname.
A solution could be use the config file to save this parameter, when the
account is created this field is sat as alias field; then ad after sending
ADL command to get the contact list, send the first PRP MFN, to set first
the nickname with param the value of friendlyname field; and also add a
command to save the friendly nickname's value in the setting file, when is
modified manually throught the dialog.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 19:21

Message:
Logged In: YES
user_id=159910
Originator: YES

actually I _thought_ I fixed the 2nd issue, turns out now I can't log in
anymore :-/ reverting to old gaim code works though, will figure it out
later tonight.

feel free to take a shot

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 18:46

Message:
Logged In: YES
user_id=159910
Originator: YES

I actually have those 2 fixed already, nice job though.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 17:34

Message:
Logged In: YES
user_id=1678429
Originator: NO

I've tried the patch winth gaim svn... it works but there are some
problems with the friendly nickname... when I try to set the nickname, it
disconnect from msn. I've corrected this problem using the new msn command
to set nickname, instead of the obsolate one.

###################################################################
--- msn.c.original 2006-12-28 18:30:12.000000000 +0100
+++ msn.c 2006-12-28 18:30:34.000000000 +0100
@@ -137,9 +137,7 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
}

static void
#########################################################################

Now I'm going to solve the missed nickname's update on connect.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1693706 ] Fix missing buddy icons and custom emoticons on MSN

2007-04-08T19:21:22Z

Patches item #1693706, was opened at 2007-04-03 10:22
Message generated for change (Comment added) made by datallah
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1693706&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Simo Mattila (simom)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix missing buddy icons and custom emoticons on MSN

Initial Comment:
Newer Live Messenger -versions doesn't always send SHA1C-field in msnobj's and so Gaim discards them. This patch accepts them even if SHA1C is missing, and use SHA1D as icon checksum instead of SHA1C.
Fixes bug #1675659.

----------------------------------------------------------------------

>Comment By: Daniel Atallah (datallah)
Date: 2007-04-08 20:21

Message:
Logged In: YES
user_id=325843
Originator: NO

This will cause all the existing icon checksums to be incorrect.

I think this should be redone using SHA1D as a fallback instead of the
default.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1693706&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1662169 ] Log Embeded Images

2007-04-08T17:24:28Z

Patches item #1662169, was opened at 2007-02-17 03:26
Message generated for change (Comment added) made by rlaager
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1662169&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: David Grohmann (dave1g)
Assigned to: Richard Laager (rlaager)
Summary: Log Embeded Images

Initial Comment:
This might be aim specific, I'm not sure if the other protocols can do this. But in aim, you can send an image embedded in an IM. But in the logs it just comes out to be something like

(2:48:05 AM) Dave1g: <IMG ID="1">
(2:48:14 AM) Dave1g: <IMG ID="2">

Deadaim used to log the sent images so I know its technically feasible.

Create a folder in that log directory with the name date_images and src the images from there so when the html log is loaded in a web browser the images show up.

Perhaps this could be a summer of code 2007 project? There seems to be a lot of feature requests for how logging is done.

Thank you.

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-04-08 18:24

Message:
Logged In: YES
user_id=156487
Originator: NO

The Pidgin stuff is mostly done in the monotone repository. If you want to
port the patch to that, it'd help me a lot. If you need any assistance from
me, please feel free to IM me.

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-04-07 20:57

Message:
Logged In: YES
user_id=1055565
Originator: YES

I have been busy, but I suppose I will put this on hold until the pigin
stuff settles down. I imagine a lot of code changes are around the corner.

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-21 02:58

Message:
Logged In: YES
user_id=1055565
Originator: YES

Thanks for the hint Richard! I will attempt to address your concerns. I
must admit that most of my experience is with aim. And so I may need the
input/help of others to make this patch useful to other protocols. It is
not my intention to log smiley faces I wasn't aware of the custom ones you
speak of on other protocols.

So as far as naming conventions go I was just going for something that was
simple and had little chance of writing over another file. Wont have any
time to work on this soon, but maybe this weekend.

Glad you took notice of my work :-)

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-03-20 19:53

Message:
Logged In: YES
user_id=156487
Originator: NO

I think you're on the right track. I do have some comments.

image_file_ptr = fopen(path, "w");

You're writing binary data, not text. Change the "w" to "wb" instead.

Regarding this...
fwrite(image_data, 1, image_byte_count, image_file_ptr);

To me, you're writing 1 image of a given size, not a number of 1 byte
blocks ;) I'd change this to, which should still work:
fwrite(image_data, image_byte_count, 1, image_file_ptr);

Please indent your code, and if variables are only used within a given
block, please move the variable definitions there instead. For example:
+if (imgid != 0)
+{
+gaim_imgstore_ref(imgid);
+image = gaim_imgstore_get(imgid);
+image_data = gaim_imgstore_get_data(image);
+image_byte_count = gaim_imgstore_get_size(image);
+original_filename = gaim_imgstore_get_filename(image);
...

You should be able to move the variable definitions to there instead of
doing them at the top.

I'm not sure how much I like the idea of saving images with the date and
original filename. I think maybe we should be saving them with a file hash
instead. That way, if the same image is embedded multiple times or used
across multiple conversations, we would only save one copy. This is
important for MSN custom emoticons, for example. You should address the
other concerns first, and then I can offer some guidance on making this
change.

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:53

Message:
Logged In: YES
user_id=1055565
Originator: YES

Well I have the patch almost working. The output file is slightly
corrupted from the original. I cant figure out why that is happening.
Perhaps another pair of eyes can point out the flaw.

I compiled and tested this with svn from a couple days ago and on a cygwin
windows xp installation. core 2 duo dell laptop.

Please if anyone else is interested in this, take a look at my patch and
try to fix it.

P.S. the formatting isnt up to snuff, but it doesn't work so I wasn't
worried about getting it committed yet.

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:46

Message:
Logged In: YES
user_id=1055565
Originator: YES

File Added: 2007-03-18.040726Central Daylight TimeCDT.html

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:45

Message:
Logged In: YES
user_id=1055565
Originator: YES

File Added: 2007-03-18.040726_handdrawn copy.jpg

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:44

Message:
Logged In: YES
user_id=1055565
Originator: YES

File Added: handdrawn copy.jpg

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:42

Message:
Logged In: YES
user_id=1055565
Originator: YES

File Added: image_logging.patch

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-16 00:50

Message:
Logged In: YES
user_id=1055565
Originator: YES

well i got bored today, and am attempting to put my time where my mouth is
and write a patch that logs images in aim

----------------------------------------------------------------------

Comment By: CWAL (cwal)
Date: 2007-02-18 10:54

Message:
Logged In: YES
user_id=1410499
Originator: NO

I would find this feature useful as well.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1662169&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1694728 ] plug 3 simple leaks

2007-04-08T16:31:14Z

Patches item #1694728, was opened at 2007-04-04 23:17
Message generated for change (Comment added) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1694728&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Andrew Gaul (gaul)
Assigned to: Nobody/Anonymous (nobody)
Summary: plug 3 simple leaks

Initial Comment:
==16165== 4,134 bytes in 1 blocks are definitely lost in loss record 231 of 267
==16165== at 0x4005400: malloc (vg_replace_malloc.c:149)
==16165== by 0x4CC98692: g_try_malloc (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC83BAA: g_file_get_contents (in /lib/libglib-2.0.so.0.1200.9
)
==16165== by 0x4541864: yahoo_set_buddy_icon (yahoo_picture.c:540)
==16165== by 0x453126C: yahoo_login (yahoo.c:2655)
==16165== by 0x404C5D5: gaim_connection_new (connection.c:156)
==16165== by 0x403D16D: gaim_account_connect (account.c:1000)
==16165== by 0x403D453: gaim_accounts_restore_current_statuses (account.c:231
6)
==16165== by 0x80ABAC0: main (gtkmain.c:797)

==29463== 148 bytes in 10 blocks are definitely lost in loss record 135 of 266
==29463== at 0x4005400: malloc (vg_replace_malloc.c:149)
==29463== by 0x4CC98875: g_malloc (in /lib/libglib-2.0.so.0.1200.9)
==29463== by 0x4467623: jabber_parser_element_start_libxml (parser.c:48)
==29463== by 0x4A55AB31: (within /usr/lib/libxml2.so.2.6.27)
==29463== by 0x4A5631BF: xmlParseChunk (in /usr/lib/libxml2.so.2.6.27)
==29463== by 0x4467A6E: jabber_parser_process (parser.c:190)
==29463== by 0x445F486: jabber_recv_cb_ssl (jabber.c:382)
==29463== by 0x4085101: recv_cb (sslconn.c:138)
==29463== by 0x809AFFA: gaim_gtk_io_invoke (gtkeventloop.c:77)
==29463== by 0x4CCBABAC: (within /lib/libglib-2.0.so.0.1200.9)
==29463== by 0x4CC91441: g_main_context_dispatch (in /lib/libglib-2.0.so.0.12
00.9)
==29463== by 0x4CC9441E: (within /lib/libglib-2.0.so.0.1200.9)
==29463== by 0x4CC947C8: g_main_loop_run (in /lib/libglib-2.0.so.0.1200.9)
==29463== by 0x423624B3: gtk_main (in /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==29463== by 0x80B3234: main (gtkmain.c:817)

==16165== 32 bytes in 1 blocks are definitely lost in loss record 70 of 267
==16165== at 0x40054FB: realloc (vg_replace_malloc.c:306)
==16165== by 0x4CC9873A: g_realloc (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CCACF7B: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CCAD4A2: g_string_insert_len (in /lib/libglib-2.0.so.0.1200.9
)
==16165== by 0x4CCAD7F5: g_string_append_len (in /lib/libglib-2.0.so.0.1200.9
)
==16165== by 0x4CC82BAB: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC82DAF: g_build_filename (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4044CAC: gaim_buddy_icons_get_full_path (buddyicon.c:520)
==16165== by 0x44CE133: gaim_ssi_parselist (oscar.c:4976)
==16165== by 0x44BF273: snachandler (family_feedbag.c:1331)
==16165== by 0x44C1E44: flap_connection_recv_cb (flap_connection.c:667)
==16165== by 0x80969C2: gaim_gtk_io_invoke (gtkeventloop.c:77)
==16165== by 0x4CCBABAC: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC91441: g_main_context_dispatch (in /lib/libglib-2.0.so.0.12
00.9)
==16165== by 0x4CC9441E: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC947C8: g_main_loop_run (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x423624B3: gtk_main (in /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16165== by 0x80ABA97: main (gtkmain.c:817)

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2007-04-08 18:31

Message:
Logged In: YES
user_id=20979
Originator: NO

The Jabber memleak had already been fixed in Pidgin Monotone, but I
applied the other two changes. I love patches like this. Thanks!

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1694728&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1662169 ] Log Embeded Images

2007-04-07T19:57:44Z

Patches item #1662169, was opened at 2007-02-17 03:26
Message generated for change (Comment added) made by dave1g
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1662169&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: David Grohmann (dave1g)
Assigned to: Richard Laager (rlaager)
Summary: Log Embeded Images

Initial Comment:
This might be aim specific, I'm not sure if the other protocols can do this. But in aim, you can send an image embedded in an IM. But in the logs it just comes out to be something like

(2:48:05 AM) Dave1g: <IMG ID="1">
(2:48:14 AM) Dave1g: <IMG ID="2">

Deadaim used to log the sent images so I know its technically feasible.

Create a folder in that log directory with the name date_images and src the images from there so when the html log is loaded in a web browser the images show up.

Perhaps this could be a summer of code 2007 project? There seems to be a lot of feature requests for how logging is done.

Thank you.

----------------------------------------------------------------------

>Comment By: David Grohmann (dave1g)
Date: 2007-04-07 20:57

Message:
Logged In: YES
user_id=1055565
Originator: YES

I have been busy, but I suppose I will put this on hold until the pigin
stuff settles down. I imagine a lot of code changes are around the corner.

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-21 02:58

Message:
Logged In: YES
user_id=1055565
Originator: YES

Thanks for the hint Richard! I will attempt to address your concerns. I
must admit that most of my experience is with aim. And so I may need the
input/help of others to make this patch useful to other protocols. It is
not my intention to log smiley faces I wasn't aware of the custom ones you
speak of on other protocols.

So as far as naming conventions go I was just going for something that was
simple and had little chance of writing over another file. Wont have any
time to work on this soon, but maybe this weekend.

Glad you took notice of my work :-)

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-03-20 19:53

Message:
Logged In: YES
user_id=156487
Originator: NO

I think you're on the right track. I do have some comments.

image_file_ptr = fopen(path, "w");

You're writing binary data, not text. Change the "w" to "wb" instead.

Regarding this...
fwrite(image_data, 1, image_byte_count, image_file_ptr);

To me, you're writing 1 image of a given size, not a number of 1 byte
blocks ;) I'd change this to, which should still work:
fwrite(image_data, image_byte_count, 1, image_file_ptr);

Please indent your code, and if variables are only used within a given
block, please move the variable definitions there instead. For example:
+if (imgid != 0)
+{
+gaim_imgstore_ref(imgid);
+image = gaim_imgstore_get(imgid);
+image_data = gaim_imgstore_get_data(image);
+image_byte_count = gaim_imgstore_get_size(image);
+original_filename = gaim_imgstore_get_filename(image);
...

You should be able to move the variable definitions to there instead of
doing them at the top.

I'm not sure how much I like the idea of saving images with the date and
original filename. I think maybe we should be saving them with a file hash
instead. That way, if the same image is embedded multiple times or used
across multiple conversations, we would only save one copy. This is
important for MSN custom emoticons, for example. You should address the
other concerns first, and then I can offer some guidance on making this
change.

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:53

Message:
Logged In: YES
user_id=1055565
Originator: YES

Well I have the patch almost working. The output file is slightly
corrupted from the original. I cant figure out why that is happening.
Perhaps another pair of eyes can point out the flaw.

I compiled and tested this with svn from a couple days ago and on a cygwin
windows xp installation. core 2 duo dell laptop.

Please if anyone else is interested in this, take a look at my patch and
try to fix it.

P.S. the formatting isnt up to snuff, but it doesn't work so I wasn't
worried about getting it committed yet.

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:46

Message:
Logged In: YES
user_id=1055565
Originator: YES

File Added: 2007-03-18.040726Central Daylight TimeCDT.html

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:45

Message:
Logged In: YES
user_id=1055565
Originator: YES

File Added: 2007-03-18.040726_handdrawn copy.jpg

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:44

Message:
Logged In: YES
user_id=1055565
Originator: YES

File Added: handdrawn copy.jpg

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-18 05:42

Message:
Logged In: YES
user_id=1055565
Originator: YES

File Added: image_logging.patch

----------------------------------------------------------------------

Comment By: David Grohmann (dave1g)
Date: 2007-03-16 00:50

Message:
Logged In: YES
user_id=1055565
Originator: YES

well i got bored today, and am attempting to put my time where my mouth is
and write a patch that logs images in aim

----------------------------------------------------------------------

Comment By: CWAL (cwal)
Date: 2007-02-18 10:54

Message:
Logged In: YES
user_id=1410499
Originator: NO

I would find this feature useful as well.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1662169&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1668681 ] Close bug #1121620 and fix some Bi-Directional text issues

2007-04-05T16:49:18Z

Patches item #1668681, was opened at 2007-02-26 02:23
Message generated for change (Comment added) made by shlomil
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668681&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Shlomi Loubaton (shlomil)
Assigned to: Ethan Blanton (eblanton)
Summary: Close bug #1121620 and fix some Bi-Directional text issues

Initial Comment:
In this patch I implemented the following:

* Added a support for tag in the parser of the IMHtml Widget. (AFAIK this HTML tag is deprecated, but most browsers implement it and it beats coding CSS support)

* Added text direction detection to outgoing messages and send it with the correct SPAN tag.

* Added support for the "FN=1" flag in Messanger protocol implementation, both in sending and receiving messages (bug #1121620).

* Fixed some display issues: Insert RLM and RLE unicode characters to the conversation display according to the expected alignment and direction.

For more information about this patch and screenshots:
http://shlomil.blogspot.com/2007/02/patch-to-fix-some-bidi-text-issues-in.html

----------------------------------------------------------------------

>Comment By: Shlomi Loubaton (shlomil)
Date: 2007-04-05 22:49

Message:
Logged In: YES
user_id=953881
Originator: YES

4th version of the patch:
The problem mentioned in my previous comment with ICQ plug-in was fixed.
The function gaim_unescape_html() was used (oscar.c:4288) to strip HTML
tags before sending ch2 messages.
Doing that, of course, did not work so I changed it to use
gaim_markup_strip_html() .

File Added: shlomi-bidi4.patch

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-24 16:41

Message:
Logged In: YES
user_id=953881
Originator: YES

I investigated implementing the same fix for ICQ protocol only to realized
that it's impossible at least until the ability to send "channel 2"
messages is implemented in Gaim (AKA the 4 years old feature request
#787993). I guess that it's a heavy task since it requires implementing
basic RTF parsing abilities. After we have such ability - it's only a
matter of sending the message with this RTF prefix: '\pard\rtlpar\qr'.

Unfortunately, I also found a problem with the patch - sending a RTL
message to ICQ user will send embedded SPAN tags in the message. Seems like
ICQ's implementation rely on the fact that the message formatting buttons
are disabled when editing a message for ICQ and it doesn't strip the HTML
before sending. This is a minor fix - I'll fix it soon and upload a 4th
version for the patch.

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-06 23:59

Message:
Logged In: YES
user_id=953881
Originator: YES

* Timestamps and Aliases are now encapsulated in their own LRE/RLE Unicode
characters.
* screenshot of fixed timestamps in Gaim:
http://bp2.blogger.com/_40WxAMsyuJQ/Re36uN_jodI/AAAAAAAAAA8/UX592uVRwGk/s400/timestamps.png

Code just got a little more complicated but works great.
Maybe I should try to optimize it somehow. Suggestions/requests are
welcomed.
File Added: shlomi-bidi3.patch

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 03:38

Message:
Logged In: YES
user_id=953881
Originator: YES

Ok, thank you both. Note taken.
I'll see what I can do about the timestamps.

Shlomil.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-03-02 02:40

Message:
Logged In: YES
user_id=156487
Originator: NO

I agree with Sean. As you can see in your second screenshot, the
timestamps don't line up. They should be on the right, with the name after
them (on the left, since we're talking about RTL).

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 01:45

Message:
Logged In: YES
user_id=953881
Originator: YES

Changes in shlomi-bidi2.patch:
* The two spans were unified to a single span tag (as Etan suggested).
* Now text properties are set by inline CSS attributes (<span
style="...">) (also as Etan suggested).
* Need for inline CSS parsing in MSN plug-in made this patch a little more
complicated than the first one.
* gtk_imhtml_get_css_opt() - Function was able to recognized only the
first attribute - now fixed. (But this function is a mess and should be
rewritten IMO)

Tested again talking to MSN Messenger and Gaim and it still works as
expected.

Shlomil.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2007-03-02 01:44

Message:
Logged In: YES
user_id=199625
Originator: NO

I don't speak an rtl language, but it seems like, in the second
screenshot, you'd want the timestamp to be right-aligned, followed by the
screenname, then the message. Like we do it in LTR.

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 01:27

Message:
Logged In: YES
user_id=953881
Originator: YES

File Added: shlomi-bidi2.patch

----------------------------------------------------------------------

Comment By: Shlomi Loubaton (shlomil)
Date: 2007-02-28 08:39

Message:
Logged In: YES
user_id=953881
Originator: YES

After a chat with Etan on IRC, I was suggested to unify the two span tags
into one tag and add the alignment and direction attributes (deprecated
HTML) as CSS properties.
I'll do that and then resubmit my patch.

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2007-02-27 22:40

Message:
Logged In: YES
user_id=28833
Originator: NO

Ethan, do you have time to look at this?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668681&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1694728 ] plug 3 simple leaks

2007-04-04T21:17:03Z

Patches item #1694728, was opened at 2007-04-04 22:17
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1694728&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Andrew Gaul (gaul)
Assigned to: Nobody/Anonymous (nobody)
Summary: plug 3 simple leaks

Initial Comment:
==16165== 4,134 bytes in 1 blocks are definitely lost in loss record 231 of 267
==16165== at 0x4005400: malloc (vg_replace_malloc.c:149)
==16165== by 0x4CC98692: g_try_malloc (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC83BAA: g_file_get_contents (in /lib/libglib-2.0.so.0.1200.9
)
==16165== by 0x4541864: yahoo_set_buddy_icon (yahoo_picture.c:540)
==16165== by 0x453126C: yahoo_login (yahoo.c:2655)
==16165== by 0x404C5D5: gaim_connection_new (connection.c:156)
==16165== by 0x403D16D: gaim_account_connect (account.c:1000)
==16165== by 0x403D453: gaim_accounts_restore_current_statuses (account.c:231
6)
==16165== by 0x80ABAC0: main (gtkmain.c:797)

==29463== 148 bytes in 10 blocks are definitely lost in loss record 135 of 266
==29463== at 0x4005400: malloc (vg_replace_malloc.c:149)
==29463== by 0x4CC98875: g_malloc (in /lib/libglib-2.0.so.0.1200.9)
==29463== by 0x4467623: jabber_parser_element_start_libxml (parser.c:48)
==29463== by 0x4A55AB31: (within /usr/lib/libxml2.so.2.6.27)
==29463== by 0x4A5631BF: xmlParseChunk (in /usr/lib/libxml2.so.2.6.27)
==29463== by 0x4467A6E: jabber_parser_process (parser.c:190)
==29463== by 0x445F486: jabber_recv_cb_ssl (jabber.c:382)
==29463== by 0x4085101: recv_cb (sslconn.c:138)
==29463== by 0x809AFFA: gaim_gtk_io_invoke (gtkeventloop.c:77)
==29463== by 0x4CCBABAC: (within /lib/libglib-2.0.so.0.1200.9)
==29463== by 0x4CC91441: g_main_context_dispatch (in /lib/libglib-2.0.so.0.12
00.9)
==29463== by 0x4CC9441E: (within /lib/libglib-2.0.so.0.1200.9)
==29463== by 0x4CC947C8: g_main_loop_run (in /lib/libglib-2.0.so.0.1200.9)
==29463== by 0x423624B3: gtk_main (in /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==29463== by 0x80B3234: main (gtkmain.c:817)

==16165== 32 bytes in 1 blocks are definitely lost in loss record 70 of 267
==16165== at 0x40054FB: realloc (vg_replace_malloc.c:306)
==16165== by 0x4CC9873A: g_realloc (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CCACF7B: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CCAD4A2: g_string_insert_len (in /lib/libglib-2.0.so.0.1200.9
)
==16165== by 0x4CCAD7F5: g_string_append_len (in /lib/libglib-2.0.so.0.1200.9
)
==16165== by 0x4CC82BAB: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC82DAF: g_build_filename (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4044CAC: gaim_buddy_icons_get_full_path (buddyicon.c:520)
==16165== by 0x44CE133: gaim_ssi_parselist (oscar.c:4976)
==16165== by 0x44BF273: snachandler (family_feedbag.c:1331)
==16165== by 0x44C1E44: flap_connection_recv_cb (flap_connection.c:667)
==16165== by 0x80969C2: gaim_gtk_io_invoke (gtkeventloop.c:77)
==16165== by 0x4CCBABAC: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC91441: g_main_context_dispatch (in /lib/libglib-2.0.so.0.12
00.9)
==16165== by 0x4CC9441E: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC947C8: g_main_loop_run (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x423624B3: gtk_main (in /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16165== by 0x80ABA97: main (gtkmain.c:817)

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1694728&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1694487 ] added RC4 support in cipher.c

2007-04-04T12:55:31Z

Patches item #1694487, was opened at 2007-04-04 13:55
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1694487&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Peterson (uvwarning)
Assigned to: Nobody/Anonymous (nobody)
Summary: added RC4 support in cipher.c

Initial Comment:
RC4 is a fairly common encryption method and will be needed for MySpaceIM authentication, so I have preemptively created this patch as an update to cipher.c and have tested all of the functions. As far as I can tell, everything seems to be working great. (I also have successfully logged in to MySpaceIM with the help of this patch).

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1694487&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1678291 ] fixed 3 BUGS, jabber get usr info crash etc

2007-04-04T05:17:28Z

Patches item #1678291, was opened at 2007-03-11 20:41
Message generated for change (Comment added) made by gnap_an
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1678291&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: segfault
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: George Ang (gnap_an)
Assigned to: Mark Huetsch (markhuetsch)
Summary: fixed 3 BUGS, jabber get usr info crash etc

Initial Comment:
1、crashes when obtaining jabber user info;
2、crashes when sending buddy message using QQ protocol;
3、playing nxn times user leaving chat room sound when opening a QQ
protocol chat room. n equals to the number of users in a QQ chat room.

----------------------------------------------------------------------

>Comment By: George Ang (gnap_an)
Date: 2007-04-04 19:17

Message:
Logged In: YES
user_id=1139767
Originator: YES

Actually,I didn't realy fix the bug in buddy.c.I just hided it :(
I should learn more about glib:)

----------------------------------------------------------------------

Comment By: Mark Huetsch (markhuetsch)
Date: 2007-04-04 12:27

Message:
Logged In: YES
user_id=1529760
Originator: NO

Thanks gnap! I committed the QQ changes. Sorry about the slow response
time.

Are you still experiencing the jabber crash on current SVN? I looked, and
no one has made the change from your patch, and yet I am unable to
reproduce the bug.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1678291&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1678291 ] fixed 3 BUGS, jabber get usr info crash etc

2007-04-03T22:27:34Z

Patches item #1678291, was opened at 2007-03-11 05:41
Message generated for change (Comment added) made by markhuetsch
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1678291&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: segfault
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: George Ang (gnap_an)
Assigned to: Mark Huetsch (markhuetsch)
Summary: fixed 3 BUGS, jabber get usr info crash etc

Initial Comment:
1、crashes when obtaining jabber user info;
2、crashes when sending buddy message using QQ protocol;
3、playing nxn times user leaving chat room sound when opening a QQ
protocol chat room. n equals to the number of users in a QQ chat room.

----------------------------------------------------------------------

>Comment By: Mark Huetsch (markhuetsch)
Date: 2007-04-03 21:27

Message:
Logged In: YES
user_id=1529760
Originator: NO

Thanks gnap! I committed the QQ changes. Sorry about the slow response
time.

Are you still experiencing the jabber crash on current SVN? I looked, and
no one has made the change from your patch, and yet I am unable to
reproduce the bug.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1678291&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1692858 ] SIP/SIMPLE register/auth/message problems with Siemens

2007-04-03T10:15:08Z

Patches item #1692858, was opened at 2007-04-02 08:47
Message generated for change (Settings changed) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1692858&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Chris Brody (cbrody)
Assigned to: Nobody/Anonymous (nobody)
Summary: SIP/SIMPLE register/auth/message problems with Siemens

Initial Comment:
I have encountered several problems when connecting to a Siemens CSCF. I made some quick fixes to get this to work, as shown in the attached diff file.

Unfortunately, I did not yet succeed to get the presence information (PUBLISH) to work with the Siemens CSCF. I will try again at some other point.

So far, I have got the basic registration and a simple MESSAGE to work.

I am now testing some other functionality with the Siemens CSCF for the next 1-2 months. If these problems are fixed and committed before I am done, I will be happy to try the new version as well.

I will try to make a complete list, as concise as I can:

1. The Siemens CSCF uses abbreviated headers, such as l:0 for Content-Length: 0. These abbreviated headers are valid according to RFC 3261, but they are not supported in the current SIMPLE protocol library.

2. simple.c: in the "auth" HTTP Digest authentication (auth->type == 1), upon receiving the WWW-Authenticate:Digest in a challenge response (401 Unauthorized) to the first REGISTER request, the client must put in a CNONCE value, and of course use it in gaim_cipher_http_digest_calculate_session_key() & gaim_cipher_http_digest_calculate_response().

3. simple.c: in addition, the qop ("auth" for Siemens) must be used in gaim_cipher_http_digest_calculate_response().

4. Some of the WWW-Authenticate parameters from the Siemens CSCF are separated by "," only, no space between them. In fill_auth(), the 2nd g_strsplit() function call should be replaced by: parts = g_strsplit_set(hdr, ", ", 0);

5. In send_sip_request(), it is only in the REGISTER message for which the Request URI & authentication URI should have been the same. For others such as MESSAGE, even though the Request URI has the end-username, the auth URI was still sip:servername.

6. To submit a MESSAGE (as well as any other request beyond registration), the Proxy-Authorization: must be included using the authorization from the successful REGISTER transaction. To fix send_sip_request() for MESSAGE, I put the following lines right before if(sip->proxy.type && strcmp(method, "REGISTER")):
if(sip->registrar.type && !strcmp(method, "MESSAGE")) {
buf = auth_header(sip, &sip->registrar, method, auth_uri);
auth = g_strdup_printf("Proxy-Authorization: %s", buf);
g_free(buf);
gaim_debug(GAIM_DEBUG_MISC, "simple", "header %s", auth);
}
else

At this point, my fixes are in rough form. If some fixes are committed, I will be happy to try them again assuming that I still have access.

Thanks,
Chris

----------------------------------------------------------------------

Comment By: Chris Brody (cbrody)
Date: 2007-04-02 08:49

Message:
Logged In: YES
user_id=1757099
Originator: YES

File Added: Siemens-message1.zip

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1692858&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1693706 ] Fix missing buddy icons and custom emoticons on MSN

2007-04-03T09:22:45Z

Patches item #1693706, was opened at 2007-04-03 18:22
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1693706&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Simo Mattila (simom)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix missing buddy icons and custom emoticons on MSN

Initial Comment:
Newer Live Messenger -versions doesn't always send SHA1C-field in msnobj's and so Gaim discards them. This patch accepts them even if SHA1C is missing, and use SHA1D as icon checksum instead of SHA1C.
Fixes bug #1675659.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1693706&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1574238 ] add icq away message to user info window

2007-04-01T18:39:19Z

Patches item #1574238, was opened at 2006-10-09 23:46
Message generated for change (Comment added) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1574238&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Mark Doliner (thekingant)
Summary: add icq away message to user info window

Initial Comment:
icq away message was only showing in blist and tooltip,
this patch adds it to the info window so it can be copy
and pasted.

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2007-04-01 20:39

Message:
Logged In: YES
user_id=20979
Originator: NO

Looks good to me. Sorry it took 6 months.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-04-01 19:13

Message:
Logged In: YES
user_id=159910
Originator: YES

ping rlaager!

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-27 22:39

Message:
Logged In: YES
user_id=159910
Originator: YES

a new version updated with evands' notify_user_info change

File Added: oscar-icq-status-msg.diff

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2006-11-19 02:34

Message:
Logged In: YES
user_id=156487
Originator: NO

At a *quick* glance, this seems reasonable. Mark, thoughts?

Ka-Hing, if there's no response on this in a little while, ping me.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1574238&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1574238 ] add icq away message to user info window

2007-04-01T17:13:47Z

Patches item #1574238, was opened at 2006-10-10 04:46
Message generated for change (Comment added) made by bsponline
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1574238&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Mark Doliner (thekingant)
Summary: add icq away message to user info window

Initial Comment:
icq away message was only showing in blist and tooltip,
this patch adds it to the info window so it can be copy
and pasted.

----------------------------------------------------------------------

>Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-04-02 00:13

Message:
Logged In: YES
user_id=159910
Originator: YES

ping rlaager!

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 03:39

Message:
Logged In: YES
user_id=159910
Originator: YES

a new version updated with evands' notify_user_info change

File Added: oscar-icq-status-msg.diff

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2006-11-19 07:34

Message:
Logged In: YES
user_id=156487
Originator: NO

At a *quick* glance, this seems reasonable. Mark, thoughts?

Ka-Hing, if there's no response on this in a little while, ping me.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1574238&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1692595 ] most prioritized buddy in expanded contact sign off weirdnes

2007-04-01T17:07:38Z

Patches item #1692595, was opened at 2007-04-02 00:07
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1692595&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Nobody/Anonymous (nobody)
Summary: most prioritized buddy in expanded contact sign off weirdnes

Initial Comment:
... because the contact priority is not always invalidated when the blist is updated. I removed the ui update in notify_buddy_status_update() because it doesn't recompute the priority and because the only call path for that function already updates the blist

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1692595&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1621854 ] brings soc-2006-msnp13 up to head

2007-04-01T15:03:43Z

Patches item #1621854, was opened at 2006-12-25 06:36
Message generated for change (Comment added) made by simom
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ka-Hing Cheung (bsponline)
Assigned to: Sean Egan (seanegan)
Summary: brings soc-2006-msnp13 up to head

Initial Comment:
This tarball brings soc-2006-msnp13 up to head. In addition to that it also fixes a crash with sending offline messages.

I wasn't able to generate a diff against that branch, svn seems to insist on diff'ing against HEAD after I run the merge command. After running `svn merge -r 16309:HEAD https://gaim.svn.sourceforge.net/svnroot/gaim/trunk` on the soc-2006-msnp13 you can replace the msn directory with the attached tarball. The fix for offline messaging is on msn.c:901:

if (!session->oim)
session->oim = msn_oim_new(session)

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-04-02 00:03

Message:
Logged In: YES
user_id=1525231
Originator: NO

Couple patches again:
http://koti.mbnet.fi/simom/gaim-msnp13/markup_escape_psm.diff
PSM needs to be escaped, tooltip rendering fails if PSM had '&' in it.

http://koti.mbnet.fi/simom/gaim-msnp13/currentmedia.diff
Support for showing current media of buddies in buddy list. Tooltip shows
both PSM and current media if they are both set, but status line shows only
current media if it is set (official client behaviour). Note: This patch
already includes escaping of PSM, you don't need markup_escape_psm.diff if
you use this.
I know there are bigger problems at the moment than lack of current media
support, but here it is anyway :)

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-16 11:18

Message:
Logged In: YES
user_id=1525231
Originator: NO

Two little patches, first one prevents own account to be added as a buddy
to buddylist, and second fixes tooltip messing with status and PSM.

http://koti.mbnet.fi/simom/gaim-msnp13/own-account-as-buddy.diff
http://koti.mbnet.fi/simom/gaim-msnp13/psm-in-tooltip.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 08:35

Message:
Logged In: YES
user_id=159910
Originator: YES

A little late, but here is a version that should remember your friendly
name. Also has a fix for a crasher when MSN sends you back:

<faultstring>Need to do full sync. Can't sync deltas Client
has too old a copy for us to do a delta sync</faultstring>

In this case, I make gaim re-request the full contact list/address book.

I haven't look too deeply into the reverse list problem, but I think the
solution would involve caching the reverse list, which may require
extending the privacy api.
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-16 05:30

Message:
Logged In: YES
user_id=159910
Originator: YES

Updated the diff with basically no change, except with simom's icon fix.
The previous diff was broken because some of the files were not added

Had to compress it because of sourceforge file size limit
File Added: msn-p13-merge-head.diff.gz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-10 22:39

Message:
Logged In: YES
user_id=159910
Originator: YES

uploaded a diff, this diff is unchanged from the last tarball that I
previously uploaded, except that it's against HEAD. This should be a little
easier for most people.

File Added: msn-p13-merge-head.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-07 09:54

Message:
Logged In: YES
user_id=159910
Originator: YES

Another way is to make a SOAP request whenever the friendly name is set,
and set the friendly name every time you sign on, which doesn't fix the
reverse list problem, but does allow the friendly name to persist. I
already have the first part written.

I apologize if my lack of activity wasted you too much time.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-06 13:22

Message:
Logged In: YES
user_id=1525231
Originator: NO

One way too is to ask full contact list and address book every time
(*Changes=NULL in certain function calls), I tried this too, it works but
logging in takes some more time. It actually fixes reverse list -problem
too, but maybe local caching would still be a better solution as it is
planned to work that way and it reduces bandwidth-usage.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-03-06 09:09

Message:
Logged In: YES
user_id=20979
Originator: NO

Ooh, that's so rockin'

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2007-03-06 09:02

Message:
Logged In: YES
user_id=159910
Originator: YES

I found a way to make the server resend the friendly name every time you
sign on, but I haven't had the time and motivation to finish that.
Hopefully I will find the time to look at your diff this weekend.

----------------------------------------------------------------------

Comment By: Simo Mattila (simom)
Date: 2007-03-05 18:43

Message:
Logged In: YES
user_id=1525231
Originator: NO

I fixed the icons by adding "b->proto_data = user;" to msn_userlist_load()
in userlist.c (see end of the patch), and Friendly name -issue by caching
it to buddylist and using that if it isn't sent by server. This seems to be
necessary as server sends only changes in information since last time.
Maybe same should be done to reverse list, as now for every buddy in my
list i get 'has you: no' in the tooltip. I also prevented own account to be
added to buddy list. Patch against msn.tgz v2 (the one dated 2006-12-30
09:17) can be found in
http://koti.mbnet.fi/simom/gaim-msnp13/msnp13-friendly-name-and-icons.diff

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 20:54

Message:
Logged In: YES
user_id=159910
Originator: YES

I am heading out, but g_return_if_fail(cmd->param_count >= 3) means if the
condition cmd->param_count >= 3 fails, the function would return right
there. So that part is working as expected. I have no idea why sometimes I
get the friendly name and sometimes I don't.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 13:11

Message:
Logged In: YES
user_id=1678429
Originator: NO

The first two connection I receive after last USR TWN command
USR <tid> OK <email> 1 0
USR <tid2> <email> <a number of three blocks
nnnnnnnnnn.nnnnnnnn.nnnnnnnn>
USR <tid2> OK <email> <displayname>

The third time the last USR OK command is:
USR <tid2> OK <email> <email>

I changed nothing in account's setting, I only connected and disconnected
for three time. VERY strange.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 13:02

Message:
Logged In: YES
user_id=1678429
Originator: NO

Uhm... I'm trying your updated version... with a new profile.... The first
connection, it's all ok... it loads for my contact the right friendly name
from server I think because the local alias is different. I disconnected,
then reconnected, it's ok also this time; again I disconnect and then
reconnect, but at this third time... it doesn't load the friendly name, and
all my msn buddies have the same msn icon
http://xs210.xs.to/xs210/06525/screenshot1.png. :|

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 12:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

And also I see now in prp_cmd method of notification.c your mod...
###############
static void
prp_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
MsnSession *session = cmdproc->session;
const char *type, *value;

g_return_if_fail(cmd->param_count >= 3);

type = cmd->params[2];

if (cmd->param_count == 4)
{
value = cmd->params[3];
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, gaim_url_decode(value));
}
else
{
if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
else if (!strcmp(type, "PHM"))
msn_user_set_mobile_phone(session->user, NULL);
else if (!strcmp(type, "MFM")) {
type = cmd->params[1];
gaim_connection_set_display_name(
gaim_account_get_connection(session->account),
gaim_url_decode(cmd->params[2]));
}
}
}
###############################
as third instruction of the void there is
g_return_if_fail(cmd->param_count >= 3);, from whati I understand of this
void, it stop the void procedure if cmd->param_count >= 3.... but after I
see if (cmd->param_count == 4) .... so if it's right the interpretation of
g_return_if_fail the condition that follow never happen! And I also thought
that was incoerent... and so I changed the integer of values.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-30 12:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

I added the if (!strcmp(type, "MFN")) { in sync.c and notification.c
because it figured out in that files the void prp_cmd... and I thought that
was necessary add the parsing of that instruction... that set the nickname.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 09:17

Message:
Logged In: YES
user_id=159910
Originator: YES

new version, fixes some crashes because group_id is char * but in some
places it's set to an int (!). skadotnet, I don't understand why you need
`if (!strcmp(type, "MFN")) {` in so many places, so I didn't include most
of them. I also have different versions of some of your fixes because I
already fixed them.

Group manipulations may still not work, at least it's not crashing :-)

File Added: msn.tgz

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 09:03

Message:
Logged In: YES
user_id=159910
Originator: YES

are you sure that setting the friendly name in msn_notification_post_adl()
is correct?

something is weird, sometimes I get back my own contact information in
contact.c:msn_parse_addressbook(), so I can set the display name there, and
sometimes I don't. It may have something to do with contact list caching.

I will upload a new version soon that fixes lots of compiler warning and
some crashes for group manipulations.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-30 04:38

Message:
Logged In: YES
user_id=159910
Originator: YES

I finally figured out why I couldn't sign on, I was missing a */ so a
large block of code was commented out!

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 17:35

Message:
Logged In: YES
user_id=1678429
Originator: NO

I link directly the patch file....
http://skadotnet.altervista.org/msn.patch

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 17:33

Message:
Logged In: YES
user_id=1678429
Originator: NO

This is the patch file for the first 2 fix, it's not complete because it
need the implementation of the field where save the friendly name, now it
use local alias as first display name. It persists the problem of buddy
icon, I'm sorry but more than this I can't do.
Here the patch:
############################################################################################################################################
diff -uN msn.original/msn.c msn/msn.c
--- msn.original/msn.c 2006-12-25 03:29:57.000000000 +0100
+++ msn/msn.c 2006-12-29 16:11:15.000000000 +0100
@@ -137,9 +137,10 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ if (strlen(alias) > 0)
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
+ else
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s",
gaim_url_encode(gaim_account_get_username(account)));
}

static void
@@ -798,6 +799,9 @@

if (!msn_session_connect(session, host, port, http_method))
gaim_connection_error(gc, _("Failed to connect to server."));
+
+ // Transitional pointment to local alias. Should be the friendly name
saved at every change.
+ gaim_connection_set_display_name(gc, gaim_account_get_alias(account));
}

static void
diff -uN msn.original/notification.c msn/notification.c
--- msn.original/notification.c 2006-12-25 00:52:23.000000000 +0100
+++ msn/notification.c 2006-12-29 16:11:15.000000000 +0100
@@ -235,8 +235,9 @@
/* authenticate OK */
const char *friendly = gaim_url_decode(cmd->params[3]);

- gaim_connection_set_display_name(gc, friendly);
-
+ if (g_ascii_strcasecmp(friendly, "1"))
+ gaim_connection_set_display_name(gc, friendly);
+
msn_session_set_login_step(session, MSN_LOGIN_STEP_SYN);

// msn_cmdproc_send(cmdproc, "SYN", "%s", "0");
@@ -626,6 +627,29 @@
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;
+
+ GaimAccount *account;
+ account = cmdproc->session->account;
+
+ /*
+ * TODO: save somewhere the friendly name in accounts file, when a new
account is created,
+ * or it's set empty or equal to local alias. When a command PRP
MFN is sent through
+ * prp_cmd method in notification.c and sync.c the field in xml
config file is updated.
+ * This is loaded after login with
gaim_connection_set_display_name(GaimConnection *gc, const char *value)
[msn.c:803-804]
+ * so if we connect throught MSNP8 on USR OK command we overwrite
that field,
+ * if the length isn't equal to "1", else if we connect throught
MSNP11 or higher, on USR OK command
+ * we don't overwrite that field because the params is equals to
"1", and throught the command down here
+ * we set for the first time the saved friendly nickname.
+ */
+ const char *friendly;
+ friendly =
gaim_url_encode(gaim_connection_get_display_name(account->gc));
+
+ if (strlen(friendly) <= 0)
+ friendly = gaim_url_encode(gaim_account_get_username(account));
+
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", friendly);
+
+ gaim_debug_info("Ska","Set friendly name as
%s\n",gaim_url_decode(friendly));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
@@ -1025,12 +1049,16 @@

g_return_if_fail(cmd->param_count >= 3);

- type = cmd->params[2];
+ type = cmd->params[1];

- if (cmd->param_count == 4)
+ if (cmd->param_count == 3)
{
- value = cmd->params[3];
- if (!strcmp(type, "PHH"))
+ value = cmd->params[2];
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -1039,7 +1067,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
diff -uN msn.original/sync.c msn/sync.c
--- msn.original/sync.c 2006-12-25 00:17:41.000000000 +0100
+++ msn/sync.c 2006-12-29 16:11:15.000000000 +0100
@@ -64,7 +64,11 @@

if (cmd->param_count == 2)
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, gaim_url_decode(value));
+ gaim_connection_set_display_name(session->account->gc,
gaim_url_decode(value));
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, gaim_url_decode(value));
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, gaim_url_decode(value));
@@ -73,7 +77,11 @@
}
else
{
- if (!strcmp(type, "PHH"))
+ if (!strcmp(type, "MFN")) {
+ msn_user_set_friendly_name(session->user, NULL);
+ gaim_connection_set_display_name(session->account->gc, NULL);
+ }
+ else if (!strcmp(type, "PHH"))
msn_user_set_home_phone(session->user, NULL);
else if (!strcmp(type, "PHW"))
msn_user_set_work_phone(session->user, NULL);
############################################################################################################################################

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 16:05

Message:
Logged In: YES
user_id=1678429
Originator: NO

I'm modifying the fix for second issue, that also set the display name's
field when you open the dialog for set alias manually

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 13:15

Message:
Logged In: YES
user_id=1678429
Originator: NO

There is also another bug.... all my msn buddies have the same msn icon:
this http://xs210.xs.to/xs210/06525/screenshot1.png

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 13:09

Message:
Logged In: YES
user_id=1678429
Originator: NO

I don't see any other way to solve this... when login server send the
command USR Ok, now there isn't the display name that should be stored on
the server....
I've found, I think, the right location to add this command. File
notification.c at line 625.

From:
#####################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
######################################

To:
######################################
void
msn_notification_post_adl(MsnCmdProc *cmdproc,char *payload, int
payload_len)
{
MsnTransaction *trans;

GaimAccount *account;
account = cmdproc->session->account;

msn_cmdproc_send(cmdproc,"PRP","MFN %s",
gaim_url_encode(gaim_account_get_alias(account)));

gaim_debug_info("MaYuan","Send ADL{%s}\n",payload);
trans = msn_transaction_new(cmdproc, "ADL","%d",strlen(payload));
msn_transaction_set_payload(trans, payload, strlen(payload));
msn_cmdproc_send_trans(cmdproc, trans);
}
################################################

with this fix, now the friendly name is set at startup as the local alias
field's value.
For the old MSNP8 is still enabled the parsing of USR OK answer to look
for the display name... but connecting with MSNP13/14 it finds only the
value "1", because server answer with "USR <transid> OK <email-address> 1
0\r\n". The old parser get the fourth parameter... that now is "1", and set
it as friendly name... but then arrives another USR OK answer that
containst at fourth parameter again the email address, and again it set the
friendly name with the email address.
Using this fix, before the second USR OK answer it set the friendly name
so the second USR OK answer arrives as the old format "USR <transid> OK
<email-address> <friendly-name> 0\r\n".

There are other things to do, because, now it set the local alias, and
when you want manually change the friendly name through the dialog, the
value of textbox is "1", I don't know why.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-29 01:02

Message:
Logged In: YES
user_id=159910
Originator: YES

ya, I thought about that, but then with MSNP8 you can use your friendly
name that you set from elsewhere, with this it means you can't

anyway, I still need to fix the logon issue before I can do any meaningful
work again.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-29 00:40

Message:
Logged In: YES
user_id=1678429
Originator: NO

For the second "bug", from what I could see from the code, and from
msnpiki, it's a change of commands of the protocol. Before the friendly
name ad login was recieved form USR command, but now as says
http://msnpiki.msnfanatic.com/index.php/MSNP13:Example_Session#Updating_Display_Name
after ADL command we need to send a fisrt PRP command to set the friendly
name, so we need to save somewhere the nickname.
A solution could be use the config file to save this parameter, when the
account is created this field is sat as alias field; then ad after sending
ADL command to get the contact list, send the first PRP MFN, to set first
the nickname with param the value of friendlyname field; and also add a
command to save the friendly nickname's value in the setting file, when is
modified manually throught the dialog.

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 21:21

Message:
Logged In: YES
user_id=159910
Originator: YES

actually I _thought_ I fixed the 2nd issue, turns out now I can't log in
anymore :-/ reverting to old gaim code works though, will figure it out
later tonight.

feel free to take a shot

----------------------------------------------------------------------

Comment By: Ka-Hing Cheung (bsponline)
Date: 2006-12-28 20:46

Message:
Logged In: YES
user_id=159910
Originator: YES

I actually have those 2 fixed already, nice job though.

----------------------------------------------------------------------

Comment By: Michele Scandale (skadotnet)
Date: 2006-12-28 19:34

Message:
Logged In: YES
user_id=1678429
Originator: NO

I've tried the patch winth gaim svn... it works but there are some
problems with the friendly nickname... when I try to set the nickname, it
disconnect from msn. I've corrected this problem using the new msn command
to set nickname, instead of the obsolate one.

###################################################################
--- msn.c.original 2006-12-28 18:30:12.000000000 +0100
+++ msn.c 2006-12-28 18:30:34.000000000 +0100
@@ -137,9 +137,7 @@
return;
}

- msn_cmdproc_send(cmdproc, "REA", "%s %s",
- gaim_account_get_username(account),
- alias);
+ msn_cmdproc_send(cmdproc, "PRP", "MFN %s", alias);
}

static void
#########################################################################

Now I'm going to solve the missed nickname's update on connect.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1621854&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1684297 ] GAIM crashes on Buddy Get Info (Jabber protocol)

2007-04-01T12:59:21Z

Patches item #1684297, was opened at 2007-03-20 08:30
Message generated for change (Comment added) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1684297&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: segfault
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Atamyrat Hezretguliyev (myhat)
Assigned to: Nobody/Anonymous (nobody)
Summary: GAIM crashes on Buddy Get Info (Jabber protocol)

Initial Comment:
This patch fixes a bug in buddy.c, jabber_buddy_remove_id function.
l->data is accessed after l is freed, which crashes GAIM.

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2007-04-01 14:59

Message:
Logged In: YES
user_id=20979
Originator: NO

Cool, thanks

----------------------------------------------------------------------

Comment By: Atamyrat Hezretguliyev (myhat)
Date: 2007-03-20 08:39

Message:
Logged In: YES
user_id=1125672
Originator: YES

Fixes this bug
http://sourceforge.net/tracker/index.php?func=detail&aid=1676403&group_id=235&atid=100235

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1684297&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1692248 ] plug gtkblist.c memory leaks and code cleanup

2007-04-01T11:46:45Z

Patches item #1692248, was opened at 2007-04-01 02:56
Message generated for change (Comment added) made by gaul
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1692248&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Andrew Gaul (gaul)
Assigned to: Nobody/Anonymous (nobody)
Summary: plug gtkblist.c memory leaks and code cleanup

Initial Comment:
Plug two memory leaks found by Valgrind in gtkblist.c and clean up code a little.

==16170== 392 bytes in 7 blocks are definitely lost in loss record 130 of 210
==16170== at 0x4005400: malloc (vg_replace_malloc.c:149)
==16170== by 0x4D5019FF: (within /usr/lib/libXcursor.so.1.0.2)
==16170== by 0x4D502205: (within /usr/lib/libXcursor.so.1.0.2)
==16170== by 0x4D502C51: XcursorXcFileLoadImages (in /usr/lib/libXcursor.so.1
.0.2)
==16170== by 0x4D502D6A: XcursorFileLoadImages (in /usr/lib/libXcursor.so.1.0
.2)
==16170== by 0x4D503660: XcursorLibraryLoadImages (in /usr/lib/libXcursor.so.
1.0.2)
==16170== by 0x4D5036DA: XcursorShapeLoadImages (in /usr/lib/libXcursor.so.1.
0.2)
==16170== by 0x4D504012: XcursorTryShapeCursor (in /usr/lib/libXcursor.so.1.0
.2)
==16170== by 0x4D2D1C21: XCreateGlyphCursor (in /usr/lib/libX11.so.6.2.0)
==16170== by 0x4D2D20AC: XCreateFontCursor (in /usr/lib/libX11.so.6.2.0)
==16170== by 0x421D9271: gdk_cursor_new_for_display (in /usr/lib/libgdk-x11-2
.0.so.0.1000.8)
==16170== by 0x421B8A99: gdk_cursor_new (in /usr/lib/libgdk-x11-2.0.so.0.1000
.8)
==16170== by 0x80CF05D: setup_icon_box (gtkstatusbox.c:345)
==16170== by 0x4CD13E00: g_object_newv (in /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x4CD147A7: g_object_new_valist (in /lib/libgobject-2.0.so.0.120
0.9)
==16170== by 0x4CD148AF: g_object_new (in /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x80CB98A: gtk_gaim_status_box_new (gtkstatusbox.c:1814)
==16170== by 0x8078A70: gaim_gtk_blist_show (gtkblist.c:4359)
==16170== by 0x403F6CC: gaim_blist_show (blist.c:702)
==16170== by 0x80AB951: main (gtkmain.c:763)

==16170== 35,008 (10,752 direct, 24,256 indirect) bytes in 42 blocks are definit
ely lost in loss record 198 of 210
==16170== at 0x40054FB: realloc (vg_replace_malloc.c:306)
==16170== by 0x49CF7E13: (within /usr/lib/libfontconfig.so.1.1.0)
==16170== by 0x49CF87E3: (within /usr/lib/libfontconfig.so.1.1.0)
==16170== by 0x49CF8CDB: (within /usr/lib/libfontconfig.so.1.1.0)
==16170== by 0x49CF53F2: FcFontRenderPrepare (in /usr/lib/libfontconfig.so.1.
1.0)
==16170== by 0x425E6CB8: (within /usr/lib/libpangoft2-1.0.so.0.1400.10)
==16170== by 0x42622D8F: pango_font_map_load_fontset (in /usr/lib/libpango-1.
0.so.0.1400.10)
==16170== by 0x425E6FC4: (within /usr/lib/libpangoft2-1.0.so.0.1400.10)
==16170== by 0x42622E18: pango_font_map_load_font (in /usr/lib/libpango-1.0.s
o.0.1400.10)
==16170== by 0x426212F8: pango_context_load_font (in /usr/lib/libpango-1.0.so
.0.1400.10)
==16170== by 0x42626F55: pango_layout_line_get_extents (in /usr/lib/libpango-
1.0.so.0.1400.10)
==16170== by 0x4262725E: (within /usr/lib/libpango-1.0.so.0.1400.10)
==16170== by 0x42629DB4: (within /usr/lib/libpango-1.0.so.0.1400.10)
==16170== by 0x42411EB2: gtk_text_layout_get_line_display (in /usr/lib/libgtk
-x11-2.0.so.0.1000.8)
==16170== by 0x42415008: (within /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16170== by 0x4241007E: gtk_text_layout_wrap (in /usr/lib/libgtk-x11-2.0.so.
0.1000.8)
==16170== by 0x423F3F78: (within /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16170== by 0x42413EEA: gtk_text_layout_validate_yrange (in /usr/lib/libgtk-
x11-2.0.so.0.1000.8)
==16170== by 0x42420ADC: (within /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16170== by 0x42420B7D: (within /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16170== by 0x4236509C: (within /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16170== by 0x4CD0D588: (within /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x4CD0ED9A: g_closure_invoke (in /lib/libgobject-2.0.so.0.1200.9
)
==16170== by 0x4CD1FA82: (within /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x4CD20956: g_signal_emit_valist (in /lib/libgobject-2.0.so.0.12
00.9)
==16170== by 0x4CD20B18: g_signal_emit (in /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x424807EE: gtk_widget_set_scroll_adjustments (in /usr/lib/libgt
k-x11-2.0.so.0.1000.8)
==16170== by 0x423C0AB0: (within /usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16170== by 0x4CD1B608: g_cclosure_marshal_VOID__OBJECT (in /lib/libgobject-
2.0.so.0.1200.9)
==16170== by 0x4CD0D588: (within /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x4CD0ED9A: g_closure_invoke (in /lib/libgobject-2.0.so.0.1200.9
)
==16170== by 0x4CD1F8C9: (within /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x4CD20956: g_signal_emit_valist (in /lib/libgobject-2.0.so.0.12
00.9)
==16170== by 0x4CD20B18: g_signal_emit (in /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x422D1E7B: gtk_container_add (in /usr/lib/libgtk-x11-2.0.so.0.1
000.8)
==16170== by 0x80D649A: gaim_gtk_create_imhtml (gtkutils.c:154)
==16170== by 0x80CD1E0: gtk_gaim_status_box_init (gtkstatusbox.c:1601)
==16170== by 0x4CD2E6FB: g_type_create_instance (in /lib/libgobject-2.0.so.0.
1200.9)
==16170== by 0x4CD15F41: (within /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x4CD13B9A: g_object_newv (in /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x4CD147A7: g_object_new_valist (in /lib/libgobject-2.0.so.0.120
0.9)
==16170== by 0x4CD148AF: g_object_new (in /lib/libgobject-2.0.so.0.1200.9)
==16170== by 0x80CB98A: gtk_gaim_status_box_new (gtkstatusbox.c:1814)
==16170== by 0x8078A70: gaim_gtk_blist_show (gtkblist.c:4359)
==16170== by 0x403F6CC: gaim_blist_show (blist.c:702)
==16170== by 0x80AB951: main (gtkmain.c:763)

----------------------------------------------------------------------

>Comment By: Andrew Gaul (gaul)
Date: 2007-04-01 12:46

Message:
Logged In: YES
user_id=139865
Originator: YES

Pasted the same leak twice, here is the correct second leak:

==16165== 667 bytes in 45 blocks are definitely lost in loss record 185 of
267
==16165== at 0x4005400: malloc (vg_replace_malloc.c:149)
==16165== by 0x4CC98875: g_malloc (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CCABED8: g_strdup (in /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x8075E37: buddy_node (gtkblist.c:3288)
==16165== by 0x80762AB: gaim_gtk_blist_update_contact
(gtkblist.c:4882)
==16165== by 0x8076312: gaim_gtk_blist_update_buddy (gtkblist.c:4910)
==16165== by 0x8076525: gaim_gtk_blist_update (gtkblist.c:4986)
==16165== by 0x40778EF: gaim_presence_set_idle (status.c:1331)
==16165== by 0x406C417: gaim_prpl_got_user_idle (prpl.c:98)
==16165== by 0x45318FB: yahoo_update_status (yahoo.c:176)
==16165== by 0x4531F6F: yahoo_process_status (yahoo.c:228)
==16165== by 0x453758E: yahoo_packet_process (yahoo.c:1055)
==16165== by 0x4538B06: yahoo_pending (yahoo.c:2333)
==16165== by 0x80969C2: gaim_gtk_io_invoke (gtkeventloop.c:77)
==16165== by 0x4CCBABAC: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC91441: g_main_context_dispatch (in
/lib/libglib-2.0.so.0.12
00.9)
==16165== by 0x4CC9441E: (within /lib/libglib-2.0.so.0.1200.9)
==16165== by 0x4CC947C8: g_main_loop_run (in
/lib/libglib-2.0.so.0.1200.9)
==16165== by 0x423624B3: gtk_main (in
/usr/lib/libgtk-x11-2.0.so.0.1000.8)
==16165== by 0x80ABA97: main (gtkmain.c:817)

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1692248&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches

[Gaim-patches] [ gaim-Patches-1691784 ] Patch to fix SVN 18222

2007-04-01T11:38:09Z

Patches item #1691784, was opened at 2007-03-31 02:03
Message generated for change (Comment added) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1691784&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 6
Private: No
Submitted By: William Ehlhardt (orborde)
Assigned to: Sadrul Habib Chowdhury (sadrul)
Summary: Patch to fix SVN 18222

Initial Comment:
Fixes a build-breaker introduced in SVN r18220.

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2007-04-01 13:38

Message:
Logged In: YES
user_id=20979
Originator: NO

Applied, thanks. For some reason my build compiled without this change...
but that might be operating system dependent or something.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1691784&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@...
https://lists.sourceforge.net/lists/listinfo/gaim-patches