Generator specs/matchers broken

View: New views
1 Messages — Rating Filter:   Alert me  

Generator specs/matchers broken

by Travis D Warlick Jr :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


While I was working on writing specs for my implementation of radiant  
instance generation templates, I realized that many of my specs  
weren't running.  I went looking at the matchers, and I realized the  
blocks weren't going to the right places... The have_generated_*  
methods were taking blocks; however, simple matchers do not take  
blocks since the .should method passes the block directly to the  
matcher.matches? methods.  It very well may be that these worked once  
upon a time but were broken by updates to Rspec.

Since just about every have_generated_* method was taking blocks, the  
generator_matchers.rb file had to be almost completely refactored to  
preserve the original intent.  And, in the process of refactoring, I  
discovered some specs that were either out of date or broken.  I've  
fixed these issues as well.

Please take a look my master branch (github.com/tekwiz/radiant) to see  
the changes I've made and consider pulling them into the core (I have  
made a pull request) and your personal forks of radiant if you are  
considering working on or have have made changes to any generators.

--
     Travis D Warlick, Jr
     Lead Developer -- Operis Systems


--~--~---------~--~----~------------~-------~--~----~
Radiant CMS Dev Mailing List
Post:        radiantcms-dev@...
Unsubscribe: radiantcms-dev-unsubscribe@...
Group Site:  http://groups.google.com/group/radiantcms-dev/
-~----------~----~----~----~------~----~------~--~---