Gianny's going to kill me :-)

View: New views
3 Messages — Rating Filter:   Alert me  

Gianny's going to kill me :-)

by Jules Gosnell-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Gianny,

Last night, I figured out how to break the circular test-time dependency
between backend-dispatcher-core....

maven supports an extra artefact type - test-jar.
You can generate one of these which contains all test classes for a
given module. Then you can make other modules depend upon it...

dispatcher and core now generate these jars which are consumed by the
backends so that they may run generic tests that are written in
dispatcher and core on the InVM stuff, but may be overridden in each
backend with a specific dispatcher for that backend.

As a result, we get coverage recorded for the same test in both backend
but also dispatcher and core :-)

This raises our coverage by about 8% - and a few of the tests are
disabled... so I expect that it will be better than that - we are now
riding at about 38-39%... - I am rebuilding the website as we speak.

If you want to rename the tests or shuffle their packages around a bit,
feel free - but they need to stay in their current module to maintain
correct coverage...

I considered using itests - but I could see no way that doing this would
allow us to capture coverage in anywhere but the itests module... -
hence my current approach - I think that it is the only way... :-(



Jules

--
"Open Source is a self-assembling organism. You dangle a piece of
string into a super-saturated solution and a whole operating-system
crystallises out around it."

/**********************************
 * Jules Gosnell
 * Partner
 * Core Developers Network (Europe)
 *
 *    www.coredevelopers.net
 *
 * Open Source Training & Support.
 **********************************/


Re: Gianny's going to kill me :-)

by Gianny Damour-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I actually think that this is a good change :-). After second thought,
it seems to be a better approach than the previous situation.

Thanks,
Gianny

Jules Gosnell wrote:

>
> Gianny,
>
> Last night, I figured out how to break the circular test-time
> dependency between backend-dispatcher-core....
>
> maven supports an extra artefact type - test-jar.
> You can generate one of these which contains all test classes for a
> given module. Then you can make other modules depend upon it...
>
> dispatcher and core now generate these jars which are consumed by the
> backends so that they may run generic tests that are written in
> dispatcher and core on the InVM stuff, but may be overridden in each
> backend with a specific dispatcher for that backend.
>
> As a result, we get coverage recorded for the same test in both
> backend but also dispatcher and core :-)
>
> This raises our coverage by about 8% - and a few of the tests are
> disabled... so I expect that it will be better than that - we are now
> riding at about 38-39%... - I am rebuilding the website as we speak.
>
> If you want to rename the tests or shuffle their packages around a
> bit, feel free - but they need to stay in their current module to
> maintain correct coverage...
>
> I considered using itests - but I could see no way that doing this
> would allow us to capture coverage in anywhere but the itests
> module... - hence my current approach - I think that it is the only
> way... :-(
>
>
>
> Jules
>



Re: Gianny's going to kill me :-)

by Jules Gosnell-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Gianny Damour wrote:

> I actually think that this is a good change :-). After second thought,
> it seems to be a better approach than the previous situation.

excellent - glad that you agree :-)

Jules

>
> Thanks,
> Gianny
>
> Jules Gosnell wrote:
>
>>
>> Gianny,
>>
>> Last night, I figured out how to break the circular test-time
>> dependency between backend-dispatcher-core....
>>
>> maven supports an extra artefact type - test-jar.
>> You can generate one of these which contains all test classes for a
>> given module. Then you can make other modules depend upon it...
>>
>> dispatcher and core now generate these jars which are consumed by the
>> backends so that they may run generic tests that are written in
>> dispatcher and core on the InVM stuff, but may be overridden in each
>> backend with a specific dispatcher for that backend.
>>
>> As a result, we get coverage recorded for the same test in both
>> backend but also dispatcher and core :-)
>>
>> This raises our coverage by about 8% - and a few of the tests are
>> disabled... so I expect that it will be better than that - we are now
>> riding at about 38-39%... - I am rebuilding the website as we speak.
>>
>> If you want to rename the tests or shuffle their packages around a
>> bit, feel free - but they need to stay in their current module to
>> maintain correct coverage...
>>
>> I considered using itests - but I could see no way that doing this
>> would allow us to capture coverage in anywhere but the itests
>> module... - hence my current approach - I think that it is the only
>> way... :-(
>>
>>
>>
>> Jules
>>
>
>


--
"Open Source is a self-assembling organism. You dangle a piece of
string into a super-saturated solution and a whole operating-system
crystallises out around it."

/**********************************
 * Jules Gosnell
 * Partner
 * Core Developers Network (Europe)
 *
 *    www.coredevelopers.net
 *
 * Open Source Training & Support.
 **********************************/