Git issues with Evince repository?

[Wouter Bolsterlee-3]

Hey all,

I'm having issues with Evince's git repository. It's quite likely I just
don't understand how Git works (this was the first time I tried to use
git — usually I use bzr or svn), though I exactly followed the
instructions on the Gnome wiki page:
http://live.gnome.org/Git/Developers

I think I committed and pushed a revision (minor docs change) using "git
commit -a" and "git push", so I expected to see my changes turning up on
git.gnome.org. However, http://git.gnome.org/cgit/evince/tree/ shows
really ancient files (it says evince-0-1 at the top right drop down
box!), and the page at http://git.gnome.org/cgit/evince/?h=master says
"Invalid branch: master".

For other projects this seems to work fine, e.g.
http://git.gnome.org/cgit/gtk+/?h=master shows me what I expect to see.

Any clue what I did wrong?

    — Wouter


_______________________________________________
Evince-list mailing list
Evince-list@...
http://mail.gnome.org/mailman/listinfo/evince-list

[Juanjo Marin]

El mar, 06-10-2009 a las 21:57 +0200, Wouter Bolsterlee escribió:
> For other projects this seems to work fine, e.g.
> http://git.gnome.org/cgit/gtk+/?h=master shows me what I expect to see.
>
> Any clue what I did wrong?

I asked for help on IRC and Owen Taylor kindly debugged it. It seems to
be a permission problem and the setting of the umask in your bashrc
caused the problem. You have umask '077', but you should use the default
value (Debian-based distros uses '022' and Red Hat/SUSE distros uses
'002')

So your git commands were correct, but not your configuration.

Now everything is OK.

Be sure to change it before doing another push :)


Cheers,

   -- Juanjo Marín

_______________________________________________
Evince-list mailing list
Evince-list@...
http://mail.gnome.org/mailman/listinfo/evince-list

[Wouter Bolsterlee-2]

Op dinsdag 06-10-2009 om 23:57 uur [tijdzone +0200], schreef Juanjo
Marin:
> I asked for help on IRC and Owen Taylor kindly debugged it. It seems to
> be a permission problem and the setting of the umask in your bashrc
> caused the problem. You have umask '077', but you should use the default
> value (Debian-based distros uses '022' and Red Hat/SUSE distros uses
> '002')

Hi Juanjo,

Thanks for looking into it, and fixing the problem.

However, it makes me really, really, no, seriously, I mean, *really* sad
that a client side umask [1] causes Git repository corruption on the
Gnome infrastructure. I expected Gnome's version control tools to be
*slightly* less sucking before they were put into production use for a
large and important project such as Gnome.

    — Wouter (no, this is not a flame bait)

[1] My umask is 077 for a reason. I don't want others to be able to read
my files by default. That's a very valid reason, and I'm not going to
change it.


_______________________________________________
Evince-list mailing list
Evince-list@...
http://mail.gnome.org/mailman/listinfo/evince-list

[Juanjo Marin]

El mié, 07-10-2009 a las 19:20 +0200, Wouter Bolsterlee escribió:

> Thanks for looking into it, and fixing the problem.

Don't mention it :)

> However, it makes me really, really, no, seriously, I mean, *really* sad
> that a client side umask [1] causes Git repository corruption on the
> Gnome infrastructure. I expected Gnome's version control tools to be
> *slightly* less sucking before they were put into production use for a
> large and important project such as Gnome.
> [1] My umask is 077 for a reason. I don't want others to be able to read
> my files by default. That's a very valid reason, and I'm not going to
> change it.

I totally understand your point. I've done some researching and I think
changing the core.sharedRepository on .git/config is a good solution.

I think KaL have some experience with git, so I left this to KaL or any
other git-savyy user from the list.

-- Juanjo



 


_______________________________________________
Evince-list mailing list
Evince-list@...
http://mail.gnome.org/mailman/listinfo/evince-list

[Juanjo Marin]

Hi,

I was talking on IRC about this issue with Owen Taylor and the
configuration is OK, I mean, they are using core.sharedRepository. If
you do a

git config --get core.sharedRepository

it gives 1. This value is equivalent to setting core.sharedRepository to
group:

http://git.kernel.org/?p=git/git.git;a=blob;f=setup.c;h=029371e5844a1069d62456c6bb51028efbb671c4;hb=HEAD#l411

Anyway, he added something to the wrapper script to reset the umask.

Wouter, If you have more issues you can contact Owen Taylor for fixing
it (he is on #sysadmin or #gnome-hacker most most all the time)

Cheers,

   -- Juanjo Marín


El mié, 07-10-2009 a las 23:12 +0200, Juanjo Marin escribió:

>  I've done some researching and I think
> changing the core.sharedRepository on .git/config is a good solution.
>
> I think KaL have some experience with git, so I left this to KaL or any
> other git-savyy user from the list.
>
> -- Juanjo
>
> _______________________________________________
> Evince-list mailing list
> Evince-list@...
> http://mail.gnome.org/mailman/listinfo/evince-list

_______________________________________________
Evince-list mailing list
Evince-list@...
http://mail.gnome.org/mailman/listinfo/evince-list