Nabble - GlazedLists - Dev

Re: IllegalStateException when sorting via table headers

2009-11-15T05:03:24Z

JohnPM wrote:

I am getting java.lang.IllegalStateException: Cannot combine reorder with other change events when sorting a list via the table headers. I found an old post with this problem, which implied it was resolved by avoiding accessing the list selection model, but I'm not clear how I can use the list if I don't use the selection model! The exception appears to be trigggered by processing of a ListSelectionEvent, i.e.

public void valueChanged(ListSelectionEvent lse){
if (lse.getSource() == myListSelectionModel){
if (!lse.getValueIsAdjusting()){
/** React to changes in the selected entries */
selectedEntries = myListSelectionModel.getSelected();
}
}
}

If I comment out the access to getSelected() the exception no longer occurs, but of course I then do not get the selected entries. Any idea how I resolve this? I have tried the latest dev build and it has the same behaviour.

Problem solved - another event processing path was (wrongly) triggering a clearSelection().

Using EventList with JTree

2009-11-14T23:53:47Z

Hi all,

I've tried to use the TreeList with Jtree.
To the bean which i use in the TreeList (the base class of the list) , i added a BeanChange Support(Like in the screencast example).

The problem is : when i change a property (and fire an appropriate event through the bean change support) the tree get a structure change event , and i'm intersted in a smaller change in the tree (like node change ) . Another problem: it doesnt react to the expanding policy.

This all seems to work great with a TreeTable .

My conclusion is that it is not supported by Jtree, am I Right?

If the answear is yes, what should i do to add support for this feature?

Thanks,
Gal

IllegalStateException when sorting via table headers

2009-11-14T16:15:59Z

I am getting java.lang.IllegalStateException: Cannot combine reorder with other change events when sorting a list via the table headers. I found an old post with this problem, which implied it was resolved by avoiding accessing the list selection model, but I'm not clear how I can use the list if I don't use the selection model! The exception appears to be trigggered by processing of a ListSelectionEvent, i.e.

public void valueChanged(ListSelectionEvent lse){
if (lse.getSource() == myListSelectionModel){
if (!lse.getValueIsAdjusting()){
/** React to changes in the selected entries */
selectedEntries = myListSelectionModel.getSelected();
}
}
}

If I comment out the access to getSelected() the exception no longer occurs, but of course I then do not get the selected entries. Any idea how I resolve this? I have tried the latest dev build and it has the same behaviour.

Edit: Here are the exception details:

Exception in thread "AWT-EventQueue-0" java.lang.IllegalStateException: Cannot combine reorder with other change events
at ca.odell.glazedlists.event.ListEventAssembler.reorder(ListEventAssembler.java:246)
at ca.odell.glazedlists.ListSelection.addSelectedReorder(ListSelection.java:852)
at ca.odell.glazedlists.ListSelection.listChanged(ListSelection.java:172)
at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:412)
at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:409)
at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher$SubjectAndListener.firePendingEvent(SequenceDependenciesEventPublisher.java:445)
at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher.fireEvent(SequenceDependenciesEventPublisher.java:344)
at ca.odell.glazedlists.event.ListEventAssembler.commitEvent(ListEventAssembler.java:316)
at ca.odell.glazedlists.SortedList.setComparator(SortedList.java:478)
at ca.odell.glazedlists.gui.AbstractTableComparatorChooser.rebuildComparator(AbstractTableComparatorChooser.java:154)
at ca.odell.glazedlists.swing.TableComparatorChooser.rebuildComparator(TableComparatorChooser.java:295)
at ca.odell.glazedlists.gui.AbstractTableComparatorChooser$SortingStateListener.propertyChange(AbstractTableComparatorChooser.java:140)
at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:339)
at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:276)
at ca.odell.glazedlists.impl.gui.SortingState.fireSortingChanged(SortingState.java:67)
at ca.odell.glazedlists.impl.gui.MouseOnlySortingStrategy.columnClicked(MouseOnlySortingStrategy.java:65)
at ca.odell.glazedlists.swing.TableComparatorChooser$HeaderClickHandler.mouseClicked(TableComparatorChooser.java:568)
at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:253)
at java.awt.Component.processMouseEvent(Component.java:6266)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
at java.awt.Component.processEvent(Component.java:6028)
at java.awt.Container.processEvent(Container.java:2041)
at java.awt.Component.dispatchEventImpl(Component.java:4630)
at java.awt.Container.dispatchEventImpl(Container.java:2099)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4247)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
at java.awt.Container.dispatchEventImpl(Container.java:2085)
at java.awt.Window.dispatchEventImpl(Window.java:2475)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Re: Problem with class listening to different EventLists

2009-11-03T16:58:10Z

My educated guess tells me you're getting the wrong list because List.equals() considers the equality and order of elements. So event.getSourceList() will match the FIRST list from dataManager that contains the SAME kinds of elements.

if (event.getSourceList().equals(dataManager.getListA())){

handleFsrListEvent(event);
}else if (event.getSource().equals(dataManager.getListB())){
handleFsrFunctionListEvent(event);
}else if (event.getSource().equals(dataManager.getListC())){
handleElementListEvent(event);
}

If you like your design and want to keep it that way, consider switching to identity equals if you know the Lists in question are precisely equal:

if (event.getSourceList() == dataManager.getListA()){

handleFsrListEvent(event);
}else if (event.getSource() == dataManager.getListB()){
handleFsrFunctionListEvent(event);
}else if (event.getSource() == dataManager.getListC()){
handleElementListEvent(event);
}

otherwise I'm uncertain of how you'll be to make that code work reliably.

James

On Tue, Nov 3, 2009 at 5:58 AM, Fritz Richter <fritz@...> wrote:

Hi together,
I've got a component which must listen to different eventLists.
It is not possible to implement the ListEventListener typed via generics interface more than once.
Therefore I added just one method (without generics), ask the event for the eventListSource, compare it to the different eventLists and call specific methods which handle the specific events.

If my if-clause says that the eventListSource is the eventList A than I call handleAEvent(...) method. In this method I try to retrieve the object either via event.getOldObject or via getIndex and get(index). My problem is, that sometimes i get objects of other lists...

Is my problem described clearly? Can anyone help me?
Here a code snipped...

dataManager.getFsrs().addListEventListener(this);
dataManager.getFsrFunctions().addListEventListener(this);
dataManager.getElements().addListEventListener(this);
...

public void listChanged(ListEvent event) {
//Iterate through all list changes
while (event.hasNext()) {
event.next(); //get the next change event
if (event.getSourceList().equals(dataManager.getListA())){
handleFsrListEvent(event);
}else if (event.getSource().equals(dataManager.getListB())){
handleFsrFunctionListEvent(event);
}else if (event.getSource().equals(dataManager.getListC())){
handleElementListEvent(event);
}
}
}

...

private void handleFunctionListEvent(ListEvent<Function> event) {
if (event.getType() == ListEvent.INSERT){
Function function = event.getSourceList().get(event.getIndex());
ElementRow<Function> functionRow = new ElementRow<Function>(function);
ElementRow parentRow = findRow(function.getElement());
addRow(parentRow, functionRow);
} else if (event.getType() == ListEvent.DELETE){
Function function = event.getOldValue();
//SOMETIMES HERE I GOT OTHER VALUES THAN FUNCTIONS...
Row row = findRow(function);
removeRow(row);
}
}

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: Problem with class listening to different EventLists

2009-11-03T06:32:20Z

What are you trying to do? I think you have to refactor at some greater scope in your code.
Can't you divide the Handlers for the ListEvents in different classes?

fabian

fritzr wrote:

Hi together,
I've got a component which must listen to different eventLists.
It is not possible to implement the ListEventListener typed via generics interface more than once.
Therefore I added just one method (without generics), ask the event for the eventListSource, compare it to the different eventLists and call specific methods which handle the specific events.

If my if-clause says that the eventListSource is the eventList A than I call handleAEvent(...) method. In this method I try to retrieve the object either via event.getOldObject or via getIndex and get(index). My problem is, that sometimes i get objects of other lists...

Is my problem described clearly? Can anyone help me?
Here a code snipped...

dataManager.getFsrs().addListEventListener(this);
dataManager.getFsrFunctions().addListEventListener(this);
dataManager.getElements().addListEventListener(this);
...

public void listChanged(ListEvent event) {
//Iterate through all list changes
while (event.hasNext()) {
event.next(); //get the next change event
if (event.getSourceList().equals(dataManager.getListA())){
handleFsrListEvent(event);
}else if (event.getSource().equals(dataManager.getListB())){
handleFsrFunctionListEvent(event);
}else if (event.getSource().equals(dataManager.getListC())){
handleElementListEvent(event);
}
}
}

...

private void handleFunctionListEvent(ListEvent<Function> event) {
if (event.getType() == ListEvent.INSERT){
Function function = event.getSourceList().get(event.getIndex());
ElementRow<Function> functionRow = new ElementRow<Function>(function);
ElementRow parentRow = findRow(function.getElement());
addRow(parentRow, functionRow);
} else if (event.getType() == ListEvent.DELETE){
Function function = event.getOldValue();
//SOMETIMES HERE I GOT OTHER VALUES THAN FUNCTIONS...
Row row = findRow(function);
removeRow(row);
}
}

Re: Problem with class listening to different EventLists

2009-11-03T06:02:32Z

Just a quick reply, possibly w/o any help!

Is your equals-method working for sure?

You could user inner classes for the problem you have, instead of doing this more hackish "routing"-stuff you do. Either anonymous classes, like directly in the code do 'new ListEventListener<Type>() { .. body ..}', or make inner classes (possibly "non-static", so that they have direct access to the enclosing class).

Kind regards,

Endre.

On Tue, Nov 3, 2009 at 14:55, fritzr <fritz@...> wrote:

Hi together,
I've got a component which must listen to different eventLists.
It is not possible to implement the ListEventListener typed via generics
interface more than once.
Therefore I added just one method (without generics), ask the event for the
eventListSource, compare it to the different eventLists and call specific
methods which handle the specific events.

If my if-clause says that the eventListSource is the eventList A than I call
handleAEvent(...) method. In this method I try to retrieve the object either
via event.getOldObject or via getIndex and get(index). My problem is, that
sometimes i get objects of other lists...

Is my problem described clearly? Can anyone help me?
Here a code snipped...

dataManager.getFsrs().addListEventListener(this);
dataManager.getFsrFunctions().addListEventListener(this);
dataManager.getElements().addListEventListener(this);
...

public void listChanged(ListEvent event) {
//Iterate through all list changes
while (event.hasNext()) {
event.next(); //get the next change event
if (event.getSourceList().equals(dataManager.getListA())){
handleFsrListEvent(event);
}else if (event.getSource().equals(dataManager.getListB())){
handleFsrFunctionListEvent(event);
}else if (event.getSource().equals(dataManager.getListC())){
handleElementListEvent(event);
}
}
}

...

private void handleFunctionListEvent(ListEvent<Function> event) {
if (event.getType() == ListEvent.INSERT){
Function function = event.getSourceList().get(event.getIndex());
ElementRow<Function> functionRow = new ElementRow<Function>(function);
ElementRow parentRow = findRow(function.getElement());
addRow(parentRow, functionRow);
} else if (event.getType() == ListEvent.DELETE){
Function function = event.getOldValue();
//SOMETIMES HERE I GOT OTHER VALUES THAN
FUNCTIONS...
Row row = findRow(function);
removeRow(row);
}
}

--
View this message in context: http://old.nabble.com/Problem-with-class-listening-to-different-EventLists-tp26160133p26160133.html
Sent from the GlazedLists - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Problem with class listening to different EventLists

2009-11-03T05:58:39Z

Hi together,
I've got a component which must listen to different eventLists.
It is not possible to implement the ListEventListener typed via
generics interface more than once.
Therefore I added just one method (without generics), ask the event
for the eventListSource, compare it to the different eventLists and
call specific methods which handle the specific events.

If my if-clause says that the eventListSource is the eventList A than
I call handleAEvent(...) method. In this method I try to retrieve the
object either via event.getOldObject or via getIndex and get(index).
My problem is, that sometimes i get objects of other lists...

Is my problem described clearly? Can anyone help me?
Here a code snipped...

dataManager.getFsrs().addListEventListener(this);
dataManager.getFsrFunctions().addListEventListener(this);
dataManager.getElements().addListEventListener(this);
...

public void listChanged(ListEvent event) {
//Iterate through all list changes
while (event.hasNext()) {
event.next(); //get the next change event
if (event.getSourceList().equals(dataManager.getListA())){
handleFsrListEvent(event);
}else if (event.getSource().equals(dataManager.getListB())){
handleFsrFunctionListEvent(event);
}else if (event.getSource().equals(dataManager.getListC())){
handleElementListEvent(event);
}
}
}

...

private void handleFunctionListEvent(ListEvent<Function> event) {
if (event.getType() == ListEvent.INSERT){
Function function = event.getSourceList().get(event.getIndex());
ElementRow<Function> functionRow = new ElementRow<Function>
(function);
ElementRow parentRow = findRow(function.getElement());
addRow(parentRow, functionRow);
} else if (event.getType() == ListEvent.DELETE){
Function function = event.getOldValue();
//SOMETIMES HERE I GOT OTHER VALUES THAN
FUNCTIONS...
Row row = findRow(function);
removeRow(row);
}
}

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Problem with class listening to different EventLists

2009-11-03T05:57:00Z

Hi together,
I've got a component which must listen to different eventLists.
It is not possible to implement the ListEventListener typed via generics interface more than once.
Therefore I added just one method (without generics), ask the event for the eventListSource, compare it to the different eventLists and call specific methods which handle the specific events.

If my if-clause says that the eventListSource is the eventList A than I call handleAEvent(...) method. In this method I try to retrieve the object either via event.getOldObject or via getIndex and get(index). My problem is, that sometimes i get objects of other lists...

Is my problem described clearly? Can anyone help me?
Here a code snipped...

dataManager.getFsrs().addListEventListener(this);
dataManager.getFsrFunctions().addListEventListener(this);
dataManager.getElements().addListEventListener(this);
...

public void listChanged(ListEvent event) {
//Iterate through all list changes
while (event.hasNext()) {
event.next(); //get the next change event
if (event.getSourceList().equals(dataManager.getListA())){
handleFsrListEvent(event);
}else if (event.getSource().equals(dataManager.getListB())){
handleFsrFunctionListEvent(event);
}else if (event.getSource().equals(dataManager.getListC())){
handleElementListEvent(event);
}
}
}

...

private void handleFunctionListEvent(ListEvent<Function> event) {
if (event.getType() == ListEvent.INSERT){
Function function = event.getSourceList().get(event.getIndex());
ElementRow<Function> functionRow = new ElementRow<Function>(function);
ElementRow parentRow = findRow(function.getElement());
addRow(parentRow, functionRow);
} else if (event.getType() == ListEvent.DELETE){
Function function = event.getOldValue();
//SOMETIMES HERE I GOT OTHER VALUES THAN FUNCTIONS...
Row row = findRow(function);
removeRow(row);
}
}

Problem with class listening to different EventLists

2009-11-03T05:55:24Z

Hi together,
I've got a component which must listen to different eventLists.
It is not possible to implement the ListEventListener typed via generics interface more than once.
Therefore I added just one method (without generics), ask the event for the eventListSource, compare it to the different eventLists and call specific methods which handle the specific events.

If my if-clause says that the eventListSource is the eventList A than I call handleAEvent(...) method. In this method I try to retrieve the object either via event.getOldObject or via getIndex and get(index). My problem is, that sometimes i get objects of other lists...

Is my problem described clearly? Can anyone help me?
Here a code snipped...

dataManager.getFsrs().addListEventListener(this);
dataManager.getFsrFunctions().addListEventListener(this);
dataManager.getElements().addListEventListener(this);
...

public void listChanged(ListEvent event) {
//Iterate through all list changes
while (event.hasNext()) {
event.next(); //get the next change event
if (event.getSourceList().equals(dataManager.getListA())){
handleFsrListEvent(event);
}else if (event.getSource().equals(dataManager.getListB())){
handleFsrFunctionListEvent(event);
}else if (event.getSource().equals(dataManager.getListC())){
handleElementListEvent(event);
}
}
}

...

private void handleFunctionListEvent(ListEvent<Function> event) {
if (event.getType() == ListEvent.INSERT){
Function function = event.getSourceList().get(event.getIndex());
ElementRow<Function> functionRow = new ElementRow<Function>(function);
ElementRow parentRow = findRow(function.getElement());
addRow(parentRow, functionRow);
} else if (event.getType() == ListEvent.DELETE){
Function function = event.getOldValue();
//SOMETIMES HERE I GOT OTHER VALUES THAN FUNCTIONS...
Row row = findRow(function);
removeRow(row);
}
}

Re: malware-problem and virus-warnings

2009-11-02T10:40:16Z

Wow! Congratulations Holger! Finally got around to solving that bug, huh? :-)

James

On Mon, Oct 26, 2009 at 1:02 PM, Rob Eden <rob@...> wrote:

Congratulations, Holger!

Rob

On Oct 26, 2009, at 4:00 PM, Holger Brands wrote:

As I'm getting married on Friday,
I'm pretty busy with other stuff ;-)
Hopefully, Jesse or James will find some time
to have a look at this?

Thanks,
Holger

Hi guys,

I've got the same kind of problem to access the GL main page.
But I get more than one virus warning --> A look at the API is inhibited
by our webscan:
There's a trojan horse called 'Tenia.d'.
A look at the release notes is inhibited due to a virus called
'Mal_Hifrm'.

I think, for the most of people that use some internet protection
there's no access to your GL main page.
It doesn't seem to be a false alarm. if you load the side in a safe
area, the local scanner triggers an alarm, too.

Thanks,
Markus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

______________________________________________________
GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://movieflat.web.de

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: malware-problem and virus-warnings

2009-10-26T14:02:01Z

Congratulations, Holger!

Rob

On Oct 26, 2009, at 4:00 PM, Holger Brands wrote:

> As I'm getting married on Friday,
> I'm pretty busy with other stuff ;-)
> Hopefully, Jesse or James will find some time
> to have a look at this?
>
> Thanks,
> Holger
>
>> Hi guys,
>>
>> I've got the same kind of problem to access the GL main page.
>> But I get more than one virus warning --> A look at the API is
>> inhibited
>> by our webscan:
>> There's a trojan horse called 'Tenia.d'.
>> A look at the release notes is inhibited due to a virus called
>> 'Mal_Hifrm'.
>>
>> I think, for the most of people that use some internet protection
>> there's no access to your GL main page.
>> It doesn't seem to be a false alarm. if you load the side in a safe
>> area, the local scanner triggers an alarm, too.
>>
>> Thanks,
>> Markus
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>>
>
>
> ______________________________________________________
> GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
> Jetzt freischalten unter http://movieflat.web.de
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: malware-problem and virus-warnings

2009-10-26T14:00:42Z

As I'm getting married on Friday,
I'm pretty busy with other stuff ;-)
Hopefully, Jesse or James will find some time
to have a look at this?

Thanks,
Holger

> Hi guys,
>
> I've got the same kind of problem to access the GL main page.
> But I get more than one virus warning --> A look at the API is inhibited
> by our webscan:
> There's a trojan horse called 'Tenia.d'.
> A look at the release notes is inhibited due to a virus called
> 'Mal_Hifrm'.
>
> I think, for the most of people that use some internet protection
> there's no access to your GL main page.
> It doesn't seem to be a false alarm. if you load the side in a safe
> area, the local scanner triggers an alarm, too.
>
> Thanks,
> Markus
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

______________________________________________________
GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://movieflat.web.de

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

malware-problem and virus-warnings

2009-10-26T02:17:02Z

Hi guys,

I've got the same kind of problem to access the GL main page.
But I get more than one virus warning --> A look at the API is inhibited
by our webscan:
There's a trojan horse called 'Tenia.d'.
A look at the release notes is inhibited due to a virus called
'Mal_Hifrm'.

I think, for the most of people that use some internet protection
there's no access to your GL main page.
It doesn't seem to be a false alarm. if you load the side in a safe
area, the local scanner triggers an alarm, too.

Thanks,
Markus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: GL Page Malware Warning

2009-10-22T09:51:48Z

So remember a long time ago when we had that spam magnet of a wiki? Well apparently it's distributing malware. GROSS!! I've cleaned up wiki, so now I await another crawl by Googlebot.

Sorry about this!

On Thu, Oct 22, 2009 at 8:20 AM, Rob Eden <rob@...> wrote:

The GL main page is giving a malware warning in Safari at the moment.

Here's the Google diagnositc page for "statanalyze.cn": http://google.com/safebrowsing/diagnostic?tpl=safari&site=statanalyze.cn&hl=en-us

Screenshot attached.

Rob

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

--
Climate change should be your #1 political issue.
http://www.youtube.com/watch?v=zORv8wwiadQ

GL Page Malware Warning

2009-10-22T08:20:52Z

The GL main page is giving a malware warning in Safari at the moment.

Here's the Google diagnositc page for "statanalyze.cn": http://google.com/safebrowsing/diagnostic?tpl=safari&site=statanalyze.cn&hl=en-us

Screenshot attached.

Rob

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

gl_malware.png (90K) Download Attachment

Maven source jar has wrong contents

2009-10-14T10:25:25Z

Hi folks,

I just added the dependency to glazed-lists to my project:

<dependency>
<groupId>net.java.dev.glazedlists</groupId>
<artifactId>glazedlists_java15</artifactId>
<version>1.8.0</version>
</dependency>

which is located at Maven Central.

You were kind enough to also provide the source and javadoc artifacts, but I think there is a slight mistake here, since IntelliJ could not display the source correctly:
I think the source.jar should ONLY contain the contents of the "source" subdirectory (that is, ca/odell/glazedlists/...), not the whole "source" download available from your website.
So, the source.jar should start one level deeper in the project directory tree in order to conform to maven's expectations.

Thanks
Gerhard

setTableFormat for EventTableViewer

2009-10-11T12:05:51Z

Hi,
I've implemented setTableFormat for EventTableViewer.

http://gist.github.com/207822

Regards
fabian

Re: Taking back the wiki

2009-10-06T09:11:22Z

Hi Kon -

A while back we moved the wiki to Google Sites. If you're still
looking at MediaWiki, you should update your bookmark to "sites.google.com/site/glazedlists/
" (note: the link is on the GL main page).

We locked down who can edit the wiki to eliminate the spam, but I
believe we're open to inviting others interested in helping maintain
the wiki to do so. The intention wasn't to reduce collaboration, but
rather to eliminate the spam. So, if you're interested, let us know.

Rob

On Oct 6, 2009, at 4:19 AM, Kon Soulianidis wrote:

> Hi,
>
> As an infrequent glazed lists user, I do refer back to the videos
> and wiki
> from time to time.
>
> I know previous posts on the mailing list have looked at reducing
> the spam
> on the wiki but there were some issues with getting someone with the
> skills
> to install a captcha plugin on the wiki.
>
> I went to clean up some spam from the main page the other day but
> can still
> see from the recent changes page that spammers are still making
> changes to
> different pages.
>
> I'd like to continue to clean up more pages on the wiki, but knowing
> that
> spammers will attack again, I'd like to put in place some measures
> to make
> sure users from an unknown IP cant edit pages, and that it isn't so
> easy to
> sign up - perhaps admin validation or having another go at
> installing the
> captcha plugin for Mediawiki.
>
> Just wanted to get an understanding from the team what the opinion
> was of
> the wiki and to whether or not continue to maintain it? If so,
> would I be
> able to have access to lock the wiki down?
>
> Thanks,
>
> Kon Soulianidis
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: Taking back the wiki

2009-10-06T09:10:23Z

Hey Kon,

Our longterm solution to that spam problem was to abandon our own wiki and use a Google Site (which is working much much better). You can find it here:

http://sites.google.com/site/glazedlists/Home/whats-new/Glazed-Lists-wiki-relaunched-as-Google-site

If we still have a link that points to the old one, let us know which and we'll update it.

James

On Tue, Oct 6, 2009 at 2:19 AM, Kon Soulianidis <kon@...> wrote:

Hi,

As an infrequent glazed lists user, I do refer back to the videos and wiki
from time to time.

I know previous posts on the mailing list have looked at reducing the spam
on the wiki but there were some issues with getting someone with the skills
to install a captcha plugin on the wiki.

I went to clean up some spam from the main page the other day but can still
see from the recent changes page that spammers are still making changes to
different pages.

I'd like to continue to clean up more pages on the wiki, but knowing that
spammers will attack again, I'd like to put in place some measures to make
sure users from an unknown IP cant edit pages, and that it isn't so easy to
sign up - perhaps admin validation or having another go at installing the
captcha plugin for Mediawiki.

Just wanted to get an understanding from the team what the opinion was of
the wiki and to whether or not continue to maintain it? If so, would I be
able to have access to lock the wiki down?

Thanks,

Kon Soulianidis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Taking back the wiki

2009-10-06T02:19:57Z

Hi,

As an infrequent glazed lists user, I do refer back to the videos and wiki
from time to time.

I know previous posts on the mailing list have looked at reducing the spam
on the wiki but there were some issues with getting someone with the skills
to install a captcha plugin on the wiki.

I went to clean up some spam from the main page the other day but can still
see from the recent changes page that spammers are still making changes to
different pages.

I'd like to continue to clean up more pages on the wiki, but knowing that
spammers will attack again, I'd like to put in place some measures to make
sure users from an unknown IP cant edit pages, and that it isn't so easy to
sign up - perhaps admin validation or having another go at installing the
captcha plugin for Mediawiki.

Just wanted to get an understanding from the team what the opinion was of
the wiki and to whether or not continue to maintain it? If so, would I be
able to have access to lock the wiki down?

Thanks,

Kon Soulianidis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: Corrupted glazedlists-1.8.0_java15.jar from site

2009-09-23T12:42:40Z

I think this is issue
https://glazedlists.dev.java.net/issues/show_bug.cgi?id=463
which is fixed for the next release.

As a workaround, you could regenerate the jar index:

jar i <GL-jarfile>

Hope this helps,
Holger

>
> Hi all
>
> It seems the glazedlists-1.8.0_java15.jar from
> http://publicobject.com/glazedlists/ is corrupted.
> I issue with it when tried to import java class with long name package into
> groovy class. More description about problem is here
> http://gr8forums.org/viewtopic.php?f=19&t=60
>
> When I removed glazedlists-1.8.0_java15.jar from dependencies the problem
> went away.
> --
> View this message in context: http://www.nabble.com/Corrupted-glazedlists-1.8.0_java15.jar-from-site-tp25531106p25531106.html
> Sent from the GlazedLists - Dev mailing list archive at Nabble.com.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

________________________________________________________________
Neu: WEB.DE Doppel-FLAT mit Internet-Flatrate + Telefon-Flatrate
für nur 19,99 Euro/mtl.!* http://produkte.web.de/go/02/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Corrupted glazedlists-1.8.0_java15.jar from site

2009-09-23T05:20:14Z

Hi all

It seems the glazedlists-1.8.0_java15.jar from http://publicobject.com/glazedlists/ is corrupted.
I issue with it when tried to import java class with long name package into groovy class. More description about problem is here http://gr8forums.org/viewtopic.php?f=19&t=60

When I removed glazedlists-1.8.0_java15.jar from dependencies the problem went away.

Re: selection support in GL

2009-09-15T08:21:57Z

On Wed, 02 Sep 2009 20:22:57 +0200 Holger Brands <hbrands@...> wrote:

HB> What do you mean by "disabling the selection mapper locks the EDT"?
HB> Does the call to table.getSelectionMapper().setEnabled(false) block
HB> or what behaviour do you see?

It blocked the EDT, application never comes up. I can't replicate it
anymore; I tried several times, hence the delay in responding. I'll
write back if I see the EDT block again.

Ted

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

TextMatcherEditor.CONTAINS -> CONTAINS_ANY

2009-09-15T08:20:36Z

I want to have multiple OR search terms (TextMatcherEditor.CONTAINS but
with a OR combination).

Option 1: subclass to implement CONTAINS_ANY. This is pretty painful
because the matcher strategy class is inlined. Has anyone done it?

Option 2: use the REGEX option. Training the users is not going to be
fun.

Option 3: use the seach engine. Way too complicated for my purpose so
I'm avoiding this.

I am posting this to the developer list because I think option (1) is
the best one, and should be part of GL. If not, sorry for the noise.

Ted

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: Unsafe Construction in GL

2009-09-07T14:23:35Z

[I of course have both Effective Java and JCIP, as I guess we all do!]

I think you might have lost my point: I specifically, twice even, stated that I don't want this to be a part of "the public API", and that the coders of GL would be totally free to completely trash my code on every revision-release when it comes to places where I've used inheritance. Document this decision in the javadoc, possibly of both class and the protected methods, and one would be good.

Problem is that composition can't fix the problem I have as GL stands. All of GL would have to be rewritten in that case. So, given these final classes and private methods, I'm stuck with copying the entire class to fix (add) one damn line of code. Lovely. Thus, your "high-flying argument" about composition vs. inheritance doesn't help me jack.

Also, the prohibition (finalness and private) isn't consitent, and one typically extend or tailor GL by extending AbstractEventList or TransformedEventList. So the point isn't valid at all, IMHO, at least as the codebase stands. Thus, opening up would make the situation better, not worse. On a rewrite, or on breaching major version, one could implement a composition logic throughout, and make everything final.

Two situations: CollectionList takes a Model (good - composition), but the decision about which implementation of ChildElement to use is a private method (as is the the interface, and the two inner implementation classes), even though the class is NOT final. Thus, to implement "recursing dispose", I had to copy the entire thing. For UniqueList, a simple extension would actually have fixed my problem - but here the class is final.

Generally, on these situations, I personally feel that javadoccing the intention of inheritance not being a "supported means of using GL" is better than just messing me over by making the class final, and methods private. See, problem is that one can't envision all the usage scenarios ones user have - maybe they even come up with something that really should be turned into a proper part of the API - while by making a class final, you pretty much state "I am just too intelligent for you, and my decision here is .. final".

.. and GlazedLists isn't in java.util quite yet, either.

Kind regards,

Endre.

On Mon, Sep 7, 2009 at 22:04, Bruce Alspaugh <compulinkltd@...> wrote:

I agree that the dispose methods are a real problem. See my post:

http://www.nabble.com/WeakReferenceProxy-td25299875.html

However, I have to defend the GL designers when they followed best practices in places where they prohibited inheritance. The central problem is that extending a class breaks encapsulation.

Good API design is hard enough. As Joshua Bloch points out[1], it is very difficult to design a class that can be safely extended because of all the problems you can run into[2]. Unlike C++, Java is a single inheritance language which significantly limits what you can do with inheritance. Instead of extending a class, I recommend to use composition whenever possible[3]. I like his quote, "If a class implements some interface that captures its essence, such as Set, List, or Map, then you should feel no compunction about prohibiting subclassing. The wrapper class pattern, described in Item 16, provides a superior alternative to inheritance for augmenting the functionality." pg. 91. For GL, EventList is that interface.

By the way, "Effective Java" is one of the best Java books I have ever read. Even James Gosling himself speaks highly of it. It should be required reading for all Java developers. It is that good.

Bruce

[1] Effective Java Second Edition, Joshua Bloch
[2] Effective Java Item 17: Design and document for inheritance or else prohibit it.
[3] Effective Java Item 16: Favor composition over inheritance

Endre Stølsvik wrote:

I've also noticed the aspect the OP points out. Although I understand that it doesn't really make a problem until you have errors in your code (exceptions thrown), or you have code that "uses" this escaping in some way.

BUT: *Don't make anything private - make it protected.* (and don't use final either).

There is way to much privateness in GL already. I've been in need to override some small aspects of GL now and then (primarily with the resource handling (dispose), which I am not happy with) - and I've invariably have had to copy the entire class. And if the required methods aren't private - because they are a public part of the API - the class is instead final!

I sense the "But these are implementation details that we do not want to expose!!!!" and "That is not a part of the API that we will have to maintain!!!!" arguments building up, so I'll just dryly point out: Either I can extend these classes, or I have to copy them pretty much verbatim. Which of those strategies is "most exposed"? If you try to lock things down even more, I'll just pretty much have to "fork" the entire project into my own codebase. And again - which is the worst of these two approaches?

IMHO, The API is the public facing methods. That the /implementations/ are open for extension (non-final classes and protected methods instead of private) doesn't make it into a part of the API as such. So feel free to ruin my extensions for every version of GL issued. ( - and it wouldn't hurt sticking in some extra "hooks" either - like you already had with CollectionList.createChildElementForList(..), which of course is private).

Endre.

On Mon, Sep 7, 2009 at 17:51, Bruce Alspaugh <compulinkltd@... <mailto:compulinkltd@...>> wrote:

I was reading a copy of Java Concurrency in Practice[1], and they
point out there are certain things you should never do inside a
constructor like call a method that could be overridden, or start a
thread because it can allow the this reference to escape from an
object before it is completely constructed. I'm concerned that GL may
be doing something else they say you should never do in a constructor:
publish an inner class instance. The example they give looks like
this:

public class ThisEscape {
public ThisEscape(EventSource source) {
source.registerListener(
new EventListener() {
public void onEvent(Event e) {
doSomething(e);
}
});
}
}

When ThisEscape publishes the EventListener, it implicitly publishes
the enclosing ThisEscape instance as well, because inner class
instances contain a hidden reference to the enclosing instance. The
problem is that the event source has access to the "this" reference
before ThisEscape has been fully constructed. They say it is a
problem even if the publication is the last statement in the
constructor.

The workaround they recommend is to use a static factory method. It's
OK to create a listener or a thread in a constructor, just don't
publish or start it.

public class SafeListener {
private final EventListener listener;

private SafeListener() {
listener = new EventListener() {
public void onEvent(Event e) {
doSomething(e);
}
};
}

public static SafeListener newInstance(EventSource source) {
SafeListener safe = new SafeListener();
source.registerListener(safe.listener);
return safe;
}
}

When I looked at the Javadoc describing the constructors for classes
like ObservableElementList, I was concerned that might be happening.
When I looked at the source for ObservableElementList and saw lines
like the ones below in the constructor, I became even more concerned:

public ObservableElementList(EventList<E> source, Connector<? super E>
elementConnector) {
this.elementConnector = elementConnector;

// attach this list to the element connector so the listeners know
// which List to notify of their modifications
this.elementConnector.setObservableElementList(this);

// for speed, we add all source elements together, rather than
individually
this.observedElements = new ArrayList<E>(source);

// we initialize the single EventListener registry, as we
optimistically
// assume we'll be using a single listener for all observed elements
this.singleEventListenerRegistry = new Barcode();
this.singleEventListenerRegistry.addWhite(0, source.size());

// add listeners to all source list elements
for (int i = 0, n = size(); i < n; i++) {
// connect a listener to the element
final EventListener listener = this.connectElement(get(i));

// record the listener in the registry
this.registerListener(i, listener, false);
}

// begin listening to the source list
source.addListEventListener(this);
}

The elementConnector sees the "this" reference before the
ObservableElementList is fully constructed. Later, every list element
sees the "this" reference when the listener is registered on each
element. Finally, the source list sees the "this" reference in the
last line of the constructor.

I'm concerned this idiom exists throughout GL, and it may be difficult
to fix without API changes. To emply the suggested workaround would
require making the constructors private and using factory methods
instead. Maybe the GL folks already know about this?

Bruce

[1] Java Concurrency in Practice, Brian Goetz, Tim Peierls, Joshua
Bloch, Joseph Bowbeer, David Holmes, and Doug Lea Chapter 3.2.1 Safe
Construction Practices, pg. 41-42

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
<mailto:dev-unsubscribe@...>

For additional commands, e-mail: dev-help@...
<mailto:dev-help@...>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: Unsafe Construction in GL

2009-09-07T13:02:52Z

I agree that the dispose methods are a real problem. See my post:

http://www.nabble.com/WeakReferenceProxy-td25299875.html

However, I have to defend the GL designers when they followed best
practices in places where they prohibited inheritance. The central
problem is that extending a class breaks encapsulation.

Good API design is hard enough. As Joshua Bloch points out[1], it is
very difficult to design a class that can be safely extended because of
all the problems you can run into[2]. Unlike C++, Java is a single
inheritance language which significantly limits what you can do with
inheritance. Instead of extending a class, I recommend to use
composition whenever possible[3]. I like his quote, "If a class
implements some interface that captures its essence, such as Set, List,
or Map, then you should feel no compunction about prohibiting
subclassing. The wrapper class pattern, described in Item 16, provides
a superior alternative to inheritance for augmenting the functionality."
pg. 91. For GL, EventList is that interface.

By the way, "Effective Java" is one of the best Java books I have ever
read. Even James Gosling himself speaks highly of it. It should be
required reading for all Java developers. It is that good.

Bruce

[1] Effective Java Second Edition, Joshua Bloch
[2] Effective Java Item 17: Design and document for inheritance or else
prohibit it.
[3] Effective Java Item 16: Favor composition over inheritance

Endre Stølsvik wrote:

> I've also noticed the aspect the OP points out. Although I understand
> that it doesn't really make a problem until you have errors in your code
> (exceptions thrown), or you have code that "uses" this escaping in some way.
>
> BUT: *Don't make anything private - make it protected.* (and don't use
> final either).
>
> There is way to much privateness in GL already. I've been in need to
> override some small aspects of GL now and then (primarily with the
> resource handling (dispose), which I am not happy with) - and I've
> invariably have had to copy the entire class. And if the required
> methods aren't private - because they are a public part of the API - the
> class is instead final!
>
> I sense the "But these are implementation details that we do not want to
> expose!!!!" and "That is not a part of the API that we will have to
> maintain!!!!" arguments building up, so I'll just dryly point out:
> Either I can extend these classes, or I have to copy them pretty much
> verbatim. Which of those strategies is "most exposed"? If you try to
> lock things down even more, I'll just pretty much have to "fork" the
> entire project into my own codebase. And again - which is the worst of
> these two approaches?
>
> IMHO, The API is the public facing methods. That the /implementations/
> are open for extension (non-final classes and protected methods instead
> of private) doesn't make it into a part of the API as such. So feel free
> to ruin my extensions for every version of GL issued. ( - and it
> wouldn't hurt sticking in some extra "hooks" either - like you already
> had with CollectionList.createChildElementForList(..), which of course
> is private).
>
> Endre.
>
> On Mon, Sep 7, 2009 at 17:51, Bruce Alspaugh <compulinkltd@...
> <mailto:compulinkltd@...>> wrote:
>
> I was reading a copy of Java Concurrency in Practice[1], and they
> point out there are certain things you should never do inside a
> constructor like call a method that could be overridden, or start a
> thread because it can allow the this reference to escape from an
> object before it is completely constructed. I'm concerned that GL may
> be doing something else they say you should never do in a constructor:
> publish an inner class instance. The example they give looks like
> this:
>
> public class ThisEscape {
> public ThisEscape(EventSource source) {
> source.registerListener(
> new EventListener() {
> public void onEvent(Event e) {
> doSomething(e);
> }
> });
> }
> }
>
> When ThisEscape publishes the EventListener, it implicitly publishes
> the enclosing ThisEscape instance as well, because inner class
> instances contain a hidden reference to the enclosing instance. The
> problem is that the event source has access to the "this" reference
> before ThisEscape has been fully constructed. They say it is a
> problem even if the publication is the last statement in the
> constructor.
>
> The workaround they recommend is to use a static factory method. It's
> OK to create a listener or a thread in a constructor, just don't
> publish or start it.
>
> public class SafeListener {
> private final EventListener listener;
>
> private SafeListener() {
> listener = new EventListener() {
> public void onEvent(Event e) {
> doSomething(e);
> }
> };
> }
>
> public static SafeListener newInstance(EventSource source) {
> SafeListener safe = new SafeListener();
> source.registerListener(safe.listener);
> return safe;
> }
> }
>
> When I looked at the Javadoc describing the constructors for classes
> like ObservableElementList, I was concerned that might be happening.
> When I looked at the source for ObservableElementList and saw lines
> like the ones below in the constructor, I became even more concerned:
>
> public ObservableElementList(EventList<E> source, Connector<? super E>
> elementConnector) {
> this.elementConnector = elementConnector;
>
> // attach this list to the element connector so the listeners know
> // which List to notify of their modifications
> this.elementConnector.setObservableElementList(this);
>
> // for speed, we add all source elements together, rather than
> individually
> this.observedElements = new ArrayList<E>(source);
>
> // we initialize the single EventListener registry, as we
> optimistically
> // assume we'll be using a single listener for all observed elements
> this.singleEventListenerRegistry = new Barcode();
> this.singleEventListenerRegistry.addWhite(0, source.size());
>
> // add listeners to all source list elements
> for (int i = 0, n = size(); i < n; i++) {
> // connect a listener to the element
> final EventListener listener = this.connectElement(get(i));
>
> // record the listener in the registry
> this.registerListener(i, listener, false);
> }
>
> // begin listening to the source list
> source.addListEventListener(this);
> }
>
> The elementConnector sees the "this" reference before the
> ObservableElementList is fully constructed. Later, every list element
> sees the "this" reference when the listener is registered on each
> element. Finally, the source list sees the "this" reference in the
> last line of the constructor.
>
> I'm concerned this idiom exists throughout GL, and it may be difficult
> to fix without API changes. To emply the suggested workaround would
> require making the constructors private and using factory methods
> instead. Maybe the GL folks already know about this?
>
> Bruce
>
> [1] Java Concurrency in Practice, Brian Goetz, Tim Peierls, Joshua
> Bloch, Joseph Bowbeer, David Holmes, and Doug Lea Chapter 3.2.1 Safe
> Construction Practices, pg. 41-42
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> <mailto:dev-unsubscribe@...>
> For additional commands, e-mail: dev-help@...
> <mailto:dev-help@...>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: Unsafe Construction in GL

2009-09-07T10:01:15Z

I've also noticed the aspect the OP points out. Although I understand that it doesn't really make a problem until you have errors in your code (exceptions thrown), or you have code that "uses" this escaping in some way.

BUT: Don't make anything private - make it protected. (and don't use final either).

There is way to much privateness in GL already. I've been in need to override some small aspects of GL now and then (primarily with the resource handling (dispose), which I am not happy with) - and I've invariably have had to copy the entire class. And if the required methods aren't private - because they are a public part of the API - the class is instead final!

I sense the "But these are implementation details that we do not want to expose!!!!" and "That is not a part of the API that we will have to maintain!!!!" arguments building up, so I'll just dryly point out: Either I can extend these classes, or I have to copy them pretty much verbatim. Which of those strategies is "most exposed"? If you try to lock things down even more, I'll just pretty much have to "fork" the entire project into my own codebase. And again - which is the worst of these two approaches?

IMHO, The API is the public facing methods. That the /implementations/ are open for extension (non-final classes and protected methods instead of private) doesn't make it into a part of the API as such. So feel free to ruin my extensions for every version of GL issued. ( - and it wouldn't hurt sticking in some extra "hooks" either - like you already had with CollectionList.createChildElementForList(..), which of course is private).

Endre.

On Mon, Sep 7, 2009 at 17:51, Bruce Alspaugh <compulinkltd@...> wrote:

I was reading a copy of Java Concurrency in Practice[1], and they
point out there are certain things you should never do inside a
constructor like call a method that could be overridden, or start a
thread because it can allow the this reference to escape from an
object before it is completely constructed. I'm concerned that GL may
be doing something else they say you should never do in a constructor:
publish an inner class instance. The example they give looks like
this:

public class ThisEscape {
public ThisEscape(EventSource source) {
source.registerListener(
new EventListener() {
public void onEvent(Event e) {
doSomething(e);
}
});
}
}

When ThisEscape publishes the EventListener, it implicitly publishes
the enclosing ThisEscape instance as well, because inner class
instances contain a hidden reference to the enclosing instance. The
problem is that the event source has access to the "this" reference
before ThisEscape has been fully constructed. They say it is a
problem even if the publication is the last statement in the
constructor.

The workaround they recommend is to use a static factory method. It's
OK to create a listener or a thread in a constructor, just don't
publish or start it.

public class SafeListener {
private final EventListener listener;

private SafeListener() {
listener = new EventListener() {
public void onEvent(Event e) {
doSomething(e);
}
};
}

public static SafeListener newInstance(EventSource source) {
SafeListener safe = new SafeListener();
source.registerListener(safe.listener);
return safe;
}
}

When I looked at the Javadoc describing the constructors for classes
like ObservableElementList, I was concerned that might be happening.
When I looked at the source for ObservableElementList and saw lines
like the ones below in the constructor, I became even more concerned:

public ObservableElementList(EventList<E> source, Connector<? super E>
elementConnector) {
this.elementConnector = elementConnector;

// attach this list to the element connector so the listeners know
// which List to notify of their modifications
this.elementConnector.setObservableElementList(this);

// for speed, we add all source elements together, rather than individually
this.observedElements = new ArrayList<E>(source);

// we initialize the single EventListener registry, as we optimistically
// assume we'll be using a single listener for all observed elements
this.singleEventListenerRegistry = new Barcode();
this.singleEventListenerRegistry.addWhite(0, source.size());

// add listeners to all source list elements
for (int i = 0, n = size(); i < n; i++) {
// connect a listener to the element
final EventListener listener = this.connectElement(get(i));

// record the listener in the registry
this.registerListener(i, listener, false);
}

// begin listening to the source list
source.addListEventListener(this);
}

The elementConnector sees the "this" reference before the
ObservableElementList is fully constructed. Later, every list element
sees the "this" reference when the listener is registered on each
element. Finally, the source list sees the "this" reference in the
last line of the constructor.

I'm concerned this idiom exists throughout GL, and it may be difficult
to fix without API changes. To emply the suggested workaround would
require making the constructors private and using factory methods
instead. Maybe the GL folks already know about this?

Bruce

[1] Java Concurrency in Practice, Brian Goetz, Tim Peierls, Joshua
Bloch, Joseph Bowbeer, David Holmes, and Doug Lea Chapter 3.2.1 Safe
Construction Practices, pg. 41-42

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Unsafe Construction in GL

2009-09-07T08:51:41Z

I was reading a copy of Java Concurrency in Practice[1], and they
point out there are certain things you should never do inside a
constructor like call a method that could be overridden, or start a
thread because it can allow the this reference to escape from an
object before it is completely constructed. I'm concerned that GL may
be doing something else they say you should never do in a constructor:
publish an inner class instance. The example they give looks like
this:

public class ThisEscape {
public ThisEscape(EventSource source) {
source.registerListener(
new EventListener() {
public void onEvent(Event e) {
doSomething(e);
}
});
}
}

When ThisEscape publishes the EventListener, it implicitly publishes
the enclosing ThisEscape instance as well, because inner class
instances contain a hidden reference to the enclosing instance. The
problem is that the event source has access to the "this" reference
before ThisEscape has been fully constructed. They say it is a
problem even if the publication is the last statement in the
constructor.

The workaround they recommend is to use a static factory method. It's
OK to create a listener or a thread in a constructor, just don't
publish or start it.

public class SafeListener {
private final EventListener listener;

private SafeListener() {
listener = new EventListener() {
public void onEvent(Event e) {
doSomething(e);
}
};
}

public static SafeListener newInstance(EventSource source) {
SafeListener safe = new SafeListener();
source.registerListener(safe.listener);
return safe;
}
}

When I looked at the Javadoc describing the constructors for classes
like ObservableElementList, I was concerned that might be happening.
When I looked at the source for ObservableElementList and saw lines
like the ones below in the constructor, I became even more concerned:

public ObservableElementList(EventList<E> source, Connector<? super E>
elementConnector) {
this.elementConnector = elementConnector;

// attach this list to the element connector so the listeners know
// which List to notify of their modifications
this.elementConnector.setObservableElementList(this);

// for speed, we add all source elements together, rather than individually
this.observedElements = new ArrayList<E>(source);

// we initialize the single EventListener registry, as we optimistically
// assume we'll be using a single listener for all observed elements
this.singleEventListenerRegistry = new Barcode();
this.singleEventListenerRegistry.addWhite(0, source.size());

// add listeners to all source list elements
for (int i = 0, n = size(); i < n; i++) {
// connect a listener to the element
final EventListener listener = this.connectElement(get(i));

// record the listener in the registry
this.registerListener(i, listener, false);
}

// begin listening to the source list
source.addListEventListener(this);
}

The elementConnector sees the "this" reference before the
ObservableElementList is fully constructed. Later, every list element
sees the "this" reference when the listener is registered on each
element. Finally, the source list sees the "this" reference in the
last line of the constructor.

I'm concerned this idiom exists throughout GL, and it may be difficult
to fix without API changes. To emply the suggested workaround would
require making the constructors private and using factory methods
instead. Maybe the GL folks already know about this?

Bruce

[1] Java Concurrency in Practice, Brian Goetz, Tim Peierls, Joshua
Bloch, Joseph Bowbeer, David Holmes, and Doug Lea Chapter 3.2.1 Safe
Construction Practices, pg. 41-42

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: selection support in GL

2009-09-02T11:22:57Z

Hey Ted,

what I was trying to say was, that the only supported approaches
for integrating GL with SwingX are the ones listed on the wiki page.

You're free to try something different, but you can't expect it to work
out of the box ;-)

>
> As I mentioned in my earlier post, disabling the selection mapper locks
> the EDT. I can research further if you need me to--does it work for
> you?

What do you mean by "disabling the selection mapper locks the EDT"?
Does the call to table.getSelectionMapper().setEnabled(false) block
or what behaviour do you see?

I tried your (modified) two examples on Windows XP with JDK 1.5u7 and 1.6u11
with SwingX 1.0 and the latest GL build without problems.

In the first example, I only added the call to
table.getSelectionMapper().setEnabled(false)
I modified the second example to use the TableComparatorChooser approach.

If you could provide an executable example with instructions on how to
reproduce the issue, we'd be happy to have a look at it.
(But I have access to a Windows box only)

> Also I don't see why the selection mapper has to be disabled--my whole
> point below the example was that I'd like to use the JXTable facilities
> to sort and filter, instead of layering SortedList and FilterList
> adapters. There should be a simple way to do that with the stock
> DefaultEventSelectionModel, converting every index to the model index.
> If not I can write my own version I guess, but I was hoping to avoid
> that.

Jesse is the author of the SwingX extension.
I think he knows best why things work this way currently.
But if you find a more elegant solution, we'd of course be interested ;-)

Holger

________________________________________________________________
Neu: WEB.DE Doppel-FLAT mit Internet-Flatrate + Telefon-Flatrate
für nur 19,99 Euro/mtl.!* http://produkte.web.de/go/02/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: selection support in GL

2009-09-02T07:43:28Z

On Wed, 2 Sep 2009 13:15:17 +0200 Endre Stølsvik <java@...> wrote:

ES> Just a quick note on JXTable: I thought they currently were in the process
ES> of completely ripping out all their sorting and filtering, and building it
ES> up again with JDK 6 stuff for the next version (and possible inclusion in
ES> Java 7 or how that was again..)? Just a heads-up if you weren't aware of it
ES> - and if I'm right.

Yeah, all of SwingX is in limbo after the 1.0 release and they are
planning to synchronize with JDK 6. I had a few exchanges with the
SwingX developers
(e.g. http://forums.java.net/jive/thread.jspa?messageID=352381) and it
looks like these rewrites are far in the future.

I think all of Java is going to be in a transition for a bit with the
Oracle purchase and the Java team may discover new priorities, so for
now the best direction seems to be to work with the existing libraries.

Ted

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: selection support in GL

2009-09-02T04:15:17Z

Just a quick note on JXTable: I thought they currently were in the process of completely ripping out all their sorting and filtering, and building it up again with JDK 6 stuff for the next version (and possible inclusion in Java 7 or how that was again..)? Just a heads-up if you weren't aware of it - and if I'm right.

Endre.

2009/9/1 Ted Zlatanov <tzz@...>

On Tue, 01 Sep 2009 21:34:18 +0200 Holger Brands <hbrands@...> wrote:

HB> Hi Ted,
HB> in both examples you posted, you use DefaultEventSelectionModel with JXTable,
HB> but I don't see where you disable the selection mapper.
HB> The link I quoted states under section "Maintaining selection":

HB> "It is necessary to disable the SelectionMapper to use JXTable with Glazed Lists.
HB> Otherwise, the SelectionMapper competes with Glazed Lists' own selection management,
HB> and selection is left in an inconsistent state."

As I mentioned in my earlier post, disabling the selection mapper locks
the EDT. I can research further if you need me to--does it work for
you?

Also I don't see why the selection mapper has to be disabled--my whole
point below the example was that I'd like to use the JXTable facilities
to sort and filter, instead of layering SortedList and FilterList
adapters. There should be a simple way to do that with the stock
DefaultEventSelectionModel, converting every index to the model index.
If not I can write my own version I guess, but I was hoping to avoid
that.

Ted

>> On Sat, 29 Aug 2009 12:28:50 +0200 Holger Brands <hbrands@...> wrote:
>>
HB> there is some info about SwingX and GL here:
HB> http://sites.google.com/site/glazedlists/documentation/swingx
>>
>> First of all, GL is great. This is just one case where it's been hard
>> to use. I would not go back to non-GL programming, it would be painful.
>>
>> I tried the suggested
>>
>> EventListJXTableSorting sorting = EventListJXTableSorting.install(t, beans);
>> sorting.setMultipleColumnSort(true);
>>
>> but got many illegal state and null pointer errors, e.g. below. I also
>> don't like all the caveats and limitations of the suggested approaches.
>>
>> java.lang.IllegalStateException: Cannot combine reorder with other change events
>> at ca.odell.glazedlists.event.ListEventAssembler.reorder(ListEventAssembler.java:246)
>> at ca.odell.glazedlists.ListSelection.addSelectedReorder(ListSelection.java:852)
>> at ca.odell.glazedlists.ListSelection.listChanged(ListSelection.java:172)
>> at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:412)
>> at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:409)
>> at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher$SubjectAndListener.firePendingEvent(SequenceDependenciesEventPublisher.java:445)
>> at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher.fireEvent(SequenceDependenciesEventPublisher.java:344)
>> at ca.odell.glazedlists.event.ListEventAssembler.commitEvent(ListEventAssembler.java:316)
>> at ca.odell.glazedlists.SortedList.setComparator(SortedList.java:481)
>> at ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.setSortKeys(EventListJXTableSorting.java:228)
>> at ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.toggleSortOrder(EventListJXTableSorting.java:192)
>> at org.jdesktop.swingx.JXTable.toggleSortOrder(JXTable.java:2046)
>> at org.jdesktop.swingx.JXTableHeader$HeaderListener.doSort(JXTableHeader.java:608)
>> at org.jdesktop.swingx.JXTableHeader$HeaderListener.mouseClicked(JXTableHeader.java:589)
>> at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:253)
>> at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:252)
>> at java.awt.Component.processMouseEvent(Component.java:6266)
>> at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
>> at java.awt.Component.processEvent(Component.java:6028)
>> at java.awt.Container.processEvent(Container.java:2041)
>> at java.awt.Component.dispatchEventImpl(Component.java:4630)
>> at java.awt.Container.dispatchEventImpl(Container.java:2099)
>> at java.awt.Component.dispatchEvent(Component.java:4460)
>> at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
>> at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4247)
>> at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
>> at java.awt.Container.dispatchEventImpl(Container.java:2085)
>> at java.awt.Window.dispatchEventImpl(Window.java:2475)
>> at java.awt.Component.dispatchEvent(Component.java:4460)
>> at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
>> at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
>> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
>> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:178)
>> at java.awt.Dialog$1.run(Dialog.java:1045)
>> at java.awt.Dialog$3.run(Dialog.java:1097)
>> at java.security.AccessController.doPrivileged(Native Method)
>> at java.awt.Dialog.show(Dialog.java:1095)
>> at java.awt.Component.show(Component.java:1563)
>> at java.awt.Component.setVisible(Component.java:1515)
>> at java.awt.Window.setVisible(Window.java:841)
>> at java.awt.Dialog.setVisible(Dialog.java:985)
>> at com.jump.simple.Out.show(Out.java:851)
>> at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:199)
>> at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
>> at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
>> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
>> at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
>> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
>> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
>> at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
>>
>> This is the code I tried (see below for version without the EventListJXTableSorting):
>>
>> try
>> {
>> SwingUtilities.invokeAndWait(new Runnable()
>> {
>> public void run()
>> {
>> EventList<JLabel> labels = GlazedLists.eventListOf(new JLabel("a"), new JLabel("b"), new JLabel("c"), new JLabel("d"));
>> ObservableElementList.Connector<JLabel> labelConnector = GlazedLists.beanConnector(JLabel.class);
>> SortedList<JLabel> beans = new SortedList<JLabel>(new ObservableElementList<JLabel>(labels, labelConnector), new Comparator<JLabel>()
>> {
>> public int compare(JLabel o1, JLabel o2)
>> {
>> return o1.getText().compareTo(o2.getText());
>> }
>> });
>> // build a JTable
>> String[] propertyNames = { "text", };
>> TableFormat<JLabel> ltf = GlazedLists.tableFormat(JLabel.class, propertyNames, propertyNames);
>> final JXTable t = new JXTable(new DefaultEventTableModel<JLabel>(beans, ltf));
>> final JLabel view_selected = new JLabel("wrong");
>> final JLabel real_selected = new JLabel("right");
>> DefaultEventSelectionModel<JLabel> selModel = new DefaultEventSelectionModel<JLabel>(beans);
>> t.setSelectionModel(selModel);
>>
>> EventListJXTableSorting sorting = EventListJXTableSorting.install(t, beans);
>> sorting.setMultipleColumnSort(true);
>>
>> t.getSelectionModel().addListSelectionListener(new ListSelectionListener()
>> {
>> public void valueChanged(ListSelectionEvent e)
>> {
>> int[] rows = t.getSelectedRows();
>> int sel = rows.length < 1 ? -1 : rows[0];
>>
>> view_selected.setText("" + sel);
>> real_selected.setText("" + t.convertRowIndexToModel(sel));
>> }
>> });
>> JPanel show = new JPanel(new GridLayout(0, 1));
>> JList selList = new JList(new DefaultEventListModel<JLabel>(selModel.getSelected()));
>> selList.setCellRenderer(new DefaultListCellRenderer()
>> {
>> public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus)
>> {
>> JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
>> label.setText(((JLabel) value).getText());
>> return label;
>> }
>> });
>>
>> show.add(new JScrollPane(t));
>> show.add(new JScrollPane(selList));
>> show.add(view_selected);
>> show.add(real_selected);
>> Out.show(800, 600, show);
>> }
>> });
>> }
>> catch (Exception e)
>> {
>> e.printStackTrace();
>> }
>>
>>
>>
HB> I think there are some users combining SwingX with GL without problems,
HB> so to help you with your problem we need to know:
>>
HB> Which versions of SwingX and GL do you use?
>>
HB> How did you setup your JXTable?
>>
HB> A test program that demonstrates your issue would be ideal.
>>
>> Here's a simple example using JLabel lists. I'm using the latest dev
>> snapshot of glazed lists and the 1.0 SwingX release.
>>
>> EventList<JLabel> labels = GlazedLists.eventListOf(new JLabel("a"), new JLabel("b"), new JLabel("c"), new JLabel("d"));
>> ObservableElementList.Connector<JLabel> labelConnector = GlazedLists.beanConnector(JLabel.class);
>> ObservableElementList<JLabel> beans = new ObservableElementList<JLabel>(labels, labelConnector);
>> // build a JTable
>> String[] propertyNames = {"text",};
>> TableFormat<JLabel> ltf = GlazedLists.tableFormat(JLabel.class, propertyNames, propertyNames);
>> final JXTable t = new JXTable(new DefaultEventTableModel<JLabel>(beans, ltf));
>> final JLabel view_selected = new JLabel("wrong");
>> final JLabel real_selected = new JLabel("right");
>> DefaultEventSelectionModel<JLabel> selModel = new DefaultEventSelectionModel<JLabel>(beans);
>> t.setSelectionModel(selModel);
>>
>> t.getSelectionModel().addListSelectionListener(new ListSelectionListener()
>> {
>> public void valueChanged(ListSelectionEvent e)
>> {
>> int[] rows = t.getSelectedRows();
>> int sel = rows.length < 1 ? -1 : rows[0];
>>
>> view_selected.setText(""+sel);
>> real_selected.setText(""+t.convertRowIndexToModel(sel));
>> }
>> });
>> JPanel show = new JPanel(new GridLayout(0, 1));
>> JList selList = new JList(new DefaultEventListModel<JLabel>(selModel.getSelected()));
>> selList.setCellRenderer(new DefaultListCellRenderer()
>> {
>> public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus)
>> {
>> JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
>> label.setText(((JLabel)value).getText());
>> return label;
>> }
>> });
>>
>> show.add(new JScrollPane(t));
>> show.add(new JScrollPane(selList));
>> show.add(view_selected);
>> show.add(real_selected);
>> // show the JPanel now
>>
>> When unsorted, everything works. If you reverse-sort, though, selecting
>> elements 0 and 1 ("d" and "c") results in the selected list being "a"
>> and "b" (the view coordinates). The selection model needs to ask the
>> table to convert view rows to model rows, basically. I show this in the
>> real_selected vs. view_selected labels. The code has an exception for
>> -1 (nothing selected) but I didn't want to spend time polishing
>> irrelevant cases.
>>
>> My question, then, is: why not modify the DefaultEventSelectionModel to
>> ask the JXTable for the model coordinates of the selected data? At the
>> leat, mention that possibility in the SwingX compatiblity docs. I think
>> EventListJXTableSorting is too complicated and limiting for users who
>> like the JXTable sorting and filtering, plus as I showed it had some
>> issues (perhaps due to my inexperience using it).
>>
>> I would also suggest the docs for DefaultEventSelectionModel should
>> mention the SwingX issues clearly. If those issues are in the bug list,
>> point that out next to the bug URL.
>>
>> Thanks!
>> Ted
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>>

HB> ______________________________________________________
HB> GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
HB> Jetzt freischalten unter http://movieflat.web.de

--

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: selection support in GL

2009-09-01T14:11:37Z

On Tue, 01 Sep 2009 21:34:18 +0200 Holger Brands <hbrands@...> wrote:

HB> Hi Ted,
HB> in both examples you posted, you use DefaultEventSelectionModel with JXTable,
HB> but I don't see where you disable the selection mapper.
HB> The link I quoted states under section "Maintaining selection":

HB> "It is necessary to disable the SelectionMapper to use JXTable with Glazed Lists.
HB> Otherwise, the SelectionMapper competes with Glazed Lists' own selection management,
HB> and selection is left in an inconsistent state."

As I mentioned in my earlier post, disabling the selection mapper locks
the EDT. I can research further if you need me to--does it work for
you?

Also I don't see why the selection mapper has to be disabled--my whole
point below the example was that I'd like to use the JXTable facilities
to sort and filter, instead of layering SortedList and FilterList
adapters. There should be a simple way to do that with the stock
DefaultEventSelectionModel, converting every index to the model index.
If not I can write my own version I guess, but I was hoping to avoid
that.

Ted

>> On Sat, 29 Aug 2009 12:28:50 +0200 Holger Brands <hbrands@...> wrote:
>>
HB> there is some info about SwingX and GL here:
HB> http://sites.google.com/site/glazedlists/documentation/swingx

>>
>> First of all, GL is great. This is just one case where it's been hard
>> to use. I would not go back to non-GL programming, it would be painful.
>>
>> I tried the suggested
>>
>> EventListJXTableSorting sorting = EventListJXTableSorting.install(t, beans);
>> sorting.setMultipleColumnSort(true);
>>
>> but got many illegal state and null pointer errors, e.g. below. I also
>> don't like all the caveats and limitations of the suggested approaches.
>>
>> java.lang.IllegalStateException: Cannot combine reorder with other change events
>> at ca.odell.glazedlists.event.ListEventAssembler.reorder(ListEventAssembler.java:246)
>> at ca.odell.glazedlists.ListSelection.addSelectedReorder(ListSelection.java:852)
>> at ca.odell.glazedlists.ListSelection.listChanged(ListSelection.java:172)
>> at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:412)
>> at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:409)
>> at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher$SubjectAndListener.firePendingEvent(SequenceDependenciesEventPublisher.java:445)
>> at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher.fireEvent(SequenceDependenciesEventPublisher.java:344)
>> at ca.odell.glazedlists.event.ListEventAssembler.commitEvent(ListEventAssembler.java:316)
>> at ca.odell.glazedlists.SortedList.setComparator(SortedList.java:481)
>> at ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.setSortKeys(EventListJXTableSorting.java:228)
>> at ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.toggleSortOrder(EventListJXTableSorting.java:192)
>> at org.jdesktop.swingx.JXTable.toggleSortOrder(JXTable.java:2046)
>> at org.jdesktop.swingx.JXTableHeader$HeaderListener.doSort(JXTableHeader.java:608)
>> at org.jdesktop.swingx.JXTableHeader$HeaderListener.mouseClicked(JXTableHeader.java:589)
>> at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:253)
>> at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:252)
>> at java.awt.Component.processMouseEvent(Component.java:6266)
>> at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
>> at java.awt.Component.processEvent(Component.java:6028)
>> at java.awt.Container.processEvent(Container.java:2041)
>> at java.awt.Component.dispatchEventImpl(Component.java:4630)
>> at java.awt.Container.dispatchEventImpl(Container.java:2099)
>> at java.awt.Component.dispatchEvent(Component.java:4460)
>> at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
>> at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4247)
>> at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
>> at java.awt.Container.dispatchEventImpl(Container.java:2085)
>> at java.awt.Window.dispatchEventImpl(Window.java:2475)
>> at java.awt.Component.dispatchEvent(Component.java:4460)
>> at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
>> at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
>> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
>> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:178)
>> at java.awt.Dialog$1.run(Dialog.java:1045)
>> at java.awt.Dialog$3.run(Dialog.java:1097)
>> at java.security.AccessController.doPrivileged(Native Method)
>> at java.awt.Dialog.show(Dialog.java:1095)
>> at java.awt.Component.show(Component.java:1563)
>> at java.awt.Component.setVisible(Component.java:1515)
>> at java.awt.Window.setVisible(Window.java:841)
>> at java.awt.Dialog.setVisible(Dialog.java:985)
>> at com.jump.simple.Out.show(Out.java:851)
>> at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:199)
>> at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
>> at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
>> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
>> at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
>> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
>> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
>> at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
>>
>> This is the code I tried (see below for version without the EventListJXTableSorting):
>>
>> try
>> {
>> SwingUtilities.invokeAndWait(new Runnable()
>> {
>> public void run()
>> {
>> EventList<JLabel> labels = GlazedLists.eventListOf(new JLabel("a"), new JLabel("b"), new JLabel("c"), new JLabel("d"));
>> ObservableElementList.Connector<JLabel> labelConnector = GlazedLists.beanConnector(JLabel.class);
>> SortedList<JLabel> beans = new SortedList<JLabel>(new ObservableElementList<JLabel>(labels, labelConnector), new Comparator<JLabel>()
>> {
>> public int compare(JLabel o1, JLabel o2)
>> {
>> return o1.getText().compareTo(o2.getText());
>> }
>> });
>> // build a JTable
>> String[] propertyNames = { "text", };
>> TableFormat<JLabel> ltf = GlazedLists.tableFormat(JLabel.class, propertyNames, propertyNames);
>> final JXTable t = new JXTable(new DefaultEventTableModel<JLabel>(beans, ltf));
>> final JLabel view_selected = new JLabel("wrong");
>> final JLabel real_selected = new JLabel("right");
>> DefaultEventSelectionModel<JLabel> selModel = new DefaultEventSelectionModel<JLabel>(beans);
>> t.setSelectionModel(selModel);
>>
>> EventListJXTableSorting sorting = EventListJXTableSorting.install(t, beans);
>> sorting.setMultipleColumnSort(true);
>>
>> t.getSelectionModel().addListSelectionListener(new ListSelectionListener()
>> {
>> public void valueChanged(ListSelectionEvent e)
>> {
>> int[] rows = t.getSelectedRows();
>> int sel = rows.length < 1 ? -1 : rows[0];
>>
>> view_selected.setText("" + sel);
>> real_selected.setText("" + t.convertRowIndexToModel(sel));
>> }
>> });
>> JPanel show = new JPanel(new GridLayout(0, 1));
>> JList selList = new JList(new DefaultEventListModel<JLabel>(selModel.getSelected()));
>> selList.setCellRenderer(new DefaultListCellRenderer()
>> {
>> public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus)
>> {
>> JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
>> label.setText(((JLabel) value).getText());
>> return label;
>> }
>> });
>>
>> show.add(new JScrollPane(t));
>> show.add(new JScrollPane(selList));
>> show.add(view_selected);
>> show.add(real_selected);
>> Out.show(800, 600, show);
>> }
>> });
>> }
>> catch (Exception e)
>> {
>> e.printStackTrace();
>> }
>>
>>
>>

HB> I think there are some users combining SwingX with GL without problems,
HB> so to help you with your problem we need to know:
>>
HB> Which versions of SwingX and GL do you use?
>>
HB> How did you setup your JXTable?
>>
HB> A test program that demonstrates your issue would be ideal.

>>
>> Here's a simple example using JLabel lists. I'm using the latest dev
>> snapshot of glazed lists and the 1.0 SwingX release.
>>
>> EventList<JLabel> labels = GlazedLists.eventListOf(new JLabel("a"), new JLabel("b"), new JLabel("c"), new JLabel("d"));
>> ObservableElementList.Connector<JLabel> labelConnector = GlazedLists.beanConnector(JLabel.class);
>> ObservableElementList<JLabel> beans = new ObservableElementList<JLabel>(labels, labelConnector);
>> // build a JTable
>> String[] propertyNames = {"text",};
>> TableFormat<JLabel> ltf = GlazedLists.tableFormat(JLabel.class, propertyNames, propertyNames);
>> final JXTable t = new JXTable(new DefaultEventTableModel<JLabel>(beans, ltf));
>> final JLabel view_selected = new JLabel("wrong");
>> final JLabel real_selected = new JLabel("right");
>> DefaultEventSelectionModel<JLabel> selModel = new DefaultEventSelectionModel<JLabel>(beans);
>> t.setSelectionModel(selModel);
>>
>> t.getSelectionModel().addListSelectionListener(new ListSelectionListener()
>> {
>> public void valueChanged(ListSelectionEvent e)
>> {
>> int[] rows = t.getSelectedRows();
>> int sel = rows.length < 1 ? -1 : rows[0];
>>
>> view_selected.setText(""+sel);
>> real_selected.setText(""+t.convertRowIndexToModel(sel));
>> }
>> });
>> JPanel show = new JPanel(new GridLayout(0, 1));
>> JList selList = new JList(new DefaultEventListModel<JLabel>(selModel.getSelected()));
>> selList.setCellRenderer(new DefaultListCellRenderer()
>> {
>> public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus)
>> {
>> JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
>> label.setText(((JLabel)value).getText());
>> return label;
>> }
>> });
>>
>> show.add(new JScrollPane(t));
>> show.add(new JScrollPane(selList));
>> show.add(view_selected);
>> show.add(real_selected);
>> // show the JPanel now
>>
>> When unsorted, everything works. If you reverse-sort, though, selecting
>> elements 0 and 1 ("d" and "c") results in the selected list being "a"
>> and "b" (the view coordinates). The selection model needs to ask the
>> table to convert view rows to model rows, basically. I show this in the
>> real_selected vs. view_selected labels. The code has an exception for
>> -1 (nothing selected) but I didn't want to spend time polishing
>> irrelevant cases.
>>
>> My question, then, is: why not modify the DefaultEventSelectionModel to
>> ask the JXTable for the model coordinates of the selected data? At the
>> leat, mention that possibility in the SwingX compatiblity docs. I think
>> EventListJXTableSorting is too complicated and limiting for users who
>> like the JXTable sorting and filtering, plus as I showed it had some
>> issues (perhaps due to my inexperience using it).
>>
>> I would also suggest the docs for DefaultEventSelectionModel should
>> mention the SwingX issues clearly. If those issues are in the bug list,
>> point that out next to the bug URL.
>>
>> Thanks!
>> Ted
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>>

HB> ______________________________________________________
HB> GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
HB> Jetzt freischalten unter http://movieflat.web.de

--

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: selection support in GL

2009-09-01T12:34:18Z

Hi Ted,

in both examples you posted, you use DefaultEventSelectionModel with JXTable,
but I don't see where you disable the selection mapper.
The link I quoted states under section "Maintaining selection":

"It is necessary to disable the SelectionMapper to use JXTable with Glazed Lists.
Otherwise, the SelectionMapper competes with Glazed Lists' own selection management,
and selection is left in an inconsistent state."

Please try that first.
If any problem remains, please let us know.

Thanks,
Holger

> On Sat, 29 Aug 2009 12:28:50 +0200 Holger Brands <hbrands@...> wrote:
>
> HB> there is some info about SwingX and GL here:
> HB> http://sites.google.com/site/glazedlists/documentation/swingx
>
> First of all, GL is great. This is just one case where it's been hard
> to use. I would not go back to non-GL programming, it would be painful.
>
> I tried the suggested
>
> EventListJXTableSorting sorting = EventListJXTableSorting.install(t, beans);
> sorting.setMultipleColumnSort(true);
>
> but got many illegal state and null pointer errors, e.g. below. I also
> don't like all the caveats and limitations of the suggested approaches.
>
> java.lang.IllegalStateException: Cannot combine reorder with other change events
> at ca.odell.glazedlists.event.ListEventAssembler.reorder(ListEventAssembler.java:246)
> at ca.odell.glazedlists.ListSelection.addSelectedReorder(ListSelection.java:852)
> at ca.odell.glazedlists.ListSelection.listChanged(ListSelection.java:172)
> at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:412)
> at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:409)
> at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher$SubjectAndListener.firePendingEvent(SequenceDependenciesEventPublisher.java:445)
> at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher.fireEvent(SequenceDependenciesEventPublisher.java:344)
> at ca.odell.glazedlists.event.ListEventAssembler.commitEvent(ListEventAssembler.java:316)
> at ca.odell.glazedlists.SortedList.setComparator(SortedList.java:481)
> at ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.setSortKeys(EventListJXTableSorting.java:228)
> at ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.toggleSortOrder(EventListJXTableSorting.java:192)
> at org.jdesktop.swingx.JXTable.toggleSortOrder(JXTable.java:2046)
> at org.jdesktop.swingx.JXTableHeader$HeaderListener.doSort(JXTableHeader.java:608)
> at org.jdesktop.swingx.JXTableHeader$HeaderListener.mouseClicked(JXTableHeader.java:589)
> at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:253)
> at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:252)
> at java.awt.Component.processMouseEvent(Component.java:6266)
> at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
> at java.awt.Component.processEvent(Component.java:6028)
> at java.awt.Container.processEvent(Container.java:2041)
> at java.awt.Component.dispatchEventImpl(Component.java:4630)
> at java.awt.Container.dispatchEventImpl(Container.java:2099)
> at java.awt.Component.dispatchEvent(Component.java:4460)
> at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
> at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4247)
> at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
> at java.awt.Container.dispatchEventImpl(Container.java:2085)
> at java.awt.Window.dispatchEventImpl(Window.java:2475)
> at java.awt.Component.dispatchEvent(Component.java:4460)
> at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
> at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:178)
> at java.awt.Dialog$1.run(Dialog.java:1045)
> at java.awt.Dialog$3.run(Dialog.java:1097)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.awt.Dialog.show(Dialog.java:1095)
> at java.awt.Component.show(Component.java:1563)
> at java.awt.Component.setVisible(Component.java:1515)
> at java.awt.Window.setVisible(Window.java:841)
> at java.awt.Dialog.setVisible(Dialog.java:985)
> at com.jump.simple.Out.show(Out.java:851)
> at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:199)
> at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
> at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
> at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
> at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
> at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
>
> This is the code I tried (see below for version without the EventListJXTableSorting):
>
> try
> {
> SwingUtilities.invokeAndWait(new Runnable()
> {
> public void run()
> {
> EventList<JLabel> labels = GlazedLists.eventListOf(new JLabel("a"), new JLabel("b"), new JLabel("c"), new JLabel("d"));
> ObservableElementList.Connector<JLabel> labelConnector = GlazedLists.beanConnector(JLabel.class);
> SortedList<JLabel> beans = new SortedList<JLabel>(new ObservableElementList<JLabel>(labels, labelConnector), new Comparator<JLabel>()
> {
> public int compare(JLabel o1, JLabel o2)
> {
> return o1.getText().compareTo(o2.getText());
> }
> });
> // build a JTable
> String[] propertyNames = { "text", };
> TableFormat<JLabel> ltf = GlazedLists.tableFormat(JLabel.class, propertyNames, propertyNames);
> final JXTable t = new JXTable(new DefaultEventTableModel<JLabel>(beans, ltf));
> final JLabel view_selected = new JLabel("wrong");
> final JLabel real_selected = new JLabel("right");
> DefaultEventSelectionModel<JLabel> selModel = new DefaultEventSelectionModel<JLabel>(beans);
> t.setSelectionModel(selModel);
>
> EventListJXTableSorting sorting = EventListJXTableSorting.install(t, beans);
> sorting.setMultipleColumnSort(true);
>
> t.getSelectionModel().addListSelectionListener(new ListSelectionListener()
> {
> public void valueChanged(ListSelectionEvent e)
> {
> int[] rows = t.getSelectedRows();
> int sel = rows.length < 1 ? -1 : rows[0];
>
> view_selected.setText("" + sel);
> real_selected.setText("" + t.convertRowIndexToModel(sel));
> }
> });
> JPanel show = new JPanel(new GridLayout(0, 1));
> JList selList = new JList(new DefaultEventListModel<JLabel>(selModel.getSelected()));
> selList.setCellRenderer(new DefaultListCellRenderer()
> {
> public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus)
> {
> JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
> label.setText(((JLabel) value).getText());
> return label;
> }
> });
>
> show.add(new JScrollPane(t));
> show.add(new JScrollPane(selList));
> show.add(view_selected);
> show.add(real_selected);
> Out.show(800, 600, show);
> }
> });
> }
> catch (Exception e)
> {
> e.printStackTrace();
> }
>
>
>
> HB> I think there are some users combining SwingX with GL without problems,
> HB> so to help you with your problem we need to know:
>
> HB> Which versions of SwingX and GL do you use?
>
> HB> How did you setup your JXTable?
>
> HB> A test program that demonstrates your issue would be ideal.
>
> Here's a simple example using JLabel lists. I'm using the latest dev
> snapshot of glazed lists and the 1.0 SwingX release.
>
> EventList<JLabel> labels = GlazedLists.eventListOf(new JLabel("a"), new JLabel("b"), new JLabel("c"), new JLabel("d"));
> ObservableElementList.Connector<JLabel> labelConnector = GlazedLists.beanConnector(JLabel.class);
> ObservableElementList<JLabel> beans = new ObservableElementList<JLabel>(labels, labelConnector);
> // build a JTable
> String[] propertyNames = {"text",};
> TableFormat<JLabel> ltf = GlazedLists.tableFormat(JLabel.class, propertyNames, propertyNames);
> final JXTable t = new JXTable(new DefaultEventTableModel<JLabel>(beans, ltf));
> final JLabel view_selected = new JLabel("wrong");
> final JLabel real_selected = new JLabel("right");
> DefaultEventSelectionModel<JLabel> selModel = new DefaultEventSelectionModel<JLabel>(beans);
> t.setSelectionModel(selModel);
>
> t.getSelectionModel().addListSelectionListener(new ListSelectionListener()
> {
> public void valueChanged(ListSelectionEvent e)
> {
> int[] rows = t.getSelectedRows();
> int sel = rows.length < 1 ? -1 : rows[0];
>
> view_selected.setText(""+sel);
> real_selected.setText(""+t.convertRowIndexToModel(sel));
> }
> });
> JPanel show = new JPanel(new GridLayout(0, 1));
> JList selList = new JList(new DefaultEventListModel<JLabel>(selModel.getSelected()));
> selList.setCellRenderer(new DefaultListCellRenderer()
> {
> public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus)
> {
> JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
> label.setText(((JLabel)value).getText());
> return label;
> }
> });
>
> show.add(new JScrollPane(t));
> show.add(new JScrollPane(selList));
> show.add(view_selected);
> show.add(real_selected);
> // show the JPanel now
>
> When unsorted, everything works. If you reverse-sort, though, selecting
> elements 0 and 1 ("d" and "c") results in the selected list being "a"
> and "b" (the view coordinates). The selection model needs to ask the
> table to convert view rows to model rows, basically. I show this in the
> real_selected vs. view_selected labels. The code has an exception for
> -1 (nothing selected) but I didn't want to spend time polishing
> irrelevant cases.
>
> My question, then, is: why not modify the DefaultEventSelectionModel to
> ask the JXTable for the model coordinates of the selected data? At the
> leat, mention that possibility in the SwingX compatiblity docs. I think
> EventListJXTableSorting is too complicated and limiting for users who
> like the JXTable sorting and filtering, plus as I showed it had some
> issues (perhaps due to my inexperience using it).
>
> I would also suggest the docs for DefaultEventSelectionModel should
> mention the SwingX issues clearly. If those issues are in the bug list,
> point that out next to the bug URL.
>
> Thanks!
> Ted
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

Re: selection support in GL

2009-09-01T12:05:55Z

On Sat, 29 Aug 2009 12:28:50 +0200 Holger Brands <hbrands@...> wrote:

HB> there is some info about SwingX and GL here:
HB> http://sites.google.com/site/glazedlists/documentation/swingx

First of all, GL is great. This is just one case where it's been hard
to use. I would not go back to non-GL programming, it would be painful.

I tried the suggested

EventListJXTableSorting sorting = EventListJXTableSorting.install(t, beans);
sorting.setMultipleColumnSort(true);

but got many illegal state and null pointer errors, e.g. below. I also
don't like all the caveats and limitations of the suggested approaches.

java.lang.IllegalStateException: Cannot combine reorder with other change events
at ca.odell.glazedlists.event.ListEventAssembler.reorder(ListEventAssembler.java:246)
at ca.odell.glazedlists.ListSelection.addSelectedReorder(ListSelection.java:852)
at ca.odell.glazedlists.ListSelection.listChanged(ListSelection.java:172)
at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:412)
at ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:409)
at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher$SubjectAndListener.firePendingEvent(SequenceDependenciesEventPublisher.java:445)
at ca.odell.glazedlists.event.SequenceDependenciesEventPublisher.fireEvent(SequenceDependenciesEventPublisher.java:344)
at ca.odell.glazedlists.event.ListEventAssembler.commitEvent(ListEventAssembler.java:316)
at ca.odell.glazedlists.SortedList.setComparator(SortedList.java:481)
at ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.setSortKeys(EventListJXTableSorting.java:228)
at ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.toggleSortOrder(EventListJXTableSorting.java:192)
at org.jdesktop.swingx.JXTable.toggleSortOrder(JXTable.java:2046)
at org.jdesktop.swingx.JXTableHeader$HeaderListener.doSort(JXTableHeader.java:608)
at org.jdesktop.swingx.JXTableHeader$HeaderListener.mouseClicked(JXTableHeader.java:589)
at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:253)
at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:252)
at java.awt.Component.processMouseEvent(Component.java:6266)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
at java.awt.Component.processEvent(Component.java:6028)
at java.awt.Container.processEvent(Container.java:2041)
at java.awt.Component.dispatchEventImpl(Component.java:4630)
at java.awt.Container.dispatchEventImpl(Container.java:2099)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4247)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
at java.awt.Container.dispatchEventImpl(Container.java:2085)
at java.awt.Window.dispatchEventImpl(Window.java:2475)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:178)
at java.awt.Dialog$1.run(Dialog.java:1045)
at java.awt.Dialog$3.run(Dialog.java:1097)
at java.security.AccessController.doPrivileged(Native Method)
at java.awt.Dialog.show(Dialog.java:1095)
at java.awt.Component.show(Component.java:1563)
at java.awt.Component.setVisible(Component.java:1515)
at java.awt.Window.setVisible(Window.java:841)
at java.awt.Dialog.setVisible(Dialog.java:985)
at com.jump.simple.Out.show(Out.java:851)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:199)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

This is the code I tried (see below for version without the EventListJXTableSorting):

try
{
SwingUtilities.invokeAndWait(new Runnable()
{
public void run()
{
EventList<JLabel> labels = GlazedLists.eventListOf(new JLabel("a"), new JLabel("b"), new JLabel("c"), new JLabel("d"));
ObservableElementList.Connector<JLabel> labelConnector = GlazedLists.beanConnector(JLabel.class);
SortedList<JLabel> beans = new SortedList<JLabel>(new ObservableElementList<JLabel>(labels, labelConnector), new Comparator<JLabel>()
{
public int compare(JLabel o1, JLabel o2)
{
return o1.getText().compareTo(o2.getText());
}
});
// build a JTable
String[] propertyNames = { "text", };
TableFormat<JLabel> ltf = GlazedLists.tableFormat(JLabel.class, propertyNames, propertyNames);
final JXTable t = new JXTable(new DefaultEventTableModel<JLabel>(beans, ltf));
final JLabel view_selected = new JLabel("wrong");
final JLabel real_selected = new JLabel("right");
DefaultEventSelectionModel<JLabel> selModel = new DefaultEventSelectionModel<JLabel>(beans);
t.setSelectionModel(selModel);

EventListJXTableSorting sorting = EventListJXTableSorting.install(t, beans);
sorting.setMultipleColumnSort(true);

t.getSelectionModel().addListSelectionListener(new ListSelectionListener()
{
public void valueChanged(ListSelectionEvent e)
{
int[] rows = t.getSelectedRows();
int sel = rows.length < 1 ? -1 : rows[0];

view_selected.setText("" + sel);
real_selected.setText("" + t.convertRowIndexToModel(sel));
}
});
JPanel show = new JPanel(new GridLayout(0, 1));
JList selList = new JList(new DefaultEventListModel<JLabel>(selModel.getSelected()));
selList.setCellRenderer(new DefaultListCellRenderer()
{
public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus)
{
JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
label.setText(((JLabel) value).getText());
return label;
}
});

show.add(new JScrollPane(t));
show.add(new JScrollPane(selList));
show.add(view_selected);
show.add(real_selected);
Out.show(800, 600, show);
}
});
}
catch (Exception e)
{
e.printStackTrace();
}

HB> I think there are some users combining SwingX with GL without problems,
HB> so to help you with your problem we need to know:

HB> Which versions of SwingX and GL do you use?

HB> How did you setup your JXTable?

HB> A test program that demonstrates your issue would be ideal.

Here's a simple example using JLabel lists. I'm using the latest dev
snapshot of glazed lists and the 1.0 SwingX release.

EventList<JLabel> labels = GlazedLists.eventListOf(new JLabel("a"), new JLabel("b"), new JLabel("c"), new JLabel("d"));
ObservableElementList.Connector<JLabel> labelConnector = GlazedLists.beanConnector(JLabel.class);
ObservableElementList<JLabel> beans = new ObservableElementList<JLabel>(labels, labelConnector);
// build a JTable
String[] propertyNames = {"text",};
TableFormat<JLabel> ltf = GlazedLists.tableFormat(JLabel.class, propertyNames, propertyNames);
final JXTable t = new JXTable(new DefaultEventTableModel<JLabel>(beans, ltf));
final JLabel view_selected = new JLabel("wrong");
final JLabel real_selected = new JLabel("right");
DefaultEventSelectionModel<JLabel> selModel = new DefaultEventSelectionModel<JLabel>(beans);
t.setSelectionModel(selModel);

t.getSelectionModel().addListSelectionListener(new ListSelectionListener()
{
public void valueChanged(ListSelectionEvent e)
{
int[] rows = t.getSelectedRows();
int sel = rows.length < 1 ? -1 : rows[0];

view_selected.setText(""+sel);
real_selected.setText(""+t.convertRowIndexToModel(sel));
}
});
JPanel show = new JPanel(new GridLayout(0, 1));
JList selList = new JList(new DefaultEventListModel<JLabel>(selModel.getSelected()));
selList.setCellRenderer(new DefaultListCellRenderer()
{
public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus)
{
JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
label.setText(((JLabel)value).getText());
return label;
}
});

show.add(new JScrollPane(t));
show.add(new JScrollPane(selList));
show.add(view_selected);
show.add(real_selected);
// show the JPanel now

When unsorted, everything works. If you reverse-sort, though, selecting
elements 0 and 1 ("d" and "c") results in the selected list being "a"
and "b" (the view coordinates). The selection model needs to ask the
table to convert view rows to model rows, basically. I show this in the
real_selected vs. view_selected labels. The code has an exception for
-1 (nothing selected) but I didn't want to spend time polishing
irrelevant cases.

My question, then, is: why not modify the DefaultEventSelectionModel to
ask the JXTable for the model coordinates of the selected data? At the
leat, mention that possibility in the SwingX compatiblity docs. I think
EventListJXTableSorting is too complicated and limiting for users who
like the JXTable sorting and filtering, plus as I showed it had some
issues (perhaps due to my inexperience using it).

I would also suggest the docs for DefaultEventSelectionModel should
mention the SwingX issues clearly. If those issues are in the bug list,
point that out next to the bug URL.

Thanks!
Ted

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: selection support in GL

2009-08-29T03:28:50Z

Hi Ted,

there is some info about SwingX and GL here:
http://sites.google.com/site/glazedlists/documentation/swingx

I think there are some users combining SwingX with GL without problems,
so to help you with your problem we need to know:

Which versions of SwingX and GL do you use?

How did you setup your JXTable?

A test program that demonstrates your issue would be ideal.

Thanks,
Holger

> On Thu, 27 Aug 2009 09:38:35 -0700 James Lemieux <jplemieux@...> wrote:
>
> JL> 2009/8/27 Ted Zlatanov <tzz@...>
>
> >> It would be very nice if the GL had some knowledge of what's been
> >> selected in a list or table generated from it. Obviously that's not
> >> always possible, but at least a Matcher should be possible that glues
> >> together the selection control piece of the GUI view with the underlying
> >> model. Any suggestions?
>
> JL> EventSelectionModel does precisely this. If you start using it in place of
> JL> the traditional selection model you can ask it to furnish you with the
> JL> selected/unselected elements. Just make sure you pass the same EventList
> JL> into both your data model and selection model.
>
> I tried it with a JXTable/JXList and it doesn't work correctly. I'm
> guessing the model to view mappings are confusing it.
> JXTable.getSelectionMapper().setEnabled(false) locks up the EDT thread,
> so there's some strange interaction there.
>
> Ted
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>