Nabble - GlazedLists - Issues

[Issue 485] Additional constructor for CompositeList

2009-12-02T14:56:54Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=485

------- Additional comments from trumpetinc@... Wed Dec 2 22:56:54 +0000 2009 -------
PS - the static method below could be replaced to a call to the GlazedLists
method requested here: https://glazedlists.dev.java.net/issues/show_bug.cgi?id=483

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 485] New - Additional constructor for CompositeList

2009-12-02T14:55:46Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=485
Issue #|485
Summary|Additional constructor for CompositeList
Component|glazedlists
Version|0.9.1
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|core
Assigned to|jessewilson
Reported by|trumpetinc

------- Additional comments from trumpetinc@... Wed Dec 2 22:55:46 +0000 2009 -------
I often find that I need a composite list that merges the results of 2 or 3
fixed lists (i.e. those lists will never change). The following constructor
helps with two things:

1. It simplifies the code
2. It provides a workaround for issue 484 for a number of relatively common
cases (https://glazedlists.dev.java.net/issues/show_bug.cgi?id=484) (I'd still
prefer to get 484 fixed, of course)

public CompositeList(EventList<E>... sources) {
super(eventListFromArray(sources, sources[0].getPublisher(),
sources[0].getReadWriteLock()), (Model)GlazedLists.listCollectionListModel());

ListEventPublisher pub = sources[0].getPublisher();
ReadWriteLock lok = sources[0].getReadWriteLock();
for (EventList<E> eventList : sources) {
if (eventList.getPublisher() != pub)
throw new IllegalArgumentException("Member list must share
publisher with CompositeList");
if (eventList.getReadWriteLock() != lok)
throw new IllegalArgumentException("Member list must share lock
with CompositeList");
}
}

private static <E> EventList<E> eventListFromArray(E[] source,
ListEventPublisher publisher, ReadWriteLock lock){
EventList<E> l = new BasicEventList<E>(publisher, lock);
l.addAll(Arrays.asList(source));
return l;
}

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 484] CompositeList.addMemberList doesn't handle reentrancy

2009-12-02T14:51:27Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=484

------- Additional comments from trumpetinc@... Wed Dec 2 22:51:26 +0000 2009 -------
Created an attachment (id=50)
Unit test demonstrating issue

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 484] New - CompositeList.addMemberList doesn't handle reentrancy

2009-12-02T14:49:08Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=484
Issue #|484
Summary|CompositeList.addMemberList doesn't handle reentrancy
Component|glazedlists
Version|0.9.1
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|core
Assigned to|jessewilson
Reported by|trumpetinc

------- Additional comments from trumpetinc@... Wed Dec 2 22:49:07 +0000 2009 -------
If addMemberList is called on CompositeList as part of a list event response,
the change to the CompositeList is dropped.

Demonstrating this issue involves a fairly complex list pipeline. I've prepared
a unit test that demonstrates the issue.

As near as I can tell, the dropped event occurs because of two things in
SequenceDependenciesEventPublisher.fireEvent():

1. the loop that checks for subjects (the first for loop in the method) does
not find any entries for the addMemberList event (maybe a listener isn't getting
registered properly??)
2. reentrantFireEventCount is equal to 2 during the addMemberList event
handler, so processing delegates to the stack (but because of #1, nothing gets
added for the stack to handle)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 483] New - Add publisher and lock to eventList and eventListOf

2009-12-02T14:21:59Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=483
Issue #|483
Summary|Add publisher and lock to eventList and eventListOf
Component|glazedlists
Version|0.9.1
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|ENHANCEMENT
Priority|P3
Subcomponent|core
Assigned to|jessewilson
Reported by|trumpetinc

------- Additional comments from trumpetinc@... Wed Dec 2 22:21:59 +0000 2009 -------
Something along the lines of:

public static <E> EventList<E> eventList(ListEventPublisher publisher,
ReadWriteLock lock, Collection<? extends E> contents) {
final EventList<E> result = new BasicEventList<E>(contents == null ? 0 :
contents.size(), publisher, lock);
if(contents != null) result.addAll(contents);
return result;
}

and

public static <E> EventList<E> eventListOf(ListEventPublisher publisher,
ReadWriteLock lock, E... contents) {
return eventList(publisher, lock, contents == null ?
Collections.EMPTY_LIST : Arrays.asList(contents));
}

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 482] SequenceList duplicates first element if element is a sequence value

2009-10-12T11:44:33Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=482

------- Additional comments from rasss@... Mon Oct 12 18:44:33 +0000 2009 -------
Created an attachment (id=49)
Test Case

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 482] New - SequenceList duplicates first element if element is a sequence value

2009-10-12T11:35:16Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=482
Issue #|482
Summary|SequenceList duplicates first element if element is a
|sequence value
Component|glazedlists
Version|current
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|core
Assigned to|jessewilson
Reported by|rasss

------- Additional comments from rasss@... Mon Oct 12 18:35:15 +0000 2009 -------
The SequenceList duplicates the first element iff the first element of the source list is a sequence value
itself. The problem seems to come from the implementation of updateSequence. The if statement at line
220 inserts the same element twice into the result list (nextSequenceValue == previousSequenceValue).

The following test outputs: [1,1,2]

instead of [1,2]

public void testSequenceList() {
EventList<Integer> src = new BasicEventList<Integer>();
src.add(1);
src.add(2);

SequenceList<Integer> integers = new SequenceList<Integer>(src, new Sequencer<Integer>() {
public Integer next(Integer value) {
return value + 1;
}
public Integer previous(Integer value) {
return value - 1;
}
});

for (Integer value : integers) {
System.out.println(value);
}
}

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 481] New - SequenceDependenciesEventPublisher.clearRelatedListener() swapped parameters

2009-10-12T08:48:47Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=481
Issue #|481
Summary|SequenceDependenciesEventPublisher.clearRelatedListene
|r() swapped parameters
Component|glazedlists
Version|current
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|core
Assigned to|jessewilson
Reported by|brunomedeiros

------- Additional comments from brunomedeiros@... Mon Oct 12 15:48:47 +0000 2009 -------
Apparently SequenceDependenciesEventPublisher.clearRelatedListener() calls
removeListener with wrong swapped parameters:

public void clearRelatedListener(Object subject, Object relatedListener) {
removeListener(relatedListener, subject);
}

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 453] SeparatorList incorrectly throws ConcurrentModificationException when setting comparator

2009-08-18T07:07:45Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=453

------- Additional comments from phustad@... Tue Aug 18 14:07:45 +0000 2009 -------
Well, since this is a quite obvious bug and since I submitted a test case and a
fix, I would expect it to be quite safe and quick to patch. Anyway, I gave it 3
votes today :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 453] SeparatorList incorrectly throws ConcurrentModificationException when setting comparator

2009-08-18T05:51:04Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=453

------- Additional comments from kikonen@... Tue Aug 18 12:51:04 +0000 2009 -------
Is there fix coming for this? I was just hit by this issue.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 480] Add high performance version of FunctionList

2009-07-19T13:56:28Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=480

User brands changed the following:

What |Old value |New value
================================================================================
Status|NEW |RESOLVED
--------------------------------------------------------------------------------
Resolution| |FIXED
--------------------------------------------------------------------------------

------- Additional comments from brands@... Sun Jul 19 20:56:28 +0000 2009 -------
Added ca.odell.glazedlists.impl.SimpleFunctionList
and
GlazedLists#transformByFunction(EventList, Function)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 480] Add high performance version of FunctionList

2009-07-19T13:43:19Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=480

User brands changed the following:

What |Old value |New value
================================================================================
Assigned to|jessewilson |brands
--------------------------------------------------------------------------------
Target milestone|milestone 1 |1.9.0
--------------------------------------------------------------------------------

------- Additional comments from brands@... Sun Jul 19 20:43:18 +0000 2009 -------
reassigning...

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 478] Upgrade to SwingX 1.0

2009-07-19T11:49:37Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=478

User brands changed the following:

What |Old value |New value
================================================================================
CC|'' |'jplemieux'
--------------------------------------------------------------------------------
Status|NEW |RESOLVED
--------------------------------------------------------------------------------
Resolution| |FIXED
--------------------------------------------------------------------------------

------- Additional comments from brands@... Sun Jul 19 18:49:36 +0000 2009 -------
Uploaded SwingX 1.0 and changed build file to include it.
Seems to work fine with EventListJXTableSorting or TableComparatorChooser.

Since SwingX 0.9.5, usage of EventJXTableModel with JXTable seems to be
unnecessary, as SwingX fixed issue 924
(https://swingx.dev.java.net/issues/show_bug.cgi?id=924)
which also seems to fix our issue
https://glazedlists.dev.java.net/issues/show_bug.cgi?id=445

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 478] Upgrade to SwingX 1.0

2009-07-19T11:36:12Z

Re: GC of SWT Virtual TableItems (#160)

2009-07-19T09:39:09Z

Sorry, I correct myself. EventTableViewer removes it's rows by calling table.remove(int[] rows).
I checked that using DisposeListeners: the TableItems will be disposed after removing a row.

fab|an wrote:

Hi,

since I can't comment on https://glazedlists.dev.java.net/issues/show_bug.cgi?id=160, I add my comment here:

I believe this issue can be closed. I played around with virtual Tables and Trees for a while and found via a DisposeListener on the created Items out that SWT disposes them after using setItemCount() to notify the Table that they aren't needed anymore, which is exactly what GL does.

[Issue 479] EventListJXTableSorting.install sets the comparator to null

2009-07-19T09:10:33Z

[Issue 479] EventListJXTableSorting.install sets the comparator to null

2009-07-19T09:00:45Z

GC of SWT Virtual TableItems (#160)

2009-07-19T07:55:02Z

Hi,

since I can't comment on https://glazedlists.dev.java.net/issues/show_bug.cgi?id=160, I add my comment here:

I believe this issue can be closed. I played around with virtual Tables and Trees for a while and found via a DisposeListener on the created Items out that SWT disposes them after using setItemCount() to notify the Table that they aren't needed anymore, which is exactly what GL does.

[Issue 415] UniqueList fires unecessary updates

2009-07-15T05:48:21Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=415

User fabian_ changed the following:

What |Old value |New value
================================================================================
Attachment is patch| |Created an attachment (id=
| |48)
Patch for UniqueList

--------------------------------------------------------------------------------

------- Additional comments from fabian_@... Wed Jul 15 12:48:19 +0000 2009 -------
Created an attachment (id=48)
Patch for UniqueList

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 415] UniqueList fires unecessary updates

2009-07-15T05:47:23Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=415

------- Additional comments from fabian_@... Wed Jul 15 12:47:23 +0000 2009 -------
I attached a proposed fix. It adds another GrouperClient which doesn't fire
UPDATE-events, if a delete or insert into an unchanged group appears.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 480] New - Add high performance version of FunctionList

2009-07-10T07:19:16Z

>We frequently find ourselves needing to perform relatively simple
> transformations on lists (for example, pull a value out of a
> composite object):
>
> class A{
> public String val1;
> public String val2;
> }
>
> with a pipeline of:
>
> EventList<A> -> FunctionList<A, String>
>
> so this is pretty simple, right? The Function implementation is
> actually boring it's so simple.
>
> What I'm wondering is if FunctionList is too heavyweight for this
> sort of scenario. It actually holds onto a full list of String
> objects, instead of just delegating the get() to the function. Every
> list mutation winds up with relatively expensive array adjustments.
> The function would have to be forward only, but I rarely find the
> need to do that in these scenarios.
>

and suggested implementation from Holger Brands on mailing list 6/7/09:

public class SimpleFunctionList<S, E> extends TransformedList<S, E> {
private final Function<S,E> function;
public SimpleFunctionList(EventList<S> source, Function<S,E> function) {
super(source);
this.function = function;
source.addListEventListener(this);
}
public E get(int index) {
final S elem = source.get(index);
return function.evaluate(elem);
}
public void listChanged(ListEvent<S> listChanges) {
updates.forwardEvent(listChanges);
}
protected boolean isWritable() {
return false;
}
}

.. and used like this for the above example:

final EventList<Issue> issues = ...
final Function<Issue, String> function =
GlazedLists.beanFunction(Issue.class, "reporter");
final SimpleFunctionList<Issue, String> reporters = new
SimpleFunctionList<Issue, String>(issues, function);

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 464] TableComparatorChooser & wrong selection

2009-06-19T14:48:32Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=464

------- Additional comments from brianmerrill@... Fri Jun 19 21:48:31 +0000 2009 -------
Or rather, the lead selection should be a value greater than or *equal* to zero
but not negative.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 464] TableComparatorChooser & wrong selection

2009-06-19T14:43:34Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=464

------- Additional comments from brianmerrill@... Fri Jun 19 21:43:34 +0000 2009 -------
The above patch also contains an update to the JUnit test case for this issue,
i.e. "guiTestChangeSelectionByKeysInSortedState_FixMe". The test case checked
for a lead selection of -1 when it should be a value > 0 based upon the previous
setSelectionInterval(1, 1) call.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 464] TableComparatorChooser & wrong selection

2009-06-19T14:38:23Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=464

------- Additional comments from brianmerrill@... Fri Jun 19 21:38:23 +0000 2009 -------
Created an attachment (id=47)
Proposed patch (generated via Eclipse) to track changes to the lead and anchor indices by way of the reorder map to preserve keyboard selections.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 462] selection is lost when update on TreeList happens

2009-06-19T14:36:00Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=462

------- Additional comments from brianmerrill@... Fri Jun 19 21:36:00 +0000 2009 -------
Please disregard the previous attachment/patch. It was intended for Issue #464.
I apologize for any inconvenience.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 462] selection is lost when update on TreeList happens

2009-06-17T17:24:47Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=462

------- Additional comments from immudium@... Thu Jun 18 00:24:47 +0000 2009 -------
Created an attachment (id=46)
Proposed patch (generated via Eclipse) to track changes to the lead and anchor indices by way of the reorder map to preserve keyboard selections

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 463] incorrect jar index contains 'com' directory

2009-06-07T13:36:18Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=463

User brands changed the following:

What |Old value |New value
================================================================================
Target milestone|milestone 1 |1.9.0
--------------------------------------------------------------------------------

------- Additional comments from brands@... Sun Jun 7 20:36:18 +0000 2009 -------
for next release

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 479] EventListJXTableSorting.install sets the comparator to null

2009-06-07T13:34:47Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=479

User brands changed the following:

What |Old value |New value
================================================================================
Target milestone|milestone 1 |1.9.0
--------------------------------------------------------------------------------

------- Additional comments from brands@... Sun Jun 7 20:34:47 +0000 2009 -------
some more info:

Here is a thread dump for SortedList.setComparator(..)
produced with the sample app:

SortedList.setComparator(): null
java.lang.Exception: Stack trace
at java.lang.Thread.dumpStack(Thread.java:1158)
at ca.odell.glazedlists.SortedList.setComparator(SortedList.java:435)
at
ca.odell.glazedlists.swing.EventListJXTableSorting$EventListSortController.setSortKeys(EventListJXTableSorting.java:214)
at org.jdesktop.swingx.JXTable.setFilters(JXTable.java:1733)
at
ca.odell.glazedlists.swing.EventListJXTableSorting.<init>(EventListJXTableSorting.java:92)
at
ca.odell.glazedlists.swing.EventListJXTableSorting.install(EventListJXTableSorting.java:100)
at JXTableSorting.<init>(JXTableSorting.java:48)
at JXTableSorting$3.run(JXTableSorting.java:117)
...

EventListJXTableSorting.install(...) installs a new FilterPipeline on JXTable
to provide its own SortController (JXTable.setFilters(...)).
JXTable calls back into the new SorController to set the sort keys of the old
SortController, which appear to be null or empty in this case.
The EventListSortController tries to build a comparator from the sort keys,
see EventListSortController.setSortKeys(...)
If there are no sort keys, it sets the comparator of the SortedList to null.
This is what happens in the example app.

One thing we could do is to memorize the comparator of the SortedList at the
time EventListJXTableSorting.install(...) is called and restore this comparator
instead of null when EventListSortController.setSortKeys(...) is called with no
sort keys.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 479] New - EventListJXTableSorting.install sets the comparator to null

2009-06-07T13:32:45Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=479
Issue #|479
Summary|EventListJXTableSorting.install sets the comparator to
| null
Component|glazedlists
Version|current
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|swingx
Assigned to|jessewilson
Reported by|brands

------- Additional comments from brands@... Sun Jun 7 20:32:44 +0000 2009 -------
the call to EventListJXTableSorting.install(table, sortedList) is setting the
comparator to null, see the thread here for details:
https://glazedlists.dev.java.net/servlets/ReadMsg?list=users&msgNo=4094

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 478] Upgrade to SwingX 1.0

2009-06-07T13:29:35Z

[Issue 478] New - Upgrade to SwingX 1.0

2009-06-07T13:29:08Z

[Issue 477] New - TreeList doesn't paint expansion handles correctly

2009-06-04T09:19:18Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=477
Issue #|477
Summary|TreeList doesn't paint expansion handles correctly
Component|glazedlists
Version|current
Platform|All
OS/Version|All
URL|http://kari.world.dy.fi
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|treetable
Assigned to|jessewilson
Reported by|kikonen

------- Additional comments from kikonen@... Thu Jun 4 16:19:18 +0000 2009 -------
Expansion state rendering doesn't work in dynamic treetables

Scenario:
I've tree model, which is dynamically changing. I.e. children of the nodes
cannot be known until node is tried to be expanded; after that it's known if
node is leaf or not. This means that expansion handles must be shown all the
time that user can known that there might be some nodes under tree branch. And
not displaying expansion handles is not really an option either here.

TreeList of glazedlists fails with this since it will end up displaying expand
handle for node which didn't have any children. TreeExpansionModel is telling
that node don't have children, but appearently TreeList caches information
somewhere.

Thus TreeList should recalculate "can have children" if node changes.

As workaround, I attempted to set custom TreeCellRenderer, but this runned into
problems, since panel implementing expansion icon is to be private. This was
resolved by accessing field via reflection API; leading into nasty hack to
implement desired behaviour.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 476] Glazed Lists 1.8.0 breaks classloader (ECJ)

2009-06-01T13:40:41Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=476

------- Additional comments from brands@... Mon Jun 1 20:40:40 +0000 2009 -------
seems to be related to issue
https://glazedlists.dev.java.net/issues/show_bug.cgi?id=463
which was discovered and fixed after the 1.8.0 release.
You could try to regenerate the jar index of the Glazed Lists 1.8 jar file:
jar i <GL-jarfile>

Let us know if this helps.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 476] New - Glazed Lists 1.8.0 breaks classloader (ECJ)

2009-06-01T04:44:23Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=476
Issue #|476
Summary|Glazed Lists 1.8.0 breaks classloader (ECJ)
Component|glazedlists
Version|current
Platform|PC
OS/Version|Windows XP
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|core
Assigned to|jessewilson
Reported by|actualsystems

------- Additional comments from actualsystems@... Mon Jun 1 11:44:22 +0000 2009 -------
We don't know that this is an issue with glazed-lists, although upgrading to
1.8.0 (from 1.7.0) caused the problem to surface. An InvalidJarIndexException is
thrown at run-time.

We have a test case that does not use any classes from Glazed lists, but does
use Jasperreports which can use ECJ internally to compile Java code. When the
glazedlists-1.8.0.jar file is appended to the classpath, ECJ throws the
exception, causing the program to error. (Tested on XP and Vista using Java
1.6.0u13).

We have managed to reduce the problem to a test case. The problem seems to be
related to glazed lists, but we are not sure how. The classloader throws an
exception when navigating the the package of the test case; it loads the "com"
package correctly, but throws an InvalidJarException when trying to load the
"com.actual_systems" package (an ancestor package of the test case).

The problem occurs when the test case is in a sub-package at least three levels
deep, and when using glazedlists-1.8.0-java15.jar on the classpath. Replacing
glazedlists-1.8.0-java15.jar with 1.7.0-java15.jar, or removing it completely,
causes the error to go away and the program then works as expected. The program
also works as expected when placed in the main package or the "com" package.

The program can also be made to work by changing the text-field expression not
to include a reference back to the class (although this isn't a good workaround
for us).

The program also works if ECJ is removed from the classpath and
Glazedlists-1.8.0. is added (although the program won't then run without a Java
compiler, e.g. when run over web start). We have also tried different versions
of ECJ.

The test case is:

package com.actual_systems.p2.client.GUI.ReportPreview.TableReport;

import net.sf.jasperreports.engine.design.*;
import net.sf.jasperreports.engine.*;
import net.sf.jasperreports.engine.data.JRTableModelDataSource;
import net.sf.jasperreports.view.JasperViewer;

import javax.swing.*;
import javax.swing.table.TableColumnModel;
import javax.swing.table.TableModel;
import javax.swing.table.DefaultTableModel;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.*;
import java.sql.Timestamp;

/**
* JasperDesign to setup a report based on a JTable
*/
public class TableJasperDesign extends JasperDesign {
private static final int LANDSCAPE_TOTAL_PAGE_WIDTH = 791;
private static final int LANDSCAPE_TOTAL_PAGE_HEIGHT = 595;
private static final int LANDSCAPE_MARGIN_HEIGHT = 40;
private static final int LANDSCAPE_MARGIN_WIDTH = 50;

/**
* the printable area of the page (the width of the page minus the right and
left margins)
*/
public static final int PORTRAIT_PRINTABLE_PAGE_WIDTH = 595 - (2 * 40);

/**
* the printable area of the page (the width of the page minus the right and
left margins)
*/
public static final int LANDSCAPE_PRINTABLE_PAGE_WIDTH = 791 - (2 * 50);

private static final int SPACE_BETWEEN_COLUMNS = 5;

/**
* Scaling factor from JTable width to report width
*/
private final double widthScale;

public static final String REPORT_TITLE_KEY = "ReportTitle";
private static final String REPORT_CLASSNAME = "DynamicReport";
private TableColumnModel columnModel;
private TableModel dataModel;

/**
* Construct the report
*
* @param table JTable containing data and column models to use
* @throws JRException on error
*/
public TableJasperDesign(JTable table) throws JRException {
this.columnModel = table.getColumnModel();
this.dataModel = table.getModel();

widthScale = (double) LANDSCAPE_PRINTABLE_PAGE_WIDTH / (double)
columnModel.getTotalColumnWidth();
setOrientation(JasperDesign.ORIENTATION_LANDSCAPE);

setupPage();
setupDetailBand();
}

/**
* Sets up the detail band, which shows the data
*/
private void setupDetailBand() {
// Create a band and set the height.
JRDesignBand band = new JRDesignBand();
band.setHeight(14);

for (int col = 0, xPos = 0; col < columnModel.getColumnCount(); ++col) {

// get the column width from the table model
int colWidth = getScaledColWidth(col);

// Create the designTextField and place the field type
// make sure these values can overflow
JRDesignTextField textField = new JRDesignTextField();
textField.setStretchWithOverflow(true);
textField.setX(xPos);
textField.setY(2);
textField.setWidth(colWidth);
textField.setHeight(12);
textField.setPositionType(JRElement.POSITION_TYPE_FLOAT);

JRDesignExpression expression = new JRDesignExpression();
Class type = String.class;
expression.setValueClass(type);
expression.setText(getClass().getName() +
".stripHTML(\"<html>TEST</html>\")");
textField.setExpression(expression);
band.addElement(textField);

xPos += colWidth + SPACE_BETWEEN_COLUMNS;
}

setDetail(band);
}

/**
* Scale a column from a JTable into the report
*
* @param col Column Index
* @return colWidth
*/
private int getScaledColWidth(int col) {
int colWidth = columnModel.getColumn(col).getWidth();
colWidth = (int) (colWidth * widthScale);
colWidth -= SPACE_BETWEEN_COLUMNS;
return colWidth;
}

/**
* Setup the page settings (page height, width, margins etc.)
*/
private void setupPage() {
setName(REPORT_CLASSNAME);
setPageWidth(LANDSCAPE_TOTAL_PAGE_WIDTH);
setPageHeight(LANDSCAPE_TOTAL_PAGE_HEIGHT);
setColumnWidth(LANDSCAPE_PRINTABLE_PAGE_WIDTH);
setLeftMargin(LANDSCAPE_MARGIN_WIDTH);
setRightMargin(LANDSCAPE_MARGIN_WIDTH);
setTopMargin(LANDSCAPE_MARGIN_HEIGHT);
setBottomMargin(LANDSCAPE_MARGIN_HEIGHT);
setColumnSpacing(0);
}

/**
* Return the table data
*
* @return rtn
*/
public JRTableModelDataSource getTableModel() {
return new JRTableModelDataSource(dataModel) {
private final DateFormat dateFormetter = new SimpleDateFormat("dd/MM");

public Object getFieldValue(JRField jrField) throws JRException {
Object rtn = super.getFieldValue(jrField);
if (rtn == null) {
rtn = "-";
} else if (rtn instanceof Date) {
rtn = dateFormetter.format((Date) rtn);
}
return rtn.toString();
}
};
}

/**
* Compile the report and use JasperFillManager to fill the report with the
required data.
*
* @return printed - the completed report
* @throws JRException on error
*/
public JasperPrint compileAndPrintReport() throws JRException {
JRTableModelDataSource tableModel = getTableModel();
JasperReport report = JasperCompileManager.compileReport(this);
return JasperFillManager.fillReport(report, new HashMap<String,
Object>(), tableModel);
}

/*
In Jtables it is easier to render mul;tilines using the HTMLCell renderer.
Unfortunately this does not work for JasperReports printing tables
so we need to translate the HTML into equivalent eg to "\n"
*/
public static String stripHTML(String htmlString) {

String value = htmlString;
if (value.toUpperCase().indexOf("<HTML>") != -1) {
if (value.toUpperCase().indexOf(" ") != -1) {
value = htmlString.replaceAll("<[bB][rR]>", "\n");
}
value = value.replaceAll("<.*?>", "");
// if (logger.isDebugEnabled()) logger.debug("value = " + value);
}
return value;
}

// Test methods:

public static void main(String args[]) throws JRException {
// set up the map for testing purposes.
JTable table = makeTestData();
TableJasperDesign jasperDesign = new TableJasperDesign(table);
JasperPrint printed = jasperDesign.compileAndPrintReport();
JasperViewer.viewReport(printed);
}

private static JTable makeTestData() {
Vector<String> colNames = new Vector<String>();
colNames.add("Id");
colNames.add("FirstName");
colNames.add("LastName");
colNames.add("Street Address etc.");
colNames.add("City");
colNames.add("Country");
colNames.add("Telephone Number");
colNames.add("Postcode");
colNames.add("Date");

DateFormat df = new SimpleDateFormat();
Timestamp time = new Timestamp(System.currentTimeMillis());
String date = df.format(time);

TableModel rtn = new DefaultTableModel(colNames, 50);
int i = 1;
for (; i <= rtn.getRowCount(); ++i) {
//data.add(new TestVO(Integer.valueOf(i), "FirstName " + i,
"LastName " + i, "Street " + i));
rtn.setValueAt(i, i - 1, 0);
rtn.setValueAt("<html>First Name " + i + "</html>", i - 1, 1);
rtn.setValueAt("<html>Last Name " + i + "</html>", i - 1, 2);
rtn.setValueAt("Street Address " + i, i - 1, 3);
rtn.setValueAt("City " + i, i - 1, 4);
rtn.setValueAt("Country" + i, i - 1, 5);
rtn.setValueAt("Telephone Number" + i, i - 1, 6);
rtn.setValueAt("PCode " + i, i - 1, 7);
rtn.setValueAt(date, i - 1, 8);
}
return new JTable(rtn);
}

}

The error reported is:

Exception in thread "main" net.sf.jasperreports.engine.JRException: Error
compiling report design.
at
net.sf.jasperreports.engine.design.JRAbstractCompiler.compileReport(JRAbstractCompiler.java:231)
at
net.sf.jasperreports.engine.JasperCompileManager.compileReport(JasperCompileManager.java:219)
at
com.actualsystems.p2.client.GUI.ReportPreview.TableReport.TableJasperDesign.compileAndPrintReport(TableJasperDesign.java:158)
at
com.actualsystems.p2.client.GUI.ReportPreview.TableReport.TableJasperDesign.main(TableJasperDesign.java:188)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:90)
Caused by: sun.misc.InvalidJarIndexException: Invalid index
at sun.misc.URLClassPath$JarLoader.getResource(URLClassPath.java:854)
at sun.misc.URLClassPath$JarLoader.getResource(URLClassPath.java:762)
at sun.misc.URLClassPath$JarLoader.findResource(URLClassPath.java:732)
at sun.misc.URLClassPath.findResource(URLClassPath.java:145)
at java.net.URLClassLoader$2.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findResource(URLClassLoader.java:359)
at java.lang.ClassLoader.getResource(ClassLoader.java:978)
at java.lang.ClassLoader.getResourceAsStream(ClassLoader.java:1168)
at
net.sf.jasperreports.engine.design.JRJdtCompiler.getResource(JRJdtCompiler.java:567)
at
net.sf.jasperreports.engine.design.JRJdtCompiler$1.findType(JRJdtCompiler.java:271)
at
net.sf.jasperreports.engine.design.JRJdtCompiler$1.findType(JRJdtCompiler.java:229)
at
org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:119)
at
org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
at
org.eclipse.jdt.internal.compiler.lookup.BlockScope.getBinding(BlockScope.java:397)
at
org.eclipse.jdt.internal.compiler.ast.QualifiedNameReference.resolveType(QualifiedNameReference.java:874)
at
org.eclipse.jdt.internal.compiler.ast.MessageSend.resolveType(MessageSend.java:258)
at
org.eclipse.jdt.internal.compiler.ast.CastExpression.resolveType(CastExpression.java:392)
at
org.eclipse.jdt.internal.compiler.ast.Assignment.resolveType(Assignment.java:181)
at org.eclipse.jdt.internal.compiler.ast.Expression.resolve(Expression.java:829)
at org.eclipse.jdt.internal.compiler.ast.Block.resolve(Block.java:101)
at org.eclipse.jdt.internal.compiler.ast.Statement.resolveCase(Statement.java:140)
at
org.eclipse.jdt.internal.compiler.ast.SwitchStatement.resolve(SwitchStatement.java:279)
at
org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:418)
at
org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:178)
at
org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:396)
at
org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1072)
at
org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1121)
at
org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:305)
at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:512)
at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:329)
at
net.sf.jasperreports.engine.design.JRJdtCompiler.compileUnits(JRJdtCompiler.java:192)
at
net.sf.jasperreports.engine.design.JRAbstractCompiler.compileReport(JRAbstractCompiler.java:190)
... 8 more

The third-party JAR versions we are using are:

commons-collections-3.1.jar
commons-digester-1.7.jar
commons-javaflow-20060411.jar
commons-logging.jar (unknown version)
ireport.jar (unknown version)
itext-1.4.jar
jasperreports-3.0.0.jar
jdt-compiler-3.1.1.jar (ECJ; we have also tried newer versions without success)
commons-collections-3.1.jar

All obtained through the Jasper Reports website
http://jasperforge.org/projects/jasperreports

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[Issue 475] New - IndexOutOfBoundsException when changing a filter using a JideTable under 1.8.0

2009-05-27T07:58:51Z

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=475
Issue #|475
Summary|IndexOutOfBoundsException when changing a filter using
| a JideTable under 1.8.0
Component|glazedlists
Version|current
Platform|PC
OS/Version|other
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|swing
Assigned to|jessewilson
Reported by|actualsystems

------- Additional comments from actualsystems@... Wed May 27 14:58:50 +0000 2009 -------
Our test case uses JideTable from the Jide grids package:
(http://www.jidesoft.com/javadoc/com/jidesoft/grid/JideTable.html)
(jide-grids.jar and jide-common.jar).

Tested using Windows Vista and a 32-bit JVM (1.6) and Jide-grids.jar version
(from the MANIFEST.MF) Jide-Version: 2.1.2.02

The following test case reproduces the problem, and changing t from being a
JideTable to a JTable causes it not to occur. This test case works under
GlazedLists 1.7.0.

import ca.odell.glazedlists.*;
import ca.odell.glazedlists.gui.TableFormat;
import ca.odell.glazedlists.swing.*;
import com.jidesoft.grid.JideTable;

import javax.swing.*;
import javax.swing.text.JTextComponent;
import java.awt.*;
import java.lang.reflect.InvocationTargetException;
import java.util.List;

/**
* Test for a bug in Glazed Lists filtering
* If a selection is on the screen, and the filter changes so that the selected
row index no longer exists,
* we get an IndexOutOfBoundsException
*/
public class TestFilterBug implements Runnable {

private static final EventList<String> base = new DebugList<String>();

public static void main(String[] args) throws InvocationTargetException,
InterruptedException {
SwingUtilities.invokeLater(new TestFilterBug());

Thread.sleep(500); // show window

base.getReadWriteLock().writeLock().lock();
try {
base.add("C");
base.add("B");
base.add("A");
} finally {
base.getReadWriteLock().writeLock().unlock();
}

}

public void run() {
try {
JFrame f = new JFrame();
f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
JTable t = new JideTable();
f.getContentPane().setLayout(new BorderLayout());
JTextComponent filter = new JTextField();
f.getContentPane().add(filter, BorderLayout.NORTH);
f.getContentPane().add(new JScrollPane(t), BorderLayout.CENTER);

FilterList<String> filtered = new FilterList<String>(base, new
TextComponentMatcherEditor<String>(filter, new TextFilterator<String>() {
public void getFilterStrings(List<String> baseList, String
element) {
baseList.add(element);
}
}));
f.pack();

t.setModel(new EventTableModel<String>(filtered, new
TableFormat<String>() {
public int getColumnCount() {
return 3;
}

public String getColumnName(int column) {
return "X";
}

public Object getColumnValue(String baseObject, int column) {
return baseObject + column;
}
}));

t.setSelectionModel(new EventSelectionModel<String>(filtered));

f.setVisible(true);

Thread.sleep(1000); // wait for list

t.getSelectionModel().setSelectionInterval(2, 2);

filter.setText("X");
} catch (Throwable t) {
System.out.println(t.getMessage());
t.printStackTrace();
System.exit(0);
}
}

}

Program output:

Index: 2, Size: 0
java.lang.IndexOutOfBoundsException: Index: 2, Size: 0
at java.util.ArrayList.RangeCheck(ArrayList.java:547)
at java.util.ArrayList.get(ArrayList.java:322)
at
ca.odell.glazedlists.impl.gui.ThreadProxyEventList.get(ThreadProxyEventList.java:136)
at ca.odell.glazedlists.ListSelection.setAllColor(ListSelection.java:544)
at ca.odell.glazedlists.ListSelection.deselectAll(ListSelection.java:524)
at
ca.odell.glazedlists.ListSelection.setAnchorSelectionIndex(ListSelection.java:799)
at
ca.odell.glazedlists.swing.EventSelectionModel.setAnchorSelectionIndex(EventSelectionModel.java:314)
at com.jidesoft.grid.JideTable.d(Unknown Source)
at com.jidesoft.grid.JideTable.b(Unknown Source)
at com.jidesoft.grid.JideTable.tableChanged(Unknown Source)
at
javax.swing.table.AbstractTableModel.fireTableChanged(AbstractTableModel.java:280)
at
ca.odell.glazedlists.swing.EventTableModel.handleListChange(EventTableModel.java:189)
at ca.odell.glazedlists.swing.EventTableModel.listChanged(EventTableModel.java:170)
at
ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:412)
at
ca.odell.glazedlists.event.ListEventAssembler$ListEventFormat.fire(ListEventAssembler.java:409)
at
ca.odell.glazedlists.event.SequenceDependenciesEventPublisher$SubjectAndListener.firePendingEvent(SequenceDependenciesEventPublisher.java:445)
at
ca.odell.glazedlists.event.SequenceDependenciesEventPublisher.fireEvent(SequenceDependenciesEventPublisher.java:344)
at
ca.odell.glazedlists.event.ListEventAssembler.commitEvent(ListEventAssembler.java:316)
at ca.odell.glazedlists.FilterList.constrained(FilterList.java:389)
at ca.odell.glazedlists.FilterList.changeMatcher(FilterList.java:286)
at ca.odell.glazedlists.FilterList.changeMatcherWithLocks(FilterList.java:269)
at ca.odell.glazedlists.FilterList.access$100(FilterList.java:51)
at
ca.odell.glazedlists.FilterList$PrivateMatcherEditorListener.changedMatcher(FilterList.java:443)
at
ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireChangedMatcher(AbstractMatcherEditor.java:115)
at
ca.odell.glazedlists.matchers.AbstractMatcherEditor.fireConstrained(AbstractMatcherEditor.java:73)
at
ca.odell.glazedlists.matchers.TextMatcherEditor.setTextMatcher(TextMatcherEditor.java:321)
at
ca.odell.glazedlists.matchers.TextMatcherEditor.setFilterText(TextMatcherEditor.java:292)
at
ca.odell.glazedlists.swing.TextComponentMatcherEditor.refilter(TextComponentMatcherEditor.java:209)
at
ca.odell.glazedlists.swing.TextComponentMatcherEditor.access$100(TextComponentMatcherEditor.java:44)
at
ca.odell.glazedlists.swing.TextComponentMatcherEditor$FilterHandler.insertUpdate(TextComponentMatcherEditor.java:221)
at javax.swing.text.AbstractDocument.fireInsertUpdate(AbstractDocument.java:185)
at javax.swing.text.AbstractDocument.handleInsertString(AbstractDocument.java:734)
at javax.swing.text.AbstractDocument.insertString(AbstractDocument.java:693)
at javax.swing.text.PlainDocument.insertString(PlainDocument.java:114)
at javax.swing.text.AbstractDocument.replace(AbstractDocument.java:655)
at javax.swing.text.JTextComponent.setText(JTextComponent.java:1693)
at
com.actual_systems.p2.client.GUI.workordermanager.TestFilterBug.run(TestFilterBug.java:86)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
at
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Process finished with exit code 0

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...