tag:old.nabble.com,2006:forum-1300Nabble - Gnome - Evolution - Patches2009-11-14T20:24:28Ztag:old.nabble.com,2006:post-26356400[PATCH 1/1] Adjust DList names to make sense.2009-11-14T20:24:28Z2009-11-14T20:24:28ZMatthew W. S. Bell-2Hi,
<br>I recently spent a fun afternoon trying to work out why dlist->tail
<br>didn't do what I expected it to (I'm not very bright). After working out
<br>that tailpred (tail predecessor) was what I wanted and that tail was
<br>never used, I couldn't see any reason for the fields to be named
<br>according to their use. So here it is.
<br><br>Matthew W.S. Bell
<br><br>From: Matthew W. S. Bell <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26356400&i=0" target="_top" rel="nofollow">matthew@...</a>>
<br>---
<br> camel/camel-block-file.c | 2 +-
<br> camel/camel-iconv.c | 22 +++++++++++-----------
<br> camel/camel-list-utils.c | 20 ++++++++++----------
<br> camel/camel-list-utils.h | 8 ++++----
<br> camel/camel-text-index.c | 2 +-
<br> libedataserver/e-iconv.c | 22 +++++++++++-----------
<br> libedataserver/e-msgport.c | 22 +++++++++++-----------
<br> libedataserver/e-msgport.h | 4 ++--
<br> 8 files changed, 51 insertions(+), 51 deletions(-)
<br><br>diff --git a/camel/camel-block-file.c b/camel/camel-block-file.c
<br>index 673ff80..06d1361 100644
<br>--- a/camel/camel-block-file.c
<br>+++ b/camel/camel-block-file.c
<br>@@ -574,7 +574,7 @@ CamelBlock *camel_block_file_get_block(CamelBlockFile *bs, camel_block_t id)
<br> g_hash_table_insert(bs->blocks, GUINT_TO_POINTER(bl->id), bl);
<br>
<br> /* flush old blocks */
<br>- flush = (CamelBlock *)bs->block_cache.tailpred;
<br>+ flush = (CamelBlock *)bs->block_cache.tail;
<br> prev = flush->prev;
<br> while (bs->block_cache_count > bs->block_cache_limit && prev) {
<br> if (flush->refcount == 0) {
<br>diff --git a/camel/camel-iconv.c b/camel/camel-iconv.c
<br>index 2533d1f..78c87a6 100644
<br>--- a/camel/camel-iconv.c
<br>+++ b/camel/camel-iconv.c
<br>@@ -60,11 +60,11 @@ typedef struct _CamelDListNode {
<br>
<br> typedef struct _CamelDList {
<br> struct _CamelDListNode *head;
<br>+ struct _CamelDListNode *terminator;
<br> struct _CamelDListNode *tail;
<br>- struct _CamelDListNode *tailpred;
<br> } CamelDList;
<br>
<br>-#define CAMEL_DLIST_INITIALISER(l) { (CamelDListNode *)&l.tail, 0, (CamelDListNode *)&l.head }
<br>+#define CAMEL_DLIST_INITIALISER(l) { (CamelDListNode *)&l.terminator, 0, (CamelDListNode *)&l.head }
<br>
<br> struct _iconv_cache_node {
<br> struct _iconv_cache_node *next;
<br>@@ -160,9 +160,9 @@ struct {
<br> and g_list's are f@@#$ed up to make this a hassle */
<br> static void camel_dlist_init(CamelDList *v)
<br> {
<br>- v->head = (CamelDListNode *)&v->tail;
<br>- v->tail = NULL;
<br>- v->tailpred = (CamelDListNode *)&v->head;
<br>+ v->head = (CamelDListNode *)&v->terminator;
<br>+ v->terminator = NULL;
<br>+ v->tail = (CamelDListNode *)&v->head;
<br> }
<br>
<br> static CamelDListNode *camel_dlist_addhead(CamelDList *l, CamelDListNode *n)
<br>@@ -176,10 +176,10 @@ static CamelDListNode *camel_dlist_addhead(CamelDList *l, CamelDListNode *n)
<br>
<br> static CamelDListNode *camel_dlist_addtail(CamelDList *l, CamelDListNode *n)
<br> {
<br>- n->next = (CamelDListNode *)&l->tail;
<br>- n->prev = l->tailpred;
<br>- l->tailpred->next = n;
<br>- l->tailpred = n;
<br>+ n->next = (CamelDListNode *)&l->terminator;
<br>+ n->prev = l->tail;
<br>+ l->tail->next = n;
<br>+ l->tail = n;
<br> return n;
<br> }
<br>
<br>@@ -467,7 +467,7 @@ camel_iconv_open (const gchar *oto, const gchar *ofrom)
<br> if (ic) {
<br> camel_dlist_remove((CamelDListNode *)ic);
<br> } else {
<br>- struct _iconv_cache *last = (struct _iconv_cache *)iconv_cache_list.tailpred;
<br>+ struct _iconv_cache *last = (struct _iconv_cache *)iconv_cache_list.tail;
<br> struct _iconv_cache *prev;
<br>
<br> prev = last->prev;
<br>@@ -496,7 +496,7 @@ camel_iconv_open (const gchar *oto, const gchar *ofrom)
<br> camel_dlist_addhead(&iconv_cache_list, (CamelDListNode *)ic);
<br>
<br> /* If we have a free iconv, use it */
<br>- in = (struct _iconv_cache_node *)ic->open.tailpred;
<br>+ in = (struct _iconv_cache_node *)ic->open.tail;
<br> if (in->prev && !in->busy) {
<br> cd(printf("using existing iconv converter '%s'\n", ic->conv));
<br> ip = in->ip;
<br>diff --git a/camel/camel-list-utils.c b/camel/camel-list-utils.c
<br>index bf9489b..2e9b7e5 100644
<br>--- a/camel/camel-list-utils.c
<br>+++ b/camel/camel-list-utils.c
<br>@@ -38,9 +38,9 @@
<br> void
<br> camel_dlist_init (CamelDList *v)
<br> {
<br>- v->head = (CamelDListNode *)&v->tail;
<br>- v->tail = NULL;
<br>- v->tailpred = (CamelDListNode *)&v->head;
<br>+ v->head = (CamelDListNode *)&v->terminator;
<br>+ v->terminator = NULL;
<br>+ v->tail = (CamelDListNode *)&v->head;
<br> }
<br>
<br> /**
<br>@@ -74,10 +74,10 @@ camel_dlist_addhead (CamelDList *l, CamelDListNode *n)
<br> CamelDListNode *
<br> camel_dlist_addtail (CamelDList *l, CamelDListNode *n)
<br> {
<br>- n->next = (CamelDListNode *)&l->tail;
<br>- n->prev = l->tailpred;
<br>- l->tailpred->next = n;
<br>- l->tailpred = n;
<br>+ n->next = (CamelDListNode *)&l->terminator;
<br>+ n->prev = l->tail;
<br>+ l->tail->next = n;
<br>+ l->tail = n;
<br> return n;
<br> }
<br>
<br>@@ -135,11 +135,11 @@ camel_dlist_remtail (CamelDList *l)
<br> {
<br> CamelDListNode *n, *np;
<br>
<br>- n = l->tailpred;
<br>+ n = l->tail;
<br> np = n->prev;
<br> if (np) {
<br> np->next = n->next;
<br>- l->tailpred = np;
<br>+ l->tail = np;
<br> return n;
<br> }
<br> return NULL;
<br>@@ -156,7 +156,7 @@ camel_dlist_remtail (CamelDList *l)
<br> gint
<br> camel_dlist_empty (CamelDList *l)
<br> {
<br>- return (l->head == (CamelDListNode *)&l->tail);
<br>+ return (l->head == (CamelDListNode *)&l->terminator);
<br> }
<br>
<br> /**
<br>diff --git a/camel/camel-list-utils.h b/camel/camel-list-utils.h
<br>index e75ef23..e5cb5f0 100644
<br>--- a/camel/camel-list-utils.h
<br>+++ b/camel/camel-list-utils.h
<br>@@ -55,8 +55,8 @@ struct _CamelDListNode {
<br> * struct _CamelDList - A double-linked list header.
<br> *
<br> * @head: The head node's next pointer.
<br>- * @tail: The tail node's next pointer.
<br>- * @tailpred: The previous node to the tail node.
<br>+ * @terminator: The head's prev and tail's next pointer.
<br>+ * @tail: The tail node's prev pointer.
<br> *
<br> * This is the merging of two separate head and tail nodes into a
<br> * single structure. i.e. if you ahve a NULL terminated head and tail
<br>@@ -68,11 +68,11 @@ struct _CamelDListNode {
<br> **/
<br> struct _CamelDList {
<br> struct _CamelDListNode *head;
<br>+ struct _CamelDListNode *terminator;
<br> struct _CamelDListNode *tail;
<br>- struct _CamelDListNode *tailpred;
<br> };
<br>
<br>-#define CAMEL_DLIST_INITIALISER(l) { (CamelDListNode *)&l.tail, 0, (CamelDListNode *)&l.head }
<br>+#define CAMEL_DLIST_INITIALISER(l) { (CamelDListNode *)&l.terminator, 0, (CamelDListNode *)&l.head }
<br>
<br> void camel_dlist_init(CamelDList *v);
<br> CamelDListNode *camel_dlist_addhead(CamelDList *l, CamelDListNode *n);
<br>diff --git a/camel/camel-text-index.c b/camel/camel-text-index.c
<br>index f696fd7..e6453b3 100644
<br>--- a/camel/camel-text-index.c
<br>+++ b/camel/camel-text-index.c
<br>@@ -214,7 +214,7 @@ text_index_add_name_to_word(CamelIndex *idx, const gchar *word, camel_key_t name
<br> g_hash_table_insert(p->words, w->word, w);
<br> camel_dlist_addhead(&p->word_cache, (CamelDListNode *)w);
<br> p->word_cache_count++;
<br>- ww = (struct _CamelTextIndexWord *)p->word_cache.tailpred;
<br>+ ww = (struct _CamelTextIndexWord *)p->word_cache.tail;
<br> wp = ww->prev;
<br> while (wp && p->word_cache_count > p->word_cache_limit) {
<br> io(printf("writing key file entry '%s' [%x]\n", ww->word, ww->data));
<br>diff --git a/libedataserver/e-iconv.c b/libedataserver/e-iconv.c
<br>index 411f71c..61f5bd4 100644
<br>--- a/libedataserver/e-iconv.c
<br>+++ b/libedataserver/e-iconv.c
<br>@@ -60,11 +60,11 @@ typedef struct _EDListNode {
<br>
<br> typedef struct _EDList {
<br> struct _EDListNode *head;
<br>+ struct _EDListNode *terminator;
<br> struct _EDListNode *tail;
<br>- struct _EDListNode *tailpred;
<br> } EDList;
<br>
<br>-#define E_DLIST_INITIALISER(l) { (EDListNode *)&l.tail, 0, (EDListNode *)&l.head }
<br>+#define E_DLIST_INITIALISER(l) { (EDListNode *)&l.terminator, 0, (EDListNode *)&l.head }
<br>
<br> struct _iconv_cache_node {
<br> struct _iconv_cache_node *next;
<br>@@ -157,9 +157,9 @@ static const struct {
<br> and g_list's are f@@#$ed up to make this a hassle */
<br> static void e_dlist_init(EDList *v)
<br> {
<br>- v->head = (EDListNode *)&v->tail;
<br>- v->tail = NULL;
<br>- v->tailpred = (EDListNode *)&v->head;
<br>+ v->head = (EDListNode *)&v->terminator;
<br>+ v->terminator = NULL;
<br>+ v->tail = (EDListNode *)&v->head;
<br> }
<br>
<br> static EDListNode *e_dlist_addhead(EDList *l, EDListNode *n)
<br>@@ -173,10 +173,10 @@ static EDListNode *e_dlist_addhead(EDList *l, EDListNode *n)
<br>
<br> static EDListNode *e_dlist_addtail(EDList *l, EDListNode *n)
<br> {
<br>- n->next = (EDListNode *)&l->tail;
<br>- n->prev = l->tailpred;
<br>- l->tailpred->next = n;
<br>- l->tailpred = n;
<br>+ n->next = (EDListNode *)&l->terminator;
<br>+ n->prev = l->tail;
<br>+ l->tail->next = n;
<br>+ l->tail = n;
<br> return n;
<br> }
<br>
<br>@@ -462,7 +462,7 @@ iconv_t e_iconv_open(const gchar *oto, const gchar *ofrom)
<br> if (ic) {
<br> e_dlist_remove((EDListNode *)ic);
<br> } else {
<br>- struct _iconv_cache *last = (struct _iconv_cache *)iconv_cache_list.tailpred;
<br>+ struct _iconv_cache *last = (struct _iconv_cache *)iconv_cache_list.tail;
<br> struct _iconv_cache *prev;
<br>
<br> prev = last->prev;
<br>@@ -491,7 +491,7 @@ iconv_t e_iconv_open(const gchar *oto, const gchar *ofrom)
<br> e_dlist_addhead(&iconv_cache_list, (EDListNode *)ic);
<br>
<br> /* If we have a free iconv, use it */
<br>- in = (struct _iconv_cache_node *)ic->open.tailpred;
<br>+ in = (struct _iconv_cache_node *)ic->open.tail;
<br> if (in->prev && !in->busy) {
<br> cd(printf("using existing iconv converter '%s'\n", ic->conv));
<br> ip = in->ip;
<br>diff --git a/libedataserver/e-msgport.c b/libedataserver/e-msgport.c
<br>index 7a2c6ee..861d686 100644
<br>--- a/libedataserver/e-msgport.c
<br>+++ b/libedataserver/e-msgport.c
<br>@@ -198,9 +198,9 @@ out0:
<br>
<br> void e_dlist_init(EDList *v)
<br> {
<br>- v->head = (EDListNode *)&v->tail;
<br>- v->tail = NULL;
<br>- v->tailpred = (EDListNode *)&v->head;
<br>+ v->head = (EDListNode *)&v->terminator;
<br>+ v->terminator = NULL;
<br>+ v->tail = (EDListNode *)&v->head;
<br> }
<br>
<br> EDListNode *e_dlist_addhead(EDList *l, EDListNode *n)
<br>@@ -214,10 +214,10 @@ EDListNode *e_dlist_addhead(EDList *l, EDListNode *n)
<br>
<br> EDListNode *e_dlist_addtail(EDList *l, EDListNode *n)
<br> {
<br>- n->next = (EDListNode *)&l->tail;
<br>- n->prev = l->tailpred;
<br>- l->tailpred->next = n;
<br>- l->tailpred = n;
<br>+ n->next = (EDListNode *)&l->terminator;
<br>+ n->prev = l->tail;
<br>+ l->tail->next = n;
<br>+ l->tail = n;
<br> return n;
<br> }
<br>
<br>@@ -246,11 +246,11 @@ EDListNode *e_dlist_remtail(EDList *l)
<br> {
<br> EDListNode *n, *np;
<br>
<br>- n = l->tailpred;
<br>+ n = l->tail;
<br> np = n->prev;
<br> if (np) {
<br> np->next = n->next;
<br>- l->tailpred = np;
<br>+ l->tail = np;
<br> return n;
<br> }
<br> return NULL;
<br>@@ -258,7 +258,7 @@ EDListNode *e_dlist_remtail(EDList *l)
<br>
<br> gint e_dlist_empty(EDList *l)
<br> {
<br>- return (l->head == (EDListNode *)&l->tail);
<br>+ return (l->head == (EDListNode *)&l->terminator);
<br> }
<br>
<br> gint e_dlist_length(EDList *l)
<br>@@ -437,7 +437,7 @@ em_cache_add(EMCache *emc, EMCacheNode *n)
<br>
<br> c(printf("inserting node %s\n", n->key));
<br>
<br>- old = (EMCacheNode *)emc->lru_list.tailpred;
<br>+ old = (EMCacheNode *)emc->lru_list.tail;
<br> prev = old->prev;
<br> while (prev && old->stamp < now - emc->timeout) {
<br> if (old->ref_count == 0) {
<br>diff --git a/libedataserver/e-msgport.h b/libedataserver/e-msgport.h
<br>index 6e1573e..fbb9098 100644
<br>--- a/libedataserver/e-msgport.h
<br>+++ b/libedataserver/e-msgport.h
<br>@@ -13,11 +13,11 @@ typedef struct _EDListNode {
<br>
<br> typedef struct _EDList {
<br> struct _EDListNode *head;
<br>+ struct _EDListNode *terminator;
<br> struct _EDListNode *tail;
<br>- struct _EDListNode *tailpred;
<br> } EDList;
<br>
<br>-#define E_DLIST_INITIALISER(l) { (EDListNode *)&l.tail, NULL, (EDListNode *)&l.head }
<br>+#define E_DLIST_INITIALISER(l) { (EDListNode *)&l.terminator, NULL, (EDListNode *)&l.head }
<br>
<br> void e_dlist_init(EDList *v);
<br> EDListNode *e_dlist_addhead(EDList *l, EDListNode *n);
<br>--
<br>1.6.5
<br><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26356400&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (501 bytes) <a href="http://old.nabble.com/attachment/26356400/0/signature.asc" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-24920376Fix some sparse warnings in e-d-s2009-08-11T08:53:04Z2009-08-11T08:53:04ZKjartan MaraasThis is a patch that fixes a bunch of warnings from sparse in e-d-s.
<br>Please comment.
<br><br>Cheers
<br>Kjartan
<br><br>diff --git a/addressbook/backends/google/google-book.c b/addressbook/backends/google/google-book.c
<br>index 566de42..405343f 100644
<br>--- a/addressbook/backends/google/google-book.c
<br>+++ b/addressbook/backends/google/google-book.c
<br>@@ -1097,7 +1097,7 @@ google_book_get_contact (GoogleBook *book,
<br> priv = GET_PRIVATE (book);
<br>
<br> __debug__ (G_STRFUNC);
<br>- g_return_val_if_fail (IS_GOOGLE_BOOK (book), FALSE);
<br>+ g_return_val_if_fail (IS_GOOGLE_BOOK (book), NULL);
<br>
<br> google_book_cache_refresh_if_needed (book, error);
<br>
<br>@@ -1130,7 +1130,7 @@ google_book_get_all_contacts (GoogleBook *book,
<br> priv = GET_PRIVATE (book);
<br>
<br> __debug__ (G_STRFUNC);
<br>- g_return_val_if_fail (IS_GOOGLE_BOOK (book), FALSE);
<br>+ g_return_val_if_fail (IS_GOOGLE_BOOK (book), NULL);
<br>
<br> google_book_cache_refresh_if_needed (book, error);
<br>
<br>@@ -1171,7 +1171,7 @@ google_book_get_all_contacts_in_live_mode (GoogleBook *book)
<br> priv = GET_PRIVATE (book);
<br>
<br> __debug__ (G_STRFUNC);
<br>- g_return_val_if_fail (IS_GOOGLE_BOOK (book), FALSE);
<br>+ g_return_val_if_fail (IS_GOOGLE_BOOK (book), NULL);
<br>
<br> priv->live_mode = TRUE;
<br>
<br>diff --git a/addressbook/backends/google/util.c b/addressbook/backends/google/util.c
<br>index 98c610a..25cb111 100644
<br>--- a/addressbook/backends/google/util.c
<br>+++ b/addressbook/backends/google/util.c
<br>@@ -329,7 +329,7 @@ struct RelTypeMap {
<br> const gchar * types[3];
<br> };
<br>
<br>-const struct RelTypeMap rel_type_map_phone[] = {
<br>+static const struct RelTypeMap rel_type_map_phone[] = {
<br> {"fax", { "FAX", NULL, NULL}},
<br> {"home", { "HOME", "VOICE", NULL}},
<br> {"home_fax", { "HOME", "FAX", NULL}},
<br>@@ -340,7 +340,7 @@ const struct RelTypeMap rel_type_map_phone[] = {
<br> {"work_fax", { "WORK", "FAX", NULL}}
<br> };
<br>
<br>-const struct RelTypeMap rel_type_map_others[] = {
<br>+static const struct RelTypeMap rel_type_map_others[] = {
<br> {"home", { "HOME", NULL, NULL}},
<br> {"other", { "OTHER", NULL, NULL}},
<br> {"work", { "WORK", NULL, NULL}},
<br>diff --git a/addressbook/libebook/e-destination.c b/addressbook/libebook/e-destination.c
<br>index 83b21d7..ef12067 100644
<br>--- a/addressbook/libebook/e-destination.c
<br>+++ b/addressbook/libebook/e-destination.c
<br>@@ -1151,7 +1151,7 @@ e_destination_get_textrepv (EDestination **destv)
<br> *
<br> * Return value: Pointer to the root node of the XML tree.
<br> **/
<br>-xmlNodePtr
<br>+static xmlNodePtr
<br> e_destination_xml_encode (const EDestination *dest)
<br> {
<br> xmlNodePtr dest_node;
<br>@@ -1234,7 +1234,7 @@ e_destination_xml_encode (const EDestination *dest)
<br> *
<br> * Return value: %TRUE if the XML tree was well-formed, %FALSE otherwise.
<br> **/
<br>-gboolean
<br>+static gboolean
<br> e_destination_xml_decode (EDestination *dest, xmlNodePtr node)
<br> {
<br> gchar *name = NULL, *email = NULL, *source_uid = NULL, *card_uid = NULL;
<br>diff --git a/calendar/backends/caldav/e-cal-backend-caldav.c b/calendar/backends/caldav/e-cal-backend-caldav.c
<br>index 08fb02a..69c65f5 100644
<br>--- a/calendar/backends/caldav/e-cal-backend-caldav.c
<br>+++ b/calendar/backends/caldav/e-cal-backend-caldav.c
<br>@@ -2710,7 +2710,7 @@ convert_to_inline_attachment (ECalBackendCalDAV *cbdav, icalcomponent *icalcomp)
<br> * be embedded in a soap message
<br> */
<br> encoded = g_base64_encode ((guchar *) content, len);
<br>- attach = icalattach_new_from_data ((guchar *) encoded, 0, 0);
<br>+ attach = icalattach_new_from_data ((guchar *) encoded, NULL, NULL);
<br> g_free(content);
<br> g_free(encoded);
<br>
<br>@@ -4157,7 +4157,7 @@ caldav_get_free_busy (ECalBackendSync *backend,
<br> e_cal_component_set_dtend (comp, &dt);
<br>
<br> if (priv->username) {
<br>- ECalComponentOrganizer organizer = {0};
<br>+ ECalComponentOrganizer organizer = {NULL};
<br>
<br> organizer.value = priv->username;
<br> e_cal_component_set_organizer (comp, &organizer);
<br>diff --git a/calendar/backends/contacts/e-cal-backend-contacts.c b/calendar/backends/contacts/e-cal-backend-contacts.c
<br>index 8606936..c701d10 100644
<br>--- a/calendar/backends/contacts/e-cal-backend-contacts.c
<br>+++ b/calendar/backends/contacts/e-cal-backend-contacts.c
<br>@@ -916,7 +916,7 @@ init_sources_cb (ECalBackendContacts *cbc)
<br> ECalBackendContactsPrivate *priv;
<br> GSList *i;
<br>
<br>- g_return_val_if_fail (cbc != NULL, FALSE);
<br>+ g_return_val_if_fail (cbc != NULL, NULL);
<br>
<br> priv = cbc->priv;
<br>
<br>diff --git a/calendar/backends/google/e-cal-backend-google-utils.c b/calendar/backends/google/e-cal-backend-google-utils.c
<br>index 5ed864e..c5b3036 100644
<br>--- a/calendar/backends/google/e-cal-backend-google-utils.c
<br>+++ b/calendar/backends/google/e-cal-backend-google-utils.c
<br>@@ -776,7 +776,7 @@ utils_update_deletion (ECalBackendGoogle *cbgo, ECalBackendCache *cache, GSList
<br> * @dt a #ECalComponentDateTime value
<br> **/
<br> /* FIXME use proper functions to manipulate the dates */
<br>-gchar *
<br>+static gchar *
<br> get_date (ECalComponentDateTime dt)
<br> {
<br> gchar *temp;
<br>diff --git a/calendar/libecal/e-cal.c b/calendar/libecal/e-cal.c
<br>index a75f6ab..f4f33ce 100644
<br>--- a/calendar/libecal/e-cal.c
<br>+++ b/calendar/libecal/e-cal.c
<br>@@ -1071,7 +1071,7 @@ e_cal_init (ECal *ecal, ECalClass *klass)
<br> priv->cal_address = NULL;
<br> priv->alarm_email_address = NULL;
<br> priv->ldap_attribute = NULL;
<br>- priv->capabilities = FALSE;
<br>+ priv->capabilities = NULL;
<br> priv->factories = NULL;
<br> priv->timezones = g_hash_table_new (g_str_hash, g_str_equal);
<br> priv->default_zone = icaltimezone_get_utc_timezone ();
<br>diff --git a/calendar/tests/ecal/test-ecal.c b/calendar/tests/ecal/test-ecal.c
<br>index e52eccf..de537da 100644
<br>--- a/calendar/tests/ecal/test-ecal.c
<br>+++ b/calendar/tests/ecal/test-ecal.c
<br>@@ -699,7 +699,7 @@ create_client (ECal **client, const gchar *uri, ECalSourceType type, gboolean on
<br> results = all_tests (*client, uri);
<br> cl_printf (*client, "\n\n\n*************Tests run: %d****************\n\n", tests_run);
<br> cl_printf (*client, "*************Tests passed: %d*************\n\n\n", tests_passed);
<br>- if (results != 0)
<br>+ if (results != NULL)
<br> cl_printf (*client, "***Failures********%s\n", results);
<br>
<br> cl_printf (*client, "dump of the test calendar data");
<br>diff --git a/camel/camel-data-cache.c b/camel/camel-data-cache.c
<br>index 5c38240..09be951 100644
<br>--- a/camel/camel-data-cache.c
<br>+++ b/camel/camel-data-cache.c
<br>@@ -254,7 +254,7 @@ data_cache_path(CamelDataCache *cdc, gint create, const gchar *path, const gchar
<br> dd(printf("Checking expire cycle time on dir '%s'\n", dir));
<br>
<br> /* This has a race, but at worst we re-run an expire cycle which is safe */
<br>- now = time(0);
<br>+ now = time(NULL);
<br> if (cdc->priv->expire_last[hash] + CAMEL_DATA_CACHE_CYCLE_TIME < now) {
<br> cdc->priv->expire_last[hash] = now;
<br> data_cache_expire(cdc, dir, key, now);
<br>diff --git a/camel/camel-db.c b/camel/camel-db.c
<br>index 696b6e9..e771e8d 100644
<br>--- a/camel/camel-db.c
<br>+++ b/camel/camel-db.c
<br>@@ -366,13 +366,13 @@ cdb_sql_exec (sqlite3 *db, const gchar * stmt, CamelException *ex)
<br>
<br> d(g_print("Camel SQL Exec:\n%s\n", stmt));
<br>
<br>- ret = sqlite3_exec(db, stmt, 0, 0, &errmsg);
<br>+ ret = sqlite3_exec(db, stmt, NULL, NULL, &errmsg);
<br> while (ret == SQLITE_BUSY || ret == SQLITE_LOCKED || ret == -1) {
<br> if (errmsg) {
<br> sqlite3_free (errmsg);
<br> errmsg = NULL;
<br> }
<br>- ret = sqlite3_exec(db, stmt, 0, 0, &errmsg);
<br>+ ret = sqlite3_exec(db, stmt, NULL, NULL, &errmsg);
<br> }
<br>
<br> if (ret != SQLITE_OK) {
<br>diff --git a/camel/camel-folder-summary.h b/camel/camel-folder-summary.h
<br>index 6281d18..9316f11 100644
<br>--- a/camel/camel-folder-summary.h
<br>+++ b/camel/camel-folder-summary.h
<br>@@ -152,7 +152,7 @@ struct _CamelMessageInfo {
<br> guint32 refcount; /* ??? */
<br> const gchar *uid;
<br> /*FIXME: Make it work with the CAMEL_MESSADE_DB_DIRTY flag instead of another 4 bytes*/
<br>- gint dirty:1;
<br>+ guint dirty:1;
<br> };
<br>
<br> /* For classes wishing to do the provided i/o, or for anonymous users,
<br>@@ -164,7 +164,7 @@ struct _CamelMessageInfoBase {
<br> guint32 refcount; /* ??? */
<br> const gchar *uid;
<br> /*FIXME: Make it work with the CAMEL_MESSADE_DB_DIRTY flag instead of another 4 bytes*/
<br>- gint dirty:1;
<br>+ guint dirty:1;
<br>
<br> const gchar *subject;
<br> const gchar *from;
<br>diff --git a/camel/camel-mime-utils.c b/camel/camel-mime-utils.c
<br>index a304c5c..258c8ee 100644
<br>--- a/camel/camel-mime-utils.c
<br>+++ b/camel/camel-mime-utils.c
<br>@@ -1433,7 +1433,7 @@ rfc2047_encode_word(GString *outstring, const gchar *in, gsize len, const gchar
<br> inptr += convlen;
<br> } else {
<br> /* make sure we flush out any shift state */
<br>- camel_iconv (ic, NULL, 0, &out, &outlen);
<br>+ camel_iconv (ic, NULL, NULL, &out, &outlen);
<br> }
<br> inlen -= (inptr - p);
<br> }
<br>@@ -2063,7 +2063,7 @@ header_convert(const gchar *to, const gchar *from, const gchar *in, gsize inlen)
<br>
<br> ret = camel_iconv(ic, &in, &inlen, &outbuf, &outlen);
<br> if (ret != (gsize) -1) {
<br>- camel_iconv(ic, NULL, 0, &outbuf, &outlen);
<br>+ camel_iconv(ic, NULL, NULL, &outbuf, &outlen);
<br> *outbuf = '\0';
<br> result = g_strdup(outbase);
<br> }
<br>@@ -2166,7 +2166,7 @@ camel_header_set_param (struct _camel_header_param **l, const gchar *name, const
<br> return NULL;
<br>
<br> pn = g_malloc (sizeof (*pn));
<br>- pn->next = 0;
<br>+ pn->next = NULL;
<br> pn->name = g_strdup (name);
<br> pn->value = g_strdup (value);
<br> p->next = pn;
<br>@@ -2837,7 +2837,7 @@ camel_header_references_list_append_asis(struct _camel_header_references **list,
<br> w = w->next;
<br> n = g_malloc(sizeof(*n));
<br> n->id = ref;
<br>- n->next = 0;
<br>+ n->next = NULL;
<br> w->next = n;
<br> }
<br>
<br>@@ -3324,11 +3324,12 @@ header_encode_param (const guchar *in, gboolean *encoded, gboolean is_filename)
<br> return str;
<br> }
<br>
<br>-/* HACK: Set to non-zero when you want the 'filename' and 'name' headers encode in RFC 2047 way,
<br>+/* HACK: Set to non-zero when you want the 'filename' and 'name' headers encoded in RFC 2047 way,
<br> otherwise they will be encoded in the correct RFC 2231 way. It's because Outlook and GMail
<br> do not understand the correct standard and refuse attachments with localized name sent
<br>- from evolution. */
<br>-gint camel_header_param_encode_filenames_in_rfc_2047 = 0;
<br>+ from evolution. This seems to have been fixed in Exchange 2007 at least - not sure about
<br>+ standalone Outlook. */
<br>+static gint camel_header_param_encode_filenames_in_rfc_2047 = 0;
<br>
<br> void
<br> camel_header_param_list_format_append (GString *out, struct _camel_header_param *p)
<br>diff --git a/camel/camel-search-private.c b/camel/camel-search-private.c
<br>index 37719fb..3b8c83d 100644
<br>--- a/camel/camel-search-private.c
<br>+++ b/camel/camel-search-private.c
<br>@@ -141,7 +141,7 @@ camel_search_build_match_regex (regex_t *pattern, camel_search_flags_t type, gin
<br> if (err != 0) {
<br> /* regerror gets called twice to get the full error string
<br> length to do proper posix error reporting */
<br>- gint len = regerror (err, pattern, 0, 0);
<br>+ gint len = regerror (err, pattern, NULL, 0);
<br> gchar *buffer = g_malloc0 (len + 1);
<br>
<br> regerror (err, pattern, buffer, len);
<br>diff --git a/camel/camel-search-sql-sexp.c b/camel/camel-search-sql-sexp.c
<br>index 3490085..a6d432d 100644
<br>--- a/camel/camel-search-sql-sexp.c
<br>+++ b/camel/camel-search-sql-sexp.c
<br>@@ -559,7 +559,7 @@ sql_exp (struct _ESExp *f, gint argc, struct _ESExpResult **argv, gpointer data)
<br> static struct {
<br> const gchar *name;
<br> ESExpFunc *func;
<br>- gint immediate :1;
<br>+ guint immediate :1;
<br> } symbols[] = {
<br> { "and", (ESExpFunc *) func_and, 1 },
<br> { "or", (ESExpFunc *) func_or, 1},
<br>diff --git a/camel/camel-search-sql.c b/camel/camel-search-sql.c
<br>index 8d7b766..a191f0b 100644
<br>--- a/camel/camel-search-sql.c
<br>+++ b/camel/camel-search-sql.c
<br>@@ -103,13 +103,13 @@ typedef struct Node {
<br> gchar post_token; /* post token to apppend with substitute */
<br> gchar rval; /* rhs value for binary ops */
<br> gint level; /* depth in the hier */
<br>- gint prefix:1; /* unary operator to be searched ?*/
<br>- gint sys_node:1; /* is it a predefined term ? */
<br>- gint ignore_lhs:1; /* ignore lhs value ?*/
<br>- gint swap :1;
<br>- gint prenode :1;
<br>- gint operator:1;
<br>- gint execute:1;
<br>+ guint prefix:1; /* unary operator to be searched ?*/
<br>+ guint sys_node:1; /* is it a predefined term ? */
<br>+ guint ignore_lhs:1; /* ignore lhs value ?*/
<br>+ guint swap :1;
<br>+ guint prenode :1;
<br>+ guint operator:1;
<br>+ guint execute:1;
<br> gint ref;
<br> }Node;
<br>
<br>diff --git a/camel/providers/groupwise/camel-groupwise-provider.c b/camel/providers/groupwise/camel-groupwise-provider.c
<br>index 6b44948..69b898e 100644
<br>--- a/camel/providers/groupwise/camel-groupwise-provider.c
<br>+++ b/camel/providers/groupwise/camel-groupwise-provider.c
<br>@@ -47,7 +47,7 @@ static guint groupwise_url_hash (gconstpointer key);
<br> static gint check_equal (gchar *s1, gchar *s2);
<br> static gint groupwise_url_equal (gconstpointer a, gconstpointer b);
<br>
<br>-CamelProviderConfEntry groupwise_conf_entries[] = {
<br>+static CamelProviderConfEntry groupwise_conf_entries[] = {
<br> /* override the labels/defaults of the standard settings */
<br>
<br> { CAMEL_PROVIDER_CONF_SECTION_START, "mailcheck", NULL,
<br>diff --git a/camel/providers/imap/camel-imap-provider.c b/camel/providers/imap/camel-imap-provider.c
<br>index 42febef..d5c9ef8 100644
<br>--- a/camel/providers/imap/camel-imap-provider.c
<br>+++ b/camel/providers/imap/camel-imap-provider.c
<br>@@ -39,7 +39,7 @@ static guint imap_url_hash (gconstpointer key);
<br> static gint check_equal (gchar *s1, gchar *s2);
<br> static gint imap_url_equal (gconstpointer a, gconstpointer b);
<br>
<br>-CamelProviderConfEntry imap_conf_entries[] = {
<br>+static CamelProviderConfEntry imap_conf_entries[] = {
<br> { CAMEL_PROVIDER_CONF_SECTION_START, "mailcheck", NULL,
<br> N_("Checking for New Mail") },
<br> { CAMEL_PROVIDER_CONF_CHECKBOX, "check_all", NULL,
<br>diff --git a/libedataserverui/e-source-option-menu.c b/libedataserverui/e-source-option-menu.c
<br>index f9afc26..0a21f6f 100644
<br>--- a/libedataserverui/e-source-option-menu.c
<br>+++ b/libedataserverui/e-source-option-menu.c
<br>@@ -20,6 +20,8 @@
<br> * Author: Ettore Perazzoli <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=24920376&i=0" target="_top" rel="nofollow">ettore@...</a>>
<br> */
<br>
<br>+#undef GTK_DISABLE_DEPRECATED
<br>+
<br> #ifdef HAVE_CONFIG_H
<br> #include <config.h>
<br> #endif
<br>diff --git a/servers/google/libgdata-google/gdata-google-service.c b/servers/google/libgdata-google/gdata-google-service.c
<br>index b0e1890..3f085ab 100644
<br>--- a/servers/google/libgdata-google/gdata-google-service.c
<br>+++ b/servers/google/libgdata-google/gdata-google-service.c
<br>@@ -347,8 +347,8 @@ gdata_google_service_update_entry (GDataService *service, GDataEntry *entry, GEr
<br> {
<br> const gchar *entry_edit_url;
<br>
<br>- g_return_val_if_fail (service !=NULL, FALSE);
<br>- g_return_val_if_fail (GDATA_IS_GOOGLE_SERVICE (service), FALSE);
<br>+ g_return_val_if_fail (service !=NULL, NULL);
<br>+ g_return_val_if_fail (GDATA_IS_GOOGLE_SERVICE (service), NULL);
<br>
<br> entry_edit_url = gdata_entry_get_edit_link (entry);
<br>
<br>@@ -374,9 +374,9 @@ gdata_google_service_update_entry_with_link (GDataService *service, GDataEntry *
<br> gchar *entry_xml;
<br> GDataEntry *updated_entry = NULL;
<br>
<br>- g_return_val_if_fail (service !=NULL, FALSE);
<br>- g_return_val_if_fail (GDATA_IS_GOOGLE_SERVICE (service), FALSE);
<br>- g_return_val_if_fail (edit_link !=NULL, FALSE);
<br>+ g_return_val_if_fail (service !=NULL, NULL);
<br>+ g_return_val_if_fail (GDATA_IS_GOOGLE_SERVICE (service), NULL);
<br>+ g_return_val_if_fail (edit_link !=NULL, NULL);
<br>
<br> if (!service_is_authenticated( GDATA_GOOGLE_SERVICE(service) )) {
<br> if (FALSE == gdata_google_service_authenticate(GDATA_GOOGLE_SERVICE(service), error))
<br><br><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=24920376&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-24113131Re: patch to build eds against latest glib2009-06-19T07:57:49Z2009-06-19T07:57:49ZMatthew BarnesOn Fri, 2009-06-19 at 01:56 -0400, Larry Reaves wrote:
<br>> There was a glib commit (git.gnome.org/glib
<br>> 4c791f49e58688d1b8948d083c1780cab9d26e93) on the 18th that adds
<br>> reference counting to GMappedFile, and deprecates g_mapped_file_free,
<br>> replacing it with g_mapped_file_unref. The attached patch replaces each
<br>> call to g_mapped_file_free with g_mapped_file unref. Of course, eds
<br>> won't build with this patch without the very latest glib ;).
<br><br>Interim workarounds committed:
<br><br><a href="http://git.gnome.org/cgit/gtkhtml/commit/?id=2f5786fefbbf350359d60977ea4033da03203f3d" target="_top" rel="nofollow">http://git.gnome.org/cgit/gtkhtml/commit/?id=2f5786fefbbf350359d60977ea4033da03203f3d</a><br><br><a href="http://git.gnome.org/cgit/evolution-data-server/commit/?id=440cf63332708e09cc8a5fbcdcec32fa52d59ad2" target="_top" rel="nofollow">http://git.gnome.org/cgit/evolution-data-server/commit/?id=440cf63332708e09cc8a5fbcdcec32fa52d59ad2</a><br><br><a href="http://git.gnome.org/cgit/evolution-mapi/commit/?id=94809815f679e9df93822aa2b810b730d654a29e" target="_top" rel="nofollow">http://git.gnome.org/cgit/evolution-mapi/commit/?id=94809815f679e9df93822aa2b810b730d654a29e</a><br><br>Matthew Barnes
<br><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=24113131&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (204 bytes) <a href="http://old.nabble.com/attachment/24113131/0/signature.asc" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-24106792Re: patch to build eds against latest glib2009-06-19T00:32:36Z2009-06-19T00:32:36ZSuman Manjunath-2On Fri, Jun 19, 2009 at 11:26, Larry Reaves<<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=24106792&i=0" target="_top" rel="nofollow">larry@...</a>> wrote:
<br>> There was a glib commit (git.gnome.org/glib
<br>> 4c791f49e58688d1b8948d083c1780cab9d26e93) on the 18th that adds
<br>> reference counting to GMappedFile, and deprecates g_mapped_file_free,
<br>> replacing it with g_mapped_file_unref. The attached patch replaces each
<br>> call to g_mapped_file_free with g_mapped_file unref. Of course, eds
<br>> won't build with this patch without the very latest glib ;).
<br><br>which implies your patch gotta wait ;-)
<br><br>-Suman
<br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=24106792&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-24105931patch to build eds against latest glib2009-06-18T22:56:18Z2009-06-18T22:56:18ZLarry ReavesThere was a glib commit (git.gnome.org/glib
<br>4c791f49e58688d1b8948d083c1780cab9d26e93) on the 18th that adds
<br>reference counting to GMappedFile, and deprecates g_mapped_file_free,
<br>replacing it with g_mapped_file_unref. The attached patch replaces each
<br>call to g_mapped_file_free with g_mapped_file unref. Of course, eds
<br>won't build with this patch without the very latest glib ;).
<br><br>-Larry Reaves
<br><br /><tt>[0001-Update-g_mapped_file_free-calls-to-g_mapped_file_unr.patch]</tt><br /><hr align="left" width="300" /><tt>From d7e0f4a16757a2e75df447fa98a5a8ff5af51cfe Mon Sep 17 00:00:00 2001
<br>From: Larry Reaves <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=24105931&i=0" target="_top" rel="nofollow">larry@...</a>>
<br>Date: Fri, 19 Jun 2009 01:44:49 -0400
<br>Subject: [PATCH] Update g_mapped_file_free calls to g_mapped_file_unref to keep up with glib
<br><br>---
<br> calendar/backends/file/e-cal-backend-file.c | 2 +-
<br> calendar/backends/google/e-cal-backend-google.c | 2 +-
<br> .../backends/groupwise/e-cal-backend-groupwise.c | 2 +-
<br> libedataserver/e-xml-utils.c | 2 +-
<br> libedataserver/md5-utils.c | 2 +-
<br> 5 files changed, 5 insertions(+), 5 deletions(-)
<br><br>diff --git a/calendar/backends/file/e-cal-backend-file.c b/calendar/backends/file/e-cal-backend-file.c
<br>index 29284f7..4ac3572 100644
<br>--- a/calendar/backends/file/e-cal-backend-file.c
<br>+++ b/calendar/backends/file/e-cal-backend-file.c
<br>@@ -2510,7 +2510,7 @@ fetch_attachments (ECalBackendSync *backend, ECalComponent *comp)
<br> g_message ("DEBUG: attachment write failed.\n");
<br> }
<br>
<br>- g_mapped_file_free (mapped_file);
<br>+ g_mapped_file_unref (mapped_file);
<br> if (fd != -1)
<br> close (fd);
<br> dest_url = g_filename_to_uri (dest_file, NULL, NULL);
<br>diff --git a/calendar/backends/google/e-cal-backend-google.c b/calendar/backends/google/e-cal-backend-google.c
<br>index 845d6d3..1d8624a 100644
<br>--- a/calendar/backends/google/e-cal-backend-google.c
<br>+++ b/calendar/backends/google/e-cal-backend-google.c
<br>@@ -523,7 +523,7 @@ fetch_attachments (ECalBackendGoogle *cbgo, ECalComponent *comp)
<br> g_message ("DEBUG: attachment write failed.\n");
<br> }
<br>
<br>- g_mapped_file_free (mapped_file);
<br>+ g_mapped_file_unref (mapped_file);
<br> if (fd != -1)
<br> close (fd);
<br> dest_url = g_filename_to_uri (dest_file, NULL, NULL);
<br>diff --git a/calendar/backends/groupwise/e-cal-backend-groupwise.c b/calendar/backends/groupwise/e-cal-backend-groupwise.c
<br>index aec0661..a2c46da 100644
<br>--- a/calendar/backends/groupwise/e-cal-backend-groupwise.c
<br>+++ b/calendar/backends/groupwise/e-cal-backend-groupwise.c
<br>@@ -2449,7 +2449,7 @@ fetch_attachments (ECalBackendGroupwise *cbgw, ECalComponent *comp)
<br> g_message ("DEBUG: attachment write failed.\n");
<br> }
<br>
<br>- g_mapped_file_free (mapped_file);
<br>+ g_mapped_file_unref (mapped_file);
<br> if (fd != -1)
<br> close (fd);
<br> dest_url = g_filename_to_uri (dest_file, NULL, NULL);
<br>diff --git a/libedataserver/e-xml-utils.c b/libedataserver/e-xml-utils.c
<br>index 8901ce3..525627f 100644
<br>--- a/libedataserver/e-xml-utils.c
<br>+++ b/libedataserver/e-xml-utils.c
<br>@@ -50,7 +50,7 @@ e_xml_parse_file (const gchar *filename)
<br> if (mapped_file) {
<br> result = xmlParseMemory (g_mapped_file_get_contents (mapped_file),
<br> g_mapped_file_get_length (mapped_file));
<br>- g_mapped_file_free (mapped_file);
<br>+ g_mapped_file_unref (mapped_file);
<br> }
<br> return result;
<br> }
<br>diff --git a/libedataserver/md5-utils.c b/libedataserver/md5-utils.c
<br>index 4ef3780..fee9e7b 100644
<br>--- a/libedataserver/md5-utils.c
<br>+++ b/libedataserver/md5-utils.c
<br>@@ -362,5 +362,5 @@ md5_get_digest_from_file (const gchar *filename, guchar digest[16])
<br>
<br> md5_get_digest (contents, length, digest);
<br>
<br>- g_mapped_file_free (mapped_file);
<br>+ g_mapped_file_unref (mapped_file);
<br> }
<br>--
<br>1.6.0.4
<br><br></tt><hr align="left" width="300" /><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=24105931&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-23250962Re: Extend calendar plugin support2009-04-26T23:44:50Z2009-04-26T23:44:50ZChenthill-2It would be good if you can file a bug in www.bugzilla.gnome.org and
<br>attach all the patches there. The review comments will be posted as a
<br>comment through bugzilla and accepted patches can be committed. You can
<br>either file separate bugs for issues or file a single bug and post all
<br>the patch in the same.
<br><br>Thanks for sharing the patches!!
<br><br>- Chenthill.
<br>On Wed, 2009-04-22 at 16:10 +0200, Jan devyx Kratina wrote:
<div class='shrinkable-quote'><br>> Hello,
<br>> there are some patches that we created to support features in our
<br>> calendar system.
<br>> Patches eds-* are meant to evolution data server and evo-* are for
<br>> evolution package.
<br>> It was testedagainst 2.26 release, so i hope it will work with current
<br>> developement version of evolution.
<br>>
<br>> -- Jan Kratina
<br>> <a href="http://zonio.cz" target="_top" rel="nofollow">http://zonio.cz</a><br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=23250962&i=0" target="_top" rel="nofollow">jan.kratina@...</a>
<br>> _______________________________________________
<br>> Evolution-patches mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=23250962&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br>> <a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a></div><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=23250962&i=2" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-23250966unsubscribe2009-04-22T23:57:20Z2009-04-22T23:57:20ZJeroen van Lit<br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=23250966&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-23187153Re: Extend calendar plugin support2009-04-22T15:46:24Z2009-04-22T15:46:24ZMatthew BarnesOn Wed, 2009-04-22 at 16:10 +0200, Jan devyx Kratina wrote:
<br>> there are some patches that we created to support features in our
<br>> calendar system.
<br>> Patches eds-* are meant to evolution data server and evo-* are for
<br>> evolution package.
<br>> It was testedagainst 2.26 release, so i hope it will work with current
<br>> developement version of evolution.
<br><br>Can you please file separate bugs for each of these patches at
<br><a href="http://bugzilla.gnome.org/" target="_top" rel="nofollow">http://bugzilla.gnome.org/</a> and include a description of what they do?
<br><br>It's easier to track patches in a bug database than on a mailing list.
<br><br>Thanks,
<br>Matthew Barnes
<br><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=23187153&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (204 bytes) <a href="http://old.nabble.com/attachment/23187153/0/signature.asc" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-22268642Hash algorithm for signing e-mails with GnuPG v2.0.92009-02-28T16:32:50Z2009-02-28T16:32:50ZBugzilla from stmichalke@germanynet.deHi all:
<br><br>I've updated the patches for evolution-data-server and evolution
<br>v2.25.91.
<br><br>Tested with gpg.conf option:
<br>digest-algo SHA1
<br>digest-algo SHA512
<br>digest-algo RIPEMD160
<br># digest-algo
<br><br>The last setting results in gpg's default SHA1.
<br><br>Cheers
<br>Steffen
<br><br><br /><tt>[eds-camel-camel_gpg_context_c.225.patch]</tt><br /><hr align="left" width="300" /><tt>--- evolution-data-server-2.25.91/camel/camel-gpg-context.c 2009-02-13 08:39:09.000000000 +0100
<br>+++ evolution-data-server-2.25.91/camel/camel-gpg-context.c 2009-02-27 11:08:08.000000000 +0100
<br>@@ -126,7 +126,6 @@
<br> case CAMEL_CIPHER_HASH_MD5:
<br> return "pgp-md5";
<br> case CAMEL_CIPHER_HASH_SHA1:
<br>- case CAMEL_CIPHER_HASH_DEFAULT:
<br> return "pgp-sha1";
<br> case CAMEL_CIPHER_HASH_RIPEMD160:
<br> return "pgp-ripemd160";
<br></tt><hr align="left" width="300" /><br /><tt>[evo-composer_e-msg_composer_c.225.patch]</tt><br /><hr align="left" width="300" /><tt>--- evolution-2.25.91/composer/e-msg-composer.c 2009-02-13 08:39:37.000000000 +0100
<br>+++ evolution-2.25.91/composer/e-msg-composer.c 2009-02-27 11:14:51.000000000 +0100
<br>@@ -806,7 +806,7 @@
<br> CamelMimePart *npart = camel_mime_part_new ();
<br>
<br> cipher = mail_crypto_get_pgp_cipher_context (account);
<br>- camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_SHA1, part, npart, &ex);
<br>+ camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_DEFAULT, part, npart, &ex);
<br> camel_object_unref (cipher);
<br>
<br> if (camel_exception_is_set (&ex)) {
<br></tt><hr align="left" width="300" /><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=22268642&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (236 bytes) <a href="http://old.nabble.com/attachment/22268642/0/signature.asc" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-22265048Hash algorithm for signing e-mails with GnuPG v2.0.92009-02-28T10:20:51Z2009-02-28T10:20:51ZBugzilla from stmichalke@germanynet.deHi all:
<br><br>I've updated the patches for evolution-data-server and evolution
<br>v2.25.91.
<br><br>Tested with gpg.conf option:
<br>digest-algo SHA1
<br>digest-algo SHA512
<br>digest-algo RIPEMD160
<br># digest-algo
<br><br>The last setting results in gpg's default SHA1.
<br><br>Cheers
<br>Steffen
<br><br><br /><tt>[eds-camel-camel_gpg_context_c.225.patch]</tt><br /><hr align="left" width="300" /><tt>--- evolution-data-server-2.25.91/camel/camel-gpg-context.c 2009-02-13 08:39:09.000000000 +0100
<br>+++ evolution-data-server-2.25.91/camel/camel-gpg-context.c 2009-02-27 11:08:08.000000000 +0100
<br>@@ -126,7 +126,6 @@
<br> case CAMEL_CIPHER_HASH_MD5:
<br> return "pgp-md5";
<br> case CAMEL_CIPHER_HASH_SHA1:
<br>- case CAMEL_CIPHER_HASH_DEFAULT:
<br> return "pgp-sha1";
<br> case CAMEL_CIPHER_HASH_RIPEMD160:
<br> return "pgp-ripemd160";
<br></tt><hr align="left" width="300" /><br /><tt>[evo-composer_e-msg_composer_c.225.patch]</tt><br /><hr align="left" width="300" /><tt>--- evolution-2.25.91/composer/e-msg-composer.c 2009-02-13 08:39:37.000000000 +0100
<br>+++ evolution-2.25.91/composer/e-msg-composer.c 2009-02-27 11:14:51.000000000 +0100
<br>@@ -806,7 +806,7 @@
<br> CamelMimePart *npart = camel_mime_part_new ();
<br>
<br> cipher = mail_crypto_get_pgp_cipher_context (account);
<br>- camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_SHA1, part, npart, &ex);
<br>+ camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_DEFAULT, part, npart, &ex);
<br> camel_object_unref (cipher);
<br>
<br> if (camel_exception_is_set (&ex)) {
<br></tt><hr align="left" width="300" /><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=22265048&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (236 bytes) <a href="http://old.nabble.com/attachment/22265048/0/signature.asc" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-22264996Hash algorithm for signing e-mails with GnuPG v2.0.92009-02-28T10:16:29Z2009-02-28T10:16:29ZBugzilla from stmichalke@germanynet.deHi all:
<br><br>I've updated the patches for evolution-data-server and evolution
<br>v2.25.91.
<br><br>Tested with gpg.conf option:
<br>digest-algo SHA1
<br>digest-algo SHA512
<br>digest-algo RIPEMD160
<br># digest-algo
<br><br>The last setting results in gpg's default SHA1.
<br><br>Cheers
<br>Steffen
<br><br><br /><tt>[eds-camel-camel_gpg_context_c.225.patch]</tt><br /><hr align="left" width="300" /><tt>--- evolution-data-server-2.25.91/camel/camel-gpg-context.c 2009-02-13 08:39:09.000000000 +0100
<br>+++ evolution-data-server-2.25.91/camel/camel-gpg-context.c 2009-02-27 11:08:08.000000000 +0100
<br>@@ -126,7 +126,6 @@
<br> case CAMEL_CIPHER_HASH_MD5:
<br> return "pgp-md5";
<br> case CAMEL_CIPHER_HASH_SHA1:
<br>- case CAMEL_CIPHER_HASH_DEFAULT:
<br> return "pgp-sha1";
<br> case CAMEL_CIPHER_HASH_RIPEMD160:
<br> return "pgp-ripemd160";
<br></tt><hr align="left" width="300" /><br /><tt>[evo-composer_e-msg_composer_c.225.patch]</tt><br /><hr align="left" width="300" /><tt>--- evolution-2.25.91/composer/e-msg-composer.c 2009-02-13 08:39:37.000000000 +0100
<br>+++ evolution-2.25.91/composer/e-msg-composer.c 2009-02-27 11:14:51.000000000 +0100
<br>@@ -806,7 +806,7 @@
<br> CamelMimePart *npart = camel_mime_part_new ();
<br>
<br> cipher = mail_crypto_get_pgp_cipher_context (account);
<br>- camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_SHA1, part, npart, &ex);
<br>+ camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_DEFAULT, part, npart, &ex);
<br> camel_object_unref (cipher);
<br>
<br> if (camel_exception_is_set (&ex)) {
<br></tt><hr align="left" width="300" /><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=22264996&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (236 bytes) <a href="http://old.nabble.com/attachment/22264996/0/signature.asc" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-22264930Hash algo for signing e-mails with GnuPG v2.0.92009-02-28T10:09:49Z2009-02-28T10:09:49ZBugzilla from stmichalke@germanynet.deHi all:
<br><br>I've updated the patches for evolution-data-server and evolution
<br>v2.25.91.
<br><br>Tested with gpg.conf option
<br>digest-algo SHA1
<br>digest-algo SHA512
<br>digest-algo RIPEMD160
<br># digest-algo
<br><br>The last setting results in gpg's default SHA1.
<br><br>Cheers
<br>Steffen
<br><br><br /><tt>[eds-camel-camel_gpg_context_c.225.patch]</tt><br /><hr align="left" width="300" /><tt>--- evolution-data-server-2.25.91/camel/camel-gpg-context.c 2009-02-13 08:39:09.000000000 +0100
<br>+++ evolution-data-server-2.25.91/camel/camel-gpg-context.c 2009-02-27 11:08:08.000000000 +0100
<br>@@ -126,7 +126,6 @@
<br> case CAMEL_CIPHER_HASH_MD5:
<br> return "pgp-md5";
<br> case CAMEL_CIPHER_HASH_SHA1:
<br>- case CAMEL_CIPHER_HASH_DEFAULT:
<br> return "pgp-sha1";
<br> case CAMEL_CIPHER_HASH_RIPEMD160:
<br> return "pgp-ripemd160";
<br></tt><hr align="left" width="300" /><br /><tt>[evo-composer_e-msg_composer_c.225.patch]</tt><br /><hr align="left" width="300" /><tt>--- evolution-2.25.91/composer/e-msg-composer.c 2009-02-13 08:39:37.000000000 +0100
<br>+++ evolution-2.25.91/composer/e-msg-composer.c 2009-02-27 11:14:51.000000000 +0100
<br>@@ -806,7 +806,7 @@
<br> CamelMimePart *npart = camel_mime_part_new ();
<br>
<br> cipher = mail_crypto_get_pgp_cipher_context (account);
<br>- camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_SHA1, part, npart, &ex);
<br>+ camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_DEFAULT, part, npart, &ex);
<br> camel_object_unref (cipher);
<br>
<br> if (camel_exception_is_set (&ex)) {
<br></tt><hr align="left" width="300" /><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=22264930&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (236 bytes) <a href="http://old.nabble.com/attachment/22264930/0/signature.asc" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-22264845Hash algorithm for signing e-mails with GnuPG v2.0.92009-02-28T10:01:17Z2009-02-28T10:01:17ZBugzilla from stmichalke@germanynet.deHi all:
<br><br>I've updated the patches for evolution-data-server and evolution
<br>v2.25.91.
<br><br>Tested with gpg-option (gpg.conf)
<br>disgest-algo SHA1
<br>disgest-algo SHA512
<br>disgest-algo RIPEMD160
<br># digest-algo
<br><br>The last option results in gpg's default SHA1.
<br><br>Cheers
<br>Steffen
<br><br><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=22264845&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (236 bytes) <a href="http://old.nabble.com/attachment/22264845/0/signature.asc" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-21653131Obama -- The Judas Goat2009-01-25T08:03:41Z2009-01-25T08:03:41ZBenjamin OtteObama -- The Judas Goat
<br>1/25/2009
<br>By David Duke
<br><br>Judas Goat\ A goat that leads other goats or sheep to slaughter. Also, one who entices into danger and betrays others. The name is an allusion to Judas Iscariot, who betrayed Jesus for 30 pieces of slaughter. (From Merriam Websters Dictionary)
<br><br>Barack Hussein Obama is a Judas Goat.
<br><br>Extremist Jews guided Barack Hussein Obamas career from day one, even all the way back to Harvard Law School. Radical Zionist hitman, David Axelrod previously orchestrated the Jewish-financed and organized defeat of perceived anti-Zionist Sen. Charles Percy. He is the man who ran Obamas campaign for President and who is his chief handler. Obamas campaign was overwhelmingly financed by the most powerful Zionist bankers in the world. His campaigns largest contribution source was the Zionist international banking firm of Goldman Sachs. (FEC campaign records). In both Obamas Senate and Presidential campaign he prostrated himself before AIPAC (American Israel Public Affairs Committee) promising even more money and blood for Israels terrorism than even the supine John McCain, and even more money and blood than the previous Shabbez Goy in the White House, George Bush. Before the Israeli terrorism and mass murder in Gaza, he went to Israel and said that he supported Israels p
<br> lanned murderous terrorism against the men, women and children of Gaza.
<br><br>His first act as President-elect was to appoint a rabid Zionist, Israeli dual citizen who served in the Israeli Army as his Chief of Staff, Rahm Emmanuel. As thousands of women and children in Gaza were killed or maimed, Obama remained silent. Within a few days as President Obama supported indiscriminate American missile strikes in villages of our ally Pakistan, a clear continuation of Bushs policies. He completely supports the theft of trillions of American taxpayer dollars to the Zionist international bankers. Eighty percent of American Jews voted for Obama, and all the main leaders of the Jewish Supremacist state of Israel have proclaimed Obama as the perfect man for U.S. President.
<br><br>What better for the Zionists to have their own servant perceived as a clean break from the Jewish extremist-controlled Bush administration? What better than for the Zionists than to have their Shabbez Goy be treated by the worlds press and even by much of the anti-Zionist community as a man of real change? What better for the Zionists than for the world to think that Obama will be a change from the Zionist-controlled policies when he willing to do anything that Israel demands? What better for the Zionist murderers to have their craven puppet be looked at by the whole world as a man of honor and integrity and fairness.
<br><br>In the slaughterhouse, the Judas Goat is often painted with bright colors, adorned with strong, sweet scents to lure the sheep to their pens and to their death. Obama, the Judas Goat of our time, is looked upon by millions of Zionist-propagandized sheep as the man who will lead them to salvation.
<br><br>Instead, he leads America, Palestine and the world to the bloody altar of Jewish Supremacism.
<br><br>Any supposed anti-Zionist who praises Barack Obama is actually aiding this Judas Goat to lead us all to slaughter. Every person who truly opposes Jewish extremism must speak out and expose the Judas Goat named Barack Obama!
<br><br> Dr. David Duke
<br><br>Former Member of the House of Representatives
<br><br>State of Louisiana
<br><br>United States of America
<br><br>It is up to you the people of the United States who can still think freely, and up to all of the people of the world who are able to see through the deceptions of the Zionist-influenced Global media -- to get this simple, powerful message to everyone on earth. Email this message to your friends, post it on forums and websites and put links to it on every website, facebook or other media in the world. Go and seek out media and Internet sites not controlled by Zionist power. Make youtube videos of this message, (use the short audio and find good illustrative pictures) and post it untill your fingers are worn and tired, print it and mail it to newspapers or any media outlet that has still not fallen under the propaganda of the Zionists. Let the world know the truth. Person by person, in the USA, Canada, UK, France, Germany, Italy, japan, Russia, China, Africa, Palestine, South America and across the whole world this Judas Goat must be exposed for what he is, so that when begin
<br> s to do his evil for Israel, the whole world will know exactly what is going on and resist!
<br><br>Source : <a href="http://www.davidduke.com/general/obama-the-judas-goat_7317.html" target="_top" rel="nofollow">http://www.davidduke.com/general/obama-the-judas-goat_7317.html</a><br><br><br>------------------------
<br><br>Why is the President of Israel, the terrorist who just oversaw the Zionist mass murder and maiming of thousands of Palestinians so happy
<br>that Obama is President of the USA?
<br>by David Duke
<br><br><br>Read the excerpt from the Israeli News about how President Perez and Israel think that Obamas becoming U.S. President is great day
<br>for Israel.
<br><br>"Israels President Shimon Peres ecstatic over the election of Obama"
<br>Ronen Medzini Israel News Jan. 21
<br><br>Today is a great day not only for the United States of America, but for the entire world, President Shimon Peres wrote in a letter
<br>addressed to Barack Obama on the day of his inauguration as president of the United States.
<br><br>Obama was elected by the United States, but as a matter of fact, he was chosen by the whole of humankind,
<br><br>Why is Peres so ecstatic?
<br><br>Why shouldnt he be, he knows that Obama is completely in the grip of the extremist Jewish Zionists in America, and he knows that the
<br>greater Obamas popularity and idol worship, the more Obama can do for the International Zionist Cause.
<br><br>Any thinking and caring human being who realizes that the Zionist-controlled American foreign policy has been a disaster for the robbed
<br>and murdered people of Palestine, Lebanon, Iraq and a catastrophe for the 50,000 American wounded in Iraq and Afghanistan, as well
<br>as an economic catastrophe for the hardworking Americans who pay trillions to finance these wars for Israel -- must wake up the fact that
<br>supporting Obama and increasing his popularity will only aid Zionist terrorism, war, and their murder and oppression of the Palestinians. It
<br>will also hasten the economic suffering of billions of people around the world as his popularity enables him to more easily aid the Zionist
<br>International Bankers steal the wealth of the United States, Europe and the world. Obama is totally in the bloodstained and green ink-
<br>stained hands of the Zionists. The hard truth is that the more good will and support Obama has also gives more power to support the
<br>Zionist agenda!
<br><br>Mark my words. The Obama Presidency will be disaster for America and for the world.
<br><br>Obama was put into office by the Zionists. His top two cohorts for years have been the radical Jews David Axelrod and Rahm
<br>Emmanuel. Both have long records of radical Zionism and have been attack dogs against anyone perceived as having the slightest
<br>opposition to Israel. One such victim was Sen. Charles Percy, who both men worked to defeat and destroy because he dared to only be
<br>99 percent rather than 100 percent pro-Israel. Rahm Emmanuel, a dual citizen of Israel who went to fight for Israel, he has a long
<br>pedigree of Jewish extremism. His father served in the Irgun Terrorist Gang and he himself is named after an Irgun terrorist.
<br><br>Zionist leaders in Chicago actually call Obama the first Jewish President and boast that Jews were key players in Obamas every step
<br>up the ladder to President.
<br><br>from the very earliest days, extremist Jews were the largest contributors to his campaign. In the beginning of his Presidential bid, three
<br>Hollywood Jews that constantly make movies about Jewish suffering, but never about the Zionist terrorism and theft against the
<br>Palestinian people, Steven Spielberg, David Geffen, and Jeffrey Katzenberg raised 1.2 million for Obama in a single Hollywood party.
<br><br>By the time Obamas campaign was in full swing, he had huge support from the criminal Zionist International Banking firms such as
<br>Goldman Sachs and Lehman brothers. Goldman Sachs was Obamas biggest single contributor, and his vast war chest came not from
<br>American manufacturing firms like GM or even American oil companies, (not one was in his top twenty) it was overwhelmingly dominated
<br>by Zionist international bankers, the same ones whose thievery and fraud are giving the world this economic depression.
<br><br>For those looking for meaningful social and political change, do you really think it will come from this man who has already been bought
<br>heart, head and soul by the most powerful czars of the international financial establishment and the biggest globalists in the world?
<br><br>I know that many are desperate for change, so desperate that you want to believe anything. But in the face of these facts cant you see
<br>that Obama will be even more dangerous to freedom and justice than even George Bush and his band of Neocons were. What better
<br>way to wipe out George Bushs hated legacy and make the world believe that America has really changed than with the election of
<br>Obama. But, all the real Zionist power, Zionist media power, and Zionist financial power in America is still in place, even stronger than
<br>ever.
<br><br>Many Americans and others around the world who want to do good are now telling us how wonderful Obama will be as president. What
<br>a great change it will be from the old policies. This is because of the Zionist-Controlled media hype, promoting Obama. The fact is that
<br>these poor sods are ignorantly helping the radical Zionist agenda in Israel and around the world.
<br><br>Every day that you dont help expose Obama for the Zionist servant that he actually is, his popularity will be a greater danger to peace
<br>and freedom.
<br><br>If the Zionist terrorist Shimon Perez is happy about the coronation of Obama, then why in the hell should you be?
<br><br>David Duke
<br><br>Source : <a href="http://www.davidduke.com/general/7303_7303.html" target="_top" rel="nofollow">http://www.davidduke.com/general/7303_7303.html</a><br>-------------------------------------
<br><br>You or someone using your email adress is currently subscribed to the Lawrence Auster
<br>Newletter. If you wish to unsubscribe from our mailing list, please let us know by calling to 1 212 865 1284
<br><br>Thanks,
<br><br>Lawrence Auster,
<br>238 W 101 St Apt. 3B
<br>New York, NY 10025
<br>Contact: <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21653131&i=0" target="_top" rel="nofollow">lawrence.auster@...</a>
<br>-------------------------------------
<br><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21653131&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-21649379Re: [Fwd: Wake Up World! Meet the New Boss, Same as the Old Boss]2009-01-25T00:18:30Z2009-01-25T00:18:30ZSuman Manjunath-2On Sun, Jan 25, 2009 at 10:57, Peter Lucas <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21649379&i=0" target="_top" rel="nofollow">pklucas@...</a>> wrote:
<br>> The sending of politically motivated email such as the attached using the
<br>> open source community's mailing lists is an abuse of these lists.
<br>>
<br>> I suggest the originator of the attached message be blocked from future use
<br>> the evolution-patches or indeed the gnome mailing lists.
<br><br>Christophe clarified on d-d-l ;-)
<br><a href="http://mail.gnome.org/archives/desktop-devel-list/2009-January/msg00304.html" target="_top" rel="nofollow">http://mail.gnome.org/archives/desktop-devel-list/2009-January/msg00304.html</a><br><br>-Suman
<br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21649379&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-21648748[Fwd: Wake Up World! Meet the New Boss, Same as the Old Boss]2009-01-24T21:27:51Z2009-01-24T21:27:51ZPeter Lucas-2The sending of politically motivated email such as the attached using
<br>the open source community's mailing lists is an abuse of these lists.
<br><br>I suggest the originator of the attached message be blocked from future
<br>use the evolution-patches or indeed the gnome mailing lists.
<br><br>Regards
<br>Peter Lucas
<br><br />If you want to know who the real establishment is in America and around the world, the real power behind the so-called ''military-industrial complex'', the real maleficent power that has led this world to inexorable conflict, war, hatreds, destruction of real human values, morality, conscience it is the global media establishment.
<br>
<br>This same media witnessed the Zionist slaughter of 1,300 people in Gaza, and the maiming of 6,000 more, half of them women and children. More than 20,000 homes and buildings were destroyed or damaged and thousands became homeless. This horrendous mass slaughter of Palestinians is compared to the loss of 3 Israeli civilians. Yet, the media never dare to call this slaughter exactly what it is: terrorism on a horrendous scale! This same American and global media has not informed the American people or the people of the world of the damning truth about Barack Obama.
<br>
<br>In truth, Obama is a complete creation of extremist Jewish Zionists and he has already begun to serve Israel by his top appointments.
<br>
<br>The Jewish-dominated media in America is promoting the Obama inauguration as akin to the Second Coming of Jesus Christ. (If you question Jewish control of the media read Who Runs the Media? and you will find documentation proving the Jewish control being far greater than you might suspect) The rest of the worlds powerful media (Which also has a powerful Jewish presence in the UK, France, Spain, Sweden, Russia, and the rest of Europe) takes its cues from the NY/Hollywood media axis, and presents Obama as kind of a superhuman agent of real change.
<br>
<br>In fact, it is a Huge Lie!
<br>
<br>Obama is completely controlled by the same forces that have controlled George Bush, so much so that The Chicago Tribune quotes leading Jews bragging that Obama is so in the hands of the Zionists that he is ''the first Jewish President.'' Obama received about 80 percent of the Jewish vote in the United States!
<br>
<br>The Three critical things that made Obama President:
<br>
<br>1)Jewish political influence
<br>
<br>Obamas chief handler is David Axelrod, a radical Jewish Zionist whose previous claim to fame was the fact that he was the Zionist political hit man against Illinois Senator Charles Percy, who was not deemed to be pro-Israel enough. (He was only 99.9 percent Israels lackey, not the required 100 percent) Obama went to Israel and made sure he pronounced himself even more radically pro-Zionist than Bush or McCain.
<br>
<br>2) Massive amounts of Jewish money
<br>
<br>Obamas campaign was kicked in high gear by Jewish Hollywood and financial moguls. In just one of the early fundraising parties in Hollywood by Spielberg, Geffen and Katzenburg it raised over a million dollars for Obama. Obama raised more money than any political candidate in American history and his biggest contributors were overwhelmingly Jewish activists, Jewish international finance and banking firms and Jewish globalists. His largest single contributor was the international Jewish Banking firm of Goldman Sachs. He received more money from the same international bankers that ripped off trillions of dollars in the recent economic scandals than even John McCain. Is a man totally under the power of the most powerful financial organizations in the entire world, really an agent of ''change?''
<br>
<br>3) Overwhelming positive support in the Jewish-dominated media
<br>
<br>By a large margin, Jewish-owned media officially endorsed Obama, and that is not counting tens of thousands of positive articles by Jewish; owned publications and pundits.
<br>
<br>Obamas first act as President-elect was to appoint a Jewish extremist, dual citizen, Rahm Emmanuel, as his chief of staff. As the people of Gaza were slaughtered, Obama would not make a single statement to stop this murder and maiming of thousands of innocents!
<br>
<br>Israel, very carefully timed its terrorist attack on Gaza to be in the remaining days of the Bush Administration. The day before Obamas inauguration Israel announced that it would be completely out of Gaza by the time Obama took his oath of office.
<br>
<br>Why?
<br>
<br>Before Obama took office, Israel could make this terrorist slaughter against Palestinians and Obama would still be perceived as having clean hands. Because Obama is completely under their control, they want him to have an image of fairness, honor and peacefulness, and as representing a new direction of American policy, as he begins to deal with the Mideast turmoil.
<br>
<br>Since he is Israels boy in the White House, what better scenario could they have than a President perceived as practically the Second Coming, of high moral conviction, and dedicated to fairness, but who is actually bound hand-and-foot to the Zionist agenda, just as the last presidents have been. Talk about a perfect shill. And the game is working, for even many Palestinians are filled with hope that the new President will work to end their long suffering.
<br>
<br>With an almost godlike positive image around the world, a Barack Obama who is in reality controlled by Israel, is a much bigger danger than was even George Bush. We know what Bush is, but too many Americans and other peoples around the world are falling for the lies about the new ''savior'' of the world: Barack Obama. He already says we are to put thousands of new troops in Afghanistan and has rattled the sabers against Iran. Obama with highest positive image (created by media) in the world is in a more dangerous position to lead us into catastrophic wars than George Bush ever was.
<br>
<br>Jewish screenwriters in Hollywood couldnt have written a better script for the Zionist agenda than what is being played out on inauguration day, USA.
<br>
<br>Of course, why should they write it, they did it.
<br>
<br>God save America, God save the Palestinians, God save peace and justice in the world!
<br>
<br>david duke
<br>
<br> Source:
<br>
<br> <a href="http://www.davidduke.com/general/wake-up-world-meet-the-new-boss-same-as-the-old-boss_7225.html" target="_top" rel="nofollow">http://www.davidduke.com/general/wake-up-world-meet-the-new-boss-same-as-the-old-boss_7225.html</a><br>
<br>---------------------------------------------------------------
<br>
<br>
<br>You or someone using your email adress is currently subscribed to the Lawrence Auster
<br>Newletter. If you wish to unsubscribe from our mailing list, please let us know by calling to 1 212 865 1284
<br>
<br>Thanks,
<br>
<br>Lawrence Auster,
<br>238 W 101 St Apt. 3B
<br>New York, NY 10025
<br>Contact: <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21648748&i=0" target="_top" rel="nofollow">lawrence.auster@...</a>
<br><br><br>---------------------------------------------------------------
<br><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21648748&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21648748&i=2" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-21612021Wake Up World! Meet the New Boss, Same as the Old Boss2009-01-22T12:01:14Z2009-01-22T12:01:14ZBugzilla from teuf@gnome.orgIf you want to know who the real establishment is in America and around the world, the real power behind the so-called ''military-industrial complex'', the real maleficent power that has led this world to inexorable conflict, war, hatreds, destruction of real human values, morality, conscience it is the global media establishment.
<br>
<br>This same media witnessed the Zionist slaughter of 1,300 people in Gaza, and the maiming of 6,000 more, half of them women and children. More than 20,000 homes and buildings were destroyed or damaged and thousands became homeless. This horrendous mass slaughter of Palestinians is compared to the loss of 3 Israeli civilians. Yet, the media never dare to call this slaughter exactly what it is: terrorism on a horrendous scale! This same American and global media has not informed the American people or the people of the world of the damning truth about Barack Obama.
<br>
<br>In truth, Obama is a complete creation of extremist Jewish Zionists and he has already begun to serve Israel by his top appointments.
<br>
<br>The Jewish-dominated media in America is promoting the Obama inauguration as akin to the Second Coming of Jesus Christ. (If you question Jewish control of the media read Who Runs the Media? and you will find documentation proving the Jewish control being far greater than you might suspect) The rest of the worlds powerful media (Which also has a powerful Jewish presence in the UK, France, Spain, Sweden, Russia, and the rest of Europe) takes its cues from the NY/Hollywood media axis, and presents Obama as kind of a superhuman agent of real change.
<br>
<br>In fact, it is a Huge Lie!
<br>
<br>Obama is completely controlled by the same forces that have controlled George Bush, so much so that The Chicago Tribune quotes leading Jews bragging that Obama is so in the hands of the Zionists that he is ''the first Jewish President.'' Obama received about 80 percent of the Jewish vote in the United States!
<br>
<br>The Three critical things that made Obama President:
<br>
<br>1)Jewish political influence
<br>
<br>Obamas chief handler is David Axelrod, a radical Jewish Zionist whose previous claim to fame was the fact that he was the Zionist political hit man against Illinois Senator Charles Percy, who was not deemed to be pro-Israel enough. (He was only 99.9 percent Israels lackey, not the required 100 percent) Obama went to Israel and made sure he pronounced himself even more radically pro-Zionist than Bush or McCain.
<br>
<br>2) Massive amounts of Jewish money
<br>
<br>Obamas campaign was kicked in high gear by Jewish Hollywood and financial moguls. In just one of the early fundraising parties in Hollywood by Spielberg, Geffen and Katzenburg it raised over a million dollars for Obama. Obama raised more money than any political candidate in American history and his biggest contributors were overwhelmingly Jewish activists, Jewish international finance and banking firms and Jewish globalists. His largest single contributor was the international Jewish Banking firm of Goldman Sachs. He received more money from the same international bankers that ripped off trillions of dollars in the recent economic scandals than even John McCain. Is a man totally under the power of the most powerful financial organizations in the entire world, really an agent of ''change?''
<br>
<br>3) Overwhelming positive support in the Jewish-dominated media
<br>
<br>By a large margin, Jewish-owned media officially endorsed Obama, and that is not counting tens of thousands of positive articles by Jewish; owned publications and pundits.
<br>
<br>Obamas first act as President-elect was to appoint a Jewish extremist, dual citizen, Rahm Emmanuel, as his chief of staff. As the people of Gaza were slaughtered, Obama would not make a single statement to stop this murder and maiming of thousands of innocents!
<br>
<br>Israel, very carefully timed its terrorist attack on Gaza to be in the remaining days of the Bush Administration. The day before Obamas inauguration Israel announced that it would be completely out of Gaza by the time Obama took his oath of office.
<br>
<br>Why?
<br>
<br>Before Obama took office, Israel could make this terrorist slaughter against Palestinians and Obama would still be perceived as having clean hands. Because Obama is completely under their control, they want him to have an image of fairness, honor and peacefulness, and as representing a new direction of American policy, as he begins to deal with the Mideast turmoil.
<br>
<br>Since he is Israels boy in the White House, what better scenario could they have than a President perceived as practically the Second Coming, of high moral conviction, and dedicated to fairness, but who is actually bound hand-and-foot to the Zionist agenda, just as the last presidents have been. Talk about a perfect shill. And the game is working, for even many Palestinians are filled with hope that the new President will work to end their long suffering.
<br>
<br>With an almost godlike positive image around the world, a Barack Obama who is in reality controlled by Israel, is a much bigger danger than was even George Bush. We know what Bush is, but too many Americans and other peoples around the world are falling for the lies about the new ''savior'' of the world: Barack Obama. He already says we are to put thousands of new troops in Afghanistan and has rattled the sabers against Iran. Obama with highest positive image (created by media) in the world is in a more dangerous position to lead us into catastrophic wars than George Bush ever was.
<br>
<br>Jewish screenwriters in Hollywood couldnt have written a better script for the Zionist agenda than what is being played out on inauguration day, USA.
<br>
<br>Of course, why should they write it, they did it.
<br>
<br>God save America, God save the Palestinians, God save peace and justice in the world!
<br>
<br>david duke
<br>
<br> Source:
<br>
<br> <a href="http://www.davidduke.com/general/wake-up-world-meet-the-new-boss-same-as-the-old-boss_7225.html" target="_top" rel="nofollow">http://www.davidduke.com/general/wake-up-world-meet-the-new-boss-same-as-the-old-boss_7225.html</a><br>
<br>---------------------------------------------------------------
<br>
<br>
<br>You or someone using your email adress is currently subscribed to the Lawrence Auster
<br>Newletter. If you wish to unsubscribe from our mailing list, please let us know by calling to 1 212 865 1284
<br>
<br>Thanks,
<br>
<br>Lawrence Auster,
<br>238 W 101 St Apt. 3B
<br>New York, NY 10025
<br>Contact: <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21612021&i=0" target="_top" rel="nofollow">lawrence.auster@...</a>
<br><br><br>---------------------------------------------------------------
<br><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21612021&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-21370674Re: Extend external editor plugin2009-01-09T03:35:35Z2009-01-09T03:35:35ZSankar POn Tue, 2009-01-06 at 12:46 +0100, Holger Macht wrote:
<br>> Extend/rewrite the external editor plugin. Now you are able to launch
<br>> the external editor directly from the mail composer, either from the
<br>> menu or by a shortcut.
<br>>
<br>> Furthermore, add a gconf configuration option to automatically launch
<br>> the editor when the user starts typing in the composer (kmail way of
<br>> doing it).
<br>>
<br><br>Patch added to <a href="http://bugzilla.gnome.org/show_bug.cgi?id=567145" target="_top" rel="nofollow">http://bugzilla.gnome.org/show_bug.cgi?id=567145</a>
<br><br>More comments and review will continue there.
<br><br>Holger, Thanks a lot for the patch :-)
<br><br>> Signed-off-by: Holger Macht <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21370674&i=0" target="_top" rel="nofollow">hmacht@...</a>>
<br>> _______________________________________________
<br>> Evolution-patches mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21370674&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br>> <a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><br>--
<br>Sankar
<br><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21370674&i=2" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-21308947Extend external editor plugin2009-01-06T03:46:31Z2009-01-06T03:46:31ZHolger MachtExtend/rewrite the external editor plugin. Now you are able to launch
<br>the external editor directly from the mail composer, either from the
<br>menu or by a shortcut.
<br><br>Furthermore, add a gconf configuration option to automatically launch
<br>the editor when the user starts typing in the composer (kmail way of
<br>doing it).
<br><br>Signed-off-by: Holger Macht <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=0" target="_top" rel="nofollow">hmacht@...</a>>
<br><br /><tt>[evolution-extend-external-editor-plugin.patch]</tt><br /><hr align="left" width="300" /><tt>Index: plugins/external-editor/apps-evolution-external-editor.schemas.in
<br>===================================================================
<br>--- plugins/external-editor/apps-evolution-external-editor.schemas.in (Revision 36999)
<br>+++ plugins/external-editor/apps-evolution-external-editor.schemas.in (Arbeitskopie)
<br>@@ -10,6 +10,16 @@
<br> <short>Default External Editor</short>
<br> <long>The default command that must be used as the editor.</long>
<br> </locale>
<br>+
<br>+ <key>/schemas/apps/evolution/eplugin/external-editor/launch-on-key-press</key>
<br>+ <applyto>/apps/evolution/eplugin/external-editor/launch-on-key-press</applyto>
<br>+ <owner>evolution-mail</owner>
<br>+ <type>bool</type>
<br>+ <default>false</default>
<br>+ <locale name="C">
<br>+ <short>Automatically launch when a new mail is edited</short>
<br>+ <long>Automatically launch editor when key is pressed in the mail composer</long>
<br>+ </locale>
<br> </schema>
<br> </schemalist>
<br> </gconfschemafile>
<br>Index: plugins/external-editor/ChangeLog
<br>===================================================================
<br>--- plugins/external-editor/ChangeLog (Revision 36999)
<br>+++ plugins/external-editor/ChangeLog (Arbeitskopie)
<br>@@ -1,3 +1,17 @@
<br>+2009-01-06 Holger Macht <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=1" target="_top" rel="nofollow">hmacht@...</a>>
<br>+
<br>+ * org-gnome-external-editor.eplug.xml:
<br>+ Add hook for the editor to be launched from the menu.
<br>+
<br>+ * org-gnome-external-editor-errors.xml:
<br>+ Add error messages.
<br>+
<br>+ * external-editor.c:
<br>+ Extend the external editor plugin to be launched from composer.
<br>+
<br>+ * apps-evolution-external-editor.schemas.in:
<br>+ Add gconf key for external editor "auto launch feature"
<br>+
<br> 2008-08-27 Sankar P <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=2" target="_top" rel="nofollow">psankar@...</a>>
<br>
<br> License Changes
<br>Index: plugins/external-editor/external-editor.c
<br>===================================================================
<br>--- plugins/external-editor/external-editor.c (Revision 36999)
<br>+++ plugins/external-editor/external-editor.c (Arbeitskopie)
<br>@@ -11,11 +11,12 @@
<br> * Lesser General Public License for more details.
<br> *
<br> * You should have received a copy of the GNU Lesser General Public
<br>- * License along with the program; if not, see <http://www.gnu.org/licenses/>
<br>+ * License along with the program; if not, see <http://www.gnu.org/licenses/>
<br> *
<br> *
<br> * Authors:
<br>- * Sankar P <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=3" target="_top" rel="nofollow">psankar@...</a>>
<br>+ * Holger Macht <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=4" target="_top" rel="nofollow">hmacht@...</a>>
<br>+ * based on work by Sankar P <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=5" target="_top" rel="nofollow">psankar@...</a>>
<br> *
<br> * Copyright (C) 1999-2008 Novell, Inc. (www.novell.com)
<br> *
<br>@@ -31,6 +32,7 @@
<br> #include <mail/mail-config.h>
<br> #include <e-util/e-error.h>
<br> #include <e-msg-composer.h>
<br>+#include <camel/camel-mime-filter-tohtml.h>
<br>
<br> #include <glib/gi18n-lib.h>
<br> #include <glib-object.h>
<br>@@ -45,67 +47,59 @@
<br>
<br> #include <gconf/gconf-client.h>
<br>
<br>-#define d(x)
<br>+#define d(x)
<br>
<br>-#define EDITOR_GCONF_KEY "/apps/evolution/eplugin/external-editor/editor-command"
<br>+#define EDITOR_GCONF_KEY_COMMAND "/apps/evolution/eplugin/external-editor/editor-command"
<br>+#define EDITOR_GCONF_KEY_IMMEDIATE "/apps/evolution/eplugin/external-editor/launch-on-key-press"
<br>
<br>-void org_gnome_external_editor (EPlugin *ep, EMMenuTargetSelect *select);
<br>-void ee_editor_command_changed (GtkWidget *textbox);
<br>+gboolean e_plugin_ui_init (GtkUIManager *manager, EMsgComposer *composer);
<br> GtkWidget * e_plugin_lib_get_configure_widget (EPlugin *epl);
<br>-void async_external_editor (GArray *array);
<br>-static gboolean show_composer_dialog (EMsgComposer *composer);
<br>+static void ee_editor_command_changed (GtkWidget *textbox);
<br>+static void ee_editor_immediate_launch_changed (GtkWidget *checkbox);
<br>+static void async_external_editor (EMsgComposer *composer);
<br>+static gboolean editor_running (void);
<br>+static gboolean key_press_cb(GtkWidget * widget, GdkEventKey * event, EMsgComposer *composer);
<br>
<br>-/* Utility function to convert an email address to CamelInternetAddress.
<br>-May be this should belong to CamelInternetAddress.h file itself. */
<br>-static CamelInternetAddress * convert_to_camel_internet_address (char * emails)
<br>-{
<br>- CamelInternetAddress *cia = camel_internet_address_new();
<br>- gchar **address_tokens = NULL;
<br>- int i;
<br>+/* used to track when the external editor is active */
<br>+static GThread *editor_thread;
<br>
<br>- d(printf ("\n\aconvert called with : [%s] \n\a", emails));
<br>-
<br>- emails = g_strstrip (emails);
<br>-
<br>- if (emails && strlen (emails) > 1) {
<br>- address_tokens = g_strsplit (emails, ",", 0);
<br>-
<br>- if (address_tokens) {
<br>- for (i = 0; address_tokens[i]; ++i) {
<br>- camel_internet_address_add (cia, " ", address_tokens [i]);
<br>- d(printf ("\nAdding camel_internet_address[%s] \n", address_tokens [i]));
<br>- }
<br>- g_strfreev (address_tokens);
<br>-
<br>- g_free (emails);
<br>- return cia;
<br>- }
<br>- }
<br>- camel_object_unref (cia);
<br>- g_free (emails);
<br>- return NULL;
<br>-}
<br>-
<br>-void ee_editor_command_changed (GtkWidget *textbox)
<br>+void
<br>+ee_editor_command_changed (GtkWidget *textbox)
<br> {
<br> const char *editor;
<br> GConfClient *gconf;
<br>
<br> editor = gtk_entry_get_text (GTK_ENTRY(textbox));
<br> d(printf ("\n\aeditor is : [%s] \n\a", editor));
<br>-
<br>+
<br> /* gconf access for every key-press. Sucky ? */
<br> gconf = gconf_client_get_default ();
<br>- gconf_client_set_string (gconf, EDITOR_GCONF_KEY, editor, NULL);
<br>+ gconf_client_set_string (gconf, EDITOR_GCONF_KEY_COMMAND, editor, NULL);
<br> g_object_unref (gconf);
<br> }
<br>
<br>+void
<br>+ee_editor_immediate_launch_changed (GtkWidget *checkbox)
<br>+{
<br>+ gboolean immediately;
<br>+ GConfClient *gconf;
<br>+
<br>+ immediately = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (checkbox));
<br>+ d(printf ("\n\aimmediate launch is : [%d] \n\a", immediately));
<br>+
<br>+ gconf = gconf_client_get_default ();
<br>+ gconf_client_set_bool (gconf, EDITOR_GCONF_KEY_IMMEDIATE, immediately, NULL);
<br>+ g_object_unref (gconf);
<br>+}
<br>+
<br> GtkWidget *
<br> e_plugin_lib_get_configure_widget (EPlugin *epl)
<br> {
<br> GtkWidget *vbox, *textbox, *label, *help;
<br>+ GtkWidget *checkbox;
<br> GConfClient *gconf;
<br> char *editor;
<br>+ gboolean checked;
<br>
<br> vbox = gtk_vbox_new (FALSE, 10);
<br> textbox = gtk_entry_new ();
<br>@@ -113,32 +107,128 @@
<br> help = gtk_label_new (_("For Emacs use \"xemacs\"\nFor VI use \"gvim\""));
<br> gconf = gconf_client_get_default ();
<br>
<br>- editor = gconf_client_get_string (gconf, EDITOR_GCONF_KEY, NULL);
<br>+ editor = gconf_client_get_string (gconf, EDITOR_GCONF_KEY_COMMAND, NULL);
<br> if (editor) {
<br> gtk_entry_set_text (GTK_ENTRY(textbox), editor);
<br> g_free (editor);
<br> }
<br>+
<br>+ checkbox = gtk_check_button_new_with_label (
<br>+ _("Automatically launch when a new mail is edited"));
<br>+ checked = gconf_client_get_bool (gconf, EDITOR_GCONF_KEY_IMMEDIATE, NULL);
<br>+ if (checked)
<br>+ gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (checkbox), TRUE);
<br> g_object_unref (gconf);
<br>
<br> gtk_box_pack_start (GTK_BOX (vbox), label, FALSE, FALSE, 0);
<br> gtk_box_pack_start (GTK_BOX (vbox), textbox, FALSE, FALSE, 0);
<br> gtk_box_pack_start (GTK_BOX (vbox), help, FALSE, FALSE, 0);
<br>+ gtk_box_pack_start (GTK_BOX (vbox), checkbox, FALSE, FALSE, 0);
<br>
<br> g_signal_connect (textbox, "changed", G_CALLBACK(ee_editor_command_changed), textbox);
<br>-
<br>+
<br>+ g_signal_connect (checkbox, "toggled",
<br>+ G_CALLBACK(ee_editor_immediate_launch_changed), checkbox);
<br>+
<br> gtk_widget_show_all (vbox);
<br> return vbox;
<br> }
<br>
<br>+static void
<br>+enable_disable_composer (EMsgComposer *composer, gboolean enable)
<br>+{
<br>+ GtkhtmlEditor *editor;
<br>+ GtkAction *action;
<br>+ GtkActionGroup *action_group;
<br>+
<br>+ g_return_if_fail (E_IS_MSG_COMPOSER (composer));
<br>+
<br>+ editor = GTKHTML_EDITOR (composer);
<br>+
<br>+ if (enable)
<br>+ gtkhtml_editor_run_command (editor, "editable-on");
<br>+ else
<br>+ gtkhtml_editor_run_command (editor, "editable-off");
<br>+
<br>+ action = GTKHTML_EDITOR_ACTION_EDIT_MENU (composer);
<br>+ gtk_action_set_sensitive (action, enable);
<br>+
<br>+ action = GTKHTML_EDITOR_ACTION_FORMAT_MENU (composer);
<br>+ gtk_action_set_sensitive (action, enable);
<br>+
<br>+ action = GTKHTML_EDITOR_ACTION_INSERT_MENU (composer);
<br>+ gtk_action_set_sensitive (action, enable);
<br>+
<br>+ action_group = gtkhtml_editor_get_action_group (editor, "composer");
<br>+ gtk_action_group_set_sensitive (action_group, enable);
<br>+}
<br>+
<br>+static void enable_composer (EMsgComposer *composer)
<br>+{
<br>+ enable_disable_composer (composer, TRUE);
<br>+}
<br>+
<br>+static void disable_composer (EMsgComposer *composer)
<br>+{
<br>+ enable_disable_composer (composer, FALSE);
<br>+}
<br>+
<br>+static gboolean
<br>+update_composer_text (GArray *array)
<br>+{
<br>+ EMsgComposer *composer;
<br>+ gchar *text;
<br>+
<br>+ composer = g_array_index (array, gpointer, 0);
<br>+ text = g_array_index (array, gpointer, 1);
<br>+
<br>+ e_msg_composer_set_body_text (composer, text, -1);
<br>+
<br>+ enable_composer (composer);
<br>+
<br>+ g_free (text);
<br>+
<br>+ return FALSE;
<br>+}
<br>+
<br> void
<br>-async_external_editor (GArray *array)
<br>+async_external_editor (EMsgComposer *composer)
<br> {
<br> char *filename = NULL;
<br> gchar *argv[5];
<br> int status = 0;
<br>+ GConfClient *gconf;
<br>+ char *editor_cmd = NULL;
<br>+ gint fd;
<br>
<br>- argv[0] = g_array_index (array, gpointer, 0);
<br>- argv[1] = g_array_index (array, gpointer, 1);
<br>+ fd = g_file_open_tmp (NULL, &filename, NULL);
<br>+ if (fd > 0) {
<br>+ close (fd);
<br>+ /* Push the text (if there is one) from the composer to the file */
<br>+ g_file_set_contents (filename, gtkhtml_editor_get_text_plain(
<br>+ GTKHTML_EDITOR(composer), NULL),
<br>+ -1, NULL);
<br>+ d(printf ("\n\aTemporary-file Name is : [%s] \n\a", filename));
<br>+ } else {
<br>+ g_warning ("Temporary file fd is null");
<br>+ e_error_run (NULL, "org.gnome.evolution.plugins.external-editor:no-temp-file", NULL);
<br>+ g_idle_add ((GSourceFunc) enable_composer, composer);
<br>+ return ;
<br>+ }
<br>+
<br>+ gconf = gconf_client_get_default ();
<br>+ editor_cmd = gconf_client_get_string (gconf, EDITOR_GCONF_KEY_COMMAND, NULL);
<br>+ if (!editor_cmd) {
<br>+ if (! (editor_cmd = g_strdup(g_getenv ("EDITOR"))) )
<br>+ /* Make gedit the default external editor,
<br>+ if the default schemas are not installed
<br>+ and no $EDITOR is set. */
<br>+ editor_cmd = g_strdup("gedit");
<br>+ }
<br>+ g_object_unref (gconf);
<br>+
<br>+ argv[0] = editor_cmd;
<br>+ argv[1] = filename;
<br> argv[2] = NULL;
<br>
<br> filename = g_strdup (argv[1]);
<br>@@ -146,126 +236,139 @@
<br> if (!g_spawn_sync (NULL, argv, NULL, G_SPAWN_SEARCH_PATH, NULL, NULL, NULL, NULL, &status, NULL))
<br> {
<br> g_warning ("Unable to launch %s: ", argv[0]);
<br>+ printf("doing error\n");
<br> e_error_run (NULL, "org.gnome.evolution.plugins.external-editor:editor-not-launchable", NULL);
<br>+ printf("error done\n");
<br> g_free (filename);
<br>+ printf("unable to launch\n");
<br>+ enable_composer (composer);
<br> return ;
<br> }
<br>-
<br>+
<br> if (WEXITSTATUS (status) != 0) {
<br> d(printf ("\n\nsome problem here with external editor\n\n"));
<br>+ g_idle_add ((GSourceFunc) enable_composer, composer);
<br> return ;
<br> } else {
<br> gchar *buf;
<br>- CamelMimeMessage *message;
<br>- EMsgComposer *composer;
<br>
<br>- message = camel_mime_message_new ();
<br>-
<br> if (g_file_get_contents (filename, &buf, NULL, NULL)) {
<br>- gchar **tokens;
<br>- int i, j;
<br>+ gchar *htmltext;
<br>+ GArray *array;
<br>
<br>- tokens = g_strsplit (buf, "###|||", 6);
<br>+ htmltext = camel_text_to_html(buf, CAMEL_MIME_FILTER_TOHTML_PRE, 0);
<br>
<br>- for (i = 1; tokens[i]; ++i) {
<br>+ array = g_array_sized_new (TRUE, TRUE,
<br>+ sizeof (gpointer), 2 * sizeof(gpointer));
<br>+ array = g_array_append_val (array, composer);
<br>+ array = g_array_append_val (array, htmltext);
<br>
<br>- for (j = 0; tokens[i][j] && tokens[i][j] != '\n'; ++j) {
<br>- tokens [i][j] = ' ';
<br>- }
<br>+ g_idle_add ((GSourceFunc) update_composer_text, array);
<br>
<br>- if (tokens[i][j] == '\n')
<br>- tokens[i][j] = ' ';
<br>+ /* We no longer need that temporary file */
<br>+ g_remove (filename);
<br>+ g_free (filename);
<br>+ }
<br>+ }
<br>
<br>- d(printf ("\nstripped off token[%d] is : %s \n", i, tokens[i]));
<br>- }
<br>+ return ;
<br>+}
<br>
<br>- camel_mime_message_set_recipients (message, "To", convert_to_camel_internet_address(g_strchug(g_strdup(tokens[1]))));
<br>- camel_mime_message_set_recipients (message, "Cc", convert_to_camel_internet_address(g_strchug(g_strdup(tokens[2]))));
<br>- camel_mime_message_set_recipients (message, "Bcc", convert_to_camel_internet_address(g_strchug(g_strdup(tokens[3]))));
<br>- camel_mime_message_set_subject (message, tokens[4]);
<br>- camel_mime_part_set_content ((CamelMimePart *)message, tokens [5], strlen (tokens [5]), "text/plain");
<br>+static void launch_editor (GtkAction *action, EMsgComposer *composer)
<br>+{
<br>+ d(printf ("\n\nexternal_editor plugin is launched \n\n"));
<br>
<br>+ if (editor_running()) {
<br>+ printf("not opening editor, because it's still running\n");
<br>+ return ;
<br>+ }
<br>
<br>- /* FIXME: We need to make mail-remote working properly.
<br>- So that we neednot invoke composer widget at all.
<br>+ disable_composer (composer);
<br>
<br>- May be we can do it now itself by invoking local CamelTransport.
<br>- But all that is not needed for the first release.
<br>+ editor_thread = g_thread_create ((GThreadFunc)async_external_editor, composer, FALSE, NULL);
<br>+}
<br>
<br>- People might want to format mails using their editor (80 cols width etc.)
<br>- But might want to use evolution addressbook for auto-completion etc.
<br>- So starting the composer window anyway.
<br>- */
<br>+static GtkActionEntry entries[] = {
<br>
<br>- composer = e_msg_composer_new_with_message (message);
<br>- g_signal_connect (GTK_OBJECT (composer), "send", G_CALLBACK (em_utils_composer_send_cb), NULL);
<br>- g_signal_connect (GTK_OBJECT (composer), "save-draft", G_CALLBACK (em_utils_composer_save_draft_cb), NULL);
<br>-
<br>- /* Composer cannot be shown in any random thread. Should happen in main thread */
<br>- g_idle_add ((GSourceFunc) show_composer_dialog, composer);
<br>+ { "ExternalEditor",
<br>+ GTK_STOCK_EDIT,
<br>+ N_("Compose in External Editor"),
<br>+ "<Shift><Control>e",
<br>+ N_("Compose in External Editor"),
<br>+ G_CALLBACK (launch_editor) }
<br>+};
<br>
<br>- g_strfreev (tokens);
<br>+static gboolean
<br>+key_press_cb(GtkWidget * widget, GdkEventKey * event, EMsgComposer *composer)
<br>+{
<br>+ GConfClient *gconf;
<br>+ gboolean immediately;
<br>
<br>- /* We no longer need that temporary file */
<br>- g_remove (filename);
<br>- g_free (filename);
<br>- }
<br>+ gconf = gconf_client_get_default ();
<br>+ immediately = gconf_client_get_bool (gconf, EDITOR_GCONF_KEY_IMMEDIATE, NULL);
<br>+ g_object_unref (gconf);
<br>+ if (!immediately)
<br>+ return FALSE;
<br>+
<br>+ launch_editor (NULL, composer);
<br>+
<br>+ return TRUE;
<br>+}
<br>+
<br>+static void
<br>+editor_running_thread_func (GThread *thread, gpointer running)
<br>+{
<br>+ printf("checking thread\n");
<br>+ if (thread == editor_thread) {
<br>+ printf("editor still running!!!!!!\n");
<br>+ *(gboolean*)running = TRUE;
<br> }
<br> }
<br>
<br>+/* Racy? */
<br> static gboolean
<br>-show_composer_dialog (EMsgComposer *composer)
<br>+editor_running (void)
<br> {
<br>- gtk_widget_show (GTK_WIDGET(composer));
<br>- return FALSE;
<br>+ gboolean running = FALSE;
<br>+
<br>+ g_thread_foreach ((GFunc)editor_running_thread_func, &running);
<br>+ printf("returning %d\n", running);
<br>+
<br>+ return running;
<br> }
<br>
<br>-void org_gnome_external_editor (EPlugin *ep, EMMenuTargetSelect *select)
<br>+static gboolean
<br>+delete_cb (GtkWidget *widget, EMsgComposer *composer)
<br> {
<br>- /* The template to be used in the external editor */
<br>+ if (editor_running()) {
<br>+ printf("composer: %p , widget: %p\n", composer, widget);
<br>+ e_error_run (NULL, "org.gnome.evolution.plugins.external-editor:editor-still-running", NULL);
<br>+ return TRUE;
<br>+ }
<br>
<br>- /* README: I have not marked this for translation.
<br>- As I might change this string to make it more meaningful and friendlier based on feedback. */
<br>+ return FALSE;
<br>+}
<br>
<br>- char template[] = "###|||Insert , seperated TO addresses below this line. Do not edit or delete this line. Optional field\n\n###||| Insert , seperated CC addresses below this line. Do not edit or delete this line. Optional field\n\n###|||Insert , seperated BCC addresses below this line. Do not edit or delete this line. Optional field\n\n###|||Insert SUBJECT below this line. Do not edit or delete this line. Optional field\n\n###|||Insert BODY of mail below this line. Do not edit or delete this line.\n\n";
<br>+gboolean
<br>+e_plugin_ui_init (GtkUIManager *manager, EMsgComposer *composer)
<br>+{
<br>+ GtkhtmlEditor *editor;
<br>+ GtkHTML *html;
<br>
<br>- gint fd;
<br>- char *filename = NULL;
<br>- char *editor = NULL;
<br>- GConfClient *gconf;
<br>- GArray *array;
<br>+ editor = GTKHTML_EDITOR (composer);
<br>
<br>- d(printf ("\n\nexternal_editor plugin is launched \n\n"));
<br>+ /* Add actions to the "composer" action group. */
<br>+ gtk_action_group_add_actions (
<br>+ gtkhtml_editor_get_action_group (editor, "composer"),
<br>+ entries, G_N_ELEMENTS (entries), composer);
<br>
<br>- fd = g_file_open_tmp (NULL, &filename, NULL);
<br>- if (fd > 0) {
<br>- close (fd);
<br>- /* Push the template contents to the intermediate file */
<br>- g_file_set_contents (filename, template, strlen (template), NULL);
<br>- d(printf ("\n\aTemporary-file Name is : [%s] \n\a", filename));
<br>- } else {
<br>- g_warning ("Temporary file fd is null");
<br>- e_error_run (NULL, "org.gnome.evolution.plugins.external-editor:no-temp-file", NULL);
<br>- return ;
<br>- }
<br>+ html = gtkhtml_editor_get_html (editor);
<br>
<br>- gconf = gconf_client_get_default ();
<br>- editor = gconf_client_get_string (gconf, EDITOR_GCONF_KEY, NULL);
<br>- if (!editor) {
<br>+ g_signal_connect (G_OBJECT(html), "key_press_event",
<br>+ G_CALLBACK(key_press_cb), composer);
<br>
<br>- if (! (editor = g_strdup(g_getenv ("EDITOR"))) )
<br>- /* Make gedit the default external editor,
<br>- if the default schemas are not installed
<br>- and no $EDITOR is set. */
<br>- editor = g_strdup("gedit");
<br>- }
<br>- g_object_unref (gconf);
<br>+ g_signal_connect (G_OBJECT(composer), "delete-event",
<br>+ G_CALLBACK(delete_cb), composer);
<br>
<br>- array = g_array_sized_new (TRUE, TRUE, sizeof (gpointer), 2 * sizeof(gpointer));
<br>- array = g_array_append_val (array, editor);
<br>- array = g_array_append_val (array, filename);
<br>-
<br>- g_thread_create ( (GThreadFunc) async_external_editor, array, FALSE, NULL);
<br>-
<br>- return ;
<br>+ return TRUE;
<br> }
<br>Index: plugins/external-editor/org-gnome-external-editor-errors.xml
<br>===================================================================
<br>--- plugins/external-editor/org-gnome-external-editor-errors.xml (Revision 36999)
<br>+++ plugins/external-editor/org-gnome-external-editor-errors.xml (Arbeitskopie)
<br>@@ -1,14 +1,19 @@
<br> <?xml version="1.0" encoding="UTF-8"?>
<br> <error-list domain="org.gnome.evolution.plugins.external-editor">
<br>-
<br>+
<br> <error id="editor-not-launchable" type="error">
<br>- <_primary>Editor not launchable</_primary>
<br>- <_secondary>The external editor set in your plugin preferences cannot be launched. Try setting a different editor.</_secondary>
<br>+ <primary>Editor not launchable</primary>
<br>+ <secondary>The external editor set in your plugin preferences cannot be launched. Try setting a different editor.</secondary>
<br> </error>
<br>
<br> <error id="no-temp-file" type="error">
<br>- <_primary>Cannot create Temporary File</_primary>
<br>- <_secondary>Evolution is unable to create a temporary file to save your mail. Retry later.</_secondary>
<br>+ <primary>Cannot create Temporary File</primary>
<br>+ <secondary>Evolution is unable to create a temporary file to save your mail. Retry later.</secondary>
<br> </error>
<br>
<br>+ <error id="editor-still-running" type="error">
<br>+ <primary>External editor still running</primary>
<br>+ <secondary>The external editor is still running. The mail composer window cannot be closed as long as the editor is active.</secondary>
<br>+ </error>
<br>+
<br> </error-list>
<br>Index: plugins/external-editor/org-gnome-external-editor.eplug.xml
<br>===================================================================
<br>--- plugins/external-editor/org-gnome-external-editor.eplug.xml (Revision 36999)
<br>+++ plugins/external-editor/org-gnome-external-editor.eplug.xml (Arbeitskopie)
<br>@@ -1,27 +1,25 @@
<br>-<?xml version="1.0"?>
<br>+<?xml version="1.0" encoding="UTF-8"?>
<br> <e-plugin-list>
<br>- <!-- the path to the shared library -->
<br>- <e-plugin
<br>- id="org.gnome.plugin.external.editor"
<br>- type="shlib"
<br>- location="@PLUGINDIR@/liborg-gnome-external-editor@SOEXT@"
<br>- _name="External Editor">
<br>+ <e-plugin type="shlib"
<br>+ location="@PLUGINDIR@/liborg-gnome-external-editor@SOEXT@"
<br>+ id="org.gnome.plugin.external.editor" name="External Editor">
<br>+ <author name="Holger Macht" email="<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=6" target="_top" rel="nofollow">hmacht@...</a>"/>
<br> <author name="Sankar P" email="<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=7" target="_top" rel="nofollow">sankar2u@...</a>"/>
<br>- <_description>A plugin for using an external editor as the composer. You can send only plain-text messages.</_description>
<br>+ <description>A plugin for using an external editor as the composer. You can send only plain-text messages.</description>
<br>
<br>- <hook class="org.gnome.evolution.shell.bonobomenu:1.0">
<br>+ <hook class="org.gnome.evolution.ui:1.0">
<br>+ <ui-manager id="org.gnome.evolution.composer">
<br>+ <menubar name='main-menu'>
<br>+ <placeholder name='pre-edit-menu'>
<br>+ <menu action='file-menu'>
<br>+ <placeholder name="external-editor-holder">
<br>+ <menuitem action="ExternalEditor"/>
<br>+ </placeholder>
<br>+ </menu>
<br>+ </placeholder>
<br>+ </menubar>
<br>+ </ui-manager>
<br>+ </hook>
<br>
<br>- <menu id="org.gnome.evolution.shell" target="shell">
<br>- <!-- the path to the bonobo menu description -->
<br>- <ui file="@PLUGINDIR@/org-gnome-external-editor.xml"/>
<br>- <item
<br>- type="item"
<br>- verb="EPExtEditor"
<br>- path="/commands/EPExtEditor"
<br>- activate="org_gnome_external_editor"/>
<br>- </menu>
<br>-
<br>- </hook>
<br>-
<br> </e-plugin>
<br> </e-plugin-list>
<br>Index: plugins/external-editor/Makefile.am
<br>===================================================================
<br>--- plugins/external-editor/Makefile.am (Revision 36999)
<br>+++ plugins/external-editor/Makefile.am (Arbeitskopie)
<br>@@ -17,8 +17,7 @@
<br> errordir = $(privdatadir)/errors
<br>
<br> plugin_DATA = \
<br>- org-gnome-external-editor.eplug \
<br>- org-gnome-external-editor.xml
<br>+ org-gnome-external-editor.eplug
<br>
<br> plugin_LTLIBRARIES = liborg-gnome-external-editor.la
<br>
<br>@@ -43,7 +42,6 @@
<br> EXTRA_DIST = \
<br> org-gnome-external-editor.eplug.xml \
<br> org-gnome-external-editor-errors.xml \
<br>- org-gnome-external-editor.xml \
<br> $(schema_in_files)
<br>
<br> BUILT_SOURCES = org-gnome-external-editor.eplug \
<br>Index: composer/evolution-composer.ui
<br>===================================================================
<br>--- composer/evolution-composer.ui (Revision 36999)
<br>+++ composer/evolution-composer.ui (Arbeitskopie)
<br>@@ -11,6 +11,9 @@
<br> <menuitem action='save-draft'/>
<br> <placeholder name='template-holder'/>
<br> <separator/>
<br>+ <placeholder name='external-editor-holder'/>
<br>+ <separator/>
<br>+ <separator/>
<br> <menuitem action='print-preview'/>
<br> <menuitem action='print'/>
<br> <separator/>
<br>Index: composer/ChangeLog
<br>===================================================================
<br>--- composer/ChangeLog (Revision 36999)
<br>+++ composer/ChangeLog (Arbeitskopie)
<br>@@ -1,3 +1,8 @@
<br>+2009-01-06 Holger Macht <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=8" target="_top" rel="nofollow">hmacht@...</a>>
<br>+
<br>+ * evolution-composer.ui:
<br>+ Add menu placeholder for the external editor plugin.
<br>+
<br> 2008-12-18 Matthew Barnes <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=9" target="_top" rel="nofollow">mbarnes@...</a>>
<br>
<br> * e-composer-actions.c:
<br></tt><hr align="left" width="300" /><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=21308947&i=10" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-20553957Select "Today" upon opening calendar2008-11-17T21:45:02Z2008-11-17T21:45:02ZJennifer Newman(See bug #557187)
<br><br>Make "Today" selected when a calendar first opens.
<br><br>Thanks!
<br><br>Jenn
<br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=20553957&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-20517786Re: Fix addressbook error messages2008-11-15T09:36:46Z2008-11-15T09:36:46ZJennifer Newman(See bug #549964)
<br><br>Get rid of "we"s in error messages, combine duplicate error messages.
<br>Thanks!
<br><br>Jenn
<br><br /> <br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=20517786&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>549964.patch</strong> (5K) <a href="http://old.nabble.com/attachment/20517786/0/549964.patch" target="_top">Download Attachment</a></div>tag:old.nabble.com,2006:post-20126332Re: Patch for de.po2008-10-23T01:09:30Z2008-10-23T01:09:30ZSankar POn Thu, 2008-10-23 at 09:29 +0200, Claude Paroz wrote:
<div class='shrinkable-quote'><br>> Le jeudi 23 octobre 2008 à 11:15 +0530, Sankar a écrit :
<br>> > On Tue, 2008-10-21 at 15:51 +0200, Ronny Standtke wrote:
<br>> > > Hi all
<br>> > >
<br>> > > The German translation for "Always encrypt to myself when sending
<br>> > > encrypted messages" is really unclear. The attached patch fixes that.
<br>> > >
<br>> >
<br>> > Forwarding to gnome-i18n list, who are better equipped to judge the
<br>> > patch. Thanks.
<br>>
<br>> May we have a chance to look on this patch in a bug report :-) ?
</div><br>I filed <a href="http://bugzilla.gnome.org/show_bug.cgi?id=557563" target="_top" rel="nofollow">http://bugzilla.gnome.org/show_bug.cgi?id=557563</a><br><br>Thanks a lot Ronny for the patch and translators for the upcoming
<br>reivew :-)
<br><br>>
<br>> Claude
<br>>
<br><br>--
<br>Sankar
<br><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=20126332&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-20125758Re: Patch for de.po2008-10-23T00:29:32Z2008-10-23T00:29:32ZClaude Paroz-2Le jeudi 23 octobre 2008 à 11:15 +0530, Sankar a écrit :
<br>> On Tue, 2008-10-21 at 15:51 +0200, Ronny Standtke wrote:
<br>> > Hi all
<br>> >
<br>> > The German translation for "Always encrypt to myself when sending
<br>> > encrypted messages" is really unclear. The attached patch fixes that.
<br>> >
<br>>
<br>> Forwarding to gnome-i18n list, who are better equipped to judge the
<br>> patch. Thanks.
<br><br>May we have a chance to look on this patch in a bug report :-) ?
<br><br>Claude
<br><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=20125758&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-20124715Re: Patch for de.po2008-10-22T22:45:54Z2008-10-22T22:45:54ZSankar POn Tue, 2008-10-21 at 15:51 +0200, Ronny Standtke wrote:
<br>> Hi all
<br>>
<br>> The German translation for "Always encrypt to myself when sending
<br>> encrypted messages" is really unclear. The attached patch fixes that.
<br>>
<br><br>Forwarding to gnome-i18n list, who are better equipped to judge the
<br>patch. Thanks.
<br><br>> Regards
<br>>
<br>> Ronny Standtke
<br>> _______________________________________________
<br>> Evolution-patches mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=20124715&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br>> <a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br><br>--
<br>Sankar
<br><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=20124715&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-20090738Patch for de.po2008-10-21T06:51:10Z2008-10-21T06:51:10ZRonny StandtkeHi all
<br><br>The German translation for "Always encrypt to myself when sending
<br>encrypted messages" is really unclear. The attached patch fixes that.
<br><br>Regards
<br><br>Ronny Standtke
<br><br /><tt>[de.po.diff]</tt><br /><hr align="left" width="300" /><tt>--- de.po.original 2008-10-21 15:29:30.000000000 +0200
<br>+++ de.po 2008-10-21 15:30:18.000000000 +0200
<br>@@ -14498,7 +14498,7 @@
<br> #: ../mail/mail-config.glade.h:43
<br> msgid "Always encrypt to _myself when sending encrypted messages"
<br> msgstr ""
<br>-"Beim Verschicken verschlüsselter E-Mails _immer vor mir selbst verschlüsseln"
<br>+"Beim Verschicken verschlüsselter E-Mails _immer auch für mich verschlüsseln"
<br>
<br> #: ../mail/mail-config.glade.h:44
<br> msgid "Always request rea_d receipt"
<br></tt><hr align="left" width="300" /><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=20090738&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-20106130Patch for de.po2008-10-21T06:48:32Z2008-10-21T06:48:32ZRonny Standtke-4Hi all
<br><br>The German translation for "Always encrypt to myself when sending
<br>encrypted messages" is really unclear. The attached patch fixes that.
<br><br>Regards
<br><br>Ronny Standtke
<br><br>--
<br>Ronny Standtke Fachhochschule Nordwestschweiz
<br>Dozent Medienpädagogik / ICT Pädagogische Hochschule
<br>Telefon: +41 32 627 92 47 Obere Sternengasse 7
<br>Mobil : +41 79 786 81 82 4502 Solothurn
<br><br /><tt>[de.po.diff]</tt><br /><hr align="left" width="300" /><tt>--- de.po.original 2008-10-21 15:29:30.000000000 +0200
<br>+++ de.po 2008-10-21 15:30:18.000000000 +0200
<br>@@ -14498,7 +14498,7 @@
<br> #: ../mail/mail-config.glade.h:43
<br> msgid "Always encrypt to _myself when sending encrypted messages"
<br> msgstr ""
<br>-"Beim Verschicken verschlüsselter E-Mails _immer vor mir selbst verschlüsseln"
<br>+"Beim Verschicken verschlüsselter E-Mails _immer auch für mich verschlüsseln"
<br>
<br> #: ../mail/mail-config.glade.h:44
<br> msgid "Always request rea_d receipt"
<br></tt><hr align="left" width="300" /><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=20106130&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-19986692Re: Fix bugs in e-contact/e-vcard reordering attributes [#556061]2008-10-13T19:41:57Z2008-10-13T19:41:57ZSrinivasa RagavanOn Mon, 2008-10-13 at 11:44 +0200, Frederic Crozat wrote:
<br>> Le lundi 13 octobre 2008 à 09:12 +0530, Srinivasa Ragavan a écrit :
<br>> > You really don't have to post on bugzilla and post a mail. I will review
<br>> > it over bugzilla.
<br>>
<br>> Since this list seems useless now, it would be better to close it
<br>> completely and keep archives opened.
<br><br>I must do that I think.
<br><br>-Srini.
<br><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19986692&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-19951635Re: Fix bugs in e-contact/e-vcard reordering attributes [#556061]2008-10-13T02:44:17Z2008-10-13T02:44:17ZFrederic CrozatLe lundi 13 octobre 2008 à 09:12 +0530, Srinivasa Ragavan a écrit :
<br>> You really don't have to post on bugzilla and post a mail. I will review
<br>> it over bugzilla.
<br><br>Since this list seems useless now, it would be better to close it
<br>completely and keep archives opened.
<br><br>--
<br>Frederic Crozat <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19951635&i=0" target="_top" rel="nofollow">fcrozat@...</a>>
<br>Mandriva
<br><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19951635&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-19948460Re: Fix bugs in e-contact/e-vcard reordering attributes [#556061]2008-10-12T20:42:20Z2008-10-12T20:42:20ZSrinivasa RagavanYou really don't have to post on bugzilla and post a mail. I will review
<br>it over bugzilla.
<br><br>-Srini.
<br>On Sun, 2008-10-12 at 22:42 +0100, Matt Davey wrote:
<div class='shrinkable-quote'><br>> (see bug #556061)
<br>>
<br>>
<br>> If you import a vcard with three EMAIL attributes and then export, you will
<br>> find that the EMAIL attributes are exported in reverse order.
<br>>
<br>> Also, if you create two email entries in the contact editor gui, you will find
<br>> that they are put into the vcard in reverse order.
<br>>
<br>> This may seem trivial, but it causes complications for the addressbook-conduit.
<br>> If the pda has two emails, in 'slot1' and 'slot2' it is problematic if they
<br>> get written to 'email1' and 'email2' on the desktop and they are subsequently
<br>> edited by the gui. The edit can cause them to be reversed, which causes
<br>> consistency problems when syncing.
<br>>
<br>> I'm attaching two patches, one for e-d-s to fix e-contact and e-vcard, and one
<br>> for the gui editor. I have more extensive patches for the conduit itself so
<br>> I'll raise that separately.
<br>>
<br>> Matt
<br>>
<br>> Index: addressbook/gui/contact-editor/e-contact-editor.c
<br>> ===================================================================
<br>> --- addressbook/gui/contact-editor/e-contact-editor.c (revision 36574)
<br>> +++ addressbook/gui/contact-editor/e-contact-editor.c (working copy)
<br>> @@ -1078,7 +1078,7 @@
<br>> for (l = attr_list; l; l = g_list_next (l)) {
<br>> EVCardAttribute *attr = l->data;
<br>>
<br>> - e_vcard_add_attribute (vcard, e_vcard_attribute_copy (attr));
<br>> + e_vcard_append_attribute (vcard, e_vcard_attribute_copy (attr));
<br>> }
<br>> }
<br>>
<br>> Index: e-contact.c
<br>> ===================================================================
<br>> --- e-contact.c (revision 9652)
<br>> +++ e-contact.c (working copy)
<br>> @@ -808,7 +808,8 @@
<br>> e_vcard_attribute_param_new (EVC_TYPE),
<br>> "OTHER");
<br>> }
<br>> - e_vcard_add_attribute (E_VCARD (contact), attr);
<br>> + /* append, so that first attr is still first attr */
<br>> + e_vcard_append_attribute (E_VCARD (contact), attr);
<br>> }
<br>>
<br>> e_vcard_attribute_add_value (attr, sval);
<br>> @@ -829,7 +830,7 @@
<br>> gboolean found = FALSE;
<br>> int num_left = info->list_elem;
<br>> GList *attrs = e_vcard_get_attributes (E_VCARD (contact));
<br>> - GList *l;
<br>> + GList *l, *last_attr;
<br>>
<br>> for (l = attrs; l && !found; l = l->next) {
<br>> const char *name;
<br>> @@ -880,10 +881,12 @@
<br>> }
<br>>
<br>> if (found_needed1 && found_needed2) {
<br>> + last_attr = l; /* remember last occurrence, even if it's not the one we want */
<br>> if (num_left-- == 0) {
<br>> found = TRUE;
<br>> - break;
<br>> }
<br>> + break; /* break here, otherwise we'd match again if there
<br>> + are any more params in this attribute */
<br>> }
<br>> }
<br>> }
<br>> @@ -896,7 +899,8 @@
<br>> else {
<br>> /* we didn't find it - add a new attribute */
<br>> attr = e_vcard_attribute_new (NULL, info->vcard_field_name);
<br>> - e_vcard_add_attribute (E_VCARD (contact), attr);
<br>> + /* append attribute, to ensure we don't change HOME into HOME_1, for example */
<br>> + e_vcard_append_attribute (E_VCARD (contact), attr);
<br>> if (info->attr_type1)
<br>> e_vcard_attribute_add_param_with_value (attr, e_vcard_attribute_param_new (EVC_TYPE),
<br>> info->attr_type1);
<br>> @@ -1640,11 +1644,12 @@
<br>> name = e_vcard_attribute_get_name (attr);
<br>>
<br>> if (!g_ascii_strcasecmp (name, info->vcard_field_name)) {
<br>> - l = g_list_prepend (l, e_vcard_attribute_copy (attr));
<br>> + l = g_list_append (l, e_vcard_attribute_copy (attr));
<br>> }
<br>> }
<br>>
<br>> - return g_list_reverse(l);
<br>> + return l;
<br>> +
<br>> }
<br>>
<br>> /**
<br>> @@ -1669,7 +1674,11 @@
<br>> e_vcard_remove_attributes (E_VCARD (contact), NULL, info->vcard_field_name);
<br>>
<br>> for (l = attributes; l; l = l->next)
<br>> - e_vcard_add_attribute (E_VCARD (contact),
<br>> + /* append the attributes, to ensure synthetic
<br>> + * attributes such as EMAIL_1, EMAIL_2 are in the same
<br>> + * order as the vcard entries appear.
<br>> + */
<br>> + e_vcard_append_attribute (E_VCARD (contact),
<br>> e_vcard_attribute_copy ((EVCardAttribute*)l->data));
<br>> }
<br>>
<br>> Index: e-vcard.c
<br>> ===================================================================
<br>> --- e-vcard.c (revision 9652)
<br>> +++ e-vcard.c (working copy)
<br>> @@ -1149,6 +1149,22 @@
<br>> }
<br>>
<br>> /**
<br>> + * e_vcard_append_attribute:
<br>> + * @evc: an #EVCard
<br>> + * @attr: an #EVCardAttribute to add to end of list of attributes
<br>> + *
<br>> + * Adds @attr to @evc.
<br>> + **/
<br>> +void
<br>> +e_vcard_append_attribute (EVCard *evc, EVCardAttribute *attr)
<br>> +{
<br>> + g_return_if_fail (E_IS_VCARD (evc));
<br>> + g_return_if_fail (attr != NULL);
<br>> +
<br>> + evc->priv->attributes = g_list_append (evc->priv->attributes, attr);
<br>> +}
<br>> +
<br>> +/**
<br>> * e_vcard_add_attribute_with_value:
<br>> * @evcard: an #EVCard
<br>> * @attr: an #EVCardAttribute to add
<br>> Index: e-vcard.h
<br>> ===================================================================
<br>> --- e-vcard.h (revision 9652)
<br>> +++ e-vcard.h (working copy)
<br>> @@ -146,6 +146,7 @@
<br>> void e_vcard_remove_attributes (EVCard *evc, const char *attr_group, const char *attr_name);
<br>> void e_vcard_remove_attribute (EVCard *evc, EVCardAttribute *attr);
<br>> void e_vcard_add_attribute (EVCard *evc, EVCardAttribute *attr);
<br>> +void e_vcard_append_attribute (EVCard *evc, EVCardAttribute *attr);
<br>> void e_vcard_add_attribute_with_value (EVCard *evcard, EVCardAttribute *attr, const char *value);
<br>> void e_vcard_add_attribute_with_values (EVCard *evcard, EVCardAttribute *attr, ...);
<br>> void e_vcard_attribute_add_value (EVCardAttribute *attr, const char *value);
<br>> _______________________________________________
<br>> Evolution-patches mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19948460&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br>> <a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a></div><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19948460&i=1" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-19946184Fix bugs in e-contact/e-vcard reordering attributes [#556061]2008-10-12T14:42:48Z2008-10-12T14:42:48ZMatt Davey(see bug #556061)
<br><br><br>If you import a vcard with three EMAIL attributes and then export, you will
<br>find that the EMAIL attributes are exported in reverse order.
<br><br>Also, if you create two email entries in the contact editor gui, you will find
<br>that they are put into the vcard in reverse order.
<br><br>This may seem trivial, but it causes complications for the addressbook-conduit.
<br> If the pda has two emails, in 'slot1' and 'slot2' it is problematic if they
<br>get written to 'email1' and 'email2' on the desktop and they are subsequently
<br>edited by the gui. The edit can cause them to be reversed, which causes
<br>consistency problems when syncing.
<br><br>I'm attaching two patches, one for e-d-s to fix e-contact and e-vcard, and one
<br>for the gui editor. I have more extensive patches for the conduit itself so
<br>I'll raise that separately.
<br><br>Matt
<br><br><br />Index: addressbook/gui/contact-editor/e-contact-editor.c
<br>===================================================================
<br>--- addressbook/gui/contact-editor/e-contact-editor.c (revision 36574)
<br>+++ addressbook/gui/contact-editor/e-contact-editor.c (working copy)
<br>@@ -1078,7 +1078,7 @@
<br> for (l = attr_list; l; l = g_list_next (l)) {
<br> EVCardAttribute *attr = l->data;
<br>
<br>- e_vcard_add_attribute (vcard, e_vcard_attribute_copy (attr));
<br>+ e_vcard_append_attribute (vcard, e_vcard_attribute_copy (attr));
<br> }
<br> }
<br>
<br><br />Index: e-contact.c
<br>===================================================================
<br>--- e-contact.c (revision 9652)
<br>+++ e-contact.c (working copy)
<br>@@ -808,7 +808,8 @@
<br> e_vcard_attribute_param_new (EVC_TYPE),
<br> "OTHER");
<br> }
<br>- e_vcard_add_attribute (E_VCARD (contact), attr);
<br>+ /* append, so that first attr is still first attr */
<br>+ e_vcard_append_attribute (E_VCARD (contact), attr);
<br> }
<br>
<br> e_vcard_attribute_add_value (attr, sval);
<br>@@ -829,7 +830,7 @@
<br> gboolean found = FALSE;
<br> int num_left = info->list_elem;
<br> GList *attrs = e_vcard_get_attributes (E_VCARD (contact));
<br>- GList *l;
<br>+ GList *l, *last_attr;
<br>
<br> for (l = attrs; l && !found; l = l->next) {
<br> const char *name;
<br>@@ -880,10 +881,12 @@
<br> }
<br>
<br> if (found_needed1 && found_needed2) {
<br>+ last_attr = l; /* remember last occurrence, even if it's not the one we want */
<br> if (num_left-- == 0) {
<br> found = TRUE;
<br>- break;
<br> }
<br>+ break; /* break here, otherwise we'd match again if there
<br>+ are any more params in this attribute */
<br> }
<br> }
<br> }
<br>@@ -896,7 +899,8 @@
<br> else {
<br> /* we didn't find it - add a new attribute */
<br> attr = e_vcard_attribute_new (NULL, info->vcard_field_name);
<br>- e_vcard_add_attribute (E_VCARD (contact), attr);
<br>+ /* append attribute, to ensure we don't change HOME into HOME_1, for example */
<br>+ e_vcard_append_attribute (E_VCARD (contact), attr);
<br> if (info->attr_type1)
<br> e_vcard_attribute_add_param_with_value (attr, e_vcard_attribute_param_new (EVC_TYPE),
<br> info->attr_type1);
<br>@@ -1640,11 +1644,12 @@
<br> name = e_vcard_attribute_get_name (attr);
<br>
<br> if (!g_ascii_strcasecmp (name, info->vcard_field_name)) {
<br>- l = g_list_prepend (l, e_vcard_attribute_copy (attr));
<br>+ l = g_list_append (l, e_vcard_attribute_copy (attr));
<br> }
<br> }
<br>
<br>- return g_list_reverse(l);
<br>+ return l;
<br>+
<br> }
<br>
<br> /**
<br>@@ -1669,7 +1674,11 @@
<br> e_vcard_remove_attributes (E_VCARD (contact), NULL, info->vcard_field_name);
<br>
<br> for (l = attributes; l; l = l->next)
<br>- e_vcard_add_attribute (E_VCARD (contact),
<br>+ /* append the attributes, to ensure synthetic
<br>+ * attributes such as EMAIL_1, EMAIL_2 are in the same
<br>+ * order as the vcard entries appear.
<br>+ */
<br>+ e_vcard_append_attribute (E_VCARD (contact),
<br> e_vcard_attribute_copy ((EVCardAttribute*)l->data));
<br> }
<br>
<br>Index: e-vcard.c
<br>===================================================================
<br>--- e-vcard.c (revision 9652)
<br>+++ e-vcard.c (working copy)
<br>@@ -1149,6 +1149,22 @@
<br> }
<br>
<br> /**
<br>+ * e_vcard_append_attribute:
<br>+ * @evc: an #EVCard
<br>+ * @attr: an #EVCardAttribute to add to end of list of attributes
<br>+ *
<br>+ * Adds @attr to @evc.
<br>+ **/
<br>+void
<br>+e_vcard_append_attribute (EVCard *evc, EVCardAttribute *attr)
<br>+{
<br>+ g_return_if_fail (E_IS_VCARD (evc));
<br>+ g_return_if_fail (attr != NULL);
<br>+
<br>+ evc->priv->attributes = g_list_append (evc->priv->attributes, attr);
<br>+}
<br>+
<br>+/**
<br> * e_vcard_add_attribute_with_value:
<br> * @evcard: an #EVCard
<br> * @attr: an #EVCardAttribute to add
<br>Index: e-vcard.h
<br>===================================================================
<br>--- e-vcard.h (revision 9652)
<br>+++ e-vcard.h (working copy)
<br>@@ -146,6 +146,7 @@
<br> void e_vcard_remove_attributes (EVCard *evc, const char *attr_group, const char *attr_name);
<br> void e_vcard_remove_attribute (EVCard *evc, EVCardAttribute *attr);
<br> void e_vcard_add_attribute (EVCard *evc, EVCardAttribute *attr);
<br>+void e_vcard_append_attribute (EVCard *evc, EVCardAttribute *attr);
<br> void e_vcard_add_attribute_with_value (EVCard *evcard, EVCardAttribute *attr, const char *value);
<br> void e_vcard_add_attribute_with_values (EVCard *evcard, EVCardAttribute *attr, ...);
<br> void e_vcard_attribute_add_value (EVCardAttribute *attr, const char *value);
<br><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19946184&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-19946158patch to allow building evolution outside source tree [#556059]2008-10-12T14:39:55Z2008-10-12T14:39:55ZMatt Davey(See bug #556059)
<br><br>See attached patch.
<br><br>I have a Makefile that leaves the Evo source tree intact and generates the Evo
<br>Makefiles and all build objects in a obj/ tree. There's a slight change
<br>required to the calendar/conduit/common files to support this.
<br><br>Matt
<br><br><br />Index: calendar/conduits/common/libecalendar-common-conduit.c
<br>===================================================================
<br>--- calendar/conduits/common/libecalendar-common-conduit.c (revision 36574)
<br>+++ calendar/conduits/common/libecalendar-common-conduit.c (working copy)
<br>@@ -26,7 +26,7 @@
<br> #include <string.h>
<br>
<br> #include <libedataserver/e-categories.h>
<br>-#include <e-util/e-pilot-util.h>
<br>+#include <e-pilot-util.h>
<br> #include <pi-appinfo.h>
<br> #include <glib.h>
<br>
<br>Index: calendar/conduits/common/Makefile.am
<br>===================================================================
<br>--- calendar/conduits/common/Makefile.am (revision 36574)
<br>+++ calendar/conduits/common/Makefile.am (working copy)
<br>@@ -1,4 +1,5 @@
<br> INCLUDES = \
<br>+ -I$(top_srcdir) \
<br> -I$(top_srcdir)/e-util \
<br> -I$(top_builddir)/e-util \
<br> $(EVOLUTION_CALENDAR_CONDUIT_CFLAGS)
<br><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19946158&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-19944779Category support in addressbook-conduit2008-10-12T12:14:57Z2008-10-12T12:14:57ZMatt DaveyI'm attaching a patch to add category support to the addressbook-conduit.
<br>I've also attached the patch to bug 201167:
<br><a href="http://bugzilla.gnome.org/show_bug.cgi?id=201167" target="_top" rel="nofollow">http://bugzilla.gnome.org/show_bug.cgi?id=201167</a><br><br>The code is similar to the code used to sync categories in the
<br>calendar/todo/memo conduit, but that code couldn't be reused because
<br>the categories are stored differently in the e-contact code.
<br><br>A palm addressbook entry can only have a single category, but evolution
<br>can have multiple categories. The approach taken in my patch is:
<br>1. If a category in use on the desktop doesn't exist on the palm,
<br> create it. If a category in use on the palm doesn't exist
<br> on the desktop, create it.
<br>2. If we're writing to a desktop entry, ensure the palm category
<br> is prepended to the list of categories. If the palm is 'Unfiled' -
<br> i.e. has no categories, then delete all categories in the desktop
<br> entry.
<br>3. When writing to the palm, we first look to see if any
<br> of the desktop categories are known to the palm. If
<br> not, we use the first category found on the
<br> desktop. We shorten the desktop category if it is
<br> longer than 15 characters. This means that if you subsequently
<br> change the entry on the palm then the shortened category name
<br> will be created on the desktop. I don't see a way around this
<br> without adding support for UUID for desktop categories and
<br> a 'rename category' API.
<br>
<br>This patch also includes a one-liner to fix broken name mapping when
<br>writing from the Palm to the Desktop:
<br><br> /* set the name, respecting the pilot's given/family names */
<br> e_contact_set (contact, E_CONTACT_NAME, name);
<br><br>This seems to have been broken inadvertently in revision r26202.
<br><br>This fixes bugs 201167, 269342, 325230.
<br><br>Matt
<br><br><br />Index: address-conduit.c
<br>===================================================================
<br>--- address-conduit.c (revision 36574)
<br>+++ address-conduit.c (working copy)
<br>@@ -34,6 +34,8 @@
<br> #include <pi-socket.h>
<br> #include <pi-dlp.h>
<br> #include <pi-address.h>
<br>+#include <pi-appinfo.h>
<br>+#include <libedataserver/e-categories.h>
<br> #include <libedataserver/e-url.h>
<br> #include <libedataserverui/e-passwords.h>
<br> #include <libebook/e-book.h>
<br>@@ -63,6 +65,7 @@
<br>
<br> #define WARN g_warning
<br> #define INFO g_message
<br>+#define PILOT_MAX_CATEGORIES 16
<br>
<br> enum {
<br> LABEL_WORK,
<br>@@ -154,6 +157,194 @@
<br> gchar *last_uri;
<br> };
<br>
<br>+/* NOTE: copied from calendar/conduit/common/libecalendar-common-conduit.c
<br>+ * Adds a category to the category app info structure (name and ID),
<br>+ * sets category->renamed[i] to true if possible to rename.
<br>+ *
<br>+ * This will be packed and written to the app info block during post_sync.
<br>+ *
<br>+ * NOTE: cat_to_add MUST be in PCHAR format. Evolution stores categories
<br>+ * in UTF-8 format. A conversion must take place before calling
<br>+ * this function (see e_pilot_utf8_to_pchar() in e-pilot-util.c)
<br>+ */
<br>+static int
<br>+e_pilot_add_category_if_possible(char *cat_to_add, struct CategoryAppInfo *category)
<br>+{
<br>+ int i, j;
<br>+ int retval = 0; /* 0 is the Unfiled category */
<br>+ LOG(g_message("e_pilot_add_category_if_possible\n"));
<br>+
<br>+ for(i=0; i<PILOT_MAX_CATEGORIES; i++){
<br>+ /* if strlen is 0, then the category is empty
<br>+ the PalmOS doesn't let 0-length strings for
<br>+ categories */
<br>+ if(strlen(category->name[i]) == 0){
<br>+ int cat_to_add_len;
<br>+ int desktopUniqueID;
<br>+
<br>+ cat_to_add_len = strlen(cat_to_add);
<br>+ retval = i;
<br>+
<br>+ if(cat_to_add_len > 15){
<br>+ char tmpstr[16];
<br>+ strncpy(tmpstr, cat_to_add,16);
<br>+ tmpstr[16] = '\0';
<br>+ /* Have to truncate the category name */
<br>+ LOG (g_warning (_("*** Desktop category '%s' too long for PDA."
<br>+ "Truncating to '%s' ***"),cat_to_add, tmpstr));
<br>+ cat_to_add_len = 15;
<br>+ }
<br>+
<br>+ /* only 15 characters for category, 16th is
<br>+ * '\0' can't do direct mem transfer due to
<br>+ * declaration type
<br>+ */
<br>+ for(j=0; j<cat_to_add_len; j++){
<br>+ category->name[i][j] = cat_to_add[j];
<br>+ }
<br>+
<br>+ for(j=cat_to_add_len; j<16; j++) {
<br>+ category->name[i][j] = '\0';
<br>+ }
<br>+
<br>+ //find a desktop id that is not in use between 128 and 255
<br>+ /* XXX desktopUniqueID should really be used for tracking
<br>+ * categories across renaming operations, but as Evo
<br>+ * doesn't have a concept of category UIDs or renaming,
<br>+ * we don't have much use for it at present.
<br>+ */
<br>+ for (desktopUniqueID = 128; desktopUniqueID <= 255; desktopUniqueID++) {
<br>+ int found = 0;
<br>+ for(j=0; j<PILOT_MAX_CATEGORIES; j++){
<br>+ if (category->ID[j] == desktopUniqueID) {
<br>+ found = 1;
<br>+ }
<br>+ }
<br>+ if (found == 0) {
<br>+ break;
<br>+ }
<br>+ if (desktopUniqueID == 255) {
<br>+ LOG (g_warning (_("*** no more categories available on PC ***")));
<br>+ }
<br>+ }
<br>+ category->ID[i] = desktopUniqueID;
<br>+
<br>+ category->renamed[i] = TRUE;
<br>+
<br>+ break;
<br>+ }
<br>+ }
<br>+
<br>+ if(retval == 0){
<br>+ LOG (g_warning (_("*** not adding category - category list already full ***")));
<br>+ }
<br>+
<br>+ return retval;
<br>+}
<br>+
<br>+/*
<br>+ * conversion from an evolution category to a palm category.
<br>+ * we iterate over the list of desktop categories to see if
<br>+ * there is matching palm category. If not, we create
<br>+ * a new palm category from the first evo category.
<br>+ * If a category was not found and could not be created,
<br>+ * or if there are no desktop categories, then *pilotCategory
<br>+ * is set to zero ("Unfiled").
<br>+ */
<br>+static
<br>+void e_pilot_local_category_to_remote(int * pilotCategory,
<br>+ EContact *contact, struct CategoryAppInfo *category)
<br>+{
<br>+ GList *c_list = NULL, *l;
<br>+ char * category_string, *first_category = NULL;
<br>+ int i;
<br>+ *pilotCategory = 0; /* default to "Unfiled" */
<br>+ c_list = e_contact_get (contact, E_CONTACT_CATEGORY_LIST);
<br>+ if (c_list) {
<br>+ /* remember the first category */
<br>+ first_category = e_pilot_utf8_to_pchar((const char *)c_list->data);
<br>+ }
<br>+ l = c_list;
<br>+ while(l && *pilotCategory == 0) {
<br>+ //list != 0, so at least 1 category is assigned
<br>+ category_string = e_pilot_utf8_to_pchar((const char *)l->data);
<br>+ for (i=0; i < PILOT_MAX_CATEGORIES; i++) {
<br>+ /* only 15 chars + nul in palm category name */
<br>+ if (strncmp(category_string,category->name[i], 15) == 0) {
<br>+ *pilotCategory = i;
<br>+ break;
<br>+ }
<br>+ }
<br>+ g_free(category_string);
<br>+ l = l->next;
<br>+ }
<br>+ if (*pilotCategory == 0 && first_category && *first_category) {
<br>+ /* category not available on palm, try to create it */
<br>+ /* XXX e_pilot_add_category_if_possible can be called
<br>+ * when we're doing a 'copy from pilot'. This should
<br>+ * really be avoided.
<br>+ */
<br>+ *pilotCategory = e_pilot_add_category_if_possible(
<br>+ first_category,category);
<br>+ g_free(first_category);
<br>+ }
<br>+ g_list_foreach (c_list, (GFunc)g_free, NULL);
<br>+ g_list_free(c_list);
<br>+ /*end category*/
<br>+}
<br>+
<br>+/*
<br>+ * conversion from a palm category to an evolution category
<br>+ */
<br>+static
<br>+void e_pilot_remote_category_to_local(int pilotCategory,
<br>+ EContact *contact, struct CategoryAppInfo *category)
<br>+{
<br>+ char *category_string = NULL, *str;
<br>+
<br>+ if (pilotCategory != 0) {
<br>+ /* pda has category assigned */
<br>+ category_string = e_pilot_utf8_from_pchar(
<br>+ category->name[pilotCategory]);
<br>+
<br>+ LOG(g_message("PDA Category: %s\n", category_string));
<br>+
<br>+ if(e_categories_exist(category_string) == FALSE){
<br>+ /* add if it doesn't exist */
<br>+ LOG(g_message("Category created on pc\n"));
<br>+ e_categories_add(category_string, NULL, NULL, TRUE);
<br>+ }
<br>+ }
<br>+
<br>+ /* store the data in EContact */
<br>+ if (category_string == NULL) {
<br>+ /* remove categories from desktop. */
<br>+ e_contact_set (contact, E_CONTACT_CATEGORY_LIST, NULL);
<br>+ }
<br>+ else {
<br>+
<br>+ /* Since the first first category is synced with the PDA, add the PDA's
<br>+ * category to the beginning of the category list */
<br>+ GList *c_list = NULL;
<br>+ GList *newcat_in_list;
<br>+ c_list = e_contact_get (contact, E_CONTACT_CATEGORY_LIST);
<br>+
<br>+ /* remove old item from list so we don't have duplicate entries */
<br>+ newcat_in_list = g_list_find_custom(c_list, category_string, (GCompareFunc)strcmp);
<br>+ if(newcat_in_list != NULL)
<br>+ {
<br>+ g_free(newcat_in_list->data);
<br>+ c_list = g_list_remove(c_list, newcat_in_list->data);
<br>+ }
<br>+
<br>+ c_list = g_list_prepend(c_list, category_string);
<br>+ e_contact_set (contact, E_CONTACT_CATEGORY_LIST, c_list);
<br>+
<br>+ g_list_foreach (c_list, (GFunc)g_free, NULL);
<br>+ g_list_free(c_list);
<br>+ }
<br>+}
<br>+
<br> static EAddrConduitCfg *
<br> addrconduit_load_configuration (guint32 pilot_id)
<br> {
<br>@@ -919,6 +1110,9 @@
<br> #endif
<br> }
<br>
<br>+ /*Category support*/
<br>+ e_pilot_local_category_to_remote(&(local->local.category), contact, &(ctxt->ai.category));
<br>+
<br> local->addr->entry[entryFirstname] = e_pilot_utf8_to_pchar (e_contact_get_const (contact, E_CONTACT_GIVEN_NAME));
<br> local->addr->entry[entryLastname] = e_pilot_utf8_to_pchar (e_contact_get_const (contact, E_CONTACT_FAMILY_NAME));
<br> local->addr->entry[entryCompany] = e_pilot_utf8_to_pchar (e_contact_get_const (contact, E_CONTACT_ORG));
<br>@@ -1104,11 +1298,17 @@
<br> else
<br> contact = e_contact_duplicate (in_contact);
<br>
<br>+ /*Category support*/
<br>+ e_pilot_remote_category_to_local(remote->category, contact, &(ctxt->ai.category));
<br>+
<br> /* Name */
<br> name = e_contact_name_new ();
<br> name->given = get_entry_text (address, entryFirstname);
<br> name->family = get_entry_text (address, entryLastname);
<br>
<br>+ /* set the name, respecting the pilot's given/family names */
<br>+ e_contact_set (contact, E_CONTACT_NAME, name);
<br>+ /* now set the full_name */
<br> full_name = e_contact_name_to_string (name);
<br> e_contact_set (contact, E_CONTACT_FULL_NAME, full_name);
<br> e_contact_name_free (name);
<br>@@ -1423,9 +1623,29 @@
<br> {
<br> GList *changed;
<br> gchar *filename, *change_id;
<br>+ unsigned char *buf;
<br>+ int dlpRetVal, len;
<br>
<br> LOG (g_message ( "post_sync: Address Conduit v.%s", CONDUIT_VERSION ));
<br>
<br>+ /* Write AppBlock to PDA - updates categories */
<br>+ buf = (unsigned char*)g_malloc (0xffff);
<br>+
<br>+ len = pack_AddressAppInfo (&(ctxt->ai), buf, 0xffff);
<br>+
<br>+ dlpRetVal = dlp_WriteAppBlock (dbi->pilot_socket, dbi->db_handle,
<br>+ (unsigned char *)buf, len);
<br>+
<br>+ g_free (buf);
<br>+
<br>+ if (dlpRetVal < 0) {
<br>+ WARN ( ("Could not write pilot's Address application block"));
<br>+ WARN ("dlp_WriteAppBlock(...) = %d", dlpRetVal);
<br>+ /*gnome_pilot_conduit_error (conduit,
<br>+ _("Could not write pilot's Address application block"));*/
<br>+ return -1;
<br>+ }
<br>+
<br> g_free (ctxt->cfg->last_uri);
<br> ctxt->cfg->last_uri = g_strdup (e_book_get_uri (ctxt->ebook));
<br> addrconduit_save_configuration (ctxt->cfg);
<br><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19944779&i=0" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-19724408Re: Using gpg2 with SHA5122008-09-29T06:58:32Z2008-09-29T06:58:32ZJeffrey Stedfastseems reasonable to me.
<br><br>Jeff
<br><br><br>On Sun, 2008-09-28 at 21:56 +0200, Steffen Michalke wrote:
<div class='shrinkable-quote'><br>> Steffen Michalke <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19724408&i=0" target="_top" rel="nofollow">stmichalke@...</a>> writes:
<br>>
<br>> > Srinivasa Ragavan <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19724408&i=1" target="_top" rel="nofollow">sragavan@...</a>> writes:
<br>> >
<br>> >> On Thu, 2008-02-28 at 10:18 +0530, Johnny Jacob wrote:
<br>> >>> On Wed, 2008-02-27 at 10:19 -0500, Jeffrey Stedfast wrote:
<br>> >>> > On Wed, 2008-02-27 at 15:05 +0100, Steffen Michalke wrote:
<br>> >>> > > Hi,
<br>> >>> > >
<br>> >>> > > I'm using gpg v.2.0.8/libgcrypt 1.4.0 and wanted to test keys with
<br>> >>> > > maximum strength. Therefor I created a pair of keys with gpg2
<br>> >>> > > --enable-dsa2.
<br>> >>> > >
<br>> >>> > > These keys are usable in Thunderbird, but can't be handled by Evolution
<br>> >>> > > (v2.21.92 btw.). The reason is that SHA-1 is hard wired as the hash
<br>> >>> > > method.
<br>> >>> > >
<br>> >>> > > From Thunderbird I learned that I had to use SHA-512 instead. I enclosed
<br>> >>> > > three patches against evolution-data-server and evolution (v2.21.92
<br>> >>> > > both) which hard code SHA-512 as hash algorhythm for gpg.
<br>> >>> > >
<br>> >>> > > I confess that I'm not a C programmer so I don't know whether I broke
<br>> >>> > > something but the patches work for signing and encryption.
<br>> >>> >
<br>> >>> > There's a bug about this in Bugzilla somewhere,
<br>> >>>
<br>> >>> Bugzilla entry for this issue :
<br>> >>> <a href="http://bugzilla.gnome.org/show_bug.cgi?id=304415" target="_top" rel="nofollow">http://bugzilla.gnome.org/show_bug.cgi?id=304415</a><br>> >>
<br>> >> Can you put your patches to bugzilla? So that it is tracked well :-)
<br>> >>
<br>> >>>
<br>> >>> > I think... basically,
<br>> >>> > the Right Fix(tm) is to provide a way for the user to choose what hash
<br>> >>> > algo Evolution should use.
<br>> >>
<br>> >> I agree to fejj's point. Can you look into this as well. You can contact
<br>> >> us on mail/chat for any help you need.
<br>> >>
<br>> >> -Srini
<br>> >
<br>> > Hi,
<br>> >
<br>> > I attached 2 patches against evolution and evolution-data-server
<br>> > v2.24.0.
<br>> >
<br>> > These patches (one line each) simply remove the default hash algorhythm,
<br>> > leaving the choice to gpg2 resp. the user settings in gpg.conf
<br>> > ("digest-algo"). To me, it seems to be fine to use the backends for such
<br>> > things. Signing e-mails now works with all the algorhythms which gpg2
<br>> > knows of, given the "digest-algo" option is set (but
<br>> > "personal-digest-preferences", as described in the manpage, does not
<br>> > work here :-( ).
<br>> >
<br>> > The default method is SHA1.
<br>> >
<br>> > Cheers
<br>> > Steffen
<br>>
<br>> I try it again ;-)
<br>>
<br>> _______________________________________________
<br>> Evolution-patches mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19724408&i=2" target="_top" rel="nofollow">Evolution-patches@...</a>
<br>> <a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a></div><br>_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19724408&i=3" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>tag:old.nabble.com,2006:post-19714952Re: Using gpg2 with SHA5122008-09-28T12:56:26Z2008-09-28T12:56:26ZBugzilla from stmichalke@germanynet.deSteffen Michalke <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19714952&i=0" target="_top" rel="nofollow">stmichalke@...</a>> writes:
<br><div class='shrinkable-quote'><div class='shrinkable-quote'><br>> Srinivasa Ragavan <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19714952&i=1" target="_top" rel="nofollow">sragavan@...</a>> writes:
<br>>
<br>>> On Thu, 2008-02-28 at 10:18 +0530, Johnny Jacob wrote:
<br>>>> On Wed, 2008-02-27 at 10:19 -0500, Jeffrey Stedfast wrote:
<br>>>> > On Wed, 2008-02-27 at 15:05 +0100, Steffen Michalke wrote:
<br>>>> > > Hi,
<br>>>> > >
<br>>>> > > I'm using gpg v.2.0.8/libgcrypt 1.4.0 and wanted to test keys with
<br>>>> > > maximum strength. Therefor I created a pair of keys with gpg2
<br>>>> > > --enable-dsa2.
<br>>>> > >
<br>>>> > > These keys are usable in Thunderbird, but can't be handled by Evolution
<br>>>> > > (v2.21.92 btw.). The reason is that SHA-1 is hard wired as the hash
<br>>>> > > method.
<br>>>> > >
<br>>>> > > From Thunderbird I learned that I had to use SHA-512 instead. I enclosed
<br>>>> > > three patches against evolution-data-server and evolution (v2.21.92
<br>>>> > > both) which hard code SHA-512 as hash algorhythm for gpg.
<br>>>> > >
<br>>>> > > I confess that I'm not a C programmer so I don't know whether I broke
<br>>>> > > something but the patches work for signing and encryption.
<br>>>> >
<br>>>> > There's a bug about this in Bugzilla somewhere,
<br>>>>
<br>>>> Bugzilla entry for this issue :
<br>>>> <a href="http://bugzilla.gnome.org/show_bug.cgi?id=304415" target="_top" rel="nofollow">http://bugzilla.gnome.org/show_bug.cgi?id=304415</a><br>>>
<br>>> Can you put your patches to bugzilla? So that it is tracked well :-)
<br>>>
<br>>>>
<br>>>> > I think... basically,
<br>>>> > the Right Fix(tm) is to provide a way for the user to choose what hash
<br>>>> > algo Evolution should use.
<br>>>
<br>>> I agree to fejj's point. Can you look into this as well. You can contact
<br>>> us on mail/chat for any help you need.
<br>>>
<br>>> -Srini
<br>>
<br>> Hi,
<br>>
<br>> I attached 2 patches against evolution and evolution-data-server
<br>> v2.24.0.
<br>>
<br>> These patches (one line each) simply remove the default hash algorhythm,
<br>> leaving the choice to gpg2 resp. the user settings in gpg.conf
<br>> ("digest-algo"). To me, it seems to be fine to use the backends for such
<br>> things. Signing e-mails now works with all the algorhythms which gpg2
<br>> knows of, given the "digest-algo" option is set (but
<br>> "personal-digest-preferences", as described in the manpage, does not
<br>> work here :-( ).
<br>>
<br>> The default method is SHA1.
<br>>
<br>> Cheers
<br>> Steffen
</div></div>I try it again ;-)
<br><br><br /><hr align="left" width="300" /><tt>--- a/camel/camel-gpg-context.c 2008-08-01 08:35:16.000000000 +0200
<br>+++ b/camel/camel-gpg-context.c 2008-09-28 18:02:58.000000000 +0200
<br>@@ -126,8 +126,7 @@
<br> case CAMEL_CIPHER_HASH_MD5:
<br> return "pgp-md5";
<br> case CAMEL_CIPHER_HASH_SHA1:
<br>- case CAMEL_CIPHER_HASH_DEFAULT:
<br> return "pgp-sha1";
<br> case CAMEL_CIPHER_HASH_RIPEMD160:
<br> return "pgp-ripemd160";
<br> case CAMEL_CIPHER_HASH_TIGER192:
<br></tt><hr align="left" width="300" /><br /><hr align="left" width="300" /><tt>--- evolution-2.24.0/composer/e-msg-composer.c 2008-09-22 21:46:38.000000000 +0200
<br>+++ evolution-2.24.0/composer/e-msg-composer.c 2008-09-22 21:49:56.000000000 +0200
<br>@@ -810,7 +810,7 @@
<br> CamelMimePart *npart = camel_mime_part_new ();
<br>
<br> cipher = mail_crypto_get_pgp_cipher_context (account);
<br>- camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_SHA1, part, npart, &ex);
<br>+ camel_cipher_sign (cipher, pgp_userid, CAMEL_CIPHER_HASH_DEFAULT, part, npart, &ex);
<br> camel_object_unref (cipher);
<br>
<br> if (camel_exception_is_set (&ex)) {
<br></tt><hr align="left" width="300" /><br />_______________________________________________
<br>Evolution-patches mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=19714952&i=2" target="_top" rel="nofollow">Evolution-patches@...</a>
<br><a href="http://mail.gnome.org/mailman/listinfo/evolution-patches" target="_top" rel="nofollow">http://mail.gnome.org/mailman/listinfo/evolution-patches</a><br>