Gossip patches

View: New views
6 Messages — Rating Filter:   Alert me  

Gossip patches

by Jordi Mallach-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hey Martyn,

I buggered you on jabber last night, I bugger you on mail now.

I have tried compiling this, but I:

- don't have anyone to make the birthday bit popup.
- don't know of a server with just one conference room.

So I guess I can't really test. :)

Jordi
--
Jordi Mallach Pérez  --  Debian developer     http://www.debian.org/
jordi@...     jordi@...     http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/


Index: src/gossip-new-chatroom-dialog.c
===================================================================
--- src/gossip-new-chatroom-dialog.c (revision 2591)
+++ src/gossip-new-chatroom-dialog.c (working copy)
@@ -818,7 +818,7 @@
       GTK_STOCK_FIND,
       GTK_ICON_SIZE_BUTTON);
 
- str = g_strdup_printf (_("Found %d conference rooms"), g_list_length (rooms));
+ str = g_strdup_printf (ngettext("Found %d conference room", "Found %d conference rooms", g_list_length (rooms)), g_list_length (rooms));
  gtk_label_set_text (GTK_LABEL (dialog->label_status), str);
  g_free (str);
 
Index: src/gossip-vcard-dialog.c
===================================================================
--- src/gossip-vcard-dialog.c (revision 2591)
+++ src/gossip-vcard-dialog.c (working copy)
@@ -476,14 +476,14 @@
  gtk_button_box_set_layout (GTK_BUTTON_BOX (bbox), GTK_BUTTONBOX_END);
  gtk_box_pack_start (GTK_BOX (vbox), bbox, FALSE, FALSE, 0);
 
- button = gtk_button_new_with_label (_("Cancel"));
+ button = gtk_button_new_with_label (GTK_STOCK_CANCEL);
  gtk_container_add (GTK_CONTAINER (bbox), button);
  g_signal_connect (button,
   "clicked",
   G_CALLBACK (vcard_dialog_birthday_cancel_clicked_cb),
   popup_button);
 
- button = gtk_button_new_with_label (_("OK"));
+ button = gtk_button_new_with_label (GTK_STOCK_OK);
  gtk_container_add (GTK_CONTAINER (bbox), button);
  g_signal_connect (button, "clicked",
   G_CALLBACK (vcard_dialog_birthday_ok_clicked_cb),
Index: ChangeLog
===================================================================
--- ChangeLog (revision 2591)
+++ ChangeLog (working copy)
@@ -1,3 +1,13 @@
+2007-08-30  Jordi Mallach  <jordi@...>
+
+ * src/src/gossip-new-chatroom-dialog.c:
+ (new_chatroom_dialog_browse_cb): Use ngettext() as needed.
+
+ * src/gossip-vcard-dialog.c:
+ (vcard_dialog_birthday_button_popup_cb): Use GTK stock strings.
+
+ * ui/main.glade: Fix typo, to unify nearly identical strings.
+
 2007-08-19  Martyn Russell  <martyn@...>
 
  * Release 0.27.
Index: ui/main.glade
===================================================================
--- ui/main.glade (revision 2591)
+++ ui/main.glade (working copy)
@@ -5143,7 +5143,7 @@
       <child>
  <widget class="GtkLabel" id="label_no_account_blurb">
   <property name="visible">True</property>
-  <property name="label" translatable="yes">To add a new account, you can click on the 'Add' button and a new entry will be created for you to started configuring.
+  <property name="label" translatable="yes">To add a new account, you can click on the 'Add' button and a new entry will be created for you to start configuring.
 
 If you do not want to add an account, simply click on the account you want to configure in the list on the left.</property>
   <property name="use_underline">False</property>


_______________________________________________
Gossip-dev mailing list
Gossip-dev@...
http://lists.imendio.com/mailman/listinfo/gossip-dev

Re: Gossip patches

by Bastien Nocera :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, 2007-08-31 at 00:05 +0200, Jordi Mallach wrote:
> Hey Martyn,
>
> I buggered you on jabber last night, I bugger you on mail now.

Huh, you might want to keep that private[1].

[1]: http://dictionary.cambridge.org/define.asp?key=10107&dict=CALD
--
Bastien Nocera <hadess@...>

_______________________________________________
Gossip-dev mailing list
Gossip-dev@...
http://lists.imendio.com/mailman/listinfo/gossip-dev

Re: Gossip patches

by Martyn Russell-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Bastien Nocera wrote:
> On Fri, 2007-08-31 at 00:05 +0200, Jordi Mallach wrote:
>> Hey Martyn,
>>
>> I buggered you on jabber last night, I bugger you on mail now.
>
> Huh, you might want to keep that private[1].
>
> [1]: http://dictionary.cambridge.org/define.asp?key=10107&dict=CALD

Haha, Bastien is right :)

Still, thanks all the same Jordi.
I will commit the patch ASAP.

--
Regards,
Martyn
_______________________________________________
Gossip-dev mailing list
Gossip-dev@...
http://lists.imendio.com/mailman/listinfo/gossip-dev

Re: Gossip patches

by Ross Burton :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, 2007-08-31 at 00:05 +0200, Jordi Mallach wrote:
> I buggered you on jabber last night, I bugger you on mail now.

Man that totally made my bad.  For future reference you meant
"bugged". :)

Ross
--
Ross Burton                                 mail: ross@...
                                          jabber: ross@...
                                     www: http://www.burtonini.com./
 PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF



_______________________________________________
Gossip-dev mailing list
Gossip-dev@...
http://lists.imendio.com/mailman/listinfo/gossip-dev

signature.asc (196 bytes) Download Attachment

Re: Gossip patches

by Jordi Mallach-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Aug 31, 2007 at 12:36:08AM +0100, Bastien Nocera wrote:
> [1]: http://dictionary.cambridge.org/define.asp?key=10107&dict=CALD

LOL

--
Jordi Mallach Pérez  --  Debian developer     http://www.debian.org/
jordi@...     jordi@...     http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/
_______________________________________________
Gossip-dev mailing list
Gossip-dev@...
http://lists.imendio.com/mailman/listinfo/gossip-dev

Re: Gossip patches

by Martyn Russell-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Jordi Mallach wrote:

> Hey Martyn,
>
> I buggered you on jabber last night, I bugger you on mail now.
>
> I have tried compiling this, but I:
>
> - don't have anyone to make the birthday bit popup.
> - don't know of a server with just one conference room.
>
> So I guess I can't really test. :)

Thanks for the patch, I have committed it now ;)

--
Regards,
Martyn
_______________________________________________
Gossip-dev mailing list
Gossip-dev@...
http://lists.imendio.com/mailman/listinfo/gossip-dev