Grails build and source distribution

View: New views
4 Messages — Rating Filter:   Alert me  

Grails build and source distribution

by hdockter :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I'm working on the Gradle build for Grails. I have a question regarding the release distributions. It looks as if the source distribution is no longer build by the HEAD Ant build. Has the source distribution become obsolete or is this just a temporary thing? If it is obsolete, one could merge a couple of things.

- Hans

--
Hans Dockter
Gradle Project Manager
http://www.gradle.org

 

Re: Grails build and source distribution

by Graeme Rocher-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

We build only one build now and package the source with the binaries.

Its easier to maintain.

Regards

On Fri, Nov 6, 2009 at 10:35 AM, hdockter <mail@...> wrote:

>
> I'm working on the Gradle build for Grails. I have a question regarding the
> release distributions. It looks as if the source distribution is no longer
> build by the HEAD Ant build. Has the source distribution become obsolete or
> is this just a temporary thing? If it is obsolete, one could merge a couple
> of things.
>
> - Hans
>
> --
> Hans Dockter
> Gradle Project Manager
> http://www.gradle.org
>
>
> --
> View this message in context: http://old.nabble.com/Grails-build-and-source-distribution-tp26228800p26228800.html
> Sent from the grails - dev mailing list archive at Nabble.com.
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>



--
Graeme Rocher
Head of Grails Development
SpringSource - A Division of VMware
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email



Re: Grails build and source distribution

by hdockter :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

The migration is progressing nicely. The Gradle build uses exactly the same layout as the ant build. I have written some tests which can be executed as part of the Gradle build. They compare the content of the jars and zips produced by the ant build with the Gradle build. If those are equals that should give us confidence that the major parts of the build are working. After the migration we might think about some refactorings regrading the layout. On the other hand I don't feel any significant pain with the current layout. The only thing I really would change at one point is having transitive dependency management, possibly from a repository.

Missing functionality in the current Gradle build:
- testing (including os-x stuff). Will hopefully be implemented this week.
- Maven pom

Some open issues:
- The following files are _empty_ files (not empty classes)
src/test/org/codehaus/groovy/grails/orm/hibernate/cfg/GrailsDomainConfigurationUtilTest.java
src/test/org/codehaus/groovy/grails/validation/routines/DomainValidatorTest.java
src/test/org/codehaus/groovy/grails/validation/routines/InetAddressValidatorTest.java
src/test/org/codehaus/groovy/grails/validation/routines/RegexValidatorTest.java
src/test/org/codehaus/groovy/grails/validation/routines/UrlValidatorTest.java
Is this the way it should be?

- In the ant eclipse.xml there is the following section:
if (project.properties["plugin.disabled"])
{
  project.log("Eclipse plugin disabled. Adding Groovy compile targets to classpath", Project.MSG_WARN)

  //plugin is disabled, which means you need to build
  //groovy using the ant scripts.
  //This adds the ant scripts to the classpath
  classpathentry(kind:"lib", path: "target/classes/core")
  classpathentry(kind:"lib", path: "target/classes/crud")
  classpathentry(kind:"lib", path: "target/classes/gorm")
  classpathentry(kind:"lib", path: "target/classes/web")
  classpathentry(kind:"lib", path: "target/classes/config")
}
Is this still relevant? I don't understand what exactly is going on here.

- Hans

--
Hans Dockter
Gradle Project Manager
http://www.gradle.org


Graeme Rocher-3 wrote:
We build only one build now and package the source with the binaries.

Its easier to maintain.

Regards

On Fri, Nov 6, 2009 at 10:35 AM, hdockter <mail@dockter.biz> wrote:
>
> I'm working on the Gradle build for Grails. I have a question regarding the
> release distributions. It looks as if the source distribution is no longer
> build by the HEAD Ant build. Has the source distribution become obsolete or
> is this just a temporary thing? If it is obsolete, one could merge a couple
> of things.
>
> - Hans
>
> --
> Hans Dockter
> Gradle Project Manager
> http://www.gradle.org
>
>
> --
> View this message in context: http://old.nabble.com/Grails-build-and-source-distribution-tp26228800p26228800.html
> Sent from the grails - dev mailing list archive at Nabble.com.
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>



--
Graeme Rocher
Head of Grails Development
SpringSource - A Division of VMware
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Re: Grails build and source distribution

by Graeme Rocher-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Mon, Nov 16, 2009 at 8:06 PM, hdockter <mail@...> wrote:

>
> The migration is progressing nicely. The Gradle build uses exactly the same
> layout as the ant build. I have written some tests which can be executed as
> part of the Gradle build. They compare the content of the jars and zips
> produced by the ant build with the Gradle build. If those are equals that
> should give us confidence that the major parts of the build are working.
> After the migration we might think about some refactorings regrading the
> layout. On the other hand I don't feel any significant pain with the current
> layout. The only thing I really would change at one point is having
> transitive dependency management, possibly from a repository.
>
> Missing functionality in the current Gradle build:
> - testing (including os-x stuff). Will hopefully be implemented this week.
> - Maven pom
>
> Some open issues:
> - The following files are _empty_ files (not empty classes)
> src/test/org/codehaus/groovy/grails/orm/hibernate/cfg/GrailsDomainConfigurationUtilTest.java
> src/test/org/codehaus/groovy/grails/validation/routines/DomainValidatorTest.java
> src/test/org/codehaus/groovy/grails/validation/routines/InetAddressValidatorTest.java
> src/test/org/codehaus/groovy/grails/validation/routines/RegexValidatorTest.java
> src/test/org/codehaus/groovy/grails/validation/routines/UrlValidatorTest.java
> Is this the way it should be?

Hmm I'm not sure why these are there. Looks like they need to be deleted.

>
> - In the ant eclipse.xml there is the following section:
> if (project.properties["plugin.disabled"])
> {
>        project.log("Eclipse plugin disabled. Adding Groovy compile targets to
> classpath", Project.MSG_WARN)
>
>        //plugin is disabled, which means you need to build
>        //groovy using the ant scripts.
>        //This adds the ant scripts to the classpath
>        classpathentry(kind:"lib", path: "target/classes/core")
>        classpathentry(kind:"lib", path: "target/classes/crud")
>        classpathentry(kind:"lib", path: "target/classes/gorm")
>        classpathentry(kind:"lib", path: "target/classes/web")
>        classpathentry(kind:"lib", path: "target/classes/config")
> }
> Is this still relevant? I don't understand what exactly is going on here.

This looks like legacy stuff and can be ignored

Cheers

>
> - Hans
>
> --
> Hans Dockter
> Gradle Project Manager
> http://www.gradle.org
>
>
>
> Graeme Rocher-3 wrote:
>>
>> We build only one build now and package the source with the binaries.
>>
>> Its easier to maintain.
>>
>> Regards
>>
>> On Fri, Nov 6, 2009 at 10:35 AM, hdockter <mail@...> wrote:
>>>
>>> I'm working on the Gradle build for Grails. I have a question regarding
>>> the
>>> release distributions. It looks as if the source distribution is no
>>> longer
>>> build by the HEAD Ant build. Has the source distribution become obsolete
>>> or
>>> is this just a temporary thing? If it is obsolete, one could merge a
>>> couple
>>> of things.
>>>
>>> - Hans
>>>
>>> --
>>> Hans Dockter
>>> Gradle Project Manager
>>> http://www.gradle.org
>>>
>>>
>>> --
>>> View this message in context:
>>> http://old.nabble.com/Grails-build-and-source-distribution-tp26228800p26228800.html
>>> Sent from the grails - dev mailing list archive at Nabble.com.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe from this list, please visit:
>>>
>>>    http://xircles.codehaus.org/manage_email
>>>
>>>
>>>
>>
>>
>>
>> --
>> Graeme Rocher
>> Head of Grails Development
>> SpringSource - A Division of VMware
>> http://www.springsource.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe from this list, please visit:
>>
>>     http://xircles.codehaus.org/manage_email
>>
>>
>>
>>
>
> --
> View this message in context: http://old.nabble.com/Grails-build-and-source-distribution-tp26228800p26377605.html
> Sent from the grails - dev mailing list archive at Nabble.com.
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>



--
Graeme Rocher
Head of Grails Development
SpringSource - A Division of VMware
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email