Nabble - GtkPod

Re: clang and nested functions

2009-12-15T00:47:08Z

Hi,

2009/12/15 Javier Kohen <jkohen@...>

This is clear. Since you asked whether nested functions were preferred, my question was if GCC produced different code with your patch applied. That was more out of curiosity, because even if it does, it might be a good idea to apply your changes for the sake of compatibility.

Fwiw, libgpod used to have a few nested functions too, they were removed because visual c++ (I think) doesn't support that.

Christophe

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev

_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev

_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: clang and nested functions

2009-12-14T23:58:32Z

On Tue, Dec 15, 2009 at 04:38, Maia Kozheva <sikon@...> wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

15.12.2009 03:22, Javier Kohen ?????:

> I don't have any argument against your patch, but maybe you could provide
> some more information. Does GCC even generate different binaries with your
> patch applied? I would be surprised.
>

GCC shouldn't generate different binaries. The issue that this patch
fixes is a build failure with a different compiler - clang.

This is clear. Since you asked whether nested functions were preferred, my question was if GCC produced different code with your patch applied. That was more out of curiosity, because even if it does, it might be a good idea to apply your changes for the sake of compatibility.

Re: clang and nested functions

2009-12-14T19:38:30Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

15.12.2009 03:22, Javier Kohen ?????:

> I don't have any argument against your patch, but maybe you could provide
> some more information. Does GCC even generate different binaries with your
> patch applied? I would be surprised.
>

GCC shouldn't generate different binaries. The issue that this patch
fixes is a build failure with a different compiler - clang. And it is
caused by the fact that it, unlike GCC, doesn't support nested functions
(and they are not in the ANSI standard anyway).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJLJwSyAAoJEDqDNnQ69yYSd/4H/0y/zCmrPVqBrgtwKVIplI53
10E5gKsklHUFCGb+88enIywEZn2JWDuyEOR36cX8fDfK0aTYTFZ7t1sqLujbyeop
05VJ5A2amnN8G6LoDoERGd5hA6S0WQkdD2KOQ4nHPmXx7KIHrzirw03ovfR6oy9R
zaz99XBjRk2paV/sHOxto66MI5rfFGQcyoqrcLeL2ntMt9nE/ExYK4nFnUANMVUt
NQEZ8a6OygBfpw4QNoXLOSplk8y6cEwGnPadzylKg2qPTd/BYWAsDQ++56WgDJKQ
7AhxTs5BYZwLWlkudFEW+32jTuy/BHKPGXfM0URo1OFq/29s4b73ZLD5D/Opif0=
=QdMS
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: clang and nested functions

2009-12-14T13:22:19Z

On Fri, Dec 4, 2009 at 12:03, Maia Kozheva <sikon@...> wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I have tried building gtkpod with clang instead of gcc. It built and
ran, but only after I de-nested nested functions (and made them static).
Nested functions are a feature of gcc not found in ANSI C.

Should I apply this patch to git, or is it better to have nested
functions than to support another compiler?

I don't have any argument against your patch, but maybe you could provide some more information. Does GCC even generate different binaries with your patch applied? I would be surprised.

Re: Merge of iphone30 branch

2009-12-11T01:17:56Z

Hi,

2009/12/10 Nicolas Will <nico@...>:
>
> Excellent news !
>
> Does it take care of all the signing and all the obfuscated stuff?

Provided the device initially has a valid database (ie one that was
written and checksummed by iTunes), yep. I need to document all of
that in some file.
http://marcansoft.com/blog/2009/10/iphone-syncing-on-linux/ has lots
of details about it too.

>
> I am ready to beg, or even make a donation to , anyone who can make a
> complete ppa with the complete libgpod, gtkpod, amarok, libiphone,
> usbmuxd stack stuff..

I don't think amarok will work out of the box with iphones (solid is
missing some bits to detect/mount the iphone when it's plugged in).
Fwiw, I could really help donations to buy ipods for testing, all
these changes made me realize it was much easier to hack on stuff when
I have an iPod touch or a nano5g at my place to make tests on ;)

Christophe

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: Merge of iphone30 branch

2009-12-10T14:11:15Z

On Thu, 2009-12-10 at 21:51 +0100, Christophe Fergeau wrote:

> Just a note to announce that I finally merged all the work that had
> been happening to my iphone30 git branch to git master. Hope this
> won't cause an email flood on the commits mailing list.. So far, it
> has been working for people who managed to compile and install it, but
> it will be much easier to use and try when it's available in distros.
> Some polishing needs to be done before that though. In particular, I
> suspect it won't work nicely with iphoneos 1.x and 2.x, I need to
> rework that.
>
> Lots of thanks to everyone that made that possible, especially to
> marcan, nikias and psp250 who made the hard work in that branch, and
> thanks to all the testers. Next on the list, the nano5g ;)

Excellent news !

Does it take care of all the signing and all the obfuscated stuff?

I am ready to beg, or even make a donation to , anyone who can make a
complete ppa with the complete libgpod, gtkpod, amarok, libiphone,
usbmuxd stack stuff...

Nico
iPhone 3G owner
would love to press the delete button for the windows virtual machine

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: Merge of iphone30 branch

2009-12-10T13:46:55Z

2009/12/10 Christophe Fergeau <teuf@...>:

> 2009/12/10 Bastien Nocera <hadess@...>:
>
>>
>> What do you need tested? My iPod Touch 2G is still on 2.x.
>
> Actually, I should have said "it's known to be broken" ;) since in
> places we assume iphones/itouches necessarily have a 3.x os and
> unconditionnally write sqlite files and a compressed iTunesDB. I
> should look into fixing itdb_device_supports_sqlite_db so that you
> have something to test...

On second thought, if you have a SysInfoExtended file on the ipod, the
current code should just work since it checks the content of this file
first (the SqliteDB key). But I'm not sure it has been tested
recently. Just trying to add a song to the itouch and checking it can
see it would be enough of a test.

Christophe

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: Merge of iphone30 branch

2009-12-10T13:42:36Z

2009/12/10 Bastien Nocera <hadess@...>:

>
> What do you need tested? My iPod Touch 2G is still on 2.x.

Actually, I should have said "it's known to be broken" ;) since in
places we assume iphones/itouches necessarily have a 3.x os and
unconditionnally write sqlite files and a compressed iTunesDB. I
should look into fixing itdb_device_supports_sqlite_db so that you
have something to test...

Christophe

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: Merge of iphone30 branch

2009-12-10T13:24:21Z

On Thu, 2009-12-10 at 21:51 +0100, Christophe Fergeau wrote:

> Hi,
>
> Just a note to announce that I finally merged all the work that had
> been happening to my iphone30 git branch to git master. Hope this
> won't cause an email flood on the commits mailing list.. So far, it
> has been working for people who managed to compile and install it, but
> it will be much easier to use and try when it's available in distros.
> Some polishing needs to be done before that though. In particular, I
> suspect it won't work nicely with iphoneos 1.x and 2.x, I need to
> rework that.

What do you need tested? My iPod Touch 2G is still on 2.x.

> Lots of thanks to everyone that made that possible, especially to
> marcan, nikias and psp250 who made the hard work in that branch, and
> thanks to all the testers. Next on the list, the nano5g ;)

Cheers

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Merge of iphone30 branch

2009-12-10T12:51:09Z

Hi,

Just a note to announce that I finally merged all the work that had
been happening to my iphone30 git branch to git master. Hope this
won't cause an email flood on the commits mailing list.. So far, it
has been working for people who managed to compile and install it, but
it will be much easier to use and try when it's available in distros.
Some polishing needs to be done before that though. In particular, I
suspect it won't work nicely with iphoneos 1.x and 2.x, I need to
rework that.

Lots of thanks to everyone that made that possible, especially to
marcan, nikias and psp250 who made the hard work in that branch, and
thanks to all the testers. Next on the list, the nano5g ;)

Cheers,

Christophe

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: UTF-16 handling fixes

2009-12-10T12:46:04Z

Hi Bastien,

2009/12/10 Bastien Nocera <hadess@...>:
> The first one is a rework of a UTF-16 handling fix Christophe did, and a
> fix for the crasher at:

Thanks for the patch, I committed it to git. I reworked it so that it
applies on top of my iphone30 branch, and made sure "error" is not
leaked in utf16_to_utf8_with_partial (could occur on errors not caused
by truncated input).

Christophe

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

UTF-16 handling fixes

2009-12-10T06:59:19Z

The first one is a rework of a UTF-16 handling fix Christophe did, and a
fix for the crasher at:
https://bugzilla.redhat.com/show_bug.cgi?id=542176

Cheers

[0001-Handle-partial-UTF-16-strings-in-mhod.patch]

>From 8d85b27b46e9e77ece0f16338b121932268baa69 Mon Sep 17 00:00:00 2001 From: Bastien Nocera <hadess@...> Date: Thu, 10 Dec 2009 14:56:46 +0000 Subject: [PATCH 1/2] Handle partial UTF-16 strings in mhod And make sure the UTF-8 strings created are valid. --- src/itdb_itunesdb.c | 25 +++++++++++++++++++++++-- 1 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/itdb_itunesdb.c b/src/itdb_itunesdb.c index ed66e98..a41abb4 100644 --- a/src/itdb_itunesdb.c +++ b/src/itdb_itunesdb.c @@ -809,7 +809,22 @@ static inline guint64 get64bint (FContents *cts, glong seek) return cts->be_reader.get64int (cts, seek); } +/* Try to convert from UTF-16 to UTF-8 and handle partial characters + * at the end of the string */ +static char *utf16_to_utf8_with_partial (gunichar2 *entry_utf16) +{ + GError *error = NULL; + char *entry_utf8; + glong items_read; + + entry_utf8 = g_utf16_to_utf8 (entry_utf16, -1, &items_read, NULL, &error); + if (entry_utf8 == NULL && g_error_matches (error, G_CONVERT_ERROR, G_CONVERT_ERROR_PARTIAL_INPUT)) { + g_error_free (error); + entry_utf8 = g_utf16_to_utf8 (entry_utf16, items_read, NULL, NULL, NULL); + } + return entry_utf8; +} /* Fix little endian UTF16 String to correct byteorder if necessary @@ -1393,9 +1408,15 @@ static MHODData get_mhod (FImport *fimp, glong mhod_seek, guint32 *ml) if (seek_get_n_bytes (cts, (gchar *)entry_utf16, seek+16, xl)) { fixup_little_utf16 (entry_utf16); - result.data.string = g_utf16_to_utf8 (entry_utf16, -1, - NULL, NULL, NULL); + result.data.string = utf16_to_utf8_with_partial (entry_utf16); g_free (entry_utf16); + + if (result.data.string == NULL || g_utf8_validate (result.data.string, -1, NULL) == FALSE) { + /* error */ + g_free (result.data.string); + result.data.string = NULL; + return result; + } } else { /* error */ -- 1.6.5.2

Re: gtkpod helper scripts and spaces in mount point

2009-12-08T00:51:22Z

On Tue, Nov 24, 2009 at 8:49 PM, Götz Waschk <goetz.waschk@...> wrote:

> On Tue, Nov 24, 2009 at 4:36 PM, Todd Zullinger <tmz@...> wrote:
>> Götz Waschk wrote:
>>> On Sat, Oct 31, 2009 at 9:31 PM, Todd Zullinger <tmz@...>
>>> wrote:
>>>> Thanks for the patch. Looking at the scripts, many (if not most)
>>>> of them have quoting problems. We should probably clean them all
>>>> up and wrap it in a single commit. Anyone up for taking that on?
>>>> I think this is a start, but it would need testing and checking:
>>> thanks for the patch. When will you commit it?
>> I haven't had any time to further test that patch. I don't make any
>> use of the various scripts, so I hesitate to commit them without some
>> confirmation that they don't break more than they fix.
> I have only tested sync-evolution, sync-evocalendar and sync-tomboy,
> they work fine now.

Hi,

I have now added the patch to the Mandriva gtkpod rpm package.

Regards, Götz

--
AL I:40: Do what thou wilt shall be the whole of the Law.

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

clang and nested functions

2009-12-04T03:03:18Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I have tried building gtkpod with clang instead of gcc. It built and
ran, but only after I de-nested nested functions (and made them static).
Nested functions are a feature of gcc not found in ANSI C.

Should I apply this patch to git, or is it better to have nested
functions than to support another compiler?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJLGOx2AAoJEDqDNnQ69yYSsnsH/2Bqk8E8LttMqxUl1UTJ1o3u
viZxpqrXpur9K9aoGFR6q6PqnNiNHO2Z4t09Ta/2H5PKEy0YYSGfjLdxvjfl8/KZ
6ZbGy0UF9QKG2KkNJ4aKJOmZn6RzCFJXea8VUpibli4ZxIqZ8IxDFczLZAcQZo9g
yq9eMApyeme+3lpLGva88pDJ1LN9G6HKRaZc4ZDydeXyYEn76e8FAdG8mPnUDczX
7GIvqNwbhfychwo+wOSebZqFcnPalivbVkvNTSMUp3fFSviBXYx9C3uGUzryH8Pt
FG8jaFCWbc9ZiJ0o7ajJ5gTclYeNqiKf7dJlZh7S6WqS7Ey+ZqBbbudRc1ofM+c=
=nQ03
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Making libgpod run on the device, continued...

2009-11-30T20:54:36Z

Hi Christophe and others reading,

anyway, as I said I didn't want to depend that much on the SysInfo
and SysInfoExtended, so after too much wondering where to start
modifying the libgpod source, I copied and pasted from parse_itdb to a
new function:

parse_itdb_builtin(const gchar *mp, const gchar *firewire_guid,
GError **error)

I added 2 lines after itdb_set_mountpoint (itdb, mp);
itdb_device_set_sysinfo (itdb->device, "ModelNumStr", "MA712");
/* this library is being designed to run on the iPhone, so we just
tell it that device is an iPhone. (although, will this cause problems
with capacity calculations?) */
itdb_device_set_sysinfo (itdb->device, "FirewireGuid",
firewire_guid);

So later itdb_hash72_extract_hash_info() calls
->itdb_device_get_checksum_type(), which calls
--> itdb_sysinfo_properties_get_db_version(), which will I believe
fail because of the non-existing SysInfoExtended.
--> and as an alternative it calls itdb_device_get_ipod_info()
---> itdb_sysinfo_properties_get_serial_number(), which will also fail.
---> but then it calls itdb_device_get_sysinfo (device,
"ModelNumStr"), which works because I set it earlier :P

So itdb_device_get_ipod_info() returns an appropriate info line,
itdb_sysinfo_properties_get_db_version() returns 4,
itdb_device_get_checksum_type() returns ITDB_CHECKSUM_HASH72 and a
HashInfo is generated.

At the first run it did fail because I didn't have a "Device"
directory to store the HashInfo in.

As for passing the FirewireGUID to the function, The main app passes
it the first 16 bytes of [UIDevice currentDevice].uniqueIdentifier,
making the proper imports from the iPhone SDK makes it compile
properly, which amazed me (that mixing C and Obj-C works).

Well, do tell me if that was really ugly. :)

Anyway, it still works (managed to insert a song into the DB so it
appears on the player).

I do have a question, how far to 0.7.3? :) I see you still have to
detect the proper iPhone OS version to see which database version it
would want. I guess from outside the phone that depends on libiphone.
Inside it there's UIDevice which is nice :)

Yours,

-Louis

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: libgpod mk_Locations_cbk

2009-11-30T02:02:29Z

2009/11/30 Louis Adiputra <netsharc@...>:
> In conclusion... I guess I really should modify the library so that
> it doesn't depend on the SysInfoExtended file which doesn't seem to
> originally exist on iPhones, to make installation on a user device
> easier. Because it'll be running on the device itself, it has access
> to some internal functions that gets the serial number, like [UIDevice
> uniqueIdentifier] and probably an OS version number, using this class:
> http://developer.apple.com/iphone/library/documentation/UIKit/Reference/UIDevice_Class/Reference/UIDevice.html
>
> Well, that certainly wasn't worth your time reading it was it.

Nope, your use case was interesting :) Though with 3.x firmwares,
Apple provides an API to access the phone music database so maybe you
don't need to fight with libgpod? SysInfoExtended on the iphone can be
found in /System/Library/Lockdown/Checkpoint.xml (on jailbroken
devices), dunno if in your usecase you can get access to it.
fwiw, I'd like itdb_parse_file to die but it's still in use by gtkpod.
And the Itdb_Device struct will probably need some rework at some
point.

Thanks for the thorough explanations of what you are trying to achieve :)

Christophe

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: libgpod mk_Locations_cbk

2009-11-29T20:15:18Z

Hi Christophe,

thanks for the quick response. Actually I wrote the top part right
after I wrote the bottom one, never sending the bottom one, that's why
you never saw the 1st email.

Well, the conclusion is, I managed to insert a song into the device
Database. The iPod app crashed the 1st time around, with syslog
saying:

Nov 30 04:25:03 iphone MobileMusicPlayer[494]: *** Terminating app due
to uncaught exception 'ML3QuerySQLError', reason: 'SELECT
COUNT(item_artist.ROWID), item_artist.sort_name_section FROM
item_artist WHERE ((item_artist.has_song = ?) AND
(item_artist.name_blank = ?)) GROUP BY item_artist.sort_name_section
ORDER BY item_artist.sort_name_section: no such table: item_artist'

And on the 2nd launch it said "Updating Database" (or something
similar) during which the Library.itdb grew, in the end it launched,
and the song I've been trying to insert was listed. Success!

But if you care, here's how I got there (actually this is mostly for
me documenting my stupid hack for next time):

I had started with tests/itdb_main.c and that one uses a
itdb_parse_file(), which doesn't set the mountpoint, so it doesn't
read the sysinfo, etc, etc.. I realized after your email that
itdb_parse() asks for a mountpoint, and it calls itdb_set_mountpoint,
which in turn calls the itdb_device_read_sysinfo.

Unfortunately trying to compile on Linux with libiphone (from Ubuntu
9.10, probably not the latest and greatest) failed, besides if I want
to make everything run on the device itself I can't depend on a
library that talks to the USB device... so I looked for an example
SysInfoExtended and made my own (containing only FireWireGUID and
DBVersion in the beginning).

It still did not want to work the first time I tried it... as we recall:

itdb_parse
-> itdb_parse_internal
--> itdb_hash72_extract_hash_info
---> itdb_device_get_checksum_type
----> itdb_sysinfo_properties_get_db_version

Strangely it still fails for me here. Anyway, I guess the
sysinfo/sysinfo_extended never got initialized correctly. Better look
into it tomorrow. Maybe it needs ModelNumStr?

After a bit of delving into ARM assembly and gdb, I changed one
register so itdb_device_get_checksum_type() returns
ITDB_CHECKSUM_HASH72, it generated the HashInfo file, and the checksum
was calculated correctly!

So far I've been refusing to modify libgpod itself, which is a bit
foolish, because it would have been easier than what I just did
tonight. But the compilation to make a library that works on the
iPhone needs a bit of manual work.

In conclusion... I guess I really should modify the library so that
it doesn't depend on the SysInfoExtended file which doesn't seem to
originally exist on iPhones, to make installation on a user device
easier. Because it'll be running on the device itself, it has access
to some internal functions that gets the serial number, like [UIDevice
uniqueIdentifier] and probably an OS version number, using this class:
http://developer.apple.com/iphone/library/documentation/UIKit/Reference/UIDevice_Class/Reference/UIDevice.html

Well, that certainly wasn't worth your time reading it was it.

-Louis

On Sun, Nov 29, 2009 at 9:56 PM, Christophe Fergeau <teuf@...> wrote:

> Hey,
>
> Didn't get the message you quote in that one, not sure why. Basically,
> the HashInfo file is indeed generated when the database is parsed
> (itdb_parse) if needed. And to know the checksum type, we need to know
> the iPod model somehow, this is either done thanks to a ModelNumStr
> entry in Device/SysInfo (deprecated) or by parsing a SysInfoExtended
> file in Device/ (itdb_device_read_sysinfo calls
> itdb_device_read_sysinfo_extended). I think this is the part you
> missed during your investigation. The Itdb_Device::sysinfo hash is
> deprecated at this point.
>
> In short, I think all you are missing is a SysInfoExtended file on
> your iTouch. You can get it using tools/ipod-read-sysinfo-extended.
>
> Hope that helps,
>
> Christophe
>

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: libgpod mk_Locations_cbk

2009-11-29T12:56:41Z

Hey,

Didn't get the message you quote in that one, not sure why. Basically,
the HashInfo file is indeed generated when the database is parsed
(itdb_parse) if needed. And to know the checksum type, we need to know
the iPod model somehow, this is either done thanks to a ModelNumStr
entry in Device/SysInfo (deprecated) or by parsing a SysInfoExtended
file in Device/ (itdb_device_read_sysinfo calls
itdb_device_read_sysinfo_extended). I think this is the part you
missed during your investigation. The Itdb_Device::sysinfo hash is
deprecated at this point.

In short, I think all you are missing is a SysInfoExtended file on
your iTouch. You can get it using tools/ipod-read-sysinfo-extended.

Hope that helps,

Christophe

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

libgpod mk_Locations_cbk

2009-11-29T12:33:42Z

Hi all,

actually after reading this, my conclusion is, if I'm going to use
svn-code, I better fix it myself... but for Christophe who's
git-commit I downloaded it might be of interest...

and hello to everyone, this is my second post, first message follows :)

Actually I have another question, is FireWireGuid the first 16 bytes
of the iPhone's UDID?

Yours,

Louis

----

Hi all,

I'm a newbie to the list, I've been trying to get libgpod to run on
the jailbroken iPhone device itself, well actually I've succeeded in
doing that minus the gdk-pixbuf, first with the 0.7.2 build that
apparently doesn't have support for the sqlite3 format (yeah, what a
waste of time that was...), and then downloading a git-commit from
http://gitorious.org/~teuf/libgpod/teuf-sandbox/commits/iphone30 ...

Anyway, I've got so far as building the sqlite files, but apparently
it fails when trying to build Locations.itdb.cbk ...

The function calls are:

mk_Locations_cbk
-> itdb_hash72_compute_hash_for_sha1
--> read_hash_info

The function read_hash_info then tries to read the file
(mountpoint)/iTunes_Control/Device/HashInfo ... a file is supposed to
be generated by:

write_hash_info()
which is only called by: itdb_hash72_extract_hash_info()
which is only ever called by: itdb_parse_internal()
which is called by either itdb_parse or itdb_parse_file()

Or in reverse:
itdb_parse
-> itdb_parse_internal
--> itdb_hash72_extract_hash_info
---> write_hash_info

Now itdb_hash72_extract_hash_info has this line:

if (itdb_device_get_checksum_type (device) != ITDB_CHECKSUM_HASH72)
{ return FALSE }

which stops the function from continuing if it thinks the required
device checksum algorithm is other than hash72.

But to determine the checksum type, itdb_device_get_checksum_type
needs either sysinfo_extended or a valid ipod_info from itdb->device.

itdb_parse creates a new Itdb_iTunesDB (via itdb_new()), which in
turns calls itdb_device_new(), which calls itdb_device_reset_sysinfo,
which seems to do nothing more than initiate a new hash table.

itdb_parse
-> itdb_new --------- generates new Itdb_iTunesDB itdb
--> itdb_device_new ---- sets itdb->device
---> itdb_device_reset_sysinfo ---- sets
itdb->device->extended_sysinfo to an empty hash table
-> itdb_parse_internal
--> itdb_hash72_extract_hash_info --- always end at return FALSE above
---> write_hash_info --- never gets called.

So the HashInfo file never gets created, and mk_Locations_cbk will
always fail. Or am I not seeing something?

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: libgpod windows binary?!

2009-11-25T00:48:15Z

2009/11/25 Jared Albers <discountstringing@...>:
> Does anyone know where I might find a recent version of a libgpod binary
> compiled as a dll for windows?

The songbird guys use (slightly old sllightly modified) libgpod, maybe
their compiled DLL is usable for you?

Christophe

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: Open patches

2009-11-25T00:20:24Z

On 24/11/09 15:14, Todd Zullinger wrote:
> Andrea wrote:
>> Just a reminder, there are still 2 outstanding patches which should
>> be very easy to merge
>>
>> http://article.gmane.org/gmane.comp.ipod.gtkpod/4351
>
> It seems that this was applied along with the volume patch:

Sorry I did miss it.

>
> http://gtkpod.git.sourceforge.net/git/gitweb.cgi?p=gtkpod/gtkpod;a=commitdiff;h=b4d0195
>
>> http://article.gmane.org/gmane.comp.ipod.gtkpod/4344
>
> I just pushed this, thanks!

Thanks.

Since I've got some spare time I'd like to investigate this other issue

http://article.gmane.org/gmane.comp.ipod.gtkpod/4352

It happens often when I copy big videos to the iPod.
Could you please tell me what is the work flow when I add a new file to the iPod: e.g., when it is
copied, in background, one file at a time...

Reading the code it is trying to set values (lyrics) TO a track that does not yet (?) exist on the
iPod. Maybe because it is still waiting other tracks to be copied first?

Thanks

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

libgpod windows binary?!

2009-11-24T16:21:13Z

Does anyone know where I might find a recent version of a libgpod binary
compiled as a dll for windows?

Or perhaps does someone know of a tutorial on how to compile libgpod for
windows?

I'm unfamiliar with all of the dependencies. I hear reports that using
Visual Studio is problematic but that cygwin works.

Thanks

-Jared

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: gtkpod helper scripts and spaces in mount point

2009-11-24T11:49:21Z

On Tue, Nov 24, 2009 at 4:36 PM, Todd Zullinger <tmz@...> wrote:

> Götz Waschk wrote:
>> On Sat, Oct 31, 2009 at 9:31 PM, Todd Zullinger <tmz@...>
>> wrote:
>>> Thanks for the patch. Looking at the scripts, many (if not most)
>>> of them have quoting problems. We should probably clean them all
>>> up and wrap it in a single commit. Anyone up for taking that on?
>>> I think this is a start, but it would need testing and checking:
>> thanks for the patch. When will you commit it?
> I haven't had any time to further test that patch. I don't make any
> use of the various scripts, so I hesitate to commit them without some
> confirmation that they don't break more than they fix.

I have only tested sync-evolution, sync-evocalendar and sync-tomboy,
they work fine now.

Regards, Götz
--
AL I:40: Do what thou wilt shall be the whole of the Law.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: Export iTunesDB to file system

2009-11-24T10:52:15Z

Andrea wrote:
> I would like to make all my music in the iPod available using a
> plain fs interface where I create a directory structure with 3
> levels.
>
> Artist -> Album -> Tracks
>
> I could write something using libgpod, but I wonder if anybody has
> ever done it?

This should be possible with gtkpod now, by right clicking on the iPod
and choosing the "Copy Tracks to Filesystem" item. The dialog
presented has an option for the filename format, something like
%a/%A/%T - %t.mp3. (Add additional extensions as needed, e.g.:
%%a/%A/%T - %t.mp3; %a/%A/%T - %t.m4a)

I'd have to look, but there might be a % switch to use the existing
extension. That would be most convenient, allowing %a/%A/%T - %t.%x
to work.

--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Some mornings it just doesn't seem worth it to gnaw through the
leather straps.
-- Emo Phillips

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

attachment0 (554 bytes) Download Attachment

Export iTunesDB to file system

2009-11-24T08:33:07Z

Hi,

I would like to make all my music in the iPod available using a plain fs interface where I create a
directory structure with 3 levels.

Artist -> Album -> Tracks

I could write something using libgpod, but I wonder if anybody has ever done it?

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: gtkpod helper scripts and spaces in mount point

2009-11-24T07:36:20Z

Ho Götz,

Götz Waschk wrote:
> On Sat, Oct 31, 2009 at 9:31 PM, Todd Zullinger <tmz@...>
> wrote:
>> Thanks for the patch. Looking at the scripts, many (if not most)
>> of them have quoting problems. We should probably clean them all
>> up and wrap it in a single commit. Anyone up for taking that on?
>> I think this is a start, but it would need testing and checking:
>
> thanks for the patch. When will you commit it?

I haven't had any time to further test that patch. I don't make any
use of the various scripts, so I hesitate to commit them without some
confirmation that they don't break more than they fix.

--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
IDIOT, n - A member of a large and powerful tribe whose influence in
human affairs has always been dominant and controlling.
-- Ambrose Bierce

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

attachment0 (554 bytes) Download Attachment

Re: Open patches

2009-11-24T07:14:37Z

Andrea wrote:
> Just a reminder, there are still 2 outstanding patches which should
> be very easy to merge
>
> http://article.gmane.org/gmane.comp.ipod.gtkpod/4351

It seems that this was applied along with the volume patch:

http://gtkpod.git.sourceforge.net/git/gitweb.cgi?p=gtkpod/gtkpod;a=commitdiff;h=b4d0195

> http://article.gmane.org/gmane.comp.ipod.gtkpod/4344

I just pushed this, thanks!

--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sanity is the trademark of a weak mind.
-- Mark Harrold

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

attachment0 (554 bytes) Download Attachment

Open patches

2009-11-24T04:42:33Z

Hi,

I've seen the volume patch has been merged. Good.
Just a reminder, there are still 2 outstanding patches which should be very easy to merge

http://article.gmane.org/gmane.comp.ipod.gtkpod/4351
http://article.gmane.org/gmane.comp.ipod.gtkpod/4344

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: gtkpod helper scripts and spaces in mount point

2009-11-09T06:25:07Z

On Sat, Oct 31, 2009 at 9:31 PM, Todd Zullinger <tmz@...> wrote:
> Thanks for the patch. Looking at the scripts, many (if not most) of
> them have quoting problems. We should probably clean them all up and
> wrap it in a single commit. Anyone up for taking that on? I think
> this is a start, but it would need testing and checking:

Hi Todd,

thanks for the patch. When will you commit it?

Regards, Götz
--
AL I:40: Do what thou wilt shall be the whole of the Law.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: Possible bug: sometimes gtkpod does not want to save the db.

2009-11-09T05:20:45Z

On 08/11/09 08:41, Andrea wrote:

> I've had the following problem recently.
> Not easy to reproduce, but it happens often enough.
>
> I import an .mp4 video to gtkpod and then try to save it.
>
> Eventually gtkpod will not save the db but print
>
> ** (gtkpod:3018): CRITICAL **: transfer_tracks_show_failed: assertion `tracks' failed
>
> to the console.
>
> Before that, usually I get a warning dialog about something to do with "lyrics" in a bad format.
>

The warning message is exactly

iPod File not available and ID3 saving disabled in options, cannot save lyrics to:

in write_lyrics_to_file() in file.c

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Possible bug: sometimes gtkpod does not want to save the db.

2009-11-08T00:41:27Z

I've had the following problem recently.
Not easy to reproduce, but it happens often enough.

I import an .mp4 video to gtkpod and then try to save it.

Eventually gtkpod will not save the db but print

** (gtkpod:3018): CRITICAL **: transfer_tracks_show_failed: assertion `tracks' failed

to the console.

Before that, usually I get a warning dialog about something to do with "lyrics" in a bad format.

The 2 always happen together (if they happen at all).

Debugging the code, the problem seems to be somewhere in

transfer_tracks_show_failed()

in file_itunesdb.c and its caller

transfer_tracks()

in the same file.

Basically file_transfer_get_status() returns a status of FILE_TRANSFER_IDLE and 1 failed track, but
then when it tries to get the list of failed tracks, there is none and the assert kicks in.

Any idea?

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

[PATCH] Change UI for the volume control. It uses now a GtkHScale.

2009-11-07T04:33:15Z

---
data/gtkpod.glade | 15 +++++++++----
src/details.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++++----
2 files changed, 64 insertions(+), 10 deletions(-)

diff --git a/data/gtkpod.glade b/data/gtkpod.glade
index 3b165ed..babb762 100644
--- a/data/gtkpod.glade
+++ b/data/gtkpod.glade
@@ -6816,11 +6816,16 @@ simultaneously</property>
</packing>
</child>
<child>
- <widget class="GtkEntry" id="details_entry_23">
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="invisible_char">*</property>
- </widget>
+ <widget class="GtkHScale" id="details_scale_23">
+ <property name="visible">True</property>
+ <property name="can_focus">True</property>
+ <property name="draw_value">True</property>
+ <property name="value_pos">GTK_POS_RIGHT</property>
+ <property name="digits">0</property>
+ <property name="update_policy">GTK_UPDATE_DISCONTINUOUS</property>
+ <property name="inverted">False</property>
+ <property name="adjustment">0 -255 255 1 16 0</property>
+ </widget>
<packing>
<property name="left_attach">1</property>
<property name="right_attach">2</property>
diff --git a/src/details.c b/src/details.c
index 02b4b4c..581622b 100644
--- a/src/details.c
+++ b/src/details.c
@@ -199,6 +199,24 @@ static void details_checkbutton_toggled (GtkCheckButton *button,
details_get_item (detail, item, FALSE);
}

+static gboolean details_scale_changed (GtkRange *scale,
+ GtkScrollType scroll,
+ gdouble value,
+ Detail *detail)
+{
+ T_item item;
+
+ g_return_if_fail (scale);
+
+ item = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (scale),
+ "details_item"));
+
+ g_return_if_fail ((item > 0) && (item < T_ITEM_NUM));
+
+ details_get_item (detail, item, FALSE);
+
+ return FALSE;
+}

static void details_combobox_changed (GtkComboBox *combobox,
Detail *detail)
@@ -735,7 +753,6 @@ static void details_setup_widget (Detail *detail, T_item item)
case T_PLAYCOUNT:
case T_BPM:
case T_RATING:
- case T_VOLUME:
case T_SOUNDCHECK:
case T_CD_NR:
case T_TRACK_NR:
@@ -765,6 +782,13 @@ static void details_setup_widget (Detail *detail, T_item item)
G_CALLBACK (details_text_changed),
detail);
break;
+ case T_VOLUME:
+ buf = g_strdup_printf ("details_scale_%d", item);
+ w = gtkpod_xml_get_widget (detail->xml, buf);
+ g_signal_connect (w, "change-value",
+ G_CALLBACK (details_scale_changed),
+ detail);
+ break;
case T_COMPILATION:
case T_TRANSFERRED:
case T_CHECKED:
@@ -817,7 +841,7 @@ static void details_set_item (Detail *detail, Track *track, T_item item)
GtkTextBuffer *tb;
GtkWidget *w = NULL;
gchar *text;
- gchar *entry, *checkbutton, *textview, *combobox;
+ gchar *entry, *checkbutton, *textview, *combobox, *scale;

g_return_if_fail (detail);
g_return_if_fail ((item > 0) && (item < T_ITEM_NUM));
@@ -826,6 +850,7 @@ static void details_set_item (Detail *detail, Track *track, T_item item)
checkbutton = g_strdup_printf ("details_checkbutton_%d", item);
textview = g_strdup_printf ("details_textview_%d", item);
combobox = g_strdup_printf ("details_combobox_%d", item);
+ scale = g_strdup_printf ("details_scale_%d", item);

if (track != NULL)
{
@@ -869,7 +894,6 @@ static void details_set_item (Detail *detail, Track *track, T_item item)
case T_PLAYCOUNT:
case T_BPM:
case T_RATING:
- case T_VOLUME:
case T_SOUNDCHECK:
case T_CD_NR:
case T_TRACK_NR:
@@ -895,6 +919,17 @@ static void details_set_item (Detail *detail, Track *track, T_item item)
gtk_entry_set_text (GTK_ENTRY (w), text);
g_signal_handlers_unblock_by_func(w, details_text_changed,detail);
break;
+ case T_VOLUME:
+ w = gtkpod_xml_get_widget (detail->xml, scale);
+ if (track)
+ {
+ gtk_range_set_value (GTK_RANGE (w), track->volume);
+ }
+ else
+ {
+ gtk_range_set_value (GTK_RANGE (w), 0.0);
+ }
+ break;
case T_COMMENT:
case T_DESCRIPTION:
case T_LYRICS:
@@ -1001,6 +1036,7 @@ static void details_set_item (Detail *detail, Track *track, T_item item)
g_free (textview);
g_free (combobox);
g_free (text);
+ g_free (scale);
}

@@ -1013,7 +1049,7 @@ static void details_get_item (Detail *detail, T_item item,
gboolean assumechanged)
{
GtkWidget *w = NULL;
- gchar *entry, *checkbutton, *textview, *combobox;
+ gchar *entry, *checkbutton, *textview, *combobox, *scale;
gboolean changed = FALSE;
ExtraTrackData *etr;
Track *track;
@@ -1030,6 +1066,7 @@ static void details_get_item (Detail *detail, T_item item,
checkbutton = g_strdup_printf ("details_checkbutton_%d", item);
textview = g_strdup_printf ("details_textview_%d", item);
combobox = g_strdup_printf ("details_combobox_%d", item);
+ scale = g_strdup_printf ("details_scale_%d", item);

switch (item)
{
@@ -1049,7 +1086,6 @@ static void details_get_item (Detail *detail, T_item item,
case T_PLAYCOUNT:
case T_BPM:
case T_RATING:
- case T_VOLUME:
case T_CD_NR:
case T_TRACK_NR:
case T_YEAR:
@@ -1118,6 +1154,18 @@ static void details_get_item (Detail *detail, T_item item,
}
}
break;
+ case T_VOLUME:
+ if ((w = gtkpod_xml_get_widget (detail->xml, scale)))
+ {
+ gdouble value = gtk_range_get_value (GTK_RANGE (w));
+ gint32 new_volume = (gint32)value;
+ if (track->volume != new_volume)
+ {
+ track->volume = new_volume;
+ changed = TRUE;
+ }
+ }
+ break;
case T_COMMENT:
case T_DESCRIPTION:
case T_SUBTITLE:
@@ -1254,6 +1302,7 @@ static void details_get_item (Detail *detail, T_item item,
g_free (checkbutton);
g_free (textview);
g_free (combobox);
+ g_free (scale);

details_update_buttons (detail);
}
--
1.6.2.5

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

[PATCH] Change UI for the volume control.

2009-11-07T04:33:14Z

This is a patch to change the UI control for the "volume" in the track details.
I've used a GtkHScale with range -255 - +255.
Let me know what you think.
Andrea

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

[PATCH] Bug fix, the list has to be NULL terminated.

2009-11-07T04:22:57Z

---
src/syncdir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/syncdir.c b/src/syncdir.c
index 1c55f05..58a10e5 100644
--- a/src/syncdir.c
+++ b/src/syncdir.c
@@ -496,7 +496,7 @@ static void cache_directory (const gchar *dir, GHashTable *dirs_hash)
while ((filename = g_dir_read_name(dir_handle)))
{
/* Construct absolute path from dir and filename */
- path = g_build_filename(dir, filename);
+ path = g_build_filename(dir, filename, NULL);

/* If path is not directory then move on to next */
if (! g_file_test (path, G_FILE_TEST_IS_DIR))
--
1.6.2.5

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Re: Help on increasing the volume.

2009-11-03T12:46:25Z

On 03/11/09 19:08, Todd Zullinger wrote:

> Andrea wrote:
>> there is a field in the track details "Volume" which is normally 0.
>> I guess it can be used to adjust the volume.
>>
>> What is the scale?
>
> The currently up ipodlinux.org wiki¹ says:
>
> "Volume adjustment field. This is a value from -255 to 255 that will
> be applied to the track on playback. If you adjust the volume slider
> in iTunes track info screen, this is what you are adjusting."
>
> ¹ http://www.ipodlinux.org/wiki/ITunesDB#Track_Item

Thanks.
Will try some values now.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Gtkpod-devel mailing list
Gtkpod-devel@...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel