HOM changes for merging into stable

[Niels Grewe]

Hello all,

I just created a review request for the ETCollection higher-order
messaging stuff to go into stable [0] . Since the review board doesn't
do that for me, I'm restating that request for feedback here. I'd be
happy if somebody could find the time to take a look and suggest
improvements and emendations and will vouch to buy that person(s) a beer
the next time I meet them ;-)

Cheers,


Niels

[0] http://review.etoileos.com/r/128/

_______________________________________________
Etoile-dev mailing list
Etoile-dev@...
https://mail.gna.org/listinfo/etoile-dev

[Quentin Mathé-2]

Hi Niels,

Le 5 nov. 2009 à 19:13, Niels Grewe a écrit :

> Hello all,
>
> I just created a review request for the ETCollection higher-order
> messaging stuff to go into stable [0] . Since the review board doesn't
> do that for me, I'm restating that request for feedback here. I'd be
> happy if somebody could find the time to take a look and suggest
> improvements and emendations and will vouch to buy that person(s) a  
> beer
> the next time I meet them ;-)

The new stuff you added looks great! :-)
I just the tested these recent changes on GNUstep and Mac OS X.  
Everything seems to be fine, except some tests failing on Mac OS X.

I was just wondering whether -inverseFilter would be better named -
filterOut? I had some troubles to understand what 'inverseFilter'  
means before I read the method documentation.
I'm not an English-native speaker though, may be -inverseFilter sounds  
good and it's just me.

I'll take a better look at it in the next days and post a review.

Cheers,
Quentin.
_______________________________________________
Etoile-dev mailing list
Etoile-dev@...
https://mail.gna.org/listinfo/etoile-dev

[Niels Grewe]

On Sat, Nov 07, 2009 at 12:41:34AM +0100, Quentin Mathé wrote:
> Everything seems to be fine, except some tests failing on Mac OS X.

I just fixed those. There were some problems due to the fact that in OS
X you will always get some mutable CF-bridged class for both
NSDictionary and NSMutableDictionary.

> I was just wondering whether -inverseFilter would be better named -
> filterOut? I had some troubles to understand what 'inverseFilter'  
> means before I read the method documentation.
> I'm not an English-native speaker though, may be -inverseFilter sounds  
> good and it's just me.

-inverseFilter was never my first choice either, but it seems to be
rather difficult to find a sound method name for it. (Eh, it might
just be that I'm seriously creativity-impaired) In MPWFoundation
the corresponding method is called -reject, which also struck me as
odd. Perhaps -filterOut can work. But how would you name the variant for
immutable collections? Is -filteredOutCollection okay? Maybe we should
really leave this for a native speaker to decide...

Cheers,


Niels

_______________________________________________
Etoile-dev mailing list
Etoile-dev@...
https://mail.gna.org/listinfo/etoile-dev

[Quentin Mathé-2]

Le 8 nov. 2009 à 18:46, Niels Grewe a écrit :

> On Sat, Nov 07, 2009 at 12:41:34AM +0100, Quentin Mathé wrote:
>> Everything seems to be fine, except some tests failing on Mac OS X.
>
> I just fixed those. There were some problems due to the fact that in  
> OS
> X you will always get some mutable CF-bridged class for both
> NSDictionary and NSMutableDictionary.

ok, thanks.

>> I was just wondering whether -inverseFilter would be better named -
>> filterOut? I had some troubles to understand what 'inverseFilter'
>> means before I read the method documentation.
>> I'm not an English-native speaker though, may be -inverseFilter  
>> sounds
>> good and it's just me.
>
> -inverseFilter was never my first choice either, but it seems to be
> rather difficult to find a sound method name for it. (Eh, it might
> just be that I'm seriously creativity-impaired) In MPWFoundation
> the corresponding method is called -reject, which also struck me as
> odd.

MPW borrows most of its terminology from Smalltalk, so I suppose  
that's why it uses -reject as -select inverse operation. I find a bit  
hard to remember that -reject is the inverse operation that  
corresponds to -select though.

However it could be nice to have Smalltalk HOM variants built on top  
of -filter, -map etc. in addition to the Smalltalk block variants. I  
mean if we have:
aCollection filterWithBlock: [:each | each age > 16] // Étoilé generic  
idiom
aCollection filter age > 16 // Étoilé generic HOM idiom
aCollection select: [:each | each age > 16] // Smalltalk-specific idiom

we might want to support with the SmalltalkSupport framework or similar:

aCollection select age > 16 // Smalltalk-specific HOM idiom

I took these examples from an existing Smalltalk HOM implementation  
described here: http://www.cincomsmalltalk.com/publicRepository/HigherOrderMessaging.html

> Perhaps -filterOut can work. But how would you name the variant for
> immutable collections? Is -filteredOutCollection okay?

yes -filteredOutCollection.

> Maybe we should
> really leave this for a native speaker to decide...

Fully agreed. Is there a native speaker to comment on that? :-)

Cheers,
Quentin.
_______________________________________________
Etoile-dev mailing list
Etoile-dev@...
https://mail.gna.org/listinfo/etoile-dev