Highlighting in conf.pl is unreadable with some terminal color schemas

Hi,

highlighting in configuration utility conf.pl does not work correctly.
For example in default gnome terminal color settings it's not readable (white
text on white paper). This could be fixed by:

a) using only bold, no color (most color schemas in terminals use different
color for bold text)

b) add background color

What do you think about this?

Regards,
Michal Hlavinka

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

[Paul Lesniewski]

On Tue, Mar 17, 2009 at 8:26 AM, Michal Hlavinka <mhlavink@...> wrote:

> Hi,
>
> highlighting in configuration utility conf.pl does not work correctly.
> For example in default gnome terminal color settings it's not readable (white
> text on white paper). This could be fixed by:
>
> a) using only bold, no color (most color schemas in terminals use different
> color for bold text)
>
> b) add background color
>
> What do you think about this?

Patches welcome

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

[Tomas Kuliavas]

Paul Lesniewski wrote:

On Tue, Mar 17, 2009 at 8:26 AM, Michal Hlavinka <[e-mail]> wrote:
> Hi,
>
> highlighting in configuration utility conf.pl does not work correctly.
> For example in default gnome terminal color settings it's not readable (white
> text on white paper). This could be fixed by:
>
> a) using only bold, no color (most color schemas in terminals use different
> color for bold text)
>
> b) add background color
>
> What do you think about this?

Patches welcome

Don't use ANSI escape code which sets color in highlighted text.

Find both '$WHT = "\x1B[37;1m"' entries in conf.pl and remove white color escape code ('37;')

http://en.wikipedia.org/wiki/ANSI_escape_code

[Paul Lesniewski]

>>> highlighting in configuration utility conf.pl does not work correctly.
>>> For example in default gnome terminal color settings it's not readable
>>> (white
>>> text on white paper). This could be fixed by:
>>>
>>> a) using only bold, no color (most color schemas in terminals use
>>> different
>>> color for bold text)
>>>
>>> b) add background color
>>>
>>> What do you think about this?
>>
>> Patches welcome
>>
>
> Don't use ANSI escape code which sets color in highlighted text.
>
> Find both '$WHT = "\x1B[37;1m"' entries in conf.pl and remove white color
> escape code ('37;')

Thanks, Tomas.  Committed.

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel