I need confirmation...

[Vladimir Savic-3]

...that something has changed in rg code that makes importing of .sf2
files crash the app.
I've got a few hours of free time to improve lscp import, but something
has changed in instruments.cpp or elsewhere that stops me at this time.
If someone has more knowledge and time then me to correct this issue,
I'd be very grateful.

Vlada

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[cannam]

On Tue, Oct 27, 2009 at 9:58 AM, Vladimir Savic
<vladimir.firefly.savic@...> wrote:
> ...that something has changed in rg code that makes importing of .sf2
> files crash the app.

Confirmed, and fixed in SVN.

The cause was a change in the device code so that the MIDI device
object created its own instrument objects, rather than having the code
that created the devices also create instruments for it.  To do this,
it needs to have a valid base instrument ID to start from.  The
importer code was creating devices that were only intended to be
temporary, so it has always used the arbitrary device ID of zero for
all of them, and I extended this to use the arbitrary instrument base
ID of zero as well -- but the instrument code rejects this (with an
assertion failure) as not a valid instrument ID.  Corrected it to
MidiInstrumentBase (=1000) and it works again.

So, my fault.  Sorry about that.


Chris

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel