Importers 1.5 broken

[Ruud v A]

The importers in the 1.5 source are broken. The .cs files are included, but they are not included in a project. Make will build them but Monodevelop won't. They also don't seem to work. As the folder importers do work I suspect that the ThreadPoolImportSource class is broken somehow.

I was writing an iTunes importer and it worked for 1.4.3 but with the new source some import-related stuff seems to be broken.

[Alexander Kojevnikov]

2009/6/2 Ruud v A <banshee@...>:
>
> The importers in the 1.5 source are broken. The .cs files are included, but
> they are not included in a project. Make will build them but Monodevelop
> won't. They also don't seem to work. As the folder importers do work I
> suspect that the ThreadPoolImportSource class is broken somehow.
>
> I was writing an iTunes importer and it worked for 1.4.3 but with the new
> source some import-related stuff seems to be broken.

This is fixed in the patch from http://bugzilla.gnome.org/show_bug.cgi?id=441093

Could you check if that patch works for your iTunes database? If your
importer does something that the one from bgo#441093 doesn't do, I
would be interested in consolidating them.

Cheers,
Alex
_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[Ruud v A]

Alexander Kojevnikov wrote:

This is fixed in the patch from http://bugzilla.gnome.org/show_bug.cgi?id=441093

Could you check if that patch works for your iTunes database? If your
importer does something that the one from bgo#441093 doesn't do, I
would be interested in consolidating them.

Cheers,
Alex

This patch works :D
It works different than mine but it also solves some problems I hadn't dealt with yet. Mine had one advantage though: it scanned your computer for installed iTunes versions and then compares user names etc. to find an iTunes library. If none is found, CanImport returned false. Also the checkboxes wheter to import ratings etc. is unnecessary; why would you uncheck this while importing? So I think the entire dialog could be left out and the importer could be made more intelligent.

There is one remark: if the user completely switches to Banshee and uninstalls iTunes but backups his library file, my importer won't find it. This would only work if the user keeps his music in a separate folder.

The importer is great but it could be made a lot "smarter" so it requires less input from the user and just imports.

I am currently working on implementing that for the patch, but do you think it would be an improvement?

P.S is this included for 1.5?

P.P.S the Rythmbox importer still doesn't work, though I have used Rythmbox. In 1.4 it did work.

[Alexander Kojevnikov]

2009/6/3 Ruud v A <banshee@...>:

> This patch works :D

Thanks for testing!

> It works different than mine but it also solves some problems I hadn't dealt
> with yet. Mine had one advantage though: it scanned your computer for
> installed iTunes versions and then compares user names etc. to find an
> iTunes library. If none is found, CanImport returned false.

How fast is it? CanImport is called each time the Import dialogue
opens, does it slow it down?

> Also the
> checkboxes wheter to import ratings etc. is unnecessary; why would you
> uncheck this while importing? So I think the entire dialog could be left out
> and the importer could be made more intelligent.

See comments 25-27 in bgo#532650, it looks like *not* importing the
ratings, etc can sometimes be useful.

> There is one remark: if the user completely switches to Banshee and
> uninstalls iTunes but backups his library file, my importer won't find it.
> This would only work if the user keeps his music in a separate folder.

That IMHO is a major limitation. This wouldn't work if for example the
user wants to import her iTunes library to a brand new Linux box.

> The importer is great but it could be made a lot "smarter" so it requires
> less input from the user and just imports.
>
> I am currently working on implementing that for the patch, but do you think
> it would be an improvement?

Auto-discovery of the iTunes library file would be useful if it works
fast enough.

> P.S is this included for 1.5?

No.

> P.P.S the Rythmbox importer still doesn't work, though I have used Rythmbox.
> In 1.4 it did work.

What exactly doesn't work? Is it the inclusion of the PlayerMigration
project into the solution or something else? Could you file a bug if
the latter?
_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[Ruud v A]

Alexander Kojevnikov wrote:

2009/6/3 Ruud v A <[e-mail]>:
How fast is it? CanImport is called each time the Import dialogue
opens, does it slow it down?

First of all, I'm sorry for my late reply... I haven't been using Linux for some time.
I ran some test, the first time it took 1,112843 seconds to find the library, but after that each next time takes only about 0,77 seconds. This scans eight drives in my computer, determines if there is a OS installed with users, then scans the user folders for iTunes folders and then selects the most recent one based on the username or not if they don't match. It found two libraries and chose the right one.

[Alexander Kojevnikov]

2009/7/7 Ruud v A <banshee@...>:

> Alexander Kojevnikov wrote:
>> 2009/6/3 Ruud v A <banshee@...>:
>> How fast is it? CanImport is called each time the Import dialogue
>> opens, does it slow it down?
>
> I ran some test, the first time it took 1,112843 seconds to find the
> library, but after that each next time takes only about 0,77 seconds. This
> scans eight drives in my computer, determines if there is a OS installed
> with users, then scans the user folders for iTunes folders and then selects
> the most recent one based on the username or not if they don't match. It
> found two libraries and chose the right one.

That's quite a delay IMHO. Imagine how slow the import dialogue would
be if future importers have the same delay for CanImport?

Anyway, we are going to revamp the import dialogue so that the import
options are included in it rather than in a newly opened dialogue. See
BGO 559013 [1]

Regardless of this, on-demand auto-discovery of the iTunes library
would make a great feature, feel free to file a bug for it.

[1] http://bugzilla.gnome.org/show_bug.cgi?id=559013
_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list