Improve pg_restore docs

View: New views
4 Messages — Rating Filter:   Alert me  

Improve pg_restore docs

by Mike Toews :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

 From a quick discussion on hackers
(http://archives.postgresql.org/pgsql-hackers/2009-06/msg01434.php), it
appears the documentation can improve for pg_restore.

I've prepared some quick diff output from
pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think
would help. Note that I'm not entirely sure about the default namespace
from default_path .. please verify this before accepting. Edit as necessary.

291c291,292
<         specific table.
---
 >         specific table.  The default is taken from the
 >         <envar>default_path</envar> variable.
379c380,382
<         Restore definition and/or data of named table only.
---
 >         Restore definition and/or data of named table only. This can be
 >         combined with the <option>-n</option> option to restore a table
 >         from a specific schema.


Thanks,

-Mike


--
Sent via pgsql-docs mailing list (pgsql-docs@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

Re: Improve pg_restore docs

by Greg Smith-12 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Mon, 29 Jun 2009, Mike Toews wrote:

> I've prepared some quick diff output from
> pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think would
> help.

The standard way to submit patches here is to attach a file with a full
context diff (diff -c) to the message, rather than putting it inline or
including just the changes.  The idea is to make it easy for the
committers to grab your patch and apply it.

--
* Greg Smith gsmith@... http://www.gregsmith.com Baltimore, MD

--
Sent via pgsql-docs mailing list (pgsql-docs@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

Re: Improve pg_restore docs

by Mike Toews :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Greg Smith wrote:
> The standard way to submit patches here is to attach a file with a
> full context diff (diff -c) to the message, rather than putting it
> inline or including just the changes.  The idea is to make it easy for
> the committers to grab your patch and apply it.

Part of my hesitation in attaching the patch is that I'm on a Windows
computer (be aware of CRLF line endings in the attached). Apply to
pgsql/doc/src/sgml/ref/pg_restore.sgml

-Mike

291c291,292
<         specific table.
---
>         specific table.  The default is taken from the
>         <envar>default_path</envar> variable.
379c380,382
<         Restore definition and/or data of named table only.
---
>         Restore definition and/or data of named table only. This can be
>         combined with the <option>-n</option> option to restore a table
>         from a specific schema.


--
Sent via pgsql-docs mailing list (pgsql-docs@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

Re: Improve pg_restore docs

by Greg Smith-12 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Mon, 29 Jun 2009, Mike Toews wrote:

> Apply to pgsql/doc/src/sgml/ref/pg_restore.sgml

The main point I was trying to make is that we want the whole patch, not
just the change.  A standard diff patch will include what file name it is
supposed to apply to as part of its header.

--
* Greg Smith gsmith@... http://www.gregsmith.com Baltimore, MD

--
Sent via pgsql-docs mailing list (pgsql-docs@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs