Gianny Damour wrote:
> Jules Gosnell wrote:
>
>> Gianny Damour wrote:
>>
>>> Hi Jules,
>>>
>>> TestGroup is now passing on my local version. If you wait a little
>>> bit, I will commit my updates.
>>
>>
>>
>> Cool.
>>
>> So have you made the same changes as I have made ?
>
>
> Same changes + what is required to be able to use "==" instead of
> "equals" on Address.
great :-)
FYI - here is a breakdown of the borken (my side) InVM tests :
<exclude
implementation="java.lang.String">**/TestInVMReplicationContextualiser.java</exclude><!--
runs but throws exception -->
<exclude
implementation="java.lang.String">**/TestInVMEvacuation.java</exclude><!--
runs but wong -->
<exclude
implementation="java.lang.String">**/TestInVMRelocation.java</exclude><!--
runs but wong -->
'runs but wrong' - means that whilst the test succeeds, I can tell from
the output that not everything went to plan. In both cases something
goes wrong with Partition negotiation and multiple copies of the same
Partition arise and have to be resolved...
I will start looking at this as soon as you get checked in.
thanks,
Jules
>
> Thanks,
> Gianny
>
>>
>> Jules
>>
>>>
>>> Also, TestGroup does not pass with the AC backend on my box. Could
>>> you please confirm that it works on my machine? This is the reason
>>> why I have not yet checked in my local updates...
>>>
>>> Thanks,
>>> Gianny
>>>
>>> Jules Gosnell wrote:
>>>
>>>> Jules Gosnell wrote:
>>>>
>>>>> Gianny,
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> My bad !
>>>>
>>>> I've just taken a look at this - I had added an implementation of
>>>> 'waitForClusterToStart' - but on the shared rather than local
>>>> Cluster - so it didn't work, because all the peers are remote to
>>>> the shared one... - fixed that.
>>>> Ensured that setAddress(target) was called on outgoing messages as
>>>> the test uses this.
>>>> just looking at ensuring object identity for Addresses - so the
>>>> same Address is always '==' instead of just 'equals()' - WADI
>>>> doesn't yet need it, but I putting it into all backends so that we
>>>> can soon use this feature to avoid getting multiple views on a
>>>> remote Peer in the same local Peer.
>>>>
>>>> Jules
>>>>
>>>>>
>>>>> I've been rationalising the tests a bit more - coverage slowly
>>>>> rising :-)
>>>>>
>>>>> I have introduced a new test suite that can be run against our
>>>>> backends :
>>>>>
>>>>> ./wadi-dispatcher/src/test/java/org/codehaus/wadi/group/TestGroup.java
>>>>>
>>>>> ./wadi-jgroups/src/test/java/org/codehaus/wadi/jgroups/TestGroup.java
>>>>> ./wadi-activecluster/src/test/java/org/codehaus/wadi/activecluster/TestGroup.java
>>>>>
>>>>>
>>>>> In the dispatcher module, this test is written against the InVM impl.
>>>>> In the other backends it is subclassed and the InVM impl is
>>>>> replaced with the relevant backend.
>>>>> I hope to increase the number of tests in it, until we have a
>>>>> pretty good test harness for any new backend - e.g. Tribes
>>>>>
>>>>> It runs fine against AC and JG at the moment, but is not so happy
>>>>> with InVM :-(
>>>>>
>>>>> Would you mind taking a look, when you have time,
>>>>>
>>>>> Cheers :-)
>>>>>
>>>>>
>>>>> Jules
>>>>>
>>>>> P.S.
>>>>>
>>>>> Gianni and Filip,
>>>>>
>>>>> you may want to consider putting Tribes underneath this as a first
>>>>> test of the new backend...
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>
>
--
"Open Source is a self-assembling organism. You dangle a piece of
string into a super-saturated solution and a whole operating-system
crystallises out around it."
/**********************************
* Jules Gosnell
* Partner
* Core Developers Network (Europe)
*
* www.coredevelopers.net
*
* Open Source Training & Support.
**********************************/