Incoming freeze on Thursday, 22th at midnight

[Cyrille Berger]

Hello,

In preparation of the RC release, and of the tag of the RC, koffice/trunk will
enter deep freeze on Thursday, 22th at midnight wherever you live. After that,
until I say so, no commit is allowed, to the exception of build fixes that I
have approuved.

On Friday, I will send an other email to tell when the freeze is lift.

--
Cyrille Berger
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

[Cyrille Berger]

Hello,

After talking to some of you it appears that doing the branching today isn't a
good idea (for instance, we still have some deep issues marked as
release_blocker), so unless some one has a good reason for reopening trunk, it
will be done at a later date.

On Tuesday 20 October 2009, Cyrille Berger wrote:
> Hello,
>
> In preparation of the RC release, and of the tag of the RC, koffice/trunk
>  will enter deep freeze on Thursday, 22th at midnight wherever you live.
>  After that, until I say so, no commit is allowed, to the exception of
>  build fixes that I have approuved.
>
> On Friday, I will send an other email to tell when the freeze is lift.
>


--
Cyrille Berger
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Hello,

On Fri October 23 2009, Cyrille Berger wrote:
> After talking to some of you it appears that doing the branching today
>  isn't a good idea (for instance, we still have some deep issues marked as
> release_blocker), so unless some one has a good reason for reopening trunk,
>  it will be done at a later date.

I think it would be a good idea if such a discussion (if branching should be
done) is made on the mailing list so that everybody can participate.

I'm not sure what the commit policy is for the moment. Can one just commit a
patch or do we need review for patches now.

If so could someone please review the attached patch. It fixes loading of
formulas.

Have a nice weekend,

Thorsten

[kformula.diff]

---

Index: KoFormulaShape.cpp
===================================================================
--- KoFormulaShape.cpp (revision 1039538)
+++ KoFormulaShape.cpp (working copy)
@@ -87,7 +87,7 @@ bool KoFormulaShape::loadOdf( const KoXm
 
 bool KoFormulaShape::loadOdfFrameElement( const KoXmlElement & element, KoShapeLoadingContext &/*context*/ )
 {
-    KoXmlElement topLevelElement = KoXml::namedItemNS(element, "http://www.w3.org/1998/Math/MathML", "math");
+    const KoXmlElement &topLevelElement = KoXml::namedItemNS(element, "http://www.w3.org/1998/Math/MathML", "math");
     // This is only true when loading as embedded in the main doc
     if (topLevelElement.isNull()) {
         kWarning() << "no math element as first child";
@@ -95,7 +95,7 @@ bool KoFormulaShape::loadOdfFrameElement
     }
     delete m_formulaData->formulaElement();
     FormulaElement* formulaElement = new FormulaElement();     // create a new root element
-    formulaElement->readMathML( element );     // and load the new formula
+    formulaElement->readMathML( topLevelElement );     // and load the new formula
     m_formulaData->setFormulaElement(formulaElement);
     m_formulaData->notifyDataChange(0,false);
     return true;

---

_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

[Cyrille Berger]

On Saturday 24 October 2009, Thorsten Zachmann wrote:
> If so could someone please review the attached patch. It fixes loading of
> formulas.
I think a bit of review doesn't harm now. Even if it doesn't prevent
everything ;)

Speaking of the formula shape, what is it's statuts ? Is it releasable ? Does
your patch help making it releasable ?

--
Cyrille Berger
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Dissabte 24 Octubre 2009(e)an, Cyrille Berger(e)k idatzi zuen:
> On Saturday 24 October 2009, Thorsten Zachmann wrote:
> > If so could someone please review the attached patch. It fixes loading of
> > formulas.

please apply

> Speaking of the formula shape, what is it's statuts ? Is it releasable ?

What happens when a document containing a formula gets loaded without formula
shape? formula is ignored or lost? If lost it could be released (it would not
harm more), if ignored it should not be released (formula shape still has data
loss issues even with no tools :(

Cheers!
--
Alfredo Beaumont Sainz
http://www.alfredobeaumont.org/blog.cgi


_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

[Cyrille Berger]

Ok after further discussions, all objections to branching are lift, I will
therefor proceed to the branching later tonight.

--
Cyrille Berger
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel