Is this patch correct?
|
View:
New views
2 Messages
—
Rating Filter:
Alert me
|
 |
Is this patch correct?
by Dave Plater-2
::
Rate this Message:
Hi, openSUSE build service gives an error for "else if (value >=
m_mediumKnee < m_loudKnee)" on line 98 in src/gui/rulers/VelocityColour.cpp so I made a patch but not being that literate in C++ I'm not sure if I actually interpreted the statement right. The patch is against latest svn Rosegarden Thorn :- cat rosegarden-mathmeaning.patch Index: rosegarden/src/gui/rulers/VelocityColour.cpp =================================================================== --- src/gui/rulers/VelocityColour.cpp +++ src/gui/rulers/VelocityColour.cpp @@ -95,7 +95,7 @@ VelocityColour::getColour(int value) ( m_loStartGreen + m_loStepGreen * value ) / m_multiplyFactor, ( m_loStartBlue + m_loStepBlue * value ) / m_multiplyFactor); - } else if (value >= m_mediumKnee < m_loudKnee) { + } else if ((value >= m_mediumKnee) && (value < m_loudKnee)) { int mixFactor = value - m_mediumKnee; m_mixedColour.setRgb( Regards Dave P ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@... - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel |
|
|
Re: Is this patch correct?
by cannam
::
Rate this Message:
On Sun, Oct 18, 2009 at 7:36 AM, Dave Plater <davejplater@...> wrote:
> Hi, openSUSE build service gives an error for "else if (value >= > m_mediumKnee < m_loudKnee)" on line 98 in > src/gui/rulers/VelocityColour.cpp so I made a patch but not being that > literate in C++ I'm not sure if I actually interpreted the statement > right. Looks correct to me -- fix in SVN, thanks. Chris ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@... - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel |
| Free embeddable forum powered by Nabble | Forum Help |
