JavaAgent support (SUREFIRE-179)

View: New views
6 Messages — Rating Filter:   Alert me  

JavaAgent support (SUREFIRE-179)

by David Blevins :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Is there any committer out there who has the time to review and commit  
this patch?

Would be happy to issue a "thank you" blog post in the OpenEJB blog to  
the committer who gets this functionality in :)  Would be a big bonus  
for OpenEJB/OpenJPA unit testers to get this or something like it in.


-David











---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: JavaAgent support (SUREFIRE-179)

by brettporter :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I took a look and the patch is quite out of date and didn't apply  
straight up for me. It does have tests though so with any luck I'll  
get a closer look at the hackathon tomorrow.

The good news (sort of) is that Surefire has very few changes  
committed since the last release, so a release should be reasonably  
straightforward.

- Brett

On 02/11/2009, at 1:44 PM, David Blevins wrote:

> Is there any committer out there who has the time to review and  
> commit this patch?
>
> Would be happy to issue a "thank you" blog post in the OpenEJB blog  
> to the committer who gets this functionality in :)  Would be a big  
> bonus for OpenEJB/OpenJPA unit testers to get this or something like  
> it in.
>
>
> -David
>
>
>
>
>
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: JavaAgent support (SUREFIRE-179)

by David Blevins :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Yeah, I wasn't sure if that patch was still good (or if it ever was).

Thanks for taking a look a it!

-David

On Nov 3, 2009, at 12:15 AM, Brett Porter wrote:

> I took a look and the patch is quite out of date and didn't apply  
> straight up for me. It does have tests though so with any luck I'll  
> get a closer look at the hackathon tomorrow.
>
> The good news (sort of) is that Surefire has very few changes  
> committed since the last release, so a release should be reasonably  
> straightforward.
>
> - Brett
>
> On 02/11/2009, at 1:44 PM, David Blevins wrote:
>
>> Is there any committer out there who has the time to review and  
>> commit this patch?
>>
>> Would be happy to issue a "thank you" blog post in the OpenEJB blog  
>> to the committer who gets this functionality in :)  Would be a big  
>> bonus for OpenEJB/OpenJPA unit testers to get this or something  
>> like it in.
>>
>>
>> -David
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Java versions within surefire ?

by Kristian Rosenvold-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I am working on a patch to surefire and find that habitually I'm
consistently grabbing got my <>'s and java 5 for loops. I see the
following seems to apply:

Some surefire-providers have an implicit java 5 requirement because
(like junit 4) they support java 5 projects.

But what language levels are effective in shared modules (like
surefire-api), surefire-plugin and surefire-booter ? At least sine poms
don't seem to be entirely correctly set up to refelect language levels
either (testng provider uses java 5 features but does not seem to be at
java 5 language level in the poms - AFAIK)


Regards,

Kristian Rosenvold





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Java versions within surefire ?

by brettporter :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

The plugin is 1.4 and the booter/api is 1.3 so that you can still run  
tests on old JDKs.

The plugin *could* be updated to 1.5 if it is made to require Maven  
2.2. Probably not worth it at this stage.

- Brett

On 03/11/2009, at 6:09 PM, Kristian Rosenvold wrote:

> I am working on a patch to surefire and find that habitually I'm
> consistently grabbing got my <>'s and java 5 for loops. I see the
> following seems to apply:
>
> Some surefire-providers have an implicit java 5 requirement because
> (like junit 4) they support java 5 projects.
>
> But what language levels are effective in shared modules (like
> surefire-api), surefire-plugin and surefire-booter ? At least sine  
> poms
> don't seem to be entirely correctly set up to refelect language levels
> either (testng provider uses java 5 features but does not seem to be  
> at
> java 5 language level in the poms - AFAIK)
>
>
> Regards,
>
> Kristian Rosenvold
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Java versions within surefire ?

by Stephen Connolly-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I don;t see much to be gained in making surefire require JDK 1.5.
There are a lot of people on 2.0.x (heck recent traffic on the list
would seem to imply a lot of people starting to use maven 1.1!) and
forcing JDK 1.5 on them just to get some of the fixes in surefire
would seem to be not nice.

Now that we have maven-plugin-enforcer we should be able to test the
core plugins a bit better and that way we can start releasing them
more often... just have to wait for Benjamin to wire it up on the grid

-Stephen

2009/11/4 Brett Porter <brett@...>:

> The plugin is 1.4 and the booter/api is 1.3 so that you can still run tests
> on old JDKs.
>
> The plugin *could* be updated to 1.5 if it is made to require Maven 2.2.
> Probably not worth it at this stage.
>
> - Brett
>
> On 03/11/2009, at 6:09 PM, Kristian Rosenvold wrote:
>
>> I am working on a patch to surefire and find that habitually I'm
>> consistently grabbing got my <>'s and java 5 for loops. I see the
>> following seems to apply:
>>
>> Some surefire-providers have an implicit java 5 requirement because
>> (like junit 4) they support java 5 projects.
>>
>> But what language levels are effective in shared modules (like
>> surefire-api), surefire-plugin and surefire-booter ? At least sine poms
>> don't seem to be entirely correctly set up to refelect language levels
>> either (testng provider uses java 5 features but does not seem to be at
>> java 5 language level in the poms - AFAIK)
>>
>>
>> Regards,
>>
>> Kristian Rosenvold
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@...
>> For additional commands, e-mail: dev-help@...
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...