Nabble - Kannel - Dev

Re: reference documentation (not doxygen)

2009-12-22T03:56:38Z

Thanks for the reply. I'll look that document. Thanks again.

2009/12/21 Nikos Balkanas <nbalkanas@...>

Nope. Just the sources and inlined comments. If you are interested in wap, there is an excellent architecture document, but none for SMS.

BR,

Nikos

----- Original Message -----

From: estebancacavelos@...

To: devel@...

Sent: Monday, December 21, 2009 10:32 PM

Subject: reference documentation (not doxygen)

Hi, I want to know if there are any tutorial or something different than doxygen to help me better understand the code of Kannel ?.

Sorry for the erros, my native language is Spanish and my English is not too good.

Thanks for the help.

--
Esteban L. Cacavelos de Amoriza
Cel: 0981 220 429

--
Esteban L. Cacavelos de Amoriza
Cel: 0981 220 429

Re: reference documentation (not doxygen)

2009-12-21T13:22:47Z

Nope. Just the sources and inlined comments. If you are interested in wap, there is an excellent architecture document, but none for SMS.

BR,

Nikos

----- Original Message -----

From: estebancacavelos@...

To: devel@...

Sent: Monday, December 21, 2009 10:32 PM

Subject: reference documentation (not doxygen)

Hi, I want to know if there are any tutorial or something different than doxygen to help me better understand the code of Kannel ?.

Sorry for the erros, my native language is Spanish and my English is not too good.

Thanks for the help.

--
Esteban L. Cacavelos de Amoriza
Cel: 0981 220 429

reference documentation (not doxygen)

2009-12-21T12:32:59Z

Hi, I want to know if there are any tutorial or something different than doxygen to help me better understand the code of Kannel ?.

Sorry for the erros, my native language is Spanish and my English is not too good.

Thanks for the help.

--
Esteban L. Cacavelos de Amoriza
Cel: 0981 220 429

Patch: Compiler warnings

2009-12-18T07:20:39Z

Hi,

A couple of ominus compiler warnings:

warning: array subscript is above array bounds

At least the first one should result in an invalid write during normal operation.

BR,

Nikos

kannel.diff (1K) Download Attachment

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2009-12-17T04:33:27Z

Am 17.12.2009 um 11:28 schrieb Konstantin Vayner:

why remembering smsc-id in sms.smsc_id is not enough?

due to accepted-smsc in smsc config group and because SMSCs may have the same names (or even no names defines)...

how does smsbox remember routing when i submit a message with predefined smsc id from http (sendsms) ?

On Thu, Dec 17, 2009 at 12:10 PM, Alexander Malysh <amalysh@...> wrote:

Am 17.12.2009 um 10:43 schrieb Konstantin Vayner:

so the best option would be to requeue the part via same smsc, right ?

yes, but it's not easy todo. You have to remember SMSC pointer not only SMSC-name/id and then teach all routing parts

to respect it...

cause requeueing all parts may also get extra messages to the handset despite it not being able to reconstruct (not to mention the extra money ;) )

On Thu, Dec 17, 2009 at 11:33 AM, Alexander Malysh <amalysh@...> wrote:

Hi,

unfortunately this will not work as expected (the rule is: _all_ parts if multipart message have to be send via the same SMSC)...

example:

SMSC-A -> splits (2 parts) -> 1 part sent OK -> 2 part get temp. error -> you put it into global queue for resend -> 2 part sent via SMSC-B -> handset rejects it

We have only two possibility here:
1) if temp error occurs put the _whole_ message into resend queue and resend then _all_ parts (very easy todo)
2) remember smsc which was used for first parts and resend it via the same smsc (complicated but save money :) )

Thanks,
Alexander Malysh

Am 16.12.2009 um 18:17 schrieb Konstantin Vayner:

Bug report: http://redmine.kannel.org/issues/show/529

Quote from gw/bb_smscconn.c :

static void handle_split(SMSCConn *conn, Msg *msg, long reason)
{
    struct split_parts *split = msg->sms.split_parts;

    /*
     * If temporarely failed, try again immediately but only if connection active.
     * Because if connection is not active we will loop for ever here consuming 100% CPU
     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
     */
    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
        smscconn_send(conn, msg) == 0) {
        /* destroy this message because it will be duplicated in smsc module */
        msg_destroy(msg);
        return;
    }

(end quote)

So, if an smsc is alive and throws temporary error every time you try to submit such a message, we enter endless loop of attempting to resend it....

Suggested patch follows (also attached).
Sorry its not cvs diff - having firewall issues accessing pserver now so i ran diff vs snapshot generated yesterday
I will be able to produce a normal cvs diff tomorrow morning if it is needed

--- kannel-snapshot/gw/bb_smscconn.c    2009-11-15 16:12:28.000000000 +0200
+++ gateway-cvs/gw/bb_smscconn.c        2009-12-16 19:47:32.000000000 +0200
@@ -203,18 +203,6 @@
     struct split_parts *split = msg->sms.split_parts;

     /*
-     * If temporarely failed, try again immediately but only if connection active.
-     * Because if connection is not active we will loop for ever here consuming 100% CPU
-     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
-     */
-    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
-        smscconn_send(conn, msg) == 0) {
-        /* destroy this message because it will be duplicated in smsc module */
-        msg_destroy(msg);
-        return;
-    }
-
-    /*
      * if the reason is not a success and status is still success
      * then set status of a split to the reason.
      * Note: reason 'malformed','discarded' or 'rejected' has higher priority!
@@ -303,7 +291,7 @@

void bb_smscconn_send_failed(SMSCConn *conn, Msg *sms, int reason, Octstr *reply)
{
-    if (sms->sms.split_parts != NULL) {
+    if (reason != SMSCCONN_FAILED_TEMPORARILY && sms->sms.split_parts != NULL) {
         handle_split(conn, sms, reason);
         octstr_destroy(reply);
         return;

<bb_smscconn.diff>

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2009-12-17T02:28:10Z

why remembering smsc-id in sms.smsc_id is not enough?
how does smsbox remember routing when i submit a message with predefined smsc id from http (sendsms) ?

On Thu, Dec 17, 2009 at 12:10 PM, Alexander Malysh <amalysh@...> wrote:

Am 17.12.2009 um 10:43 schrieb Konstantin Vayner:

so the best option would be to requeue the part via same smsc, right ?

yes, but it's not easy todo. You have to remember SMSC pointer not only SMSC-name/id and then teach all routing parts

to respect it...

cause requeueing all parts may also get extra messages to the handset despite it not being able to reconstruct (not to mention the extra money ;) )

On Thu, Dec 17, 2009 at 11:33 AM, Alexander Malysh <amalysh@...> wrote:

Hi,

unfortunately this will not work as expected (the rule is: _all_ parts if multipart message have to be send via the same SMSC)...

example:

SMSC-A -> splits (2 parts) -> 1 part sent OK -> 2 part get temp. error -> you put it into global queue for resend -> 2 part sent via SMSC-B -> handset rejects it

We have only two possibility here:
1) if temp error occurs put the _whole_ message into resend queue and resend then _all_ parts (very easy todo)
2) remember smsc which was used for first parts and resend it via the same smsc (complicated but save money :) )

Thanks,
Alexander Malysh

Am 16.12.2009 um 18:17 schrieb Konstantin Vayner:

Bug report: http://redmine.kannel.org/issues/show/529

Quote from gw/bb_smscconn.c :

static void handle_split(SMSCConn *conn, Msg *msg, long reason)
{
    struct split_parts *split = msg->sms.split_parts;

    /*
     * If temporarely failed, try again immediately but only if connection active.
     * Because if connection is not active we will loop for ever here consuming 100% CPU
     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
     */
    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
        smscconn_send(conn, msg) == 0) {
        /* destroy this message because it will be duplicated in smsc module */
        msg_destroy(msg);
        return;
    }

(end quote)

So, if an smsc is alive and throws temporary error every time you try to submit such a message, we enter endless loop of attempting to resend it....

Suggested patch follows (also attached).
Sorry its not cvs diff - having firewall issues accessing pserver now so i ran diff vs snapshot generated yesterday
I will be able to produce a normal cvs diff tomorrow morning if it is needed

--- kannel-snapshot/gw/bb_smscconn.c    2009-11-15 16:12:28.000000000 +0200
+++ gateway-cvs/gw/bb_smscconn.c        2009-12-16 19:47:32.000000000 +0200
@@ -203,18 +203,6 @@
     struct split_parts *split = msg->sms.split_parts;

     /*
-     * If temporarely failed, try again immediately but only if connection active.
-     * Because if connection is not active we will loop for ever here consuming 100% CPU
-     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
-     */
-    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
-        smscconn_send(conn, msg) == 0) {
-        /* destroy this message because it will be duplicated in smsc module */
-        msg_destroy(msg);
-        return;
-    }
-
-    /*
      * if the reason is not a success and status is still success
      * then set status of a split to the reason.
      * Note: reason 'malformed','discarded' or 'rejected' has higher priority!
@@ -303,7 +291,7 @@

void bb_smscconn_send_failed(SMSCConn *conn, Msg *sms, int reason, Octstr *reply)
{
-    if (sms->sms.split_parts != NULL) {
+    if (reason != SMSCCONN_FAILED_TEMPORARILY && sms->sms.split_parts != NULL) {
         handle_split(conn, sms, reason);
         octstr_destroy(reply);
         return;

<bb_smscconn.diff>

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2009-12-17T02:10:25Z

Am 17.12.2009 um 10:43 schrieb Konstantin Vayner:

so the best option would be to requeue the part via same smsc, right ?

yes, but it's not easy todo. You have to remember SMSC pointer not only SMSC-name/id and then teach all routing parts

to respect it...

cause requeueing all parts may also get extra messages to the handset despite it not being able to reconstruct (not to mention the extra money ;) )

On Thu, Dec 17, 2009 at 11:33 AM, Alexander Malysh <amalysh@...> wrote:

Hi,

unfortunately this will not work as expected (the rule is: _all_ parts if multipart message have to be send via the same SMSC)...

example:

SMSC-A -> splits (2 parts) -> 1 part sent OK -> 2 part get temp. error -> you put it into global queue for resend -> 2 part sent via SMSC-B -> handset rejects it

We have only two possibility here:
1) if temp error occurs put the _whole_ message into resend queue and resend then _all_ parts (very easy todo)
2) remember smsc which was used for first parts and resend it via the same smsc (complicated but save money :) )

Thanks,
Alexander Malysh

Am 16.12.2009 um 18:17 schrieb Konstantin Vayner:

Bug report: http://redmine.kannel.org/issues/show/529

Quote from gw/bb_smscconn.c :

static void handle_split(SMSCConn *conn, Msg *msg, long reason)
{
    struct split_parts *split = msg->sms.split_parts;

    /*
     * If temporarely failed, try again immediately but only if connection active.
     * Because if connection is not active we will loop for ever here consuming 100% CPU
     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
     */
    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
        smscconn_send(conn, msg) == 0) {
        /* destroy this message because it will be duplicated in smsc module */
        msg_destroy(msg);
        return;
    }

(end quote)

So, if an smsc is alive and throws temporary error every time you try to submit such a message, we enter endless loop of attempting to resend it....

Suggested patch follows (also attached).
Sorry its not cvs diff - having firewall issues accessing pserver now so i ran diff vs snapshot generated yesterday
I will be able to produce a normal cvs diff tomorrow morning if it is needed

--- kannel-snapshot/gw/bb_smscconn.c    2009-11-15 16:12:28.000000000 +0200
+++ gateway-cvs/gw/bb_smscconn.c        2009-12-16 19:47:32.000000000 +0200
@@ -203,18 +203,6 @@
     struct split_parts *split = msg->sms.split_parts;

     /*
-     * If temporarely failed, try again immediately but only if connection active.
-     * Because if connection is not active we will loop for ever here consuming 100% CPU
-     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
-     */
-    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
-        smscconn_send(conn, msg) == 0) {
-        /* destroy this message because it will be duplicated in smsc module */
-        msg_destroy(msg);
-        return;
-    }
-
-    /*
      * if the reason is not a success and status is still success
      * then set status of a split to the reason.
      * Note: reason 'malformed','discarded' or 'rejected' has higher priority!
@@ -303,7 +291,7 @@

void bb_smscconn_send_failed(SMSCConn *conn, Msg *sms, int reason, Octstr *reply)
{
-    if (sms->sms.split_parts != NULL) {
+    if (reason != SMSCCONN_FAILED_TEMPORARILY && sms->sms.split_parts != NULL) {
         handle_split(conn, sms, reason);
         octstr_destroy(reply);
         return;

<bb_smscconn.diff>

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2009-12-17T01:43:55Z

so the best option would be to requeue the part via same smsc, right ?
cause requeueing all parts may also get extra messages to the handset despite it not being able to reconstruct (not to mention the extra money ;) )

On Thu, Dec 17, 2009 at 11:33 AM, Alexander Malysh <amalysh@...> wrote:

Hi,

unfortunately this will not work as expected (the rule is: _all_ parts if multipart message have to be send via the same SMSC)...

example:

SMSC-A -> splits (2 parts) -> 1 part sent OK -> 2 part get temp. error -> you put it into global queue for resend -> 2 part sent via SMSC-B -> handset rejects it

We have only two possibility here:
1) if temp error occurs put the _whole_ message into resend queue and resend then _all_ parts (very easy todo)
2) remember smsc which was used for first parts and resend it via the same smsc (complicated but save money :) )

Thanks,
Alexander Malysh

Am 16.12.2009 um 18:17 schrieb Konstantin Vayner:

Bug report: http://redmine.kannel.org/issues/show/529

Quote from gw/bb_smscconn.c :

static void handle_split(SMSCConn *conn, Msg *msg, long reason)
{
    struct split_parts *split = msg->sms.split_parts;

    /*
     * If temporarely failed, try again immediately but only if connection active.
     * Because if connection is not active we will loop for ever here consuming 100% CPU
     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
     */
    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
        smscconn_send(conn, msg) == 0) {
        /* destroy this message because it will be duplicated in smsc module */
        msg_destroy(msg);
        return;
    }

(end quote)

So, if an smsc is alive and throws temporary error every time you try to submit such a message, we enter endless loop of attempting to resend it....

Suggested patch follows (also attached).
Sorry its not cvs diff - having firewall issues accessing pserver now so i ran diff vs snapshot generated yesterday
I will be able to produce a normal cvs diff tomorrow morning if it is needed

--- kannel-snapshot/gw/bb_smscconn.c    2009-11-15 16:12:28.000000000 +0200
+++ gateway-cvs/gw/bb_smscconn.c        2009-12-16 19:47:32.000000000 +0200
@@ -203,18 +203,6 @@
     struct split_parts *split = msg->sms.split_parts;

     /*
-     * If temporarely failed, try again immediately but only if connection active.
-     * Because if connection is not active we will loop for ever here consuming 100% CPU
-     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
-     */
-    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
-        smscconn_send(conn, msg) == 0) {
-        /* destroy this message because it will be duplicated in smsc module */
-        msg_destroy(msg);
-        return;
-    }
-
-    /*
      * if the reason is not a success and status is still success
      * then set status of a split to the reason.
      * Note: reason 'malformed','discarded' or 'rejected' has higher priority!
@@ -303,7 +291,7 @@

void bb_smscconn_send_failed(SMSCConn *conn, Msg *sms, int reason, Octstr *reply)
{
-    if (sms->sms.split_parts != NULL) {
+    if (reason != SMSCCONN_FAILED_TEMPORARILY && sms->sms.split_parts != NULL) {
         handle_split(conn, sms, reason);
         octstr_destroy(reply);
         return;

<bb_smscconn.diff>

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2009-12-17T01:33:16Z

Hi,

unfortunately this will not work as expected (the rule is: _all_ parts if multipart message have to be send via the same SMSC)...

example:

SMSC-A -> splits (2 parts) -> 1 part sent OK -> 2 part get temp. error -> you put it into global queue for resend -> 2 part sent via SMSC-B -> handset rejects it

We have only two possibility here:

1) if temp error occurs put the _whole_ message into resend queue and resend then _all_ parts (very easy todo)

2) remember smsc which was used for first parts and resend it via the same smsc (complicated but save money :) )

Thanks,

Alexander Malysh

Am 16.12.2009 um 18:17 schrieb Konstantin Vayner:

Bug report: http://redmine.kannel.org/issues/show/529

Quote from gw/bb_smscconn.c :

static void handle_split(SMSCConn *conn, Msg *msg, long reason)
{
    struct split_parts *split = msg->sms.split_parts;

    /*
     * If temporarely failed, try again immediately but only if connection active.
     * Because if connection is not active we will loop for ever here consuming 100% CPU
     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
     */
    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
        smscconn_send(conn, msg) == 0) {
        /* destroy this message because it will be duplicated in smsc module */
        msg_destroy(msg);
        return;
    }

(end quote)

So, if an smsc is alive and throws temporary error every time you try to submit such a message, we enter endless loop of attempting to resend it....

Suggested patch follows (also attached).
Sorry its not cvs diff - having firewall issues accessing pserver now so i ran diff vs snapshot generated yesterday
I will be able to produce a normal cvs diff tomorrow morning if it is needed

--- kannel-snapshot/gw/bb_smscconn.c    2009-11-15 16:12:28.000000000 +0200
+++ gateway-cvs/gw/bb_smscconn.c        2009-12-16 19:47:32.000000000 +0200
@@ -203,18 +203,6 @@
     struct split_parts *split = msg->sms.split_parts;

     /*
-     * If temporarely failed, try again immediately but only if connection active.
-     * Because if connection is not active we will loop for ever here consuming 100% CPU
-     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
-     */
-    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
-        smscconn_send(conn, msg) == 0) {
-        /* destroy this message because it will be duplicated in smsc module */
-        msg_destroy(msg);
-        return;
-    }
-
-    /*
      * if the reason is not a success and status is still success
      * then set status of a split to the reason.
      * Note: reason 'malformed','discarded' or 'rejected' has higher priority!
@@ -303,7 +291,7 @@

void bb_smscconn_send_failed(SMSCConn *conn, Msg *sms, int reason, Octstr *reply)
{
-    if (sms->sms.split_parts != NULL) {
+    if (reason != SMSCCONN_FAILED_TEMPORARILY && sms->sms.split_parts != NULL) {
         handle_split(conn, sms, reason);
         octstr_destroy(reply);
         return;

<bb_smscconn.diff>

dlr_sdb fixes (?)

2009-12-16T10:02:47Z

I noticed that some commit to CVS after 1.4.3 incorporated checking like
this in dlr_sdb.c:

if (state == -1)
error(0, "SDB: error in inserting DLR for DST <%s>",
octstr_get_cstr(dlr->destination));
else if (!state)
warning(0, "SDB: No dlr inserted for DST <%s>",
octstr_get_cstr(dlr->destination));

The -1 part is obviously sane, however it is perfectly legal for sdb to
return 0 for a number of actions, depending on the back-end database,
e.g. INSERT, UPDATE and DELETE to sqlite return 0 even though the
operation does complete successfully.
The warning message is a little ominous and not explanatory at all.
I don't have any other database to check against right now, but would we
mind altering the message/lowering the severity a little ?

Best Regards,
Thanos Chatziathanassiou

[PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2009-12-16T09:17:31Z

Bug report: http://redmine.kannel.org/issues/show/529

Quote from gw/bb_smscconn.c :

static void handle_split(SMSCConn *conn, Msg *msg, long reason)
{
    struct split_parts *split = msg->sms.split_parts;

    /*
     * If temporarely failed, try again immediately but only if connection active.
     * Because if connection is not active we will loop for ever here consuming 100% CPU
     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
     */
    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
        smscconn_send(conn, msg) == 0) {
        /* destroy this message because it will be duplicated in smsc module */
        msg_destroy(msg);
        return;
    }

(end quote)

So, if an smsc is alive and throws temporary error every time you try to submit such a message, we enter endless loop of attempting to resend it....

Suggested patch follows (also attached).
Sorry its not cvs diff - having firewall issues accessing pserver now so i ran diff vs snapshot generated yesterday
I will be able to produce a normal cvs diff tomorrow morning if it is needed

--- kannel-snapshot/gw/bb_smscconn.c    2009-11-15 16:12:28.000000000 +0200
+++ gateway-cvs/gw/bb_smscconn.c        2009-12-16 19:47:32.000000000 +0200
@@ -203,18 +203,6 @@
     struct split_parts *split = msg->sms.split_parts;

     /*
-     * If temporarely failed, try again immediately but only if connection active.
-     * Because if connection is not active we will loop for ever here consuming 100% CPU
-     * time due to internal queue cleanup in smsc module that call bb_smscconn_failed.
-     */
-    if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE &&
-        smscconn_send(conn, msg) == 0) {
-        /* destroy this message because it will be duplicated in smsc module */
-        msg_destroy(msg);
-        return;
-    }
-
-    /*
      * if the reason is not a success and status is still success
      * then set status of a split to the reason.
      * Note: reason 'malformed','discarded' or 'rejected' has higher priority!
@@ -303,7 +291,7 @@

void bb_smscconn_send_failed(SMSCConn *conn, Msg *sms, int reason, Octstr *reply)
{
-    if (sms->sms.split_parts != NULL) {
+    if (reason != SMSCCONN_FAILED_TEMPORARILY && sms->sms.split_parts != NULL) {
         handle_split(conn, sms, reason);
         octstr_destroy(reply);
         return;

[bb_smscconn.diff]

--- kannel-snapshot/gw/bb_smscconn.c 2009-11-15 16:12:28.000000000 +0200 +++ gateway-cvs/gw/bb_smscconn.c 2009-12-16 19:47:32.000000000 +0200 @@ -203,18 +203,6 @@ struct split_parts *split = msg->sms.split_parts; /* - * If temporarely failed, try again immediately but only if connection active. - * Because if connection is not active we will loop for ever here consuming 100% CPU - * time due to internal queue cleanup in smsc module that call bb_smscconn_failed. - */ - if (reason == SMSCCONN_FAILED_TEMPORARILY && smscconn_status(conn) == SMSCCONN_ACTIVE && - smscconn_send(conn, msg) == 0) { - /* destroy this message because it will be duplicated in smsc module */ - msg_destroy(msg); - return; - } - - /* * if the reason is not a success and status is still success * then set status of a split to the reason. * Note: reason 'malformed','discarded' or 'rejected' has higher priority! @@ -303,7 +291,7 @@ void bb_smscconn_send_failed(SMSCConn *conn, Msg *sms, int reason, Octstr *reply) { - if (sms->sms.split_parts != NULL) { + if (reason != SMSCCONN_FAILED_TEMPORARILY && sms->sms.split_parts != NULL) { handle_split(conn, sms, reason); octstr_destroy(reply); return;

Re: Is there any Kannel Version for .Net?

2009-12-14T09:14:32Z

Yo Stipe,

I used to see a few mails about Cygwin and pthreads ~6 months ago. These
have stopped. Besides i have come across a few mails from cygwin people
asking about URL encoding and queues. I didn't ask specifically, but it
seems that Cygwin has fixed their pthreads issues...

BR,
Nikos
----- Original Message -----
From: "Stipe Tolj" <st@...>
Cc: <devel@...>
Sent: Monday, December 14, 2009 6:40 PM
Subject: Re: Is there any Kannel Version for .Net?

> Nikos Balkanas schrieb:
>> Nope. Your best bet is cygwin.
>
> which is NOT production stable, due to some internal issues with the
> pthreads
> library of Cygwin.
>
> Stipe
>
> --
> -------------------------------------------------------------------
> KΓ¶lner Landstrasse 419
> 40589 DΓΌsseldorf, NRW, Germany
>
> tolj.org system architecture Kannel Software Foundation (KSF)
> http://www.tolj.org/ http://www.kannel.org/
>
> mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------
>

Re: Is there any Kannel Version for .Net?

2009-12-14T08:41:04Z

Guillaume Cottenceau schrieb:
> مدثر حسن <mudasserhassan 'at' gmail.com> writes:
>
>> Dear,
>>
>> Is there any Kannel versions for Microsoft .Net Framework 2.0 or above running
>> on Microsoft Windows XP/Vista? If yes then please provide me the link to
>> download it and also its guide about how to install and use?
>
> lol

well, good things are requested for every place ;)

Stipe

--
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture Kannel Software Foundation (KSF)
http://www.tolj.org/ http://www.kannel.org/

mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------

Re: Is there any Kannel Version for .Net?

2009-12-14T08:40:12Z

Nikos Balkanas schrieb:
> Nope. Your best bet is cygwin.

which is NOT production stable, due to some internal issues with the pthreads
library of Cygwin.

Stipe

--
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture Kannel Software Foundation (KSF)
http://www.tolj.org/ http://www.kannel.org/

mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------

Re: Is there any Kannel Version for .Net?

2009-12-14T06:48:01Z

Nope. Your best bet is cygwin.

BR,

Nikos

----- Original Message -----

From: mudasserhassan@...

To: devel@...

Sent: Monday, December 14, 2009 12:33 PM

Subject: Is there any Kannel Version for .Net?

Dear,

Is there any Kannel versions for Microsoft .Net Framework 2.0 or above running on Microsoft Windows XP/Vista? If yes then please provide me the link to download it and also its guide about how to install and use?

Thank You,
Mudasser Hassan

Re: DLR counters on the status page

2009-12-14T05:16:04Z

Hi alejandro,

Could we expect this patch soon ?

Vincent.

Alejandro Guerrieri a écrit :

> I guess what Vincent means is that short_open_tag may be removed
> completely at future versions, and in fact right now it's not
> recommended at all because it might be disabled on some installations.
>
> I'll commit a patch with those fixes and also a couple color changes
> Vincent also suggested.
>
> Regards,
> --
> Alejandro Guerrieri
> aguerrieri@...
>
>
>
> On 26/11/2009, at 11:00, Andreas Fink wrote:
>
>> php version >= 6.0??
>> thats not existing yet.
>>
>>
>> On 25.11.2009, at 14:37, Vincent CHAVANIS wrote:
>>
>>> Hi,
>>>
>>> You have short_open_tag "<?" on index.php & xmltoarray.php
>>> And *shouldn't* be like this as described in the php guidelines
>>> for further php releases (eg. >= php 6.0)
>>>
>>> Could you please fix this asap?
>>>
>>> Then, i think we have to make a default working config
>>> for people who just want to quickly test this contrib.
>>>
>>> $configs = array(
>>> array( "base_url" => "http://127.0.0.1:13000",
>>> "status_passwd" => "foo",
>>> "admin_passwd" => "bar",
>>> "name" => "Kannel default"
>>> ),
>>> );
>>>
>>> Also, you can also credit yourself ;-)
>>> as you re-wrote the script.
>>>
>>> Thanks
>>>
>>> Vincent.
>>>
>>>
>>> Alejandro Guerrieri a écrit :
>>>> Commited to CVS.
>>>> Regards,
>>>> --
>>>> Alejandro Guerrieri
>>>> aguerrieri@...
>>>> On 24/11/2009, at 12:14, Alexander Malysh wrote:
>>>>> Alex, could you please commit this patch?
>>>>>
>>>>> Thanks,
>>>>> Alexander Malysh
>>>>>
>>>>> Am 17.11.2009 um 20:40 schrieb Alejandro Guerrieri:
>>>>>
>>>>>> Please find a zip with the full folder attached.
>>>>>>
>>>>>> It's almost a full code rewrite, with lots of changes on the code
>>>>>> structure and UI as well, apart from support for the dlr fields.
>>>>>>
>>>>>> I'm working on a completely new, "ajaxified" version as well, stay
>>>>>> tuned ;)
>>>>>>
>>>>>> Regards,
>>>>>> --
>>>>>> Alejandro Guerrieri
>>>>>> aguerrieri@...
>>>>>>
>>>>>> <kannel-monitor.zip>
>>>>>> On 15/11/2009, at 15:44, Alexander Malysh wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> @Alex: any news about kannel-monitor patch?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Alexander Malysh
>>>>>>>
>>>>>>> Am 11.11.2009 um 19:47 schrieb Alejandro Guerrieri:
>>>>>>>
>>>>>>>> Working on it already, it'll be ready for tomorrow probably.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> --
>>>>>>>> Alejandro Guerrieri
>>>>>>>> aguerrieri@...
>>>>>>>>
>>>
>>>
>>
>>
>>
>
>
>

--
Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
Service Technique/Reseau - NOC
Direction du Developpement xMS+
http://www.telemaque.fr/
v.chavanis@...
Tel : +33 4 92 90 99 84 (fax 9142)

Re: Is there any Kannel Version for .Net?

2009-12-14T02:55:05Z

مدثر حسن <mudasserhassan 'at' gmail.com> writes:

> Dear,
>
> Is there any Kannel versions for Microsoft .Net Framework 2.0 or above running
> on Microsoft Windows XP/Vista? If yes then please provide me the link to
> download it and also its guide about how to install and use?

lol

--
Guillaume Cottenceau

Is there any Kannel Version for .Net?

2009-12-14T02:33:23Z

Dear,

Is there any Kannel versions for Microsoft .Net Framework 2.0 or above running on Microsoft Windows XP/Vista? If yes then please provide me the link to download it and also its guide about how to install and use?

Thank You,
Mudasser Hassan

Re: 2009-12-07 Stipe Tolj - gw/smsc/smsc_emi.c: fix segmentation fault

2009-12-09T04:22:58Z

Vincent CHAVANIS schrieb:
> +2009-12-07 Stipe Tolj <stolj at kannel.org>
> + * gw/smsc/smsc_emi.c: fix segmentation fault in case we jump via goto
> + error in smsc_emi2_create(), but have yet no privdata created.
>
> nice catch!

;) ... well, there was a specific EMI smsc group (multiple times) config WITHOUT
smsc-[username|password] but with with same inbound port, which revealed it. So
pure coincidence this time.

Stipe

--
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture Kannel Software Foundation (KSF)
http://www.tolj.org/ http://www.kannel.org/

mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------

2009-12-07 Stipe Tolj - gw/smsc/smsc_emi.c: fix segmentation fault

2009-12-09T02:50:57Z

+2009-12-07 Stipe Tolj <stolj at kannel.org>
+ * gw/smsc/smsc_emi.c: fix segmentation fault in case we jump via goto
+ error in smsc_emi2_create(), but have yet no privdata created.

nice catch!

Vincent.

Re: interface to configure kannel

2009-12-08T00:57:48Z

thanks for your answers ,
if there is no software or web interface to configure kannel then i have to develop a web interface for my application to do the configuration ,
i wish you can help me with your ideas and answers
thak you any way.

2009/12/7 Juan Nin <juanin@...>

there used to be a webmin module, but I guess it's very outdated, and
it's link is broken

On Mon, Dec 7, 2009 at 2:44 PM, Alvaro Cornejo <cornejo.alvaro@...> wrote:
> There is none
>
> You only have a monitoring web interface that allows you to control
> start/stop of smsc but don't any config
>
>
> |-----------------------------------------------------------------------------------------------------------------|
> Envíe y Reciba Datos y mensajes de Texto (SMS) hacia y desde cualquier
> celular y Nextel
> en el Perú, México y en mas de 180 paises. Use aplicaciones 2 vias via
> SMS y GPRS online
> Visitenos en www.perusms.NET www.smsglobal.com.mx y
> www.pravcom.com
>
>
>
> On Sat, Dec 5, 2009 at 12:34 PM, emocanos <emocanos87@...> wrote:
>>
>> Hi,
>> I am still a new bie to Kannel.
>> I am looking for a web interface to configure kannel .
>> Can You help me to solve this issue?
>> --
>> View this message in context: http://old.nabble.com/interface-to-configure-kannel-tp26657557p26657557.html
>> Sent from the Kannel - Dev mailing list archive at Nabble.com.
>>
>>
>>
>
>

--
Juan Nin
3Cinteractive / Mobilizing Great Brands
http://www.3cinteractive.com

Re: interface to configure kannel

2009-12-07T13:56:59Z

there used to be a webmin module, but I guess it's very outdated, and
it's link is broken

On Mon, Dec 7, 2009 at 2:44 PM, Alvaro Cornejo <cornejo.alvaro@...> wrote:

> There is none
>
> You only have a monitoring web interface that allows you to control
> start/stop of smsc but don't any config
>
>
> |-----------------------------------------------------------------------------------------------------------------|
> Envíe y Reciba Datos y mensajes de Texto (SMS) hacia y desde cualquier
> celular y Nextel
> en el Perú, México y en mas de 180 paises. Use aplicaciones 2 vias via
> SMS y GPRS online
> Visitenos en www.perusms.NET www.smsglobal.com.mx y
> www.pravcom.com
>
>
>
> On Sat, Dec 5, 2009 at 12:34 PM, emocanos <emocanos87@...> wrote:
>>
>> Hi,
>> I am still a new bie to Kannel.
>> I am looking for a web interface to configure kannel .
>> Can You help me to solve this issue?
>> --
>> View this message in context: http://old.nabble.com/interface-to-configure-kannel-tp26657557p26657557.html
>> Sent from the Kannel - Dev mailing list archive at Nabble.com.
>>
>>
>>
>
>

--
Juan Nin
3Cinteractive / Mobilizing Great Brands
http://www.3cinteractive.com

Re: interface to configure kannel

2009-12-07T11:44:45Z

There is none

You only have a monitoring web interface that allows you to control
start/stop of smsc but don't any config

|-----------------------------------------------------------------------------------------------------------------|
Envíe y Reciba Datos y mensajes de Texto (SMS) hacia y desde cualquier
celular y Nextel
en el Perú, México y en mas de 180 paises. Use aplicaciones 2 vias via
SMS y GPRS online
Visitenos en www.perusms.NET www.smsglobal.com.mx y
www.pravcom.com

On Sat, Dec 5, 2009 at 12:34 PM, emocanos <emocanos87@...> wrote:

>
> Hi,
> I am still a new bie to Kannel.
> I am looking for a web interface to configure kannel .
> Can You help me to solve this issue?
> --
> View this message in context: http://old.nabble.com/interface-to-configure-kannel-tp26657557p26657557.html
> Sent from the Kannel - Dev mailing list archive at Nabble.com.
>
>
>

Re: Patch: http-timeout support

2009-12-07T00:43:31Z

Hi,

yes, timeout is not changed and is 240 sec. Don't worry userguide changed as well :)

Thanks,

Alexander Malysh

Am 06.12.2009 um 19:05 schrieb Nikos Balkanas:

Hi,

You mean that you left gwlib/http.c as before with default timeout to 240 s. Am I reading you correctly? In such case you should also modify userguide patch as well.

BR,
Nikos
----- Original Message -----
From: amalysh@...
To: nbalkanas@...
Cc: devel@...
Sent: Sunday, December 06, 2009 7:25 PM
Subject: Re: Patch: http-timeout support

Hi Nikos,

patch commited to cvs but I dropped part that changed default value.

Thanks,
Alexander Malysh

Am 03.12.2009 um 23:01 schrieb Nikos Balkanas:

Hi,

This patch adds configurable http-timeout support for outgoing http client connections. Patch provided for bearerbox, wapbox, smsbox & userguide.

BR,
Nikos
<kannel.diff>

Re: [PATCH] Meta Data on DLR's

2009-12-07T00:42:11Z

Hi,

ok I see the reason for dlr_status... but it's not dlr_status field that we forward...

should we rename it to cmd_status then ?

Thanks,

Alexander Malysh

Am 06.12.2009 um 20:58 schrieb Alejandro Guerrieri:

We added this because some users needed to get command_status values. See Dante Moreno's message on Aug 30 to user's list:

http://www.mail-archive.com/users@.../msg17067.html

I'm attaching the thread from devel list as well. You actually agreed to it then and suggested using the 0x%08lx format for it.

<Re: [PATCH] Pass meta-data from message to dlrs.eml>

Regards,

--
Alejandro Guerrieri
aguerrieri@...

On 06/12/2009, at 12:41, Alexander Malysh wrote:

Hi Alex,

sorry for delay...

Patch looks OK but I don't like this part:
+ if (msg->sms.meta_data == NULL)
+ msg->sms.meta_data = octstr_create("");
+ meta_data_set_value(msg->sms.meta_data, "smpp", octstr_imm("dlr_status"),
+ octstr_format("0x%08lx", pdu->u.submit_sm_resp.command_status), 1);

Why do you need to forward SMPP internal status to client? If all was fine and message was accepted it's always 0 and if
it was rejected you will receive errorcode in DLR msgdata field.
Therefore I don't really know why you need this part?

I'm +1 for this patch without dlr_status part.

Thanks,
Alexander Malysh

P.S. Don't forget to rebase your patch due to recent changes in dlr_pgsql.c :)

Am 05.11.2009 um 23:41 schrieb Alejandro Guerrieri:

This is an expanded version of a patch I've done a couple of months ago. It adds the following functionality and fix a few things in the process:

#1: Allows meta-data to be passed when sending a message to come back on the DLR's (internal, intermediate and final).

***COMPATIBILITY BREAKER***
A new "meta-data" field is needed on the DB table.
***COMPATIBILITY BREAKER***

This allows, for example, to set the dlr-url on the smsbox group and then pass extra parameters as meta-data (either on the ?smpp? group or you could even create your own, ?dlr? for example).

#2: It creates a meta data value called "dlr_status" that comes back on the internal dlr generated by kannel. The loaded value is the SMPP "command_status" parameter.

#3: It fixes/cleanup code on some dlr_<dbengine>.c, for example on many places %s was used inside octstr_format, and then octstr_get_cstr(var) was used, where using %S would be more direct:

- sql = octstr_format("DELETE FROM %s WHERE %s='%s' AND %s='%s' %s",
- octstr_get_cstr(fields->table),
- octstr_get_cstr(fields->field_smsc), octstr_get_cstr(smsc),
- octstr_get_cstr(fields->field_ts), octstr_get_cstr(ts), sdb_get_limit_str());

+ sql = octstr_format("DELETE FROM %S WHERE %S='%S' AND %S='%S' %s",
+ fields->table, fields->field_smsc, smsc,
+ fields->field_ts, ts, sdb_get_limit_str());

#4 There was also a "LIMIT 1" on dlr_sdb.c where sdb_get_limit_str() should be used instead.

Example usage:

On sendsms:

http://localhost:13013/cgi-bin/sendsms?username=kannel&password=kannel&from=12345&to=12345678&smsc=mysmsc&text=Hello&dlr-mask=31&meta-data=%3Fsmpp%3Fmy_own_field%3D1234&dlr-url=http%3A%2F%2Flocalhost%2Fx%3Fdata%3D%25D

Notes:

meta-data is urlencoded version of: ?smpp?my_own_field=1234
dlr-url is urlencoded version of: http://localhost/x?data=%D

So, after applying, kannel would call the following url:

http://localhost/x?md=%3Fsmpp%3Fmy_own_field%3D1234%26dlr_status%3D69%26

The "md" parameter, once urldecoded would look like:

?smpp?my_own_field=1234&dlr_status=69&

You can pass as many parameters as you want of course and they would be added to meta-data along with any other fields you've defined on your smpp-tlv groups, etc. You're not limited to ?smpp?, you can add your own meta-data groups to avoid possible conflicts.

Regarding the dlr_status, in this example gets loaded with submit_sm_resp's command_status which was: 69 = 0x00000045 (Submit Failed).

Please review, I'm writing the userguide part if it goes forward.

Regards,

--
Alejandro Guerrieri
aguerrieri@...

<kannel-dlr-meta-data.diff.zip>

Re: [PATCH] Meta Data on DLR's

2009-12-06T11:58:46Z

We added this because some users needed to get command_status values. See Dante Moreno's message on Aug 30 to user's list:

http://www.mail-archive.com/users@.../msg17067.html

I'm attaching the thread from devel list as well. You actually agreed to it then and suggested using the 0x%08lx format for it.

Ok, silly diff errors aside (I wasn't including dlr_p.h :P), here's the new patches also changing the error code format as Alex suggested.

Userguide patch coming later.

Just a few more ideas to consider:

1. Adding one more called "dlr_status_text" with the text description from smpp_error_to_string(pdu->u.submit_sm_resp.command_status). Not sure if it makes sense, this could be done at the application level with a simple table...

2. Adding one more called "dlr_sequence" with the sequence_number parameter.

3. Extending patch #1 adding the meta-data column on all DB implementations, so meta-data could be passed and stored on dlr's other than the first one generated by kannel.

Regards,

Alejandro Guerrieri

aguerrieri@...

On 03/09/2009, at 23:33, Alexander Malysh wrote:

Hi Alex,

first patch seems still broken:
+ dlr->meta_data = (msg->sms.meta_data ? octstr_duplicate(msg->sms.meta_data) : octstr_create(""));

we don't have meta_data in dlr struct. otherwise +1

second patch:
+ if (msg->sms.meta_data == NULL)
+ msg->sms.meta_data = octstr_create("");
+ meta_data_set_value(msg->sms.meta_data, "smpp", octstr_imm("dlr_status"),
+ octstr_format("%d", pdu->u.submit_sm_resp.command_status), 1);
+

Would it it not better to have error code formated as smpp-tlv group and as error message?
+ octstr_format("0x%08lx", pdu->u.submit_sm_resp.command_status), 1);

Thanks,
Alexander Malysh

Am 03.09.2009 um 21:13 schrieb Alejandro Guerrieri:

Oh, I see, I've attached the ~ backup file from vim. This are the right files, just in case:

<kannel-dlr-command-status.diff>
<kannel-dlr-meta-data.diff>

--
Alejandro Guerrieri
aguerrieri@...

On 03/09/2009, at 21:06, Alejandro Guerrieri wrote:

Oh, that must have filtered into the patch. Weird :P

Sorry, it's safe to remove it.

Regards,

--
Alejandro Guerrieri
aguerrieri@...

On 03/09/2009, at 20:56, Gustavo Mohme C. wrote:

Hi Alejandro,
I get this error after applying your patch.

gw/dlr.c: In function ‘dlr_add’:
gw/dlr.c:352: error: ‘struct dlr_entry’ has no member named ‘meta_data’
make: *** [gw/dlr.o] Error 1

After editing /gw/dlr_p.h and adding meta_data to the struct dlr_entry, it compiled with no complaints. Is this the correct thing to do?
I was patching the latest kannel snapshot....
Thanks,
Gustavo

On Thu, Sep 3, 2009 at 3:39 AM, Alejandro Guerrieri <aguerrieri@...> wrote:

Hi,

This is a set of two patches, though they're both very simple and could have been mixed, I've preferred to split to honor the rule of not mixing features in a single patch.

Patch #1, kannel-drl-meta-data.diff allows meta-data to be passed when sending a message to come back into the "fake" dlr that kannel generates when the smsc accepts or rejects a message. It could be extended to work with the different dlr engines so the meta-data would be also passed on the intermediate and final dlr's delivered by the carriers (though it would require changes on the database structure to add a "meta_data" column of course. I'm not sure this would be needed, the dlr-url could be easily abused to pass application-specific parameters without much hassle.

Patch #2, kannel-dlr-command-status.diff builds on top of patch #1 and creates a meta data value called "dlr_status" that comes back on the "fake" dlr generated by kannel (This was the real reason why patch #1 was created). The value there is the "command_status" value some people on the list needs to get from the submit_sm_resp PDU's.

Example usage:

On sendsms:

http://localhost:13013/cgi-bin/sendsms?username=kannel&password=kannel&from=12345&to=12345678&smsc=mysmsc&text=Hello&dlr-mask=31&meta-data=%3Fsmpp%3Fmy_own_field%3D1234&dlr-url=http%3A%2F%2Flocalhost%2Fx%3Fdata%3D%25D

Notes:

meta-data is urlencoded version of: ?smpp?my_own_field=1234
dlr-url is urlencoded version of: http://localhost/x?data=%D

So, after applying Patch #1, kannel would call the following url:

http://localhost/x?md=%3Fsmpp%3Fmy_own_field%3D1234

The "md" parameter, once urldecoded would look like:

?smpp?my_own_field=1234

You can pass as many parameters as you want of course and they would be added to meta-data along with any other fields you've defined on your smpp-tlv groups, etc.

So far so good, in fact you could pass this kind of stuff on regular url variables, but the goal of this patch was to allow to add stuff back from the smsc's response.

Now, with patch #2 also applied, the url returned would be something like this:

http://localhost/x?md=%3Fsmpp%3Fmy_own_field%3D1234%26dlr_status%3D69%26

The "md" parameter, once urldecoded would look like:

?smpp?my_own_field=1234&dlr_status=69&

In this case, dlr_status gets loaded with submit_sm_resp's command_status which was: 69 = 0x00000045 (Submit Failed).

The "sequence_number" could be added just as easily (not a bad idea imho). What do you think? "dlr_sequence" or "dlr_seq" would be ok?

I'm writing the userguide patch if this goes forward of course.

Comments?

Regards,
--
Alejandro Guerrieri
aguerrieri@...

Regards,

Alejandro Guerrieri

aguerrieri@...

On 06/12/2009, at 12:41, Alexander Malysh wrote:

Hi Alex,

sorry for delay...

Patch looks OK but I don't like this part:
+ if (msg->sms.meta_data == NULL)
+ msg->sms.meta_data = octstr_create("");
+ meta_data_set_value(msg->sms.meta_data, "smpp", octstr_imm("dlr_status"),
+ octstr_format("0x%08lx", pdu->u.submit_sm_resp.command_status), 1);

Why do you need to forward SMPP internal status to client? If all was fine and message was accepted it's always 0 and if
it was rejected you will receive errorcode in DLR msgdata field.
Therefore I don't really know why you need this part?

I'm +1 for this patch without dlr_status part.

Thanks,
Alexander Malysh

P.S. Don't forget to rebase your patch due to recent changes in dlr_pgsql.c :)

Am 05.11.2009 um 23:41 schrieb Alejandro Guerrieri:

This is an expanded version of a patch I've done a couple of months ago. It adds the following functionality and fix a few things in the process:

#1: Allows meta-data to be passed when sending a message to come back on the DLR's (internal, intermediate and final).

***COMPATIBILITY BREAKER***
A new "meta-data" field is needed on the DB table.
***COMPATIBILITY BREAKER***

This allows, for example, to set the dlr-url on the smsbox group and then pass extra parameters as meta-data (either on the ?smpp? group or you could even create your own, ?dlr? for example).

#2: It creates a meta data value called "dlr_status" that comes back on the internal dlr generated by kannel. The loaded value is the SMPP "command_status" parameter.

#3: It fixes/cleanup code on some dlr_<dbengine>.c, for example on many places %s was used inside octstr_format, and then octstr_get_cstr(var) was used, where using %S would be more direct:

- sql = octstr_format("DELETE FROM %s WHERE %s='%s' AND %s='%s' %s",
- octstr_get_cstr(fields->table),
- octstr_get_cstr(fields->field_smsc), octstr_get_cstr(smsc),
- octstr_get_cstr(fields->field_ts), octstr_get_cstr(ts), sdb_get_limit_str());

+ sql = octstr_format("DELETE FROM %S WHERE %S='%S' AND %S='%S' %s",
+ fields->table, fields->field_smsc, smsc,
+ fields->field_ts, ts, sdb_get_limit_str());

#4 There was also a "LIMIT 1" on dlr_sdb.c where sdb_get_limit_str() should be used instead.

Example usage:

On sendsms:

http://localhost:13013/cgi-bin/sendsms?username=kannel&password=kannel&from=12345&to=12345678&smsc=mysmsc&text=Hello&dlr-mask=31&meta-data=%3Fsmpp%3Fmy_own_field%3D1234&dlr-url=http%3A%2F%2Flocalhost%2Fx%3Fdata%3D%25D

Notes:

meta-data is urlencoded version of: ?smpp?my_own_field=1234
dlr-url is urlencoded version of: http://localhost/x?data=%D

So, after applying, kannel would call the following url:

http://localhost/x?md=%3Fsmpp%3Fmy_own_field%3D1234%26dlr_status%3D69%26

The "md" parameter, once urldecoded would look like:

?smpp?my_own_field=1234&dlr_status=69&

You can pass as many parameters as you want of course and they would be added to meta-data along with any other fields you've defined on your smpp-tlv groups, etc. You're not limited to ?smpp?, you can add your own meta-data groups to avoid possible conflicts.

Regarding the dlr_status, in this example gets loaded with submit_sm_resp's command_status which was: 69 = 0x00000045 (Submit Failed).

Please review, I'm writing the userguide part if it goes forward.

Regards,

--
Alejandro Guerrieri
aguerrieri@...

<kannel-dlr-meta-data.diff.zip>

kannel-dlr-meta-data.diff (1K) Download Attachment
kannel-dlr-command-status.diff (923 bytes) Download Attachment

Re: Patch: http-timeout support

2009-12-06T10:05:40Z

Hi,

You mean that you left gwlib/http.c as before with default timeout to 240 s. Am I reading you correctly? In such case you should also modify userguide patch as well.

BR,

Nikos

----- Original Message -----

From: amalysh@...

To: nbalkanas@...

Cc: devel@...

Sent: Sunday, December 06, 2009 7:25 PM

Subject: Re: Patch: http-timeout support

Hi Nikos,

patch commited to cvs but I dropped part that changed default value.

Thanks,

Alexander Malysh

Am 03.12.2009 um 23:01 schrieb Nikos Balkanas:

Hi,

This patch adds configurable http-timeout support for outgoing http client connections. Patch provided for bearerbox, wapbox, smsbox & userguide.

BR,

Nikos
<kannel.diff>

Re: [PATCH] Meta Data on DLR's

2009-12-06T09:41:15Z

Hi Alex,

sorry for delay...

Patch looks OK but I don't like this part:

+ if (msg->sms.meta_data == NULL)

+ msg->sms.meta_data = octstr_create("");

+ meta_data_set_value(msg->sms.meta_data, "smpp", octstr_imm("dlr_status"),

+ octstr_format("0x%08lx", pdu->u.submit_sm_resp.command_status), 1);

Why do you need to forward SMPP internal status to client? If all was fine and message was accepted it's always 0 and if

it was rejected you will receive errorcode in DLR msgdata field.

Therefore I don't really know why you need this part?

I'm +1 for this patch without dlr_status part.

Thanks,

Alexander Malysh

P.S. Don't forget to rebase your patch due to recent changes in dlr_pgsql.c :)

Am 05.11.2009 um 23:41 schrieb Alejandro Guerrieri:

This is an expanded version of a patch I've done a couple of months ago. It adds the following functionality and fix a few things in the process:

#1: Allows meta-data to be passed when sending a message to come back on the DLR's (internal, intermediate and final).

***COMPATIBILITY BREAKER***
A new "meta-data" field is needed on the DB table.
***COMPATIBILITY BREAKER***

This allows, for example, to set the dlr-url on the smsbox group and then pass extra parameters as meta-data (either on the ?smpp? group or you could even create your own, ?dlr? for example).

#2: It creates a meta data value called "dlr_status" that comes back on the internal dlr generated by kannel. The loaded value is the SMPP "command_status" parameter.

#3: It fixes/cleanup code on some dlr_<dbengine>.c, for example on many places %s was used inside octstr_format, and then octstr_get_cstr(var) was used, where using %S would be more direct:

- sql = octstr_format("DELETE FROM %s WHERE %s='%s' AND %s='%s' %s",
- octstr_get_cstr(fields->table),
- octstr_get_cstr(fields->field_smsc), octstr_get_cstr(smsc),
- octstr_get_cstr(fields->field_ts), octstr_get_cstr(ts), sdb_get_limit_str());

+ sql = octstr_format("DELETE FROM %S WHERE %S='%S' AND %S='%S' %s",
+ fields->table, fields->field_smsc, smsc,
+ fields->field_ts, ts, sdb_get_limit_str());

#4 There was also a "LIMIT 1" on dlr_sdb.c where sdb_get_limit_str() should be used instead.

Example usage:

On sendsms:

http://localhost:13013/cgi-bin/sendsms?username=kannel&password=kannel&from=12345&to=12345678&smsc=mysmsc&text=Hello&dlr-mask=31&meta-data=%3Fsmpp%3Fmy_own_field%3D1234&dlr-url=http%3A%2F%2Flocalhost%2Fx%3Fdata%3D%25D

Notes:

meta-data is urlencoded version of: ?smpp?my_own_field=1234
dlr-url is urlencoded version of: http://localhost/x?data=%D

So, after applying, kannel would call the following url:

http://localhost/x?md=%3Fsmpp%3Fmy_own_field%3D1234%26dlr_status%3D69%26

The "md" parameter, once urldecoded would look like:

?smpp?my_own_field=1234&dlr_status=69&

You can pass as many parameters as you want of course and they would be added to meta-data along with any other fields you've defined on your smpp-tlv groups, etc. You're not limited to ?smpp?, you can add your own meta-data groups to avoid possible conflicts.

Regarding the dlr_status, in this example gets loaded with submit_sm_resp's command_status which was: 69 = 0x00000045 (Submit Failed).

Please review, I'm writing the userguide part if it goes forward.

Regards,

--
Alejandro Guerrieri
aguerrieri@...

<kannel-dlr-meta-data.diff.zip>

Re: Munin plugin

2009-12-06T09:28:07Z

Hi,

I don't know of any munin plugin. If you write one and post it then we will happily add it to contrib.

Thanks,
Alexander Malysh

Am 18.11.2009 um 09:56 schrieb Rolandow:

> Hi all,
>
> I was wondering if there exists a Munin plugin for Kannel? The plugin's are really easy to write, so I guess it would be quite simple for the experienced developers in here, and I can imagine that I'm not the first one who would like this plugin?
>
> So is there some patch or extension available for this?
>
> If not, I just solve it in my PHP scripts... :-)
>
> Thanks!
>
> Kind regards,
> Roland.
>

Re: Patch: http-timeout support

2009-12-06T09:25:27Z

Hi Nikos,

patch commited to cvs but I dropped part that changed default value.

Thanks,

Alexander Malysh

Am 03.12.2009 um 23:01 schrieb Nikos Balkanas:

Hi,

This patch adds configurable http-timeout support for outgoing http client connections. Patch provided for bearerbox, wapbox, smsbox & userguide.

BR,
Nikos
<kannel.diff>

interface to configure kannel

2009-12-05T09:34:34Z

Hi,
I am still a new bie to Kannel.
I am looking for a web interface to configure kannel .
Can You help me to solve this issue?

interface to configure kannel

2009-12-05T09:34:16Z

Hi,
I am still a new bie to Kannel.
I am looking for a web interface to configure kannel .
Can You help me to solve this issue?

Patch: http-timeout support

2009-12-03T14:01:54Z

Hi,

This patch adds configurable http-timeout support for outgoing http client connections. Patch provided for bearerbox, wapbox, smsbox & userguide.

BR,

Nikos

kannel.diff (6K) Download Attachment

Re: Does Kannel Support IA5

2009-12-03T08:56:49Z

Why not simply use UTF-8 as the character set to submit? Kannel converts it to the GSM character set when possible or to UCS2.

On 03.12.2009, at 16:52, Hillel wrote:

Hi,

We are using SMPP version 3.4 with Kannel CVS and Centos and for one operator they require the IA5 character set.
Kannel is giving the following error:

2009-12-02 17:51:43 [2547] [23] ERROR: Failed to convert string from <UTF-8> to <IA5> - probably broken type names.
2009-12-02 17:51:43 [2547] [23] ERROR: Failed to convert msgdata from charset <UTF-8> to <IA5>, will send as is.

Would developers recommend using ASCII as the charset even though it not exactly the same?
Or is there any other way?

thanks

Does Kannel Support IA5

2009-12-03T07:52:06Z

Hi,

We are using SMPP version 3.4 with Kannel CVS and Centos and for one operator they require the IA5 character set.

Kannel is giving the following error:

2009-12-02 17:51:43 [2547] [23] ERROR: Failed to convert string from <UTF-8> to <IA5> - probably broken type names.

2009-12-02 17:51:43 [2547] [23] ERROR: Failed to convert msgdata from charset <UTF-8> to <IA5>, will send as is.

Would developers recommend using ASCII as the charset even though it not exactly the same?

Or is there any other way?

thanks