Knop form html encoding output?

[Jolle Carlestam-3]

Is there a change done in Knop somewhere along the line that html  
encodes label output in the form object.

This used to work and still does on one older server. But on a newer  
installation it's html encoded.

        $fContact -> addfield(
                        -type = 'text',
                        -name = 'addon_1_infitem',
                        -dbfield = '',
                        -label = '<img src="/jina_img/plus.gif"  
id="addon_1_infselect_button" type="button" class="addbtn" title="' +  
($lang_messages -> addNewItemMsg) + '" alt="' + ($lang_messages ->  
addNewItemMsg) + '" border="0" height="15" width="15">',
                        -size = 35);


HDB
Jolle

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Steve Piercy]

In the form.inc notes:

2007-02-23  JS  Removed encode_html from form field labels

So you could either modify form.inc or not use HTML in your label and instead loop through all the fields and do a regular expression to find and replace </label> with your stuff + </label>.

It looks like you're trying to insert some tooltip stuff, yes?

--steve


On Wednesday, July 22, 2009, list@... pronounced:

>Is there a change done in Knop somewhere along the line that html  
>encodes label output in the form object.
>
>This used to work and still does on one older server. But on a newer  
>installation it's html encoded.
>
>   $fContact -> addfield(
>           -type = 'text',
>           -name = 'addon_1_infitem',
>           -dbfield = '',
>           -label = '<img src="/jina_img/plus.gif"  
>id="addon_1_infselect_button" type="button" class="addbtn" title="' +  
>($lang_messages -> addNewItemMsg) + '" alt="' + ($lang_messages ->  
>addNewItemMsg) + '" border="0" height="15" width="15">',
>           -size = 35);
>
>
>HDB
>Jolle
>

-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Steve Piercy               Web Site Builder               Soquel, CA
<web@...>                  <http://www.StevePiercy.com/>

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Jolle Carlestam-3]

22 jul 2009 kl. 16.21 skrev Steve Piercy - Web Site Builder:

>
> In the form.inc notes:
>
> 2007-02-23  JS  Removed encode_html from form field labels

This indicates the opposite. Prior to feb 2007 the labels where  
encoded but not after that so it should work now. Anyway both the  
working version of Knop form and the non working are from after that  
date.

The working 2008-05-06. The non working 2009-01-08.

> So you could either modify form.inc or not use HTML in your label  
> and instead loop through all the fields and do a regular expression  
> to find and replace </label> with your stuff + </label>.

I'm reengineering form as we write to see where it happens.

> It looks like you're trying to insert some tooltip stuff, yes?

Na, it's part of a dynamic form where the user can click on a plus  
sign to add another item in the form. Like in this case an extra phone  
number or e-mail address.

When it's working...

HDB
Jolle

>
> --steve
>
>
> On Wednesday, July 22, 2009, list@... pronounced:
>
>> Is there a change done in Knop somewhere along the line that html
>> encodes label output in the form object.
>>
>> This used to work and still does on one older server. But on a newer
>> installation it's html encoded.
>>
>>  $fContact -> addfield(
>>          -type = 'text',
>>          -name = 'addon_1_infitem',
>>          -dbfield = '',
>>          -label = '<img src="/jina_img/plus.gif"
>> id="addon_1_infselect_button" type="button" class="addbtn" title="' +
>> ($lang_messages -> addNewItemMsg) + '" alt="' + ($lang_messages ->
>> addNewItemMsg) + '" border="0" height="15" width="15">',
>>          -size = 35);
>>
>>
>> HDB
>> Jolle
>>
>
> -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> Steve Piercy               Web Site Builder               Soquel, CA
> <web@...>                  <http://www.StevePiercy.com/>
>
> --
> #############################################################
> This message is sent to you because you are subscribed to
> the mailing list <knop@...>.
> To unsubscribe, E-mail to: <knop-off@...>
> Send administrative queries to  <knop-request@...>
> List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
> Project homepage http://montania.se/projects/knop/
> Google Code has the latest downloads at http://code.google.com/p/knop/

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Jolle Carlestam-3]

22 jul 2009 kl. 16.31 skrev list@...:

>> So you could either modify form.inc or not use HTML in your label
>> and instead loop through all the fields and do a regular expression
>> to find and replace </label> with your stuff + </label>.
>
> I'm reengineering form as we write to see where it happens.

I think this is where it happens:
Old:
'<label for="' + #id + '" ' + #errorclass + '>' + (#onefield -> (find:  
'label')) + '</label>');

New:
'<label for="' + #id + '" ' + #errorclass + '>' +  
encode_html(#onefield -> find('label')) + '</label>');


Johan put some encode_html on other places nearby too. The fix is  
easy. But could be that Johan had a good reason for using encode_html.  
Perhaps some kind of protection against evil doers.
Hm, I wonder what.
I'll change it for the time being in my version.

HDB
Jolle

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Jolle Carlestam-3]

22 jul 2009 kl. 16.38 skrev list@...:

> Johan put some encode_html on other places nearby too. The fix is
> easy. But could be that Johan had a good reason for using encode_html.
> Perhaps some kind of protection against evil doers.
> Hm, I wonder what.
> I'll change it for the time being in my version.

Pending an enlightening mail from Johan telling us about why  
encode_html is so smart in this place I vote for not having it for  
labels. If it's there it prevents us from using images as labels.

HDB
Jolle

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Steve Piercy]

On Wednesday, July 22, 2009, list@... pronounced:

>> It looks like you're trying to insert some tooltip stuff, yes?
>
>Na, it's part of a dynamic form where the user can click on a plus  
>sign to add another item in the form. Like in this case an extra phone  
>number or e-mail address.
>
>When it's working...

The standards wonk in me gives you the hairy eyebrow.  I don't think that is how labels should be used.

http://www.w3.org/TR/html401/interact/forms.html#h-17.9

    The LABEL element may be used to attach information to controls.
    Each LABEL element is associated with exactly one form control.

Your widget does not attach information to the control (the input field), but instead adds a new control itself.  IMO, it should be placed after the input.

--steve

-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Steve Piercy               Web Site Builder               Soquel, CA
<web@...>                  <http://www.StevePiercy.com/>

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Steve Piercy]

On Wednesday, July 22, 2009, list@... pronounced:

>22 jul 2009 kl. 16.31 skrev list@...:
>
>>> So you could either modify form.inc or not use HTML in your label
>>> and instead loop through all the fields and do a regular expression
>>> to find and replace </label> with your stuff + </label>.
>>
>> I'm reengineering form as we write to see where it happens.
>
>I think this is where it happens:
>Old:
>'<label for="' + #id + '" ' + #errorclass + '>' + (#onefield -> (find:  
>'label')) + '</label>');
>
>New:
>'<label for="' + #id + '" ' + #errorclass + '>' +  
>encode_html(#onefield -> find('label')) + '</label>');
>
>
>Johan put some encode_html on other places nearby too. The fix is  
>easy. But could be that Johan had a good reason for using encode_html.  
>Perhaps some kind of protection against evil doers.
>Hm, I wonder what.
>I'll change it for the time being in my version.

Using my elementary powers of deduction, my dear Watson, it is likely to compensate for the removal of encode_html from the form.inc type.  ;)

Since you are the only person with control over the contents of the field label, are you an evildoer?

--steve

-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Steve Piercy               Web Site Builder               Soquel, CA
<web@...>                  <http://www.StevePiercy.com/>

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Jolle Carlestam-3]

22 jul 2009 kl. 17.08 skrev Steve Piercy - Web Site Builder:

>
> On Wednesday, July 22, 2009, list@... pronounced:
>
>>> It looks like you're trying to insert some tooltip stuff, yes?
>>
>> Na, it's part of a dynamic form where the user can click on a plus
>> sign to add another item in the form. Like in this case an extra  
>> phone
>> number or e-mail address.
>>
>> When it's working...
>
> The standards wonk in me gives you the hairy eyebrow.  I don't think  
> that is how labels should be used.
>
> http://www.w3.org/TR/html401/interact/forms.html#h-17.9
>
>    The LABEL element may be used to attach information to controls.
>    Each LABEL element is associated with exactly one form control.
>
> Your widget does not attach information to the control (the input  
> field), but instead adds a new control itself.  IMO, it should be  
> placed after the input.

Possibly. But if I want it to be created as part of the addfield tag  
in a form object I have few options. Putting it in the label is about  
it. The actual placement is then a matter of css. So from a user point  
of view it's not part of the label. I'll attach an example.




This shows a form where a user can add infinite number of interests,  
types or notes. Each time he clicks on a plus sign he'll get another  
select or text area box for that particular type of data. I could  
insert it in a more manual way in the content file by breaking up the  
renderform into smaller parts but this, when working, is more  
convenient.

HDB
Jolle
--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Jolle Carlestam-3]

22 jul 2009 kl. 17.13 skrev Steve Piercy - Web Site Builder:

> Since you are the only person with control over the contents of the  
> field label, are you an evildoer?

Usually only in regard to slugs in the garden. They definitely  
consider me pure evil.

HDB
Jolle

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Steve Piercy]

On Wednesday, July 22, 2009, list@... pronounced:

>22 jul 2009 kl. 16.38 skrev list@...:
>
>> Johan put some encode_html on other places nearby too. The fix is
>> easy. But could be that Johan had a good reason for using encode_html.
>> Perhaps some kind of protection against evil doers.
>> Hm, I wonder what.
>> I'll change it for the time being in my version.
>
>Pending an enlightening mail from Johan telling us about why  
>encode_html is so smart in this place I vote for not having it for  
>labels. If it's there it prevents us from using images as labels.

Agreed.  There might be other areas where encode_html could be removed from the form type.  It should remain on data values, whether input by a user or retrieved from a datasource.  But for stuff that the programmer does, maybe that is to handle shrimp sandwiches?

    + ' id="' +  (encode_html: #id) + '"'

--steve

-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Steve Piercy               Web Site Builder               Soquel, CA
<web@...>                  <http://www.StevePiercy.com/>

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Jolle Carlestam-3]

22 jul 2009 kl. 17.23 skrev Steve Piercy - Web Site Builder:

>> Pending an enlightening mail from Johan telling us about why
>> encode_html is so smart in this place I vote for not having it for
>> labels. If it's there it prevents us from using images as labels.
>
> Agreed.  There might be other areas where encode_html could be  
> removed from the form type.  It should remain on data values,  
> whether input by a user or retrieved from a datasource.  But for  
> stuff that the programmer does, maybe that is to handle shrimp  
> sandwiches?

No, that can't be it. A quick test reveals that putting räksmörgås in  
a label works fine. In the adjusted knop form without encode_html.

HDB
Jolle
--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Steve Piercy]

On Wednesday, July 22, 2009, list@... pronounced:

>22 jul 2009 kl. 17.08 skrev Steve Piercy - Web Site Builder:
>
>>
>> On Wednesday, July 22, 2009, list@... pronounced:
>>
>>>> It looks like you're trying to insert some tooltip stuff, yes?
>>>
>>> Na, it's part of a dynamic form where the user can click on a plus
>>> sign to add another item in the form. Like in this case an extra  
>>> phone
>>> number or e-mail address.
>>>
>>> When it's working...
>>
>> The standards wonk in me gives you the hairy eyebrow.  I don't think  
>> that is how labels should be used.
>>
>> http://www.w3.org/TR/html401/interact/forms.html#h-17.9
>>
>>    The LABEL element may be used to attach information to controls.
>>    Each LABEL element is associated with exactly one form control.
>>
>> Your widget does not attach information to the control (the input  
>> field), but instead adds a new control itself.  IMO, it should be  
>> placed after the input.
>
>Possibly. But if I want it to be created as part of the addfield tag  
>in a form object I have few options. Putting it in the label is about  
>it. The actual placement is then a matter of css. So from a user point  
>of view it's not part of the label. I'll attach an example.
>
>-----
>
>
>This shows a form where a user can add infinite number of interests,  
>types or notes. Each time he clicks on a plus sign he'll get another  
>select or text area box for that particular type of data. I could  
>insert it in a more manual way in the content file by breaking up the  
>renderform into smaller parts but this, when working, is more  
>convenient.

I see, but semantically and for visually impaired users, this implementation poses some issues, specifically when a user clicks on or selects a label then its associated control should be active and not add a new input.  This implementation handles these issues:

<div class="form_widget">
<label for="id">name</label>
<input name="name" id="id" type="hidden" value="value" />
<a href="#"><img src="/jina_img/plus.gif" id="addon_1_infselect_button" type="button" class="addbtn" title="msg" alt="msg" border="0" height="15" width="15" /></a>
</div>

--steve

-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Steve Piercy               Web Site Builder               Soquel, CA
<web@...>                  <http://www.StevePiercy.com/>

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Jolle Carlestam-3]

22 jul 2009 kl. 18.00 skrev Steve Piercy - Web Site Builder:

>
> On Wednesday, July 22, 2009, list@... pronounced:
>
>> 22 jul 2009 kl. 17.08 skrev Steve Piercy - Web Site Builder:
>>
>>>
>>> On Wednesday, July 22, 2009, list@... pronounced:
>>>
>>>>> It looks like you're trying to insert some tooltip stuff, yes?
>>>>
>>>> Na, it's part of a dynamic form where the user can click on a plus
>>>> sign to add another item in the form. Like in this case an extra
>>>> phone
>>>> number or e-mail address.
>>>>
>>>> When it's working...
>>>
>>> The standards wonk in me gives you the hairy eyebrow.  I don't think
>>> that is how labels should be used.
>>>
>>> http://www.w3.org/TR/html401/interact/forms.html#h-17.9
>>>
>>>   The LABEL element may be used to attach information to controls.
>>>   Each LABEL element is associated with exactly one form control.
>>>
>>> Your widget does not attach information to the control (the input
>>> field), but instead adds a new control itself.  IMO, it should be
>>> placed after the input.
>>
>> Possibly. But if I want it to be created as part of the addfield tag
>> in a form object I have few options. Putting it in the label is about
>> it. The actual placement is then a matter of css. So from a user  
>> point
>> of view it's not part of the label. I'll attach an example.
>>
>> -----
>>
>>
>> This shows a form where a user can add infinite number of interests,
>> types or notes. Each time he clicks on a plus sign he'll get another
>> select or text area box for that particular type of data. I could
>> insert it in a more manual way in the content file by breaking up the
>> renderform into smaller parts but this, when working, is more
>> convenient.
>
> I see, but semantically and for visually impaired users, this  
> implementation poses some issues, specifically when a user clicks on  
> or selects a label then its associated control should be active and  
> not add a new input.  This implementation handles these issues:
>
> <div class="form_widget">
> <label for="id">name</label>
> <input name="name" id="id" type="hidden" value="value" />
> <a href="#"><img src="/jina_img/plus.gif"  
> id="addon_1_infselect_button" type="button" class="addbtn"  
> title="msg" alt="msg" border="0" height="15" width="15" /></a>
> </div>

I agree in theory. The application in question is an intranet  
application with a very limited amount of users that happen to have  
their eysight left. And the way I have it, if they click the label  
text they get the expected behavior, that is the field is selected.  
It's only if the click the plus image they get a new input. I then use  
javascript to stop the selection of the field linked to that label.  
And, the code suggested by you above is hard to get using Knop. So  
I'll stick with my standard violation. As a CEO of Ericsson said to me  
once, "Standards are good. But only if they are good standards".  
Meaning that they only adhered to standards that suited them.

HDB
Jolle

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

[Johan Solve-2]

This is odd. Looking through the repository it seems to have reappeared sometime early 2008. I have no explanation. Labels shouldn't have encode_html. I've committed the fix.

There might be other areas where it should be removed as well, for example the contents of a legend.


At 07.21 -0700 2009-07-22, Steve Piercy - Web Site Builder wrote:

>In the form.inc notes:
>
>2007-02-23  JS  Removed encode_html from form field labels
>
>So you could either modify form.inc or not use HTML in your label and instead loop through all the fields and do a regular expression to find and replace </label> with your stuff + </label>.
>
>It looks like you're trying to insert some tooltip stuff, yes?
>
>--steve
>
>
>On Wednesday, July 22, 2009, list@... pronounced:
>
>>Is there a change done in Knop somewhere along the line that html
>>encodes label output in the form object.
>>
>>This used to work and still does on one older server. But on a newer
>>installation it's html encoded.
>>
>>   $fContact -> addfield(
>>           -type = 'text',
>>           -name = 'addon_1_infitem',
>>           -dbfield = '',
>>           -label = '<img src="/jina_img/plus.gif"
>>id="addon_1_infselect_button" type="button" class="addbtn" title="' +
>>($lang_messages -> addNewItemMsg) + '" alt="' + ($lang_messages ->
>>addNewItemMsg) + '" border="0" height="15" width="15">',
>>           -size = 35);
>>
>>
>>HDB
>>Jolle
>>
>
>-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>Steve Piercy               Web Site Builder               Soquel, CA
><web@...>                  <http://www.StevePiercy.com/>
>
>--
>#############################################################
>This message is sent to you because you are subscribed to
>the mailing list <knop@...>.
>To unsubscribe, E-mail to: <knop-off@...>
>Send administrative queries to  <knop-request@...>
>List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
>Project homepage http://montania.se/projects/knop/
>Google Code has the latest downloads at http://code.google.com/p/knop/

--
     Johan Sölve    [FSA Member, Lasso Partner]
     Web Application/Lasso/FileMaker Developer
     MONTANIA SOFTWARE & SOLUTIONS
http://www.montania.se   mailto:joh-n@...
 (spam-safe email address, replace '-' with 'a')

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <knop@...>.
To unsubscribe, E-mail to: <knop-off@...>
Send administrative queries to  <knop-request@...>
List archive http://www.nabble.com/Knop-Framework-Discussion-f29076.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/