LIBKCDDB: CDDB/FreeDB submit

View: New views
4 Messages — Rating Filter:   Alert me  

LIBKCDDB: CDDB/FreeDB submit

by Marco Nelles-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi list,


I am Marco, developer of the KDE CD ripper tool Audex (http://www.kde-
apps.org/content/show.php/Audex?content=77125).

I want to active the CDDB/FreeDB submit action, but taking a closer look at
the libkcddb code I've found this in libkcddb/httpsubmit.cpp on line 54/55:

        // Change to sumbit
        header += "Submit-Mode: test\n";

Why is this not set to submit? For a first look I can't see a reason for that.


Regards, Marco
_______________________________________________
kde-multimedia mailing list
kde-multimedia@...
https://mail.kde.org/mailman/listinfo/kde-multimedia

Re: LIBKCDDB: CDDB/FreeDB submit

by Richard Lärkäng-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi!

I believe it was because when I ported libkcddb to KDE/Qt 4, I temporarily set
it to testing mode, and then planned to do a little testing of it so it still
worked after the porting. However, after I ported it, I haven't been able to
be active in maintaining libkcddb, so noone got around to enabling it again.

/Richard Lärkäng

On Sunday 09 August 2009 22:11:11 Marco Nelles wrote:

> Hi list,
>
>
> I am Marco, developer of the KDE CD ripper tool Audex (http://www.kde-
> apps.org/content/show.php/Audex?content=77125).
>
> I want to active the CDDB/FreeDB submit action, but taking a closer look at
> the libkcddb code I've found this in libkcddb/httpsubmit.cpp on line 54/55:
>
> // Change to sumbit
> header += "Submit-Mode: test\n";
>
> Why is this not set to submit? For a first look I can't see a reason for
> that.
>
>
> Regards, Marco
> _______________________________________________
> kde-multimedia mailing list
> kde-multimedia@...
> https://mail.kde.org/mailman/listinfo/kde-multimedia
_______________________________________________
kde-multimedia mailing list
kde-multimedia@...
https://mail.kde.org/mailman/listinfo/kde-multimedia

Re: LIBKCDDB: CDDB/FreeDB submit

by Marco Nelles-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hej,


It is somewhat frustrating for me, because some users asked for cddb
submitting capabilities - and I have to explain that it's an issue with
libkcddb.

> However, after I ported it, I haven't been
> able to be active in maintaining libkcddb, so noone got around to enabling

As far as I understand, noone is working on this?
I don't want to use another lib for that. So, I think it is okay, if I start
testing on libkcddb and send patches to the list?


Kind regards, Marco



Am Montag, 10. August 2009 08:00:52 schrieb Richard Lärkäng:

> Hi!
>
> I believe it was because when I ported libkcddb to KDE/Qt 4, I temporarily
> set it to testing mode, and then planned to do a little testing of it so it
> still worked after the porting. However, after I ported it, I haven't been
> able to be active in maintaining libkcddb, so noone got around to enabling
> it again.
>
> /Richard Lärkäng
>
> On Sunday 09 August 2009 22:11:11 Marco Nelles wrote:
> > Hi list,
> >
> >
> > I am Marco, developer of the KDE CD ripper tool Audex (http://www.kde-
> > apps.org/content/show.php/Audex?content=77125).
> >
> > I want to active the CDDB/FreeDB submit action, but taking a closer look
> > at the libkcddb code I've found this in libkcddb/httpsubmit.cpp on line
> > 54/55:
> >
> > // Change to sumbit
> > header += "Submit-Mode: test\n";
> >
> > Why is this not set to submit? For a first look I can't see a reason for
> > that.
> >
> >
> > Regards, Marco
> > _______________________________________________
> > kde-multimedia mailing list
> > kde-multimedia@...
> > https://mail.kde.org/mailman/listinfo/kde-multimedia
_______________________________________________
kde-multimedia mailing list
kde-multimedia@...
https://mail.kde.org/mailman/listinfo/kde-multimedia

Re: LIBKCDDB: CDDB/FreeDB submit

by Richard Lärkäng-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi!

On Monday 10 August 2009 09:00:50 Marco Nelles wrote:
> Hej,
>
>
> It is somewhat frustrating for me, because some users asked for cddb
> submitting capabilities - and I have to explain that it's an issue with
> libkcddb.

Sure, I can understand that.

> > However, after I ported it, I haven't been
> > able to be active in maintaining libkcddb, so noone got around to
> > enabling
>
> As far as I understand, noone is working on this?
> I don't want to use another lib for that. So, I think it is okay, if I
> start testing on libkcddb and send patches to the list?

Yes, AFAIK, no one is working on libkcddb right now, and from what I can see,
none of the applications using libkcddb in KDE's svn support submitting to
cddb at the moment. However, at least the basic functionality seems to be
working, running the test apps asynchttpsubmittest/synchttpsubmittest seems to
indicate that it's working as it should. So if you could do a little testing,
we can probably enable it again.

/Richard

> Kind regards, Marco
>
> Am Montag, 10. August 2009 08:00:52 schrieb Richard Lärkäng:
> > Hi!
> >
> > I believe it was because when I ported libkcddb to KDE/Qt 4, I
> > temporarily set it to testing mode, and then planned to do a little
> > testing of it so it still worked after the porting. However, after I
> > ported it, I haven't been able to be active in maintaining libkcddb, so
> > noone got around to enabling it again.
> >
> > /Richard Lärkäng
> >
> > On Sunday 09 August 2009 22:11:11 Marco Nelles wrote:
> > > Hi list,
> > >
> > >
> > > I am Marco, developer of the KDE CD ripper tool Audex (http://www.kde-
> > > apps.org/content/show.php/Audex?content=77125).
> > >
> > > I want to active the CDDB/FreeDB submit action, but taking a closer
> > > look at the libkcddb code I've found this in libkcddb/httpsubmit.cpp on
> > > line 54/55:
> > >
> > > // Change to sumbit
> > > header += "Submit-Mode: test\n";
> > >
> > > Why is this not set to submit? For a first look I can't see a reason
> > > for that.
> > >
> > >
> > > Regards, Marco
> > > _______________________________________________
> > > kde-multimedia mailing list
> > > kde-multimedia@...
> > > https://mail.kde.org/mailman/listinfo/kde-multimedia
_______________________________________________
kde-multimedia mailing list
kde-multimedia@...
https://mail.kde.org/mailman/listinfo/kde-multimedia