tag:old.nabble.com,2006:forum-3776Nabble - Linux Wacom Tablet Project2009-12-15T15:31:33ZThis project manages the libraries, configuration, and diagnostic tools for Wacom tablets running under Linux. It also maintains updated linux kernel drivers and XFree86 XInput drivers. Linux Wacom Tablet Project home is <a href="http://sourceforge.net/projects/linuxwacom/" target="_top" rel="nofollow">here</a>.tag:old.nabble.com,2006:post-26803839Re: Graphire wireless bluetooth support?2009-12-15T15:31:33Z2009-12-15T15:31:33ZPing@LinuxWacomHi Steven,<br><br>It is supported by kernels 2.6.31 and later. The bluetooth kernel driver is not under the same tree as Wacom USB driver (drivers/input/tablet). It is under drivers/hid. The file is called hid-wacom.c. <br>
<br>If you are running kernel 2.6.31 or later with the current stable (0.8.4-4) or unstable (0.8.5-7) X driver from <a href="http://linuxwacom.sf.net" target="_top" rel="nofollow">linuxwacom.sf.net</a>, your bluetooth tablet should work. If not, please let us know. Thank you,<br>
<br>Ping<br><br><div class="gmail_quote">On Tue, Dec 15, 2009 at 3:19 PM, Steven L. Seed <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26803839&i=0" target="_top" rel="nofollow">Steven.Seed@...</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi linuxwacom folks,<br>
<br>
I was wondering if support for the Graphire wireless bluetooh tablet has<br>
been added to the project yet. We have a project that wants to make use<br>
of this tablet, but it doesn't appear to work under Linux right now.<br>
<br>
<br>
--<br>
<br>
<br>
<br>
<br>
------------------------------------------------------------------------------<br>
This SF.Net email is sponsored by the Verizon Developer Community<br>
Take advantage of Verizon's best-in-class app development support<br>
A streamlined, 14 day to market process makes app distribution fast and easy<br>
Join now and get one step closer to millions of Verizon customers<br>
<a href="http://p.sf.net/sfu/verizon-dev2dev" target="_blank" rel="nofollow">http://p.sf.net/sfu/verizon-dev2dev</a><br>
_______________________________________________<br>
Linuxwacom-discuss mailing list<br>
<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26803839&i=1" target="_top" rel="nofollow">Linuxwacom-discuss@...</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_blank" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br>
</blockquote></div><br>
<br />------------------------------------------------------------------------------
<br>This SF.Net email is sponsored by the Verizon Developer Community
<br>Take advantage of Verizon's best-in-class app development support
<br>A streamlined, 14 day to market process makes app distribution fast and easy
<br>Join now and get one step closer to millions of Verizon customers
<br><a href="http://p.sf.net/sfu/verizon-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/verizon-dev2dev</a> <br />_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26803839&i=2" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26803674Graphire wireless bluetooth support?2009-12-15T15:19:11Z2009-12-15T15:19:11ZSteven SeedHi linuxwacom folks,
<br><br>I was wondering if support for the Graphire wireless bluetooh tablet has
<br>been added to the project yet. We have a project that wants to make use
<br>of this tablet, but it doesn't appear to work under Linux right now.
<br><br><br>--
<br><br><br><br><br>------------------------------------------------------------------------------
<br>This SF.Net email is sponsored by the Verizon Developer Community
<br>Take advantage of Verizon's best-in-class app development support
<br>A streamlined, 14 day to market process makes app distribution fast and easy
<br>Join now and get one step closer to millions of Verizon customers
<br><a href="http://p.sf.net/sfu/verizon-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/verizon-dev2dev</a>
<br>_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26803674&i=0" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26791709Re: Intuos3 stylus tilt precision2009-12-15T01:07:20Z2009-12-15T01:07:20ZNicolás Carranza-2On Monday 14 December 2009 3:20:49 pm Ping wrote:
<br>> On Sun, Dec 13, 2009 at 12:47 PM, Nicolas Carranza
<br><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26791709&i=0" target="_top" rel="nofollow">nicarran@...</a>>wrote:
<div class='shrinkable-quote'><br>> > I have some questions about tilt precision on an Intuos3. Using the linux
<br>> > wacom driver I get stylus tilt values on the x axis ranging from -64 to
<br>> > +63 (tested using xidump). While on Windows I get stylus tilt values
<br>> > ranging from -60 to 60 (tested using wintab and also the Wacom Tabler
<br>> > Properties utility (About->Diagnose...) ) apparently over the same
<br>> > physical range (but this is hard to say as the difference is only ~3deg).
<br>> > My questions are: * Why does the linux-wacom driver get a wider range on
<br>> > linux using the same hardware?
<br>>
<br>> We report raw data on Linux while Windows reports modified data. Tilt raw
<br>> data is reported from -64 to 63 by the hardware.
<br>>
<br>> > * How precise is the Intuos3 stylus and the linux-wacom driver when
<br>> > reporting
<br>> > tilt angle? Is there a specified error (+/-X deg) to take into account?
<br>>
<br>> I'd say as accurate as the tablet reports to us. However, considering we
<br>> have a default of 2 for Suppress (
<br>> <a href="http://linuxwacom.sourceforge.net/index.php/howto/inputdev" target="_top" rel="nofollow">http://linuxwacom.sourceforge.net/index.php/howto/inputdev</a>), you may get 2
<br>> counts of offset if you didn't change Suppress yourself
<br>>
<br>> Ping
</div><br>Thank you Ping
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26791709&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26790854Re: Wacom Intuos4, xorg 1.7.12009-12-14T23:41:15Z2009-12-14T23:41:15Zjryoung70On 14/12/09 22:08, Jim Henderson wrote:
<div class='shrinkable-quote'><br>> On Mon, 14 Dec 2009 14:01:10 -0800, Ping wrote:
<br>>
<br>>
<br>>>>> Do you have a patch for us ? As you can tell, Peter and I are both
<br>>>>> handful......
<br>>>>>
<br>>>> I thought the patch that had been previously committed for this had
<br>>>> been accepted - was it not?
<br>>>>
<br>>>>
<br>>>>
<br>>> Yes and no. Nick's kernel patches (
<br>>> <a href="http://mail.google.com/mail/?shva=1#inbox/1251cce3cd5abd37" target="_top" rel="nofollow">http://mail.google.com/mail/?shva=1#inbox/1251cce3cd5abd37</a>) can be
<br>>> considered as accepted. But, without an X driver to properly support
<br>>> the feature, it is hard to use for most users. Not everyone is as savvy
<br>>> as you are on Linux, don't you agree . I remember Nick said he will add
<br>>> the feature to X wacom_drv.so when he has time. So, if Casper can do
<br>>> the job now, we may get the feature sooner, hopefully .
<br>>>
<br>> OK, this makes sense to me. :-) And I agree, not everyone has my sense
<br>> of adventure with Linux. Over the holiday break, I'm taking some
<br>> vacation at home, so I can put 11.2 on a spare laptop I have here and do
<br>> some testing if that would help out.
<br>>
<br>>
<br>>> I've been following to see how development is coming along on support
<br>>> for
<br>>>
<br>>>> Xorg 1.7.x as I'm waiting to upgrade to openSUSE 11.2 for the support
<br>>>> to be completed.
<br>>>>
<br>>>>
<br>>> We have to bring the two code bases, xf86-input-wacom and linuxwacom,
<br>>> in-sync before we can add more features. You may aware that we are
<br>>> desperately working on this issue right now. I am extremely grateful
<br>>> that Peter Hutterer, one of the key x.org developers from Red Hat, is
<br>>> helping us to port linuxwacom to X server 1.7 and later. Without his
<br>>> help, there is no way for me to manage all these supports. We only have
<br>>> 24 hours a day anyway .
<br>>>
<br>> Yep, and I for one really appreciate the work you and the other
<br>> developers are doing on this. :-)
<br>>
<br>>
<br>>>> I'm still using the kernel driver patch that was submitted a couple
<br>>>> months ago for OLED support and it still seems to be working well.
<br>>>>
<br>>>>
<br>>>>
<br>>> It is not just a kernel driver issue if we want the feature a little bit
<br>>> user friendly. Hope you agree with me.
<br>>>
<br>> 100% agreement. :-)
<br>>
<br>> Jim
<br>>
<br>>
</div>I would be happy to help test the xorg driver patch for the OLED - I got
<br>it working with the kernel driver, but now I am using Fedora 12, and
<br>xorg1.7.1
<br>Jonathan
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26790854&i=0" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26789192Re: xsetwacom re-implementation available2009-12-14T20:06:24Z2009-12-14T20:06:24ZPeter Hutterer-3On Mon, Dec 14, 2009 at 08:38:10AM +0100, Oldrich Jedlicka wrote:
<br>> > can you give me some more info what exactly you're referring to here? you've
<br>> > assigned the button to be "Shift"? is that correct?
<br>>
<br>> Exactly. Assign a "Shift" key functionality to a button (button
<br>> press=shift pressed,button release=shift released). I was using also the
<br>> "Ctrl" key for another button. I think it would be sufficient to release
<br>> all "forgetten" pressed keys automatically (in reversed order), when the
<br>> button is released - that would sanitise the user's input too.
<br>>
<br><br>just verifying: your commandline argument was
<br>xsetwacom --set "Device Name" "Button1" "key shift"
<br><br>if so, the patches on my devel branch should fix this issue
<br><a href="http://cgit.freedesktop.org/~whot/xf86-input-wacom/log/?h=devel" target="_top" rel="nofollow">http://cgit.freedesktop.org/~whot/xf86-input-wacom/log/?h=devel</a><br><br>it'd be great if you could give this a test.
<br><div class='shrinkable-quote'><br>> > > I have also difficulties double-clicking Button 3, because it
<br>> > > freezes any mouse/tablet clicks (no buttons react) until some key is pressed.
<br>> >
<br>> > just double-clicking the physical button or assigning doubleclick to it?
<br>>
<br>> Just double-click (Button 3) without any assigned functonality - just a
<br>> pure button. I've tried it with tracing enabled, but I didn't see any
<br>> difference from single click, only no mouse clicks accepted afterwards
<br>> (also from normal mouse) - until the keyboard's key is pressed.
<br>>
<br>> I wanted to have a look at it during weekend, but I didn't have any free time for that...
</div><br>I can't reproduce this here, doubleclicks go through normally, without any
<br>issues. Not sure what happens there.
<br><br>Cheers,
<br> Peter
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26789192&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26787738Re: [PATCH] touch and gesture options2009-12-14T16:28:44Z2009-12-14T16:28:44ZPeter Hutterer-3On Mon, Dec 14, 2009 at 02:08:44PM -0800, Ping wrote:
<div class='shrinkable-quote'><br>> On Sun, Dec 13, 2009 at 9:38 PM, Peter Hutterer <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26787738&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>>wrote:
<br>> > it does, a bit anyway.
<br>> > the device-specific features are the enabling of touch, etc. based on the
<br>> > device's capabilities, right? (like the hunk below).
<br>> >
<br>> > AIUI, these capabilities don't change during the runtime of a device. if
<br>> > so,
<br>> > usbWcmInit is the wrong place to put the checks, it's called every time the
<br>> > device is opened and that seems a bit excessive.
<br>>
<br>>
<br>> I see your point. We can easily move this to wcmValidateDevice.c for USB.
<br>> But it would be a challenge for ISDV4 devices since the driver may not get
<br>> the accurate feature until it talks to the device directly in Wacom mode.
<br>> Anyway, I made a clean, I think :), patch. ISDV4 would need more work
<br>> later. But this patch covers the ISDV4 devices that we see in the market
<br>> now.
<br>>
<br>>
<br>> > (also, it looks like this
<br>> > is the cause for the touch property being overwritten when you resume from
<br>> > suspend :)
<br>> >
<br>>
<br>> Unfortunately, your "kill two birds with one stone" plan did not work :).
<br>> The property resume issue stays even with the new patch. In fact, if you
<br>> hardcode both wcmTouch and wcmTouchDefault to 1 without changing it anywhere
<br>> else in the driver, wcmTouch got changed to 0 after the system resumes. I
<br>> am running a 64 bit system. Maybe that makes a difference? Something fishy
<br>> in InitWcmAtom.
</div><br>doh. I'll have a look at it.
<br>
<br>> I think what we need here is something similar to the EvdevProbe() function
<br>> > - a function that opens the device, checks the capabilities and sets the
<br>> > required flags so that xf86WcmDevOpen and it's childs can be reduced to
<br>> > little more than fd = open(device).
<br>> >
<br>>
<br>> Let me know if my solution is acceptable or not. It is only called once now
<br>> if that was your major concern.
<br><div class='shrinkable-quote'><br>> From 5df49f641cb331646f6cbfb0975a9661f23e7a4e Mon Sep 17 00:00:00 2001
<br>> From: Ping Cheng <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26787738&i=1" target="_top" rel="nofollow">pingc@...</a>>
<br>> Date: Mon, 14 Dec 2009 13:04:04 -0800
<br>> Subject: [PATCH] Set Touch and Gesture options during the configuration
<br>>
<br>> We moved the touch and gesture option check from usbWcmInit
<br>> to wcmValidateDevice.c since usbWcmInit gets called every time
<br>> the device is opened, which is unnecessary for option check
<br>> in most cases.
<br>>
<br>> The Tablet PC Button option should also be dealt in the same way.
<br>> But it requires extra defines to make it clean, which will affect
<br>> more files in the driver. We'll do it in a separate patch later.
<br>>
<br>> Signed-off-by: Ping Cheng <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26787738&i=2" target="_top" rel="nofollow">pinglinux@...</a>>
<br>> ---
<br>> src/wcmConfig.c | 37 ++++++++++++++++++++++++++++++++++++-
<br>> src/wcmISDV4.c | 16 ----------------
<br>> src/wcmUSB.c | 25 +------------------------
<br>> src/wcmValidateDevice.c | 7 -------
<br>> 4 files changed, 37 insertions(+), 48 deletions(-)
<br>>
<br>> diff --git a/src/wcmConfig.c b/src/wcmConfig.c
<br>> index 9a51596..cf7f2ab 100644
<br>> --- a/src/wcmConfig.c
<br>> +++ b/src/wcmConfig.c
<br>> @@ -37,6 +37,7 @@ extern void wcmHotplugOthers(LocalDevicePtr local, unsigned long* keys);
<br>> extern int wcmDeviceTypeKeys(LocalDevicePtr local, unsigned long* keys);
<br>>
<br>> static int xf86WcmAllocate(LocalDevicePtr local, char* name, int flag);
<br>> +static void wcmDeviceSpecCommonOptions(LocalDevicePtr local, unsigned long* keys);
<br>>
<br>> /*****************************************************************************
<br>> * xf86WcmAllocate --
<br>> @@ -312,6 +313,37 @@ static Bool xf86WcmMatchDevice(LocalDevicePtr pMatch, LocalDevicePtr pLocal)
<br>> return 0;
<br>> }
<br>>
<br>> +/* retrieve the specific options for the device */
<br>> +static void wcmDeviceSpecCommonOptions(LocalDevicePtr local, unsigned long* keys)
<br>> +{
<br>> + WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br>> + WacomCommonPtr common = priv->common;
<br>> +
<br>> + /* a single touch device */
<br>> + if (ISBITSET (keys, BTN_TOOL_DOUBLETAP))
<br>> + {
<br>> + /* TouchDefault was off for all devices
<br>> + * except when touch is supported */
<br>> + common->wcmTouchDefault = 1;
<br>> + }
<br>> +
<br>> + /* 2FG touch device */
<br>> + if (ISBITSET (keys, BTN_TOOL_TRIPLETAP))
<br>> + {
<br>> + /* GestureDefault was off for all devices
<br>> + * except when multi-touch is supported */
<br>> + common->wcmGestureDefault = 1;
<br>> + }
<br>> +
<br>> + /* check if touch was turned off in xorg.conf */
<br>> + common->wcmTouch = xf86SetBoolOption(local->options, "Touch",
<br>> + common->wcmTouchDefault);
<br>> +
<br>> + /* Touch gesture applies to the whole tablet */
<br>> + common->wcmGesture = xf86SetBoolOption(local->options, "Gesture",
<br>> + common->wcmGestureDefault);
<br>> +}
</div><br>I don't quite understand why we'd need a separate function for this. is this
<br>future-proofing it for the ISDV4 support you mentioned above?
<br>if not, we could just add those few lines to wcmParseOptions, couldn't we?
<br><div class='shrinkable-quote'><br>> /* xf86WcmInit - called for each input devices with the driver set to
<br>> * "wacom" */
<br>> static LocalDevicePtr xf86WcmInit(InputDriverPtr drv, IDevPtr dev, int flags)
<br>> @@ -384,7 +416,10 @@ static LocalDevicePtr xf86WcmInit(InputDriverPtr drv, IDevPtr dev, int flags)
<br>> }
<br>> }
<br>>
<br>> - /* Process the common options. */
<br>> + /* update device specific common options */
<br>> + wcmDeviceSpecCommonOptions(local, keys);
<br>> +
<br>> + /* Process the general common options. */
<br>> xf86ProcessCommonOptions(local, local->options);
<br>> if (!wcmParseOptions(local))
<br>> goto SetupProc_fail;
</div><br>if wcmDeviceSpecCommonOptions is neeed (see above hunk):
<br>any reason we can't call wcmDeviceSpecCommonOptions from wcmParseOptions?
<br>That'd give us a single entry point into the option parsing code.
<br>also, IIRC parsing options before xf86ProcessCommonOptions can lead to funny
<br>results.
<br><br>rest of the patch looks good though.
<br><br>Cheers,
<br> Peter
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26787738&i=3" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26787209[PATCH] Use xf86Msg instead of ErrorF for debug messages.2009-12-14T15:33:30Z2009-12-14T15:33:30ZPeter Hutterer-3ErrorF is supposed to be used in the server, drivers are better off calling
<br>xf86Msg since this uses the appropriate prefixes.
<br><br>Signed-off-by: Peter Hutterer <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26787209&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>>
<br>---
<br>More of a janitorial patch but it's part one of the debug cleanup.
<br>Substitution was done with a simple
<br>for file in **/*.c; do
<br> sed -e "s/ErrorF(/xf86Msg(X_INFO, /g" < $file > $file.tmp
<br> mv $file.tmp $file
<br>done
<br><br> src/wcmCommon.c | 68 ++++++++++++++++++++++++++--------------------------
<br> src/wcmConfig.c | 4 +-
<br> src/wcmFilter.c | 2 +-
<br> src/wcmISDV4.c | 16 ++++++------
<br> src/wcmUSB.c | 34 +++++++++++++-------------
<br> src/wcmXCommand.c | 14 +++++-----
<br> src/xf86Wacom.c | 58 ++++++++++++++++++++++----------------------
<br> 7 files changed, 98 insertions(+), 98 deletions(-)
<br><br>diff --git a/src/wcmCommon.c b/src/wcmCommon.c
<br>index fb59cb4..429fac4 100644
<br>--- a/src/wcmCommon.c
<br>+++ b/src/wcmCommon.c
<br>@@ -56,7 +56,7 @@ void xf86WcmMappingFactor(LocalDevicePtr local)
<br> {
<br> WacomDevicePtr priv = (WacomDevicePtr) local->private;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmMappingFactor \n"));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmMappingFactor \n"));
<br>
<br> xf86WcmVirtaulTabletSize(local);
<br>
<br>@@ -80,7 +80,7 @@ void xf86WcmMappingFactor(LocalDevicePtr local)
<br> if (priv->currentScreen == -1) /* tool on the tablet */
<br> priv->currentScreen = 0;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmMappingFactor"
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmMappingFactor"
<br> " Active tablet area x=%d y=%d (virtual tablet area x=%d y=%d) map"
<br> " to maxWidth =%d maxHeight =%d\n",
<br> priv->bottomX, priv->bottomY, priv->sizeX, priv->sizeY,
<br>@@ -88,7 +88,7 @@ void xf86WcmMappingFactor(LocalDevicePtr local)
<br>
<br> priv->factorX = (double)priv->maxWidth / (double)priv->sizeX;
<br> priv->factorY = (double)priv->maxHeight / (double)priv->sizeY;
<br>- DBG(2, priv->debugLevel, ErrorF("X factor = %.3g, Y factor = %.3g\n",
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO, "X factor = %.3g, Y factor = %.3g\n",
<br> priv->factorX, priv->factorY));
<br> }
<br>
<br>@@ -105,7 +105,7 @@ static void xf86WcmSetScreen(LocalDevicePtr local, int v0, int v1)
<br> WacomDevicePtr priv = (WacomDevicePtr) local->private;
<br> int screenToSet = -1, i, j, x, y, tabletSize = 0;
<br>
<br>- DBG(6, priv->debugLevel, ErrorF("xf86WcmSetScreen v0=%d v1=%d "
<br>+ DBG(6, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSetScreen v0=%d v1=%d "
<br> "currentScreen=%d\n", v0, v1, priv->currentScreen));
<br>
<br> if (priv->screen_no != -1 && priv->screen_no >= priv->numScreen)
<br>@@ -151,7 +151,7 @@ static void xf86WcmSetScreen(LocalDevicePtr local, int v0, int v1)
<br> if (v0 > priv->topY && v0 <= priv->topY + priv->tvoffsetY)
<br> priv->currentScreen = 1;
<br> }
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmSetScreen TwinView setup screenToSet=%d\n",
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSetScreen TwinView setup screenToSet=%d\n",
<br> priv->currentScreen));
<br> }
<br>
<br>@@ -193,8 +193,8 @@ static void xf86WcmSetScreen(LocalDevicePtr local, int v0, int v1)
<br>
<br> if (screenToSet == -1)
<br> {
<br>- DBG(3, priv->debugLevel, ErrorF("xf86WcmSetScreen Error: "
<br>- "Can not find valid screen (currentScreen=%d)\n",
<br>+ DBG(3, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSetScreen Error: "
<br>+ "Can not find valid screen (currentScreen=%d)\n",
<br> priv->currentScreen));
<br> return;
<br> }
<br>@@ -209,7 +209,7 @@ static void xf86WcmSetScreen(LocalDevicePtr local, int v0, int v1)
<br> y = screenInfo.screens[screenToSet]->height - 1;
<br>
<br> xf86XInputSetScreen(local, screenToSet, x, y);
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmSetScreen current=%d ToSet=%d\n",
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSetScreen current=%d ToSet=%d\n",
<br> priv->currentScreen, screenToSet));
<br> priv->currentScreen = screenToSet;
<br> }
<br>@@ -226,7 +226,7 @@ static void xf86WcmSendButtons(LocalDevicePtr local, int buttons, int rx, int ry
<br> int button, mask;
<br> WacomDevicePtr priv = (WacomDevicePtr) local->private;
<br> WacomCommonPtr common = priv->common;
<br>- DBG(6, priv->debugLevel, ErrorF("xf86WcmSendButtons "
<br>+ DBG(6, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSendButtons "
<br> "buttons=%d for %s\n", buttons, local->name));
<br>
<br> /* Tablet PC buttons only apply to penabled devices */
<br>@@ -441,7 +441,7 @@ static void sendAButton(LocalDevicePtr local, int button, int mask,
<br> if (!priv->button[button]) /* ignore this button event */
<br> return;
<br>
<br>- DBG(4, priv->debugLevel, ErrorF(
<br>+ DBG(4, priv->debugLevel, xf86Msg(X_INFO,
<br> "sendAButton TPCButton(%s) button=%d state=%d "
<br> "code=%08x, for %s coreEvent=%s \n",
<br> common->wcmTPCButton ? "on" : "off",
<br>@@ -520,7 +520,7 @@ static void sendWheelStripEvents(LocalDevicePtr local, const WacomDeviceState* d
<br> unsigned *keyP = 0;
<br> int is_absolute = priv->flags & ABSOLUTE_FLAG;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("sendWheelStripEvents for %s \n", local->name));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "sendWheelStripEvents for %s \n", local->name));
<br>
<br> /* emulate events for relative wheel */
<br> if ( ds->relwheel )
<br>@@ -610,7 +610,7 @@ static void sendWheelStripEvents(LocalDevicePtr local, const WacomDeviceState* d
<br>
<br> if (!fakeButton) return;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("sendWheelStripEvents "
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "sendWheelStripEvents "
<br> "send fakeButton %x with value = %d \n",
<br> fakeButton, value));
<br>
<br>@@ -689,7 +689,7 @@ void xf86WcmSendEvents(LocalDevicePtr local, const WacomDeviceState* ds)
<br>
<br> if (priv->serial && serial != priv->serial)
<br> {
<br>- DBG(10, priv->debugLevel, ErrorF("[%s] serial number"
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "[%s] serial number"
<br> " is %u but your system configured %u",
<br> local->name, serial, (int)priv->serial));
<br> return;
<br>@@ -709,7 +709,7 @@ void xf86WcmSendEvents(LocalDevicePtr local, const WacomDeviceState* ds)
<br> ty = ds->stripy;
<br> }
<br>
<br>- DBG(7, priv->debugLevel, ErrorF("[%s] o_prox=%s x=%d y=%d z=%d "
<br>+ DBG(7, priv->debugLevel, xf86Msg(X_INFO, "[%s] o_prox=%s x=%d y=%d z=%d "
<br> "b=%s b=%d tx=%d ty=%d wl=%d rot=%d th=%d\n",
<br> (type == STYLUS_ID) ? "stylus" :
<br> (type == CURSOR_ID) ? "cursor" :
<br>@@ -764,7 +764,7 @@ void xf86WcmSendEvents(LocalDevicePtr local, const WacomDeviceState* ds)
<br> }
<br> v5 = wheel;
<br>
<br>- DBG(6, priv->debugLevel, ErrorF("[%s] %s prox=%d\tx=%d"
<br>+ DBG(6, priv->debugLevel, xf86Msg(X_INFO, "[%s] %s prox=%d\tx=%d"
<br> "\ty=%d\tz=%d\tv3=%d\tv4=%d\tv5=%d\tid=%d"
<br> "\tserial=%u\tbutton=%s\tbuttons=%d\n",
<br> local->name,
<br>@@ -1010,7 +1010,7 @@ static int xf86WcmSuppress(WacomCommonPtr common, const WacomDeviceState* dsOrig
<br> dsNew->y = dsOrig->y;
<br> }
<br>
<br>- DBG(10, common->debugLevel, ErrorF("xf86WcmSuppress at level = %d"
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "xf86WcmSuppress at level = %d"
<br> " return value = %d\n", suppress, returnV));
<br> return returnV;
<br> }
<br>@@ -1045,7 +1045,7 @@ void xf86WcmEvent(WacomCommonPtr common, unsigned int channel,
<br> pChannel = common->wcmChannel + channel;
<br> pLast = &pChannel->valid.state;
<br>
<br>- DBG(10, common->debugLevel, ErrorF("xf86WcmEvent at channel = %d\n", channel));
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "xf86WcmEvent at channel = %d\n", channel));
<br>
<br> /* sanity check the channel */
<br> if (channel >= MAX_CHANNELS)
<br>@@ -1057,7 +1057,7 @@ void xf86WcmEvent(WacomCommonPtr common, unsigned int channel,
<br>
<br> /* timestamp the state for velocity and acceleration analysis */
<br> ds.sample = (int)GetTimeInMillis();
<br>- DBG(10, common->debugLevel, ErrorF("xf86WcmEvent: "
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "xf86WcmEvent: "
<br> "c=%d i=%d t=%d s=%u x=%d y=%d b=%d "
<br> "p=%d rz=%d tx=%d ty=%d aw=%d rw=%d "
<br> "t=%d df=%d px=%d st=%d cs=%d \n",
<br>@@ -1076,7 +1076,7 @@ void xf86WcmEvent(WacomCommonPtr common, unsigned int channel,
<br> ds.device_type != PAD_ID && (ds.device_type != TOUCH_ID) )
<br> {
<br> DBG(11, common->debugLevel,
<br>- ErrorF("discarded %dth USB data.\n",
<br>+ xf86Msg(X_INFO, "discarded %dth USB data.\n",
<br> pChannel->nSamples));
<br> ++pChannel->nSamples;
<br> return; /* discard */
<br>@@ -1091,7 +1091,7 @@ void xf86WcmEvent(WacomCommonPtr common, unsigned int channel,
<br> fs = &pChannel->rawFilter;
<br> if (!fs->npoints && ds.proximity)
<br> {
<br>- DBG(11, common->debugLevel, ErrorF("initialize Channel data.\n"));
<br>+ DBG(11, common->debugLevel, xf86Msg(X_INFO, "initialize Channel data.\n"));
<br> /* store channel device state for later use */
<br> for (i=common->wcmRawSample - 1; i>=0; i--)
<br> {
<br>@@ -1124,7 +1124,7 @@ void xf86WcmEvent(WacomCommonPtr common, unsigned int channel,
<br> {
<br> if (common->wcmModel->FilterRaw(common,pChannel,&ds))
<br> {
<br>- DBG(10, common->debugLevel, ErrorF(
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO,
<br> "Raw filtering discarded data.\n"));
<br> resetSampleCounter(pChannel);
<br> return; /* discard */
<br>@@ -1236,7 +1236,7 @@ static void commonDispatchDevice(WacomCommonPtr common, unsigned int channel,
<br> }
<br> }
<br>
<br>- DBG(10, common->debugLevel, ErrorF("commonDispatchDevice device type = %d\n", ds->device_type));
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "commonDispatchDevice device type = %d\n", ds->device_type));
<br> /* Find the device the current events are meant for */
<br> /* 1: Find the tool (the one with correct serial or in second
<br> * hand, the one with serial set to 0 if no match with the
<br>@@ -1299,7 +1299,7 @@ static void commonDispatchDevice(WacomCommonPtr common, unsigned int channel,
<br> LocalDevicePtr oDev = outprox->device;
<br> WacomDeviceState out = { 0 };
<br> out.device_type = DEVICE_ID(((WacomDevicePtr)(oDev->private))->flags);
<br>- DBG(2, common->debugLevel, ErrorF("Soft prox-out for %s\n",
<br>+ DBG(2, common->debugLevel, xf86Msg(X_INFO, "Soft prox-out for %s\n",
<br> outprox->device->name));
<br> xf86WcmSendEvents(oDev, &out);
<br> }
<br>@@ -1311,7 +1311,7 @@ static void commonDispatchDevice(WacomCommonPtr common, unsigned int channel,
<br> if(tool->current)
<br> {
<br> pDev = tool->current->device;
<br>- DBG(11, common->debugLevel, ErrorF("tool id=%d for %s\n",
<br>+ DBG(11, common->debugLevel, xf86Msg(X_INFO, "tool id=%d for %s\n",
<br> ds->device_type, pDev->name));
<br> }
<br> }
<br>@@ -1369,7 +1369,7 @@ static void commonDispatchDevice(WacomCommonPtr common, unsigned int channel,
<br> /* Send soft prox-out for touch first */
<br> WacomDeviceState out = { 0 };
<br> out.device_type = DEVICE_ID(temppriv->flags);
<br>- DBG(2, common->debugLevel, ErrorF(
<br>+ DBG(2, common->debugLevel, xf86Msg(X_INFO,
<br> "Send soft prox-out for %s first\n",
<br> localDevices->name));
<br> xf86WcmSendEvents(localDevices, &out);
<br>@@ -1442,7 +1442,7 @@ static void commonDispatchDevice(WacomCommonPtr common, unsigned int channel,
<br> }
<br> else /* no other events to send */
<br> {
<br>- DBG(10, common->debugLevel, ErrorF(
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO,
<br> "Ignore non-movement relative data \n"));
<br> return;
<br> }
<br>@@ -1472,7 +1472,7 @@ static void commonDispatchDevice(WacomCommonPtr common, unsigned int channel,
<br> if (common->wcmMaxCursorDist < filtered.distance)
<br> common->wcmMaxCursorDist = filtered.distance;
<br> }
<br>- DBG(10, common->debugLevel, ErrorF("Distance over"
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "Distance over"
<br> " the tablet: %d, ProxoutDist: %d current"
<br> " min/max %d hard prox: %d\n",
<br> filtered.distance,
<br>@@ -1506,7 +1506,7 @@ static void commonDispatchDevice(WacomCommonPtr common, unsigned int channel,
<br> /* otherwise, if no device matched... */
<br> else
<br> {
<br>- DBG(11, common->debugLevel, ErrorF("no device matches with"
<br>+ DBG(11, common->debugLevel, xf86Msg(X_INFO, "no device matches with"
<br> " id=%d, serial=%u\n",
<br> ds->device_type, ds->serial_num));
<br> }
<br>@@ -1704,7 +1704,7 @@ static void xf86WcmInitialTVScreens(LocalDevicePtr local)
<br> priv->screenBottomY[1] = priv->tvResolution[1];
<br> }
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmInitialTVScreens for \"%s\" "
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmInitialTVScreens for \"%s\" "
<br> "topX0=%d topY0=%d bottomX0=%d bottomY0=%d "
<br> "topX1=%d topY1=%d bottomX1=%d bottomY1=%d \n",
<br> local->name, priv->screenTopX[0], priv->screenTopY[0],
<br>@@ -1722,7 +1722,7 @@ void xf86WcmInitialScreens(LocalDevicePtr local)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> int i;
<br>
<br>- DBG(2, priv->debugLevel, ErrorF("xf86WcmInitialScreens for \"%s\" "
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmInitialScreens for \"%s\" "
<br> "number of screen=%d \n", local->name, screenInfo.numScreens));
<br> priv->tvoffsetX = 0;
<br> priv->tvoffsetY = 0;
<br>@@ -1747,7 +1747,7 @@ void xf86WcmInitialScreens(LocalDevicePtr local)
<br> priv->screenBottomX[i] = dixScreenOrigins[i].x;
<br> priv->screenBottomY[i] = dixScreenOrigins[i].y;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmInitialScreens from dix for \"%s\" "
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmInitialScreens from dix for \"%s\" "
<br> "ScreenOrigins[%d].x=%d ScreenOrigins[%d].y=%d \n",
<br> local->name, i, priv->screenTopX[i], i, priv->screenTopY[i]));
<br> }
<br>@@ -1755,7 +1755,7 @@ void xf86WcmInitialScreens(LocalDevicePtr local)
<br> priv->screenBottomX[i] += screenInfo.screens[i]->width;
<br> priv->screenBottomY[i] += screenInfo.screens[i]->height;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmInitialScreens for \"%s\" "
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmInitialScreens for \"%s\" "
<br> "topX[%d]=%d topY[%d]=%d bottomX[%d]=%d bottomY[%d]=%d \n",
<br> local->name, i, priv->screenTopX[i], i, priv->screenTopY[i],
<br> i, priv->screenBottomX[i], i, priv->screenBottomY[i]));
<br>@@ -1772,7 +1772,7 @@ static void rotateOneTool(WacomDevicePtr priv)
<br> WacomToolAreaPtr area = priv->toolarea;
<br> int tmpTopX, tmpTopY, tmpBottomX, tmpBottomY, oldMaxX, oldMaxY;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("rotateOneTool for \"%s\" \n", priv->local->name));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "rotateOneTool for \"%s\" \n", priv->local->name));
<br>
<br> if (!IsTouch(priv))
<br> {
<br>@@ -1850,7 +1850,7 @@ void xf86WcmRotateTablet(LocalDevicePtr local, int value)
<br> int oldRotation;
<br> int tmpTopX, tmpTopY, tmpBottomX, tmpBottomY, oldMaxX, oldMaxY;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmRotateTablet for \"%s\" \n", local->name));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmRotateTablet for \"%s\" \n", local->name));
<br>
<br> if (common->wcmRotate == value) /* initialization */
<br> {
<br>diff --git a/src/wcmConfig.c b/src/wcmConfig.c
<br>index 9a51596..7bd11db 100644
<br>--- a/src/wcmConfig.c
<br>+++ b/src/wcmConfig.c
<br>@@ -229,7 +229,7 @@ static void xf86WcmUninit(InputDriverPtr drv, LocalDevicePtr local, int flags)
<br> WacomDevicePtr dev;
<br> WacomDevicePtr *prev;
<br>
<br>- DBG(1, priv->debugLevel, ErrorF("xf86WcmUninit\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmUninit\n"));
<br>
<br> if (priv->isParent)
<br> {
<br>@@ -289,7 +289,7 @@ static Bool xf86WcmMatchDevice(LocalDevicePtr pMatch, LocalDevicePtr pLocal)
<br> strstr(pMatch->drv->driverName, "wacom") &&
<br> !strcmp(privMatch->common->wcmDevice, common->wcmDevice))
<br> {
<br>- DBG(2, priv->debugLevel, ErrorF(
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO,
<br> "xf86WcmInit wacom port share between"
<br> " %s and %s\n", pLocal->name, pMatch->name));
<br> type = xf86FindOptionValue(pMatch->options, "Type");
<br>diff --git a/src/wcmFilter.c b/src/wcmFilter.c
<br>index 2d87362..04549fc 100644
<br>--- a/src/wcmFilter.c
<br>+++ b/src/wcmFilter.c
<br>@@ -248,7 +248,7 @@ int xf86WcmFilterCoord(WacomCommonPtr common, WacomChannelPtr pChannel,
<br> WacomDeviceState *pLast;
<br> int *x, *y, i;
<br>
<br>- DBG(10, common->debugLevel, ErrorF("xf86WcmFilterCoord with "
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "xf86WcmFilterCoord with "
<br> "common->wcmRawSample = %d \n", common->wcmRawSample));
<br> x = pChannel->rawFilter.x;
<br> y = pChannel->rawFilter.y;
<br>diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c
<br>index 4c24f5f..65bcd1a 100644
<br>--- a/src/wcmISDV4.c
<br>+++ b/src/wcmISDV4.c
<br>@@ -123,7 +123,7 @@ static Bool isdv4Init(LocalDevicePtr local, char* id, float *version)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> WacomCommonPtr common = priv->common;
<br>
<br>- DBG(1, priv->debugLevel, ErrorF("initializing ISDV4 tablet\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "initializing ISDV4 tablet\n"));
<br>
<br> /* Initial baudrate is 38400 */
<br> if (xf86SetSerialSpeed(local->fd, common->wcmISDV4Speed) < 0)
<br>@@ -150,7 +150,7 @@ static int isdv4Query(LocalDevicePtr local, const char* query, char* data)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> WacomCommonPtr common = priv->common;
<br>
<br>- DBG(1, priv->debugLevel, ErrorF("Querying ISDV4 tablet\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "Querying ISDV4 tablet\n"));
<br>
<br> /* Send stop command to the tablet */
<br> err = xf86WriteSerial(local->fd, WC_ISDV4_STOP, strlen(WC_ISDV4_STOP));
<br>@@ -256,7 +256,7 @@ static int isdv4GetRanges(LocalDevicePtr local)
<br> WacomCommonPtr common = priv->common;
<br> int ret = Success;
<br>
<br>- DBG(2, priv->debugLevel, ErrorF("getting ISDV4 Ranges\n"));
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO, "getting ISDV4 Ranges\n"));
<br>
<br> /* Send query command to the tablet */
<br> ret = isdv4Query(local, WC_ISDV4_QUERY, data);
<br>@@ -281,7 +281,7 @@ static int isdv4GetRanges(LocalDevicePtr local)
<br> if (!common->wcmMaxX || !common->wcmMaxY)
<br> common->tablet_id = 0xE2;
<br>
<br>- DBG(2, priv->debugLevel, ErrorF("isdv4GetRanges Pen speed=%d "
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO, "isdv4GetRanges Pen speed=%d "
<br> "maxX=%d maxY=%d maxZ=%d resX=%d resY=%d \n",
<br> common->wcmISDV4Speed, common->wcmMaxX, common->wcmMaxY,
<br> common->wcmMaxZ, common->wcmResolX, common->wcmResolY));
<br>@@ -383,7 +383,7 @@ static int isdv4GetRanges(LocalDevicePtr local)
<br> common->wcmVersion = ( data[10] | (data[9] << 7) );
<br> ret = Success;
<br>
<br>- DBG(2, priv->debugLevel, ErrorF("isdv4GetRanges touch speed=%d "
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO, "isdv4GetRanges touch speed=%d "
<br> "maxTouchX=%d maxTouchY=%d TouchresX=%d TouchresY=%d \n",
<br> common->wcmISDV4Speed, common->wcmMaxTouchX,
<br> common->wcmMaxTouchY, common->wcmTouchResolX,
<br>@@ -417,7 +417,7 @@ static int isdv4Parse(LocalDevicePtr local, const unsigned char* data)
<br> WacomDeviceState* ds;
<br> int n, cur_type, channel = 0;
<br>
<br>- DBG(10, common->debugLevel, ErrorF("isdv4Parse \n"));
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "isdv4Parse \n"));
<br>
<br> /* determine the type of message (touch or stylus) */
<br> if (data[0] & 0x10) /* a touch data */
<br>@@ -490,7 +490,7 @@ static int isdv4Parse(LocalDevicePtr local, const unsigned char* data)
<br> }
<br> }
<br>
<br>- DBG(8, priv->debugLevel, ErrorF("isdv4Parse MultiTouch "
<br>+ DBG(8, priv->debugLevel, xf86Msg(X_INFO, "isdv4Parse MultiTouch "
<br> "%s proximity \n", ds->proximity ? "in" : "out of"));
<br> }
<br> else
<br>@@ -542,7 +542,7 @@ static int isdv4Parse(LocalDevicePtr local, const unsigned char* data)
<br> ds->device_id = ERASER_DEVICE_ID;
<br> }
<br>
<br>- DBG(8, priv->debugLevel, ErrorF("isdv4Parse %s\n",
<br>+ DBG(8, priv->debugLevel, xf86Msg(X_INFO, "isdv4Parse %s\n",
<br> ds->device_type == ERASER_ID ? "ERASER " :
<br> ds->device_type == STYLUS_ID ? "STYLUS" : "NONE"));
<br> }
<br>diff --git a/src/wcmUSB.c b/src/wcmUSB.c
<br>index b5b69a3..fb35498 100644
<br>--- a/src/wcmUSB.c
<br>+++ b/src/wcmUSB.c
<br>@@ -372,7 +372,7 @@ static Bool usbDetect(LocalDevicePtr local)
<br> #ifdef DEBUG
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br>
<br>- DBG(1, priv->debugLevel, ErrorF("usbDetect\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "usbDetect\n"));
<br> #endif
<br>
<br> SYSCALL(err = ioctl(local->fd, EVIOCGVERSION, &version));
<br>@@ -508,7 +508,7 @@ Bool usbWcmInit(LocalDevicePtr local, char* id, float *version)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> WacomCommonPtr common = priv->common;
<br>
<br>- DBG(1, priv->debugLevel, ErrorF("initializing USB tablet\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "initializing USB tablet\n"));
<br> *version = 0.0;
<br>
<br> /* fetch vendor, product, and model name */
<br>@@ -745,7 +745,7 @@ static int usbDetectConfig(LocalDevicePtr local)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> WacomCommonPtr common = priv->common;
<br>
<br>- DBG(10, common->debugLevel, ErrorF("usbDetectConfig \n"));
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "usbDetectConfig \n"));
<br> if (IsPad (priv))
<br> priv->nbuttons = common->npadkeys;
<br> else
<br>@@ -836,7 +836,7 @@ static int usbChooseChannel(WacomCommonPtr common, int serial)
<br> xf86WcmEvent(common, i, &common->wcmChannel[i].work);
<br> }
<br> }
<br>- DBG(1, common->debugLevel, ErrorF("usbParse (device with serial number: %u)"
<br>+ DBG(1, common->debugLevel, xf86Msg(X_INFO, "usbParse (device with serial number: %u)"
<br> " at %d: Exceeded channel count; ignoring the events.\n",
<br> serial, (int)GetTimeInMillis()));
<br> }
<br>@@ -853,7 +853,7 @@ static void usbParseEvent(LocalDevicePtr local,
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> WacomCommonPtr common = priv->common;
<br>
<br>- DBG(10, common->debugLevel, ErrorF("usbParseEvent \n"));
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "usbParseEvent \n"));
<br> /* store events until we receive the MSC_SERIAL containing
<br> * the serial number; without it we cannot determine the
<br> * correct channel. */
<br>@@ -913,7 +913,7 @@ static void usbParseEvent(LocalDevicePtr local,
<br> /* ignore events without information */
<br> if (common->wcmEventCnt <= 2)
<br> {
<br>- DBG(3, common->debugLevel, ErrorF("%s - usbParse: dropping empty event"
<br>+ DBG(3, common->debugLevel, xf86Msg(X_INFO, "%s - usbParse: dropping empty event"
<br> " for serial %d\n", local->name, common->wcmLastToolSerial));
<br> goto skipEvent;
<br> }
<br>@@ -946,7 +946,7 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> WacomCommonPtr common = priv->common;
<br>
<br>- DBG(6, common->debugLevel, ErrorF("usbParseChannel %d events received\n", common->wcmEventCnt));
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO, "usbParseChannel %d events received\n", common->wcmEventCnt));
<br> #define MOD_BUTTONS(bit, value) do { \
<br> shift = 1<<bit; \
<br> ds->buttons = (((value) != 0) ? \
<br>@@ -954,10 +954,10 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> } while (0)
<br>
<br> if (common->wcmEventCnt == 1 && !common->wcmEvents->type) {
<br>- DBG(6, common->debugLevel, ErrorF("usbParseChannel no real events received\n"));
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO, "usbParseChannel no real events received\n"));
<br> return;
<br> }
<br>- DBG(6, common->debugLevel, ErrorF("usbParseChannel %d events received\n", common->wcmEventCnt));
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO, "usbParseChannel %d events received\n", common->wcmEventCnt));
<br>
<br> /* all USB data operates from previous context except relative values*/
<br> ds = &common->wcmChannel[channel].work;
<br>@@ -968,7 +968,7 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> for (i=0; i<common->wcmEventCnt; ++i)
<br> {
<br> event = common->wcmEvents + i;
<br>- DBG(11, common->debugLevel, ErrorF("usbParseChannel "
<br>+ DBG(11, common->debugLevel, xf86Msg(X_INFO, "usbParseChannel "
<br> "event[%d]->type=%d code=%d value=%d\n",
<br> i, event->type, event->code, event->value));
<br>
<br>@@ -1025,7 +1025,7 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> if (common->wcmProtocolLevel == 4)
<br> ds->device_id = STYLUS_DEVICE_ID;
<br> ds->proximity = (event->value != 0);
<br>- DBG(6, common->debugLevel, ErrorF(
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO,
<br> "USB stylus detected %x\n",
<br> event->code));
<br> }
<br>@@ -1038,14 +1038,14 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> ds->proximity = (event->value != 0);
<br> if (ds->proximity)
<br> ds->proximity = ERASER_PROX;
<br>- DBG(6, common->debugLevel, ErrorF(
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO,
<br> "USB eraser detected %x (value=%d)\n",
<br> event->code, event->value));
<br> }
<br> else if ((event->code == BTN_TOOL_MOUSE) ||
<br> (event->code == BTN_TOOL_LENS))
<br> {
<br>- DBG(6, common->debugLevel, ErrorF(
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO,
<br> "USB mouse detected %x (value=%d)\n",
<br> event->code, event->value));
<br> ds->device_type = CURSOR_ID;
<br>@@ -1056,7 +1056,7 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> }
<br> else if (event->code == BTN_TOOL_FINGER)
<br> {
<br>- DBG(6, common->debugLevel, ErrorF(
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO,
<br> "USB Pad detected %x (value=%d)\n",
<br> event->code, event->value));
<br> ds->device_type = PAD_ID;
<br>@@ -1067,7 +1067,7 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> {
<br> WacomChannelPtr pChannel = common->wcmChannel + channel;
<br> WacomDeviceState dslast = pChannel->valid.state;
<br>- DBG(6, common->debugLevel, ErrorF(
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO,
<br> "USB Touch detected %x (value=%d)\n",
<br> event->code, event->value));
<br> ds->device_type = TOUCH_ID;
<br>@@ -1089,7 +1089,7 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> {
<br> WacomChannelPtr pChannel = common->wcmChannel + channel;
<br> WacomDeviceState dslast = pChannel->valid.state;
<br>- DBG(6, common->debugLevel, ErrorF(
<br>+ DBG(6, common->debugLevel, xf86Msg(X_INFO,
<br> "USB Touch second finger detected %x (value=%d)\n",
<br> event->code, event->value));
<br> ds->device_type = TOUCH_ID;
<br>@@ -1138,7 +1138,7 @@ static void usbParseChannel(LocalDevicePtr local, int channel)
<br> if (((common->tablet_id == 0xC0) || (common->tablet_id == 0xC2)) &&
<br> (ds->device_type == ERASER_ID))
<br> {
<br>- DBG(10, common->debugLevel, ErrorF("usbParseChannel "
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "usbParseChannel "
<br> "DTF 720 doesn't support eraser "));
<br> return;
<br> }
<br>diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c
<br>index 2ac7eed..94b3424 100644
<br>--- a/src/wcmXCommand.c
<br>+++ b/src/wcmXCommand.c
<br>@@ -50,7 +50,7 @@ int xf86WcmSetPadCoreMode(LocalDevicePtr local)
<br> /* Pad is always in relative mode when it's a core device.
<br> * Always in absolute mode when it is not a core device.
<br> */
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmSetPadCoreMode (%p)"
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSetPadCoreMode (%p)"
<br> " is always in %s mode when it %s core device\n",
<br> (void *)local->dev,
<br> !is_core ? "absolute" : "relative",
<br>@@ -71,7 +71,7 @@ int xf86WcmDevSwitchModeCall(LocalDevicePtr local, int mode)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> int is_absolute = priv->flags & ABSOLUTE_FLAG;
<br>
<br>- DBG(3, priv->debugLevel, ErrorF("xf86WcmSwitchModeCall for %s to mode=%d\n",
<br>+ DBG(3, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSwitchModeCall for %s to mode=%d\n",
<br> local->name, mode));
<br>
<br> /* Pad is always in relative mode when it's a core device.
<br>@@ -98,7 +98,7 @@ int xf86WcmDevSwitchModeCall(LocalDevicePtr local, int mode)
<br> }
<br> else if ( (mode != Absolute) && (mode != Relative))
<br> {
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmSwitchModeCall"
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSwitchModeCall"
<br> " for %s invalid mode=%d\n", local->name, mode));
<br> return BadMatch;
<br> }
<br>@@ -116,7 +116,7 @@ int xf86WcmDevSwitchMode(ClientPtr client, DeviceIntPtr dev, int mode)
<br> #ifdef DEBUG
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br>
<br>- DBG(3, priv->debugLevel, ErrorF("xf86WcmSwitchMode dev=%p mode=%d\n",
<br>+ DBG(3, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSwitchMode dev=%p mode=%d\n",
<br> (void *)dev, mode));
<br> #endif
<br> /* Share this call with sendAButton in wcmCommon.c */
<br>@@ -213,7 +213,7 @@ void InitWcmDeviceProperties(LocalDevicePtr local)
<br> WacomCommonPtr common = priv->common;
<br> int values[WCM_MAX_MOUSE_BUTTONS];
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("InitWcmDeviceProperties for %s \n", local->name));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "InitWcmDeviceProperties for %s \n", local->name));
<br>
<br> values[0] = priv->topX;
<br> values[1] = priv->topY;
<br>@@ -302,7 +302,7 @@ int xf86WcmSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop,
<br> WacomCommonPtr common = priv->common;
<br> static Atom btn_actions[WCM_MAX_MOUSE_BUTTONS] = { 0 };
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmSetProperty for %s \n", local->name));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSetProperty for %s \n", local->name));
<br>
<br> if (property == prop_tablet_area)
<br> {
<br>@@ -492,7 +492,7 @@ int xf86WcmSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop,
<br> {
<br> screen = -1;
<br> priv->currentScreen = 0;
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmSetProperty TwinView sets to "
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmSetProperty TwinView sets to "
<br> "TV_NONE: can't change screen_no. \n"));
<br> }
<br> xf86WcmChangeScreen(local, screen);
<br>diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c
<br>index d4cb1fe..9e42b30 100644
<br>--- a/src/xf86Wacom.c
<br>+++ b/src/xf86Wacom.c
<br>@@ -148,7 +148,7 @@ static int xf86WcmInitArea(LocalDevicePtr local)
<br> double screenRatio, tabletRatio;
<br> int bottomx = common->wcmMaxX, bottomy = common->wcmMaxY;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmInitArea\n"));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmInitArea\n"));
<br>
<br> if (IsTouch(priv))
<br> {
<br>@@ -208,7 +208,7 @@ static int xf86WcmInitArea(LocalDevicePtr local)
<br> tabletRatio = ((double)(bottomx - priv->topX) /
<br> (double)(bottomy - priv->topY));
<br>
<br>- DBG(2, priv->debugLevel, ErrorF("screenRatio = %.3g, "
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO, "screenRatio = %.3g, "
<br> "tabletRatio = %.3g\n", screenRatio, tabletRatio));
<br>
<br> if (screenRatio > tabletRatio)
<br>@@ -296,7 +296,7 @@ void xf86WcmVirtaulTabletPadding(LocalDevicePtr local)
<br> priv->topPadding = (int)((double)(priv->screenTopY[i] * priv->topPadding)
<br> / ((double)(priv->screenBottomY[i] - priv->screenTopY[i])) + 0.5);
<br> }
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmVirtaulTabletPadding for \"%s\" "
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmVirtaulTabletPadding for \"%s\" "
<br> "x=%d y=%d \n", local->name, priv->leftPadding, priv->topPadding));
<br> return;
<br> }
<br>@@ -336,7 +336,7 @@ void xf86WcmVirtaulTabletSize(LocalDevicePtr local)
<br> priv->sizeY += (int)((double)((priv->maxHeight - priv->screenBottomY[i])
<br> * tabletSize) / ((double)(priv->screenBottomY[i] - priv->screenTopY[i])) + 0.5);
<br> }
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmVirtaulTabletSize for \"%s\" "
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmVirtaulTabletSize for \"%s\" "
<br> "x=%d y=%d \n", local->name, priv->sizeX, priv->sizeY));
<br> return;
<br> }
<br>@@ -656,7 +656,7 @@ static int xf86WcmRegisterX11Devices (LocalDevicePtr local)
<br> * This is only a workaround.
<br> */
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmRegisterX11Devices "
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmRegisterX11Devices "
<br> "(%s) %d buttons, %d keys, %d axes\n",
<br> IsStylus(priv) ? "stylus" :
<br> IsCursor(priv) ? "cursor" :
<br>@@ -976,7 +976,7 @@ static Bool xf86WcmOpen(LocalDevicePtr local)
<br> int rc;
<br> struct serial_struct ser;
<br>
<br>- DBG(1, priv->debugLevel, ErrorF("opening %s\n", common->wcmDevice));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "opening %s\n", common->wcmDevice));
<br>
<br> local->fd = xf86OpenSerial(local->options);
<br> if (local->fd < 0)
<br>@@ -1035,7 +1035,7 @@ static int xf86WcmDevOpen(DeviceIntPtr pWcm)
<br> WacomCommonPtr common = priv->common;
<br> struct stat st;
<br>
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmDevOpen\n"));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmDevOpen\n"));
<br>
<br> /* Device has been open and not autoprobed */
<br> if (priv->wcmDevOpenCount)
<br>@@ -1052,11 +1052,11 @@ static int xf86WcmDevOpen(DeviceIntPtr pWcm)
<br> if ((xf86WcmOpen (local) != Success) || (local->fd < 0) ||
<br> !common->wcmDevice)
<br> {
<br>- DBG(1, priv->debugLevel, ErrorF("Failed to open "
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "Failed to open "
<br> "device (fd=%d)\n", local->fd));
<br> if (local->fd >= 0)
<br> {
<br>- DBG(1, priv->debugLevel, ErrorF("Closing device\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "Closing device\n"));
<br> xf86CloseSerial(local->fd);
<br> }
<br> local->fd = -1;
<br>@@ -1098,7 +1098,7 @@ static int xf86WcmReady(LocalDevicePtr local)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> #endif
<br> int n = xf86WaitForInput(local->fd, 0);
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmReady for %s with %d numbers of data\n", local->name, n));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmReady for %s with %d numbers of data\n", local->name, n));
<br>
<br> if (n >= 0) return n ? 1 : 0;
<br> xf86Msg(X_ERROR, "%s: select error: %s\n", local->name, strerror(errno));
<br>@@ -1130,9 +1130,9 @@ static void xf86WcmDevReadInput(LocalDevicePtr local)
<br>
<br> /* report how well we're doing */
<br> if (loop >= MAX_READ_LOOPS)
<br>- DBG(1, priv->debugLevel, ErrorF("xf86WcmDevReadInput: Can't keep up!!!\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmDevReadInput: Can't keep up!!!\n"));
<br> else if (loop > 0)
<br>- DBG(10, priv->debugLevel, ErrorF("xf86WcmDevReadInput: Read (%d)\n",loop));
<br>+ DBG(10, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmDevReadInput: Read (%d)\n",loop));
<br> }
<br>
<br> void xf86WcmReadPacket(LocalDevicePtr local)
<br>@@ -1142,12 +1142,12 @@ void xf86WcmReadPacket(LocalDevicePtr local)
<br> int len, pos, cnt, remaining;
<br> unsigned char * data;
<br>
<br>- DBG(10, common->debugLevel, ErrorF("xf86WcmReadPacket: device=%s"
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "xf86WcmReadPacket: device=%s"
<br> " fd=%d \n", common->wcmDevice, local->fd));
<br>
<br> remaining = sizeof(common->buffer) - common->bufpos;
<br>
<br>- DBG(1, common->debugLevel, ErrorF("xf86WcmReadPacket: pos=%d"
<br>+ DBG(1, common->debugLevel, xf86Msg(X_INFO, "xf86WcmReadPacket: pos=%d"
<br> " remaining=%d\n", common->bufpos, remaining));
<br>
<br> /* fill buffer with as much data as we can handle */
<br>@@ -1171,7 +1171,7 @@ void xf86WcmReadPacket(LocalDevicePtr local)
<br>
<br> /* account for new data */
<br> common->bufpos += len;
<br>- DBG(10, common->debugLevel, ErrorF("xf86WcmReadPacket buffer has %d bytes\n",
<br>+ DBG(10, common->debugLevel, xf86Msg(X_INFO, "xf86WcmReadPacket buffer has %d bytes\n",
<br> common->bufpos));
<br>
<br> pos = 0;
<br>@@ -1203,7 +1203,7 @@ void xf86WcmReadPacket(LocalDevicePtr local)
<br> cnt = common->wcmModel->Parse(local, common->buffer + pos);
<br> if (cnt <= 0)
<br> {
<br>- DBG(1, common->debugLevel, ErrorF("Misbehaving parser returned %d\n",cnt));
<br>+ DBG(1, common->debugLevel, xf86Msg(X_INFO, "Misbehaving parser returned %d\n",cnt));
<br> break;
<br> }
<br> pos += cnt;
<br>@@ -1214,7 +1214,7 @@ void xf86WcmReadPacket(LocalDevicePtr local)
<br> /* if half a packet remains, move it down */
<br> if (pos < common->bufpos)
<br> {
<br>- DBG(7, common->debugLevel, ErrorF("MOVE %d bytes\n", common->bufpos - pos));
<br>+ DBG(7, common->debugLevel, xf86Msg(X_INFO, "MOVE %d bytes\n", common->bufpos - pos));
<br> memmove(common->buffer,common->buffer+pos,
<br> common->bufpos-pos);
<br> common->bufpos -= pos;
<br>@@ -1232,7 +1232,7 @@ int xf86WcmDevChangeControl(LocalDevicePtr local, xDeviceCtl * control)
<br> {
<br> #ifdef DEBUG
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br>- DBG(3, priv->debugLevel, ErrorF("xf86WcmDevChangeControl called\n"));
<br>+ DBG(3, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmDevChangeControl called\n"));
<br> #endif
<br> return Success;
<br> }
<br>@@ -1247,7 +1247,7 @@ static void xf86WcmDevControlProc(DeviceIntPtr device, PtrCtrl* ctrl)
<br> LocalDevicePtr local = (LocalDevicePtr)device->public.devicePrivate;
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br>
<br>- DBG(4, priv->debugLevel, ErrorF("Wacom Dev Control Proc called\n"));
<br>+ DBG(4, priv->debugLevel, xf86Msg(X_INFO, "Wacom Dev Control Proc called\n"));
<br> #endif
<br> return;
<br> }
<br>@@ -1261,14 +1261,14 @@ static void xf86WcmDevClose(LocalDevicePtr local)
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br> WacomCommonPtr common = priv->common;
<br>
<br>- DBG(4, priv->debugLevel, ErrorF("Wacom number of open devices = %d\n", common->fd_refs));
<br>+ DBG(4, priv->debugLevel, xf86Msg(X_INFO, "Wacom number of open devices = %d\n", common->fd_refs));
<br>
<br> if (local->fd >= 0)
<br> {
<br> local->fd = -1;
<br> if (!--common->fd_refs)
<br> {
<br>- DBG(1, common->debugLevel, ErrorF("Closing device; uninitializing.\n"));
<br>+ DBG(1, common->debugLevel, xf86Msg(X_INFO, "Closing device; uninitializing.\n"));
<br> xf86CloseSerial (common->fd);
<br> }
<br> }
<br>@@ -1284,7 +1284,7 @@ static int xf86WcmDevProc(DeviceIntPtr pWcm, int what)
<br> LocalDevicePtr local = (LocalDevicePtr)pWcm->public.devicePrivate;
<br> WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br>
<br>- DBG(2, priv->debugLevel, ErrorF("BEGIN xf86WcmProc dev=%p priv=%p "
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO, "BEGIN xf86WcmProc dev=%p priv=%p "
<br> "type=%s(%s) flags=%d fd=%d what=%s\n",
<br> (void *)pWcm, (void *)priv,
<br> IsStylus(priv) ? "stylus" :
<br>@@ -1306,7 +1306,7 @@ static int xf86WcmDevProc(DeviceIntPtr pWcm, int what)
<br> priv->wcmInitKeyClassCount = 0;
<br> if (!xf86WcmDevOpen(pWcm))
<br> {
<br>- DBG(1, priv->debugLevel, ErrorF("xf86WcmProc INIT FAILED\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmProc INIT FAILED\n"));
<br> return !Success;
<br> }
<br> priv->wcmInitKeyClassCount++;
<br>@@ -1316,7 +1316,7 @@ static int xf86WcmDevProc(DeviceIntPtr pWcm, int what)
<br> case DEVICE_ON:
<br> if (!xf86WcmDevOpen(pWcm))
<br> {
<br>- DBG(1, priv->debugLevel, ErrorF("xf86WcmProc ON FAILED\n"));
<br>+ DBG(1, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmProc ON FAILED\n"));
<br> return !Success;
<br> }
<br> priv->wcmDevOpenCount++;
<br>@@ -1341,7 +1341,7 @@ static int xf86WcmDevProc(DeviceIntPtr pWcm, int what)
<br> break;
<br> } /* end switch */
<br>
<br>- DBG(2, priv->debugLevel, ErrorF("END xf86WcmProc Success \n"));
<br>+ DBG(2, priv->debugLevel, xf86Msg(X_INFO, "END xf86WcmProc Success \n"));
<br> return Success;
<br> }
<br>
<br>@@ -1356,7 +1356,7 @@ static Bool xf86WcmDevConvert(LocalDevicePtr local, int first, int num,
<br> {
<br> WacomDevicePtr priv = (WacomDevicePtr) local->private;
<br>
<br>- DBG(6, priv->debugLevel, ErrorF("xf86WcmDevConvert v0=%d v1=%d on screen %d \n",
<br>+ DBG(6, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmDevConvert v0=%d v1=%d on screen %d \n",
<br> v0, v1, priv->currentScreen));
<br>
<br> if (first != 0 || num == 1)
<br>@@ -1392,7 +1392,7 @@ static Bool xf86WcmDevConvert(LocalDevicePtr local, int first, int num,
<br> if (*y < 0) *y = 0;
<br>
<br> }
<br>- DBG(6, priv->debugLevel, ErrorF("xf86WcmDevConvert v0=%d v1=%d to x=%d y=%d\n", v0, v1, *x, *y));
<br>+ DBG(6, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmDevConvert v0=%d v1=%d to x=%d y=%d\n", v0, v1, *x, *y));
<br> return TRUE;
<br> }
<br>
<br>@@ -1409,7 +1409,7 @@ static Bool xf86WcmDevReverseConvert(LocalDevicePtr local, int x, int y,
<br> WacomDevicePtr priv = (WacomDevicePtr) local->private;
<br> int i = 0;
<br>
<br>- DBG(6, priv->debugLevel, ErrorF("xf86WcmDevReverseConvert x=%d y=%d \n", x, y));
<br>+ DBG(6, priv->debugLevel, xf86Msg(X_INFO, "xf86WcmDevReverseConvert x=%d y=%d \n", x, y));
<br> priv->currentSX = x;
<br> priv->currentSY = y;
<br>
<br>@@ -1430,7 +1430,7 @@ static Bool xf86WcmDevReverseConvert(LocalDevicePtr local, int x, int y,
<br> priv->devReverseCount = 0;
<br> }
<br>
<br>- DBG(6, priv->debugLevel, ErrorF("Wacom converted x=%d y=%d"
<br>+ DBG(6, priv->debugLevel, xf86Msg(X_INFO, "Wacom converted x=%d y=%d"
<br> " to v0=%d v1=%d v2=%d v3=%d v4=%d v5=%d\n", x, y,
<br> valuators[0], valuators[1], valuators[2],
<br> valuators[3], valuators[4], valuators[5]));
<br>--
<br>1.6.5.2
<br><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26787209&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26785845Re: [PATCH] touch and gesture options2009-12-14T14:08:44Z2009-12-14T14:08:44ZPing@LinuxWacomOn Sun, Dec 13, 2009 at 9:38 PM, Peter Hutterer <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26785845&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>On Fri, Dec 11, 2009 at 02:11:34PM -0800, Ping wrote:<br>
> > need to look at the code but I noticed here we check for that option twice,<br>
> > once in wcmUSB.c, once in wcmValidateDevice. may be something to keep an<br>
> > eye<br>
> > on?<br>
> ><br>
><br>
> The check is needed for both files. In wcmValidateDevice.c, it is to<br>
> initialize the value for all devices that are defined in xorg.conf. Later<br>
> on in wcmUSB.c (and wcmISDV4.c as well), they are reassigned due the<br>
> possible changes in device specific features.<br>
><br>
> Let me know if this confuses you more.<br>
<br>
</div>it does, a bit anyway.<br>
the device-specific features are the enabling of touch, etc. based on the<br>
device's capabilities, right? (like the hunk below).<br>
<br>
AIUI, these capabilities don't change during the runtime of a device. if so,<br>
usbWcmInit is the wrong place to put the checks, it's called every time the<br>
device is opened and that seems a bit excessive. </blockquote><div><br>I see your point. We can easily move this to wcmValidateDevice.c for USB. But it would be a challenge for ISDV4 devices since the driver may not get the accurate feature until it talks to the device directly in Wacom mode. Anyway, I made a clean, I think :), patch. ISDV4 would need more work later. But this patch covers the ISDV4 devices that we see in the market now.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">(also, it looks like this<br>
is the cause for the touch property being overwritten when you resume from<br>
suspend :)<br></blockquote><div><br>Unfortunately, your "kill two birds with one stone" plan did not work :). The property resume issue stays even with the new patch. In fact, if you hardcode both wcmTouch and wcmTouchDefault to 1 without changing it anywhere else in the driver, wcmTouch got changed to 0 after the system resumes. I am running a 64 bit system. Maybe that makes a difference? Something fishy in InitWcmAtom.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I think what we need here is something similar to the EvdevProbe() function<br>
- a function that opens the device, checks the capabilities and sets the<br>
required flags so that xf86WcmDevOpen and it's childs can be reduced to<br>
little more than fd = open(device).<br></blockquote><div><br>Let me know if my solution is acceptable or not. It is only called once now if that was your major concern.<br><br>Ping<br></div></div>
<br /><tt>[0001-Set-Touch-and-Gesture-options-during-the-configurati.patch]</tt><br /><hr align="left" width="300" /><tt>From 5df49f641cb331646f6cbfb0975a9661f23e7a4e Mon Sep 17 00:00:00 2001
<br>From: Ping Cheng <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26785845&i=1" target="_top" rel="nofollow">pingc@...</a>>
<br>Date: Mon, 14 Dec 2009 13:04:04 -0800
<br>Subject: [PATCH] Set Touch and Gesture options during the configuration
<br><br>We moved the touch and gesture option check from usbWcmInit
<br>to wcmValidateDevice.c since usbWcmInit gets called every time
<br>the device is opened, which is unnecessary for option check
<br>in most cases.
<br><br>The Tablet PC Button option should also be dealt in the same way.
<br>But it requires extra defines to make it clean, which will affect
<br>more files in the driver. We'll do it in a separate patch later.
<br><br>Signed-off-by: Ping Cheng <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26785845&i=2" target="_top" rel="nofollow">pinglinux@...</a>>
<br>---
<br> src/wcmConfig.c | 37 ++++++++++++++++++++++++++++++++++++-
<br> src/wcmISDV4.c | 16 ----------------
<br> src/wcmUSB.c | 25 +------------------------
<br> src/wcmValidateDevice.c | 7 -------
<br> 4 files changed, 37 insertions(+), 48 deletions(-)
<br><br>diff --git a/src/wcmConfig.c b/src/wcmConfig.c
<br>index 9a51596..cf7f2ab 100644
<br>--- a/src/wcmConfig.c
<br>+++ b/src/wcmConfig.c
<br>@@ -37,6 +37,7 @@ extern void wcmHotplugOthers(LocalDevicePtr local, unsigned long* keys);
<br> extern int wcmDeviceTypeKeys(LocalDevicePtr local, unsigned long* keys);
<br>
<br> static int xf86WcmAllocate(LocalDevicePtr local, char* name, int flag);
<br>+static void wcmDeviceSpecCommonOptions(LocalDevicePtr local, unsigned long* keys);
<br>
<br> /*****************************************************************************
<br> * xf86WcmAllocate --
<br>@@ -312,6 +313,37 @@ static Bool xf86WcmMatchDevice(LocalDevicePtr pMatch, LocalDevicePtr pLocal)
<br> return 0;
<br> }
<br>
<br>+/* retrieve the specific options for the device */
<br>+static void wcmDeviceSpecCommonOptions(LocalDevicePtr local, unsigned long* keys)
<br>+{
<br>+ WacomDevicePtr priv = (WacomDevicePtr)local->private;
<br>+ WacomCommonPtr common = priv->common;
<br>+
<br>+ /* a single touch device */
<br>+ if (ISBITSET (keys, BTN_TOOL_DOUBLETAP))
<br>+ {
<br>+ /* TouchDefault was off for all devices
<br>+ * except when touch is supported */
<br>+ common->wcmTouchDefault = 1;
<br>+ }
<br>+
<br>+ /* 2FG touch device */
<br>+ if (ISBITSET (keys, BTN_TOOL_TRIPLETAP))
<br>+ {
<br>+ /* GestureDefault was off for all devices
<br>+ * except when multi-touch is supported */
<br>+ common->wcmGestureDefault = 1;
<br>+ }
<br>+
<br>+ /* check if touch was turned off in xorg.conf */
<br>+ common->wcmTouch = xf86SetBoolOption(local->options, "Touch",
<br>+ common->wcmTouchDefault);
<br>+
<br>+ /* Touch gesture applies to the whole tablet */
<br>+ common->wcmGesture = xf86SetBoolOption(local->options, "Gesture",
<br>+ common->wcmGestureDefault);
<br>+}
<br>+
<br> /* xf86WcmInit - called for each input devices with the driver set to
<br> * "wacom" */
<br> static LocalDevicePtr xf86WcmInit(InputDriverPtr drv, IDevPtr dev, int flags)
<br>@@ -384,7 +416,10 @@ static LocalDevicePtr xf86WcmInit(InputDriverPtr drv, IDevPtr dev, int flags)
<br> }
<br> }
<br>
<br>- /* Process the common options. */
<br>+ /* update device specific common options */
<br>+ wcmDeviceSpecCommonOptions(local, keys);
<br>+
<br>+ /* Process the general common options. */
<br> xf86ProcessCommonOptions(local, local->options);
<br> if (!wcmParseOptions(local))
<br> goto SetupProc_fail;
<br>diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c
<br>index 4c24f5f..963d6ef 100644
<br>--- a/src/wcmISDV4.c
<br>+++ b/src/wcmISDV4.c
<br>@@ -362,23 +362,7 @@ static int isdv4GetRanges(LocalDevicePtr local)
<br> (int)(1 << data[1]);
<br>
<br> if (data[1])
<br>- {
<br> common->wcmTouchResolX = common->wcmTouchResolY = 10;
<br>- common->wcmTouchDefault = 1;
<br>- }
<br>- else
<br>- common->wcmTouchDefault = 0;
<br>-
<br>- /* update touch info */
<br>- common->wcmTouch = xf86SetBoolOption(local->options, "Touch",
<br>- common->wcmTouchDefault);
<br>-
<br>- if ((common->tablet_id == 0xE2) ||
<br>- (common->tablet_id == 0xE3))
<br>- common->wcmGestureDefault = 1;
<br>-
<br>- common->wcmGesture = xf86SetBoolOption(local->options, "Gesture",
<br>- common->wcmGestureDefault);
<br>
<br> common->wcmVersion = ( data[10] | (data[9] << 7) );
<br> ret = Success;
<br>diff --git a/src/wcmUSB.c b/src/wcmUSB.c
<br>index b5b69a3..ff5d875 100644
<br>--- a/src/wcmUSB.c
<br>+++ b/src/wcmUSB.c
<br>@@ -535,28 +535,13 @@ Bool usbWcmInit(LocalDevicePtr local, char* id, float *version)
<br> common->wcmResolY = WacomModelDesc [i].yRes;
<br> }
<br>
<br>- /* a single touch device */
<br>- if (ISBITSET (keys, BTN_TOOL_DOUBLETAP))
<br>- {
<br>- /* TouchDefault was off for all devices
<br>- * except when touch is supported */
<br>- common->wcmTouchDefault = 1;
<br>- }
<br>- else if (common->wcmModel &&
<br>+ if (common->wcmModel &&
<br> strstr(common->wcmModel->name, "TabletPC"))
<br> {
<br> /* For penabled Tablet PCs, Tablet PC Button
<br> * are on by default */
<br> common->wcmTPCButtonDefault = 1;
<br> }
<br>-
<br>- /* 2FG touch device */
<br>- if (ISBITSET (keys, BTN_TOOL_TRIPLETAP))
<br>- {
<br>- /* GestureDefault was off for all devices
<br>- * except when multi-touch is supported */
<br>- common->wcmGestureDefault = 1;
<br>- }
<br> }
<br>
<br> if (!common->wcmModel)
<br>@@ -565,14 +550,6 @@ Bool usbWcmInit(LocalDevicePtr local, char* id, float *version)
<br> common->wcmResolX = common->wcmResolY = 1016;
<br> }
<br>
<br>- /* check if touch was turned off in xorg.conf */
<br>- common->wcmTouch = xf86SetBoolOption(local->options, "Touch",
<br>- common->wcmTouchDefault);
<br>-
<br>- /* Touch gesture applies to the whole tablet */
<br>- common->wcmGesture = xf86SetBoolOption(local->options, "Gesture",
<br>- common->wcmGestureDefault);
<br>-
<br> /* check if TPCButton was turned off in xorg.conf for pen */
<br> if (priv->flags & STYLUS_ID)
<br> common->wcmTPCButton = xf86SetBoolOption(local->options,
<br>diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
<br>index 53d435f..52ce1f8 100644
<br>--- a/src/wcmValidateDevice.c
<br>+++ b/src/wcmValidateDevice.c
<br>@@ -615,13 +615,6 @@ int wcmParseOptions(LocalDevicePtr local)
<br> "TPCButton",
<br> common->wcmTPCButtonDefault);
<br>
<br>- /* Touch applies to the whole tablet */
<br>- common->wcmTouch = xf86SetBoolOption(local->options, "Touch", common->wcmTouchDefault);
<br>-
<br>- /* Touch gesture applies to the whole tablet */
<br>- common->wcmGesture = xf86SetBoolOption(local->options, "Gesture",
<br>- common->wcmGestureDefault);
<br>-
<br> /* Touch capacity applies to the whole tablet */
<br> common->wcmCapacity = xf86SetBoolOption(local->options, "Capacity", common->wcmCapacityDefault);
<br>
<br>--
<br>1.6.5.2
<br><br></tt><hr align="left" width="300" /><br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26785845&i=3" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26785851Re: Wacom Intuos4, xorg 1.7.12009-12-14T14:08:20Z2009-12-14T14:08:20ZJim Henderson-4On Mon, 14 Dec 2009 14:01:10 -0800, Ping wrote:
<br><div class='shrinkable-quote'><br>>> > Do you have a patch for us ? As you can tell, Peter and I are both
<br>>> > handful......
<br>>>
<br>>> I thought the patch that had been previously committed for this had
<br>>> been accepted - was it not?
<br>>>
<br>>>
<br>> Yes and no. Nick's kernel patches (
<br>> <a href="http://mail.google.com/mail/?shva=1#inbox/1251cce3cd5abd37" target="_top" rel="nofollow">http://mail.google.com/mail/?shva=1#inbox/1251cce3cd5abd37</a>) can be
<br>> considered as accepted. But, without an X driver to properly support
<br>> the feature, it is hard to use for most users. Not everyone is as savvy
<br>> as you are on Linux, don't you agree . I remember Nick said he will add
<br>> the feature to X wacom_drv.so when he has time. So, if Casper can do
<br>> the job now, we may get the feature sooner, hopefully .
</div><br>OK, this makes sense to me. :-) And I agree, not everyone has my sense
<br>of adventure with Linux. Over the holiday break, I'm taking some
<br>vacation at home, so I can put 11.2 on a spare laptop I have here and do
<br>some testing if that would help out.
<br><div class='shrinkable-quote'><br>> I've been following to see how development is coming along on support
<br>> for
<br>>> Xorg 1.7.x as I'm waiting to upgrade to openSUSE 11.2 for the support
<br>>> to be completed.
<br>>>
<br>> We have to bring the two code bases, xf86-input-wacom and linuxwacom,
<br>> in-sync before we can add more features. You may aware that we are
<br>> desperately working on this issue right now. I am extremely grateful
<br>> that Peter Hutterer, one of the key x.org developers from Red Hat, is
<br>> helping us to port linuxwacom to X server 1.7 and later. Without his
<br>> help, there is no way for me to manage all these supports. We only have
<br>> 24 hours a day anyway .
</div><br>Yep, and I for one really appreciate the work you and the other
<br>developers are doing on this. :-)
<br><br>>> I'm still using the kernel driver patch that was submitted a couple
<br>>> months ago for OLED support and it still seems to be working well.
<br>>>
<br>>>
<br>> It is not just a kernel driver issue if we want the feature a little bit
<br>> user friendly. Hope you agree with me.
<br><br>100% agreement. :-)
<br><br>Jim
<br><br>--
<br> Jim Henderson
<br> Please keep on-topic replies on the list so everyone benefits
<br><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26785851&i=0" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26785713Re: Wacom Intuos4, xorg 1.7.12009-12-14T14:01:10Z2009-12-14T14:01:10ZPing@LinuxWacomHi Jim,<br><br>Sorry for not making my point clear in my last email (too focused on replying Casper's main questions :). Please see my comments inline.<br><br>Ping<br><br><div class="gmail_quote">On Mon, Dec 14, 2009 at 1:25 PM, Jim Henderson <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26785713&i=0" target="_top" rel="nofollow">hendersj@...</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>On Mon, 14 Dec 2009 12:10:04 -0800, Ping wrote:<br>
<br>
>> When that is solved…. Is there a way to control the LED and LCD on the<br>
>> tablet.<br>
>><br>
>><br>
> Do you have a patch for us ? As you can tell, Peter and I are both<br>
> handful......<br>
<br>
</div>I thought the patch that had been previously committed for this had been<br>
accepted - was it not?<br></blockquote><div><br>Yes and no. Nick's kernel patches ( <a href="http://mail.google.com/mail/?shva=1#inbox/1251cce3cd5abd37" target="_blank" rel="nofollow">http://mail.google.com/mail/?shva=1#inbox/1251cce3cd5abd37</a>) can be considered as accepted. But, without an X driver to properly support the feature, it is hard to use for most users. Not everyone is as savvy as you are on Linux, don't you agree :). I remember Nick said he will add the feature to X wacom_drv.so when he has time. So, if Casper can do the job now, we may get the feature sooner, hopefully :). <br>
<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I've been following to see how development is coming along on support for<br>
Xorg 1.7.x as I'm waiting to upgrade to openSUSE 11.2 for the support to<br>
be completed.<br></blockquote><div><br>We have to bring the two code bases, xf86-input-wacom and linuxwacom, in-sync before we can add more features. You may aware that we are desperately working on this issue right now. I am extremely grateful that Peter Hutterer, one of the key <a href="http://x.org" target="_top" rel="nofollow">x.org</a> developers from Red Hat, is helping us to port linuxwacom to X server 1.7 and later. Without his help, there is no way for me to manage all these supports. We only have 24 hours a day anyway :).<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
I'm still using the kernel driver patch that was submitted a couple<br>
months ago for OLED support and it still seems to be working well.<br></blockquote><div><br>It is not just a kernel driver issue if we want the feature a little bit user friendly. Hope you agree with me.<br><br>Ping<br>
</div></div>
<br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26785713&i=1" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26785174Re: Wacom Intuos4, xorg 1.7.12009-12-14T13:25:26Z2009-12-14T13:25:26ZJim Henderson-4On Mon, 14 Dec 2009 12:10:04 -0800, Ping wrote:
<br><br>>> When that is solved…. Is there a way to control the LED and LCD on the
<br>>> tablet.
<br>>>
<br>>>
<br>> Do you have a patch for us ? As you can tell, Peter and I are both
<br>> handful......
<br><br>I thought the patch that had been previously committed for this had been
<br>accepted - was it not?
<br><br>I've been following to see how development is coming along on support for
<br>Xorg 1.7.x as I'm waiting to upgrade to openSUSE 11.2 for the support to
<br>be completed.
<br><br>I'm still using the kernel driver patch that was submitted a couple
<br>months ago for OLED support and it still seems to be working well.
<br><br>Jim
<br>--
<br> Jim Henderson
<br> Please keep on-topic replies on the list so everyone benefits
<br><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26785174&i=0" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26784602Re: [PATCH] Remove area overlap check for area property.2009-12-14T12:51:39Z2009-12-14T12:51:39ZPing@LinuxWacomOn Sun, Dec 13, 2009 at 10:57 PM, Peter Hutterer <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26784602&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
This check would cause setting of the property to fail since -<br>
especially if only one coordinate is modified - overlap was virtually<br>
guaranteed to happen.<br></blockquote><div><br>Then, WcmPointInArea should be changed from<br><br> if (area->topX <= x && x <= area->bottomX &&<br> area->topY <= y && y <= area->bottomY)<br>
To<br><br> if (area->topX < x && x < area->bottomX &&<br> area->topY < y && y < area->bottomY)<br><br>Some thing else may need to be updated with this change. But, this should fix the overlap issue. You can apply this change. I will look into the other possible changes once I get there. Area is a low priority issue for our current work, I think.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Each tool only has a single area, so this check doesn't seem necessary.<br></blockquote><div><br>We are not verifying the area that is associated with the tool we are using. We are verifying the other areas in the list. WcmAreaListOverlap has this line:<br>
<br> if (area != list && WcmAreasOverlap(list, area))<br><br>Ping<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Signed-off-by: Peter Hutterer <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26784602&i=1" target="_top" rel="nofollow">peter.hutterer@...</a>><br>
---<br>
If I understand this correctly, priv->tool->arealist is this tool's area, so<br>
the check for the area overlap is superfluous here (especially since it<br>
always produces overlaps).<br>
<br>
src/wcmXCommand.c | 4 ----<br>
1 files changed, 0 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c<br>
index 23402c3..4dd4be1 100644<br>
--- a/src/wcmXCommand.c<br>
+++ b/src/wcmXCommand.c<br>
@@ -317,10 +317,6 @@ int xf86WcmSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop,<br>
area.bottomX = values[2];<br>
area.bottomY = values[3];<br>
<br>
- /* FIXME: this will always be the case? */<br>
- if (WcmAreaListOverlap(&area, priv->tool->arealist))<br>
- return BadValue;<br>
-<br>
if (!checkonly)<br>
{<br>
/* Invalid range resets axis to defaults */<br>
<font color="#888888">--<br>
1.6.5.2<br>
<br>
</font></blockquote></div><br>
<br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26784602&i=2" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26784123Re: Intuos3 stylus tilt precision2009-12-14T12:20:49Z2009-12-14T12:20:49ZPing@LinuxWacomOn Sun, Dec 13, 2009 at 12:47 PM, Nicolas Carranza <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26784123&i=0" target="_top" rel="nofollow">nicarran@...</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I have some questions about tilt precision on an Intuos3. Using the linux<br>
wacom driver I get stylus tilt values on the x axis ranging from -64 to +63<br>
(tested using xidump). While on Windows I get stylus tilt values ranging<br>
from -60 to 60 (tested using wintab and also the Wacom Tabler Properties<br>
utility (About->Diagnose...) ) apparently over the same physical range (but<br>
this is hard to say as the difference is only ~3deg). My questions are:<br>
* Why does the linux-wacom driver get a wider range on linux using the same<br>
hardware?<br></blockquote><div><br>We report raw data on Linux while Windows reports modified data. Tilt raw data is reported from -64 to 63 by the hardware.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
* How precise is the Intuos3 stylus and the linux-wacom driver when reporting<br>
tilt angle? Is there a specified error (+/-X deg) to take into account?<br></blockquote><div><br>I'd say as accurate as the tablet reports to us. However, considering we have a default of 2 for Suppress (<a href="http://linuxwacom.sourceforge.net/index.php/howto/inputdev" target="_top" rel="nofollow">http://linuxwacom.sourceforge.net/index.php/howto/inputdev</a>), you may get 2 counts of offset if you didn't change Suppress yourself <br>
<br>Ping<br></div></div>
<br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26784123&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26783984Re: Wacom Intuos4, xorg 1.7.12009-12-14T12:10:04Z2009-12-14T12:10:04ZPing@LinuxWacomThank you Casper for the update. Also a big thank you for testing xsetwacom for us. See my comments inline.<br><br>Ping<br><br><div class="gmail_quote">On Mon, Dec 14, 2009 at 9:15 AM, Casper Dietrich <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26783984&i=0" target="_top" rel="nofollow">cd@...</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Hi Ping</span></p>
<p class="MsoNormal"><span style="font-size: 16pt; color: rgb(31, 73, 125);">Finally SUCCESS</span><span style="font-size: 11pt; color: rgb(31, 73, 125);">, </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">updating the kernel driver worked, but not without some
struggle. I am not sure how many times I have tried different combinations of
compiling and editing, and installing many different additional packages into
the system. </span></p></div></div></blockquote><div><br>If you can picture someone has to face the "<span style="font-size: 11pt; color: rgb(31, 73, 125);">different combinations"</span> for many years, you would feel you are lucky :).<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div link="blue" vlink="purple" lang="EN-US"><div>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">The last issue I had was that the 60-wacom.rules file wasn’t
present in the /etc/udev/rules.d folder, I had to copy it manually, I had no
errors in the lase compilation run.</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Now I am left with all the minors, like how do I assign
commands/key presses to the buttons on the wacom.</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">I have tried through the xsetwacom, but it will not let me
reassign any buttons.</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Issuing </span></p>
<p class="MsoNormal" style="text-indent: 36pt;"><span style="font-size: 11pt; color: rgb(31, 73, 125);">xsetwacom list</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Shows the wacom devices listed in the xorg.conf</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Issuing </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> xsetwacom -x get stylus all</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Shows this list:</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "TopX" "1" </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "TopY" "1" </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "BottomX" "1" </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "BottomY" "1" </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "Button1" "BUTTON 1" </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "Button2" "BUTTON 1" </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "Button3" "BUTTON 1" </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "Button4" "BUTTON 1" </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> Option "Button5" "BUTTON 1"</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> ……..</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> GetTabletID option is only an xsetwacom get command</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> NumScreen option is only an xsetwacom get command</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> XScaling option is only an xsetwacom get command</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">But when I try redefing, like:</span></p>
<p class="MsoNormal" style="text-indent: 36pt;"><span style="font-size: 11pt; color: rgb(31, 73, 125);">xsetwacom set stylus Button1
"core key ctrl alt F2"</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">I get the following:</span></p>
<p class="MsoNormal" style="text-indent: 36pt;"><span style="font-size: 11pt; color: rgb(31, 73, 125);">X Error: 2 BadValue (integer
parameter out of range for operation)</span></p>
<p class="MsoNormal" style="text-indent: 36pt;"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Error (22):
WacomConfigSetRawParam: failed</span></p>
<p class="MsoNormal" style="text-indent: 36pt;"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Set: Failed to set stylus
value for 'Button1'</span></p>
<p class="MsoNormal" style="text-indent: 36pt;"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><a name="1258e2fc147a1c42__MailEndCompose" target="_top"><span style="font-size: 11pt; color: rgb(31, 73, 125);">The only command I have tried
issuing without errors is:</span></a></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> xsetwacom set stylus Button2 "BUTTON
2"</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">But the “xsetwacom -x get stylus all”, shows no
redefinition</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Is this the way to do redefinitions or is there a different way,
</span></p></div></div></blockquote><div><br>Peter will address these questions for you. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div link="blue" vlink="purple" lang="EN-US"><div>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">When that is solved…. Is there a way to control the LED
and LCD on the tablet.</span></p></div></div></blockquote><div><br>Do you have a patch for us :)? As you can tell, Peter and I are both handful......<br><br>Ping<br></div></div>
<br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26783984&i=1" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26781440Re: Wacom Intuos4, xorg 1.7.12009-12-14T09:16:21Z2009-12-14T09:16:21Zlinuxwacomdiscuss<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Hi Ping<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:16.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Finally SUCCESS</span><span style='font-size:11.0pt;font-family:
"Calibri","sans-serif";color:#1F497D'>, <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>updating the kernel driver worked, but not without some
struggle. I am not sure how many times I have tried different combinations of
compiling and editing, and installing many different additional packages into
the system. <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>The last issue I had was that the 60-wacom.rules file wasn’t
present in the /etc/udev/rules.d folder, I had to copy it manually, I had no
errors/warnings in the last compilation run.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Now I am left with all the minors, like how do I assign
commands/key presses to the buttons on the wacom.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>I have tried through the xsetwacom, but it will not let me
reassign any buttons.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Issuing <o:p></o:p></span></p>
<p class=MsoNormal style='text-indent:36.0pt'><span style='font-size:11.0pt;
font-family:"Calibri","sans-serif";color:#1F497D'>xsetwacom list<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Shows the wacom devices listed in the xorg.conf<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Issuing <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>
xsetwacom -x get stylus all<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Shows this list:<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"TopX" "1"
<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"TopY"
"1"
<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"BottomX"
"1" <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"BottomY"
"1" <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"Button1" "BUTTON 1" <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"Button2" "BUTTON 1" <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"Button3" "BUTTON 1" <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"Button4" "BUTTON 1" <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Option
"Button5" "BUTTON 1"<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> ……..<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> GetTabletID option is
only an xsetwacom get command<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> NumScreen option is
only an xsetwacom get command<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> XScaling option is only
an xsetwacom get command<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>But when I try redefing, like:<o:p></o:p></span></p>
<p class=MsoNormal style='text-indent:36.0pt'><span style='font-size:11.0pt;
font-family:"Calibri","sans-serif";color:#1F497D'>xsetwacom set stylus Button1
"core key ctrl alt F2"<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>I get the following:<o:p></o:p></span></p>
<p class=MsoNormal style='text-indent:36.0pt'><span style='font-size:11.0pt;
font-family:"Calibri","sans-serif";color:#1F497D'>X Error: 2 BadValue (integer
parameter out of range for operation)<o:p></o:p></span></p>
<p class=MsoNormal style='text-indent:36.0pt'><span style='font-size:11.0pt;
font-family:"Calibri","sans-serif";color:#1F497D'>Error (22):
WacomConfigSetRawParam: failed<o:p></o:p></span></p>
<p class=MsoNormal style='text-indent:36.0pt'><span style='font-size:11.0pt;
font-family:"Calibri","sans-serif";color:#1F497D'>Set: Failed to set stylus
value for 'Button1'<o:p></o:p></span></p>
<p class=MsoNormal style='text-indent:36.0pt'><span style='font-size:11.0pt;
font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>The only command I have tried issuing without errors is:<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>
xsetwacom set stylus Button2 "BUTTON 2"<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>But the “xsetwacom -x get stylus all”, shows no redefinition<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Is this the way to do redefinitions or is there a different way,
<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>When that is solved…. Is there a way to control the LED
and LCD on the tablet.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Thanks<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Casper<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><a name="_MailEndCompose" target="_top"><span style='font-size:11.0pt;
font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></a></p>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Ping
[mailto:<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26781440&i=0" target="_top" rel="nofollow">pinglinux@...</a>] <br>
<b>Sent:</b> 12. december 2009 17:28<br>
<b>To:</b> Enrico Ros<br>
<b>Cc:</b> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26781440&i=1" target="_top" rel="nofollow">linuxwacom-discuss@...</a><br>
<b>Subject:</b> Re: [Linuxwacom-discuss] Wacom Intuos4, xorg 1.7.1<o:p></o:p></span></p>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal style='margin-bottom:12.0pt'>That means your kernel driver
is out of date. Did you upodate the kernel driver as I told you
earlier? The problem is most probably caused by the fact that Intuos4 is
so new that the kernel driver included by your ditro doesn't support it.<br>
<br>
Ping<o:p></o:p></p>
<div>
<p class=MsoNormal>On Sat, Dec 12, 2009 at 6:09 AM, Enrico Ros <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26781440&i=2" target="_top" rel="nofollow">enrico.qt@...</a>>
wrote:<o:p></o:p></p>
<div>
<p class=MsoNormal style='margin-bottom:12.0pt'>On Friday 11 December 2009
22:23:45 Vu Ngoc San wrote:<br>
> this happens sometimes when wacom.ko and wacom_drv.so are not compiled
with<br>
> the same version of the driver...<o:p></o:p></p>
</div>
<p class=MsoNormal>Patch 21526f94 committed on Thursday 10 may fix this crash.
However the tablet<br>
will be partially or no functional since the X driver doesn't really know
the<br>
device that is reported by the kernel.<br>
<span style='color:#888888'><br>
Enrico</span><o:p></o:p></p>
<div>
<p class=MsoNormal style='margin-bottom:12.0pt'><br>
> Le mercredi 9 décembre 2009 16:08:56, linuxwacomdiscuss a écrit :<br>
> > Hi Peter and Ping<br>
> ><br>
> > Thanks to your great support, I had the Intuous4 up and running on
the<br>
> > test platform (an old laptop), I have now migrated to a workstation,
with<br>
> > the required graphics capabilities, but now I see a new set of
problems.<br>
> ><br>
> > I have now loaded and compiled all the files, and build the
xorg.conf,<br>
> > all logs looks good. But on any action on the tablet (pen move,<br>
> > clicks,...) my session is killed and the fedora login screen is shown<br>
> > (all processes are terminated), this is a very fast and effective way
to<br>
> > log off the computer, but with the price tag of the wacom, I would
like<br>
> > to have it working a bit better than a panic lockoff button ;-)<br>
> ><br>
> > The log files shows no warnings or errors that points to the issue.
Do<br>
> > you have any ideas.<br>
> ><br>
> > Thanks<br>
> ><br>
> > Casper<br>
> ><br>
<br>
<o:p></o:p></p>
</div>
<p class=MsoNormal>------------------------------------------------------------------------------<o:p></o:p></p>
<div>
<div>
<p class=MsoNormal>Return on Information:<br>
Google Enterprise Search pays you back<br>
Get the facts.<br>
<a href="http://p.sf.net/sfu/google-dev2dev" target="_blank" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>
_______________________________________________<br>
Linuxwacom-discuss mailing list<br>
<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26781440&i=3" target="_top" rel="nofollow">Linuxwacom-discuss@...</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_blank" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><o:p></o:p></p>
</div>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
</div>
</body>
</html>
<br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26781440&i=4" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26773982Re: xsetwacom re-implementation available2009-12-13T23:38:10Z2009-12-13T23:38:10ZBugzilla from oldium.pro@seznam.czHi Peter,
<br><div class='shrinkable-quote'><br>> ------------ Původní zpráva ------------
<br>> Od: Peter Hutterer <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26773982&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>>
<br>> Předmět: Re: [Linuxwacom-devel] xsetwacom re-implementation available
<br>> Datum: 14.12.2009 07:13:20
<br>> ----------------------------------------
<br>> On Fri, Dec 11, 2009 at 09:53:04PM +0100, Oldrich Jedlicka wrote:
<br>> > Hi Peter,
<br>> >
<br>> > On Thursday 10 of December 2009 at 07:07:34, Peter Hutterer wrote:
<br>> > > As you may be aware, xf86-input-wacom utilises input device properties to
<br>> > > set a couple of driver-specific options at runtime. This is quite different
<br>> > > to linuxwacom where run-time changing is performed via ChangeDeviceControl
<br>> > > requests. This difference in run-time parameter changes had the side-effect
<br>> > > of a broken xsetwacom.
<br>> > >
<br>> > > I've just pushed the re-implementation of xsetwacom to the xsetwacom branch
<br>> > > in my repository (it'd be a bit of a patchbomb sending all patches to the
<br>> > > list).
<br>> > >
<br>> > > It's not a 1:1 replacement yet but most commands are available and should
<br>> > > work as before. The user interface for most commands has stayed the same,
<br>> > > some commands (e.g. key mappings) have changed slightly or are available in
<br>> > > multiple versions (e.g. GNU style parameters).
<br>> > >
<br>> > > I'll be merging this branch into master early next week. If you have the
<br>> > > time for testing already, feel free to give it a crack and complain to me
<br>> > > if your favourite command doesn't do what it used to do.
<br>> > > The code is fairly straightforward, so feel free to send patches to fix
<br>> > > whatever is broken.
<br>> >
<br>> > So I've heard you want somebody to complain :-)
<br>> >
<br>> > Actually the "key shift" doesn't work (the mouse button acts exactly as a
<br>> > shift key).
<br>>
<br>> can you give me some more info what exactly you're referring to here? you've
<br>> assigned the button to be "Shift"? is that correct?
</div><br>Exactly. Assign a "Shift" key functionality to a button (button press=shift pressed,button release=shift released). I was using also the "Ctrl" key for another button. I think it would be sufficient to release all "forgetten" pressed keys automatically (in reversed order), when the button is released - that would sanitise the user's input too.
<br><br>> > I have also difficulties double-clicking Button 3, because it
<br>> > freezes any mouse/tablet clicks (no buttons react) until some key is pressed.
<br>>
<br>> just double-clicking the physical button or assigning doubleclick to it?
<br><br>Just double-click (Button 3) without any assigned functonality - just a pure button. I've tried it with tracing enabled, but I didn't see any difference from single click, only no mouse clicks accepted afterwards (also from normal mouse) - until the keyboard's key is pressed.
<br><br>I wanted to have a look at it during weekend, but I didn't have any free time for that...
<br><br>> Cheers,
<br>> Peter
<br><br>Cheers,
<br>Oldrich.
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26773982&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26773727[PATCH] Remove area overlap check for area property.2009-12-13T22:57:51Z2009-12-13T22:57:51ZPeter Hutterer-3This check would cause setting of the property to fail since -
<br>especially if only one coordinate is modified - overlap was virtually
<br>guaranteed to happen.
<br><br>Each tool only has a single area, so this check doesn't seem necessary.
<br><br>Signed-off-by: Peter Hutterer <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26773727&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>>
<br>---
<br>If I understand this correctly, priv->tool->arealist is this tool's area, so
<br>the check for the area overlap is superfluous here (especially since it
<br>always produces overlaps).
<br><br> src/wcmXCommand.c | 4 ----
<br> 1 files changed, 0 insertions(+), 4 deletions(-)
<br><br>diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c
<br>index 23402c3..4dd4be1 100644
<br>--- a/src/wcmXCommand.c
<br>+++ b/src/wcmXCommand.c
<br>@@ -317,10 +317,6 @@ int xf86WcmSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop,
<br> area.bottomX = values[2];
<br> area.bottomY = values[3];
<br>
<br>- /* FIXME: this will always be the case? */
<br>- if (WcmAreaListOverlap(&area, priv->tool->arealist))
<br>- return BadValue;
<br>-
<br> if (!checkonly)
<br> {
<br> /* Invalid range resets axis to defaults */
<br>--
<br>1.6.5.2
<br><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26773727&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26773303Re: xsetwacom re-implementation available2009-12-13T21:47:05Z2009-12-13T21:47:05ZPeter Hutterer-3On Fri, Dec 11, 2009 at 09:53:04PM +0100, Oldrich Jedlicka wrote:
<div class='shrinkable-quote'><br>> Hi Peter,
<br>>
<br>> On Thursday 10 of December 2009 at 07:07:34, Peter Hutterer wrote:
<br>> > As you may be aware, xf86-input-wacom utilises input device properties to
<br>> > set a couple of driver-specific options at runtime. This is quite different
<br>> > to linuxwacom where run-time changing is performed via ChangeDeviceControl
<br>> > requests. This difference in run-time parameter changes had the side-effect
<br>> > of a broken xsetwacom.
<br>> >
<br>> > I've just pushed the re-implementation of xsetwacom to the xsetwacom branch
<br>> > in my repository (it'd be a bit of a patchbomb sending all patches to the
<br>> > list).
<br>> >
<br>> > It's not a 1:1 replacement yet but most commands are available and should
<br>> > work as before. The user interface for most commands has stayed the same,
<br>> > some commands (e.g. key mappings) have changed slightly or are available in
<br>> > multiple versions (e.g. GNU style parameters).
<br>> >
<br>> > I'll be merging this branch into master early next week. If you have the
<br>> > time for testing already, feel free to give it a crack and complain to me
<br>> > if your favourite command doesn't do what it used to do.
<br>> > The code is fairly straightforward, so feel free to send patches to fix
<br>> > whatever is broken.
<br>>
<br>> So I've heard you want somebody to complain :-)
<br>>
<br>> Actually the "key shift" doesn't work (the mouse button acts exactly as a
<br>> shift key).
</div><br>can you give me some more info what exactly you're referring to here? you've
<br>assigned the button to be "Shift"? is that correct?
<br><br>> I have also difficulties double-clicking Button 3, because it
<br>> freezes any mouse/tablet clicks (no buttons react) until some key is pressed.
<br><br>just double-clicking the physical button or assigning doubleclick to it?
<br><br>Cheers,
<br> Peter
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26773303&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26773271Re: [PATCH] touch and gesture options2009-12-13T21:38:51Z2009-12-13T21:38:51ZPeter Hutterer-3On Fri, Dec 11, 2009 at 02:11:34PM -0800, Ping wrote:
<div class='shrinkable-quote'><br>> > need to look at the code but I noticed here we check for that option twice,
<br>> > once in wcmUSB.c, once in wcmValidateDevice. may be something to keep an
<br>> > eye
<br>> > on?
<br>> >
<br>>
<br>> The check is needed for both files. In wcmValidateDevice.c, it is to
<br>> initialize the value for all devices that are defined in xorg.conf. Later
<br>> on in wcmUSB.c (and wcmISDV4.c as well), they are reassigned due the
<br>> possible changes in device specific features.
<br>>
<br>> Let me know if this confuses you more.
</div><br>it does, a bit anyway.
<br>the device-specific features are the enabling of touch, etc. based on the
<br>device's capabilities, right? (like the hunk below).
<br><br>AIUI, these capabilities don't change during the runtime of a device. if so,
<br>usbWcmInit is the wrong place to put the checks, it's called every time the
<br>device is opened and that seems a bit excessive. (also, it looks like this
<br>is the cause for the touch property being overwritten when you resume from
<br>suspend :)
<br><br>I think what we need here is something similar to the EvdevProbe() function
<br>- a function that opens the device, checks the capabilities and sets the
<br>required flags so that xf86WcmDevOpen and it's childs can be reduced to
<br>little more than fd = open(device).
<br><br>Cheers,
<br> Peter
<br><div class='shrinkable-quote'><br>> diff --git a/src/wcmUSB.c b/src/wcmUSB.c
<br>> index 49cafc4..788bc88 100644
<br>> --- a/src/wcmUSB.c
<br>> +++ b/src/wcmUSB.c
<br>> @@ -550,6 +550,14 @@ Bool usbWcmInit(LocalDevicePtr local, char* id, float
<br>> *version)
<br>> * For penabled TabletPCs. TabletPC is on by default */
<br>> common->wcmTPCButtonDefault = 1;
<br>> }
<br>> +
<br>> + /* 2FG touch device */
<br>> + if (ISBITSET (keys, BTN_TOOL_TRIPLETAP))
<br>> + {
<br>> + /* GestureDefault was off for all devices
<br>> + * except when multi-touch is supported */
<br>> + common->wcmGestureDefault = 1;
<br>> + }
<br>> }
<br>>
<br>> if (!common->wcmModel)
<br>> @@ -562,6 +570,10 @@ Bool usbWcmInit(LocalDevicePtr local, char* id, float
<br>> *version)
<br>> common->wcmTouch = xf86SetBoolOption(local->options, "Touch",
<br>> common->wcmTouchDefault);
<br>>
<br>> + /* Touch gesture applies to the whole tablet */
<br>> + common->wcmGesture = xf86SetBoolOption(local->options, "Gesture",
<br>> + common->wcmGestureDefault);
<br>> +
<br>> /* check if TPCButton was turned off in xorg.conf for pen */
<br>> if (priv->flags & STYLUS_ID)
<br>> common->wcmTPCButton = xf86SetBoolOption(local->options,
</div><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26773271&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26770699Re: [PATCH] Quiet gcc warning about not used xf86WcmKbdLedCallback function2009-12-13T15:00:40Z2009-12-13T15:00:40ZPeter Hutterer-3On Sun, Dec 13, 2009 at 05:37:35PM +0000, Przemysław Firszt wrote:
<br>> I switched -Wall to Werror to catch all warnings (thanks Peter!) and now
<br>> I need attached patch to compile wacom driver.
<br><br>if you have a recent automake installed (1.11 IIRC) the driver should
<br>auto-enable silent build, making it easier to spot warnings. Switching to
<br>-Werror is a good approach too but can sometimes be a bit painful.
<br><div class='shrinkable-quote'><br>> From d7307d114e655d5d34b2c041b8c63208844b7e22 Mon Sep 17 00:00:00 2001
<br>> From: Przemo Firszt <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26770699&i=0" target="_top" rel="nofollow">przemo@...</a>>
<br>> Date: Sun, 13 Dec 2009 17:28:59 +0000
<br>> Subject: [PATCH] Quiet gcc warning about not used xf86WcmKbdLedCallback function
<br>>
<br>> xf86WcmKbdLedCallback is used only for ABI < 5, so there is no need to define
<br>> it for newer ABI.
<br>> Signed-off-by: Przemo Firszt <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26770699&i=1" target="_top" rel="nofollow">przemo@...</a>>
<br>> ---
<br>> src/xf86Wacom.c | 2 ++
<br>> 1 files changed, 2 insertions(+), 0 deletions(-)
<br>>
<br>> diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c
<br>> index e5a7354..95a9c8b 100644
<br>> --- a/src/xf86Wacom.c
<br>> +++ b/src/xf86Wacom.c
<br>> @@ -98,9 +98,11 @@ static void xf86WcmKbdLedCallback(DeviceIntPtr di, LedCtrl * lcp)
<br>> {
<br>> }
<br>>
<br>> +#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) < 5
<br>> static void xf86WcmBellCallback(int pct, DeviceIntPtr di, pointer ctrl, int x)
<br>> {
<br>> }
<br>> +#endif
<br>>
<br>> static void xf86WcmKbdCtrlCallback(DeviceIntPtr di, KeybdCtrl* ctrl)
<br>> {
<br>> --
<br>> 1.6.5.2
</div>
<br>applied, thanks for the patch.
<br><br>Cheers,
<br> Peter
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26770699&i=2" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26769573Intuos3 stylus tilt precision2009-12-13T12:47:38Z2009-12-13T12:47:38ZNicolás Carranza-2I have some questions about tilt precision on an Intuos3. Using the linux
<br>wacom driver I get stylus tilt values on the x axis ranging from -64 to +63
<br>(tested using xidump). While on Windows I get stylus tilt values ranging
<br>from -60 to 60 (tested using wintab and also the Wacom Tabler Properties
<br>utility (About->Diagnose...) ) apparently over the same physical range (but
<br>this is hard to say as the difference is only ~3deg). My questions are:
<br>* Why does the linux-wacom driver get a wider range on linux using the same
<br>hardware?
<br>* How precise is the Intuos3 stylus and the linux-wacom driver when reporting
<br>tilt angle? Is there a specified error (+/-X deg) to take into account?
<br><br>Thanks in advance for your help,
<br>Nicolas
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26769573&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26768037[PATCH] Quiet gcc warning about not used xf86WcmKbdLedCallback function2009-12-13T09:37:35Z2009-12-13T09:37:35ZprzemofHi,
<br>I switched -Wall to Werror to catch all warnings (thanks Peter!) and now
<br>I need attached patch to compile wacom driver.
<br><br>--
<br>regards,
<br>Przemo
<br><br /><tt>[0001-Quiet-gcc-warning-about-not-used-xf86WcmKbdLedCallba.patch]</tt><br /><hr align="left" width="300" /><tt>>From d7307d114e655d5d34b2c041b8c63208844b7e22 Mon Sep 17 00:00:00 2001
<br>From: Przemo Firszt <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26768037&i=0" target="_top" rel="nofollow">przemo@...</a>>
<br>Date: Sun, 13 Dec 2009 17:28:59 +0000
<br>Subject: [PATCH] Quiet gcc warning about not used xf86WcmKbdLedCallback function
<br><br>xf86WcmKbdLedCallback is used only for ABI < 5, so there is no need to define
<br>it for newer ABI.
<br>Signed-off-by: Przemo Firszt <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26768037&i=1" target="_top" rel="nofollow">przemo@...</a>>
<br>---
<br> src/xf86Wacom.c | 2 ++
<br> 1 files changed, 2 insertions(+), 0 deletions(-)
<br><br>diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c
<br>index e5a7354..95a9c8b 100644
<br>--- a/src/xf86Wacom.c
<br>+++ b/src/xf86Wacom.c
<br>@@ -98,9 +98,11 @@ static void xf86WcmKbdLedCallback(DeviceIntPtr di, LedCtrl * lcp)
<br> {
<br> }
<br>
<br>+#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) < 5
<br> static void xf86WcmBellCallback(int pct, DeviceIntPtr di, pointer ctrl, int x)
<br> {
<br> }
<br>+#endif
<br>
<br> static void xf86WcmKbdCtrlCallback(DeviceIntPtr di, KeybdCtrl* ctrl)
<br> {
<br>--
<br>1.6.5.2
<br><br></tt><hr align="left" width="300" /><br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26768037&i=2" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26758938Re: Wacom Intuos4, xorg 1.7.12009-12-12T08:28:15Z2009-12-12T08:28:15ZPing@LinuxWacomThat means your kernel driver is out of date. Did you upodate the kernel driver as I told you earlier? The problem is most probably caused by the fact that Intuos4 is so new that the kernel driver included by your ditro doesn't support it.<br>
<br>Ping<br><br><div class="gmail_quote">On Sat, Dec 12, 2009 at 6:09 AM, Enrico Ros <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26758938&i=0" target="_top" rel="nofollow">enrico.qt@...</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>On Friday 11 December 2009 22:23:45 Vu Ngoc San wrote:<br>
> this happens sometimes when wacom.ko and wacom_drv.so are not compiled with<br>
> the same version of the driver...<br>
<br>
</div>Patch 21526f94 committed on Thursday 10 may fix this crash. However the tablet<br>
will be partially or no functional since the X driver doesn't really know the<br>
device that is reported by the kernel.<br>
<font color="#888888"><br>
Enrico<br>
</font><div><br>
> Le mercredi 9 décembre 2009 16:08:56, linuxwacomdiscuss a écrit :<br>
> > Hi Peter and Ping<br>
> ><br>
> > Thanks to your great support, I had the Intuous4 up and running on the<br>
> > test platform (an old laptop), I have now migrated to a workstation, with<br>
> > the required graphics capabilities, but now I see a new set of problems.<br>
> ><br>
> > I have now loaded and compiled all the files, and build the xorg.conf,<br>
> > all logs looks good. But on any action on the tablet (pen move,<br>
> > clicks,...) my session is killed and the fedora login screen is shown<br>
> > (all processes are terminated), this is a very fast and effective way to<br>
> > log off the computer, but with the price tag of the wacom, I would like<br>
> > to have it working a bit better than a panic lockoff button ;-)<br>
> ><br>
> > The log files shows no warnings or errors that points to the issue. Do<br>
> > you have any ideas.<br>
> ><br>
> > Thanks<br>
> ><br>
> > Casper<br>
> ><br>
<br>
<br>
</div>------------------------------------------------------------------------------<br>
<div><div></div><div>Return on Information:<br>
Google Enterprise Search pays you back<br>
Get the facts.<br>
<a href="http://p.sf.net/sfu/google-dev2dev" target="_blank" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>
_______________________________________________<br>
Linuxwacom-discuss mailing list<br>
<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26758938&i=1" target="_top" rel="nofollow">Linuxwacom-discuss@...</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_blank" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br>
</div></div></blockquote></div><br>
<br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26758938&i=2" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26757894Re: Wacom Intuos4, xorg 1.7.12009-12-12T06:09:03Z2009-12-12T06:09:03ZEnrico Ros-2On Friday 11 December 2009 22:23:45 Vu Ngoc San wrote:
<br>> this happens sometimes when wacom.ko and wacom_drv.so are not compiled with
<br>> the same version of the driver...
<br><br>Patch 21526f94 committed on Thursday 10 may fix this crash. However the tablet
<br>will be partially or no functional since the X driver doesn't really know the
<br>device that is reported by the kernel.
<br><br>Enrico
<br><div class='shrinkable-quote'><br>> Le mercredi 9 décembre 2009 16:08:56, linuxwacomdiscuss a écrit :
<br>> > Hi Peter and Ping
<br>> >
<br>> > Thanks to your great support, I had the Intuous4 up and running on the
<br>> > test platform (an old laptop), I have now migrated to a workstation, with
<br>> > the required graphics capabilities, but now I see a new set of problems.
<br>> >
<br>> > I have now loaded and compiled all the files, and build the xorg.conf,
<br>> > all logs looks good. But on any action on the tablet (pen move,
<br>> > clicks,...) my session is killed and the fedora login screen is shown
<br>> > (all processes are terminated), this is a very fast and effective way to
<br>> > log off the computer, but with the price tag of the wacom, I would like
<br>> > to have it working a bit better than a panic lockoff button ;-)
<br>> >
<br>> > The log files shows no warnings or errors that points to the issue. Do
<br>> > you have any ideas.
<br>> >
<br>> > Thanks
<br>> >
<br>> > Casper
<br>> >
</div><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26757894&i=0" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26753687Re: [PATCH] Some cleaning....2009-12-11T16:34:14Z2009-12-11T16:34:14ZPeter Hutterer-3On Fri, Dec 11, 2009 at 05:39:11PM +0000, Przemysław Firszt wrote:
<div class='shrinkable-quote'><br>> Dnia 2009-12-10, czw o godzinie 10:22 +1000, Peter Hutterer pisze:
<br>> > > From dcdce0a4fe304d8d94ec9d55d3097ae45dd622a3 Mon Sep 17 00:00:00 2001
<br>> > > From: Przemo Firszt <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26753687&i=0" target="_top" rel="nofollow">przemo@...</a>>
<br>> > > Date: Wed, 9 Dec 2009 20:26:04 +0000
<br>> > > Subject: [PATCH 3/3] Fix comment describing where are used area check functions.
<br>> > >
<br>> > > The comment was irrelevant after WcmPointInArea, WcmAreasOverlap and
<br>> > > AreaListOverlap have been moved to wcmCommon.c in
<br>> > > f19847502e8a0767693bc54597f779370cfba643
<br>> >
<br>> > sha's can't be used in patches that you send via email. The sha is generated
<br>> > when you commit, so once I apply the patch locally it has a different sha
<br>> > than on your machine.
<br>> It wasn't clear for me - thank for the explanation.
<br>>
<br>> > For patches like this it's better to either use the first line of the commit
<br>> > message (This comment is irrelevant since the patch "Move
<br>> > xf86WcmPointInArea, xf86WcmAreasOverlap & xf86WcmAreaListOverlap") or send a
<br>> > pull request for the patches in one go - pulling preserves the shas.
<br>> >
<br>> > for this patch, I just squashed it in with the first one, it's easier.
<br>> > (have a look at git rebase -i if you haven't yet, it's very useful)
<br>> OK, I'll do it that way next time.
<br>>
<br>> > Last thing before pushing - can I have your signed-off-by for these patches
<br>> > please? just in a reply to this email is enough.
<br>> You mean this:
<br>> Signed-off-by: Przemo Firszt <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26753687&i=1" target="_top" rel="nofollow">przemo@...</a>>
<br>>
<br>> I hope it's OK...but I'm a git greenhorn
</div><br>yes, thanks. the signed-off is simply your certificate of origin
<br><a href="http://git.kernel.org/?p=linux/kernel/git/aegl/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=72651f788f4e3536149ef5e7ddfbed96a8f14d2f;hb=HEAD" target="_top" rel="nofollow">http://git.kernel.org/?p=linux/kernel/git/aegl/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=72651f788f4e3536149ef5e7ddfbed96a8f14d2f;hb=HEAD</a><br>see Section 12) in that page, it essentially means that you're guaranteeing
<br>the patch is allowed in the project.
<br><br>git commit -s adds the signed-off-by tag automatically, you don't need to
<br>add it by hand.
<br><br>on that note, once you're starting to use git rebase, s-o-b becomes useful
<br>as a marker for finished patches.
<br>e.g. I develop a set of patches, then rearrange and squash them as needed
<br>and add my s-o-b to those I consider done. This way you can do a simple log
<br>and see immediatly which patches are ready for sending to the list and which
<br>ones need more work.
<br><br>just one possible workflow, it helps me and it might help you too.
<br><br>Cheers,
<br> Peter
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26753687&i=2" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26752203Re: [PATCH] touch and gesture options2009-12-11T14:11:34Z2009-12-11T14:11:34ZPing@LinuxWacomOn Thu, Dec 10, 2009 at 10:35 PM, Peter Hutterer <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26752203&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>></span> wrote:<br>
<div class="gmail_quote"><blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;" class="gmail_quote">
<div>> diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c<br></div>> index ed02507..c33187f 100644<br>
<div>> --- a/src/wcmValidateDevice.c<br>> +++ b/src/wcmValidateDevice.c<br></div>> @@ -618,6 +618,10 @@ int wcmParseOptions(LocalDevicePtr local)<br>
<div>> /* Touch applies to the whole tablet */<br></div>
<div>> common->wcmTouch = xf86SetBoolOption(local->options, "Touch", common->wcmTouchDefault);<br>><br></div>> + /* Touch gesture applies to the whole tablet */<br>
<div>> + common->wcmGesture = xf86SetBoolOption(local->options, "Gesture",<br>> + common->wcmGestureDefault);<br><br></div>need to look at the code but I noticed here we check for that option twice,<br>
once in wcmUSB.c, once in wcmValidateDevice. may be something to keep an eye<br>on?<br></blockquote><div><br>The check is needed for both files. In wcmValidateDevice.c, it is to initialize the value for all devices that are defined in xorg.conf. Later on in wcmUSB.c (and wcmISDV4.c as well), they are reassigned due the possible changes in device specific features. <br>
<br>Let me know if this confuses you more.<br><br>Ping<br><br><br></div></div>diff --git a/src/wcmUSB.c b/src/wcmUSB.c<br>index 49cafc4..788bc88 100644<br>--- a/src/wcmUSB.c<br>+++ b/src/wcmUSB.c<br>@@ -550,6 +550,14 @@ Bool usbWcmInit(LocalDevicePtr local, char* id, float *version)<br>
* For penabled TabletPCs. TabletPC is on by default */<br> common->wcmTPCButtonDefault = 1;<br> }<br>+<br>+ /* 2FG touch device */<br>+ if (ISBITSET (keys, BTN_TOOL_TRIPLETAP))<br>
+ {<br>+ /* GestureDefault was off for all devices<br>+ * except when multi-touch is supported */<br>+ common->wcmGestureDefault = 1;<br>+ }<br> }<br> <br> if (!common->wcmModel)<br>
@@ -562,6 +570,10 @@ Bool usbWcmInit(LocalDevicePtr local, char* id, float *version)<br> common->wcmTouch = xf86SetBoolOption(local->options, "Touch",<br> common->wcmTouchDefault);<br> <br>+ /* Touch gesture applies to the whole tablet */<br>
+ common->wcmGesture = xf86SetBoolOption(local->options, "Gesture",<br>+ common->wcmGestureDefault);<br>+<br> /* check if TPCButton was turned off in xorg.conf for pen */<br> if (priv->flags & STYLUS_ID)<br>
common->wcmTPCButton = xf86SetBoolOption(local->options,<br><br>
<br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26752203&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26751776Re: xsetwacom re-implementation available2009-12-11T13:35:27Z2009-12-11T13:35:27ZBugzilla from oldium.pro@seznam.czHi Peter,
<br><br>On Friday 11 of December 2009 at 21:53:04, Oldrich Jedlicka wrote:
<div class='shrinkable-quote'><br>> Hi Peter,
<br>>
<br>> On Thursday 10 of December 2009 at 07:07:34, Peter Hutterer wrote:
<br>> > As you may be aware, xf86-input-wacom utilises input device properties to
<br>> > set a couple of driver-specific options at runtime. This is quite
<br>> > different to linuxwacom where run-time changing is performed via
<br>> > ChangeDeviceControl requests. This difference in run-time parameter
<br>> > changes had the side-effect of a broken xsetwacom.
<br>> >
<br>> > I've just pushed the re-implementation of xsetwacom to the xsetwacom
<br>> > branch in my repository (it'd be a bit of a patchbomb sending all patches
<br>> > to the list).
<br>> >
<br>> > It's not a 1:1 replacement yet but most commands are available and should
<br>> > work as before. The user interface for most commands has stayed the same,
<br>> > some commands (e.g. key mappings) have changed slightly or are available
<br>> > in multiple versions (e.g. GNU style parameters).
<br>> >
<br>> > I'll be merging this branch into master early next week. If you have the
<br>> > time for testing already, feel free to give it a crack and complain to me
<br>> > if your favourite command doesn't do what it used to do.
<br>> > The code is fairly straightforward, so feel free to send patches to fix
<br>> > whatever is broken.
<br>>
<br>> So I've heard you want somebody to complain :-)
<br>>
<br>> Actually the "key shift" doesn't work (the mouse button acts exactly as a
<br>> shift key). I have also difficulties double-clicking Button 3, because it
<br>> freezes any mouse/tablet clicks (no buttons react) until some key is
<br>> pressed. I've now compiled the Wacom module with DEBUG enabled, so I will
<br>> see what I can do with it.
</div><br>Damn, wrong description. I'm playing with _pad_ buttons (not mouse) - button 3
<br>in this case.
<br><br>Cheers,
<br>Oldrich.
<br><div class='shrinkable-quote'><br>>
<br>> Just to note, I have Wacom Intuos 3 tablet, xorg-server 1.7.3,
<br>> xf86-input-wacom fresh from branch xsetwacom.
<br>>
<br>> Cheers,
<br>> Oldrich.
<br>>
<br>> > Cheers,
<br>> > Peter
<br>> >
<br>> > The following changes since commit
<br>> > e1cbd668de52ff3f35c8cc1ca362adc019935288: Peter Hutterer (1):
<br>> > Support future udev backend.
<br>> >
<br>> > are available in the git repository at:
<br>> >
<br>> > git://people.freedesktop.org/~whot/xf86-input-wacom.git xsetwacom
<br>> >
<br>> > Peter Hutterer (32):
<br>> > Add tools/xsetwacom, currently a stub.
<br>> > xsetwacom: Implement xsetwacom list.
<br>> > xsetwacom: Add find_device() helper function.
<br>> > xsetwacom: Add property hooks for xsetwacom set/get support.
<br>> > xsetwacom: Support xsetwacom set <name> Button1 for buttons and
<br>> > references. xsetwacom: allow for multi-value properties (PressCurve)
<br>> > xsetwacom: implement rel/abs mode setting.
<br>> > xsetwacom: fill in property for TPCButton, RawFilter, ClickForce.
<br>> > xsetwacom: announce not-implemented options and parameters as such.
<br>> > xsetwacom: remove SpeedLevel and Accel options.
<br>> > xsetwacom: implement 'xsetwacom get' for basic properties.
<br>> > xsetwacom: remove CoreEvent option - not a driver choice.
<br>> > xsetwacom: Remove getdefault option, not implemented anyway.
<br>> > xsetwacom: keystroke button mapping support.
<br>> > xsetwacom: add "-" and "+" notation and modifier parsing to key
<br>> > sending. xsetwacom: split func into set_func and get_func.
<br>> > xsetwacom: Add special hook for 'get PressCurve'
<br>> > xsetwacom: implement "get Button1" for simple mappings.
<br>> > xsetwacom: abstract extracting the button number.
<br>> > xsetwacom: don't try to get/set nonexistant buttons.
<br>> > xsetwacom: a few parameters aren't implemented for get either.
<br>> > xsetwacom: error out if a property offset doesn't exist.
<br>> > xsetwacom: support get/set rotate.
<br>> > xsetwacom: implement get_mode.
<br>> > xsetwacom: switch to use of named initializers.
<br>> > xsetwacom: implement verbosity.
<br>> > xsetwacom: support GNU-style for --list, --get, etc.
<br>> > xsetwacom: plug minor memory leak in set()
<br>> > xsetwacom: implement xyDefault - reset to driver-internal defaults.
<br>> > xsetwacom: enable -x and -s get flags
<br>> > xsetwacom: Be more flexible for multi-value properties.
<br>> > xsetwacom: handle string commands for TwinView setting
<br>> >
<br>> > Makefile.am | 2 +-
<br>> > configure.ac | 8 +-
<br>> > src/wcmXCommand.c | 1 +
<br>> > tools/Makefile.am | 28 +
<br>> > tools/xsetwacom.c | 1912
<br>> > +++++++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed,
<br>> > 1949 insertions(+), 2 deletions(-)
<br>> > create mode 100644 tools/Makefile.am
<br>> > create mode 100644 tools/xsetwacom.c
<br>> >
<br>> >
<br>> > -------------------------------------------------------------------------
<br>> >-- --- Return on Information:
<br>> > Google Enterprise Search pays you back
<br>> > Get the facts.
<br>> > <a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>> > _______________________________________________
<br>> > Linuxwacom-devel mailing list
<br>> > <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751776&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br>> > <a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br>>
<br>> ---------------------------------------------------------------------------
<br>>--- Return on Information:
<br>> Google Enterprise Search pays you back
<br>> Get the facts.
<br>> <a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>> _______________________________________________
<br>> Linuxwacom-devel mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751776&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br>> <a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a></div><br><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751776&i=2" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26751646Re: Wacom Intuos4, xorg 1.7.12009-12-11T13:23:45Z2009-12-11T13:23:45ZBugzilla from san.vu-ngoc@laposte.netthis happens sometimes when wacom.ko and wacom_drv.so are not compiled with
<br>the same version of the driver...
<br><br><br><br>Le mercredi 9 décembre 2009 16:08:56, linuxwacomdiscuss a écrit :
<div class='shrinkable-quote'><br>> Hi Peter and Ping
<br>>
<br>> Thanks to your great support, I had the Intuous4 up and running on the test
<br>> platform (an old laptop), I have now migrated to a workstation, with the
<br>> required graphics capabilities, but now I see a new set of problems.
<br>>
<br>> I have now loaded and compiled all the files, and build the xorg.conf, all
<br>> logs looks good. But on any action on the tablet (pen move, clicks,...) my
<br>> session is killed and the fedora login screen is shown (all processes are
<br>> terminated), this is a very fast and effective way to log off the computer,
<br>> but with the price tag of the wacom, I would like to have it working a bit
<br>> better than a panic lockoff button ;-)
<br>>
<br>> The log files shows no warnings or errors that points to the issue. Do you
<br>> have any ideas.
<br>>
<br>> Thanks
<br>>
<br>> Casper
<br>>
<br>> -----Original Message-----
<br>> From: Peter Hutterer [mailto:<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751646&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>]
<br>> Sent: 25. november 2009 01:53
<br>> To: linuxwacomdiscuss
<br>> Cc: 'Ping'; <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751646&i=1" target="_top" rel="nofollow">linuxwacom-discuss@...</a>
<br>> Subject: Re: [Linuxwacom-discuss] Wacom Intuos4, xorg 1.7.1
<br>>
<br>> On Tue, Nov 24, 2009 at 01:47:34PM +0100, linuxwacomdiscuss wrote:
<br>> > I am unfortunately not in goal yet,
<br>> > The make install generates the wacom_drv.so file in the /usr/.../input
<br>>
<br>> dir.
<br>>
<br>> > When I look into the log files, I see
<br>> > Nov 24 12:40:01 localhost kernel: wacom: v1.51:USB Wacom Graphire
<br>> > and Wacom Intuos tablet driver
<br>> > This is the only hint of a driver version I can find in the log files.
<br>> >
<br>> > I have attached the messages and Xorg.0.log logfiles and my xorg.conf
<br>> > file
<br>> >
<br>> > Status of the usage is still, the cursor follows the pen, but pen buttons
<br>> > doesn't work. The hard buttons on the tablet does in some cases act as a
<br>> > mouse click (in the shell, but not in dialogs or apps).
<br>> >
<br>> > Thank you for your support,
<br>>
<br>> looking at the log, the device isn't initialized at all. this is due to the
<br>> xorg.conf, although you have the matching sections in the config file, they
<br>> aren't referenced. The ServerLayout only references the Mouse0 device, not
<br>> the others, hence the server doesn't try to initialize them.
<br>>
<br>> It's not overly well known, but a single xorg.conf can contain multiple
<br>> independent configurations. So the following xorg.conf is valid
<br>>
<br>> ----%<--------------------------------------------
<br>> Section "ServerLayout"
<br>> Identifier "mouse only"
<br>> InputDevice "mouse" "CorePointer"
<br>> InputDevice "keyboard" "CoreKeyboard"
<br>> ...
<br>> EndSection
<br>>
<br>> Section "ServerLayout"
<br>> Identifier "wacom"
<br>> InputDevice "mouse" "CorePointer"
<br>> InputDevice "keyboard" "CoreKeyboard"
<br>> InputDevice "wacom stylus"
<br>> InputDevice "wacom erasor"
<br>> ...
<br>> EndSection
<br>>
<br>> [... skipped for brevity]
<br>> ---%<---------------------------------------------
<br>>
<br>> then you can pick which one to use at startup time, e.g.
<br>> $> Xorg -layout "wacom"
<br>>
<br>> for this reason, the server will only initialize the input devices
<br>> referenced in the chosen server layout (default: the first one). If other
<br>> devices are present but not referenced, they're ignored.
<br>> There's some special handling for when no server layout is present or no
<br>> input devices are referenced at all but I'll skip those cases.
<br>>
<br>> on top of this - you didn't disable hotplugging. so the mouse and kbd
<br>> devices are disabled by the server and instead all devices presented by HAL
<br>> are added. the wacom device is added with the evdev driver (default driver
<br>> for input devices). this again hints that the HAL setup is missing, most
<br>> likely the wacom.fdi isn't in the right place. Try to put it into hal's
<br>> /fdi/policy directory and restart hal. then check with lshal that the
<br>> input.x11_driver option is set to "wacom" for these devices.
<br>>
<br>> Alternatively, if you refernence the devices from the ServerLayout, that'll
<br>> work as well.
<br>>
<br>> complicated, I know. that's why we're trying to push more towards having
<br>> everything hotplugged, all you need then is the right configuration files
<br>> in place (in this case wacom.fdi) and the rest automagically happens. most
<br>> of the time, anyway.
<br>>
<br>> Cheers,
<br>> Peter
<br>>
<br>> ---------------------------------------------------------------------------
<br>> - --
<br>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
<br>> trial. Simplify your report design, integration and deployment - and focus
<br>> on
<br>> what you do best, core application coding. Discover what's new with
<br>> Crystal Reports now. <a href="http://p.sf.net/sfu/bobj-july" target="_top" rel="nofollow">http://p.sf.net/sfu/bobj-july</a><br>> _______________________________________________
<br>> Linuxwacom-discuss mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751646&i=2" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br>> <a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br>>
<br>>
<br>>
<br>> ---------------------------------------------------------------------------
<br>> --- Return on Information:
<br>> Google Enterprise Search pays you back
<br>> Get the facts.
<br>> <a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>> _______________________________________________
<br>> Linuxwacom-discuss mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751646&i=3" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br>> <a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br>>
</div><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-discuss mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751646&i=4" target="_top" rel="nofollow">Linuxwacom-discuss@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-discuss-f3779.html" embed="fixTarget[3779]" target="_top" >linuxwacom-discuss</a></p>tag:old.nabble.com,2006:post-26751296Re: xsetwacom re-implementation available2009-12-11T12:53:04Z2009-12-11T12:53:04ZBugzilla from oldium.pro@seznam.czHi Peter,
<br><br>On Thursday 10 of December 2009 at 07:07:34, Peter Hutterer wrote:
<div class='shrinkable-quote'><br>> As you may be aware, xf86-input-wacom utilises input device properties to
<br>> set a couple of driver-specific options at runtime. This is quite different
<br>> to linuxwacom where run-time changing is performed via ChangeDeviceControl
<br>> requests. This difference in run-time parameter changes had the side-effect
<br>> of a broken xsetwacom.
<br>>
<br>> I've just pushed the re-implementation of xsetwacom to the xsetwacom branch
<br>> in my repository (it'd be a bit of a patchbomb sending all patches to the
<br>> list).
<br>>
<br>> It's not a 1:1 replacement yet but most commands are available and should
<br>> work as before. The user interface for most commands has stayed the same,
<br>> some commands (e.g. key mappings) have changed slightly or are available in
<br>> multiple versions (e.g. GNU style parameters).
<br>>
<br>> I'll be merging this branch into master early next week. If you have the
<br>> time for testing already, feel free to give it a crack and complain to me
<br>> if your favourite command doesn't do what it used to do.
<br>> The code is fairly straightforward, so feel free to send patches to fix
<br>> whatever is broken.
</div><br>So I've heard you want somebody to complain :-)
<br><br>Actually the "key shift" doesn't work (the mouse button acts exactly as a
<br>shift key). I have also difficulties double-clicking Button 3, because it
<br>freezes any mouse/tablet clicks (no buttons react) until some key is pressed.
<br>I've now compiled the Wacom module with DEBUG enabled, so I will see what I
<br>can do with it.
<br><br>Just to note, I have Wacom Intuos 3 tablet, xorg-server 1.7.3,
<br>xf86-input-wacom fresh from branch xsetwacom.
<br><br>Cheers,
<br>Oldrich.
<br><div class='shrinkable-quote'><br>> Cheers,
<br>> Peter
<br>>
<br>> The following changes since commit
<br>> e1cbd668de52ff3f35c8cc1ca362adc019935288: Peter Hutterer (1):
<br>> Support future udev backend.
<br>>
<br>> are available in the git repository at:
<br>>
<br>> git://people.freedesktop.org/~whot/xf86-input-wacom.git xsetwacom
<br>>
<br>> Peter Hutterer (32):
<br>> Add tools/xsetwacom, currently a stub.
<br>> xsetwacom: Implement xsetwacom list.
<br>> xsetwacom: Add find_device() helper function.
<br>> xsetwacom: Add property hooks for xsetwacom set/get support.
<br>> xsetwacom: Support xsetwacom set <name> Button1 for buttons and
<br>> references. xsetwacom: allow for multi-value properties (PressCurve)
<br>> xsetwacom: implement rel/abs mode setting.
<br>> xsetwacom: fill in property for TPCButton, RawFilter, ClickForce.
<br>> xsetwacom: announce not-implemented options and parameters as such.
<br>> xsetwacom: remove SpeedLevel and Accel options.
<br>> xsetwacom: implement 'xsetwacom get' for basic properties.
<br>> xsetwacom: remove CoreEvent option - not a driver choice.
<br>> xsetwacom: Remove getdefault option, not implemented anyway.
<br>> xsetwacom: keystroke button mapping support.
<br>> xsetwacom: add "-" and "+" notation and modifier parsing to key
<br>> sending. xsetwacom: split func into set_func and get_func.
<br>> xsetwacom: Add special hook for 'get PressCurve'
<br>> xsetwacom: implement "get Button1" for simple mappings.
<br>> xsetwacom: abstract extracting the button number.
<br>> xsetwacom: don't try to get/set nonexistant buttons.
<br>> xsetwacom: a few parameters aren't implemented for get either.
<br>> xsetwacom: error out if a property offset doesn't exist.
<br>> xsetwacom: support get/set rotate.
<br>> xsetwacom: implement get_mode.
<br>> xsetwacom: switch to use of named initializers.
<br>> xsetwacom: implement verbosity.
<br>> xsetwacom: support GNU-style for --list, --get, etc.
<br>> xsetwacom: plug minor memory leak in set()
<br>> xsetwacom: implement xyDefault - reset to driver-internal defaults.
<br>> xsetwacom: enable -x and -s get flags
<br>> xsetwacom: Be more flexible for multi-value properties.
<br>> xsetwacom: handle string commands for TwinView setting
<br>>
<br>> Makefile.am | 2 +-
<br>> configure.ac | 8 +-
<br>> src/wcmXCommand.c | 1 +
<br>> tools/Makefile.am | 28 +
<br>> tools/xsetwacom.c | 1912
<br>> +++++++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 1949
<br>> insertions(+), 2 deletions(-)
<br>> create mode 100644 tools/Makefile.am
<br>> create mode 100644 tools/xsetwacom.c
<br>>
<br>>
<br>> ---------------------------------------------------------------------------
<br>>--- Return on Information:
<br>> Google Enterprise Search pays you back
<br>> Get the facts.
<br>> <a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>> _______________________________________________
<br>> Linuxwacom-devel mailing list
<br>> <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751296&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br>> <a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a></div><br><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26751296&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26748508Re: [PATCH] Some cleaning....2009-12-11T09:39:11Z2009-12-11T09:39:11ZprzemofDnia 2009-12-10, czw o godzinie 10:22 +1000, Peter Hutterer pisze:
<div class='shrinkable-quote'><br>> > From dcdce0a4fe304d8d94ec9d55d3097ae45dd622a3 Mon Sep 17 00:00:00 2001
<br>> > From: Przemo Firszt <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26748508&i=0" target="_top" rel="nofollow">przemo@...</a>>
<br>> > Date: Wed, 9 Dec 2009 20:26:04 +0000
<br>> > Subject: [PATCH 3/3] Fix comment describing where are used area check functions.
<br>> >
<br>> > The comment was irrelevant after WcmPointInArea, WcmAreasOverlap and
<br>> > AreaListOverlap have been moved to wcmCommon.c in
<br>> > f19847502e8a0767693bc54597f779370cfba643
<br>>
<br>> sha's can't be used in patches that you send via email. The sha is generated
<br>> when you commit, so once I apply the patch locally it has a different sha
<br>> than on your machine.
</div>It wasn't clear for me - thank for the explanation.
<br><br>> For patches like this it's better to either use the first line of the commit
<br>> message (This comment is irrelevant since the patch "Move
<br>> xf86WcmPointInArea, xf86WcmAreasOverlap & xf86WcmAreaListOverlap") or send a
<br>> pull request for the patches in one go - pulling preserves the shas.
<br>>
<br>> for this patch, I just squashed it in with the first one, it's easier.
<br>> (have a look at git rebase -i if you haven't yet, it's very useful)
<br>OK, I'll do it that way next time.
<br><br>> Last thing before pushing - can I have your signed-off-by for these patches
<br>> please? just in a reply to this email is enough.
<br>You mean this:
<br> Signed-off-by: Przemo Firszt <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26748508&i=1" target="_top" rel="nofollow">przemo@...</a>>
<br><br>I hope it's OK...but I'm a git greenhorn
<br><br>Thanks for another lesson!
<br>--
<br>Przemo
<br><br><br><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26748508&i=2" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26740127Re: [PATCH] Move Touch and TPCButton options check.2009-12-11T00:15:33Z2009-12-11T00:15:33ZPeter Hutterer-3On Fri, Dec 11, 2009 at 09:04:16AM +0100, Enrico Ros wrote:
<div class='shrinkable-quote'><br>> On Thursday 10 December 2009 03:58:11 Peter Hutterer wrote:
<br>> > I had this patch sitting in my tree ready-to-push and then Enrico's merge
<br>> > gave me a bit of a headache - there was a conflict.
<br>> >
<br>> > Ping, can you just glance over it to make sure I didn't change the intent
<br>> > of the patch?
<br>> > Enrico, can you please test this to make sure it doesn't bust the new
<br>> > bamboo stuff?
<br>>
<br>> Indeed, everything works.
<br>> I'm digging more in the code, I don't know if I can do some cleanups because
<br>> there is a high chance of regressions and I only have 1 tablet to test it.
<br>> Anyway.. it's git, so I could have an experimental 'cleanups' branch for
<br>> testing.
</div><br>just letting you know, Ping sent me an updated patch from a clean source, so
<br>this merged patch became obsolete anyway.
<br>the good one is pushed to master now, please let us know if there's any
<br>issues.
<br><br>Cheers,
<br> Peter
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26740127&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26740001Re: [PATCH] Move Touch and TPCButton options check.2009-12-11T00:04:16Z2009-12-11T00:04:16ZEnrico Ros-2On Thursday 10 December 2009 03:58:11 Peter Hutterer wrote:
<br>> I had this patch sitting in my tree ready-to-push and then Enrico's merge
<br>> gave me a bit of a headache - there was a conflict.
<br>>
<br>> Ping, can you just glance over it to make sure I didn't change the intent
<br>> of the patch?
<br>> Enrico, can you please test this to make sure it doesn't bust the new
<br>> bamboo stuff?
<br><br>Indeed, everything works.
<br>I'm digging more in the code, I don't know if I can do some cleanups because
<br>there is a high chance of regressions and I only have 1 tablet to test it.
<br>Anyway.. it's git, so I could have an experimental 'cleanups' branch for
<br>testing.
<br><br>Enrico
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26740001&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26722589xsetwacom re-implementation available2009-12-09T22:07:34Z2009-12-09T22:07:34ZPeter Hutterer-3As you may be aware, xf86-input-wacom utilises input device properties to
<br>set a couple of driver-specific options at runtime. This is quite different
<br>to linuxwacom where run-time changing is performed via ChangeDeviceControl
<br>requests. This difference in run-time parameter changes had the side-effect
<br>of a broken xsetwacom.
<br><br>I've just pushed the re-implementation of xsetwacom to the xsetwacom branch
<br>in my repository (it'd be a bit of a patchbomb sending all patches to the
<br>list).
<br><br>It's not a 1:1 replacement yet but most commands are available and should
<br>work as before. The user interface for most commands has stayed the same,
<br>some commands (e.g. key mappings) have changed slightly or are available in
<br>multiple versions (e.g. GNU style parameters).
<br><br>I'll be merging this branch into master early next week. If you have the
<br>time for testing already, feel free to give it a crack and complain to me if
<br>your favourite command doesn't do what it used to do.
<br>The code is fairly straightforward, so feel free to send patches to fix
<br>whatever is broken.
<br><br>Cheers,
<br> Peter
<br><br>The following changes since commit e1cbd668de52ff3f35c8cc1ca362adc019935288:
<br> Peter Hutterer (1):
<br> Support future udev backend.
<br><br>are available in the git repository at:
<br><br> git://people.freedesktop.org/~whot/xf86-input-wacom.git xsetwacom
<br><br>Peter Hutterer (32):
<br> Add tools/xsetwacom, currently a stub.
<br> xsetwacom: Implement xsetwacom list.
<br> xsetwacom: Add find_device() helper function.
<br> xsetwacom: Add property hooks for xsetwacom set/get support.
<br> xsetwacom: Support xsetwacom set <name> Button1 for buttons and references.
<br> xsetwacom: allow for multi-value properties (PressCurve)
<br> xsetwacom: implement rel/abs mode setting.
<br> xsetwacom: fill in property for TPCButton, RawFilter, ClickForce.
<br> xsetwacom: announce not-implemented options and parameters as such.
<br> xsetwacom: remove SpeedLevel and Accel options.
<br> xsetwacom: implement 'xsetwacom get' for basic properties.
<br> xsetwacom: remove CoreEvent option - not a driver choice.
<br> xsetwacom: Remove getdefault option, not implemented anyway.
<br> xsetwacom: keystroke button mapping support.
<br> xsetwacom: add "-" and "+" notation and modifier parsing to key sending.
<br> xsetwacom: split func into set_func and get_func.
<br> xsetwacom: Add special hook for 'get PressCurve'
<br> xsetwacom: implement "get Button1" for simple mappings.
<br> xsetwacom: abstract extracting the button number.
<br> xsetwacom: don't try to get/set nonexistant buttons.
<br> xsetwacom: a few parameters aren't implemented for get either.
<br> xsetwacom: error out if a property offset doesn't exist.
<br> xsetwacom: support get/set rotate.
<br> xsetwacom: implement get_mode.
<br> xsetwacom: switch to use of named initializers.
<br> xsetwacom: implement verbosity.
<br> xsetwacom: support GNU-style for --list, --get, etc.
<br> xsetwacom: plug minor memory leak in set()
<br> xsetwacom: implement xyDefault - reset to driver-internal defaults.
<br> xsetwacom: enable -x and -s get flags
<br> xsetwacom: Be more flexible for multi-value properties.
<br> xsetwacom: handle string commands for TwinView setting
<br><br> Makefile.am | 2 +-
<br> configure.ac | 8 +-
<br> src/wcmXCommand.c | 1 +
<br> tools/Makefile.am | 28 +
<br> tools/xsetwacom.c | 1912 +++++++++++++++++++++++++++++++++++++++++++++++++++++
<br> 5 files changed, 1949 insertions(+), 2 deletions(-)
<br> create mode 100644 tools/Makefile.am
<br> create mode 100644 tools/xsetwacom.c
<br><br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26722589&i=0" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26722173Re: [PATCH] Don't set calloc'd fields to zero.2009-12-09T20:43:48Z2009-12-09T20:43:48ZPeter Hutterer-3On Wed, Dec 09, 2009 at 08:37:27PM -0800, Ping wrote:
<div class='shrinkable-quote'><br>> On Wed, Dec 9, 2009 at 8:20 PM, Peter Hutterer <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26722173&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>>wrote:
<br>>
<br>> >
<br>> > On Wed, Dec 09, 2009 at 08:05:00PM -0800, Ping wrote:
<br>> > > Is there a reason that the followings are not removed?
<br>> > >
<br>> > > common->wcmMaxX = 0; /* max digitizer logical X value
<br>> > */
<br>> > > common->wcmMaxY = 0; /* max digitizer logical Y value
<br>> > */
<br>> >
<br>> > hehe, well spotted :)
<br>> >
<br>> > they are followed by the definition of common->wcmMaxTouchX = 1024 and the
<br>> > same for Y. I left them there as an explicit signal that wcmMaxX/Y have a
<br>> > different default wcmMaxTouchX/Y
<br>> >
<br>> > > tool->next = NULL; /* next tool in list */
<br>> > > area->next = NULL; /* next area in list */
<br>> >
<br>> > both are linked lists and the ->next = NULL serves as an signal that it's a
<br>> > null-terminated list from the start.
<br>> >
<br>> > This is personal preference/style, I can remove both if you want to to be
<br>> > more consistent with the zero/NULL removals.
<br>>
<br>>
<br>> I don't have a personal preference. Either way works for me. However, you
<br>> may want to keep the following in to make it consistent within the scope.
<br>>
<br>> - priv->next = NULL;
</div><br>oops, yes, of course. will merge it in, thanks.
<br><br>Cheers,
<br> Peter
<br><br>------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br>_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26722173&i=1" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>tag:old.nabble.com,2006:post-26722133Re: [PATCH] Don't set calloc'd fields to zero.2009-12-09T20:37:27Z2009-12-09T20:37:27ZPing@LinuxWacomOn Wed, Dec 9, 2009 at 8:20 PM, Peter Hutterer <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26722133&i=0" target="_top" rel="nofollow">peter.hutterer@...</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><br>
On Wed, Dec 09, 2009 at 08:05:00PM -0800, Ping wrote:<br>
> Is there a reason that the followings are not removed?<br>
><br>
> common->wcmMaxX = 0; /* max digitizer logical X value */<br>
> common->wcmMaxY = 0; /* max digitizer logical Y value */<br>
<br>
</div>hehe, well spotted :)<br>
<br>
they are followed by the definition of common->wcmMaxTouchX = 1024 and the<br>
same for Y. I left them there as an explicit signal that wcmMaxX/Y have a<br>
different default wcmMaxTouchX/Y<br>
<div class="im"><br>
> tool->next = NULL; /* next tool in list */<br>
> area->next = NULL; /* next area in list */<br>
<br>
</div>both are linked lists and the ->next = NULL serves as an signal that it's a<br>
null-terminated list from the start.<br>
<br>
This is personal preference/style, I can remove both if you want to to be<br>
more consistent with the zero/NULL removals.</blockquote><div><br>I don't have a personal preference. Either way works for me. However, you may want to keep the following in to make it consistent within the scope. <br>
<br>- priv->next = NULL;<br></div><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Cheers,<br>
<font color="#888888"> Peter<br>
</font><div><div></div><div class="h5"><br>
><br>
> On Wed, Dec 9, 2009 at 5:56 PM, Peter Hutterer <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26722133&i=1" target="_top" rel="nofollow">peter.hutterer@...</a>>wrote:<br>
><br>
> > xf86WcmAllocate uses calloc for internally used fields. There's no need to<br>
> > reset all defaults to zero, we can assume they are.<br>
> ><br>
> > Removing those that are initialized to zero reduces the noise, anything<br>
> > listed in xf86WcmAllocate has a default that's not zero and is easy to grep<br>
> > for.<br>
> ><br>
> > Signed-off-by: Peter Hutterer <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26722133&i=2" target="_top" rel="nofollow">peter.hutterer@...</a>><br>
> > ---<br>
> > src/wcmConfig.c | 73<br>
> > +++----------------------------------------------------<br>
> > 1 files changed, 4 insertions(+), 69 deletions(-)<br>
> ><br>
> > diff --git a/src/wcmConfig.c b/src/wcmConfig.c<br>
> > index a980888..f62cde7 100644<br>
> > --- a/src/wcmConfig.c<br>
> > +++ b/src/wcmConfig.c<br>
> > @@ -48,7 +48,7 @@ static int xf86WcmAllocate(LocalDevicePtr local, char*<br>
> > type_name, int flag)<br>
> > WacomCommonPtr common = NULL;<br>
> > WacomToolPtr tool = NULL;<br>
> > WacomToolAreaPtr area = NULL;<br>
> > - int i, j;<br>
> > + int i;<br>
> ><br>
> > priv = xcalloc(1, sizeof(WacomDeviceRec));<br>
> > if (!priv)<br>
> > @@ -83,38 +83,16 @@ static int xf86WcmAllocate(LocalDevicePtr local, char*<br>
> > type_name, int flag)<br>
> > local->old_x = -1;<br>
> > local->old_y = -1;<br>
> ><br>
> > - priv->next = NULL;<br>
> > priv->local = local;<br>
> > priv->flags = flag; /* various flags (device type,<br>
> > absolute, first touch...) */<br>
> > - priv->oldX = 0; /* previous X position */<br>
> > - priv->oldY = 0; /* previous Y position */<br>
> > - priv->oldZ = 0; /* previous pressure */<br>
> > - priv->oldTiltX = 0; /* previous tilt in x direction */<br>
> > - priv->oldTiltY = 0; /* previous tilt in y direction */<br>
> > - priv->oldStripX = 0; /* previous left strip value */<br>
> > - priv->oldStripY = 0; /* previous right strip value */<br>
> > - priv->oldButtons = 0; /* previous buttons state */<br>
> > - priv->oldWheel = 0; /* previous wheel */<br>
> > - priv->topX = 0; /* X top */<br>
> > - priv->topY = 0; /* Y top */<br>
> > - priv->bottomX = 0; /* X bottom */<br>
> > - priv->bottomY = 0; /* Y bottom */<br>
> > - priv->sizeX = 0; /* active X size */<br>
> > - priv->sizeY = 0; /* active Y size */<br>
> > - priv->factorX = 0.0; /* X factor */<br>
> > - priv->factorY = 0.0; /* Y factor */<br>
> > priv->common = common; /* common info pointer */<br>
> > - priv->oldProximity = 0; /* previous proximity */<br>
> > priv->hardProx = 1; /* previous hardware proximity */<br>
> > - priv->old_serial = 0; /* last active tool's serial */<br>
> > priv->old_device_id = IsStylus(priv) ? STYLUS_DEVICE_ID :<br>
> > (IsEraser(priv) ? ERASER_DEVICE_ID :<br>
> > (IsCursor(priv) ? CURSOR_DEVICE_ID :<br>
> > (IsTouch(priv) ? TOUCH_DEVICE_ID :<br>
> > PAD_DEVICE_ID)));<br>
> ><br>
> > - priv->devReverseCount = 0; /* flag for relative Reverse call */<br>
> > - priv->serial = 0; /* serial number */<br>
> > priv->screen_no = -1; /* associated screen */<br>
> > priv->nPressCtrl [0] = 0; /* pressure curve x0 */<br>
> > priv->nPressCtrl [1] = 0; /* pressure curve y0 */<br>
> > @@ -125,14 +103,10 @@ static int xf86WcmAllocate(LocalDevicePtr local,<br>
> > char* type_name, int flag)<br>
> > for (i=0; i<WCM_MAX_BUTTONS; i++)<br>
> > priv->button[i] = i + 1;<br>
> ><br>
> > - for (i=0; i<WCM_MAX_BUTTONS; i++)<br>
> > - for (j=0; j<256; j++)<br>
> > - priv->keys[i][j] = 0;<br>
> > -<br>
> > priv->nbuttons = WCM_MAX_BUTTONS; /* Default number of<br>
> > buttons */<br>
> > priv->relup = 5; /* Default relative wheel up<br>
> > event */<br>
> > priv->reldn = 4; /* Default relative wheel<br>
> > down event */<br>
> > -<br>
> > +<br>
> > priv->wheelup = IsPad (priv) ? 4 : 0; /* Default absolute wheel up<br>
> > event */<br>
> > priv->wheeldn = IsPad (priv) ? 5 : 0; /* Default absolute wheel<br>
> > down event */<br>
> > priv->striplup = 4; /* Default left strip up<br>
> > event */<br>
> > @@ -140,49 +114,25 @@ static int xf86WcmAllocate(LocalDevicePtr local,<br>
> > char* type_name, int flag)<br>
> > priv->striprup = 4; /* Default right strip up<br>
> > event */<br>
> > priv->striprdn = 5; /* Default right strip down<br>
> > event */<br>
> > priv->naxes = 6; /* Default number of axes */<br>
> > - priv->debugLevel = 0; /* debug level */<br>
> > priv->numScreen = screenInfo.numScreens; /* configured screens count<br>
> > */<br>
> > priv->currentScreen = -1; /* current screen in<br>
> > display */<br>
> > -<br>
> > - priv->maxWidth = 0; /* max active screen width<br>
> > */<br>
> > - priv->maxHeight = 0; /* max active screen height<br>
> > */<br>
> > - priv->leftPadding = 0; /* left padding for virtual<br>
> > tablet */<br>
> > - priv->topPadding = 0; /* top padding for virtual<br>
> > tablet */<br>
> > priv->twinview = TV_NONE; /* not using twinview gfx */<br>
> > - priv->tvoffsetX = 0; /* none X edge offset for<br>
> > TwinView setup */<br>
> > - priv->tvoffsetY = 0; /* none Y edge offset for<br>
> > TwinView setup */<br>
> > - for (i=0; i<4; i++)<br>
> > - priv->tvResolution[i] = 0; /* unconfigured twinview<br>
> > resolution */<br>
> > priv->wcmMMonitor = 1; /* enabled (=1) to support<br>
> > multi-monitor desktop. */<br>
> > /* disabled (=0) when user<br>
> > doesn't want to move the */<br>
> > /* cursor from one screen to<br>
> > another screen */<br>
> ><br>
> > /* JEJ - throttle sampling code */<br>
> > - priv->throttleValue = 0;<br>
> > - priv->throttleStart = 0;<br>
> > priv->throttleLimit = -1;<br>
> > -<br>
> > +<br>
> > common->wcmDevice = ""; /* device file name */<br>
> > - common->min_maj = 0; /* device major and minor<br>
> > */<br>
> > common->wcmFlags = RAW_FILTERING_FLAG; /* various flags */<br>
> > common->wcmDevices = priv;<br>
> > - common->npadkeys = 0; /* Default number of pad keys */<br>
> > common->wcmProtocolLevel = 4; /* protocol level */<br>
> > - common->wcmThreshold = 0; /* unconfigured threshold */<br>
> > common->wcmISDV4Speed = 38400; /* serial ISDV4 link speed */<br>
> > - common->debugLevel = 0; /* shared debug level can only<br>
> > - * be changed though xsetwacom */<br>
> ><br>
> > common->wcmDevCls = &gWacomUSBDevice; /* device-specific functions<br>
> > */<br>
> > - common->wcmModel = NULL; /* model-specific<br>
> > functions */<br>
> > - common->wcmEraserID = 0; /* eraser id associated with the<br>
> > stylus */<br>
> > - common->wcmTPCButtonDefault = 0; /* default Tablet PC button<br>
> > support is off */<br>
> > common->wcmTPCButton =<br>
> > common->wcmTPCButtonDefault; /* set Tablet PC button on/off<br>
> > */<br>
> > - common->wcmTouch = 0; /* touch is disabled */<br>
> > - common->wcmTouchDefault = 0; /* default to disable when touch<br>
> > isn't supported */<br>
> > - common->wcmGesture = 0; /* touch Gesture is disabled */<br>
> > - common->wcmGestureDefault = 0; /* default to disable */<br>
> > common->wcmCapacity = -1; /* Capacity is disabled */<br>
> > common->wcmCapacityDefault = -1; /* default to -1 when capacity<br>
> > isn't supported */<br>
> > /* 3 when capacity is supported<br>
> > */<br>
> > @@ -191,20 +141,10 @@ static int xf86WcmAllocate(LocalDevicePtr local,<br>
> > char* type_name, int flag)<br>
> > common->wcmMaxY = 0; /* max digitizer logical Y value<br>
> > */<br>
> > common->wcmMaxTouchX = 1024; /* max touch X value */<br>
> > common->wcmMaxTouchY = 1024; /* max touch Y value */<br>
> > - common->wcmMaxZ = 0; /* max Z value */<br>
> > - common->wcmMaxCapacity = 0; /* max capacity value */<br>
> > - common->wcmMaxDist = 0; /* max distance value */<br>
> > - common->wcmResolX = 0; /* digitizer X resolution in<br>
> > points/inch */<br>
> > - common->wcmResolY = 0; /* digitizer Y resolution in<br>
> > points/inch */<br>
> > - common->wcmTouchResolX = 0; /* touch X resolution in<br>
> > points/mm */<br>
> > - common->wcmTouchResolY = 0; /* touch Y resolution in<br>
> > points/mm */<br>
> > common->wcmMaxStripX = 4096; /* Max fingerstrip X */<br>
> > common->wcmMaxStripY = 4096; /* Max fingerstrip Y */<br>
> > common->wcmMaxtiltX = 128; /* Max tilt in X directory */<br>
> > common->wcmMaxtiltY = 128; /* Max tilt in Y directory */<br>
> > - common->wcmMaxCursorDist = 0; /* Max distance received so far */<br>
> > - common->wcmCursorProxoutDist = 0;<br>
> > - /* Max mouse distance for proxy-out max/256 units<br>
> > */<br>
> > common->wcmCursorProxoutDistDefault = PROXOUT_INTUOS_DISTANCE;<br>
> > /* default to Intuos */<br>
> > common->wcmSuppress = DEFAULT_SUPPRESS;<br>
> > @@ -217,16 +157,11 @@ static int xf86WcmAllocate(LocalDevicePtr local,<br>
> > char* type_name, int flag)<br>
> > common->wcmTool = tool;<br>
> > tool->next = NULL; /* next tool in list */<br>
> > tool->typeid = DEVICE_ID(flag); /* tool type<br>
> > (stylus/touch/eraser/cursor/pad) */<br>
> > - tool->serial = 0; /* serial id */<br>
> > - tool->current = NULL; /* current area in-prox */<br>
> > tool->arealist = area; /* list of defined areas */<br>
> > +<br>
> > /* tool area */<br>
> > priv->toolarea = area;<br>
> > area->next = NULL; /* next area in list */<br>
> > - area->topX = 0; /* X top */<br>
> > - area->topY = 0; /* Y top */<br>
> > - area->bottomX = 0; /* X bottom */<br>
> > - area->bottomY = 0; /* Y bottom */<br>
> > area->device = local; /* associated WacomDevice */<br>
> ><br>
> > return 1;<br>
> > --<br>
> > 1.6.5.2<br>
> ><br>
> ><br>
</div></div></blockquote></div><br>
<br />------------------------------------------------------------------------------
<br>Return on Information:
<br>Google Enterprise Search pays you back
<br>Get the facts.
<br><a href="http://p.sf.net/sfu/google-dev2dev" target="_top" rel="nofollow">http://p.sf.net/sfu/google-dev2dev</a><br><br />_______________________________________________
<br>Linuxwacom-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26722133&i=3" target="_top" rel="nofollow">Linuxwacom-devel@...</a>
<br><a href="https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel" target="_top" rel="nofollow">https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel</a><br><p>From forum: <a href="http://old.nabble.com/linuxwacom-devel-f3778.html" embed="fixTarget[3778]" target="_top" >linuxwacom-devel</a></p>