Little bugs in MacLow

View: New views
1 Messages — Rating Filter:   Alert me  

Little bugs in MacLow

by Mirko Banchi :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

i think that there is a little bug in MacLow. Functions like  
NormalAckTimeout, FastAckTimeout... call method GetStation with  
argument m_currentHdr.GetAddr1 () but should it be  
m_currentHdr.GetAddr2 () instead?
Tx station should increment its retry counter not Rx station.

Also at line 616, in MacLow::ReceiveOk method, i think that correct  
behaviour should be:

...
WifiRemoteStation *station = GetStation (m_currentHdr.GetAddr2 ());
station->ReportRxOk (rxSnr, txMode);
station->ReportDataOk (rxSnr, txMode, tag.Get ());
...

Tx station should reset its retry counter not Rx station.

What do you think?

Mirko

--
Mirko Banchi

e-mail:    mk.banchi@...
e-mail:    mk.banchi@...
id-jabber: mk.banchi@...

PGP key fingerprint:

308F BFB1 4E67 2522 C88E
DC69 7631 52ED 32A5 6456






smime.p7s (3K) Download Attachment