Maintaining libid3tag?

[Andy Grundman-2]

Is there any interest in having someone take over maintenance of  
libid3tag?  There are several patches floating around in various  
places [1] that should be rolled into an official release.  There are  
also some issues related to handling of broken iTunes tags that I'd  
like to fix and don't see any patches for.  I'm happy to volunteer.

[1]
http://patch-tracking.debian.net/package/libid3tag
http://bugs.gentoo.org/show_bug.cgi?id=210564

--
Andy Grundman
Logitech Streaming Media Systems (Slim Devices)
andy@... / www.slimdevices.com

[Kurt Roeckx]

On Thu, Apr 02, 2009 at 09:44:18AM -0400, Andy Grundman wrote:
> Is there any interest in having someone take over maintenance of  
> libid3tag?  There are several patches floating around in various places
> [1] that should be rolled into an official release.  There are also some
> issues related to handling of broken iTunes tags that I'd like to fix and
> don't see any patches for.  I'm happy to volunteer.
>
> [1]
> http://patch-tracking.debian.net/package/libid3tag

Those are patches we added to the package, the difference between
our version and upstream's version.  And there hasn't been any
activity upstream for a while.

We really only have 1 open bug report:
http://bugs.debian.org/350578

> http://bugs.gentoo.org/show_bug.cgi?id=210564

We have fixed this bug long before the gentoo bug report.  This is
http://bugs.debian.org/304913
http://bugs.debian.org/480187


Kurt

[Kurt Roeckx]

On Thu, Apr 02, 2009 at 06:58:22PM +0200, Kurt Roeckx wrote:

> On Thu, Apr 02, 2009 at 09:44:18AM -0400, Andy Grundman wrote:
> > Is there any interest in having someone take over maintenance of  
> > libid3tag?  There are several patches floating around in various places
> > [1] that should be rolled into an official release.  There are also some
> > issues related to handling of broken iTunes tags that I'd like to fix and
> > don't see any patches for.  I'm happy to volunteer.
> >
> > [1]
> > http://patch-tracking.debian.net/package/libid3tag
>
> Those are patches we added to the package, the difference between
> our version and upstream's version.  And there hasn't been any
> activity upstream for a while.

I was under the impression that you've mailed the debian list
about this, and not the upstream list.  Sorry about that.


Kurt

[Andy Grundman-2]

On Apr 2, 2009, at 12:58 PM, Kurt Roeckx wrote:

> On Thu, Apr 02, 2009 at 09:44:18AM -0400, Andy Grundman wrote:
>> Is there any interest in having someone take over maintenance of
>> libid3tag?  There are several patches floating around in various  
>> places
>> [1] that should be rolled into an official release.  There are also  
>> some
>> issues related to handling of broken iTunes tags that I'd like to  
>> fix and
>> don't see any patches for.  I'm happy to volunteer.
>>
>> [1]
>> http://patch-tracking.debian.net/package/libid3tag
>
> Those are patches we added to the package, the difference between
> our version and upstream's version.  And there hasn't been any
> activity upstream for a while.
>
> We really only have 1 open bug report:
> http://bugs.debian.org/350578
>
>> http://bugs.gentoo.org/show_bug.cgi?id=210564
>
> We have fixed this bug long before the gentoo bug report.  This is
> http://bugs.debian.org/304913
> http://bugs.debian.org/480187

Yeah, it looks like Gentoo has the most complete set of patches.  
However, there are a few issues with them:

http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/libid3tag/files/0.15.1b/

libid3tag-0.15.1b-compat.patch       - This is a duplicate of  
libid3tag-0.15.1b-unknown-encoding.patch
libid3tag-0.15.1b-fix_overflow.patch - This patch breaks reading of  
UTF-16BE tags.  The fix may be:

--- field.c.orig 2008-05-05 09:49:15.000000000 -0400
+++ field.c 2008-05-05 09:49:25.000000000 -0400
@@ -291,7 +291,7 @@

        end = *ptr + length;

-      while (end - *ptr > 0) {
+      while (end - *ptr > 0 && (*encoding ==  
ID3_FIELD_TEXTENCODING_UTF_16BE || **ptr != '\0')) {
  ucs4 = id3_parse_string(ptr, end - *ptr, *encoding, 0);
  if (ucs4 == 0)
   goto fail;