Make dependency on infrae.subversion optional in z3c.recipe.compattest?

[Jonathan Ballet-5]

Hi,

we are currently using z3c.recipe.compattest in our packages, which
are managed with Mercurial. This means that the current feature of
z3c.recipe.compattest which allows to find package in a Subversion
repository and so on, is currently not very interesting for us. It
also means more package installed (infrae.subversion and its
dependencies), which should, ideally not be their.

So, I wondered if a patch which would make infrae.subversion an extra
requirements to z3c.recipe.compattest (with corresponding code change)
would be accepted by maintainers of this package? If so, I'm willing
to make such change and to send a patch (in fact, I already started to
work on this, but as I'm not sure this will be accepted, I just ask).

Regards,

 Jonathan
_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Martijn Faassen-2]

Hey Jonathan,

I noticed that this post was still in the grok-dev submission queue -
for some reason the first time I didn't clear your future postings, not
sure what went wrong. I *think* I got it going now.

To others: who else is watching the grok-dev moderation queue?

Regards,

Martijn

_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Wolfgang Schnerring]

Hello,

* Jonathan Ballet <jonathan.ballet@...> [2009-09-25 13:49]:
> we are currently using z3c.recipe.compattest in our packages, which
> are managed with Mercurial. This means that the current feature of
> z3c.recipe.compattest which allows to find package in a Subversion
> repository and so on, is currently not very interesting for us. It
> also means more package installed (infrae.subversion and its
> dependencies), which should, ideally not be their.
>
> So, I wondered if a patch which would make infrae.subversion an extra
> requirements to z3c.recipe.compattest

I'm not a fan of extras_require (except for testing dependencies), and
to be honest, in a world of buildout, I don't really buy the "but that
dependency is superfluous for me" argument on its own, since the
"penalty" for not using the feature is about 500KB of disk space.

That said, I'm not convinced this "use a svn checkout" feature is all
that useful anymore (even though I co-wrote it ;).
In the context of the ZTK, one is working from a fixed set of versions,
and I'd think only touching at most a few packages at the same time.
There, you'll want to control the checkout locations yourself (since
you'll be editing those files), and not have them checked out
automatically and hidden away somewhere.

Summary: I'd rather not use an extras_require, but I'll take a hard look
at the subversion feature, whether it is actually useful or not.

Wolfgang

_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Wolfgang Schnerring]

* Wolfgang Schnerring <wosc@...> [2009-09-30 08:02]:
> * Jonathan Ballet <jonathan.ballet@...> [2009-09-25 13:49]:
>> we are currently using z3c.recipe.compattest in our packages, which
>> are managed with Mercurial. This means that the current feature of
>> z3c.recipe.compattest which allows to find package in a Subversion
>> repository and so on, is currently not very interesting for us.
> That said, I'm not convinced this "use a svn checkout" feature is all
> that useful anymore (even though I co-wrote it ;).

I've removed it in 0.11, it just doesn't belong to the compattest
recipe. This kind of functionality is provided much better by
mr.developer (and that also supports other SCMs beside svn).

Wolfgang

_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Jonathan Ballet-5]

On Wed, Sep 30, 2009 at 9:22 AM, Wolfgang Schnerring <wosc@...> wrote:

> * Wolfgang Schnerring <wosc@...> [2009-09-30 08:02]:
>> * Jonathan Ballet <jonathan.ballet@...> [2009-09-25 13:49]:
>>> we are currently using z3c.recipe.compattest in our packages, which
>>> are managed with Mercurial. This means that the current feature of
>>> z3c.recipe.compattest which allows to find package in a Subversion
>>> repository and so on, is currently not very interesting for us.
>> That said, I'm not convinced this "use a svn checkout" feature is all
>> that useful anymore (even though I co-wrote it ;).
>
> I've removed it in 0.11, it just doesn't belong to the compattest
> recipe. This kind of functionality is provided much better by
> mr.developer (and that also supports other SCMs beside svn).

Ok, this is a radical solution, but I didn't find any way to use this
extra requirements in my tests, anyway (I imagined that using "recipe
= zc.recipe.compattest [svn]" would do the trick, but it didn't seem
to work...) And indeed, this is a job well done (and much better) by
mr.developer.

Anyway, thank you for clarifying this out!

 Jonathan ("will my mail be kept in the submission queue? ;)")
_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Sebastien Douche]

On Wed, Sep 30, 2009 at 08:02, Wolfgang Schnerring <wosc@...> wrote:
> Hello,

Hi Wolfgang !

> I'm not a fan of extras_require (except for testing dependencies), and
> to be honest, in a world of buildout, I don't really buy the "but that
> dependency is superfluous for me" argument on its own, since the
> "penalty" for not using the feature is about 500KB of disk space.

I'm not agree. We use buildout for development and production (with
internals KGS), so it's more than "500KB of disk space".

BTW, thank you for the new release :).

--
Sebastien Douche <sdouche@...>
Twitter: http://bit.ly/afkrK (agile, python, open source)
_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev