Nabble - Maven - SCM

Re: Register new scm provider

2009-10-28T00:41:43Z

No, that did not work either, but adding the provider as a dependency of the scm plugin in the plugins section of the build definition did.

Thanks for your help.

Lee

Brett Porter
Mon, 26 Oct 2009 01:32:47 -0700

It should not be in the lib directory. You should add it under the build extensions.

- Brett

On 24/10/2009, at 4:56 AM, Lee Freyberg wrote:

Hi,

How do you go about registering a new provider?
I have created a stub impl following the instructions on the scm site, and placed the its jar in the maven/lib dir (adding it as a dependecy in the pom did not work), but I get an error when I try and run any of the scm commands.
I am fairly sure mvn is picking up the provider, as if I remove the jar from the lib dir I get a 'no provider for scm 'xxx'' message.
With the jar present I get a different error:

[INFO] Internal error in the plugin manager executing goal
'org.apache.maven.plugins:maven-scm-plugin:1.2:bootstrap': Unable to load the mojo 'org.apache.maven.plugins:maven-scm-plugin:1.2:bootstrap' in the
plugin 'org.apache.maven.plugins:maven-scm-plugin'. A
required class is missing:
org/apache/maven/scm/provider/AbstractScmProvider
org.apache.maven.scm.provider.AbstractScmProvider
Am I missing a dependency somewhere? Or is this not the correct way to register a provider?
Any pointers appreciated.

Cheers,
Lee

Re: Register new scm provider

2009-10-26T01:21:59Z

It should not be in the lib directory. You should add it under the build extensions.

- Brett

On 24/10/2009, at 4:56 AM, Lee Freyberg wrote:

Hi,

How do you go about registering a new provider?

I have created a stub impl following the instructions on the scm site, and placed the its jar in the maven/lib dir (adding it as a dependecy in the pom did not work), but I get an error when I try and run any of the scm commands.

I am fairly sure mvn is picking up the provider, as if I remove the jar from the lib dir I get a 'no provider for scm 'xxx'' message.

With the jar present I get a different error:

[INFO] Internal error in the plugin manager executing goal
'org.apache.maven.plugins:maven-scm-plugin:1.2:bootstrap': Unable to load
the mojo 'org.apache.maven.plugins:maven-scm-plugin:1.2:bootstrap' in the
plugin 'org.apache.maven.plugins:maven-scm-plugin'. A
required class is missing:
org/apache/maven/scm/provider/AbstractScmProvider
org.apache.maven.scm.provider.AbstractScmProvider

Am I missing a dependency somewhere? Or is this not the correct way to register a provider?

Any pointers appreciated.

Cheers,
Lee

Register new scm provider

2009-10-23T10:56:07Z

Hi,

How do you go about registering a new provider?

I have created a stub impl following the instructions on the scm site, and placed the its jar in the maven/lib dir (adding it as a dependecy in the pom did not work), but I get an error when I try and run any of the scm commands.

I am fairly sure mvn is picking up the provider, as if I remove the jar from the lib dir I get a 'no provider for scm 'xxx'' message.

With the jar present I get a different error:

[INFO] Internal error in the plugin manager executing goal
'org.apache.maven.plugins:maven-scm-plugin:1.2:bootstrap': Unable to load
the mojo 'org.apache.maven.plugins:maven-scm-plugin:1.2:bootstrap' in the
plugin 'org.apache.maven.plugins:maven-scm-plugin'. A
required class is missing:
org/apache/maven/scm/provider/AbstractScmProvider
org.apache.maven.scm.provider.AbstractScmProvider

Am I missing a dependency somewhere? Or is this not the correct way to register a provider?

Any pointers appreciated.

Cheers,

Lee

Release Problem: Commit failure to SVN

2009-10-03T07:50:15Z

Hi developers,

I send you this mail because I'm totally irritated. I tried a few times to release a component. But it always fails while committing in release:prepare phase.

Problem:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10 seconds
[INFO] Finished at: Fri Sep 25 15:34:46 CEST 2009
[INFO] Final Memory: 35M/154M
[INFO] ------------------------------------------------------------------------
[ERROR] org.apache.maven.shared.release.scm.ReleaseScmCommandException: Unable to commit files
Provider message:
The svn command failed.
Command output:
svn: Commit failed (details follow):
svn: Unrecognized URL scheme for ''

at org.apache.maven.shared.release.phase.ScmCommitPhase.checkin(ScmCommitPhase.java:133)
at org.apache.maven.shared.release.phase.ScmCommitPhase.execute(ScmCommitPhase.java:109)
at org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:194)
at org.apache.maven.shared.release.DefaultReleaseManager.prepareWithResult(DefaultReleaseManager.java:107)
at org.apache.maven.continuum.release.executors.PrepareReleaseTaskExecutor.execute(PrepareReleaseTaskExecutor.java:43)
at org.apache.maven.continuum.release.executors.AbstractReleaseTaskExecutor.executeTask(AbstractReleaseTaskExecutor.java:67)
at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable$1.run(ThreadedTaskQueueExecutor.java:116)
at edu.emory.mathcs.backport.java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.run(FutureTask.java:178)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1061)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:575)
at java.lang.Thread.run(Thread.java:619)

First of all I don't understand why the written URL is empty. We have set the SCM "connection" and also the "developerConnection" in our poms.

Above there is more information about all that could be interesting to investigate this problem:

SVN Structure:Multi module project that includes projects (on same level in SVN) via svn:externals.

Maven Version: 2.1.0

SVN Version: 1.5.7

Maven Release Plugin Version: 2.0-beta-9

So, that's it.

Thank you in advise for your help.

Best regards

Franco

Re: svn commit: r799755 - in /maven/scm/trunk: pom.xml src/main/ src/main/assembly/ src/main/assembly/source-release.xml

2009-08-01T07:53:05Z

Brian Fox wrote:

> On the infra list it seems like we'll be required to add
> them to svn anyway

When we do, could we use a well-known file extension like .txt for these
files? The source bundles we currently produce contain "LICENSE" and
"NOTICE" and these are not easily opened on Windows without a file
extension.

Benjamin

Re: svn commit: r799755 - in /maven/scm/trunk: pom.xml src/main/ src/main/assembly/ src/main/assembly/source-release.xml

2009-07-31T16:07:01Z

2009/7/31 Jason van Zyl <jvanzyl@...>:
> Ok, we need to figure out how to do this generally. I really don't want to see this in every POM we have. Brian, is there no way to share this?
>

Yes there is. The problem was getting the license and notice files
included. On the infra list it seems like we'll be required to add
them to svn anyway so that will make it easier for me to wrap up.

Re: svn commit: r799755 - in /maven/scm/trunk: pom.xml src/main/ src/main/assembly/ src/main/assembly/source-release.xml

2009-07-31T15:26:04Z

Ok, we need to figure out how to do this generally. I really don't
want to see this in every POM we have. Brian, is there no way to share
this?

On 31-Jul-09, at 3:06 PM, olamy@... wrote:

> Author: olamy
> Date: Fri Jul 31 22:06:43 2009
> New Revision: 799755
>
> URL: http://svn.apache.org/viewvc?rev=799755&view=rev
> Log:
> Add an ASF-compliant source release assembly
>
> Added:
> maven/scm/trunk/src/main/
> maven/scm/trunk/src/main/assembly/
> maven/scm/trunk/src/main/assembly/source-release.xml (with props)
> Modified:
> maven/scm/trunk/pom.xml
>
> Modified: maven/scm/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/maven/scm/trunk/pom.xml?rev=799755&r1=799754&r2=799755&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/scm/trunk/pom.xml (original)
> +++ maven/scm/trunk/pom.xml Fri Jul 31 22:06:43 2009
> @@ -318,5 +318,33 @@
> </plugins>
> </reporting>
> </profile>
> + <profile>
> + <id>release</id>
> + <build>
> + <plugins>
> + <plugin>
> + 
> + <artifactId>maven-assembly-plugin</artifactId>
> + <executions>
> + <execution>
> + <id>make-project-src-distro</id>
> + <phase>package</phase>
> + <goals>
> + <goal>single</goal>
> + </goals>
> + <configuration>
> + <descriptors>
> + <descriptor>src/main/assembly/source-
> release.xml</descriptor>
> + </descriptors>
> + <tarLongFileMode>gnu</tarLongFileMode>
> + </configuration>
> + </execution>
> + </executions>
> + </plugin>
> + </plugins>
> + </build>
> + </profile>
> </profiles>
> </project>
>
> Added: maven/scm/trunk/src/main/assembly/source-release.xml
> URL: http://svn.apache.org/viewvc/maven/scm/trunk/src/main/assembly/source-release.xml?rev=799755&view=auto
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- maven/scm/trunk/src/main/assembly/source-release.xml (added)
> +++ maven/scm/trunk/src/main/assembly/source-release.xml Fri Jul 31
> 22:06:43 2009
> @@ -0,0 +1,49 @@
> +<?xml version='1.0' encoding='UTF-8'?>
> +
> +
> +<assembly>
> + <id>source-release</id>
> + <formats>
> + <format>tar.gz</format>
> + <format>tar.bz2</format>
> + <format>zip</format>
> + </formats>
> + <fileSets>
> + <fileSet>
> + <directory>${project.basedir}</directory>
> + <outputDirectory>/</outputDirectory>
> + <useDefaultExcludes>true</useDefaultExcludes>
> + <excludes>
> + <exclude>**/*.iws</exclude>
> + <exclude>**/*.ipr</exclude>
> + <exclude>**/*.iml</exclude>
> + <exclude>*.log</exclude>
> + <exclude>target/**</exclude>
> + <exclude>**/.settings/**</exclude>
> + <exclude>**/*.classpath</exclude>
> + <exclude>**/*.project</exclude>
> + </excludes>
> + </fileSet>
> + <fileSet>
> + <directory>${project.build.directory}/maven-shared-archive-
> resources/META-INF</directory>
> + <outputDirectory>/</outputDirectory>
> + </fileSet>
> + </fileSets>
> +</assembly>
>
> Propchange: maven/scm/trunk/src/main/assembly/source-release.xml
> ------------------------------------------------------------------------------
> svn:eol-style = native
>
> Propchange: maven/scm/trunk/src/main/assembly/source-release.xml
> ------------------------------------------------------------------------------
> svn:keywords = Author Date Id Revision
>
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------

believe nothing, no matter where you read it,
or who has said it,
not even if i have said it,
unless it agrees with your own reason
and your own common sense.

-- Buddha

VSS plugin to maven

2009-07-12T06:54:07Z

Hi,

I have defined the VSS connection in Maven , and tried doing simple goals like mvn scm:update .

I see in the Eclipse console (I use M2Eclipse) that the VSS command is executed properly , but nothing seems to happen .

It is apparently stuck I have waited for 10 minutes , with no result.

Here is the log :

[INFO] Scanning for projects...

[INFO] ------------------------------------------------------------------------

[INFO] Building testMaven

[INFO]

[INFO] Id: testMaven:testMaven:jar:0.0.1-SNAPSHOT

[INFO] task-segment: [scm:update] (aggregator-style)

[INFO] ------------------------------------------------------------------------

[INFO] [scm:update]

[INFO] Executing: "C:\Program Files\Microsoft Visual SourceSafe\ss" Get $/Projects/testMaven -R -I- -GWS

[INFO] Working directory: D:\test_for_maven\testMaven

Here is my Configuration (pom.xml) :

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">

<groupId>testMaven</groupId>

<artifactId>testMaven</artifactId>

<version>0.0.1-SNAPSHOT</version>

<name>testMaven</name>

<url>http://maven.apache.org</url>

<groupId>junit</groupId>

<artifactId>junit</artifactId>

</dependency>

<groupId>org.apache.maven.scm</groupId>

<artifactId>maven-scm-provider-vss</artifactId>

</dependency>

</dependencies>

<scm>

<connection>scm:vss|\\mts-dev\vss\InvoiceManagement|/Projects/testMaven</connection>

</scm>

<build>

<groupId>org.apache.maven.plugins</groupId>

<artifactId>maven-scm-plugin</artifactId>

<goals>install</goals>

</configuration>

</plugin>

</plugins>

</build>

</project>

I am stuck and really don’t know how to figure this issue out

Please advise,

Regards,

Yair Friedman
MTS
Office: +972 (9) 7777 552
Email: yair.friedman@...
Web : www.mtsint.com

MTS is a global provider of Operations Support Systems (OSS) solutions for comprehensive Telecommunication Management and Customer Care & Billing (CC&B) used by Enterprises, Organizations, and Service Providers. Over 60,000 systems are deployed in 22 languages throughout the world!

AW: Maven SCM Provider for Rational Team Concert SCM?

2009-06-18T10:15:57Z

Hi Thomas!

Have you searched maven-scm JIRA [1] for a respective issue?
If you can't find it there, it most probably hasn't been started yet.

LieGrue,
strub

[1] http://jira.codehaus.org/browse/SCM

--- Lageson, Thomas (STP) <thomas.lageson@...> schrieb am Do, 18.6.2009:

> Von: Lageson, Thomas (STP) <thomas.lageson@...>
> Betreff: Maven SCM Provider for Rational Team Concert SCM?
> An: scm-dev@...
> Datum: Donnerstag, 18. Juni 2009, 15:56
>
>
>
>
>
> Maven SCM Provider for Rational Team Concert
> SCM?
>
>
>
>
> Has anyone started work on a
> Maven SCM Provider for the SCM built into Rational Team
> Concert/Jazz Foundation?
>
>
> - Tom
>
>
>
>
>
>

Maven SCM Provider for Rational Team Concert SCM?

2009-06-18T06:56:39Z

Maven SCM Provider for Rational Team Concert SCM?

Has anyone started work on a Maven SCM Provider for the SCM built into Rational Team Concert/Jazz Foundation?

- Tom

StatusScmResult.getChangedFiles not filled with files list

2009-05-22T03:08:59Z

Hi
After upgrading do SlikSvn 1.6 executing of svn.exe no longer fills StatusScmResult.getChangedFiles list.

I/m testing buildnumeber-maven-plugin. There are executed lines

ScmRepository repository = getScmRepository();
ScmProvider scmProvider = scmManager.getProviderByRepository(repository);
StatusScmResult result = scmProvider.status(repository, new ScmFileSet(scmDirectory));
getLog().info("Status3 1..." + result.getCommandLine());
getLog().info("Status3 2..." + result.getCommandOutput());
getLog().info("Status3 3..." + result.getProviderMessage());
getLog().info("Status3 4..." + result.getChangedFiles().toString());
getLog().info("Status3 5..." + result.isSuccess());
getLog().info("Status3 6..." + result.hashCode());
getLog().info("Status3 7..." + result.toString());

result.getChangedFiles is empty array but list of changed files are displayed.

Console output
(...)
[DEBUG] org.apache.maven.scm:maven-scm-api:jar:1.2
[DEBUG] org.apache.maven.scm:maven-scm-manager-plexus:jar:1.2
[DEBUG] org.apache.maven.scm:maven-scm-provider-accurev:jar:1.2
(...)
[INFO] Executing: cmd.exe /X /C "svn --non-interactive status"
[INFO] Working directory: D:\oss\workspace\oss\oss-services\oss-services-web
[DEBUG] ? .revision
[DEBUG] M src\main\java\pl\asseco\oss\test\web\TestSlownikiWS.java
[DEBUG] M pom.xml
[INFO] Status3 1...cmd.exe /X /C "svn --non-interactive status"
[INFO] Status3 2...null
[INFO] Status3 3...null
[INFO] Status3 4...[]
[INFO] Status3 5...true
[INFO] Status3 6...32219102
[INFO] Status3 7...org.apache.maven.scm.command.status.StatusScmResult@1eb9fde
[INFO] Status ...[]size 0

I suppose that svn works OK but problem is in reading file data from console output.

AW: problems setting up maven scm

2009-05-15T03:27:55Z

thomas, checkout the whole maven-scm project and do a mvn clean install from the top

btw, we should move this discussion over to the general dev list, since scm-dev will be dropped soon.

LieGrue,
strub

----- Ursprüngliche Mail ----

> Von: Thomas Schüttel <schuettel@...>
> An: scm-dev@...
> Gesendet: Freitag, den 15. Mai 2009, 11:39:18 Uhr
> Betreff: problems setting up maven scm
>
> Hi,
>
> I am new to Maven SCM and I am trying to setup the project in Eclipse using the
> m2eclipse plugin. Everything downloaded fine and I have now about 30 projects in
> Eclipse.
> But some projects do not compile successfully due to missing classes.
>
> e.g. class org.apache.maven.scm.provider.cvslib.command.CvsCommandUtils does not
> compile because it cannot find
> org.apache.maven.scm.providers.cvslib.settings.Settings.
> The class is contained in the binary distribution but apparently not in the
> source repository. There are more classes like this one which do not seem to be
> in the source repository.
>
> Where is the source for those files located? Or am I missing something?
> Thanks.
>
> Tom
> ______________________________________________________
> GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
> Jetzt freischalten unter http://movieflat.web.de

problems setting up maven scm

2009-05-15T02:39:18Z

Hi,

I am new to Maven SCM and I am trying to setup the project in Eclipse using the m2eclipse plugin. Everything downloaded fine and I have now about 30 projects in Eclipse.
But some projects do not compile successfully due to missing classes.

e.g. class org.apache.maven.scm.provider.cvslib.command.CvsCommandUtils does not compile because it cannot find org.apache.maven.scm.providers.cvslib.settings.Settings.
The class is contained in the binary distribution but apparently not in the source repository. There are more classes like this one which do not seem to be in the source repository.

Where is the source for those files located? Or am I missing something?
Thanks.

Tom
______________________________________________________
GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://movieflat.web.de

Question on ScmTckTestCase

2009-05-13T11:43:58Z

I am trying to write some TCK test cases for a new provider and I keep hitting an error at ScmTestCase.assertFile(). As far as I can see, this method asserts that the contents of a file equals the file's name (?). And ScmTckTestCase is using this method in setUp() to assert on '/pom.xml' whose content will definitely not match the filename.

Is my understanding wrong? What should I do to get rid of this error?

junit.framework.ComparisonFailure: The file doesn't contain the expected contents. File: C:\Temp\pom.xml expected:<[/pom.xml]> but was:<[<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">.. </project>]>

Thanks,

Subhash

how to treat Exceptions in ScmResults?

2009-05-06T14:01:26Z

Hi!

I'm currently implementing the maven-scm-providers-jgit and like to know how others did handle e.g. CheckOutScmResult for Java implemented SCM connectors. Especially what to do if an Exception occurred? How do you transport this nested Exception? fill only e.getMessage() or is there a trick I miss?

Currently I'm doing
> return new CheckOutScmResult("", "JGit clone failed.", e.getMessage(), false );
but this doesn't feel ok somehow.

txs and LieGrue,
strub

Re: [PATCH] Git Change log takes current path into account

2009-04-13T03:28:38Z

On Mon, Apr 13, 2009 at 3:30 PM, Mark Struberg <struberg@...> wrote:
>
> Btw Imran, if you find such things then please file a Jira yourself so we'd also have tracked your highly appreciated help as a git pro
> :)
>

Thanks for the hint :), I will do that in future as soon as I come
across it. Thank you too for quick responses with patches for the
issues that I have come up with in the past :).

Best regards,

Imran

> LieGrue,
> strub
>
> --- Mark Struberg <struberg@...> schrieb am Mo, 13.4.2009:
>
>> Von: Mark Struberg <struberg@...>
>> Betreff: Re: [PATCH] Git Change log takes current path into account
>> An: scm-dev@...
>> Datum: Montag, 13. April 2009, 11:22
>>
>> Hi Imran!
>>
>> Sorry that it took so long, but I was busy.
>>
>> > I would be grateful if you would kindly state an
>> example
>> > where it
>> > would not be sufficient with the change and was
>> without
>> > it.
>>
>> Benjamin pointed me to a page [1] where all those pitfalls
>> are listed.
>>
>> So what I'd do is to add a
>> -- ${basedir}
>> to the git-whatchanged command.
>>
>> I created a Jira [2] and attached my changes as patch.
>>
>> Please note that I've only tested this on Linux, so I'd be
>> glad if someone can test this on Win also? - txs!
>>
>>
>> LieGrue,
>> strub
>>
>> [1] http://maven.apache.org/plugin-developers/common-bugs.html#Resolving_Relative_Paths
>> [2] http://jira.codehaus.org/browse/SCM-458
>>
>> --- Imran M Yousuf <imyousuf@...>
>> schrieb am Di, 7.4.2009:
>>
>> > Von: Imran M Yousuf <imyousuf@...>
>> > Betreff: Re: [PATCH] Git Change log takes current path
>> into account
>> > An: "Mark Struberg" <struberg@...>
>> > CC: scm-dev@...
>> > Datum: Dienstag, 7. April 2009, 10:32
>> > On Tue, Apr 7, 2009 at 1:42 PM, Mark
>> > Struberg <struberg@...>
>> > wrote:
>> > >
>> > > Hi Imran!
>> > >
>> > > What is the special usecase for this?
>> > > Maybe multi-module builds where the current pom
>> is
>> > only 1 sub-module of the whole build?
>> > >
>> >
>> > It is not a special case but the usual case that I am
>> want
>> > it to work
>> > as it should :). Lets think of a multi-module build or
>> a
>> > project that
>> > has the pom.xml in a sub-directory of the project. I
>> will
>> > try to
>> > explain more with 2 examples.
>> >
>> > First, a single module project. Let us suppose that we
>> have
>> > a project
>> > tree as follows:
>> >
>> > root
>> > |->project
>> > |->pom.xml
>> > |->some_other_stuff
>> >
>> > Now when maven will take changelog of it the history
>> > rationally should
>> > include only histories of the changes under 'project'
>> > sub-tree and not
>> > of all the project. Adding the '.' will do just that.
>> >
>> > Secondly, let us take a multi-module project. In that
>> case
>> > when a
>> > changelog is requested it should show the changes made
>> to
>> > that tree,
>> > and not whole project. Adding the '.' will do just
>> that.
>> >
>> > > I'm not really sure if we can safely assume to
>> always
>> > execute in the modules path. To be honest, I doubt it!
>> I
>> > have something in my mind, but I'm not sure which case
>> it
>> > was. Maybe CI builds, hmmm? In those cases a single
>> '.'
>> > would not be sufficient.
>> > >
>> >
>> > I would be grateful if you would kindly state an
>> example
>> > where it
>> > would not be sufficient with the change and was
>> without
>> > it.
>> >
>> > > And there is a really subtle difference with git
>> in
>> > releasing multi-module builds.
>> > >
>> >
>> > Yes that is true, but I do not see that effecting
>> release
>> > process :).
>> >
>> > > As you know, Git only handles full trees and not
>> > single files. So the behaviour of a release differes
>> if the
>> > git repo contains all the modules (including parent)
>> or if
>> > there is a git-submodule involved.
>> > >
>> >
>> > What I am not sure how does it adversely effect
>> release
>> > behavior? It
>> > is not clear to me.
>> >
>> > > So there are most probably still a few things
>> left to
>> > do.
>> > >
>> >
>> > Please point them out and I will gladly help out. But
>> this
>> > is a change
>> > I think would be beneficial to many not to mention
>> that I
>> > am eagerly
>> > waiting to see its introduction :). Without this in a
>> > multi-module
>> > scenario changelog does not make much (if any at all)
>> > sense.
>> >
>> > Thank you,
>> >
>> > > LieGrue,
>> > > strub
>> > >
>> > > --- Imran M Yousuf <imyousuf@...>
>> > schrieb am Di, 7.4.2009:
>> > >
>> > >> Von: Imran M Yousuf <imyousuf@...>
>> > >> Betreff: [PATCH] Git Change log takes current
>> path
>> > into account
>> > >> An: scm-dev@...
>> > >> CC: "Mark Struberg" <struberg@...>
>> > >> Datum: Dienstag, 7. April 2009, 5:23
>> > >> Hi,
>> > >>
>> > >> I was just checking the commands generated by
>> git
>> > changelog
>> > >> and I
>> > >> noticed that it does not respect the path,
>> whereas
>> > it is
>> > >> very easy to
>> > >> integrate it, mentioning a simple '.' at the
>> end
>> > of the
>> > >> 'git
>> > >> whatchanged' command does the trick and thats
>> what
>> > the
>> > >> attached patch
>> > >> does.
>> > >>
>> > >> I would be grateful if this would be
>> integrated
>> > with the
>> > >> current
>> > >> version as this change has a grave positive
>> effect
>> > on maven
>> > >> site's
>> > >> changelog report.
>> > >>
>> > >> Thank you,
>> > >>
>> > >> --
>> > >> Imran M Yousuf
>> > >> Entrepreneur & Software Engineer
>> > >> Smart IT Engineering
>> > >> Dhaka, Bangladesh
>> > >> Email: imran@...
>> > >> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> > >> Mobile: +880-1711402557
>> > >>
>> > >
>> > >
>> > >
>> > >
>> >
>> >
>> >
>> > --
>> > Imran M Yousuf
>> > Entrepreneur & Software Engineer
>> > Smart IT Engineering
>> > Dhaka, Bangladesh
>> > Email: imran@...
>> > Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> > Mobile: +880-1711402557
>> >
>>
>>
>>
>>
>
>
>
>

--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@...
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

Re: [PATCH] Git Change log takes current path into account

2009-04-13T02:30:22Z

Btw Imran, if you find such things then please file a Jira yourself so we'd also have tracked your highly appreciated help as a git pro
:)

LieGrue,
strub

--- Mark Struberg <struberg@...> schrieb am Mo, 13.4.2009:

> Von: Mark Struberg <struberg@...>
> Betreff: Re: [PATCH] Git Change log takes current path into account
> An: scm-dev@...
> Datum: Montag, 13. April 2009, 11:22
>
> Hi Imran!
>
> Sorry that it took so long, but I was busy.
>
> > I would be grateful if you would kindly state an
> example
> > where it
> > would not be sufficient with the change and was
> without
> > it.
>
> Benjamin pointed me to a page [1] where all those pitfalls
> are listed.
>
> So what I'd do is to add a
> -- ${basedir}
> to the git-whatchanged command.
>
> I created a Jira [2] and attached my changes as patch.
>
> Please note that I've only tested this on Linux, so I'd be
> glad if someone can test this on Win also? - txs!
>
>
> LieGrue,
> strub
>
> [1] http://maven.apache.org/plugin-developers/common-bugs.html#Resolving_Relative_Paths
> [2] http://jira.codehaus.org/browse/SCM-458
>
> --- Imran M Yousuf <imyousuf@...>
> schrieb am Di, 7.4.2009:
>
> > Von: Imran M Yousuf <imyousuf@...>
> > Betreff: Re: [PATCH] Git Change log takes current path
> into account
> > An: "Mark Struberg" <struberg@...>
> > CC: scm-dev@...
> > Datum: Dienstag, 7. April 2009, 10:32
> > On Tue, Apr 7, 2009 at 1:42 PM, Mark
> > Struberg <struberg@...>
> > wrote:
> > >
> > > Hi Imran!
> > >
> > > What is the special usecase for this?
> > > Maybe multi-module builds where the current pom
> is
> > only 1 sub-module of the whole build?
> > >
> >
> > It is not a special case but the usual case that I am
> want
> > it to work
> > as it should :). Lets think of a multi-module build or
> a
> > project that
> > has the pom.xml in a sub-directory of the project. I
> will
> > try to
> > explain more with 2 examples.
> >
> > First, a single module project. Let us suppose that we
> have
> > a project
> > tree as follows:
> >
> > root
> > |->project
> > |->pom.xml
> > |->some_other_stuff
> >
> > Now when maven will take changelog of it the history
> > rationally should
> > include only histories of the changes under 'project'
> > sub-tree and not
> > of all the project. Adding the '.' will do just that.
> >
> > Secondly, let us take a multi-module project. In that
> case
> > when a
> > changelog is requested it should show the changes made
> to
> > that tree,
> > and not whole project. Adding the '.' will do just
> that.
> >
> > > I'm not really sure if we can safely assume to
> always
> > execute in the modules path. To be honest, I doubt it!
> I
> > have something in my mind, but I'm not sure which case
> it
> > was. Maybe CI builds, hmmm? In those cases a single
> '.'
> > would not be sufficient.
> > >
> >
> > I would be grateful if you would kindly state an
> example
> > where it
> > would not be sufficient with the change and was
> without
> > it.
> >
> > > And there is a really subtle difference with git
> in
> > releasing multi-module builds.
> > >
> >
> > Yes that is true, but I do not see that effecting
> release
> > process :).
> >
> > > As you know, Git only handles full trees and not
> > single files. So the behaviour of a release differes
> if the
> > git repo contains all the modules (including parent)
> or if
> > there is a git-submodule involved.
> > >
> >
> > What I am not sure how does it adversely effect
> release
> > behavior? It
> > is not clear to me.
> >
> > > So there are most probably still a few things
> left to
> > do.
> > >
> >
> > Please point them out and I will gladly help out. But
> this
> > is a change
> > I think would be beneficial to many not to mention
> that I
> > am eagerly
> > waiting to see its introduction :). Without this in a
> > multi-module
> > scenario changelog does not make much (if any at all)
> > sense.
> >
> > Thank you,
> >
> > > LieGrue,
> > > strub
> > >
> > > --- Imran M Yousuf <imyousuf@...>
> > schrieb am Di, 7.4.2009:
> > >
> > >> Von: Imran M Yousuf <imyousuf@...>
> > >> Betreff: [PATCH] Git Change log takes current
> path
> > into account
> > >> An: scm-dev@...
> > >> CC: "Mark Struberg" <struberg@...>
> > >> Datum: Dienstag, 7. April 2009, 5:23
> > >> Hi,
> > >>
> > >> I was just checking the commands generated by
> git
> > changelog
> > >> and I
> > >> noticed that it does not respect the path,
> whereas
> > it is
> > >> very easy to
> > >> integrate it, mentioning a simple '.' at the
> end
> > of the
> > >> 'git
> > >> whatchanged' command does the trick and thats
> what
> > the
> > >> attached patch
> > >> does.
> > >>
> > >> I would be grateful if this would be
> integrated
> > with the
> > >> current
> > >> version as this change has a grave positive
> effect
> > on maven
> > >> site's
> > >> changelog report.
> > >>
> > >> Thank you,
> > >>
> > >> --
> > >> Imran M Yousuf
> > >> Entrepreneur & Software Engineer
> > >> Smart IT Engineering
> > >> Dhaka, Bangladesh
> > >> Email: imran@...
> > >> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> > >> Mobile: +880-1711402557
> > >>
> > >
> > >
> > >
> > >
> >
> >
> >
> > --
> > Imran M Yousuf
> > Entrepreneur & Software Engineer
> > Smart IT Engineering
> > Dhaka, Bangladesh
> > Email: imran@...
> > Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> > Mobile: +880-1711402557
> >
>
>
>
>

Re: [PATCH] Git Change log takes current path into account

2009-04-13T02:22:35Z

Hi Imran!

Sorry that it took so long, but I was busy.

> I would be grateful if you would kindly state an example
> where it
> would not be sufficient with the change and was without
> it.

Benjamin pointed me to a page [1] where all those pitfalls are listed.

So what I'd do is to add a
-- ${basedir}
to the git-whatchanged command.

I created a Jira [2] and attached my changes as patch.

Please note that I've only tested this on Linux, so I'd be glad if someone can test this on Win also? - txs!

LieGrue,
strub

[1] http://maven.apache.org/plugin-developers/common-bugs.html#Resolving_Relative_Paths
[2] http://jira.codehaus.org/browse/SCM-458

--- Imran M Yousuf <imyousuf@...> schrieb am Di, 7.4.2009:

> Von: Imran M Yousuf <imyousuf@...>
> Betreff: Re: [PATCH] Git Change log takes current path into account
> An: "Mark Struberg" <struberg@...>
> CC: scm-dev@...
> Datum: Dienstag, 7. April 2009, 10:32
> On Tue, Apr 7, 2009 at 1:42 PM, Mark
> Struberg <struberg@...>
> wrote:
> >
> > Hi Imran!
> >
> > What is the special usecase for this?
> > Maybe multi-module builds where the current pom is
> only 1 sub-module of the whole build?
> >
>
> It is not a special case but the usual case that I am want
> it to work
> as it should :). Lets think of a multi-module build or a
> project that
> has the pom.xml in a sub-directory of the project. I will
> try to
> explain more with 2 examples.
>
> First, a single module project. Let us suppose that we have
> a project
> tree as follows:
>
> root
> |->project
> |->pom.xml
> |->some_other_stuff
>
> Now when maven will take changelog of it the history
> rationally should
> include only histories of the changes under 'project'
> sub-tree and not
> of all the project. Adding the '.' will do just that.
>
> Secondly, let us take a multi-module project. In that case
> when a
> changelog is requested it should show the changes made to
> that tree,
> and not whole project. Adding the '.' will do just that.
>
> > I'm not really sure if we can safely assume to always
> execute in the modules path. To be honest, I doubt it! I
> have something in my mind, but I'm not sure which case it
> was. Maybe CI builds, hmmm? In those cases a single '.'
> would not be sufficient.
> >
>
> I would be grateful if you would kindly state an example
> where it
> would not be sufficient with the change and was without
> it.
>
> > And there is a really subtle difference with git in
> releasing multi-module builds.
> >
>
> Yes that is true, but I do not see that effecting release
> process :).
>
> > As you know, Git only handles full trees and not
> single files. So the behaviour of a release differes if the
> git repo contains all the modules (including parent) or if
> there is a git-submodule involved.
> >
>
> What I am not sure how does it adversely effect release
> behavior? It
> is not clear to me.
>
> > So there are most probably still a few things left to
> do.
> >
>
> Please point them out and I will gladly help out. But this
> is a change
> I think would be beneficial to many not to mention that I
> am eagerly
> waiting to see its introduction :). Without this in a
> multi-module
> scenario changelog does not make much (if any at all)
> sense.
>
> Thank you,
>
> > LieGrue,
> > strub
> >
> > --- Imran M Yousuf <imyousuf@...>
> schrieb am Di, 7.4.2009:
> >
> >> Von: Imran M Yousuf <imyousuf@...>
> >> Betreff: [PATCH] Git Change log takes current path
> into account
> >> An: scm-dev@...
> >> CC: "Mark Struberg" <struberg@...>
> >> Datum: Dienstag, 7. April 2009, 5:23
> >> Hi,
> >>
> >> I was just checking the commands generated by git
> changelog
> >> and I
> >> noticed that it does not respect the path, whereas
> it is
> >> very easy to
> >> integrate it, mentioning a simple '.' at the end
> of the
> >> 'git
> >> whatchanged' command does the trick and thats what
> the
> >> attached patch
> >> does.
> >>
> >> I would be grateful if this would be integrated
> with the
> >> current
> >> version as this change has a grave positive effect
> on maven
> >> site's
> >> changelog report.
> >>
> >> Thank you,
> >>
> >> --
> >> Imran M Yousuf
> >> Entrepreneur & Software Engineer
> >> Smart IT Engineering
> >> Dhaka, Bangladesh
> >> Email: imran@...
> >> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> >> Mobile: +880-1711402557
> >>
> >
> >
> >
> >
>
>
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

Re: [PATCH] Git Change log takes current path into account

2009-04-07T01:32:14Z

On Tue, Apr 7, 2009 at 1:42 PM, Mark Struberg <struberg@...> wrote:
>
> Hi Imran!
>
> What is the special usecase for this?
> Maybe multi-module builds where the current pom is only 1 sub-module of the whole build?
>

It is not a special case but the usual case that I am want it to work
as it should :). Lets think of a multi-module build or a project that
has the pom.xml in a sub-directory of the project. I will try to
explain more with 2 examples.

First, a single module project. Let us suppose that we have a project
tree as follows:

root
|->project
|->pom.xml
|->some_other_stuff

Now when maven will take changelog of it the history rationally should
include only histories of the changes under 'project' sub-tree and not
of all the project. Adding the '.' will do just that.

Secondly, let us take a multi-module project. In that case when a
changelog is requested it should show the changes made to that tree,
and not whole project. Adding the '.' will do just that.

> I'm not really sure if we can safely assume to always execute in the modules path. To be honest, I doubt it! I have something in my mind, but I'm not sure which case it was. Maybe CI builds, hmmm? In those cases a single '.' would not be sufficient.
>

I would be grateful if you would kindly state an example where it
would not be sufficient with the change and was without it.

> And there is a really subtle difference with git in releasing multi-module builds.
>

Yes that is true, but I do not see that effecting release process :).

> As you know, Git only handles full trees and not single files. So the behaviour of a release differes if the git repo contains all the modules (including parent) or if there is a git-submodule involved.
>

What I am not sure how does it adversely effect release behavior? It
is not clear to me.

> So there are most probably still a few things left to do.
>

Please point them out and I will gladly help out. But this is a change
I think would be beneficial to many not to mention that I am eagerly
waiting to see its introduction :). Without this in a multi-module
scenario changelog does not make much (if any at all) sense.

Thank you,

> LieGrue,
> strub
>
> --- Imran M Yousuf <imyousuf@...> schrieb am Di, 7.4.2009:
>
>> Von: Imran M Yousuf <imyousuf@...>
>> Betreff: [PATCH] Git Change log takes current path into account
>> An: scm-dev@...
>> CC: "Mark Struberg" <struberg@...>
>> Datum: Dienstag, 7. April 2009, 5:23
>> Hi,
>>
>> I was just checking the commands generated by git changelog
>> and I
>> noticed that it does not respect the path, whereas it is
>> very easy to
>> integrate it, mentioning a simple '.' at the end of the
>> 'git
>> whatchanged' command does the trick and thats what the
>> attached patch
>> does.
>>
>> I would be grateful if this would be integrated with the
>> current
>> version as this change has a grave positive effect on maven
>> site's
>> changelog report.
>>
>> Thank you,
>>
>> --
>> Imran M Yousuf
>> Entrepreneur & Software Engineer
>> Smart IT Engineering
>> Dhaka, Bangladesh
>> Email: imran@...
>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> Mobile: +880-1711402557
>>
>
>
>
>

--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@...
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

AW: [PATCH] Git Change log takes current path into account

2009-04-07T00:43:28Z

Hi Imran!

What is the special usecase for this?
Maybe multi-module builds where the current pom is only 1 sub-module of the whole build?

I'm not really sure if we can safely assume to always execute in the modules path. To be honest, I doubt it! I have something in my mind, but I'm not sure which case it was. Maybe CI builds, hmmm? In those cases a single '.' would not be sufficient.

And there is a really subtle difference with git in releasing multi-module builds.

As you know, Git only handles full trees and not single files. So the behaviour of a release differes if the git repo contains all the modules (including parent) or if there is a git-submodule involved.

So there are most probably still a few things left to do.

LieGrue,
strub

--- Imran M Yousuf <imyousuf@...> schrieb am Di, 7.4.2009:

> Von: Imran M Yousuf <imyousuf@...>
> Betreff: [PATCH] Git Change log takes current path into account
> An: scm-dev@...
> CC: "Mark Struberg" <struberg@...>
> Datum: Dienstag, 7. April 2009, 5:23
> Hi,
>
> I was just checking the commands generated by git changelog
> and I
> noticed that it does not respect the path, whereas it is
> very easy to
> integrate it, mentioning a simple '.' at the end of the
> 'git
> whatchanged' command does the trick and thats what the
> attached patch
> does.
>
> I would be grateful if this would be integrated with the
> current
> version as this change has a grave positive effect on maven
> site's
> changelog report.
>
> Thank you,
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

Re: [PATCH] Git Change log takes current path into account

2009-04-06T23:48:37Z

FYI, please check the following site to see the patch in action.
http://imyousuf.github.com/smart-dao/site/index.html

Thank you,

- Imran

On Tue, Apr 7, 2009 at 9:23 AM, Imran M Yousuf <imyousuf@...> wrote:

> Hi,
>
> I was just checking the commands generated by git changelog and I
> noticed that it does not respect the path, whereas it is very easy to
> integrate it, mentioning a simple '.' at the end of the 'git
> whatchanged' command does the trick and thats what the attached patch
> does.
>
> I would be grateful if this would be integrated with the current
> version as this change has a grave positive effect on maven site's
> changelog report.
>
> Thank you,
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@...
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

[PATCH] Git Change log takes current path into account

2009-04-06T20:23:19Z

Hi,

I was just checking the commands generated by git changelog and I
noticed that it does not respect the path, whereas it is very easy to
integrate it, mentioning a simple '.' at the end of the 'git
whatchanged' command does the trick and thats what the attached patch
does.

I would be grateful if this would be integrated with the current
version as this change has a grave positive effect on maven site's
changelog report.

Thank you,

--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@...
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

[respect-path.patch]

# This patch file was generated by NetBeans IDE # Following Index: paths are relative to: /home/imyousuf/projects/maven-scm/trunk/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe # This patch can be applied using context Tools: Patch action on respective folder. # It uses platform neutral UTF-8 encoding and \n newlines. # Above lines and this line are ignored by the patching process. Index: src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java --- src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java Base (BASE) +++ src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java Locally Modified (Based On LOCAL) @@ -155,6 +155,9 @@ cl.createArg().setValue( branch.getName() ); } + // It should consider to provide log for the current path only + cl.createArg().setValue("."); + return cl; } } Index: src/test/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommandTest.java --- src/test/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommandTest.java Base (BASE) +++ src/test/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommandTest.java Locally Modified (Based On LOCAL) @@ -42,7 +42,7 @@ throws Exception { testCommandLine( "scm:git:http://foo.com/git", null, (Date) null, (Date) null, - "git whatchanged --date=iso" ); + "git whatchanged --date=iso ." ); } public void testCommandLineWithDates() @@ -52,7 +52,7 @@ Date endDate = getDate( 2007, Calendar.OCTOBER, 10, GMT_TIME_ZONE ); testCommandLine( "scm:git:http://foo.com/git", null, startDate, endDate, - "git whatchanged \"--since=2003-09-10 00:00:00 +0000\" \"--until=2007-10-10 00:00:00 +0000\" --date=iso" ); + "git whatchanged \"--since=2003-09-10 00:00:00 +0000\" \"--until=2007-10-10 00:00:00 +0000\" --date=iso ." ); } public void testCommandLineStartDateOnly() @@ -61,7 +61,7 @@ Date startDate = getDate( 2003, Calendar.SEPTEMBER, 10, 1, 1, 1, GMT_TIME_ZONE ); testCommandLine( "scm:git:http://foo.com/git", null, startDate, null, - "git whatchanged \"--since=2003-09-10 01:01:01 +0000\" --date=iso" ); + "git whatchanged \"--since=2003-09-10 01:01:01 +0000\" --date=iso ." ); } public void testCommandLineDateFormat() @@ -71,7 +71,7 @@ Date endDate = getDate( 2005, Calendar.NOVEMBER, 13, 23, 23, 23, GMT_TIME_ZONE ); testCommandLine( "scm:git:http://foo.com/git", null, startDate, endDate, - "git whatchanged \"--since=2003-09-10 01:01:01 +0000\" \"--until=2005-11-13 23:23:23 +0000\" --date=iso" ); + "git whatchanged \"--since=2003-09-10 01:01:01 +0000\" \"--until=2005-11-13 23:23:23 +0000\" --date=iso ." ); } public void testCommandLineDateVersionRanges() @@ -81,7 +81,7 @@ Date endDate = getDate( 2005, Calendar.NOVEMBER, 13, 23, 23, 23, GMT_TIME_ZONE ); testCommandLine( "scm:git:http://foo.com/git", null, startDate, endDate, new ScmRevision( "1" ), new ScmRevision( "10" ), - "git whatchanged \"--since=2003-09-10 01:01:01 +0000\" \"--until=2005-11-13 23:23:23 +0000\" --date=iso 1..10" ); + "git whatchanged \"--since=2003-09-10 01:01:01 +0000\" \"--until=2005-11-13 23:23:23 +0000\" --date=iso 1..10 ." ); } public void testCommandLineEndDateOnly() @@ -91,14 +91,14 @@ // Only specifying end date should print no dates at all testCommandLine( "scm:git:http://foo.com/git", null, null, endDate, - "git whatchanged \"--until=2003-11-10 00:00:00 +0000\" --date=iso" ); + "git whatchanged \"--until=2003-11-10 00:00:00 +0000\" --date=iso ." ); } public void testCommandLineWithBranchNoDates() throws Exception { testCommandLine( "scm:git:http://foo.com/git", new ScmBranch( "my-test-branch" ), (Date) null, (Date) null, - "git whatchanged --date=iso my-test-branch" ); + "git whatchanged --date=iso my-test-branch ." ); } @@ -106,28 +106,28 @@ throws Exception { testCommandLine( "scm:git:http://foo.com/git", null, new ScmRevision( "1" ), null, - "git whatchanged --date=iso 1.." ); + "git whatchanged --date=iso 1.. ." ); } public void testCommandLineWithStartVersionAndEndVersion() throws Exception { testCommandLine( "scm:git:http://foo.com/git", null, new ScmRevision( "1" ), new ScmRevision( "10" ), - "git whatchanged --date=iso 1..10" ); + "git whatchanged --date=iso 1..10 ." ); } public void testCommandLineWithStartVersionAndEndVersionEquals() throws Exception { testCommandLine( "scm:git:http://foo.com/git", null, new ScmRevision( "1" ), new ScmRevision( "1" ), - "git whatchanged --date=iso 1..1" ); + "git whatchanged --date=iso 1..1 ." ); } public void testCommandLineWithStartVersionAndEndVersionAndBranch() throws Exception { testCommandLine( "scm:git:http://foo.com/git", new ScmBranch( "my-test-branch" ), new ScmRevision( "1" ), new ScmRevision( "10" ), - "git whatchanged --date=iso 1..10 my-test-branch" ); + "git whatchanged --date=iso 1..10 my-test-branch ." ); } // ----------------------------------------------------------------------

scm:changelog command does not include author with spaces

2009-04-06T07:54:04Z

I have justed raised 2 jiras to track this issue:

http://jira.codehaus.org/browse/SCM-455
http://jira.codehaus.org/browse/MCHANGELOG-94

If you have an author with any spaces in the name of the author, the
changelog report does not include these changes in the report. The
problem resides in the SCM project but of course affects the change log
plugin. Thus I raised a jira for both.

Please comment/vote etc...

Thanks.

---
Todd Thiessen

RE: Re: accurev provider

2009-04-03T14:02:01Z

The plugin version submitted by Grant (JIRA SCM-445) is already more
completed than the current available version.

I'm currently using the release plugin with it and it works!

The url change was required to implement the additional accurev
commands. No sure about compatibility with previous version (if this is
what you meant by "effect of the new URL syntax").

In fact, I was only able to use the plugin release with Accurev after
Grant contribution.

Pedro

-------- Original Message --------

Subject: Re: accurev provider

Date: Wed, 1 Apr 2009 01:56:19 +1100

From: Brett Porter <brett@...>

To: scm-dev@...

Do the authors of the original provider, or other users here, have an

opinion on this? I like that it is more complete (functionally, and in

docs and tests), however am not an accurev user myself.

What effect does the URL syntax change have?

Also Grant, I haven't seen the CLA yet?

- Brett

Re: accurev provider

2009-04-01T04:19:13Z

I faxed in the CLA today. Also uploaded a new version to the JIRA that
fixes a few bugs under Windows.

Grant.

On Wed, 1 Apr 2009 01:56:19 +1100, Brett Porter <brett@...> wrote:

> Do the authors of the original provider, or other users here, have an
> opinion on this? I like that it is more complete (functionally, and in
> docs and tests), however am not an accurev user myself.
>
> What effect does the URL syntax change have?
>
> Also Grant, I haven't seen the CLA yet?
>
> - Brett
>
> On 17/03/2009, at 11:58 PM, Grant Gardner wrote:
>
>>
>>
>> I've created the jira with attached code. Let me know if there's
>> anything
>> else I need to do.
>> http://jira.codehaus.org/browse/SCM-445
>>
>> Will do the CLA when I find myself conveniently located near a fax or
>> scanner.
>>

Re: A probable bug in git scm provider for maven-scm-plugin

2009-04-01T01:10:33Z

On Wed, Apr 1, 2009 at 1:48 PM, Mark Struberg <struberg@...> wrote:
>
> cool, I've attached a patch in SCM-454.
> Can you please test this?
>

Yup, that works as well :).

Thanks,

Imran

> txs and LieGrue,
> strub
>
> --- Imran M Yousuf <imyousuf@...> schrieb am Mi, 1.4.2009:
>
>> Von: Imran M Yousuf <imyousuf@...>
>> Betreff: Re: A probable bug in git scm provider for maven-scm-plugin
>> An: scm-dev@...
>> Datum: Mittwoch, 1. April 2009, 9:45
>> On Wed, Apr 1, 2009 at 12:39 PM, Mark
>> Struberg <struberg@...>
>> wrote:
>> >
>> > Hi Imran!
>> >
>> > I did almost the same changes yesterday evening, but
>> hadn't got a chance to send them yet them.
>> >
>> > I've additionally added the missing branch handling
>> and will add the patch to the corresponding JIRA.
>> >
>>
>> Great, let me know when its in trunk, I will update and
>> test it.
>>
>> Thank you,
>>
>> Imran
>>
>> > LieGrue,
>> > strub
>> >
>> > --- Imran M Yousuf <imyousuf@...>
>> schrieb am Mi, 1.4.2009:
>> >
>> >> Von: Imran M Yousuf <imyousuf@...>
>> >> Betreff: Re: A probable bug in git scm provider
>> for maven-scm-plugin
>> >> An: scm-dev@...
>> >> CC: "Mark Struberg" <struberg@...>
>> >> Datum: Mittwoch, 1. April 2009, 6:50
>> >> Hi,
>> >>
>> >> I have made the required changes to gitexe
>> implementation
>> >> and
>> >> corresponding test case and also tested it with my
>> scenario
>> >> and it
>> >> works fine. Please have a look at it and let me
>> know what
>> >> you think.
>> >>
>> >> Best regards,
>> >>
>> >> Imran
>> >>
>> >> On Tue, Mar 31, 2009 at 3:39 PM, Imran M Yousuf
>> <imyousuf@...>
>> >> wrote:
>> >> > On Tue, Mar 31, 2009 at 2:57 PM, Mark
>> Struberg <struberg@...>
>> >> wrote:
>> >> >>
>> >> >> Hi Imran!
>> >> >>
>> >> >> I recently changed the command back from
>> git-log
>> >> to git-whatchanged because I originally programmed
>> the
>> >> output consumer to fit git-whatchanged. Don't know
>> anymore
>> >> when we did this, but the git-log output hasn't
>> been
>> >> parseable with the GitLogConsumer for a while :(
>> >> >>
>> >> >> From the man git-whatchanged
>> (git-1.6.0.6) --since
>> >> should be supported:
>> >> >>> git whatchanged --since="2 weeks ago"
>> -- gitk
>> >> >>
>> >> >
>> >> > Right, this is an example in the man pages,
>> but as I
>> >> said --since
>> >> > expects date or date like expressions
>> (probably) but
>> >> not tags or
>> >> > revision sha1. I have tried it several times
>> >> unfortunately and that
>> >> > also with both 1.5.6 and 1.6.2.1.
>> >> >
>> >> > Please let me know what you think about the
>> changes I
>> >> sent you,
>> >> > because I believe they will solve the issue.
>> >> >
>> >> > Thank you,
>> >> >
>> >> > Imran
>> >> >
>> >> >> If you look at the git code it should
>> take the
>> >> --since and --until!
>> >> >> This is also backed up with the comment
>> in the man
>> >> page:
>> >> >>> The command internally invokes
>> git-rev-list
>> >> piped to
>> >> >>> git-diff-tree, and takes command line
>> options
>> >> for both
>> >> >>> of these commands.
>> >> >>
>> >> >> So imho --since and --until should work.
>> >> >>
>> >> >> Can you please try the git-whatchanged on
>> the
>> >> commandline again and play with the since date to
>> see if the
>> >> output changes? - txs!
>> >> >>
>> >> >> But maybe we trapped another error the
>> code
>> >> suffers from!
>> >> >>
>> >> >> LieGrue,
>> >> >> strub
>> >> >>
>> >> >>
>> >> >> --- Imran M Yousuf <imyousuf@...>
>> >> schrieb am Di, 31.3.2009:
>> >> >>
>> >> >>> Von: Imran M Yousuf <imyousuf@...>
>> >> >>> Betreff: A probable bug in git scm
>> provider
>> >> for maven-scm-plugin
>> >> >>> An: scm-dev@...
>> >> >>> CC: struberg@...
>> >> >>> Datum: Dienstag, 31. März 2009,
>> 6:17
>> >> >>> Hi,
>> >> >>>
>> >> >>> When I use the
>> <type>tag</type> in
>> >> changelog
>> >> >>> configuration (its at the
>> >> >>> end of the email), it uses the
>> following query
>> >> for
>> >> >>> generating the
>> >> >>> changeset -
>> >> >>>
>> >> >>> git whatchanged --since=0.3
>> --until=HEAD
>> >> --date=iso
>> >> >>>
>> >> >>> While 'git help whatchanged' says
>> nothing
>> >> about '--since'
>> >> >>> but the 'git
>> >> >>> help log' says that '--since' is to
>> be a date,
>> >> thus IMHO,
>> >> >>> the
>> >> >>> implementation should have been
>> something like
>> >> -
>> >> >>>
>> >> >>> git whatchanged 0.3...HEAD
>> --date=iso
>> >> >>>
>> >> >>> I also checked the source code of
>> the
>> >> changelog and it is
>> >> >>> using the
>> >> >>> following method-
>> >> >>>
>> >> >>> changeLog(ScmRepository repository,
>> ScmFileSet
>> >> fileSet,
>> >> >>> ScmVersion
>> >> >>> startVersion, ScmVersion endVersion)
>> >> >>> http://maven.apache.org/scm/projects/apidocs/org/apache/maven/scm/provider/ScmProvider.html#changeLog(org.apache.maven.scm.repository.ScmRepository,%20org.apache.maven.scm.ScmFileSet,%20org.apache.maven.scm.ScmVersion,%20org.apache.maven.scm.ScmVersion)
>> >> >>>
>> >> >>> Which IMHO, is the correct one to
>> use. I will
>> >> try to check
>> >> >>> the gitexe
>> >> >>> code today to see whether I can fix
>> it or not.
>> >> Please let
>> >> >>> me know what
>> >> >>> you think about the problem.
>> >> >>>
>> >> >>> Thank you,
>> >> >>>
>> >> >>> --
>> >> >>> Imran M Yousuf
>> >> >>> Entrepreneur & Software Engineer
>> >> >>> Smart IT Engineering
>> >> >>> Dhaka, Bangladesh
>> >> >>> Email: imran@...
>> >> >>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> >> >>> Mobile: +880-1711402557
>> >> >>>
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Imran M Yousuf
>> >> > Entrepreneur & Software Engineer
>> >> > Smart IT Engineering
>> >> > Dhaka, Bangladesh
>> >> > Email: imran@...
>> >> > Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> >> > Mobile: +880-1711402557
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Imran M Yousuf
>> >> Entrepreneur & Software Engineer
>> >> Smart IT Engineering
>> >> Dhaka, Bangladesh
>> >> Email: imran@...
>> >> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> >> Mobile: +880-1711402557
>> >>
>> >
>> >
>> >
>> >
>>
>>
>>
>> --
>> Imran M Yousuf
>> Entrepreneur & Software Engineer
>> Smart IT Engineering
>> Dhaka, Bangladesh
>> Email: imran@...
>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> Mobile: +880-1711402557
>>
>
>
>
>

--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@...
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

Re: A probable bug in git scm provider for maven-scm-plugin

2009-04-01T00:48:26Z

cool, I've attached a patch in SCM-454.
Can you please test this?

txs and LieGrue,
strub

--- Imran M Yousuf <imyousuf@...> schrieb am Mi, 1.4.2009:

> Von: Imran M Yousuf <imyousuf@...>
> Betreff: Re: A probable bug in git scm provider for maven-scm-plugin
> An: scm-dev@...
> Datum: Mittwoch, 1. April 2009, 9:45
> On Wed, Apr 1, 2009 at 12:39 PM, Mark
> Struberg <struberg@...>
> wrote:
> >
> > Hi Imran!
> >
> > I did almost the same changes yesterday evening, but
> hadn't got a chance to send them yet them.
> >
> > I've additionally added the missing branch handling
> and will add the patch to the corresponding JIRA.
> >
>
> Great, let me know when its in trunk, I will update and
> test it.
>
> Thank you,
>
> Imran
>
> > LieGrue,
> > strub
> >
> > --- Imran M Yousuf <imyousuf@...>
> schrieb am Mi, 1.4.2009:
> >
> >> Von: Imran M Yousuf <imyousuf@...>
> >> Betreff: Re: A probable bug in git scm provider
> for maven-scm-plugin
> >> An: scm-dev@...
> >> CC: "Mark Struberg" <struberg@...>
> >> Datum: Mittwoch, 1. April 2009, 6:50
> >> Hi,
> >>
> >> I have made the required changes to gitexe
> implementation
> >> and
> >> corresponding test case and also tested it with my
> scenario
> >> and it
> >> works fine. Please have a look at it and let me
> know what
> >> you think.
> >>
> >> Best regards,
> >>
> >> Imran
> >>
> >> On Tue, Mar 31, 2009 at 3:39 PM, Imran M Yousuf
> <imyousuf@...>
> >> wrote:
> >> > On Tue, Mar 31, 2009 at 2:57 PM, Mark
> Struberg <struberg@...>
> >> wrote:
> >> >>
> >> >> Hi Imran!
> >> >>
> >> >> I recently changed the command back from
> git-log
> >> to git-whatchanged because I originally programmed
> the
> >> output consumer to fit git-whatchanged. Don't know
> anymore
> >> when we did this, but the git-log output hasn't
> been
> >> parseable with the GitLogConsumer for a while :(
> >> >>
> >> >> From the man git-whatchanged
> (git-1.6.0.6) --since
> >> should be supported:
> >> >>> git whatchanged --since="2 weeks ago"
> -- gitk
> >> >>
> >> >
> >> > Right, this is an example in the man pages,
> but as I
> >> said --since
> >> > expects date or date like expressions
> (probably) but
> >> not tags or
> >> > revision sha1. I have tried it several times
> >> unfortunately and that
> >> > also with both 1.5.6 and 1.6.2.1.
> >> >
> >> > Please let me know what you think about the
> changes I
> >> sent you,
> >> > because I believe they will solve the issue.
> >> >
> >> > Thank you,
> >> >
> >> > Imran
> >> >
> >> >> If you look at the git code it should
> take the
> >> --since and --until!
> >> >> This is also backed up with the comment
> in the man
> >> page:
> >> >>> The command internally invokes
> git-rev-list
> >> piped to
> >> >>> git-diff-tree, and takes command line
> options
> >> for both
> >> >>> of these commands.
> >> >>
> >> >> So imho --since and --until should work.
> >> >>
> >> >> Can you please try the git-whatchanged on
> the
> >> commandline again and play with the since date to
> see if the
> >> output changes? - txs!
> >> >>
> >> >> But maybe we trapped another error the
> code
> >> suffers from!
> >> >>
> >> >> LieGrue,
> >> >> strub
> >> >>
> >> >>
> >> >> --- Imran M Yousuf <imyousuf@...>
> >> schrieb am Di, 31.3.2009:
> >> >>
> >> >>> Von: Imran M Yousuf <imyousuf@...>
> >> >>> Betreff: A probable bug in git scm
> provider
> >> for maven-scm-plugin
> >> >>> An: scm-dev@...
> >> >>> CC: struberg@...
> >> >>> Datum: Dienstag, 31. März 2009,
> 6:17
> >> >>> Hi,
> >> >>>
> >> >>> When I use the
> <type>tag</type> in
> >> changelog
> >> >>> configuration (its at the
> >> >>> end of the email), it uses the
> following query
> >> for
> >> >>> generating the
> >> >>> changeset -
> >> >>>
> >> >>> git whatchanged --since=0.3
> --until=HEAD
> >> --date=iso
> >> >>>
> >> >>> While 'git help whatchanged' says
> nothing
> >> about '--since'
> >> >>> but the 'git
> >> >>> help log' says that '--since' is to
> be a date,
> >> thus IMHO,
> >> >>> the
> >> >>> implementation should have been
> something like
> >> -
> >> >>>
> >> >>> git whatchanged 0.3...HEAD
> --date=iso
> >> >>>
> >> >>> I also checked the source code of
> the
> >> changelog and it is
> >> >>> using the
> >> >>> following method-
> >> >>>
> >> >>> changeLog(ScmRepository repository,
> ScmFileSet
> >> fileSet,
> >> >>> ScmVersion
> >> >>> startVersion, ScmVersion endVersion)
> >> >>> http://maven.apache.org/scm/projects/apidocs/org/apache/maven/scm/provider/ScmProvider.html#changeLog(org.apache.maven.scm.repository.ScmRepository,%20org.apache.maven.scm.ScmFileSet,%20org.apache.maven.scm.ScmVersion,%20org.apache.maven.scm.ScmVersion)
> >> >>>
> >> >>> Which IMHO, is the correct one to
> use. I will
> >> try to check
> >> >>> the gitexe
> >> >>> code today to see whether I can fix
> it or not.
> >> Please let
> >> >>> me know what
> >> >>> you think about the problem.
> >> >>>
> >> >>> Thank you,
> >> >>>
> >> >>> --
> >> >>> Imran M Yousuf
> >> >>> Entrepreneur & Software Engineer
> >> >>> Smart IT Engineering
> >> >>> Dhaka, Bangladesh
> >> >>> Email: imran@...
> >> >>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> >> >>> Mobile: +880-1711402557
> >> >>>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Imran M Yousuf
> >> > Entrepreneur & Software Engineer
> >> > Smart IT Engineering
> >> > Dhaka, Bangladesh
> >> > Email: imran@...
> >> > Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> >> > Mobile: +880-1711402557
> >> >
> >>
> >>
> >>
> >> --
> >> Imran M Yousuf
> >> Entrepreneur & Software Engineer
> >> Smart IT Engineering
> >> Dhaka, Bangladesh
> >> Email: imran@...
> >> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> >> Mobile: +880-1711402557
> >>
> >
> >
> >
> >
>
>
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

Re: A probable bug in git scm provider for maven-scm-plugin

2009-04-01T00:45:55Z

On Wed, Apr 1, 2009 at 12:39 PM, Mark Struberg <struberg@...> wrote:
>
> Hi Imran!
>
> I did almost the same changes yesterday evening, but hadn't got a chance to send them yet them.
>
> I've additionally added the missing branch handling and will add the patch to the corresponding JIRA.
>

Great, let me know when its in trunk, I will update and test it.

Thank you,

Imran

> LieGrue,
> strub
>
> --- Imran M Yousuf <imyousuf@...> schrieb am Mi, 1.4.2009:
>
>> Von: Imran M Yousuf <imyousuf@...>
>> Betreff: Re: A probable bug in git scm provider for maven-scm-plugin
>> An: scm-dev@...
>> CC: "Mark Struberg" <struberg@...>
>> Datum: Mittwoch, 1. April 2009, 6:50
>> Hi,
>>
>> I have made the required changes to gitexe implementation
>> and
>> corresponding test case and also tested it with my scenario
>> and it
>> works fine. Please have a look at it and let me know what
>> you think.
>>
>> Best regards,
>>
>> Imran
>>
>> On Tue, Mar 31, 2009 at 3:39 PM, Imran M Yousuf <imyousuf@...>
>> wrote:
>> > On Tue, Mar 31, 2009 at 2:57 PM, Mark Struberg <struberg@...>
>> wrote:
>> >>
>> >> Hi Imran!
>> >>
>> >> I recently changed the command back from git-log
>> to git-whatchanged because I originally programmed the
>> output consumer to fit git-whatchanged. Don't know anymore
>> when we did this, but the git-log output hasn't been
>> parseable with the GitLogConsumer for a while :(
>> >>
>> >> From the man git-whatchanged (git-1.6.0.6) --since
>> should be supported:
>> >>> git whatchanged --since="2 weeks ago" -- gitk
>> >>
>> >
>> > Right, this is an example in the man pages, but as I
>> said --since
>> > expects date or date like expressions (probably) but
>> not tags or
>> > revision sha1. I have tried it several times
>> unfortunately and that
>> > also with both 1.5.6 and 1.6.2.1.
>> >
>> > Please let me know what you think about the changes I
>> sent you,
>> > because I believe they will solve the issue.
>> >
>> > Thank you,
>> >
>> > Imran
>> >
>> >> If you look at the git code it should take the
>> --since and --until!
>> >> This is also backed up with the comment in the man
>> page:
>> >>> The command internally invokes git-rev-list
>> piped to
>> >>> git-diff-tree, and takes command line options
>> for both
>> >>> of these commands.
>> >>
>> >> So imho --since and --until should work.
>> >>
>> >> Can you please try the git-whatchanged on the
>> commandline again and play with the since date to see if the
>> output changes? - txs!
>> >>
>> >> But maybe we trapped another error the code
>> suffers from!
>> >>
>> >> LieGrue,
>> >> strub
>> >>
>> >>
>> >> --- Imran M Yousuf <imyousuf@...>
>> schrieb am Di, 31.3.2009:
>> >>
>> >>> Von: Imran M Yousuf <imyousuf@...>
>> >>> Betreff: A probable bug in git scm provider
>> for maven-scm-plugin
>> >>> An: scm-dev@...
>> >>> CC: struberg@...
>> >>> Datum: Dienstag, 31. März 2009, 6:17
>> >>> Hi,
>> >>>
>> >>> When I use the <type>tag</type> in
>> changelog
>> >>> configuration (its at the
>> >>> end of the email), it uses the following query
>> for
>> >>> generating the
>> >>> changeset -
>> >>>
>> >>> git whatchanged --since=0.3 --until=HEAD
>> --date=iso
>> >>>
>> >>> While 'git help whatchanged' says nothing
>> about '--since'
>> >>> but the 'git
>> >>> help log' says that '--since' is to be a date,
>> thus IMHO,
>> >>> the
>> >>> implementation should have been something like
>> -
>> >>>
>> >>> git whatchanged 0.3...HEAD --date=iso
>> >>>
>> >>> I also checked the source code of the
>> changelog and it is
>> >>> using the
>> >>> following method-
>> >>>
>> >>> changeLog(ScmRepository repository, ScmFileSet
>> fileSet,
>> >>> ScmVersion
>> >>> startVersion, ScmVersion endVersion)
>> >>> http://maven.apache.org/scm/projects/apidocs/org/apache/maven/scm/provider/ScmProvider.html#changeLog(org.apache.maven.scm.repository.ScmRepository,%20org.apache.maven.scm.ScmFileSet,%20org.apache.maven.scm.ScmVersion,%20org.apache.maven.scm.ScmVersion)
>> >>>
>> >>> Which IMHO, is the correct one to use. I will
>> try to check
>> >>> the gitexe
>> >>> code today to see whether I can fix it or not.
>> Please let
>> >>> me know what
>> >>> you think about the problem.
>> >>>
>> >>> Thank you,
>> >>>
>> >>> --
>> >>> Imran M Yousuf
>> >>> Entrepreneur & Software Engineer
>> >>> Smart IT Engineering
>> >>> Dhaka, Bangladesh
>> >>> Email: imran@...
>> >>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> >>> Mobile: +880-1711402557
>> >>>
>> >>
>> >>
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Imran M Yousuf
>> > Entrepreneur & Software Engineer
>> > Smart IT Engineering
>> > Dhaka, Bangladesh
>> > Email: imran@...
>> > Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> > Mobile: +880-1711402557
>> >
>>
>>
>>
>> --
>> Imran M Yousuf
>> Entrepreneur & Software Engineer
>> Smart IT Engineering
>> Dhaka, Bangladesh
>> Email: imran@...
>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> Mobile: +880-1711402557
>>
>
>
>
>

--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@...
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

Re: A probable bug in git scm provider for maven-scm-plugin

2009-03-31T23:39:42Z

Hi Imran!

I did almost the same changes yesterday evening, but hadn't got a chance to send them yet them.

I've additionally added the missing branch handling and will add the patch to the corresponding JIRA.

LieGrue,
strub

--- Imran M Yousuf <imyousuf@...> schrieb am Mi, 1.4.2009:

> Von: Imran M Yousuf <imyousuf@...>
> Betreff: Re: A probable bug in git scm provider for maven-scm-plugin
> An: scm-dev@...
> CC: "Mark Struberg" <struberg@...>
> Datum: Mittwoch, 1. April 2009, 6:50
> Hi,
>
> I have made the required changes to gitexe implementation
> and
> corresponding test case and also tested it with my scenario
> and it
> works fine. Please have a look at it and let me know what
> you think.
>
> Best regards,
>
> Imran
>
> On Tue, Mar 31, 2009 at 3:39 PM, Imran M Yousuf <imyousuf@...>
> wrote:
> > On Tue, Mar 31, 2009 at 2:57 PM, Mark Struberg <struberg@...>
> wrote:
> >>
> >> Hi Imran!
> >>
> >> I recently changed the command back from git-log
> to git-whatchanged because I originally programmed the
> output consumer to fit git-whatchanged. Don't know anymore
> when we did this, but the git-log output hasn't been
> parseable with the GitLogConsumer for a while :(
> >>
> >> From the man git-whatchanged (git-1.6.0.6) --since
> should be supported:
> >>> git whatchanged --since="2 weeks ago" -- gitk
> >>
> >
> > Right, this is an example in the man pages, but as I
> said --since
> > expects date or date like expressions (probably) but
> not tags or
> > revision sha1. I have tried it several times
> unfortunately and that
> > also with both 1.5.6 and 1.6.2.1.
> >
> > Please let me know what you think about the changes I
> sent you,
> > because I believe they will solve the issue.
> >
> > Thank you,
> >
> > Imran
> >
> >> If you look at the git code it should take the
> --since and --until!
> >> This is also backed up with the comment in the man
> page:
> >>> The command internally invokes git-rev-list
> piped to
> >>> git-diff-tree, and takes command line options
> for both
> >>> of these commands.
> >>
> >> So imho --since and --until should work.
> >>
> >> Can you please try the git-whatchanged on the
> commandline again and play with the since date to see if the
> output changes? - txs!
> >>
> >> But maybe we trapped another error the code
> suffers from!
> >>
> >> LieGrue,
> >> strub
> >>
> >>
> >> --- Imran M Yousuf <imyousuf@...>
> schrieb am Di, 31.3.2009:
> >>
> >>> Von: Imran M Yousuf <imyousuf@...>
> >>> Betreff: A probable bug in git scm provider
> for maven-scm-plugin
> >>> An: scm-dev@...
> >>> CC: struberg@...
> >>> Datum: Dienstag, 31. März 2009, 6:17
> >>> Hi,
> >>>
> >>> When I use the <type>tag</type> in
> changelog
> >>> configuration (its at the
> >>> end of the email), it uses the following query
> for
> >>> generating the
> >>> changeset -
> >>>
> >>> git whatchanged --since=0.3 --until=HEAD
> --date=iso
> >>>
> >>> While 'git help whatchanged' says nothing
> about '--since'
> >>> but the 'git
> >>> help log' says that '--since' is to be a date,
> thus IMHO,
> >>> the
> >>> implementation should have been something like
> -
> >>>
> >>> git whatchanged 0.3...HEAD --date=iso
> >>>
> >>> I also checked the source code of the
> changelog and it is
> >>> using the
> >>> following method-
> >>>
> >>> changeLog(ScmRepository repository, ScmFileSet
> fileSet,
> >>> ScmVersion
> >>> startVersion, ScmVersion endVersion)
> >>> http://maven.apache.org/scm/projects/apidocs/org/apache/maven/scm/provider/ScmProvider.html#changeLog(org.apache.maven.scm.repository.ScmRepository,%20org.apache.maven.scm.ScmFileSet,%20org.apache.maven.scm.ScmVersion,%20org.apache.maven.scm.ScmVersion)
> >>>
> >>> Which IMHO, is the correct one to use. I will
> try to check
> >>> the gitexe
> >>> code today to see whether I can fix it or not.
> Please let
> >>> me know what
> >>> you think about the problem.
> >>>
> >>> Thank you,
> >>>
> >>> --
> >>> Imran M Yousuf
> >>> Entrepreneur & Software Engineer
> >>> Smart IT Engineering
> >>> Dhaka, Bangladesh
> >>> Email: imran@...
> >>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> >>> Mobile: +880-1711402557
> >>>
> >>
> >>
> >>
> >>
> >
> >
> >
> > --
> > Imran M Yousuf
> > Entrepreneur & Software Engineer
> > Smart IT Engineering
> > Dhaka, Bangladesh
> > Email: imran@...
> > Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> > Mobile: +880-1711402557
> >
>
>
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

Re: A probable bug in git scm provider for maven-scm-plugin

2009-03-31T21:50:58Z

Hi,

I have made the required changes to gitexe implementation and
corresponding test case and also tested it with my scenario and it
works fine. Please have a look at it and let me know what you think.

Best regards,

Imran

On Tue, Mar 31, 2009 at 3:39 PM, Imran M Yousuf <imyousuf@...> wrote:

> On Tue, Mar 31, 2009 at 2:57 PM, Mark Struberg <struberg@...> wrote:
>>
>> Hi Imran!
>>
>> I recently changed the command back from git-log to git-whatchanged because I originally programmed the output consumer to fit git-whatchanged. Don't know anymore when we did this, but the git-log output hasn't been parseable with the GitLogConsumer for a while :(
>>
>> From the man git-whatchanged (git-1.6.0.6) --since should be supported:
>>> git whatchanged --since="2 weeks ago" -- gitk
>>
>
> Right, this is an example in the man pages, but as I said --since
> expects date or date like expressions (probably) but not tags or
> revision sha1. I have tried it several times unfortunately and that
> also with both 1.5.6 and 1.6.2.1.
>
> Please let me know what you think about the changes I sent you,
> because I believe they will solve the issue.
>
> Thank you,
>
> Imran
>
>> If you look at the git code it should take the --since and --until!
>> This is also backed up with the comment in the man page:
>>> The command internally invokes git-rev-list piped to
>>> git-diff-tree, and takes command line options for both
>>> of these commands.
>>
>> So imho --since and --until should work.
>>
>> Can you please try the git-whatchanged on the commandline again and play with the since date to see if the output changes? - txs!
>>
>> But maybe we trapped another error the code suffers from!
>>
>> LieGrue,
>> strub
>>
>>
>> --- Imran M Yousuf <imyousuf@...> schrieb am Di, 31.3.2009:
>>
>>> Von: Imran M Yousuf <imyousuf@...>
>>> Betreff: A probable bug in git scm provider for maven-scm-plugin
>>> An: scm-dev@...
>>> CC: struberg@...
>>> Datum: Dienstag, 31. März 2009, 6:17
>>> Hi,
>>>
>>> When I use the <type>tag</type> in changelog
>>> configuration (its at the
>>> end of the email), it uses the following query for
>>> generating the
>>> changeset -
>>>
>>> git whatchanged --since=0.3 --until=HEAD --date=iso
>>>
>>> While 'git help whatchanged' says nothing about '--since'
>>> but the 'git
>>> help log' says that '--since' is to be a date, thus IMHO,
>>> the
>>> implementation should have been something like -
>>>
>>> git whatchanged 0.3...HEAD --date=iso
>>>
>>> I also checked the source code of the changelog and it is
>>> using the
>>> following method-
>>>
>>> changeLog(ScmRepository repository, ScmFileSet fileSet,
>>> ScmVersion
>>> startVersion, ScmVersion endVersion)
>>> http://maven.apache.org/scm/projects/apidocs/org/apache/maven/scm/provider/ScmProvider.html#changeLog(org.apache.maven.scm.repository.ScmRepository,%20org.apache.maven.scm.ScmFileSet,%20org.apache.maven.scm.ScmVersion,%20org.apache.maven.scm.ScmVersion)
>>>
>>> Which IMHO, is the correct one to use. I will try to check
>>> the gitexe
>>> code today to see whether I can fix it or not. Please let
>>> me know what
>>> you think about the problem.
>>>
>>> Thank you,
>>>
>>> --
>>> Imran M Yousuf
>>> Entrepreneur & Software Engineer
>>> Smart IT Engineering
>>> Dhaka, Bangladesh
>>> Email: imran@...
>>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>>> Mobile: +880-1711402557
>>>
>>
>>
>>
>>
>
>
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

Re: accurev provider

2009-03-31T07:56:19Z

Do the authors of the original provider, or other users here, have an
opinion on this? I like that it is more complete (functionally, and in
docs and tests), however am not an accurev user myself.

What effect does the URL syntax change have?

Also Grant, I haven't seen the CLA yet?

- Brett

On 17/03/2009, at 11:58 PM, Grant Gardner wrote:

>
>
> I've created the jira with attached code. Let me know if there's
> anything
> else I need to do.
> http://jira.codehaus.org/browse/SCM-445
>
> Will do the CLA when I find myself conveniently located near a fax or
> scanner.
>
> On Mon, 9 Mar 2009 05:02:15 +1100, Brett Porter <brett@...>
> wrote:
>> 1) Create a JIRA ticket under SCM
>> 2) you might like to submit a CLA - you can do it regardless, and if
>> the work is accepted such a large chunk would probably require it
>> (see
>> http://www.apache.org/licenses/
>> and specifically http://www.apache.org/licenses/icla.txt)
>>
>> Thanks!
>>
>> - Brett
>>
>> On 07/03/2009, at 12:50 PM, Grant Gardner wrote:
>>
>>>
>>>
>>> Hi, I've got my AccuRev provider to a point where both the release
>>> plugin
>>> and Continuum are working (for me).
>>>
>>> Includes unit tests and tck tests for all the implemented commands.
>>>
>>> How do I go about contributing the code?.
>>>
>>> Grant.
>>>
>>>
>>
>> --
>> Brett Porter
>> brett@...
>> http://blogs.exist.com/bporter/

Re: A probable bug in git scm provider for maven-scm-plugin

2009-03-31T02:39:25Z

On Tue, Mar 31, 2009 at 2:57 PM, Mark Struberg <struberg@...> wrote:
>
> Hi Imran!
>
> I recently changed the command back from git-log to git-whatchanged because I originally programmed the output consumer to fit git-whatchanged. Don't know anymore when we did this, but the git-log output hasn't been parseable with the GitLogConsumer for a while :(
>
> From the man git-whatchanged (git-1.6.0.6) --since should be supported:
>> git whatchanged --since="2 weeks ago" -- gitk
>

Right, this is an example in the man pages, but as I said --since
expects date or date like expressions (probably) but not tags or
revision sha1. I have tried it several times unfortunately and that
also with both 1.5.6 and 1.6.2.1.

Please let me know what you think about the changes I sent you,
because I believe they will solve the issue.

Thank you,

Imran

> If you look at the git code it should take the --since and --until!
> This is also backed up with the comment in the man page:
>> The command internally invokes git-rev-list piped to
>> git-diff-tree, and takes command line options for both
>> of these commands.
>
> So imho --since and --until should work.
>
> Can you please try the git-whatchanged on the commandline again and play with the since date to see if the output changes? - txs!
>
> But maybe we trapped another error the code suffers from!
>
> LieGrue,
> strub
>
>
> --- Imran M Yousuf <imyousuf@...> schrieb am Di, 31.3.2009:
>
>> Von: Imran M Yousuf <imyousuf@...>
>> Betreff: A probable bug in git scm provider for maven-scm-plugin
>> An: scm-dev@...
>> CC: struberg@...
>> Datum: Dienstag, 31. März 2009, 6:17
>> Hi,
>>
>> When I use the <type>tag</type> in changelog
>> configuration (its at the
>> end of the email), it uses the following query for
>> generating the
>> changeset -
>>
>> git whatchanged --since=0.3 --until=HEAD --date=iso
>>
>> While 'git help whatchanged' says nothing about '--since'
>> but the 'git
>> help log' says that '--since' is to be a date, thus IMHO,
>> the
>> implementation should have been something like -
>>
>> git whatchanged 0.3...HEAD --date=iso
>>
>> I also checked the source code of the changelog and it is
>> using the
>> following method-
>>
>> changeLog(ScmRepository repository, ScmFileSet fileSet,
>> ScmVersion
>> startVersion, ScmVersion endVersion)
>> http://maven.apache.org/scm/projects/apidocs/org/apache/maven/scm/provider/ScmProvider.html#changeLog(org.apache.maven.scm.repository.ScmRepository,%20org.apache.maven.scm.ScmFileSet,%20org.apache.maven.scm.ScmVersion,%20org.apache.maven.scm.ScmVersion)
>>
>> Which IMHO, is the correct one to use. I will try to check
>> the gitexe
>> code today to see whether I can fix it or not. Please let
>> me know what
>> you think about the problem.
>>
>> Thank you,
>>
>> --
>> Imran M Yousuf
>> Entrepreneur & Software Engineer
>> Smart IT Engineering
>> Dhaka, Bangladesh
>> Email: imran@...
>> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
>> Mobile: +880-1711402557
>>
>
>
>
>

--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@...
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

Re: NPE with maven-changelog-plugin and git

2009-03-31T01:59:04Z

Thanks Imran!

Good to hear it works for you now!

The question to me is still: wtf, why is this happening? :)

LieGrue,
strub

--- Imran M Yousuf <imyousuf@...> schrieb am Di, 31.3.2009:

> Von: Imran M Yousuf <imyousuf@...>
> Betreff: Re: NPE with maven-changelog-plugin and git
> An: scm-dev@...
> Datum: Dienstag, 31. März 2009, 6:20
> On Mon, Mar 30, 2009 at 5:23 PM, Mark
> Struberg <struberg@...>
> wrote:
> >
> > Hi Imran!
> >
> > Having only looked over your log quickly, it seems to
> me that this is not a git-scm problem:
> >
> >> java.lang.NoSuchMethodError:
> org.codehaus.plexus.util.cli.Commandline.createArg()Lorg/codehaus/plexus/util/cli/Arg;
> >>
> org.apache.maven.scm.provider.git.gitexe.command.GitCommandLineUtils.getBaseGitCommandLine(GitCommandLineUtils.java:82)
> >
> > Looks like this function is not in the
> plexus-utils-1.1 the changelog uses in your setup?
> >> [DEBUG]
> org.codehaus.plexus:plexus-utils:jar:1.5.6:compile (removed
> - nearer found: 1.1)
> > hmm, why does it take the 1.1 instead of the 1.5.6?
> Idea, anyone?
> >
>
> Hi Mark!
>
> If I add the following to the plugin -
>
> <dependency>
>
>
> <groupId>org.codehaus.plexus</groupId>
>
>
> <artifactId>plexus-utils</artifactId>
>
>
> <version>${plexus-utils.version}</version>
>
> </dependency>
>
> Where verison is 1.5.6 it works fine with both 2.1 and the
> 2.2-SNAPSHOT and I can exclude the gitexe as dependency
> from the
> plugin.
>
> Thanks,
>
> Imran
>
>
> >
> > LieGrue,
> > strub
> >
> >
> >
> > --- Imran M Yousuf <imyousuf@...>
> schrieb am Mo, 30.3.2009:
> >
> >> Von: Imran M Yousuf <imyousuf@...>
> >> Betreff: NPE with maven-changelog-plugin and git
> >> An: scm-dev@...
> >> Datum: Montag, 30. März 2009, 4:55
> >> Hi,
> >>
> >> I am getting NPE when I issue the following
> >> configuration and
> >> command 'mvn changelog:changelog' in scm version
> 1.1. When
> >> I use scm
> >> verison 1.2 I get No Such Method Error. I am
> pretty sure I
> >> am doing
> >> something wrong but I am unable to determine it.
> Please
> >> help! I have
> >> attached the relevant outputs as attachment -
> >> git-log.out - Output of the git log command issued
> to build
> >> the log
> >> maven-changelog-npe.out - Output including debug
> info for
> >> the NPE
> >> maven-scm-error-1.2.out - No such method error
> with 1.2.
> >>
> >> I am compressing them to reduce the size of the
> attachment.
> >> I would be
> >> deeply grateful if you would be kind enough to
> point me in
> >> right
> >> direction.
> >>
> >>
> >> <scm>
> >>
> >>
> <connection>scm:git:git://repo.or.cz/smart-dao.git</connection>
> >>
> >> <developerConnection>scm:git:ssh://imyousuf@.../srv/git/smart-dao.git</developerConnection>
> >> </scm>
> >>
> >> <plugin>
> >>
> >>
> <groupId>org.apache.maven.plugins</groupId>
> >>
> >>
> <artifactId>maven-scm-plugin</artifactId>
> >>
> >> <version>${scm.version}</version>
> >> </plugin>
> >> <plugin>
> >>
> >>
> <groupId>org.apache.maven.plugins</groupId>
> >>
> >>
> <artifactId>maven-changelog-plugin</artifactId>
> >>
> >> <version>2.1</version>
> >>
> >> <dependencies>
> >>
> >> <dependency>
> >>
> >>
> >>
> <groupId>org.apache.maven.scm</groupId>
> >>
> >>
> >>
> <artifactId>maven-scm-provider-gitexe</artifactId>
> >>
> >>
> >> <version>${scm.version}</version>
> >>
> >> </dependency>
> >>
> >> </dependencies>
> >> </plugin>
> >> <properties>
> >>
> >>
> <commons-lang.version>2.3</commons-lang.version>
> >>
> >>
> <smart-util.version>0.2-SNAPSHOT</smart-util.version>
> >>
> >>
> <jgit.version>0.4-SNAPSHOT</jgit.version>
> >>
> >> <scm.version>1.1</scm.version>
> >> </properties>
> >>
> >> Thank you,
> >>
> >> --
> >> Imran M Yousuf
> >> Entrepreneur & Software Engineer
> >> Smart IT Engineering
> >> Dhaka, Bangladesh
> >> Email: imran@...
> >> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> >> Mobile: +880-1711402557
> >>
> >
> >
> >
> >
>
>
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

AW: A probable bug in git scm provider for maven-scm-plugin

2009-03-31T01:57:21Z

Hi Imran!

I recently changed the command back from git-log to git-whatchanged because I originally programmed the output consumer to fit git-whatchanged. Don't know anymore when we did this, but the git-log output hasn't been parseable with the GitLogConsumer for a while :(

From the man git-whatchanged (git-1.6.0.6) --since should be supported:
> git whatchanged --since="2 weeks ago" -- gitk

If you look at the git code it should take the --since and --until!
This is also backed up with the comment in the man page:
> The command internally invokes git-rev-list piped to
> git-diff-tree, and takes command line options for both
> of these commands.

So imho --since and --until should work.

Can you please try the git-whatchanged on the commandline again and play with the since date to see if the output changes? - txs!

But maybe we trapped another error the code suffers from!

LieGrue,
strub

--- Imran M Yousuf <imyousuf@...> schrieb am Di, 31.3.2009:

> Von: Imran M Yousuf <imyousuf@...>
> Betreff: A probable bug in git scm provider for maven-scm-plugin
> An: scm-dev@...
> CC: struberg@...
> Datum: Dienstag, 31. März 2009, 6:17
> Hi,
>
> When I use the <type>tag</type> in changelog
> configuration (its at the
> end of the email), it uses the following query for
> generating the
> changeset -
>
> git whatchanged --since=0.3 --until=HEAD --date=iso
>
> While 'git help whatchanged' says nothing about '--since'
> but the 'git
> help log' says that '--since' is to be a date, thus IMHO,
> the
> implementation should have been something like -
>
> git whatchanged 0.3...HEAD --date=iso
>
> I also checked the source code of the changelog and it is
> using the
> following method-
>
> changeLog(ScmRepository repository, ScmFileSet fileSet,
> ScmVersion
> startVersion, ScmVersion endVersion)
> http://maven.apache.org/scm/projects/apidocs/org/apache/maven/scm/provider/ScmProvider.html#changeLog(org.apache.maven.scm.repository.ScmRepository,%20org.apache.maven.scm.ScmFileSet,%20org.apache.maven.scm.ScmVersion,%20org.apache.maven.scm.ScmVersion)
>
> Which IMHO, is the correct one to use. I will try to check
> the gitexe
> code today to see whether I can fix it or not. Please let
> me know what
> you think about the problem.
>
> Thank you,
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

Re: A probable bug in git scm provider for maven-scm-plugin

2009-03-30T21:57:43Z

On Tue, Mar 31, 2009 at 10:17 AM, Imran M Yousuf <imyousuf@...> wrote:

> Hi,
>
> When I use the <type>tag</type> in changelog configuration (its at the
> end of the email), it uses the following query for generating the
> changeset -
>
> git whatchanged --since=0.3 --until=HEAD --date=iso
>
> While 'git help whatchanged' says nothing about '--since' but the 'git
> help log' says that '--since' is to be a date, thus IMHO, the
> implementation should have been something like -
>
> git whatchanged 0.3...HEAD --date=iso
>
> I also checked the source code of the changelog and it is using the
> following method-
>
> changeLog(ScmRepository repository, ScmFileSet fileSet, ScmVersion
> startVersion, ScmVersion endVersion)
> http://maven.apache.org/scm/projects/apidocs/org/apache/maven/scm/provider/ScmProvider.html#changeLog(org.apache.maven.scm.repository.ScmRepository,%20org.apache.maven.scm.ScmFileSet,%20org.apache.maven.scm.ScmVersion,%20org.apache.maven.scm.ScmVersion)
>
> Which IMHO, is the correct one to use. I will try to check the gitexe
> code today to see whether I can fix it or not. Please let me know what
> you think about the problem.
>

I already worked on it but was not able to compile and test it, but
this is just for RFC. Please have a look and let me know what you
think. I missed the configuration that caused the error adding it as
follows:

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-changelog-plugin</artifactId>
<version>${changelog.version}</version>
<inherited>false</inherited>
<dependencies>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
<version>${plexus-utils.version}</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>attach-changelog</id>
<phase>install</phase>
<goals>
<goal>changelog</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
<reporting>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-changelog-plugin</artifactId>
<version>${changelog.version}</version>
<configuration>
<type>tag</type>
<tags>
<tag implementation="java.lang.String">0.3
</tag>
<tag implementation="java.lang.String">HEAD
</tag>
</tags>
</configuration>
</plugin>
</plugins>
</reporting>

Thank you,

Imran

> Thank you,
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>

--
Imran M Yousuf
Entrepreneur & Software Engineer
Smart IT Engineering
Dhaka, Bangladesh
Email: imran@...
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557

113c113
< if ( startVersion != null || endVersion != null )
---
> if ( startVersion != null )
115,124c115
< StringBuilder builder = new StringBuilder();
< if ( startVersion != null ) {
< builder.append(startVersion.getName());
< builder.append("...");
< }
< if ( endVersion != null )
< {
< builder.append(endVersion.getName());
< }
< cl.createArg().setValue( StringUtils.escape( builder.toString() ) );
---
> cl.createArg().setValue( "--since=" + StringUtils.escape( startVersion.getName() ) );
131a123,130
> }
>
> if ( endVersion != null )
> {
> cl.createArg().setValue( "--until=" + StringUtils.escape( endVersion.getName() ) );
> }
> else
> {
138d136
<

[GitChangeLogCommand.java]

package org.apache.maven.scm.provider.git.gitexe.command.changelog; /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */ import org.apache.maven.scm.ScmBranch; import org.apache.maven.scm.ScmException; import org.apache.maven.scm.ScmFileSet; import org.apache.maven.scm.ScmVersion; import org.apache.maven.scm.command.changelog.AbstractChangeLogCommand; import org.apache.maven.scm.command.changelog.ChangeLogScmResult; import org.apache.maven.scm.command.changelog.ChangeLogSet; import org.apache.maven.scm.provider.ScmProviderRepository; import org.apache.maven.scm.provider.git.command.GitCommand; import org.apache.maven.scm.provider.git.repository.GitScmProviderRepository; import org.apache.maven.scm.provider.git.gitexe.command.GitCommandLineUtils; import org.codehaus.plexus.util.StringUtils; import org.codehaus.plexus.util.cli.CommandLineUtils; import org.codehaus.plexus.util.cli.Commandline; import java.io.File; import java.text.SimpleDateFormat; import java.util.Date; import java.util.TimeZone; /** * @author <a href="mailto:evenisse@...">Emmanuel Venisse</a> * @version $Id: GitChangeLogCommand.java 755014 2009-03-16 21:50:28Z olamy $ */ public class GitChangeLogCommand extends AbstractChangeLogCommand implements GitCommand { private static final String DATE_FORMAT = "yyyy-MM-dd HH:mm:ss Z"; /** {@inheritDoc} */ protected ChangeLogScmResult executeChangeLogCommand( ScmProviderRepository repo, ScmFileSet fileSet, ScmVersion startVersion, ScmVersion endVersion, String datePattern ) throws ScmException { return executeChangeLogCommand( repo, fileSet, null, null, null, datePattern, startVersion, endVersion ); } /** {@inheritDoc} */ protected ChangeLogScmResult executeChangeLogCommand( ScmProviderRepository repo, ScmFileSet fileSet, Date startDate, Date endDate, ScmBranch branch, String datePattern ) throws ScmException { return executeChangeLogCommand( repo, fileSet, startDate, endDate, branch, datePattern, null, null ); } protected ChangeLogScmResult executeChangeLogCommand( ScmProviderRepository repo, ScmFileSet fileSet, Date startDate, Date endDate, ScmBranch branch, String datePattern, ScmVersion startVersion, ScmVersion endVersion ) throws ScmException { Commandline cl = createCommandLine( (GitScmProviderRepository) repo, fileSet.getBasedir(), branch, startDate, endDate, startVersion, endVersion ); GitChangeLogConsumer consumer = new GitChangeLogConsumer( getLogger(), datePattern ); CommandLineUtils.StringStreamConsumer stderr = new CommandLineUtils.StringStreamConsumer(); int exitCode; exitCode = GitCommandLineUtils.execute( cl, consumer, stderr, getLogger() ); if ( exitCode != 0 ) { return new ChangeLogScmResult( cl.toString(), "The git-log command failed.", stderr.getOutput(), false ); } ChangeLogSet changeLogSet = new ChangeLogSet( consumer.getModifications(), startDate, endDate ); changeLogSet.setStartVersion( startVersion ); changeLogSet.setEndVersion( endVersion ); return new ChangeLogScmResult( cl.toString(), changeLogSet ); } // ---------------------------------------------------------------------- // // ---------------------------------------------------------------------- /** * @TODO branch handling */ public static Commandline createCommandLine( GitScmProviderRepository repository, File workingDirectory, ScmBranch branch, Date startDate, Date endDate, ScmVersion startVersion, ScmVersion endVersion ) { SimpleDateFormat dateFormat = new SimpleDateFormat( DATE_FORMAT ); dateFormat.setTimeZone( TimeZone.getTimeZone( "GMT" ) ); Commandline cl = GitCommandLineUtils.getBaseGitCommandLine( workingDirectory, "whatchanged" ); if ( startVersion != null || endVersion != null ) { StringBuilder builder = new StringBuilder(); if ( startVersion != null ) { builder.append(startVersion.getName()); builder.append("..."); } if ( endVersion != null ) { builder.append(endVersion.getName()); } cl.createArg().setValue( StringUtils.escape( builder.toString() ) ); } else { if ( startDate != null ) { cl.createArg().setValue( "--since=" + StringUtils.escape( dateFormat.format( startDate ) ) ); } if ( endDate != null ) { cl.createArg().setValue( "--until=" + StringUtils.escape( dateFormat.format( endDate ) ) ); } } cl.createArg().setValue( "--date=iso" ); return cl; } }